)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dec4fe502317451ce3b111778d7b373be2b8893","unresolved":false,"context_lines":[{"line_number":12,"context_line":"of (in automated cleaning) restarting from the first clean step."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I89726f3b32f96befba9a2e1bee67b2a7cc7eeb57"},{"line_number":15,"context_line":"Implements: blueprint manual-cleaning"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da6ed579_1c8c4e34","line":15,"updated":"2016-01-13 10:49:25.000000000","message":"nit: this should be a bug","commit_id":"811463a8d839270e1701bd3e47d33dfad0eba740"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"177825b8006a10a6fca00a0aa77a617ac191a4d8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"of (in automated cleaning) restarting from the first clean step."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I89726f3b32f96befba9a2e1bee67b2a7cc7eeb57"},{"line_number":15,"context_line":"Implements: blueprint manual-cleaning"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da6ed579_4ca0c643","line":15,"in_reply_to":"da6ed579_1c8c4e34","updated":"2016-01-13 15:19:05.000000000","message":"Yes, I didn\u0027t want to lose jroll\u0027s +2 (from December, before we changed the blueprint/RFE process) just to do this.\n\nI\u0027ll change it if I have to do another revision, and/or maybe whoever +A\u0027s it can update this before +A\u0027ing.","commit_id":"811463a8d839270e1701bd3e47d33dfad0eba740"}],"ironic/conductor/manager.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3cf5666553f9dd06756ce2e6f805a001fb63b625","unresolved":false,"context_lines":[{"line_number":973,"context_line":"                     \u0027clean_state\u0027: states.CLEANWAIT})"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"            skip_step \u003d True"},{"line_number":976,"context_line":"            if node.driver_internal_info.get(\u0027redo_clean_step\u0027, False):"},{"line_number":977,"context_line":"                skip_step \u003d False"},{"line_number":978,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":979,"context_line":"                info.pop(\u0027redo_clean_step\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_25b93aed","line":976,"updated":"2015-11-20 15:55:59.000000000","message":"I don\u0027t like \"redo\" for some reason. \"rerun\"? I guess it doesn\u0027t matter much.","commit_id":"35ced197003b61d7392f980716267bfb320ec45a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"06b2cc21517f172260723308d6ded3ec4e52f3a5","unresolved":false,"context_lines":[{"line_number":973,"context_line":"                     \u0027clean_state\u0027: states.CLEANWAIT})"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"            skip_step \u003d True"},{"line_number":976,"context_line":"            if node.driver_internal_info.get(\u0027redo_clean_step\u0027, False):"},{"line_number":977,"context_line":"                skip_step \u003d False"},{"line_number":978,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":979,"context_line":"                info.pop(\u0027redo_clean_step\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_376285d9","line":976,"in_reply_to":"ba8a016a_25b93aed","updated":"2015-11-23 15:16:40.000000000","message":"Yeah, the problem is that it didn\u0027t even do that clean step. I just need something to say \u0027don\u0027t skip this step\u0027 but I don\u0027t like using terms with negation in them. I will set a timer for some minutes and brainstorm :)","commit_id":"35ced197003b61d7392f980716267bfb320ec45a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"424d0cd3f63f04faf553cfaf8fff203900d687e3","unresolved":false,"context_lines":[{"line_number":973,"context_line":"                     \u0027clean_state\u0027: states.CLEANWAIT})"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"            skip_step \u003d True"},{"line_number":976,"context_line":"            if node.driver_internal_info.get(\u0027redo_clean_step\u0027, False):"},{"line_number":977,"context_line":"                skip_step \u003d False"},{"line_number":978,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":979,"context_line":"                info.pop(\u0027redo_clean_step\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_4a7189a7","line":976,"in_reply_to":"ba8a016a_376285d9","updated":"2015-11-24 00:04:31.000000000","message":"I went with \u0027skip_clean_step\u0027.","commit_id":"35ced197003b61d7392f980716267bfb320ec45a"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e044e834286fe09741e91cc885fa0b238206c7de","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        \"\"\"Get the task\u0027s node\u0027s next clean steps."},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_c0492cd2","line":653,"updated":"2015-12-15 09:24:24.000000000","message":"nit: skip_current_step is easier to understand?","commit_id":"eb2ef18ed11a901fead4067aaf8a2f6cdef4984b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"27e63fa6c62367ed029d4536a148ccf54ac9c013","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        \"\"\"Get the task\u0027s node\u0027s next clean steps."},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_b86b3db6","line":653,"in_reply_to":"3a7e1126_ba29ff9c","updated":"2015-12-21 20:12:38.000000000","message":"done","commit_id":"eb2ef18ed11a901fead4067aaf8a2f6cdef4984b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"eba09b24b9d72995db6300bdbac5a5c481a30ef1","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        \"\"\"Get the task\u0027s node\u0027s next clean steps."},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_ba29ff9c","line":653,"in_reply_to":"5a710552_62937750","updated":"2015-12-21 16:04:40.000000000","message":"I\u0027d do it if you write another patch, otherwise it\u0027s fine or could be in a follow up patch.","commit_id":"eb2ef18ed11a901fead4067aaf8a2f6cdef4984b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2280e53e7fe35f1309d5e89da4e89d9decea46a7","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        \"\"\"Get the task\u0027s node\u0027s next clean steps."},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_62937750","line":653,"in_reply_to":"5a710552_c0492cd2","updated":"2015-12-15 20:10:40.000000000","message":"It is probably easier to understand but it is also longer. I\u0027m not sure if it is worth making the change. If one other person wants it, I\u0027ll do it.","commit_id":"eb2ef18ed11a901fead4067aaf8a2f6cdef4984b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2f21bd4aa1e219b9296ed141b76f4a58f4da2cb8","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_de0c2cef","line":793,"updated":"2016-01-05 13:09:43.000000000","message":"This conditional seems a bit confusing, because we have to flags and if \"skip_current_clean_step\" is not set it defaults to True, but the conditional negates it and skip_step is then set to False.\n\nMay I suggest:\n\n skip_step \u003d True        \n # avoid a save() if possible                                            \n if \u0027skip_current_clean_step\u0027 in node.driver_internal_info:          \n     skip_step \u003d node.driver_internal_info.get(\u0027skip_current_clean_step\u0027)\n     info \u003d node.driver_internal_info                                \n     info.pop(\u0027skip_current_clean_step\u0027)                             \n     node.driver_internal_info \u003d info                                \n     node.save()","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6442312ed01a48f61b2bc253438b676ffa231e08","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_e4cc4f63","line":793,"in_reply_to":"da6ed579_68c0282b","updated":"2016-01-18 15:39:46.000000000","message":"Thanks Tan. I was thinking of something in the code itself. Let\u0027s see what folks think.","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e7495d0e5d3e2455e190002fd95912a5a6953e6f","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_68c0282b","line":793,"in_reply_to":"da6ed579_7d779a3a","updated":"2016-01-13 09:39:11.000000000","message":"I cook a patch for that:https://review.openstack.org/#/c/266792/","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ae92491704343d2fd819ecb68771631f32b10a96","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_99aecbe4","line":793,"in_reply_to":"fa69d971_54f81b7b","updated":"2016-01-05 14:28:58.000000000","message":"@Lucas - good idea. I\u0027ll make the change either in a revision or a followup patch.\n\n@Tan -- what Lucas says. We have similar code throughout; eg node.driver_internal_info[\u0027is_whole_disk_image\u0027]. Since there is no type checking for these values, it is very possible to have a programming error. (At least the name here implies that it is a Boolean value.) What we don\u0027t have is a place to document what we are adding to driver_internal_info and what their possible values are. Maybe we can do something after we refactor driver_internal_info into a separate table that uses labels from a labels table.","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"c18689169972bad8ef2fa5c37a7ec589bf777cba","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_7d779a3a","line":793,"in_reply_to":"fa69d971_99aecbe4","updated":"2016-01-13 02:36:47.000000000","message":"This make sense to me, thanks to explain. A document about the driver_internal_info is a nice idea. This is something we should mention in code contribution guide","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9d0ac9d6ba03632f1e6f83c9cf00b8bae0cf581d","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_fefa5042","line":793,"in_reply_to":"fa69d971_de0c2cef","updated":"2016-01-05 13:10:40.000000000","message":"we have two flags* (skip_step and the one in driver_internal_info)","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9540c5c3fbac9d382a30fe91d3b089c0434fa71b","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_54f81b7b","line":793,"in_reply_to":"fa69d971_f97fcaa8","updated":"2016-01-05 13:54:40.000000000","message":"I think that for now at least we can assume it\u0027s a boolean, because at the moment that flag is only set by the code in agent_base_vendor.py. Plus, its a driver_internal_info parameter which can\u0027t be set by users via the API (if it\u0027s not a boolean it\u0027s likely to be a programmatic error)\n\nSo I think we are safe","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"0a3c3f87f97f658195dfdde9313d29c1c85d969b","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_f97fcaa8","line":793,"in_reply_to":"fa69d971_fefa5042","updated":"2016-01-05 13:45:04.000000000","message":"Agree, this looks simpler. But should we think about the case of \u0027skip_current_clean_step\u0027 is not boolean value by mistake?","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6442312ed01a48f61b2bc253438b676ffa231e08","unresolved":false,"context_lines":[{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_current_clean_step\u0027,"},{"line_number":792,"context_line":"                                                 True):"},{"line_number":793,"context_line":"                skip_step \u003d False"},{"line_number":794,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":795,"context_line":"                info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":796,"context_line":"                node.driver_internal_info \u003d info"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_84ad538a","line":793,"in_reply_to":"fa69d971_fefa5042","updated":"2016-01-18 15:39:46.000000000","message":"Done (used Dmitry\u0027s suggestion) in revision 12.","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dec4fe502317451ce3b111778d7b373be2b8893","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"},{"line_number":657,"context_line":"        :returns: ordered list of clean step dictionaries"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_bc82e2fe","line":654,"updated":"2016-01-13 10:49:25.000000000","message":"nit: this requires me to actually remember how cleaning works, because it\u0027s not clear whether steps from the start will be run if skip_step\u003dFalse","commit_id":"811463a8d839270e1701bd3e47d33dfad0eba740"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"177825b8006a10a6fca00a0aa77a617ac191a4d8","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"},{"line_number":657,"context_line":"        :returns: ordered list of clean step dictionaries"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_efa64c52","line":654,"in_reply_to":"da6ed579_bc82e2fe","updated":"2016-01-13 15:19:05.000000000","message":"Oh, the False part isn\u0027t clear. If I do another revision (or in a followup patch), I\u0027ll add more docstring to this to describe what \u0027next\u0027 clean steps mean.\n\nEg:\n\nThis returns the list of remaining (ordered) cleaning steps to be done on the node. If no clean steps have been started yet, all the cleaning steps are returned. Otherwise, the cleaning steps after the current clean step are returned. The current clean step is also returned if \u0027skip_step\u0027 is False.\n\n:param skip_step: True to skip the current clean step; False to include it.","commit_id":"811463a8d839270e1701bd3e47d33dfad0eba740"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"088a202d3b71d54b28f68a98d3a211bd9a0a437b","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"},{"line_number":657,"context_line":"        :returns: ordered list of clean step dictionaries"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_e43a0f34","line":654,"in_reply_to":"da6ed579_efa64c52","updated":"2016-01-18 15:39:40.000000000","message":"done in revision 12.","commit_id":"811463a8d839270e1701bd3e47d33dfad0eba740"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4dec4fe502317451ce3b111778d7b373be2b8893","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":794,"context_line":"                info.pop(\u0027skip_clean_step\u0027)"},{"line_number":795,"context_line":"                node.driver_internal_info \u003d info"},{"line_number":796,"context_line":"                node.save()"},{"line_number":797,"context_line":"            next_steps \u003d self._get_node_next_clean_steps(task,"},{"line_number":798,"context_line":"                                                         skip_step\u003dskip_step)"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_dc855607","line":796,"updated":"2016-01-13 10:49:25.000000000","message":"nit: you can combine get and pop:\n\n info \u003d node.driver_internal_info\n try:\n   skip_step \u003d info.pop(\u0027skip_clean_step\u0027)\n except KeyError:\n   skip_step \u003d True\n else:\n   node.driver_internal_info \u003d info\n   node.save()","commit_id":"811463a8d839270e1701bd3e47d33dfad0eba740"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"088a202d3b71d54b28f68a98d3a211bd9a0a437b","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":794,"context_line":"                info.pop(\u0027skip_clean_step\u0027)"},{"line_number":795,"context_line":"                node.driver_internal_info \u003d info"},{"line_number":796,"context_line":"                node.save()"},{"line_number":797,"context_line":"            next_steps \u003d self._get_node_next_clean_steps(task,"},{"line_number":798,"context_line":"                                                         skip_step\u003dskip_step)"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_240fc789","line":796,"in_reply_to":"da6ed579_cf91089b","updated":"2016-01-18 15:39:40.000000000","message":"Done in revision 12.","commit_id":"811463a8d839270e1701bd3e47d33dfad0eba740"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"177825b8006a10a6fca00a0aa77a617ac191a4d8","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                info \u003d node.driver_internal_info"},{"line_number":794,"context_line":"                info.pop(\u0027skip_clean_step\u0027)"},{"line_number":795,"context_line":"                node.driver_internal_info \u003d info"},{"line_number":796,"context_line":"                node.save()"},{"line_number":797,"context_line":"            next_steps \u003d self._get_node_next_clean_steps(task,"},{"line_number":798,"context_line":"                                                         skip_step\u003dskip_step)"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_cf91089b","line":796,"in_reply_to":"da6ed579_dc855607","updated":"2016-01-13 15:19:05.000000000","message":"I was going to change this part if I did a new revision or in a followup patch, based on Lucas\u0027 suggestion in revision 9, but I like your suggestion better :)","commit_id":"811463a8d839270e1701bd3e47d33dfad0eba740"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b2db292901132b06bee4a7a8bdb8dbfa852e8a2f","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        \"\"\"Get the task\u0027s node\u0027s next clean steps."},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_977b8629","line":653,"range":{"start_line":653,"start_character":15,"end_line":653,"end_character":24},"updated":"2016-01-16 04:35:34.000000000","message":"I saw that before (patch set 8) this was \u0027skip_current_step\u0027 which makes more sense to me than just \u0027skip_step\u0027. I\u0027m not sure that \u0027skip_step\u0027 makes much sense to me.\n\nAnd then the value of \u0027skip_set\u0027 gets changed to something else based on what node.driver_internal_info.get(\u0027skip_clean_step\u0027) returns, which is also confusing.","commit_id":"a380cabe1ecd71613abed3c230d1f7fdd13f476f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d90657efe1a7554778c4a7a8081dbc7e1520cd","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        \"\"\"Get the task\u0027s node\u0027s next clean steps."},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        :param task: A TaskManager object"},{"line_number":653,"context_line":"        :param skip_step: True to skip steps from the start including the"},{"line_number":654,"context_line":"            current step; False to include the current step"},{"line_number":655,"context_line":"        :raises: NodeCleaningFailure if an internal error occurred when"},{"line_number":656,"context_line":"                 getting the next clean steps"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_4e63fa1a","line":653,"range":{"start_line":653,"start_character":15,"end_line":653,"end_character":24},"in_reply_to":"da6ed579_977b8629","updated":"2016-01-18 15:39:22.000000000","message":"OH. Good catch. I\u0027m not sure what happened, but revision 9 had skip_current_step, and revision 10 reverted it (and I don\u0027t have a note as to why I submitted revision 10, but I didn\u0027t mean to undo that change.)\n\nwrt the value of skip_step getting changed -- I\u0027m not sure what your confusion is, so I will try to catch you on IRC. The whole reason for adding this parameter was so that it could be set via the value in node.driver_internal_info.","commit_id":"a380cabe1ecd71613abed3c230d1f7fdd13f476f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b2db292901132b06bee4a7a8bdb8dbfa852e8a2f","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                     \u0027state\u0027: node.provision_state,"},{"line_number":788,"context_line":"                     \u0027clean_state\u0027: states.CLEANWAIT})"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_clean_step\u0027, True):"},{"line_number":792,"context_line":"                skip_step \u003d False"},{"line_number":793,"context_line":"                info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_17b556cf","line":790,"range":{"start_line":790,"start_character":12,"end_line":790,"end_character":21},"updated":"2016-01-16 04:35:34.000000000","message":"This seems strange/confusing to me to reassign the parameter value from L653","commit_id":"a380cabe1ecd71613abed3c230d1f7fdd13f476f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"33d90657efe1a7554778c4a7a8081dbc7e1520cd","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                     \u0027state\u0027: node.provision_state,"},{"line_number":788,"context_line":"                     \u0027clean_state\u0027: states.CLEANWAIT})"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"            skip_step \u003d True"},{"line_number":791,"context_line":"            if not node.driver_internal_info.get(\u0027skip_clean_step\u0027, True):"},{"line_number":792,"context_line":"                skip_step \u003d False"},{"line_number":793,"context_line":"                info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_ce7cca22","line":790,"range":{"start_line":790,"start_character":12,"end_line":790,"end_character":21},"in_reply_to":"da6ed579_17b556cf","updated":"2016-01-18 15:39:22.000000000","message":"It isn\u0027t reassigning -- this is the value used for the parameter value for L653. (Or is that what you meant? I guess I\u0027m not sure what you meant...)","commit_id":"a380cabe1ecd71613abed3c230d1f7fdd13f476f"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"00ee87ea9e423d9ce44b2dc17f8f865efe0686ef","unresolved":false,"context_lines":[{"line_number":670,"context_line":"            return next_steps"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        try:"},{"line_number":673,"context_line":"            # Trim off all previous steps up to (and maybe including) the"},{"line_number":674,"context_line":"            # current clean step."},{"line_number":675,"context_line":"            ind \u003d next_steps.index(node.clean_step)"},{"line_number":676,"context_line":"            if skip_current_step:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba63e191_612a6e2e","line":673,"updated":"2016-01-20 11:35:19.000000000","message":"Are the elements of `next_steps` guaranteed to be unique? Because if not, it looks like cleaning can loop forever.","commit_id":"50e42fbfe1872432a797e4a27ec922432ccc895c"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"6791993064c68d70f9c735d6201159b131fd1049","unresolved":false,"context_lines":[{"line_number":670,"context_line":"            return next_steps"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        try:"},{"line_number":673,"context_line":"            # Trim off all previous steps up to (and maybe including) the"},{"line_number":674,"context_line":"            # current clean step."},{"line_number":675,"context_line":"            ind \u003d next_steps.index(node.clean_step)"},{"line_number":676,"context_line":"            if skip_current_step:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a68dd71_e56a431a","line":673,"in_reply_to":"9a68dd71_9372b27b","updated":"2016-01-20 18:33:05.000000000","message":"Yeah, storing the index seems much cleaner if it\u0027s possible.","commit_id":"50e42fbfe1872432a797e4a27ec922432ccc895c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"729885f8bfaa040dfd7acab882b361fac4dd773a","unresolved":false,"context_lines":[{"line_number":670,"context_line":"            return next_steps"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        try:"},{"line_number":673,"context_line":"            # Trim off all previous steps up to (and maybe including) the"},{"line_number":674,"context_line":"            # current clean step."},{"line_number":675,"context_line":"            ind \u003d next_steps.index(node.clean_step)"},{"line_number":676,"context_line":"            if skip_current_step:"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a68dd71_9372b27b","line":673,"in_reply_to":"ba63e191_612a6e2e","updated":"2016-01-20 17:35:15.000000000","message":"Oh. good point. The assumption is that they are unique, but there isn\u0027t anything that checks for that.\n\nI don\u0027t actually like this bit of code; it seems like we should be saving the index so we don\u0027t have to find the index each time. (I think I wanted node.clean_step to be the index not the step.) And that would allow performing a clean step more than once if so desired.\n\nI\u0027m not sure how easy it will be to address this (it might be easy) so I opened a bug to track this so we/I don\u0027t forget. : https://bugs.launchpad.net/ironic/+bug/1536276","commit_id":"50e42fbfe1872432a797e4a27ec922432ccc895c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8a35bec0342b4c417a9f0fbd0b56f11b6e200cc1","unresolved":false,"context_lines":[{"line_number":797,"context_line":"            try:"},{"line_number":798,"context_line":"                skip_current_step \u003d info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":799,"context_line":"            except KeyError:"},{"line_number":800,"context_line":"                skip_current_step \u003d True"},{"line_number":801,"context_line":"            else:"},{"line_number":802,"context_line":"                node.driver_internal_info \u003d info"},{"line_number":803,"context_line":"                node.save()"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_653450fb","line":800,"updated":"2016-02-08 09:59:23.000000000","message":"nit: you can set a default value to pop() in case the item you are looking fot is not present, e.g:\n\n skip_current_step \u003d info.pop(\u0027skip_current_clean_step\u0027, True)","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1d84cefb67427728af45f06d760438105327c80","unresolved":false,"context_lines":[{"line_number":797,"context_line":"            try:"},{"line_number":798,"context_line":"                skip_current_step \u003d info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":799,"context_line":"            except KeyError:"},{"line_number":800,"context_line":"                skip_current_step \u003d True"},{"line_number":801,"context_line":"            else:"},{"line_number":802,"context_line":"                node.driver_internal_info \u003d info"},{"line_number":803,"context_line":"                node.save()"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_b5cd5588","line":800,"in_reply_to":"5a5ae5dd_0028d731","updated":"2016-02-09 09:41:05.000000000","message":"Fair enough","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"268ba3f98f0eb1078a664ad26fd89852457a3331","unresolved":false,"context_lines":[{"line_number":797,"context_line":"            try:"},{"line_number":798,"context_line":"                skip_current_step \u003d info.pop(\u0027skip_current_clean_step\u0027)"},{"line_number":799,"context_line":"            except KeyError:"},{"line_number":800,"context_line":"                skip_current_step \u003d True"},{"line_number":801,"context_line":"            else:"},{"line_number":802,"context_line":"                node.driver_internal_info \u003d info"},{"line_number":803,"context_line":"                node.save()"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_0028d731","line":800,"in_reply_to":"5a5ae5dd_653450fb","updated":"2016-02-08 16:06:40.000000000","message":"True, except that I want the \u0027except KeyError\u0027 to happen, because I only want to update node.driver_internal_info if \u0027skip_current_clean_step\u0027 was actually there.","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3cf5666553f9dd06756ce2e6f805a001fb63b625","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        msg \u003d _(\u0027Failed checking if deploy is done.\u0027)"},{"line_number":351,"context_line":"        try:"},{"line_number":352,"context_line":"            # NOTE(rloo): manual cleaning is allowed in maintenance mode"},{"line_number":353,"context_line":"            if node.maintenance and node.provision_state !\u003d states.CLEANWAIT:"},{"line_number":354,"context_line":"                # this shouldn\u0027t happen often, but skip the rest if it does."},{"line_number":355,"context_line":"                LOG.debug(\u0027Heartbeat from node %(node)s in maintenance mode; \u0027"},{"line_number":356,"context_line":"                          \u0027not taking any action.\u0027, {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_452f9ef6","line":353,"updated":"2015-11-20 15:55:59.000000000","message":"This is interesting - we tend to treat maintenance mode as \"Ironic won\u0027t touch this node\". Is there a reason we need to allow manual cleaning here? I\u0027m not seeing one...","commit_id":"35ced197003b61d7392f980716267bfb320ec45a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"06b2cc21517f172260723308d6ded3ec4e52f3a5","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        msg \u003d _(\u0027Failed checking if deploy is done.\u0027)"},{"line_number":351,"context_line":"        try:"},{"line_number":352,"context_line":"            # NOTE(rloo): manual cleaning is allowed in maintenance mode"},{"line_number":353,"context_line":"            if node.maintenance and node.provision_state !\u003d states.CLEANWAIT:"},{"line_number":354,"context_line":"                # this shouldn\u0027t happen often, but skip the rest if it does."},{"line_number":355,"context_line":"                LOG.debug(\u0027Heartbeat from node %(node)s in maintenance mode; \u0027"},{"line_number":356,"context_line":"                          \u0027not taking any action.\u0027, {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_b75755c9","line":353,"in_reply_to":"ba8a016a_452f9ef6","updated":"2015-11-23 15:16:40.000000000","message":"Manual cleaning is something that the operator will manually do. I think we can assume that they know what they are doing if they want to do a manual clean, so I don\u0027t see why we want to prevent them from this if a node is in maintenance. They may have put the node in maintenance in the first place, and now want to do some sort of cleaning to fix something but still want it tagged as maintenance.","commit_id":"35ced197003b61d7392f980716267bfb320ec45a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"424d0cd3f63f04faf553cfaf8fff203900d687e3","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        msg \u003d _(\u0027Failed checking if deploy is done.\u0027)"},{"line_number":351,"context_line":"        try:"},{"line_number":352,"context_line":"            # NOTE(rloo): manual cleaning is allowed in maintenance mode"},{"line_number":353,"context_line":"            if node.maintenance and node.provision_state !\u003d states.CLEANWAIT:"},{"line_number":354,"context_line":"                # this shouldn\u0027t happen often, but skip the rest if it does."},{"line_number":355,"context_line":"                LOG.debug(\u0027Heartbeat from node %(node)s in maintenance mode; \u0027"},{"line_number":356,"context_line":"                          \u0027not taking any action.\u0027, {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_367cb271","line":353,"in_reply_to":"ba8a016a_b75755c9","updated":"2015-11-24 00:04:31.000000000","message":"We had a short IRC discussion [1] about this and it isn\u0027t clear to the few folks there whether we should allow this or not. Since I think we need a bigger discussion of it, I will remove this. We can add it in later if we agree that it is desirable.\n\n[1] 2015-11-23T21:31:11, http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2015-11-23.log","commit_id":"35ced197003b61d7392f980716267bfb320ec45a"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b71cdbd461838665371bb95d1bced09667d6829f","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                # Don\u0027t restart manual cleaning if agent reboots to a new"},{"line_number":267,"context_line":"                # version. Both are operator actions, unlike automated"},{"line_number":268,"context_line":"                # cleaning. Manual clean steps are not necessarily idempotent"},{"line_number":269,"context_line":"                # like automated clean steps and can be even longer running."},{"line_number":270,"context_line":"                LOG.info(_LI(\u0027During manual cleaning, node %(node)s detected \u0027"},{"line_number":271,"context_line":"                             \u0027a clean version mismatch. Re-executing and \u0027"},{"line_number":272,"context_line":"                             \u0027continuing from current step %(step)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_2434fff9","line":269,"updated":"2015-12-09 00:56:55.000000000","message":"I really like the way we\u0027re handling this case.","commit_id":"eb2ef18ed11a901fead4067aaf8a2f6cdef4984b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"03d72cbaa598f01cd4a4109f1bafb8d3b50221ae","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                # Don\u0027t restart manual cleaning if agent reboots to a new"},{"line_number":267,"context_line":"                # version. Both are operator actions, unlike automated"},{"line_number":268,"context_line":"                # cleaning. Manual clean steps are not necessarily idempotent"},{"line_number":269,"context_line":"                # like automated clean steps and can be even longer running."},{"line_number":270,"context_line":"                LOG.info(_LI(\u0027During manual cleaning, node %(node)s detected \u0027"},{"line_number":271,"context_line":"                             \u0027a clean version mismatch. Re-executing and \u0027"},{"line_number":272,"context_line":"                             \u0027continuing from current step %(step)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_2bbfea61","line":269,"in_reply_to":"7a740942_2434fff9","updated":"2015-12-09 03:46:30.000000000","message":"Thank Josh :)","commit_id":"eb2ef18ed11a901fead4067aaf8a2f6cdef4984b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2f21bd4aa1e219b9296ed141b76f4a58f4da2cb8","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        we restart cleaning."},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":"        node \u003d task.node"},{"line_number":229,"context_line":"        manual_clean \u003d node.target_provision_state \u003d\u003d states.MANAGEABLE"},{"line_number":230,"context_line":"        command \u003d self._get_completed_cleaning_command(task)"},{"line_number":231,"context_line":"        LOG.debug(\u0027Cleaning command status for node %(node)s on step %(step)s:\u0027"},{"line_number":232,"context_line":"                  \u0027 %(command)s\u0027, {\u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_c3c9b327","line":229,"updated":"2016-01-05 13:09:43.000000000","message":"Nit. Comment explaning the differences\n\n# For manual cleaning, the target provision state is MANAGEABLE, whereas\n# for automated cleaning, it is AVAILABLE.","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6442312ed01a48f61b2bc253438b676ffa231e08","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        we restart cleaning."},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":"        node \u003d task.node"},{"line_number":229,"context_line":"        manual_clean \u003d node.target_provision_state \u003d\u003d states.MANAGEABLE"},{"line_number":230,"context_line":"        command \u003d self._get_completed_cleaning_command(task)"},{"line_number":231,"context_line":"        LOG.debug(\u0027Cleaning command status for node %(node)s on step %(step)s:\u0027"},{"line_number":232,"context_line":"                  \u0027 %(command)s\u0027, {\u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_a4ec17f4","line":229,"in_reply_to":"fa69d971_c3c9b327","updated":"2016-01-18 15:39:46.000000000","message":"Done in revision 12.","commit_id":"53bc75e1ced224873af2323b5cd56c540536dccc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"db835fa928c811e460d25361e5211bbaadf808e1","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        will check the version of all hardware managers during get_clean_steps"},{"line_number":223,"context_line":"        at the beginning of cleaning and before executing each step in the"},{"line_number":224,"context_line":"        agent. If the version has changed between steps, the agent is unable"},{"line_number":225,"context_line":"        to tell if an ordering change will cause a cleaning issue. Therefore,"},{"line_number":226,"context_line":"        we restart cleaning."},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a68dd71_9d76c1a2","line":225,"updated":"2016-01-22 17:07:55.000000000","message":"This docstring should be changed too.","commit_id":"50e42fbfe1872432a797e4a27ec922432ccc895c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"db835fa928c811e460d25361e5211bbaadf808e1","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"                driver_internal_info \u003d node.driver_internal_info"},{"line_number":278,"context_line":"                driver_internal_info[\u0027hardware_manager_version\u0027] \u003d command["},{"line_number":279,"context_line":"                    \u0027command_result\u0027][\u0027hardware_manager_version\u0027]"},{"line_number":280,"context_line":"                driver_internal_info[\u0027skip_current_clean_step\u0027] \u003d False"},{"line_number":281,"context_line":"                node.driver_internal_info \u003d driver_internal_info"},{"line_number":282,"context_line":"                node.save()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a68dd71_5277d8d2","line":279,"updated":"2016-01-22 17:07:55.000000000","message":"I might be missing something, but IIUC hardware_manager_version will be present in command_result only after get_clean_steps command (https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/clean.py#L44). What happens if version mismatch appears after some clean steps have run (https://github.com/openstack/ironic-python-agent/tree/master/ironic_python_agent/extensions#L164)? It\u0027ll be a key error here?","commit_id":"50e42fbfe1872432a797e4a27ec922432ccc895c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"885942fd5e3b26e0e2561e06a6c532eb298eedd9","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"                driver_internal_info \u003d node.driver_internal_info"},{"line_number":278,"context_line":"                driver_internal_info[\u0027hardware_manager_version\u0027] \u003d command["},{"line_number":279,"context_line":"                    \u0027command_result\u0027][\u0027hardware_manager_version\u0027]"},{"line_number":280,"context_line":"                driver_internal_info[\u0027skip_current_clean_step\u0027] \u003d False"},{"line_number":281,"context_line":"                node.driver_internal_info \u003d driver_internal_info"},{"line_number":282,"context_line":"                node.save()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a68dd71_5598d01b","line":279,"in_reply_to":"9a68dd71_5277d8d2","updated":"2016-01-25 16:51:33.000000000","message":"SIGH. I had assumed the IPA part was \u0027correct\u0027 and never looked. (This code was originally from someone else.)\n\nIf a version mismatch occurs in IPA, IPA will return this CLEAN_VERSION_MISMATCH in \u0027command_status\u0027. I just looked at the IPA code, and I don\u0027t see that \u0027command_result\u0027 gets set so yeah, no hardware_manager_version is there.\n\nGood catch!","commit_id":"50e42fbfe1872432a797e4a27ec922432ccc895c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08dc5d1d3af84ff720101392ca0fe723f4242a91","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            LOG.error(msg)"},{"line_number":250,"context_line":"            return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":251,"context_line":"        elif command.get(\u0027command_status\u0027) \u003d\u003d \u0027CLEAN_VERSION_MISMATCH\u0027:"},{"line_number":252,"context_line":"            if not manual_clean:"},{"line_number":253,"context_line":"                # Restart cleaning, agent must have rebooted to new version"},{"line_number":254,"context_line":"                LOG.info(_LI(\u0027During automated cleaning, node %s detected a \u0027"},{"line_number":255,"context_line":"                             \u0027clean version mismatch. Resetting clean steps \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_8d8ac062","line":252,"updated":"2016-02-08 15:18:58.000000000","message":"nit: maybe it\u0027s only me, but I\u0027d prefer\n\n if x:\n   ..\n else:\n   ..","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"268ba3f98f0eb1078a664ad26fd89852457a3331","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            LOG.error(msg)"},{"line_number":250,"context_line":"            return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":251,"context_line":"        elif command.get(\u0027command_status\u0027) \u003d\u003d \u0027CLEAN_VERSION_MISMATCH\u0027:"},{"line_number":252,"context_line":"            if not manual_clean:"},{"line_number":253,"context_line":"                # Restart cleaning, agent must have rebooted to new version"},{"line_number":254,"context_line":"                LOG.info(_LI(\u0027During automated cleaning, node %s detected a \u0027"},{"line_number":255,"context_line":"                             \u0027clean version mismatch. Resetting clean steps \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_408ecf2e","line":252,"in_reply_to":"5a5ae5dd_8d8ac062","updated":"2016-02-08 16:06:40.000000000","message":"I\u0027m fine with either. I had it like this because automated clean was in the code first, so I wanted to leave it as #1. I can change it in the next revision/patch.","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"17166f30f1ed5a4f1c1e600fc5a1839aa722d7e8","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                             \u0027%(node)s: %(err)s.\u0027) %"},{"line_number":263,"context_line":"                           {\u0027node\u0027: node.uuid,"},{"line_number":264,"context_line":"                            \u0027err\u0027: command.get(\u0027command_error\u0027),"},{"line_number":265,"context_line":"                            \u0027step\u0027: node.clean_step})"},{"line_number":266,"context_line":"                    LOG.exception(msg)"},{"line_number":267,"context_line":"                    return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":268,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_57b91778","line":265,"range":{"start_line":265,"start_character":29,"end_line":265,"end_character":33},"updated":"2016-02-05 08:48:55.000000000","message":"\u0027step\u0027 is not used in the message.","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b323a5c71ee010885efaee8f34876f7472aeeb73","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                             \u0027%(node)s: %(err)s.\u0027) %"},{"line_number":263,"context_line":"                           {\u0027node\u0027: node.uuid,"},{"line_number":264,"context_line":"                            \u0027err\u0027: command.get(\u0027command_error\u0027),"},{"line_number":265,"context_line":"                            \u0027step\u0027: node.clean_step})"},{"line_number":266,"context_line":"                    LOG.exception(msg)"},{"line_number":267,"context_line":"                    return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":268,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_a7a8358d","line":265,"range":{"start_line":265,"start_character":29,"end_line":265,"end_character":33},"in_reply_to":"5a5ae5dd_57b91778","updated":"2016-02-05 22:12:06.000000000","message":"Yes, it isn\u0027t. It looks like it might be useful if it were used. I\u0027ll fix that in a separate patch because I\u0027d like to change the LOG string too.","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"17166f30f1ed5a4f1c1e600fc5a1839aa722d7e8","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                             \u0027continuing from current step %(step)s.\u0027),"},{"line_number":276,"context_line":"                         {\u0027node\u0027: node.uuid, \u0027step\u0027: node.clean_step})"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"                result \u003d self._client.get_clean_steps("},{"line_number":279,"context_line":"                    task.node, task.ports).get(\u0027command_result\u0027)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"                if (\u0027clean_steps\u0027 not in result or"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_b2517938","line":278,"range":{"start_line":278,"start_character":16,"end_line":278,"end_character":22},"updated":"2016-02-05 08:48:55.000000000","message":"get_clean_steps might rise an exception IronicException(), I think we should wrap it.","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b323a5c71ee010885efaee8f34876f7472aeeb73","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                             \u0027continuing from current step %(step)s.\u0027),"},{"line_number":276,"context_line":"                         {\u0027node\u0027: node.uuid, \u0027step\u0027: node.clean_step})"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"                result \u003d self._client.get_clean_steps("},{"line_number":279,"context_line":"                    task.node, task.ports).get(\u0027command_result\u0027)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"                if (\u0027clean_steps\u0027 not in result or"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_277525f9","line":278,"range":{"start_line":278,"start_character":16,"end_line":278,"end_character":22},"in_reply_to":"5a5ae5dd_b2517938","updated":"2016-02-05 22:12:06.000000000","message":"Sigh. It doesn\u0027t look like any code handles exceptions from the agent client. Since it isn\u0027t just this one place, I opened a bug to track it: https://bugs.launchpad.net/ironic/+bug/1542506.","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08dc5d1d3af84ff720101392ca0fe723f4242a91","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                    \u0027hardware_manager_version\u0027 not in result):"},{"line_number":283,"context_line":"                    msg \u003d (_(\u0027Could not continue manual cleaning from step \u0027"},{"line_number":284,"context_line":"                             \u0027%(step)s on node %(node)s. get_clean_steps \u0027"},{"line_number":285,"context_line":"                             \u0027returned invalid result: %(result)s.\u0027) %"},{"line_number":286,"context_line":"                           {\u0027node\u0027: node.uuid,"},{"line_number":287,"context_line":"                            \u0027step\u0027: node.clean_step,"},{"line_number":288,"context_line":"                            \u0027result\u0027: result})"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_2decec28","line":285,"updated":"2016-02-08 15:18:58.000000000","message":"nit: would be good to mention what exactly is invalid about this result","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"08dc5d1d3af84ff720101392ca0fe723f4242a91","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                           {\u0027node\u0027: node.uuid,"},{"line_number":287,"context_line":"                            \u0027step\u0027: node.clean_step,"},{"line_number":288,"context_line":"                            \u0027result\u0027: result})"},{"line_number":289,"context_line":"                    LOG.exception(msg)"},{"line_number":290,"context_line":"                    return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"                driver_internal_info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_4defe81d","line":289,"updated":"2016-02-08 15:18:58.000000000","message":"there is no active exception, so this should be LOG.error","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"268ba3f98f0eb1078a664ad26fd89852457a3331","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                           {\u0027node\u0027: node.uuid,"},{"line_number":287,"context_line":"                            \u0027step\u0027: node.clean_step,"},{"line_number":288,"context_line":"                            \u0027result\u0027: result})"},{"line_number":289,"context_line":"                    LOG.exception(msg)"},{"line_number":290,"context_line":"                    return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"                driver_internal_info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_20e073cc","line":289,"in_reply_to":"5a5ae5dd_4defe81d","updated":"2016-02-08 16:06:40.000000000","message":"Oops.","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"17166f30f1ed5a4f1c1e600fc5a1839aa722d7e8","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                    if not node.clean_step:"},{"line_number":392,"context_line":"                        LOG.debug(\u0027Node %s just booted to start cleaning.\u0027,"},{"line_number":393,"context_line":"                                  node.uuid)"},{"line_number":394,"context_line":"                        msg \u003d _(\u0027Node failed to start the first cleaning \u0027"},{"line_number":395,"context_line":"                                \u0027step.\u0027)"},{"line_number":396,"context_line":"                        manager_utils.set_node_cleaning_steps(task)"},{"line_number":397,"context_line":"                        self.notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_12d16d23","line":394,"range":{"start_line":394,"start_character":24,"end_line":394,"end_character":27},"updated":"2016-02-05 08:48:55.000000000","message":"why don\u0027t add node_uuid to this message and msg on line 399","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b323a5c71ee010885efaee8f34876f7472aeeb73","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                    if not node.clean_step:"},{"line_number":392,"context_line":"                        LOG.debug(\u0027Node %s just booted to start cleaning.\u0027,"},{"line_number":393,"context_line":"                                  node.uuid)"},{"line_number":394,"context_line":"                        msg \u003d _(\u0027Node failed to start the first cleaning \u0027"},{"line_number":395,"context_line":"                                \u0027step.\u0027)"},{"line_number":396,"context_line":"                        manager_utils.set_node_cleaning_steps(task)"},{"line_number":397,"context_line":"                        self.notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a5ae5dd_cca1d647","line":394,"range":{"start_line":394,"start_character":24,"end_line":394,"end_character":27},"in_reply_to":"5a5ae5dd_12d16d23","updated":"2016-02-05 22:12:06.000000000","message":"If you look at how msg is being used, line 408, the node is mentioned there.","commit_id":"3697d9a97da61487d256d066ac3b66bf947f5dcc"}]}
