)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4b51d54be4b050ce1004047fba4f7abe6f5694f6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cleaning. It is replaced with \u0027automated_clean\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This deprecates the \u0027clean_nodes\u0027 config; the plan is to delete it"},{"line_number":14,"context_line":"in Neutron cycle."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Updates to the documentation to explicitly mention automated vs"},{"line_number":17,"context_line":"manual cleaning is done in a separate patch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3a57f1b5_4f00f334","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":10},"updated":"2016-02-10 15:30:15.000000000","message":"Newton is the name of the N release","commit_id":"8f5a51b158c1885c8a6339b37c8e01c0f6d94f6c"}],"doc/source/deploy/cleaning.rst":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"93c8dd5789fd0b0f0c03d9d25f95a4f15a1174b2","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Enabling cleaning"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  [conductor]"},{"line_number":31,"context_line":"  automated_clean\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_20671dea","line":28,"updated":"2015-11-19 18:10:38.000000000","message":"s/cleaning/automated cleaning, so that the operator doesn\u0027t think that this is needed to allow manual cleaning.","commit_id":"0269af210b427018bea732f9fb0d3148ed8097d1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"70caa3a171141d1a98a87e8064e10935f1ca3f2c","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Enabling cleaning"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  [conductor]"},{"line_number":31,"context_line":"  automated_clean\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_9b951a34","line":28,"in_reply_to":"ba8a016a_20671dea","updated":"2015-11-19 18:33:42.000000000","message":"Yup. This page needs to be updated because it is automated-cleaning-centric. It was one of those things; do I modify just the config and people ask for more modifications, or I don\u0027t modify it and someone says I should modify it cuz I changed the name of the config. Or I modify more than just the config and someone asks for even more modifications to the documentation. It seemed like a slippery slope :-(","commit_id":"0269af210b427018bea732f9fb0d3148ed8097d1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e8dc56728c2fb88d34fdfd66eec8e543c6b94fab","unresolved":false,"context_lines":[{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  [conductor]"},{"line_number":31,"context_line":"  automated_clean\u003dtrue"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This will enable the default set of steps, based on your hardware and ironic"},{"line_number":34,"context_line":"drivers. If you\u0027re using an agent_* driver, this includes, by default, erasing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_bde028ce","line":31,"updated":"2015-12-08 14:06:17.000000000","message":"Line L23 mentions that cleaning was introduced in the Kilo release and at that release this option was called \"clean_nodes\". Not sure, but should we separated this section saying in \"before mitaka\"  and \"mitaka and newer versions\" ? E.g\n\nFor Kilo and Liberty versions::\n\n  [conductor]\n  clean_nodes\u003dtrue\n\nFor Mitaka and newer versions:: \n\n  [conductor]\n  automated_clean\u003dtrue\n\nWDYT?","commit_id":"9bd585ec9106e890ab37ebb90b44bc7ef02a2957"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1915478db33171fa4da18cc772d75857392ad98d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  [conductor]"},{"line_number":31,"context_line":"  automated_clean\u003dtrue"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This will enable the default set of steps, based on your hardware and ironic"},{"line_number":34,"context_line":"drivers. If you\u0027re using an agent_* driver, this includes, by default, erasing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_e2a123f9","line":31,"in_reply_to":"7a740942_b3d61726","updated":"2015-12-08 15:34:43.000000000","message":"I was wrong -- the install guides are versioned. Discussed quickly with Jim on IRC [1] and we both think we don\u0027t need to mention the differences between versions. I filed a bug for this [2].\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2015-12-08.log.html#t2015-12-08T14:33:20\n\n[2] https://bugs.launchpad.net/ironic/+bug/1523962","commit_id":"9bd585ec9106e890ab37ebb90b44bc7ef02a2957"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5a4df5755c6a5f5c85378b99ef48231a2a3772fb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  [conductor]"},{"line_number":31,"context_line":"  automated_clean\u003dtrue"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This will enable the default set of steps, based on your hardware and ironic"},{"line_number":34,"context_line":"drivers. If you\u0027re using an agent_* driver, this includes, by default, erasing"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_b3d61726","line":31,"in_reply_to":"7a740942_bde028ce","updated":"2015-12-08 14:30:10.000000000","message":"Sigh. I was going to say no, we don\u0027t need to do that because we have versioning, eg http://docs.openstack.org/developer/ironic/4.3.0/.\n\nhowever, we do want our install guide to be included with the \u0027main\u0027 install guides. I took a quick look at those and they aren\u0027t that detailed. I\u0027m not sure how they deal with changes between releases.\n\nWe also have a different thing -- if we want to mention releases, do we only mention stable releases and/or numbered releases?","commit_id":"9bd585ec9106e890ab37ebb90b44bc7ef02a2957"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"6f85cd68014b50e95d968c253a5df85f4782050b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Ironic added support for cleaning nodes in the Kilo release."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Enabling cleaning"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"da6ed579_bafaf8bb","line":26,"updated":"2016-01-13 02:20:49.000000000","message":"better to rename the title to enabling automated clean too. Otherwise, I will expect manual clean should be mentioned in this section, but this could be done in a follow patch","commit_id":"3777d157a840736860a9befcb5c6ee2c5b7c3fcd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5dfa0e79d569d2ae68d3e06d85fc32edf8d2baa9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Ironic added support for cleaning nodes in the Kilo release."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Enabling cleaning"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"da6ed579_b60995df","line":26,"in_reply_to":"da6ed579_bafaf8bb","updated":"2016-01-13 14:34:37.000000000","message":"The documentation is going to be updated once the code has landed, via https://review.openstack.org/#/c/264266/.\n\nAt this point, I want to leave the documentation alone as much as possible. Manual cleaning isn\u0027t available to the user, so it doesn\u0027t make sense to mention that.","commit_id":"3777d157a840736860a9befcb5c6ee2c5b7c3fcd"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"6f85cd68014b50e95d968c253a5df85f4782050b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Enabling cleaning"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  [conductor]"},{"line_number":31,"context_line":"  automated_clean\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da6ed579_1a2a242d","line":28,"updated":"2016-01-13 02:20:49.000000000","message":"ditto","commit_id":"3777d157a840736860a9befcb5c6ee2c5b7c3fcd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5dfa0e79d569d2ae68d3e06d85fc32edf8d2baa9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Enabling cleaning"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"To enable cleaning, ensure your ironic.conf is set as follows: ::"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  [conductor]"},{"line_number":31,"context_line":"  automated_clean\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da6ed579_16d0a11e","line":28,"in_reply_to":"da6ed579_1a2a242d","updated":"2016-01-13 14:34:37.000000000","message":"ditto","commit_id":"3777d157a840736860a9befcb5c6ee2c5b7c3fcd"}],"ironic/conductor/manager.py":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"508dff102ea5de4f51328fea93dfd1291d1def96","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    # TODO(rloo): Remove support for deprecated name \u0027clean_nodes\u0027 in N cycle"},{"line_number":172,"context_line":"    cfg.BoolOpt(\u0027automated_clean\u0027,"},{"line_number":173,"context_line":"                default\u003dTrue,"},{"line_number":174,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":175,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":176,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"},{"line_number":177,"context_line":"                       \u0027cleaning is a configurable set of steps, \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_d8b75883","line":174,"updated":"2015-12-02 23:59:58.000000000","message":"nit: deprecated_group is not required unless the group is changed. This gives the impression that the group for the option is also changed.","commit_id":"8b30ed1d6f0dffb9fe759e596e0a6a6a53d8465c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b74ee266140c4f86126dde75aef14269d24a185d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    # TODO(rloo): Remove support for deprecated name \u0027clean_nodes\u0027 in N cycle"},{"line_number":172,"context_line":"    cfg.BoolOpt(\u0027automated_clean\u0027,"},{"line_number":173,"context_line":"                default\u003dTrue,"},{"line_number":174,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":175,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":176,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"},{"line_number":177,"context_line":"                       \u0027cleaning is a configurable set of steps, \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_3d4222af","line":174,"in_reply_to":"7a740942_b0976d8f","updated":"2015-12-07 20:54:12.000000000","message":"Nisha, I don\u0027t know when you tried this, but just to make sure I wasn\u0027t confused, I just tried it without the deprecated_group line and I got:\n\n    # option could be safely disabled. (boolean value)\n    # Deprecated group/name - [DEFAULT]/clean_nodes\n    #automated_clean\u003dtrue","commit_id":"8b30ed1d6f0dffb9fe759e596e0a6a6a53d8465c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dddfda8bca7303d786f680e4b7a41b7ea0e1df5d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    # TODO(rloo): Remove support for deprecated name \u0027clean_nodes\u0027 in N cycle"},{"line_number":172,"context_line":"    cfg.BoolOpt(\u0027automated_clean\u0027,"},{"line_number":173,"context_line":"                default\u003dTrue,"},{"line_number":174,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":175,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":176,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"},{"line_number":177,"context_line":"                       \u0027cleaning is a configurable set of steps, \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_ce10f202","line":174,"in_reply_to":"9a8ffd7b_332c87ab","updated":"2015-12-03 00:35:22.000000000","message":"If I do another revision, I\u0027ll think about whether it makes sense to add a comment that this doesn\u0027t mean it is deprecated from a different group. (I\u0027m worried that a comment might make things more confusing.)","commit_id":"8b30ed1d6f0dffb9fe759e596e0a6a6a53d8465c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"2b264f71d8bf298a97a40a23373cf8fd6d85df2d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    # TODO(rloo): Remove support for deprecated name \u0027clean_nodes\u0027 in N cycle"},{"line_number":172,"context_line":"    cfg.BoolOpt(\u0027automated_clean\u0027,"},{"line_number":173,"context_line":"                default\u003dTrue,"},{"line_number":174,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":175,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":176,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"},{"line_number":177,"context_line":"                       \u0027cleaning is a configurable set of steps, \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_b0976d8f","line":174,"in_reply_to":"9a8ffd7b_ce10f202","updated":"2015-12-04 17:34:03.000000000","message":"Ok Ruby. I withdraw my -ve vote. I had actually tried with config generator by only derecating option and not the group in Liberty release and didnt see this kind of awkward output.","commit_id":"8b30ed1d6f0dffb9fe759e596e0a6a6a53d8465c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9e927175093f4402471efb0f38301c512b8b458a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    # TODO(rloo): Remove support for deprecated name \u0027clean_nodes\u0027 in N cycle"},{"line_number":172,"context_line":"    cfg.BoolOpt(\u0027automated_clean\u0027,"},{"line_number":173,"context_line":"                default\u003dTrue,"},{"line_number":174,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":175,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":176,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"},{"line_number":177,"context_line":"                       \u0027cleaning is a configurable set of steps, \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_332c87ab","line":174,"in_reply_to":"9a8ffd7b_d8b75883","updated":"2015-12-03 00:26:52.000000000","message":"Without this, the generated .sample will show\n\n    Deprecated group/name - [default]/clean_nodes \n\nwhich might be a bug with the config generator.\n\nRegardless, it isn\u0027t wrong to put deprecated_group, and I didn\u0027t want to look into the config generator.","commit_id":"8b30ed1d6f0dffb9fe759e596e0a6a6a53d8465c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e8dc56728c2fb88d34fdfd66eec8e543c6b94fab","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                # This is a config that is deprecated from the same group"},{"line_number":158,"context_line":"                # as the rest of the configs in this file. The deprecated_group"},{"line_number":159,"context_line":"                # is needed though, otherwise the generator for the .sample"},{"line_number":160,"context_line":"                # file will assume the group is \u0027DEFAULT\u0027."},{"line_number":161,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":162,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":163,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_1d493cb7","line":160,"updated":"2015-12-08 14:06:17.000000000","message":"Seems like a bug in the config generator. We should open a bug against it since now the script lives in the ironic tree","commit_id":"9bd585ec9106e890ab37ebb90b44bc7ef02a2957"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1915478db33171fa4da18cc772d75857392ad98d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                # This is a config that is deprecated from the same group"},{"line_number":158,"context_line":"                # as the rest of the configs in this file. The deprecated_group"},{"line_number":159,"context_line":"                # is needed though, otherwise the generator for the .sample"},{"line_number":160,"context_line":"                # file will assume the group is \u0027DEFAULT\u0027."},{"line_number":161,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":162,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":163,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_c708b9dc","line":160,"in_reply_to":"7a740942_1d493cb7","updated":"2015-12-08 15:34:43.000000000","message":"Done. https://bugs.launchpad.net/ironic/+bug/1523958\n\nI tagged it as low-hanging-fruit; I hope that\u0027s true :)","commit_id":"9bd585ec9106e890ab37ebb90b44bc7ef02a2957"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"6f85cd68014b50e95d968c253a5df85f4782050b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                # This is a config that is deprecated from the same group"},{"line_number":158,"context_line":"                # as the rest of the configs in this file. The deprecated_group"},{"line_number":159,"context_line":"                # is needed though, otherwise the generator for the .sample"},{"line_number":160,"context_line":"                # file will assume the group is \u0027DEFAULT\u0027."},{"line_number":161,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":162,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":163,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_7a4a40c7","line":160,"updated":"2016-01-13 02:20:49.000000000","message":"Vdrok\u0027s patch is already merged, so the default deprecated_group will be the group of deprecated opt, like \u0027conductor\u0027 in this case. So the comment is incorrect now.","commit_id":"3777d157a840736860a9befcb5c6ee2c5b7c3fcd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5dfa0e79d569d2ae68d3e06d85fc32edf8d2baa9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                # This is a config that is deprecated from the same group"},{"line_number":158,"context_line":"                # as the rest of the configs in this file. The deprecated_group"},{"line_number":159,"context_line":"                # is needed though, otherwise the generator for the .sample"},{"line_number":160,"context_line":"                # file will assume the group is \u0027DEFAULT\u0027."},{"line_number":161,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":162,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":163,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_d6fd293b","line":160,"in_reply_to":"da6ed579_7a4a40c7","updated":"2016-01-13 14:34:37.000000000","message":"Yes, thanks for reminding me.","commit_id":"3777d157a840736860a9befcb5c6ee2c5b7c3fcd"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"6f85cd68014b50e95d968c253a5df85f4782050b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                # as the rest of the configs in this file. The deprecated_group"},{"line_number":159,"context_line":"                # is needed though, otherwise the generator for the .sample"},{"line_number":160,"context_line":"                # file will assume the group is \u0027DEFAULT\u0027."},{"line_number":161,"context_line":"                deprecated_group\u003d\u0027conductor\u0027,"},{"line_number":162,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":163,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"},{"line_number":164,"context_line":"                       \u0027cleaning is a configurable set of steps, \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"da6ed579_3a61283a","line":161,"updated":"2016-01-13 02:20:49.000000000","message":"deprecated_group is not needed anymore.","commit_id":"3777d157a840736860a9befcb5c6ee2c5b7c3fcd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"2656be8126aae9ef25ed7824a55757f6d4c1afaa","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027automated_clean\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                # This is a config that is deprecated from the same group"},{"line_number":158,"context_line":"                # as the rest of the configs in this file."},{"line_number":159,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":160,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"},{"line_number":161,"context_line":"                       \u0027cleaning is a configurable set of steps, \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_64f7daf5","line":158,"updated":"2016-01-13 17:04:48.000000000","message":"Nit: I\u0027m not sure I understand this comment.","commit_id":"ceded5bd432fdbe62f24b248400154d77562dbe4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd8b5b84e114995912cdaad406c3eace4cdc5bca","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027automated_clean\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                # This is a config that is deprecated from the same group"},{"line_number":158,"context_line":"                # as the rest of the configs in this file."},{"line_number":159,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"},{"line_number":160,"context_line":"                help\u003d_(\u0027Enables or disables automated cleaning. Automated \u0027"},{"line_number":161,"context_line":"                       \u0027cleaning is a configurable set of steps, \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_af1e0b61","line":158,"in_reply_to":"da6ed579_64f7daf5","updated":"2016-01-13 17:18:39.000000000","message":"Ouch, I was supposed to delete that. Thx for noticing :)","commit_id":"ceded5bd432fdbe62f24b248400154d77562dbe4"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4b51d54be4b050ce1004047fba4f7abe6f5694f6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"               default\u003d1800,"},{"line_number":152,"context_line":"               help\u003d_(\u0027Timeout (seconds) for waiting for node inspection. \u0027"},{"line_number":153,"context_line":"                      \u00270 - unlimited.\u0027)),"},{"line_number":154,"context_line":"    # TODO(rloo): Remove support for deprecated name \u0027clean_nodes\u0027 in N cycle"},{"line_number":155,"context_line":"    cfg.BoolOpt(\u0027automated_clean\u0027,"},{"line_number":156,"context_line":"                default\u003dTrue,"},{"line_number":157,"context_line":"                deprecated_name\u003d\u0027clean_nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a57f1b5_ef58bf58","line":154,"range":{"start_line":154,"start_character":70,"end_line":154,"end_character":71},"updated":"2016-02-10 15:30:15.000000000","message":"Newton is the name of the N release","commit_id":"8f5a51b158c1885c8a6339b37c8e01c0f6d94f6c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b91c293625ff3568cf31b2b882db792d1750304d","unresolved":false,"context_lines":[{"line_number":863,"context_line":"        LOG.debug(\u0027Starting %(type)s cleaning for node %(node)s\u0027,"},{"line_number":864,"context_line":"                  {\u0027type\u0027: clean_type, \u0027node\u0027: node.uuid})"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        if not manual_clean and not CONF.conductor.automated_clean:"},{"line_number":867,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":868,"context_line":"            node.clean_step \u003d None"},{"line_number":869,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":15,"id":"dae33548_242818e2","line":866,"updated":"2016-02-16 15:52:33.000000000","message":"+1. that\u0027s how deprecated_name actually works, so it\u0027s fine","commit_id":"9220cbd385d8bfd41c2465306a5dc1b56de570b6"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9f8f0ff9e8ace7bd723b23aa36e79c501f776262","unresolved":false,"context_lines":[{"line_number":863,"context_line":"        LOG.debug(\u0027Starting %(type)s cleaning for node %(node)s\u0027,"},{"line_number":864,"context_line":"                  {\u0027type\u0027: clean_type, \u0027node\u0027: node.uuid})"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        if not manual_clean and not CONF.conductor.automated_clean:"},{"line_number":867,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":868,"context_line":"            node.clean_step \u003d None"},{"line_number":869,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":15,"id":"dae33548_0e138fb9","line":866,"updated":"2016-02-16 07:25:32.000000000","message":"And another concern is users has to do the upgrade immediately, is it better to keep back compatibility for this, like\n\nautomated_clean \u003d CONF.conductor.automated_clean or CONF.conductor.clean_nodes\nif not manual_clean and automated_clean:\n  ....","commit_id":"9220cbd385d8bfd41c2465306a5dc1b56de570b6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2d4a5a9b362e92501e4d718e3a041a64b8c58e2","unresolved":false,"context_lines":[{"line_number":863,"context_line":"        LOG.debug(\u0027Starting %(type)s cleaning for node %(node)s\u0027,"},{"line_number":864,"context_line":"                  {\u0027type\u0027: clean_type, \u0027node\u0027: node.uuid})"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        if not manual_clean and not CONF.conductor.automated_clean:"},{"line_number":867,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":868,"context_line":"            node.clean_step \u003d None"},{"line_number":869,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":15,"id":"dae33548_cd2b63ea","line":866,"in_reply_to":"dae33548_0e138fb9","updated":"2016-02-16 10:52:34.000000000","message":"I think the \"deprecated_name\" will take care of this? E.g, operators will have the following in their ironic.conf:\n\n[conductor]\nclean_nodes\u003dTrue/False\n\nChanging the name and adding the old one to the \"deprecated_name\" parameter won\u0027t break them. The config parser should be smart enough to translate \"clean_nodes\" to \"automated_clean\".","commit_id":"9220cbd385d8bfd41c2465306a5dc1b56de570b6"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e1e4b6b6538a580400b63a1445b7fb166f69893a","unresolved":false,"context_lines":[{"line_number":863,"context_line":"        LOG.debug(\u0027Starting %(type)s cleaning for node %(node)s\u0027,"},{"line_number":864,"context_line":"                  {\u0027type\u0027: clean_type, \u0027node\u0027: node.uuid})"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        if not manual_clean and not CONF.conductor.automated_clean:"},{"line_number":867,"context_line":"            # Skip cleaning, move to AVAILABLE."},{"line_number":868,"context_line":"            node.clean_step \u003d None"},{"line_number":869,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":15,"id":"dae33548_3783279a","line":866,"in_reply_to":"dae33548_242818e2","updated":"2016-02-16 17:28:21.000000000","message":"Thanks to explain :)","commit_id":"9220cbd385d8bfd41c2465306a5dc1b56de570b6"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"9ceed5da58cd23c875b56a5c3ea40db63faf13bf","unresolved":false,"context_lines":[{"line_number":1625,"context_line":""},{"line_number":1626,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakePower.validate\u0027)"},{"line_number":1627,"context_line":"    def __do_node_clean_validate_fail(self, mock_validate, clean_steps\u003dNone):"},{"line_number":1628,"context_line":"        # InvalidParameterValue should be cause node to go to CLEANFAIL"},{"line_number":1629,"context_line":"        mock_validate.side_effect \u003d exception.InvalidParameterValue(\u0027error\u0027)"},{"line_number":1630,"context_line":"        tgt_prov_state \u003d states.MANAGEABLE if clean_steps else states.AVAILABLE"},{"line_number":1631,"context_line":"        node \u003d obj_utils.create_test_node("}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_b8997a21","line":1628,"updated":"2016-01-20 10:50:48.000000000","message":"It\u0027s not strictly related to this change, but it would be good to remove the superfluous \"be\" from this line.","commit_id":"55cafa361ffb906ea0094a19bc14a888d6382790"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1cdea59175ea299e8a36a042f9ec2ec55891ea8f","unresolved":false,"context_lines":[{"line_number":1625,"context_line":""},{"line_number":1626,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.fake.FakePower.validate\u0027)"},{"line_number":1627,"context_line":"    def __do_node_clean_validate_fail(self, mock_validate, clean_steps\u003dNone):"},{"line_number":1628,"context_line":"        # InvalidParameterValue should be cause node to go to CLEANFAIL"},{"line_number":1629,"context_line":"        mock_validate.side_effect \u003d exception.InvalidParameterValue(\u0027error\u0027)"},{"line_number":1630,"context_line":"        tgt_prov_state \u003d states.MANAGEABLE if clean_steps else states.AVAILABLE"},{"line_number":1631,"context_line":"        node \u003d obj_utils.create_test_node("}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_8d0cd343","line":1628,"in_reply_to":"ba63e191_b8997a21","updated":"2016-01-20 17:12:31.000000000","message":"If I do another revision.","commit_id":"55cafa361ffb906ea0094a19bc14a888d6382790"}],"releasenotes/notes/automated_clean_config-0170c95ae210f953.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"2656be8126aae9ef25ed7824a55757f6d4c1afaa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The [conductor]/clean_nodes config is deprecated and has been replaced"},{"line_number":4,"context_line":"    by the [conductor]/automated_clean config. The [conductor]/clean_nodes"},{"line_number":5,"context_line":"    config  will be removed in the N* cycle."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da6ed579_a4d4f246","line":5,"updated":"2016-01-13 17:04:48.000000000","message":"nit: extra space between config and will.","commit_id":"ceded5bd432fdbe62f24b248400154d77562dbe4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"bd8b5b84e114995912cdaad406c3eace4cdc5bca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The [conductor]/clean_nodes config is deprecated and has been replaced"},{"line_number":4,"context_line":"    by the [conductor]/automated_clean config. The [conductor]/clean_nodes"},{"line_number":5,"context_line":"    config  will be removed in the N* cycle."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da6ed579_af35abda","line":5,"in_reply_to":"da6ed579_a4d4f246","updated":"2016-01-13 17:18:39.000000000","message":"oops.","commit_id":"ceded5bd432fdbe62f24b248400154d77562dbe4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6829e5043b093a9dee410a554f4ae8d630f0a07c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The [conductor]/clean_nodes config is deprecated and has been replaced"},{"line_number":4,"context_line":"    by the [conductor]/automated_clean config. The [conductor]/clean_nodes"},{"line_number":5,"context_line":"    config will be removed in the N* cycle."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5a5ae5dd_6b6da3cb","line":2,"updated":"2016-02-09 16:46:18.000000000","message":"there is a separate \"deprecations\" section which IMO is more appropriate, as this change didn\u0027t yet affect the upgrade","commit_id":"8fb5571c3ac02ecb72bc2b5b46fe962aa5484881"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"415f24f5cc741b8cb455ff72f629b3e9756822b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The [conductor]/clean_nodes config is deprecated and has been replaced"},{"line_number":4,"context_line":"    by the [conductor]/automated_clean config. The [conductor]/clean_nodes"},{"line_number":5,"context_line":"    config will be removed in the N* cycle."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5a5ae5dd_a6499290","line":2,"in_reply_to":"5a5ae5dd_6b6da3cb","updated":"2016-02-09 17:12:59.000000000","message":"Oh. I wonder if the deprecations section is new. I\u0027ll update this. I see that when I wrote this, we didn\u0027t know the name of the N* cycle.","commit_id":"8fb5571c3ac02ecb72bc2b5b46fe962aa5484881"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4b51d54be4b050ce1004047fba4f7abe6f5694f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The [conductor]/clean_nodes config is deprecated and will be removed in the"},{"line_number":4,"context_line":"    Neutron cycle. It has been replaced by the [conductor]/automated_clean"},{"line_number":5,"context_line":"    config."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3a57f1b5_efaaff18","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":11},"updated":"2016-02-10 15:30:15.000000000","message":"Newton is the name of the N release","commit_id":"8f5a51b158c1885c8a6339b37c8e01c0f6d94f6c"}]}