)]}'
{"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"83463f8c69fbd5189a7e3bc629063639a7e80bde","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        _remove_share_file(_get_boot_iso_name(task.node))"},{"line_number":660,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":661,"context_line":"        driver_internal_info.pop(\u0027irmc_boot_iso\u0027, None)"},{"line_number":662,"context_line":"        driver_internal_info.pop(\u0027root_uuid_or_disk_id\u0027, None)"},{"line_number":663,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":664,"context_line":"        task.node.save()"},{"line_number":665,"context_line":"        cleanup_vmedia_boot(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_3a236abf","line":662,"updated":"2015-11-25 09:48:23.000000000","message":"let me correct the bug first before refactoring iscsi_deploy.py.","commit_id":"0d282662d41b9482d7f1dd3cce5dc9a807b0e8e0"}],"ironic/tests/unit/drivers/modules/irmc/test_boot.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"23f7b2ff94c549de4e0442409b0de214703402c6","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"                irmc_boot._get_boot_iso_name(task.node))"},{"line_number":1002,"context_line":"            self.assertFalse("},{"line_number":1003,"context_line":"                task.node.driver_internal_info.get(\u0027irmc_boot_iso\u0027))"},{"line_number":1004,"context_line":"            self.assertFalse("},{"line_number":1005,"context_line":"                task.node.driver_internal_info.get(\u0027root_uuid_or_disk_id\u0027))"},{"line_number":1006,"context_line":"            _cleanup_vmedia_boot_mock.assert_called_once_with(task)"},{"line_number":1007,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_3b51fe62","line":1004,"updated":"2015-11-26 00:39:25.000000000","message":"Maybe assertIsNone?\n\nOr better yet: self.assertNotIn(task.node.driver_internal_info, \u0027root_uuid_or_disk_id\u0027)","commit_id":"eccf2b22917d60cfa6bcacf10e84aa5bf1a02627"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"8216c3803397130f09dc871970f52cefadc60ff3","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"                irmc_boot._get_boot_iso_name(task.node))"},{"line_number":1002,"context_line":"            self.assertFalse("},{"line_number":1003,"context_line":"                task.node.driver_internal_info.get(\u0027irmc_boot_iso\u0027))"},{"line_number":1004,"context_line":"            self.assertFalse("},{"line_number":1005,"context_line":"                task.node.driver_internal_info.get(\u0027root_uuid_or_disk_id\u0027))"},{"line_number":1006,"context_line":"            _cleanup_vmedia_boot_mock.assert_called_once_with(task)"},{"line_number":1007,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_762a3d2e","line":1004,"in_reply_to":"9a8ffd7b_3b51fe62","updated":"2015-11-26 01:01:55.000000000","message":"oh, yes, it\u0027s much better, I\u0027ll fix that, thanks! Jim.","commit_id":"eccf2b22917d60cfa6bcacf10e84aa5bf1a02627"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"84611e4f292cbf8adb122824127297ac47a1ed43","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"            self.assertNotIn(task.node.driver_internal_info,"},{"line_number":1003,"context_line":"                             \u0027irmc_boot_iso\u0027)"},{"line_number":1004,"context_line":"            self.assertNotIn(task.node.driver_internal_info,"},{"line_number":1005,"context_line":"                             \u0027root_uuid_or_disk_id\u0027)"},{"line_number":1006,"context_line":"            _cleanup_vmedia_boot_mock.assert_called_once_with(task)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    @mock.patch.object(manager_utils, \u0027node_set_boot_device\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_8fd3d103","line":1005,"updated":"2015-11-26 21:06:14.000000000","message":"It should be the other way around [1] \"Test that first is (or is not) in second.\"\n\n[1] https://docs.python.org/2.7/library/unittest.html#unittest.TestCase.assertNotIn","commit_id":"93f61f5f0b1555a7fb24754183780ea862be9328"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"810edfe9e297e24fe64ebe6a84d1af9328fb0de5","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"            self.assertNotIn(task.node.driver_internal_info,"},{"line_number":1003,"context_line":"                             \u0027irmc_boot_iso\u0027)"},{"line_number":1004,"context_line":"            self.assertNotIn(task.node.driver_internal_info,"},{"line_number":1005,"context_line":"                             \u0027root_uuid_or_disk_id\u0027)"},{"line_number":1006,"context_line":"            _cleanup_vmedia_boot_mock.assert_called_once_with(task)"},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"    @mock.patch.object(manager_utils, \u0027node_set_boot_device\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_55049816","line":1005,"in_reply_to":"9a8ffd7b_8fd3d103","updated":"2015-11-27 00:04:27.000000000","message":"I got it, I\u0027ll fix that, thanks!, ruby.","commit_id":"93f61f5f0b1555a7fb24754183780ea862be9328"}]}
