)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32dc51e4c74976403e30642546ac346fe31f6c03","unresolved":false,"context_lines":[{"line_number":225,"context_line":"# along with this option. This option is ignored if"},{"line_number":226,"context_line":"# log_config_append is set. (boolean value)"},{"line_number":227,"context_line":"# This option is deprecated for removal."},{"line_number":228,"context_line":"# Its value may be silently ignored in the future."},{"line_number":229,"context_line":"#use_syslog_rfc_format\u003dtrue"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# Syslog facility to receive log lines. This option is ignored"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_0a819cfb","line":228,"updated":"2015-11-30 20:00:43.000000000","message":"I don\u0027t think this provides much value; the help string is clearer.","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32dc51e4c74976403e30642546ac346fe31f6c03","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"# Type of endpoint to use for temporary URLs. If the Glance"},{"line_number":1040,"context_line":"# backend is Swift, use \"swift\"; if it is CEPH with RADOS"},{"line_number":1041,"context_line":"# gateway, use \"radosgw\". (string value)"},{"line_number":1042,"context_line":"# Allowed values: swift, radosgw"},{"line_number":1043,"context_line":"#temp_url_endpoint_type\u003dswift"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_8aacac8d","line":1042,"updated":"2015-11-30 20:00:43.000000000","message":"I actually prefer \u0027Possible\u0027 instead of \u0027Allowed\u0027. Not sure what the right terminology is though. (\u0027Allow\u0027 just makes me think that I need permission to do something, so it might just be my own bias against that term.)","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32dc51e4c74976403e30642546ac346fe31f6c03","unresolved":false,"context_lines":[{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"# Default glance port. (port value)"},{"line_number":1054,"context_line":"# Minimum value: 1"},{"line_number":1055,"context_line":"# Maximum value: 65535"},{"line_number":1056,"context_line":"#glance_port\u003d9292"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"# Default protocol to use when connecting to glance. Set to"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_ca25d40a","line":1055,"updated":"2015-11-30 20:00:43.000000000","message":"what do you think about putting these two in one line. Eg \u0027Minimum value;1; maximum value: 65535\u0027.\n\nOr \u0027Possible values: 1 - 65535\u0027.\n\nOr \u0027Allowed values: 1 - 65535\u0027 :)","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"4947279385e54256aada944b3c794343513e267e","unresolved":false,"context_lines":[{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"# Default glance port. (port value)"},{"line_number":1054,"context_line":"# Minimum value: 1"},{"line_number":1055,"context_line":"# Maximum value: 65535"},{"line_number":1056,"context_line":"#glance_port\u003d9292"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"# Default protocol to use when connecting to glance. Set to"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_2df7c8f6","line":1055,"in_reply_to":"9a8ffd7b_ca25d40a","updated":"2015-12-01 08:29:43.000000000","message":"The tricky thing is it is possible to only assign min or max value for Opt. This could be done but we need an addition decision condition.","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32dc51e4c74976403e30642546ac346fe31f6c03","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"# Port to be used for iRMC operations, either 80 or 443 (port"},{"line_number":1258,"context_line":"# value)"},{"line_number":1259,"context_line":"# Minimum value: 1"},{"line_number":1260,"context_line":"# Maximum value: 65535"},{"line_number":1261,"context_line":"#port\u003d443"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"# Authentication method to be used for iRMC operations, either"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_0adc3c45","line":1260,"updated":"2015-11-30 20:00:43.000000000","message":"Sigh. This doesn\u0027t look good. The only possible values are 80 or 443 :-(\n\nIt would be good to fix the irmc config first, before approving this patch.","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"4947279385e54256aada944b3c794343513e267e","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"# Port to be used for iRMC operations, either 80 or 443 (port"},{"line_number":1258,"context_line":"# value)"},{"line_number":1259,"context_line":"# Minimum value: 1"},{"line_number":1260,"context_line":"# Maximum value: 65535"},{"line_number":1261,"context_line":"#port\u003d443"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"# Authentication method to be used for iRMC operations, either"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_3f98536a","line":1260,"in_reply_to":"9a8ffd7b_0adc3c45","updated":"2015-12-01 08:29:43.000000000","message":"This is a little complicated. Only StrOpt support choices, so we have two options, one is convert iRMC.port into StrOpt or make PortOpt accept choices. I prefer the second.\nI propose a patch for this https://review.openstack.org/#/c/251700/","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32dc51e4c74976403e30642546ac346fe31f6c03","unresolved":false,"context_lines":[{"line_number":1945,"context_line":""},{"line_number":1946,"context_line":"# The IP version that will be used for PXE booting. Can be"},{"line_number":1947,"context_line":"# either 4 or 6. Defaults to 4. EXPERIMENTAL (string value)"},{"line_number":1948,"context_line":"# Allowed values: 4, 6"},{"line_number":1949,"context_line":"#ip_version\u003d4"},{"line_number":1950,"context_line":""},{"line_number":1951,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_aac4105f","line":1948,"updated":"2015-11-30 20:00:43.000000000","message":"If we put this \u0027Allowed values..\u0027 here, should we change the help string so that it doesn\u0027t say \u0027Can be either 4 or 6. Defaults to 4.\u0027?\n\nNot a blocker for this patch, can be done later. Just commenting.","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"d5bd53241f7299cc058e9c46e0a5647dbafc27c1","unresolved":false,"context_lines":[{"line_number":1945,"context_line":""},{"line_number":1946,"context_line":"# The IP version that will be used for PXE booting. Can be"},{"line_number":1947,"context_line":"# either 4 or 6. Defaults to 4. EXPERIMENTAL (string value)"},{"line_number":1948,"context_line":"# Allowed values: 4, 6"},{"line_number":1949,"context_line":"#ip_version\u003d4"},{"line_number":1950,"context_line":""},{"line_number":1951,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_c64e1196","line":1948,"in_reply_to":"9a8ffd7b_0d98c469","updated":"2015-12-01 10:51:06.000000000","message":"hoops, make a mistake, this is only for version, not for IP address","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"4947279385e54256aada944b3c794343513e267e","unresolved":false,"context_lines":[{"line_number":1945,"context_line":""},{"line_number":1946,"context_line":"# The IP version that will be used for PXE booting. Can be"},{"line_number":1947,"context_line":"# either 4 or 6. Defaults to 4. EXPERIMENTAL (string value)"},{"line_number":1948,"context_line":"# Allowed values: 4, 6"},{"line_number":1949,"context_line":"#ip_version\u003d4"},{"line_number":1950,"context_line":""},{"line_number":1951,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_0d98c469","line":1948,"in_reply_to":"9a8ffd7b_aac4105f","updated":"2015-12-01 08:29:43.000000000","message":"Get it. BTW, oslo_config provide IPOpt but this is not support by ironic\u0027s generator. It\u0027s better to do this first. :)","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2217924e1b88621917b10000b616b2b1d9310aa4","unresolved":false,"context_lines":[{"line_number":534,"context_line":"#host_ip\u003d0.0.0.0"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"# The TCP port on which ironic-api listens. (port value)"},{"line_number":537,"context_line":"# Possible values: 1-65535"},{"line_number":538,"context_line":"#port\u003d6385"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"# The maximum number of items returned in a single response"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"7a5de9d1_b31fa6b6","line":537,"updated":"2016-02-02 19:38:03.000000000","message":"when I look at ironic/api/__init__.py, we didn\u0027t code it with min/max/choices. Is oslo setting min/max based on the value being an integer?\n\nyeah, I just looked at oslo.config and it looks like it is setting min/max.","commit_id":"e055101075f636fbae865dea30a5584c91de3580"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"69b161f52b725a58f8e757ad61e1787eb2a468d3","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"# IP of remote image server (string value)"},{"line_number":1279,"context_line":"#remote_image_server\u003d\u003cNone\u003e"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"# Share type of virtual media, either \"NFS\" or \"CIFS\" (string"},{"line_number":1282,"context_line":"# value)"},{"line_number":1283,"context_line":"# Possible values: CIFS, NFS"},{"line_number":1284,"context_line":"#remote_image_share_type\u003dCIFS"},{"line_number":1285,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"dae33548_69bc90dc","line":1282,"range":{"start_line":1281,"start_character":31,"end_line":1282,"end_character":8},"updated":"2016-02-17 09:02:09.000000000","message":"Not only here but also some other parts like \"either xxx or yyy\" will be unnecessary. How about removing these deprecated strings? It\u0027s OK with separated patches, of course.","commit_id":"bf8186b4a8708f0124e356d09999b46853a99d2b"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"3f59c82a2b5a47044d5aee448dd47a2ff42fc821","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"# IP of remote image server (string value)"},{"line_number":1279,"context_line":"#remote_image_server\u003d\u003cNone\u003e"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"# Share type of virtual media, either \"NFS\" or \"CIFS\" (string"},{"line_number":1282,"context_line":"# value)"},{"line_number":1283,"context_line":"# Possible values: CIFS, NFS"},{"line_number":1284,"context_line":"#remote_image_share_type\u003dCIFS"},{"line_number":1285,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"dae33548_8bd38c5f","line":1282,"range":{"start_line":1281,"start_character":31,"end_line":1282,"end_character":8},"in_reply_to":"dae33548_69bc90dc","updated":"2016-02-18 06:46:41.000000000","message":"Thanks Yuiko, there is a separate patch indeed. :)\nhttps://review.openstack.org/#/c/260365/","commit_id":"bf8186b4a8708f0124e356d09999b46853a99d2b"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"dd8e6bb6e1e457f6797b323761a533acfb90fd9e","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"# IP of remote image server (string value)"},{"line_number":1279,"context_line":"#remote_image_server\u003d\u003cNone\u003e"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"# Share type of virtual media, either \"NFS\" or \"CIFS\" (string"},{"line_number":1282,"context_line":"# value)"},{"line_number":1283,"context_line":"# Possible values: CIFS, NFS"},{"line_number":1284,"context_line":"#remote_image_share_type\u003dCIFS"},{"line_number":1285,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"dae33548_46497bb6","line":1282,"range":{"start_line":1281,"start_character":31,"end_line":1282,"end_character":8},"in_reply_to":"dae33548_8bd38c5f","updated":"2016-02-18 07:28:44.000000000","message":"Thanks, I couldn\u0027t find it ;)","commit_id":"bf8186b4a8708f0124e356d09999b46853a99d2b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"62a426aef5d2162c9b6319405ffd44503ec8ba88","unresolved":false,"context_lines":[{"line_number":323,"context_line":"#use_pub_sub\u003dtrue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Minimal port number for random ports range. (port value)"},{"line_number":326,"context_line":"# Possible values: 0-65535"},{"line_number":327,"context_line":"#rpc_zmq_min_port\u003d49152"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"# Maximal port number for random ports range. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7af24918_470d763d","line":326,"range":{"start_line":326,"start_character":19,"end_line":326,"end_character":20},"updated":"2016-03-02 11:31:43.000000000","message":"0 is not valid port number","commit_id":"e38f345709032a50ebd9d9435937ee3e3ac69406"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ea7d0a76a58724acc5a4ebcc1cff4b736b299fdf","unresolved":false,"context_lines":[{"line_number":323,"context_line":"#use_pub_sub\u003dtrue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Minimal port number for random ports range. (port value)"},{"line_number":326,"context_line":"# Possible values: 0-65535"},{"line_number":327,"context_line":"#rpc_zmq_min_port\u003d49152"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"# Maximal port number for random ports range. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7af24918_ebff28ff","line":326,"range":{"start_line":326,"start_character":19,"end_line":326,"end_character":20},"in_reply_to":"7af24918_470d763d","updated":"2016-03-02 13:00:10.000000000","message":"It\u0027s not related to this patch. This is oslo.messaging issue.","commit_id":"e38f345709032a50ebd9d9435937ee3e3ac69406"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"dadf5cab6e4a5dd4b462b0d07f16fbde8fff1fa3","unresolved":false,"context_lines":[{"line_number":323,"context_line":"#use_pub_sub\u003dtrue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Minimal port number for random ports range. (port value)"},{"line_number":326,"context_line":"# Possible values: 0-65535"},{"line_number":327,"context_line":"#rpc_zmq_min_port\u003d49152"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"# Maximal port number for random ports range. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7af24918_a515124a","line":326,"range":{"start_line":326,"start_character":19,"end_line":326,"end_character":20},"in_reply_to":"7af24918_a96cd6d0","updated":"2016-03-03 05:53:49.000000000","message":"+1, we can keep 0-65535 here.","commit_id":"e38f345709032a50ebd9d9435937ee3e3ac69406"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"056f65f37730a7dcb85b9b27b92d7521626097c4","unresolved":false,"context_lines":[{"line_number":323,"context_line":"#use_pub_sub\u003dtrue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Minimal port number for random ports range. (port value)"},{"line_number":326,"context_line":"# Possible values: 0-65535"},{"line_number":327,"context_line":"#rpc_zmq_min_port\u003d49152"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"# Maximal port number for random ports range. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7af24918_e3338f60","line":326,"range":{"start_line":326,"start_character":19,"end_line":326,"end_character":20},"in_reply_to":"7af24918_a96cd6d0","updated":"2016-03-03 07:46:23.000000000","message":"you are right, it is not a problem of current patch.","commit_id":"e38f345709032a50ebd9d9435937ee3e3ac69406"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9b17a0eb3eca6cddf9dcb0ac212c5beede4d86b0","unresolved":false,"context_lines":[{"line_number":323,"context_line":"#use_pub_sub\u003dtrue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Minimal port number for random ports range. (port value)"},{"line_number":326,"context_line":"# Possible values: 0-65535"},{"line_number":327,"context_line":"#rpc_zmq_min_port\u003d49152"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"# Maximal port number for random ports range. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7af24918_a96cd6d0","line":326,"range":{"start_line":326,"start_character":19,"end_line":326,"end_character":20},"in_reply_to":"7af24918_c40859dc","updated":"2016-03-03 01:43:23.000000000","message":"Hi Vasyl, 0 is not valid port number indeed. But there was a reason for this. Because some projects want to assign 0 to the port to indicate this port will get a automatic value. So that\u0027s why PortOption has the minimal value of 0 and that\u0027s why the possible values for this option is 0-65535.\n\nBTW, as guys said, this is not a issue could solved by this patch....","commit_id":"e38f345709032a50ebd9d9435937ee3e3ac69406"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a934c068f48d7ed9cf9530fe2dd4788961dfafdf","unresolved":false,"context_lines":[{"line_number":323,"context_line":"#use_pub_sub\u003dtrue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Minimal port number for random ports range. (port value)"},{"line_number":326,"context_line":"# Possible values: 0-65535"},{"line_number":327,"context_line":"#rpc_zmq_min_port\u003d49152"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"# Maximal port number for random ports range. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7af24918_d5b722d6","line":326,"range":{"start_line":326,"start_character":19,"end_line":326,"end_character":20},"in_reply_to":"7af24918_e3338f60","updated":"2016-03-03 10:25:57.000000000","message":"Agreed, binding to 0 as an automatic assignment is a common behavior","commit_id":"e38f345709032a50ebd9d9435937ee3e3ac69406"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"fb7d7b2d98ce57c743ce25bad0ee84d00f29695a","unresolved":false,"context_lines":[{"line_number":323,"context_line":"#use_pub_sub\u003dtrue"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Minimal port number for random ports range. (port value)"},{"line_number":326,"context_line":"# Possible values: 0-65535"},{"line_number":327,"context_line":"#rpc_zmq_min_port\u003d49152"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"# Maximal port number for random ports range. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"7af24918_c40859dc","line":326,"range":{"start_line":326,"start_character":19,"end_line":326,"end_character":20},"in_reply_to":"7af24918_ebff28ff","updated":"2016-03-02 13:39:49.000000000","message":"++","commit_id":"e38f345709032a50ebd9d9435937ee3e3ac69406"}],"ironic/common/config_generator/generator.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"32dc51e4c74976403e30642546ac346fe31f6c03","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if opt.deprecated_for_removal:"},{"line_number":300,"context_line":"        print (\u0027# This option is deprecated for removal.\u0027)"},{"line_number":301,"context_line":"        print (\u0027# Its value may be silently ignored in the future.\u0027)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    if opt.deprecated_opts:"},{"line_number":304,"context_line":"        for deprecated_opt in opt.deprecated_opts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_6a670826","line":301,"updated":"2015-11-30 20:00:43.000000000","message":"This is interesting. We don\u0027t use this flag in our code, although we\u0027ve got configs that are deprecated. I am wondering how useful this is, and the \u0027Its value may be silently ignored...\u0027 worries me. \u0027In the next release\u0027 gives more feedback than \u0027in the future\u0027.\n\nI think I\u0027d prefer that we didn\u0027t put this, and that the configs themselves, mention in their help, when it might be removed. Eg, see agent_pxe_append_params [1].\n\n\n[1] https://review.openstack.org/#/c/250132/1/etc/ironic/ironic.conf.sample","commit_id":"4023f45beb68e1be389e8efa8f76a0de08e493d6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f5c0d5b7d49b09815cdab2472c37a7e2ee2bf823","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        print(\u0027# Possible values: %(min_value)s-%(max_value)s\u0027 %"},{"line_number":295,"context_line":"              {\u0027min_value\u0027: min_value, \u0027max_value\u0027: max_value})"},{"line_number":296,"context_line":"    elif min_value:"},{"line_number":297,"context_line":"        print(\u0027# Minimum value: %d\u0027 % opt.type.min)"},{"line_number":298,"context_line":"    elif max_value:"},{"line_number":299,"context_line":"        print(\u0027# Maximum value: %d\u0027 % opt.type.max)"},{"line_number":300,"context_line":"    elif choices:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_7e40e2a5","line":297,"updated":"2016-01-13 11:21:40.000000000","message":"You can just use min_value","commit_id":"c407d749faa70d710365cfd6305c6ca754fd93d7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f5c0d5b7d49b09815cdab2472c37a7e2ee2bf823","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    elif min_value:"},{"line_number":297,"context_line":"        print(\u0027# Minimum value: %d\u0027 % opt.type.min)"},{"line_number":298,"context_line":"    elif max_value:"},{"line_number":299,"context_line":"        print(\u0027# Maximum value: %d\u0027 % opt.type.max)"},{"line_number":300,"context_line":"    elif choices:"},{"line_number":301,"context_line":"        choices_text \u003d \u0027, \u0027.join([_get_choice_text(choice)"},{"line_number":302,"context_line":"                                  for choice in opt.type.choices])"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_3e4a6ac6","line":299,"updated":"2016-01-13 11:21:40.000000000","message":"ditto","commit_id":"c407d749faa70d710365cfd6305c6ca754fd93d7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f5c0d5b7d49b09815cdab2472c37a7e2ee2bf823","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        print(\u0027# Minimum value: %d\u0027 % opt.type.min)"},{"line_number":298,"context_line":"    elif max_value:"},{"line_number":299,"context_line":"        print(\u0027# Maximum value: %d\u0027 % opt.type.max)"},{"line_number":300,"context_line":"    elif choices:"},{"line_number":301,"context_line":"        choices_text \u003d \u0027, \u0027.join([_get_choice_text(choice)"},{"line_number":302,"context_line":"                                  for choice in opt.type.choices])"},{"line_number":303,"context_line":"        print(\u0027# Possible values: %s\u0027 % choices_text)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_f274039d","line":300,"updated":"2016-01-13 11:21:40.000000000","message":"Not sure if it is something that is needed, but when choices\u003d[], there is nothing being output. e.g. StrOpt(\u0027opt\u0027, choices\u003d[]) So maybe it is worth wrapping choices_text in brackets:\n\n ...\n elif choices is not None:\n     ...\n     print(\u0027# Possible values: [%s]\u0027 % choices_text)","commit_id":"c407d749faa70d710365cfd6305c6ca754fd93d7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"5edc076194d1a609712cdd8365ccda1fa935c2cd","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        print(\u0027# Minimum value: %d\u0027 % opt.type.min)"},{"line_number":298,"context_line":"    elif max_value:"},{"line_number":299,"context_line":"        print(\u0027# Maximum value: %d\u0027 % opt.type.max)"},{"line_number":300,"context_line":"    elif choices:"},{"line_number":301,"context_line":"        choices_text \u003d \u0027, \u0027.join([_get_choice_text(choice)"},{"line_number":302,"context_line":"                                  for choice in opt.type.choices])"},{"line_number":303,"context_line":"        print(\u0027# Possible values: %s\u0027 % choices_text)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_bf4cd49e","line":300,"in_reply_to":"da6ed579_f274039d","updated":"2016-01-14 10:26:46.000000000","message":"Thanks, missing the case of choices\u003d[]","commit_id":"c407d749faa70d710365cfd6305c6ca754fd93d7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f5c0d5b7d49b09815cdab2472c37a7e2ee2bf823","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        print(\u0027# Maximum value: %d\u0027 % opt.type.max)"},{"line_number":300,"context_line":"    elif choices:"},{"line_number":301,"context_line":"        choices_text \u003d \u0027, \u0027.join([_get_choice_text(choice)"},{"line_number":302,"context_line":"                                  for choice in opt.type.choices])"},{"line_number":303,"context_line":"        print(\u0027# Possible values: %s\u0027 % choices_text)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    if opt.deprecated_opts:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_fe1292b3","line":302,"updated":"2016-01-13 11:21:40.000000000","message":"ditto","commit_id":"c407d749faa70d710365cfd6305c6ca754fd93d7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2217924e1b88621917b10000b616b2b1d9310aa4","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        print(\u0027# Minimum value: %d\u0027 % min_value)"},{"line_number":298,"context_line":"    elif max_value:"},{"line_number":299,"context_line":"        print(\u0027# Maximum value: %d\u0027 % max_value)"},{"line_number":300,"context_line":"    elif choices is not None:"},{"line_number":301,"context_line":"        if choices \u003d\u003d []:"},{"line_number":302,"context_line":"            choices_text \u003d \u0027None\u0027"},{"line_number":303,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_be020db3","line":300,"updated":"2016-02-02 19:38:03.000000000","message":"is it possible for a config to have choice specified AND min_value or max_value?\n\nI just looked at oslo.config and they are mutually exclusive. A comment would have been useful here.","commit_id":"e055101075f636fbae865dea30a5584c91de3580"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"7d206ec8657c3d250ff1d41c5f33c42c67af56b7","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        print(\u0027# Minimum value: %d\u0027 % min_value)"},{"line_number":298,"context_line":"    elif max_value:"},{"line_number":299,"context_line":"        print(\u0027# Maximum value: %d\u0027 % max_value)"},{"line_number":300,"context_line":"    elif choices is not None:"},{"line_number":301,"context_line":"        if choices \u003d\u003d []:"},{"line_number":302,"context_line":"            choices_text \u003d \u0027None\u0027"},{"line_number":303,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_534f34bd","line":300,"in_reply_to":"7a5de9d1_be020db3","updated":"2016-02-04 02:37:16.000000000","message":"Done","commit_id":"e055101075f636fbae865dea30a5584c91de3580"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2217924e1b88621917b10000b616b2b1d9310aa4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        else:"},{"line_number":304,"context_line":"            choices_text \u003d \u0027, \u0027.join([_get_choice_text(choice)"},{"line_number":305,"context_line":"                                     for choice in choices])"},{"line_number":306,"context_line":"        print(\u0027# Possible values: %s\u0027 % choices_text)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    if opt.deprecated_opts:"},{"line_number":309,"context_line":"        for deprecated_opt in opt.deprecated_opts:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_1ea00190","line":306,"updated":"2016-02-02 19:38:03.000000000","message":"I was wondering what it meant if choices \u003d\u003d [], you\u0027d see \u0027Possible values: None\u0027.\n\nIf choices \u003d\u003d [], does it mean that there are no possible choices? I can\u0027t think of when choices would be [] unless someone wanted to disable a feature or something. Anyway -- if it means there are no possible choices, maybe we should print \u0027No possible values\u0027.","commit_id":"e055101075f636fbae865dea30a5584c91de3580"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"7d206ec8657c3d250ff1d41c5f33c42c67af56b7","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        else:"},{"line_number":304,"context_line":"            choices_text \u003d \u0027, \u0027.join([_get_choice_text(choice)"},{"line_number":305,"context_line":"                                     for choice in choices])"},{"line_number":306,"context_line":"        print(\u0027# Possible values: %s\u0027 % choices_text)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    if opt.deprecated_opts:"},{"line_number":309,"context_line":"        for deprecated_opt in opt.deprecated_opts:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_1600ca00","line":306,"in_reply_to":"7a5de9d1_1ea00190","updated":"2016-02-04 02:37:16.000000000","message":"This is really a concern case, another case could be developer\u0027s misuse the choices\u003d\u003d[], without this one, there will be nothing output. And I agree to print \u0027No possible values\u0027","commit_id":"e055101075f636fbae865dea30a5584c91de3580"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b9311d91abf6a99fcea52f0405cabdbd34751630","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    choices \u003d getattr(opt.type, \u0027choices\u0027, None)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    # 0 is a possible value for \u0027min/max\u0027, but it is a False value"},{"line_number":291,"context_line":"    # in Python, so covert it to a String."},{"line_number":292,"context_line":"    min_value \u003d \u00270\u0027 if min_value \u003d\u003d 0 else min_value"},{"line_number":293,"context_line":"    max_value \u003d \u00270\u0027 if max_value \u003d\u003d 0 else max_value"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_ee4081a7","line":291,"updated":"2016-02-04 20:25:07.000000000","message":"s/covert/convert/","commit_id":"17039107a045f3c79de159a7e8d44bf6cf62153e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b9311d91abf6a99fcea52f0405cabdbd34751630","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    # 0 is a possible value for \u0027min/max\u0027, but it is a False value"},{"line_number":291,"context_line":"    # in Python, so covert it to a String."},{"line_number":292,"context_line":"    min_value \u003d \u00270\u0027 if min_value \u003d\u003d 0 else min_value"},{"line_number":293,"context_line":"    max_value \u003d \u00270\u0027 if max_value \u003d\u003d 0 else max_value"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    # NOTE(lintan): choices are mutually exclusive with \u0027min/max\u0027,"},{"line_number":296,"context_line":"    # see oslo.config for more details."}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_d951d1d9","line":293,"updated":"2016-02-04 20:25:07.000000000","message":"I don\u0027t like the special case for zero. I think it is better to distinguish None from an integral value.\n\nYou could do eg:\nA) min_value \u003d six.text_type(min_value) if min_value is not None else min_value. similar for max_value\nB) below, in the if statements, be more precise and eg \u0027if min_value is not None and max_value is not None\u0027: ...","commit_id":"17039107a045f3c79de159a7e8d44bf6cf62153e"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"00a525fe0f5d9014b4971b222f6c30c4111ebccd","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    # 0 is a possible value for \u0027min/max\u0027, but it is a False value"},{"line_number":291,"context_line":"    # in Python, so covert it to a String."},{"line_number":292,"context_line":"    min_value \u003d \u00270\u0027 if min_value \u003d\u003d 0 else min_value"},{"line_number":293,"context_line":"    max_value \u003d \u00270\u0027 if max_value \u003d\u003d 0 else max_value"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    # NOTE(lintan): choices are mutually exclusive with \u0027min/max\u0027,"},{"line_number":296,"context_line":"    # see oslo.config for more details."}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_52dd7441","line":293,"in_reply_to":"5a5ae5dd_d951d1d9","updated":"2016-02-15 03:08:03.000000000","message":"OK, this looks better. Thanks Ruby","commit_id":"17039107a045f3c79de159a7e8d44bf6cf62153e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"d9b8567c79375483559f608126fd460048760dd0","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    # 0 is a possible value for \u0027min/max\u0027, but it is a False value"},{"line_number":293,"context_line":"    # in Python, so convert Integer to String."},{"line_number":294,"context_line":"    if min_value is not None:"},{"line_number":295,"context_line":"        min_value \u003d six.text_type(min_value)"},{"line_number":296,"context_line":"    if max_value is not None:"},{"line_number":297,"context_line":"        max_value \u003d six.text_type(max_value)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_6a1a5dc7","line":294,"updated":"2016-02-24 15:15:03.000000000","message":"1) These checks l294-296 is not needed because there are in 301-308. 2) six.text_type() is not needed for numbers, %s string conversion l302-307 is good enough.","commit_id":"bf8186b4a8708f0124e356d09999b46853a99d2b"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"55f1b1836b12293c52bd88e460951f266dc825e6","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    # 0 is a possible value for \u0027min/max\u0027, but it is a False value"},{"line_number":293,"context_line":"    # in Python, so convert Integer to String."},{"line_number":294,"context_line":"    if min_value is not None:"},{"line_number":295,"context_line":"        min_value \u003d six.text_type(min_value)"},{"line_number":296,"context_line":"    if max_value is not None:"},{"line_number":297,"context_line":"        max_value \u003d six.text_type(max_value)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_bea91c7e","line":294,"in_reply_to":"bae84128_6a1a5dc7","updated":"2016-02-25 05:31:31.000000000","message":"thanks, you are right.","commit_id":"bf8186b4a8708f0124e356d09999b46853a99d2b"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"e661a41698d1a7ff34b6fb74443dcf31e4a91b98","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        print(\u0027# Possible values: %(min_value)s-%(max_value)s\u0027 %"},{"line_number":296,"context_line":"              {\u0027min_value\u0027: min_value, \u0027max_value\u0027: max_value})"},{"line_number":297,"context_line":"    elif min_value is not None:"},{"line_number":298,"context_line":"        print(\u0027# Minimum value: %s\u0027 % min_value)"},{"line_number":299,"context_line":"    elif max_value is not None:"},{"line_number":300,"context_line":"        print(\u0027# Maximum value: %s\u0027 % max_value)"},{"line_number":301,"context_line":"    elif choices is not None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_f5961c93","line":298,"range":{"start_line":298,"start_character":31,"end_line":298,"end_character":34},"updated":"2016-02-26 07:34:03.000000000","message":"just want to know why this need to convert to string instead of using \u0027%d\u0027 directly.","commit_id":"754c4bc28c00e35fdd55ad6c7d964489870d2bcc"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"8eb897a57a9fa0e419c1dee00c4d6ad39090e2b2","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        print(\u0027# Possible values: %(min_value)s-%(max_value)s\u0027 %"},{"line_number":296,"context_line":"              {\u0027min_value\u0027: min_value, \u0027max_value\u0027: max_value})"},{"line_number":297,"context_line":"    elif min_value is not None:"},{"line_number":298,"context_line":"        print(\u0027# Minimum value: %s\u0027 % min_value)"},{"line_number":299,"context_line":"    elif max_value is not None:"},{"line_number":300,"context_line":"        print(\u0027# Maximum value: %s\u0027 % max_value)"},{"line_number":301,"context_line":"    elif choices is not None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_a4cd2887","line":298,"range":{"start_line":298,"start_character":31,"end_line":298,"end_character":34},"in_reply_to":"9aed3d3a_f5961c93","updated":"2016-02-29 06:39:21.000000000","message":"hoops, thanks for this.","commit_id":"754c4bc28c00e35fdd55ad6c7d964489870d2bcc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a934c068f48d7ed9cf9530fe2dd4788961dfafdf","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        print(\u0027# Maximum value: %d\u0027 % max_value)"},{"line_number":301,"context_line":"    elif choices is not None:"},{"line_number":302,"context_line":"        if choices \u003d\u003d []:"},{"line_number":303,"context_line":"            print(\u0027# No possible values.\u0027)"},{"line_number":304,"context_line":"        else:"},{"line_number":305,"context_line":"            choices_text \u003d \u0027, \u0027.join([_get_choice_text(choice)"},{"line_number":306,"context_line":"                                     for choice in choices])"}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_d57a82f0","line":303,"updated":"2016-03-03 10:25:57.000000000","message":"Is there a case for this? \n\nI mean, can the configuration option be used if we can not set any value to it?","commit_id":"e38f345709032a50ebd9d9435937ee3e3ac69406"}],"releasenotes/notes/add_possible_values-9d22033224816c9b.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"443e28bd60260c1f5e9eaf7bf3423190da013064","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add possible values for config options for ironic.conf.sample."},{"line_number":4,"context_line":"    The config values should in the range of possible values."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa69d971_283c39c7","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":31},"updated":"2016-01-10 15:07:42.000000000","message":"nit: s/should in/should be in","commit_id":"ad43b34ef6328e320dd7799bcfcb7c6c911e0ccc"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"c46cfdd28fb584f52299b0f18d048c5d4fa2fdbe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add possible values for config options for ironic.conf.sample."},{"line_number":4,"context_line":"    The config values should in the range of possible values."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a5de9d1_ecfc4d40","line":3,"range":{"start_line":3,"start_character":43,"end_line":3,"end_character":46},"updated":"2016-01-28 07:48:29.000000000","message":"nit: change to \u0027in\u0027 is more suitable and readable.","commit_id":"e055101075f636fbae865dea30a5584c91de3580"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2217924e1b88621917b10000b616b2b1d9310aa4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add possible values for config options for ironic.conf.sample."},{"line_number":4,"context_line":"    The config values should in the range of possible values."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a5de9d1_3e829dc9","line":4,"updated":"2016-02-02 19:38:03.000000000","message":"s/in/be in/","commit_id":"e055101075f636fbae865dea30a5584c91de3580"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2217924e1b88621917b10000b616b2b1d9310aa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7a5de9d1_3e9e1d08","line":5,"updated":"2016-02-02 19:38:03.000000000","message":"I\u0027m not sure this needs a reno. but if we are going to add a reno, how about something like\n\nConfiguration options in ironic.conf.sample list the possible choices or range of values.\n\nFor the most part, the .sample already indicated the possible choices. I think that the only additional information that has been added based on this patch are the ranges for integral values. The more I think about it, the more I don\u0027t really think it is necessary to mention this in a reno.","commit_id":"e055101075f636fbae865dea30a5584c91de3580"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"7d206ec8657c3d250ff1d41c5f33c42c67af56b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a5ae5dd_16bbeae6","line":5,"in_reply_to":"7a5de9d1_3e9e1d08","updated":"2016-02-04 02:37:16.000000000","message":"hmmm, it sound reasonable. I am even thinking should we add this as a new feature since we change the behavior but it is not such important :( Read http://docs.openstack.org/developer/ironic/dev/faq.html#id3\nagain, I agree to remove this reno.","commit_id":"e055101075f636fbae865dea30a5584c91de3580"}]}
