)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dc9e332e603e6ca2d7d6db0189ba0fc353d5052d","unresolved":false,"context_lines":[{"line_number":1742,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":1743,"context_line":"# (string value)"},{"line_number":1744,"context_line":"# Deprecated group/name - [DEFAULT]/rabbit_host"},{"line_number":1745,"context_line":"#rabbit_host\u003dironic"},{"line_number":1746,"context_line":""},{"line_number":1747,"context_line":"# The RabbitMQ broker port where a single node is used. (port"},{"line_number":1748,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_84f2096e","line":1745,"updated":"2016-01-13 18:46:23.000000000","message":"shouldn\u0027t this be localhost?","commit_id":"61a5c30404e480f555e8171fcd8a172a91089a37"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e2f64d37add97e0f888de4ec8b8822128e43f876","unresolved":false,"context_lines":[{"line_number":2176,"context_line":""},{"line_number":2177,"context_line":"# The custom endpoint URL provided to override the keystone"},{"line_number":2178,"context_line":"# endpoint URL. (string value)"},{"line_number":2179,"context_line":"#swift_endpoint_url\u003d\u003cNone\u003e"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"# The swift account which must be provided when"},{"line_number":2182,"context_line":"# swift_endpoint_url is given. (string value)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"dab17558_bdccf335","line":2179,"range":{"start_line":2179,"start_character":19,"end_line":2179,"end_character":20},"updated":"2016-05-16 13:57:24.000000000","message":"There should be spaces around these.","commit_id":"4fd25f2d0711bf9d8927bc531f3263e9412d0eba"}],"ironic/common/swift.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7003dedf6bf5b7b349b3c95b872560651c00c53","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               help\u003d_(\u0027Swift service user password.\u0027)),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027swift_user_tenant_name\u0027,"},{"line_number":48,"context_line":"               help\u003d_(\u0027Swift service tenant name.\u0027)),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"CONF \u003d cfg.CONF"},{"line_number":52,"context_line":"CONF.register_opts(swift_opts, group\u003d\u0027swift\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_cd558050","line":49,"updated":"2016-01-04 21:04:40.000000000","message":"\u0027url\u0027 should be \u0027URL\u0027.\n\nDo we need to do something special for passwords, for security reasons?","commit_id":"e21e2561d1963c1112119d1ce4271f5234408a59"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c5584b337769e06b8e3e906f87063bc45cf2f72d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               help\u003d_(\u0027Swift service user password.\u0027)),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027swift_user_tenant_name\u0027,"},{"line_number":48,"context_line":"               help\u003d_(\u0027Swift service tenant name.\u0027)),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"CONF \u003d cfg.CONF"},{"line_number":52,"context_line":"CONF.register_opts(swift_opts, group\u003d\u0027swift\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_61ad1f9a","line":49,"in_reply_to":"fa69d971_cd558050","updated":"2016-01-06 17:45:07.000000000","message":"Sounds a good question. Let me check the need for this parameter from the team who actually needs this fix and get back to you.","commit_id":"e21e2561d1963c1112119d1ce4271f5234408a59"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"0697eff83d89130f343610047c3afa2966b5322b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d_(\u0027The swift account which must be provided \u0027"},{"line_number":38,"context_line":"                      \u0027when swift_endpoint_url is given.\u0027)),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027swift_api_version\u0027,"},{"line_number":40,"context_line":"               help\u003d_(\u0027The swift API version must be provided \u0027"},{"line_number":41,"context_line":"                      \u0027when swift_endpoint_url is given.\u0027)),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027swift_user_name\u0027,"},{"line_number":43,"context_line":"               help\u003d_(\u0027Swift service user name.\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_98f2b899","line":40,"range":{"start_line":40,"start_character":27,"end_line":40,"end_character":44},"updated":"2016-01-12 16:07:14.000000000","message":"minor nit: would like to see an example here. so we can easily tell what is expected here: Ie. are we looking for 1, 1.0, v1, v1.0?","commit_id":"61a5c30404e480f555e8171fcd8a172a91089a37"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3c2c13af93fd381d84bd45d4529c519e2d0f16cf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"               default\u003d2,"},{"line_number":31,"context_line":"               help\u003d_(\u0027Maximum number of times to retry a Swift request, \u0027"},{"line_number":32,"context_line":"                      \u0027before failing.\u0027)),"},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027swift_endpoint_url\u0027,"},{"line_number":34,"context_line":"               help\u003d_(\u0027The custom endpoint URL provided to override \u0027"},{"line_number":35,"context_line":"                      \u0027the keystone endpoint URL.\u0027)),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027swift_account\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_3826c2ba","line":33,"updated":"2016-05-18 16:39:10.000000000","message":"I see the same option in https://github.com/openstack/ironic/blob/master/ironic/common/glance_service/v2/image_service.py, account account and api version are also there, so it feels confusing to me to have this separation between glance and swift groups. Can we deprecate swift endpoint/api version/account in glance section and use the values from this section? Or do you think it is possible to have separate swift deployments, like one is to be used for glance backend, another for standalone usage? Or at least the descriptions should be updated, stating which config options used where (ie the ones in glance section are to generate swift temp urls, these are for instantiating a client).","commit_id":"4fd25f2d0711bf9d8927bc531f3263e9412d0eba"}],"releasenotes/notes/swift-end-point-url-311ec38f054c9477.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7003dedf6bf5b7b349b3c95b872560651c00c53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds support for providing custom Swift endpoint URLs."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa69d971_4d7af0f2","line":3,"updated":"2016-01-04 21:04:40.000000000","message":"If you look at existing renos, I think we mention the configs.","commit_id":"e21e2561d1963c1112119d1ce4271f5234408a59"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"c5584b337769e06b8e3e906f87063bc45cf2f72d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Adds support for providing custom Swift endpoint URLs."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa69d971_0180e3f3","line":3,"in_reply_to":"fa69d971_4d7af0f2","updated":"2016-01-06 17:45:07.000000000","message":"Ok. Will add it.","commit_id":"e21e2561d1963c1112119d1ce4271f5234408a59"}]}
