)]}'
{"ironic/drivers/base.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"84e62e73b2d7923364d6a514682760c3b52bf87f","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"                        _(\u0027For argument \"%(arg)s\", \"description\" must be a \u0027"},{"line_number":1017,"context_line":"                          \u0027string value instead of \"%(value)s\".\u0027) %"},{"line_number":1018,"context_line":"                        {\u0027arg\u0027: arg, \u0027value\u0027: value})"},{"line_number":1019,"context_line":"                has_description \u003d True"},{"line_number":1020,"context_line":"            elif key \u003d\u003d \u0027required\u0027:"},{"line_number":1021,"context_line":"                if not isinstance(value, bool):"},{"line_number":1022,"context_line":"                    raise exception.InvalidParameterValue("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c87841fb","line":1019,"updated":"2015-12-01 17:37:57.000000000","message":"This will pass with empty (\u0027\u0027) description, should it be checked too?","commit_id":"ef7c878d96a9bddb88bc83a6b43dd67208a3f45f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c74f8e338754e8da29cea43a8e08609afdd2a4d7","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"                        _(\u0027For argument \"%(arg)s\", \"description\" must be a \u0027"},{"line_number":1017,"context_line":"                          \u0027string value instead of \"%(value)s\".\u0027) %"},{"line_number":1018,"context_line":"                        {\u0027arg\u0027: arg, \u0027value\u0027: value})"},{"line_number":1019,"context_line":"                has_description \u003d True"},{"line_number":1020,"context_line":"            elif key \u003d\u003d \u0027required\u0027:"},{"line_number":1021,"context_line":"                if not isinstance(value, bool):"},{"line_number":1022,"context_line":"                    raise exception.InvalidParameterValue("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_e2cc41bd","line":1019,"in_reply_to":"9a8ffd7b_c87841fb","updated":"2015-12-01 18:20:53.000000000","message":"I don\u0027t think it is worth the effort to check it unless you really want to. This info is from the developer, if they put \u0027\u0027 and the reviewers are OK with it, then who are we to disagree? These descriptions will only be used when presenting the clean step information to the user (TODO still).","commit_id":"ef7c878d96a9bddb88bc83a6b43dd67208a3f45f"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"1a9b341ee90add6082149cfdebb4e8525be51c18","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                        {\u0027arg\u0027: arg, \u0027value\u0027: value})"},{"line_number":1026,"context_line":"            else:"},{"line_number":1027,"context_line":"                raise exception.InvalidParameterValue("},{"line_number":1028,"context_line":"                    _(\u0027Argument \"%(arg)s\" has invalid key \"%(key)s\". \u0027"},{"line_number":1029,"context_line":"                      \u0027It must be \"description\" or \"required\".\u0027)"},{"line_number":1030,"context_line":"                    % {\u0027key\u0027: key, \u0027arg\u0027: arg})"},{"line_number":1031,"context_line":"        if not has_description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_1b0d1a3e","line":1028,"updated":"2015-12-02 03:31:11.000000000","message":"nit: /has invalid key/has an invalid key/","commit_id":"ef7c878d96a9bddb88bc83a6b43dd67208a3f45f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2921fe7162ad7a68dd1a698f5d4fdec76d73634d","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                        {\u0027arg\u0027: arg, \u0027value\u0027: value})"},{"line_number":1026,"context_line":"            else:"},{"line_number":1027,"context_line":"                raise exception.InvalidParameterValue("},{"line_number":1028,"context_line":"                    _(\u0027Argument \"%(arg)s\" has invalid key \"%(key)s\". \u0027"},{"line_number":1029,"context_line":"                      \u0027It must be \"description\" or \"required\".\u0027)"},{"line_number":1030,"context_line":"                    % {\u0027key\u0027: key, \u0027arg\u0027: arg})"},{"line_number":1031,"context_line":"        if not has_description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b4387ca1","line":1028,"in_reply_to":"9a8ffd7b_1b0d1a3e","updated":"2015-12-02 15:45:49.000000000","message":"OH. you caught me. I\u0027m not sure \u0027an\u0027 is correct. \u0027the\u0027 might be right. But I\u0027m not sure.\n\n - Argument \"arg1\" has invalid key \"bad\".\n - Argument \"arg1\" has an invalid key \"bad\".\n - Argument \"arg1\" has the invalid key \"bad\".","commit_id":"ef7c878d96a9bddb88bc83a6b43dd67208a3f45f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6b73b545cdfde3279c1a21a446b681509c9d2024","unresolved":false,"context_lines":[{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"    if not isinstance(argsinfo, dict):"},{"line_number":1003,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1004,"context_line":"            _(\u0027\"argsinfo\" must be a dictionary instead of \"%s\"\u0027) %"},{"line_number":1005,"context_line":"            argsinfo)"},{"line_number":1006,"context_line":"    for (arg, info) in argsinfo.items():"},{"line_number":1007,"context_line":"        if not isinstance(info, dict):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_889ad66c","line":1004,"range":{"start_line":1004,"start_character":12,"end_line":1004,"end_character":13},"updated":"2015-12-21 13:29:44.000000000","message":"forgot to import \u0027_\u0027 before used here, not sure why gate check succeed.","commit_id":"162240ab0630f7aa3d7b28050e96904406f3fa17"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"23435b71dea1c4589b5fca86ae334743a2a919d7","unresolved":false,"context_lines":[{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"    if not isinstance(argsinfo, dict):"},{"line_number":1003,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":1004,"context_line":"            _(\u0027\"argsinfo\" must be a dictionary instead of \"%s\"\u0027) %"},{"line_number":1005,"context_line":"            argsinfo)"},{"line_number":1006,"context_line":"    for (arg, info) in argsinfo.items():"},{"line_number":1007,"context_line":"        if not isinstance(info, dict):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_e037dffc","line":1004,"range":{"start_line":1004,"start_character":12,"end_line":1004,"end_character":13},"in_reply_to":"3a7e1126_889ad66c","updated":"2015-12-21 14:19:23.000000000","message":"a follow up patch to fix this: https://review.openstack.org/#/c/260003/","commit_id":"162240ab0630f7aa3d7b28050e96904406f3fa17"}],"ironic/tests/unit/drivers/test_base.py":[{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"9d727aa5974cbbddc19c8d81e7b485b3bb1870af","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        del method_mock._clean_step_argsinfo"},{"line_number":129,"context_line":"        self.method \u003d method_mock"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test__validate_argsinfo(self):"},{"line_number":132,"context_line":"        # None, empty dict"},{"line_number":133,"context_line":"        driver_base._validate_argsinfo(None)"},{"line_number":134,"context_line":"        driver_base._validate_argsinfo({})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a8002fac","line":131,"updated":"2015-12-02 12:24:41.000000000","message":"nit: Why not a test case for each scenario?","commit_id":"ef7c878d96a9bddb88bc83a6b43dd67208a3f45f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2921fe7162ad7a68dd1a698f5d4fdec76d73634d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        del method_mock._clean_step_argsinfo"},{"line_number":129,"context_line":"        self.method \u003d method_mock"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test__validate_argsinfo(self):"},{"line_number":132,"context_line":"        # None, empty dict"},{"line_number":133,"context_line":"        driver_base._validate_argsinfo(None)"},{"line_number":134,"context_line":"        driver_base._validate_argsinfo({})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_7480d4bf","line":131,"in_reply_to":"9a8ffd7b_a8002fac","updated":"2015-12-02 15:45:49.000000000","message":"Because the individual tests are really simple and small. I also think putting them all in one group with comments is more expressive/easier to understand than separating them into individual tests. But that might just be me.","commit_id":"ef7c878d96a9bddb88bc83a6b43dd67208a3f45f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"74fc29e18d4d51658335f7c2d0edb7f6f2bc808f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                                 \u0027required\u0027: True},"},{"line_number":142,"context_line":"                                        \u0027arg2\u0027: {\u0027description\u0027: \u0027desc2\u0027}})"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test__validate_argsinfo_not_dict(self):"},{"line_number":145,"context_line":"        self.assertRaisesRegexp(exception.InvalidParameterValue,"},{"line_number":146,"context_line":"                                \u0027argsinfo.+dictionary\u0027,"},{"line_number":147,"context_line":"                                driver_base._validate_argsinfo, \u0027not-a-dict\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_4f105b00","line":144,"updated":"2015-12-03 14:09:23.000000000","message":"nit: I would prefer a separate test case for the _validate function","commit_id":"162240ab0630f7aa3d7b28050e96904406f3fa17"}]}
