)]}'
{"ironic/drivers/modules/irmc/common.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"5c640c0b873236c24896918748faacf819e17a03","unresolved":false,"context_lines":[{"line_number":28,"context_line":"opts \u003d ["},{"line_number":29,"context_line":"    cfg.PortOpt(\u0027port\u0027,"},{"line_number":30,"context_line":"                default\u003d443,"},{"line_number":31,"context_line":"                choices\u003d[443, 80],"},{"line_number":32,"context_line":"                help\u003d_(\u0027Port to be used for iRMC operations, either 80 or \u0027"},{"line_number":33,"context_line":"                       \u0027443\u0027)),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027auth_method\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_8d239355","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":34},"updated":"2015-12-22 07:56:35.000000000","message":"The 443 and 80 ports are just default configurations, they can be changed from iRMC side[1] I think, so we can not assume they are always in default values, any thoughts?\n\n[1] http://manuals.ts.fujitsu.com/file/11470/irmc-s4-ug-en.pdf 7.13.2 section","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"dba72de31771cbb2b2166b3ffe3d3790b6de0500","unresolved":false,"context_lines":[{"line_number":28,"context_line":"opts \u003d ["},{"line_number":29,"context_line":"    cfg.PortOpt(\u0027port\u0027,"},{"line_number":30,"context_line":"                default\u003d443,"},{"line_number":31,"context_line":"                choices\u003d[443, 80],"},{"line_number":32,"context_line":"                help\u003d_(\u0027Port to be used for iRMC operations, either 80 or \u0027"},{"line_number":33,"context_line":"                       \u0027443\u0027)),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027auth_method\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_774580b1","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":34},"in_reply_to":"1a7b0d38_77ba600c","updated":"2015-12-24 02:29:05.000000000","message":"Ok, just think the port configuration should not be hard-coded with common sense.","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"6879039cbad7c4c3d0e119a8a24ba1c9721efa0c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"opts \u003d ["},{"line_number":29,"context_line":"    cfg.PortOpt(\u0027port\u0027,"},{"line_number":30,"context_line":"                default\u003d443,"},{"line_number":31,"context_line":"                choices\u003d[443, 80],"},{"line_number":32,"context_line":"                help\u003d_(\u0027Port to be used for iRMC operations, either 80 or \u0027"},{"line_number":33,"context_line":"                       \u0027443\u0027)),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027auth_method\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_f7473075","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":34},"in_reply_to":"1a7b0d38_77ba600c","updated":"2015-12-24 02:33:10.000000000","message":"Ok, just think the port configuration should not be hard-coded with common sense.","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"f40b94e4a0720f32bfdf4b4aadccab6a69450fbe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"opts \u003d ["},{"line_number":29,"context_line":"    cfg.PortOpt(\u0027port\u0027,"},{"line_number":30,"context_line":"                default\u003d443,"},{"line_number":31,"context_line":"                choices\u003d[443, 80],"},{"line_number":32,"context_line":"                help\u003d_(\u0027Port to be used for iRMC operations, either 80 or \u0027"},{"line_number":33,"context_line":"                       \u0027443\u0027)),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027auth_method\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_f059cafd","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":34},"in_reply_to":"3a7e1126_8d239355","updated":"2015-12-22 08:15:30.000000000","message":"hmmmm, then we should change the help_, it will mislead user at least me :(","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"804e705dea13a52e7899b2763504eafe01a79e74","unresolved":false,"context_lines":[{"line_number":28,"context_line":"opts \u003d ["},{"line_number":29,"context_line":"    cfg.PortOpt(\u0027port\u0027,"},{"line_number":30,"context_line":"                default\u003d443,"},{"line_number":31,"context_line":"                choices\u003d[443, 80],"},{"line_number":32,"context_line":"                help\u003d_(\u0027Port to be used for iRMC operations, either 80 or \u0027"},{"line_number":33,"context_line":"                       \u0027443\u0027)),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027auth_method\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_77ba600c","line":31,"range":{"start_line":31,"start_character":32,"end_line":31,"end_character":34},"in_reply_to":"3a7e1126_f059cafd","updated":"2015-12-24 02:01:56.000000000","message":"Haomeng, Tan,\n\nThanks for checking the iRMC manual, Haomeng!\nAs the iRMC function, user can change the port other than 443 for https and 80 for http respectively.\n\nHowever Fujitsu decided the specification which provides customer with a choice either https(443) or http(80) in a large scale setting such as Cloud.\n\nSo the line 31 is Okay for Fujitsu.\n\nBest regards,\nNaohiro","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"}],"ironic/tests/unit/drivers/modules/irmc/test_common.py":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"5c640c0b873236c24896918748faacf819e17a03","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def test_out_range_port(self):"},{"line_number":173,"context_line":"        self.assertRaises(ValueError, cfg.CONF.set_override,"},{"line_number":174,"context_line":"                          \u0027port\u0027, 60, \u0027irmc\u0027, enforce_type\u003dTrue)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def test_out_range_auth_method(self):"},{"line_number":177,"context_line":"        self.assertRaises(ValueError, cfg.CONF.set_override,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_6dc2e754","line":174,"range":{"start_line":174,"start_character":63,"end_line":174,"end_character":64},"updated":"2015-12-22 07:56:35.000000000","message":"Should not be required, if we think iRMC default ports(80/443) can be changed.","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"}],"releasenotes/notes/add-choice-to-some-options-9fb327c48e6bfda1.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c3e19fb60d7348dd95a14b66b3fc68ee49ae4304","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add ``choices`` parameter to config options. Invalid values will"},{"line_number":4,"context_line":"    not be accepted when reading the config file for these options."},{"line_number":5,"context_line":"    * [DEFAULT]/auth_strategy         [keystone, noauth]"},{"line_number":6,"context_line":"    * [glance]/auth_strategy          [keystone, noauth]"},{"line_number":7,"context_line":"    * [glance]/glance_protocol        [http, https]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_1c2a0e7f","line":4,"updated":"2016-01-13 10:43:50.000000000","message":"this does not seem to be true: invalid values will be rejected when first accessing them, which can happen in the middle of deployment.","commit_id":"aa7fdb4e62fe2650d9a211cb8c19ba1bad75283d"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"3f0063674ac8c0cfeb345c0a4b3c0ebd335f062a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Add ``choices`` parameter to config options. Invalid values will"},{"line_number":4,"context_line":"    not be accepted when reading the config file for these options."},{"line_number":5,"context_line":"    * [DEFAULT]/auth_strategy         [keystone, noauth]"},{"line_number":6,"context_line":"    * [glance]/auth_strategy          [keystone, noauth]"},{"line_number":7,"context_line":"    * [glance]/glance_protocol        [http, https]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_ff180c20","line":4,"in_reply_to":"da6ed579_1c2a0e7f","updated":"2016-01-14 10:15:09.000000000","message":"Thanks to explain, I will correct this.","commit_id":"aa7fdb4e62fe2650d9a211cb8c19ba1bad75283d"}],"requirements.txt":[{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"5c640c0b873236c24896918748faacf819e17a03","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pysendfile\u003e\u003d2.0.0"},{"line_number":21,"context_line":"websockify\u003e\u003d0.6.1"},{"line_number":22,"context_line":"oslo.concurrency\u003e\u003d2.3.0 # Apache-2.0"},{"line_number":23,"context_line":"oslo.config\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.context\u003e\u003d0.2.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.db\u003e\u003d4.1.0 # Apache-2.0"},{"line_number":26,"context_line":"oslo.rootwrap\u003e\u003d2.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"3a7e1126_4d9e0b64","line":23,"range":{"start_line":23,"start_character":30,"end_line":23,"end_character":31},"updated":"2015-12-22 07:56:35.000000000","message":"this is not covered by commit message, so either we add this change note into commit message or change it via another patch.","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"f40b94e4a0720f32bfdf4b4aadccab6a69450fbe","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pysendfile\u003e\u003d2.0.0"},{"line_number":21,"context_line":"websockify\u003e\u003d0.6.1"},{"line_number":22,"context_line":"oslo.concurrency\u003e\u003d2.3.0 # Apache-2.0"},{"line_number":23,"context_line":"oslo.config\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.context\u003e\u003d0.2.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.db\u003e\u003d4.1.0 # Apache-2.0"},{"line_number":26,"context_line":"oslo.rootwrap\u003e\u003d2.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"3a7e1126_b0f7c2d1","line":23,"range":{"start_line":23,"start_character":30,"end_line":23,"end_character":31},"in_reply_to":"3a7e1126_4d9e0b64","updated":"2015-12-22 08:15:30.000000000","message":"Thanks, I will update in next patch set","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"804e705dea13a52e7899b2763504eafe01a79e74","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pysendfile\u003e\u003d2.0.0"},{"line_number":21,"context_line":"websockify\u003e\u003d0.6.1"},{"line_number":22,"context_line":"oslo.concurrency\u003e\u003d2.3.0 # Apache-2.0"},{"line_number":23,"context_line":"oslo.config\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.context\u003e\u003d0.2.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.db\u003e\u003d4.1.0 # Apache-2.0"},{"line_number":26,"context_line":"oslo.rootwrap\u003e\u003d2.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"1a7b0d38_3778588f","line":23,"range":{"start_line":23,"start_character":30,"end_line":23,"end_character":31},"in_reply_to":"3a7e1126_b0f7c2d1","updated":"2015-12-24 02:01:56.000000000","message":"Haomeng, Tan,\n\nShould we update the global-requirement.txt for all projects?\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt\n\nBecause Ironic is installed and executed with other projects, so we need a consensus that the minimum version requirement is 3.2.0 among OpenStack Projects, I believe.\n\nBest regards,\nNaohiro","commit_id":"9bd67f9c661fe5c1aa06bf1f9497d822db21bc29"}]}
