)]}'
{"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"56cf969c5295fddbe3d972f8b6f51d1c9eb0c6a9","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_node_list(self, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":242,"context_line":"                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":243,"context_line":"        query \u003d model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":244,"context_line":"        query \u003d self._add_nodes_filters(query, filters)"},{"line_number":245,"context_line":"        return _paginate_query(models.Node, limit, marker,"},{"line_number":246,"context_line":"                               sort_key, sort_dir, query)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_a6362be5","line":243,"updated":"2016-02-25 09:41:10.000000000","message":"you should add an extra_column and depends on the parameter to load tags. tags is not necessary for all cases","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"112bf7457ba45bbe5af96598f041e0a4d8931d04","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_node_list(self, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":242,"context_line":"                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":243,"context_line":"        query \u003d model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":244,"context_line":"        query \u003d self._add_nodes_filters(query, filters)"},{"line_number":245,"context_line":"        return _paginate_query(models.Node, limit, marker,"},{"line_number":246,"context_line":"                               sort_key, sort_dir, query)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aed3d3a_e46cb99e","line":243,"in_reply_to":"9aed3d3a_53e28d04","updated":"2016-02-26 03:25:08.000000000","message":"in those cases get_nodeinfo_list() would be called which can specify the columns, see L227, and all these with \u0027tags\u0027 loading methods are only used by Node object.","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6353e4bbbfb24533e43336b38afbd41ab6b6282c","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_node_list(self, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":242,"context_line":"                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":243,"context_line":"        query \u003d model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":244,"context_line":"        query \u003d self._add_nodes_filters(query, filters)"},{"line_number":245,"context_line":"        return _paginate_query(models.Node, limit, marker,"},{"line_number":246,"context_line":"                               sort_key, sort_dir, query)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_e86c750a","line":243,"in_reply_to":"bae84128_a6362be5","updated":"2016-02-25 13:23:34.000000000","message":"hi Tan, I would like to always load tags when getting nodes, as \u0027tags\u0027 is an attribute of node object, you can reference this in the following patches, why do you say \u0027tags is not necessary for all cases\u0027?","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"0eb9980a0f03b3d66e00659d08db71f9a1140bc6","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_node_list(self, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":242,"context_line":"                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":243,"context_line":"        query \u003d model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":244,"context_line":"        query \u003d self._add_nodes_filters(query, filters)"},{"line_number":245,"context_line":"        return _paginate_query(models.Node, limit, marker,"},{"line_number":246,"context_line":"                               sort_key, sort_dir, query)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aed3d3a_53e28d04","line":243,"in_reply_to":"bae84128_e86c750a","updated":"2016-02-26 02:01:04.000000000","message":"I am thinking in some cases of periodic tasks like _sync_power_states, the tags is useless. There are also some other similar cases so I think node.tags should be lazy-loading. WDYT？","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"56cf969c5295fddbe3d972f8b6f51d1c9eb0c6a9","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def reserve_node(self, tag, node_id):"},{"line_number":249,"context_line":"        with _session_for_write():"},{"line_number":250,"context_line":"            query \u003d model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":251,"context_line":"            query \u003d add_identity_filter(query, node_id)"},{"line_number":252,"context_line":"            # be optimistic and assume we usually create a reservation"},{"line_number":253,"context_line":"            count \u003d query.filter_by(reservation\u003dNone).update("}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_e6b5d331","line":250,"updated":"2016-02-25 09:41:10.000000000","message":"ditto","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"56cf969c5295fddbe3d972f8b6f51d1c9eb0c6a9","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            return node"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def get_node_by_id(self, node_id):"},{"line_number":320,"context_line":"        query \u003d (model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":321,"context_line":"                 .filter_by(id\u003dnode_id))"},{"line_number":322,"context_line":"        try:"},{"line_number":323,"context_line":"            return query.one()"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_c667efe8","line":320,"updated":"2016-02-25 09:41:10.000000000","message":"ditto","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"56cf969c5295fddbe3d972f8b6f51d1c9eb0c6a9","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            raise exception.NodeNotFound(node\u003dnode_id)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def get_node_by_uuid(self, node_uuid):"},{"line_number":328,"context_line":"        query \u003d (model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":329,"context_line":"                 .filter_by(uuid\u003dnode_uuid))"},{"line_number":330,"context_line":"        try:"},{"line_number":331,"context_line":"            return query.one()"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_e65e7311","line":328,"updated":"2016-02-25 09:41:10.000000000","message":"ditto","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"56cf969c5295fddbe3d972f8b6f51d1c9eb0c6a9","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            raise exception.NodeNotFound(node\u003dnode_uuid)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    def get_node_by_name(self, node_name):"},{"line_number":336,"context_line":"        query \u003d (model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":337,"context_line":"                 .filter_by(name\u003dnode_name))"},{"line_number":338,"context_line":"        try:"},{"line_number":339,"context_line":"            return query.one()"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_86a4c708","line":336,"updated":"2016-02-25 09:41:10.000000000","message":"ditto","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"56cf969c5295fddbe3d972f8b6f51d1c9eb0c6a9","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        if not uuidutils.is_uuid_like(instance):"},{"line_number":345,"context_line":"            raise exception.InvalidUUID(uuid\u003dinstance)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        query \u003d (model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":348,"context_line":"                 .filter_by(instance_uuid\u003dinstance))"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_a6abcbd5","line":347,"updated":"2016-02-25 09:41:10.000000000","message":"ditto","commit_id":"777fdd9a3ac13372216f8064be577c60d369d2a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0b8779d0bfb47ed0eb958a5080484116ec540b6d","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_node_list(self, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":242,"context_line":"                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":243,"context_line":"        query \u003d model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":244,"context_line":"        query \u003d self._add_nodes_filters(query, filters)"},{"line_number":245,"context_line":"        return _paginate_query(models.Node, limit, marker,"},{"line_number":246,"context_line":"                               sort_key, sort_dir, query)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_e9ee40eb","line":243,"updated":"2016-02-26 10:24:38.000000000","message":"joinedload_all() is deprecated: http://docs.sqlalchemy.org/en/latest/orm/loading_relationships.html?highlight\u003djoinedload_all#sqlalchemy.orm.joinedload_all","commit_id":"77285180edf29df4565279cc2d8484e17c746779"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"85ae2279e69abeb58a22a7787f301c9466194b6c","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_node_list(self, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":242,"context_line":"                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":243,"context_line":"        query \u003d model_query(models.Node).options(joinedload_all(\u0027tags\u0027))"},{"line_number":244,"context_line":"        query \u003d self._add_nodes_filters(query, filters)"},{"line_number":245,"context_line":"        return _paginate_query(models.Node, limit, marker,"},{"line_number":246,"context_line":"                               sort_key, sort_dir, query)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_e098001e","line":243,"in_reply_to":"9aed3d3a_e9ee40eb","updated":"2016-02-26 15:19:01.000000000","message":"thanks for the comment Yuriy, will update soon.","commit_id":"77285180edf29df4565279cc2d8484e17c746779"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ad3e46faeb4427bda461a17944cf4778611f1a78","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_node_list(self, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":242,"context_line":"                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":243,"context_line":"        query \u003d model_query(models.Node).options(joinedload(\u0027tags\u0027))"},{"line_number":244,"context_line":"        query \u003d self._add_nodes_filters(query, filters)"},{"line_number":245,"context_line":"        return _paginate_query(models.Node, limit, marker,"},{"line_number":246,"context_line":"                               sort_key, sort_dir, query)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_c2a2c14a","line":243,"updated":"2016-03-23 13:35:54.000000000","message":"Could we factor this out to a new method? Something like:\n\ndef _get_node_query():\n    return model_query(models.Node).options(joinedload(\u0027tags\u0027))","commit_id":"9dd8cf1f35a4dfe6aa73f2dea08bae7fe9ead3ea"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"1b06e39b8e7713d8d18cd05d976d4621443b2c43","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def get_node_list(self, filters\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":242,"context_line":"                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":243,"context_line":"        query \u003d model_query(models.Node).options(joinedload(\u0027tags\u0027))"},{"line_number":244,"context_line":"        query \u003d self._add_nodes_filters(query, filters)"},{"line_number":245,"context_line":"        return _paginate_query(models.Node, limit, marker,"},{"line_number":246,"context_line":"                               sort_key, sort_dir, query)"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_1ae6d9af","line":243,"in_reply_to":"fa0719c6_c2a2c14a","updated":"2016-03-23 16:08:34.000000000","message":"yes Jim, thanks for the suggestion, will update soon.","commit_id":"9dd8cf1f35a4dfe6aa73f2dea08bae7fe9ead3ea"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"6d703e4bf78115d5a270ebd19057eb147a5b8772","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        # TODO(zhenguo): Support creating node with tags"},{"line_number":294,"context_line":"        if \u0027tags\u0027 in values:"},{"line_number":295,"context_line":"            LOG.warning("},{"line_number":296,"context_line":"                _LW(\u0027Ignore the specified tags %(tags)s when creating node: \u0027"},{"line_number":297,"context_line":"                    \u0027%(node)s.\u0027), {\u0027tags\u0027: values[\u0027tags\u0027],"},{"line_number":298,"context_line":"                                   \u0027node\u0027: values[\u0027uuid\u0027]})"},{"line_number":299,"context_line":"            del values[\u0027tags\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"1af94dfe_59eef9b4","line":296,"updated":"2016-03-16 16:22:47.000000000","message":"This patch looks like a good opportunity to add support for creating nodes with tags.","commit_id":"9dd8cf1f35a4dfe6aa73f2dea08bae7fe9ead3ea"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"1b06e39b8e7713d8d18cd05d976d4621443b2c43","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        # TODO(zhenguo): Support creating node with tags"},{"line_number":294,"context_line":"        if \u0027tags\u0027 in values:"},{"line_number":295,"context_line":"            LOG.warning("},{"line_number":296,"context_line":"                _LW(\u0027Ignore the specified tags %(tags)s when creating node: \u0027"},{"line_number":297,"context_line":"                    \u0027%(node)s.\u0027), {\u0027tags\u0027: values[\u0027tags\u0027],"},{"line_number":298,"context_line":"                                   \u0027node\u0027: values[\u0027uuid\u0027]})"},{"line_number":299,"context_line":"            del values[\u0027tags\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_b5189ed4","line":296,"in_reply_to":"1af94dfe_59eef9b4","updated":"2016-03-23 16:08:34.000000000","message":"Thanks for the review Miles Gould, I plan to do this later if users really need this support, as it is not in the scope of this bp.","commit_id":"9dd8cf1f35a4dfe6aa73f2dea08bae7fe9ead3ea"}],"ironic/tests/unit/db/test_nodes.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ccabb5dfb72c692db6d2d1afb79b951462475656","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        res \u003d self.dbapi.get_node_by_id(node.id)"},{"line_number":65,"context_line":"        self.assertEqual(node.id, res.id)"},{"line_number":66,"context_line":"        self.assertEqual(node.uuid, res.uuid)"},{"line_number":67,"context_line":"        self.assertEqual([], res.tags)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_get_node_by_uuid(self):"},{"line_number":70,"context_line":"        node \u003d utils.create_test_node()"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a122d0e_efb3d308","line":67,"updated":"2016-04-22 10:37:39.000000000","message":"Will be good also add a test with non-empty tag list.","commit_id":"548750681b921bf4a35cacb6e81d6d2c385b4a00"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"5346cd88ca20cc61df9a75036e4c3a414421a3a1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        res \u003d self.dbapi.get_node_by_id(node.id)"},{"line_number":65,"context_line":"        self.assertEqual(node.id, res.id)"},{"line_number":66,"context_line":"        self.assertEqual(node.uuid, res.uuid)"},{"line_number":67,"context_line":"        self.assertEqual([], res.tags)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_get_node_by_uuid(self):"},{"line_number":70,"context_line":"        node \u003d utils.create_test_node()"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a122d0e_b7af657c","line":67,"in_reply_to":"1a122d0e_efb3d308","updated":"2016-04-22 14:49:18.000000000","message":"Done","commit_id":"548750681b921bf4a35cacb6e81d6d2c385b4a00"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"3a984c64ff5dbed57e6b6e97d69999834c848bb7","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        res_uuids \u003d [r.uuid for r in res]"},{"line_number":225,"context_line":"        six.assertCountEqual(self, uuids, res_uuids)"},{"line_number":226,"context_line":"        for r in res:"},{"line_number":227,"context_line":"            self.assertEqual([], r.tags)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_get_node_list_with_filters(self):"},{"line_number":230,"context_line":"        ch1 \u003d utils.create_test_chassis(uuid\u003duuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":20,"id":"dab17558_1bd19e23","line":227,"updated":"2016-05-17 08:28:29.000000000","message":"hmm, I understand this is to test the part in create_node, but do you think it\u0027s clearer to move this to test_create_node_with_tags()?","commit_id":"19ef56cf00a78871e0d30a160b07f280488ddd0c"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"696a3aca0e187e4db7a9332630f52a51f866011d","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        res_uuids \u003d [r.uuid for r in res]"},{"line_number":225,"context_line":"        six.assertCountEqual(self, uuids, res_uuids)"},{"line_number":226,"context_line":"        for r in res:"},{"line_number":227,"context_line":"            self.assertEqual([], r.tags)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_get_node_list_with_filters(self):"},{"line_number":230,"context_line":"        ch1 \u003d utils.create_test_chassis(uuid\u003duuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_e498776c","line":227,"in_reply_to":"bab6814e_4456b5ce","updated":"2016-05-23 02:03:19.000000000","message":"Then it\u0027s better to add a test in create_node_with_tags in follow-up patch","commit_id":"19ef56cf00a78871e0d30a160b07f280488ddd0c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"73800eb9764c71dc284e2be5137ac904de1e0b4c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        res_uuids \u003d [r.uuid for r in res]"},{"line_number":225,"context_line":"        six.assertCountEqual(self, uuids, res_uuids)"},{"line_number":226,"context_line":"        for r in res:"},{"line_number":227,"context_line":"            self.assertEqual([], r.tags)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_get_node_list_with_filters(self):"},{"line_number":230,"context_line":"        ch1 \u003d utils.create_test_chassis(uuid\u003duuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_0d55dfc4","line":227,"in_reply_to":"bab6814e_e498776c","updated":"2016-05-23 04:03:25.000000000","message":"yeah, will add that in the follow-up patch :)","commit_id":"19ef56cf00a78871e0d30a160b07f280488ddd0c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b6388561a0295db80fd0dbf2bf364d6f2b2d2561","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        res_uuids \u003d [r.uuid for r in res]"},{"line_number":225,"context_line":"        six.assertCountEqual(self, uuids, res_uuids)"},{"line_number":226,"context_line":"        for r in res:"},{"line_number":227,"context_line":"            self.assertEqual([], r.tags)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_get_node_list_with_filters(self):"},{"line_number":230,"context_line":"        ch1 \u003d utils.create_test_chassis(uuid\u003duuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":20,"id":"dab17558_367f5916","line":227,"in_reply_to":"dab17558_1bd19e23","updated":"2016-05-17 08:45:13.000000000","message":"Agreed, at create_node() (db/sqlalchemy/api.py) we set tags to []. We should add this check at the right test","commit_id":"19ef56cf00a78871e0d30a160b07f280488ddd0c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"1105a2b595f12b1caff948a8a5123d1e4f0affdb","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        res_uuids \u003d [r.uuid for r in res]"},{"line_number":225,"context_line":"        six.assertCountEqual(self, uuids, res_uuids)"},{"line_number":226,"context_line":"        for r in res:"},{"line_number":227,"context_line":"            self.assertEqual([], r.tags)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def test_get_node_list_with_filters(self):"},{"line_number":230,"context_line":"        ch1 \u003d utils.create_test_chassis(uuid\u003duuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_4456b5ce","line":227,"in_reply_to":"dab17558_367f5916","updated":"2016-05-21 04:37:57.000000000","message":"not actually, this is to test get_node_list returned nodes with tags joined.","commit_id":"19ef56cf00a78871e0d30a160b07f280488ddd0c"}]}
