)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3865afda69e04ee218d8de8a845785591bd05c4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lin Tan \u003clin.tan@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-09 16:14:45 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a config option [upgrade_level]/condcutor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will cap the conductor RPC version."},{"line_number":10,"context_line":"All RPC call should only sent messages which is compatible with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_5ac4625e","line":7,"updated":"2015-12-09 15:43:16.000000000","message":"s/condcutor/conductor/","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3865afda69e04ee218d8de8a845785591bd05c4d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add a config option [upgrade_level]/condcutor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will cap the conductor RPC version."},{"line_number":10,"context_line":"All RPC call should only sent messages which is compatible with"},{"line_number":11,"context_line":"the rpc_cap. User can set cap value as \u0027liberty\u0027 or future stable"},{"line_number":12,"context_line":"releases(Mitaka) and numbered releases(4.x)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_fab42ed5","line":10,"updated":"2015-12-09 15:43:16.000000000","message":"s/call/calls/\n\ns/s/sent/send/\n\ns/is/are/","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3865afda69e04ee218d8de8a845785591bd05c4d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will cap the conductor RPC version."},{"line_number":10,"context_line":"All RPC call should only sent messages which is compatible with"},{"line_number":11,"context_line":"the rpc_cap. User can set cap value as \u0027liberty\u0027 or future stable"},{"line_number":12,"context_line":"releases(Mitaka) and numbered releases(4.x)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8e72f786f7fc7ebc0477cb1ee8844572af536e3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_9a3baa38","line":11,"updated":"2015-12-09 15:43:16.000000000","message":"s/rpc_cap/the RPC cap from the [upgrade_level]/conductor config/","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"997605e17b8c099478c36ce3f40a7c99932c3291","unresolved":false,"context_lines":[{"line_number":12,"context_line":"cap value as Ironic version like \u0027liberty\u0027 or future stable"},{"line_number":13,"context_line":"releases(Mitaka) and numbered releases(4.x)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If no appropriate value was given, the version cap will be the"},{"line_number":16,"context_line":"RPC_API_VERSION."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8e72f786f7fc7ebc0477cb1ee8844572af536e3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a5ae5dd_6119ff87","line":15,"updated":"2016-02-04 22:45:50.000000000","message":"s/no appropriate value was given/no value is given/\n\nAs it doesn\u0027t allow invalid values to be given as it uses choices.","commit_id":"e913e29f2fa13bc36cb878034d994fe623e7ec95"},{"author":{"_account_id":17368,"name":"Ashwini Khandarkar","email":"ashu@coolsvap.net","username":"ashu"},"change_message_id":"85236bb217369d8a598d097ead873511ddc922c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lin Tan \u003clin.tan@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-16 14:24:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds an experimental config option [upgrade_levels]/conductor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will cap the conductor RPC API version."},{"line_number":10,"context_line":"All RPC calls should only send messages which are compatible with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1af94dfe_cb2b6f2f","line":7,"updated":"2016-03-16 08:06:36.000000000","message":"commit summary should be 50 chars or less http://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"240120f0d72ffa102a34bc5eb941df6eced1440f"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9b88417293013ff0deef1c61101f9e34feab8c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":"conductor_rpcapi_cap_options \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027condcutor_rpcapi_cap\u0027,"},{"line_number":36,"context_line":"               choices\u003d[\u0027liberty\u0027],"},{"line_number":37,"context_line":"               help\u003d_(\u0027This will set the version cap for RPC messages \u0027"},{"line_number":38,"context_line":"                      \u0027sent to conductor services. All RPC call should \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_05c90826","line":35,"updated":"2015-12-07 22:47:34.000000000","message":"typo s/condcutor/conductor/\n\nI\u0027m guessing you modelled this after the code in nova. Although I see in nova, that they called it \u0027conductor\u0027. Why did you call it \u0027conductor_rpcapi_cap\u0027?","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e0e564d7d5cea858b60a76dd9e1923ea4e4b48","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":"conductor_rpcapi_cap_options \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027condcutor_rpcapi_cap\u0027,"},{"line_number":36,"context_line":"               choices\u003d[\u0027liberty\u0027],"},{"line_number":37,"context_line":"               help\u003d_(\u0027This will set the version cap for RPC messages \u0027"},{"line_number":38,"context_line":"                      \u0027sent to conductor services. All RPC call should \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_b13828d4","line":35,"in_reply_to":"7a740942_05c90826","updated":"2015-12-09 06:41:11.000000000","message":"Just want to be more clear. But that\u0027s no problem to use ``conductor`` only.","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9b88417293013ff0deef1c61101f9e34feab8c4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d_(\u0027This will set the version cap for RPC messages \u0027"},{"line_number":38,"context_line":"                      \u0027sent to conductor services. All RPC call should \u0027"},{"line_number":39,"context_line":"                      \u0027only sent messages which is compatible with \u0027"},{"line_number":40,"context_line":"                      \u0027the rpc_cap.\u0027))"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF.register_opts(conductor_rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_088a7f1b","line":40,"updated":"2015-12-07 22:47:34.000000000","message":"I\u0027m not sure how useful the last sentence is. (It has grammatical mistakes in it too).\n\nHow will the operator know whether the rpc calls only send messages that are compatible blah blah?","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e0e564d7d5cea858b60a76dd9e1923ea4e4b48","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d_(\u0027This will set the version cap for RPC messages \u0027"},{"line_number":38,"context_line":"                      \u0027sent to conductor services. All RPC call should \u0027"},{"line_number":39,"context_line":"                      \u0027only sent messages which is compatible with \u0027"},{"line_number":40,"context_line":"                      \u0027the rpc_cap.\u0027))"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF.register_opts(conductor_rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_317af888","line":40,"in_reply_to":"7a740942_088a7f1b","updated":"2015-12-09 06:41:11.000000000","message":"hmmmm, it seems to much information to know for operator.","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9b88417293013ff0deef1c61101f9e34feab8c4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                      \u0027sent to conductor services. All RPC call should \u0027"},{"line_number":39,"context_line":"                      \u0027only sent messages which is compatible with \u0027"},{"line_number":40,"context_line":"                      \u0027the rpc_cap.\u0027))"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF.register_opts(conductor_rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_c8da374b","line":41,"updated":"2015-12-07 22:47:34.000000000","message":"I think we need to mention what the default behaviour is. Does that choices\u003d thing work if eg empty string is specified?\n\nAlso, i just asked Jim/Deva about whether we are only concerned with the stable releases or all releases and Deva said he\u0027d like both (http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2015-12-07.log.html#2015-12-07T22:15:44). I suppose we could just start with liberty?\n\nDoes upgrading work now? If not, wondering if it makes sense to add this config. Unless we put something saying \u0027live upgrades don\u0027t work yet\u0027. Not sure.","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e0e564d7d5cea858b60a76dd9e1923ea4e4b48","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                      \u0027sent to conductor services. All RPC call should \u0027"},{"line_number":39,"context_line":"                      \u0027only sent messages which is compatible with \u0027"},{"line_number":40,"context_line":"                      \u0027the rpc_cap.\u0027))"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF.register_opts(conductor_rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_ee5b2d84","line":41,"in_reply_to":"7a740942_c8da374b","updated":"2015-12-09 06:41:11.000000000","message":"If empty string is specified, the default value of version cap will be current RPC_API_VERSION. \n\nThanks, ruby, I see. so stable releases + numbered releases. \n\nNo, upgrade did not work yet, because we have to enable remote methods again and do some other stuffs. But we can add things in help say it doesnt work for upgrade yet.","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9b88417293013ff0deef1c61101f9e34feab8c4","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        target \u003d messaging.Target(topic\u003dself.topic,"},{"line_number":115,"context_line":"                                  version\u003d\u00271.0\u0027)"},{"line_number":116,"context_line":"        # To simplify the logical, only keep compatible with major release"},{"line_number":117,"context_line":"        # in VERSION_ALIASES, which could be used in production."},{"line_number":118,"context_line":"        version_cap \u003d self.VERSION_ALIASES.get("},{"line_number":119,"context_line":"            CONF.upgrade_levels.condcutor_rpcapi_cap,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_c896b73d","line":116,"updated":"2015-12-07 22:47:34.000000000","message":"s/logical/logic/","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9b88417293013ff0deef1c61101f9e34feab8c4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        target \u003d messaging.Target(topic\u003dself.topic,"},{"line_number":115,"context_line":"                                  version\u003d\u00271.0\u0027)"},{"line_number":116,"context_line":"        # To simplify the logical, only keep compatible with major release"},{"line_number":117,"context_line":"        # in VERSION_ALIASES, which could be used in production."},{"line_number":118,"context_line":"        version_cap \u003d self.VERSION_ALIASES.get("},{"line_number":119,"context_line":"            CONF.upgrade_levels.condcutor_rpcapi_cap,"},{"line_number":120,"context_line":"            self.RPC_API_VERSION)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_e837f34a","line":117,"updated":"2015-12-07 22:47:34.000000000","message":"by \u0027major\u0027 release, you mean \u0027stable\u0027? Or do you mean eg 4.0, 5.0?\n\nHmm, even master branch could be used in production. (Ok, maybe I\u0027m too optimistic but I thought rackspace did that.) I think our numbered releases qualify for production too.","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e0e564d7d5cea858b60a76dd9e1923ea4e4b48","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        target \u003d messaging.Target(topic\u003dself.topic,"},{"line_number":115,"context_line":"                                  version\u003d\u00271.0\u0027)"},{"line_number":116,"context_line":"        # To simplify the logical, only keep compatible with major release"},{"line_number":117,"context_line":"        # in VERSION_ALIASES, which could be used in production."},{"line_number":118,"context_line":"        version_cap \u003d self.VERSION_ALIASES.get("},{"line_number":119,"context_line":"            CONF.upgrade_levels.condcutor_rpcapi_cap,"},{"line_number":120,"context_line":"            self.RPC_API_VERSION)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_ae24450c","line":117,"in_reply_to":"7a740942_e837f34a","updated":"2015-12-09 06:41:11.000000000","message":"Yes, 4.0, 5.0 is What I mean for major release.","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3865afda69e04ee218d8de8a845785591bd05c4d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                      \u0027release(4.x). If no appropriate value was given, the \u0027"},{"line_number":41,"context_line":"                      \u0027version cap will be the latest RPC API version. The \u0027"},{"line_number":42,"context_line":"                      \u0027option was suggested to enable only when live upgrade \u0027"},{"line_number":43,"context_line":"                      \u0027is ready.\u0027))"},{"line_number":44,"context_line":"]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF.register_opts(rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_1cb577cf","line":43,"updated":"2015-12-09 15:43:16.000000000","message":"This description will need some changes but I won\u0027t comment on that until I understand what we\u0027re doing here.","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3865afda69e04ee218d8de8a845785591bd05c4d","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":105,"context_line":"        \u0027liberty\u0027: \u00271.31\u0027,"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."},{"line_number":109,"context_line":"    RPC_API_VERSION \u003d \u00271.31\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_dc560fce","line":106,"updated":"2015-12-09 15:43:16.000000000","message":"Shouldn\u0027t we add \u00274.2\u0027 (which will include \u00274.2.0\u0027, \u00274.2.1\u0027, \u00274.2.2\u0027, and any other stable/liberty versions)? And what about \u00274.3\u0027 (we just released 4.3.0)? \n\nReleases are documented here: http://docs.openstack.org/releasenotes/ironic/","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"70737fe358b5cfd22e7cfd690b0da8c07385fe8c","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":105,"context_line":"        \u0027liberty\u0027: \u00271.31\u0027,"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."},{"line_number":109,"context_line":"    RPC_API_VERSION \u003d \u00271.31\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_a65e5343","line":106,"in_reply_to":"7a740942_4f86bbba","updated":"2015-12-10 14:10:54.000000000","message":"liberty does include 4.0 - 4.2, but that doesn\u0027t mean that we can\u0027t allow users to specify 4.0, 4.1, 4.2 instead of \u0027liberty\u0027. It doesn\u0027t make sense to allow \u0027liberty\u0027 and only \u00274.3\u0027. If we\u0027re going to allow numbered releases, we should allow all of them.","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9e1e34b75e352f8d371ada0ba6885a3e31b3bbda","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":105,"context_line":"        \u0027liberty\u0027: \u00271.31\u0027,"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."},{"line_number":109,"context_line":"    RPC_API_VERSION \u003d \u00271.31\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_4f86bbba","line":106,"in_reply_to":"7a740942_dc560fce","updated":"2015-12-10 07:56:00.000000000","message":"I thought Liberty include (4.0.0 - 4.2.0), so I would prefer to cut off on liberty. But I will add \u00274.3\u0027 which is just released.","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3865afda69e04ee218d8de8a845785591bd05c4d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                  version\u003d\u00271.0\u0027)"},{"line_number":119,"context_line":"        # To simplify the logic, only keep compatible with stable release"},{"line_number":120,"context_line":"        # and numbered releases in VERSION_ALIASES, which is recommended to"},{"line_number":121,"context_line":"        # be used in production."},{"line_number":122,"context_line":"        version_cap \u003d self.VERSION_ALIASES.get("},{"line_number":123,"context_line":"            CONF.upgrade_levels.conductor,"},{"line_number":124,"context_line":"            self.RPC_API_VERSION)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_5cf0dfc9","line":121,"updated":"2015-12-09 15:43:16.000000000","message":"I\u0027m not sure you understood what I was asking, or whether you forgot to add the info to VERSION_ALIASES because there aren\u0027t any numbered releases there.\n\nMy suggestion is to put this comment above VERSION_ALIASES.\n\nI\u0027m also not sure what \u0027simplify the logic\u0027 means. What logic is simplified by doing this (instead of some other way, I\u0027m not sure what other ways you were thinking of).","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"70737fe358b5cfd22e7cfd690b0da8c07385fe8c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                  version\u003d\u00271.0\u0027)"},{"line_number":119,"context_line":"        # To simplify the logic, only keep compatible with stable release"},{"line_number":120,"context_line":"        # and numbered releases in VERSION_ALIASES, which is recommended to"},{"line_number":121,"context_line":"        # be used in production."},{"line_number":122,"context_line":"        version_cap \u003d self.VERSION_ALIASES.get("},{"line_number":123,"context_line":"            CONF.upgrade_levels.conductor,"},{"line_number":124,"context_line":"            self.RPC_API_VERSION)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_c607df1b","line":121,"in_reply_to":"7a740942_4f747bce","updated":"2015-12-10 14:10:54.000000000","message":"I\u0027m not sure what you mean here. Users can\u0027t/shouldn\u0027t know what the actual RPC versions are. It seems clear to me, allow named releases and numbered releases. named releases \u003d libery, mitaka, n*, o*, etc. numbered releases \u003d 4.0, 4.1, 4.2, 4.3, ...","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9e1e34b75e352f8d371ada0ba6885a3e31b3bbda","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                  version\u003d\u00271.0\u0027)"},{"line_number":119,"context_line":"        # To simplify the logic, only keep compatible with stable release"},{"line_number":120,"context_line":"        # and numbered releases in VERSION_ALIASES, which is recommended to"},{"line_number":121,"context_line":"        # be used in production."},{"line_number":122,"context_line":"        version_cap \u003d self.VERSION_ALIASES.get("},{"line_number":123,"context_line":"            CONF.upgrade_levels.conductor,"},{"line_number":124,"context_line":"            self.RPC_API_VERSION)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_4f747bce","line":121,"in_reply_to":"7a740942_5cf0dfc9","updated":"2015-12-10 07:56:00.000000000","message":"There is a complex way. For example. users can set version_cap like \u00271.29\u0027 or \u00271.40\u0027 instead of \u0027liberty\u0027 and \u00274.3\u0027. So in theory, RPC APIs have to be compatible with all these versions. But I doubt the necessary, \u0027liberty\u0027 or \u00274.x\u0027 should be enough for operators.","commit_id":"30486bc9fbbe764cb960e370e66b061e2c968500"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5d80f86e9c1c7d5904723881e9051383fbca4f6d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":"rpcapi_cap_options \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027conductor\u0027,"},{"line_number":36,"context_line":"               choices\u003d[\u0027liberty\u0027, \u00274.0\u0027, \u00274.1\u0027, \u00274.2\u0027, \u00274.3\u0027],"},{"line_number":37,"context_line":"               help\u003d_(\u0027This will set the version cap for RPC messages sent \u0027"},{"line_number":38,"context_line":"                      \u0027to conductor services. The option should be enabled \u0027"},{"line_number":39,"context_line":"                      \u0027only when live upgrade is ready for work.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_0d42b810","line":36,"updated":"2016-01-04 20:54:54.000000000","message":"Is the plan to update this list of choices every time we do a new release? I\u0027d rather not do that because it means one more \u0027thing to do\u0027 whenever we do a release.\n\nCould you get the list of choices from VERSION_ALIASES?","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"cccd8b4506eaa8286bda9367af62e3ccdec00b49","unresolved":false,"context_lines":[{"line_number":33,"context_line":"CONF \u003d cfg.CONF"},{"line_number":34,"context_line":"rpcapi_cap_options \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027conductor\u0027,"},{"line_number":36,"context_line":"               choices\u003d[\u0027liberty\u0027, \u00274.0\u0027, \u00274.1\u0027, \u00274.2\u0027, \u00274.3\u0027],"},{"line_number":37,"context_line":"               help\u003d_(\u0027This will set the version cap for RPC messages sent \u0027"},{"line_number":38,"context_line":"                      \u0027to conductor services. The option should be enabled \u0027"},{"line_number":39,"context_line":"                      \u0027only when live upgrade is ready for work.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_1ad01b53","line":36,"in_reply_to":"fa69d971_0d42b810","updated":"2016-01-12 08:54:07.000000000","message":"Good idea","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5d80f86e9c1c7d5904723881e9051383fbca4f6d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    ...     Ironic\u0027s 4.3 release supports message version 1.31. So, any"},{"line_number":113,"context_line":"    changes to existing methods in 1.x after that point should be done such"},{"line_number":114,"context_line":"    that they can handle the version_cap being set to 1.31."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    # NOTE(lintan): Only keep compatible with stable release and numbered"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_b2c42b5f","line":115,"updated":"2016-01-04 20:54:54.000000000","message":"Do we need three entries for this, or can we use one that sez something like \u0027Ironic\u0027s Liberty, 4.2 and 4.3 releases support...\u0027.","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"cccd8b4506eaa8286bda9367af62e3ccdec00b49","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    ...     Ironic\u0027s 4.3 release supports message version 1.31. So, any"},{"line_number":113,"context_line":"    changes to existing methods in 1.x after that point should be done such"},{"line_number":114,"context_line":"    that they can handle the version_cap being set to 1.31."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    # NOTE(lintan): Only keep compatible with stable release and numbered"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_fae187ff","line":115,"in_reply_to":"fa69d971_b2c42b5f","updated":"2016-01-12 08:54:07.000000000","message":"Done","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5d80f86e9c1c7d5904723881e9051383fbca4f6d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # NOTE(lintan): Only keep compatible with stable release and numbered"},{"line_number":119,"context_line":"    # releases in VERSION_ALIASES, which is recommended to be used in"},{"line_number":120,"context_line":"    # production. If no appropriate value was given, the version cap"},{"line_number":121,"context_line":"    # will be the RPC_API_VERSION. RPC version \u00271.x\u0027 was not accepted as"},{"line_number":122,"context_line":"    # version cap."},{"line_number":123,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":124,"context_line":"        \u00274.0\u0027: \u00271.29\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_d27d1f1d","line":121,"updated":"2016-01-04 20:54:54.000000000","message":"What do you mean by \u00271.x\u0027? I don\u0027t understand why you are mentioning it. The config value is an ironic release version, not an RPC version so I don\u0027t know why you mention that 1.x was not accepted.","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"cccd8b4506eaa8286bda9367af62e3ccdec00b49","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # NOTE(lintan): Only keep compatible with stable release and numbered"},{"line_number":119,"context_line":"    # releases in VERSION_ALIASES, which is recommended to be used in"},{"line_number":120,"context_line":"    # production. If no appropriate value was given, the version cap"},{"line_number":121,"context_line":"    # will be the RPC_API_VERSION. RPC version \u00271.x\u0027 was not accepted as"},{"line_number":122,"context_line":"    # version cap."},{"line_number":123,"context_line":"    VERSION_ALIASES \u003d {"},{"line_number":124,"context_line":"        \u00274.0\u0027: \u00271.29\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_9ace4b82","line":121,"in_reply_to":"fa69d971_d27d1f1d","updated":"2016-01-12 08:54:07.000000000","message":"Done","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5d80f86e9c1c7d5904723881e9051383fbca4f6d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        \u00274.1\u0027: \u00271.30\u0027,"},{"line_number":126,"context_line":"        \u00274.2\u0027: \u00271.31\u0027,"},{"line_number":127,"context_line":"        \u0027liberty\u0027: \u00271.31\u0027,"},{"line_number":128,"context_line":"        \u00274.3\u0027: \u00271.31\u0027,"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_8d6d489a","line":128,"updated":"2016-01-04 20:54:54.000000000","message":"I\u0027m a bit confused. I thought that we cannot do live upgrades using any (lower) version of ironic that is below liberty. If that is the case, then why do we care about 4.0 and 4.1 and 4.2? We cannot support live upgrades from those versions, can we?","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"cccd8b4506eaa8286bda9367af62e3ccdec00b49","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        \u00274.1\u0027: \u00271.30\u0027,"},{"line_number":126,"context_line":"        \u00274.2\u0027: \u00271.31\u0027,"},{"line_number":127,"context_line":"        \u0027liberty\u0027: \u00271.31\u0027,"},{"line_number":128,"context_line":"        \u00274.3\u0027: \u00271.31\u0027,"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_5afc533e","line":128,"in_reply_to":"fa69d971_8d6d489a","updated":"2016-01-12 08:54:07.000000000","message":"Yes, we cannot. For live upgrade, the lowest RPC version should be 1.31. I was thinking RPC cap should become a more generic feature, but because it only work with live upgrade so far. So 4.0 and 4.1 is not need.","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5d80f86e9c1c7d5904723881e9051383fbca4f6d","unresolved":false,"context_lines":[{"line_number":622,"context_line":"            upgrade"},{"line_number":623,"context_line":"        \"\"\""},{"line_number":624,"context_line":"        version \u003d \u00271.30\u0027"},{"line_number":625,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":626,"context_line":"            raise NotImplementedError(_(\u0027Incompatible conductor version - \u0027"},{"line_number":627,"context_line":"                                        \u0027please upgrade ironic-conductor \u0027"},{"line_number":628,"context_line":"                                        \u0027first\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_edaba4d4","line":625,"updated":"2016-01-04 20:54:54.000000000","message":"Why do you need to make this call? Do all new methods have to do something like this? In the documentation, it only mentions the .can_send_version() if the arguments change: http://docs.openstack.org/developer/ironic/dev/code-contribution-guide.html#ironic-api-rpc-versions","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"ef2440fea15c4638ca238177a15235a09fe0b63e","unresolved":false,"context_lines":[{"line_number":622,"context_line":"            upgrade"},{"line_number":623,"context_line":"        \"\"\""},{"line_number":624,"context_line":"        version \u003d \u00271.30\u0027"},{"line_number":625,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":626,"context_line":"            raise NotImplementedError(_(\u0027Incompatible conductor version - \u0027"},{"line_number":627,"context_line":"                                        \u0027please upgrade ironic-conductor \u0027"},{"line_number":628,"context_line":"                                        \u0027first\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_d10b467c","line":625,"in_reply_to":"da6ed579_1dbc956b","updated":"2016-01-12 09:50:58.000000000","message":"Or UnsupportedVersion if the message target version is greater then the server side.","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8d08660163aeb4c47d14cac31dfe3df1cfe32296","unresolved":false,"context_lines":[{"line_number":622,"context_line":"            upgrade"},{"line_number":623,"context_line":"        \"\"\""},{"line_number":624,"context_line":"        version \u003d \u00271.30\u0027"},{"line_number":625,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":626,"context_line":"            raise NotImplementedError(_(\u0027Incompatible conductor version - \u0027"},{"line_number":627,"context_line":"                                        \u0027please upgrade ironic-conductor \u0027"},{"line_number":628,"context_line":"                                        \u0027first\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_db546922","line":625,"in_reply_to":"da6ed579_d10b467c","updated":"2016-01-13 16:33:45.000000000","message":"So for a future patch -- we should decide if we want to do this or not. Either we do it for all, or we don\u0027t do it for any because it should be consistent.\n\nAnd if we do it, I think we should provide some helper function that deals with it. It seems like a different message is needed based on if RemoteError or UnsupportedVersion is raised/returned?","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"1ffef97ade66f01ed384d4003298a13b30e83f96","unresolved":false,"context_lines":[{"line_number":622,"context_line":"            upgrade"},{"line_number":623,"context_line":"        \"\"\""},{"line_number":624,"context_line":"        version \u003d \u00271.30\u0027"},{"line_number":625,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":626,"context_line":"            raise NotImplementedError(_(\u0027Incompatible conductor version - \u0027"},{"line_number":627,"context_line":"                                        \u0027please upgrade ironic-conductor \u0027"},{"line_number":628,"context_line":"                                        \u0027first\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba63e191_a2386ba1","line":625,"in_reply_to":"da6ed579_db546922","updated":"2016-01-20 09:59:55.000000000","message":"hmmm, then I prefer to not add helper function, because currently the return value is meaningful enough.","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"cccd8b4506eaa8286bda9367af62e3ccdec00b49","unresolved":false,"context_lines":[{"line_number":622,"context_line":"            upgrade"},{"line_number":623,"context_line":"        \"\"\""},{"line_number":624,"context_line":"        version \u003d \u00271.30\u0027"},{"line_number":625,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":626,"context_line":"            raise NotImplementedError(_(\u0027Incompatible conductor version - \u0027"},{"line_number":627,"context_line":"                                        \u0027please upgrade ironic-conductor \u0027"},{"line_number":628,"context_line":"                                        \u0027first\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_1dbc956b","line":625,"in_reply_to":"fa69d971_edaba4d4","updated":"2016-01-12 08:54:07.000000000","message":"Not a must, because conductor side will directly return RemoteError(NoSuchMethod Endpoint) without running can_send_version() in API side, But this will give more valuable info to user.","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51d2f96b27e851727aa55d87ae0fa1d556faec45","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from ironic.conductor import manager"},{"line_number":31,"context_line":"from ironic.objects import base as objects_base"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(lintan): Only keep compatible with stable release and numbered"},{"line_number":34,"context_line":"# releases in VERSION_ALIASES, which is recommended to be used in"},{"line_number":35,"context_line":"# production. If no appropriate value was given, the version cap"},{"line_number":36,"context_line":"# will be the RPC_API_VERSION."}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_db91ca9a","line":33,"updated":"2016-01-13 16:33:34.000000000","message":"s/release/releases/","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e64e8aee57a3110e0a970c2df23973da2d7176f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from ironic.conductor import manager"},{"line_number":31,"context_line":"from ironic.objects import base as objects_base"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(lintan): Only keep compatible with stable release and numbered"},{"line_number":34,"context_line":"# releases in VERSION_ALIASES, which is recommended to be used in"},{"line_number":35,"context_line":"# production. If no appropriate value was given, the version cap"},{"line_number":36,"context_line":"# will be the RPC_API_VERSION."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba63e191_c6b7bad6","line":33,"in_reply_to":"da6ed579_db91ca9a","updated":"2016-01-20 09:56:16.000000000","message":"Done","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51d2f96b27e851727aa55d87ae0fa1d556faec45","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from ironic.objects import base as objects_base"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# NOTE(lintan): Only keep compatible with stable release and numbered"},{"line_number":34,"context_line":"# releases in VERSION_ALIASES, which is recommended to be used in"},{"line_number":35,"context_line":"# production. If no appropriate value was given, the version cap"},{"line_number":36,"context_line":"# will be the RPC_API_VERSION."},{"line_number":37,"context_line":"RPC_VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_bb3bb69b","line":34,"updated":"2016-01-13 16:33:34.000000000","message":"it is RPC_VERSION_ALIASES. But I\u0027d just omit it since this is describing RPC_VERSION_ALIASES anyway, so no need to mention it.","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51d2f96b27e851727aa55d87ae0fa1d556faec45","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u00274.2\u0027: \u00271.31\u0027,"},{"line_number":39,"context_line":"    \u0027liberty\u0027: \u00271.31\u0027,"},{"line_number":40,"context_line":"    \u00274.3\u0027: \u00271.31\u0027,"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"rpcapi_cap_options \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_1b2201ba","line":41,"updated":"2016-01-13 16:33:34.000000000","message":"Sorry for not mentioning this before, but I am now thinking about the documentation for this.\n\nThese are not aliases, they are mappings between ironic release versions and RPC versions. So maybe RELEASE_RPC_MAPPING or RPC_VERSION_MAPPING.\n\nFor the description, how about something like:\nThe mapping between ironic releases (stable and numbered) and their corresponding RPC versions. There should be an entry here for every release, starting from 4.2.\n\nIs there a description/link somewhere that we can put here, so people can understand how this is used wrt the conductor services when doing upgrades? And/or if there will be such documentation in the future, maybe put a TODO to add a link here?","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e64e8aee57a3110e0a970c2df23973da2d7176f0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u00274.2\u0027: \u00271.31\u0027,"},{"line_number":39,"context_line":"    \u0027liberty\u0027: \u00271.31\u0027,"},{"line_number":40,"context_line":"    \u00274.3\u0027: \u00271.31\u0027,"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"rpcapi_cap_options \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"ba63e191_ac786490","line":41,"in_reply_to":"da6ed579_1b2201ba","updated":"2016-01-20 09:56:16.000000000","message":"Thanks for this ruby","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51d2f96b27e851727aa55d87ae0fa1d556faec45","unresolved":false,"context_lines":[{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"rpcapi_cap_options \u003d ["},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027conductor\u0027,"},{"line_number":46,"context_line":"               choices\u003dlist(RPC_VERSION_ALIASES),"},{"line_number":47,"context_line":"               help\u003d_(\u0027Choose the lowest Ironic version of existing conductor \u0027"},{"line_number":48,"context_line":"                      \u0027services. This will set the version cap for RPC \u0027"},{"line_number":49,"context_line":"                      \u0027messages sent to conductor services. The option should \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_007e0fae","line":46,"updated":"2016-01-13 16:33:34.000000000","message":"This didn\u0027t work? I don\u0027t see it in the .sample file.","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e64e8aee57a3110e0a970c2df23973da2d7176f0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"rpcapi_cap_options \u003d ["},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027conductor\u0027,"},{"line_number":46,"context_line":"               choices\u003dlist(RPC_VERSION_ALIASES),"},{"line_number":47,"context_line":"               help\u003d_(\u0027Choose the lowest Ironic version of existing conductor \u0027"},{"line_number":48,"context_line":"                      \u0027services. This will set the version cap for RPC \u0027"},{"line_number":49,"context_line":"                      \u0027messages sent to conductor services. The option should \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba63e191_66d84ef0","line":46,"in_reply_to":"da6ed579_007e0fae","updated":"2016-01-20 09:56:16.000000000","message":"the chain of \u0027choices\u0027 patches didn\u0027t merged yet....so currently this will not add into .sample","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51d2f96b27e851727aa55d87ae0fa1d556faec45","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d_(\u0027Choose the lowest Ironic version of existing conductor \u0027"},{"line_number":48,"context_line":"                      \u0027services. This will set the version cap for RPC \u0027"},{"line_number":49,"context_line":"                      \u0027messages sent to conductor services. The option should \u0027"},{"line_number":50,"context_line":"                      \u0027be enabled only when live upgrade is ready for work.\u0027))"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"CONF.register_opts(rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_7ed1ab56","line":50,"updated":"2016-01-13 16:33:34.000000000","message":"This needs more work.\n\nBy \u0027The option should be enabled...\u0027 is that for us developers? This code enables this option so I\u0027m not sure what you mean.\n\nI think it would be helpful to have a description of how this is used. Something like \u0027For live upgrades, set this to the ironic version used by your existing conductor services. \u003cThen something about why/what this does; i think API is upgraded first then conductor? I don\u0027t recall the details\u003e\u0027","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e64e8aee57a3110e0a970c2df23973da2d7176f0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d_(\u0027Choose the lowest Ironic version of existing conductor \u0027"},{"line_number":48,"context_line":"                      \u0027services. This will set the version cap for RPC \u0027"},{"line_number":49,"context_line":"                      \u0027messages sent to conductor services. The option should \u0027"},{"line_number":50,"context_line":"                      \u0027be enabled only when live upgrade is ready for work.\u0027))"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"CONF.register_opts(rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba63e191_4ce8c8b4","line":50,"in_reply_to":"da6ed579_7ed1ab56","updated":"2016-01-20 09:56:16.000000000","message":"This is to tell admin not play around with the option until the work live upgrade is done. Yes, API should upgraded first then conductor.","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51d2f96b27e851727aa55d87ae0fa1d556faec45","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    |           object_class_action_versions, object_action and"},{"line_number":103,"context_line":"    |           object_backport_versions"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    ...     Ironic\u0027s 4.2, Liberty, 4.3 release supports message version 1.31."},{"line_number":106,"context_line":"    So, any changes to existing methods in 1.x after that"},{"line_number":107,"context_line":"    point should be done such that they can handle the version_cap being set"},{"line_number":108,"context_line":"    to 1.31."}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_e0597b5b","line":105,"updated":"2016-01-13 16:33:34.000000000","message":"s/release supports/releases support/","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e64e8aee57a3110e0a970c2df23973da2d7176f0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    |           object_class_action_versions, object_action and"},{"line_number":103,"context_line":"    |           object_backport_versions"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    ...     Ironic\u0027s 4.2, Liberty, 4.3 release supports message version 1.31."},{"line_number":106,"context_line":"    So, any changes to existing methods in 1.x after that"},{"line_number":107,"context_line":"    point should be done such that they can handle the version_cap being set"},{"line_number":108,"context_line":"    to 1.31."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba63e191_a94e1694","line":105,"in_reply_to":"da6ed579_e0597b5b","updated":"2016-01-20 09:56:16.000000000","message":"Done","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51d2f96b27e851727aa55d87ae0fa1d556faec45","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    ...     Ironic\u0027s 4.2, Liberty, 4.3 release supports message version 1.31."},{"line_number":106,"context_line":"    So, any changes to existing methods in 1.x after that"},{"line_number":107,"context_line":"    point should be done such that they can handle the version_cap being set"},{"line_number":108,"context_line":"    to 1.31."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    \"\"\""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_3b3ee6b8","line":108,"updated":"2016-01-13 16:33:34.000000000","message":"I can bet you that this string is going to be copy/pasted in the future, so it would be good to format it (so they are all around 80 chars long).","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e64e8aee57a3110e0a970c2df23973da2d7176f0","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    ...     Ironic\u0027s 4.2, Liberty, 4.3 release supports message version 1.31."},{"line_number":106,"context_line":"    So, any changes to existing methods in 1.x after that"},{"line_number":107,"context_line":"    point should be done such that they can handle the version_cap being set"},{"line_number":108,"context_line":"    to 1.31."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    \"\"\""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba63e191_894b1287","line":108,"in_reply_to":"da6ed579_3b3ee6b8","updated":"2016-01-20 09:56:16.000000000","message":"Done","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"51d2f96b27e851727aa55d87ae0fa1d556faec45","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                  version\u003d\u00271.0\u0027)"},{"line_number":123,"context_line":"        version_cap \u003d RPC_VERSION_ALIASES.get("},{"line_number":124,"context_line":"            CONF.upgrade_levels.conductor,"},{"line_number":125,"context_line":"            self.__class__.RPC_API_VERSION)"},{"line_number":126,"context_line":"        serializer \u003d objects_base.IronicObjectSerializer()"},{"line_number":127,"context_line":"        self.client \u003d rpc.get_client(target,"},{"line_number":128,"context_line":"                                     version_cap\u003dversion_cap,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_3ba02543","line":125,"updated":"2016-01-13 16:33:34.000000000","message":"If the \u0027choices\u0027 config thing works, if the user specifies some \u0027foo\u0027 string, they\u0027ll get an exception and the API service won\u0027t start? If so, could you check the exception to see if it is clear to the user what is wrong? (Would be good to have a test for that cuz I can\u0027t remember what happens).","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e64e8aee57a3110e0a970c2df23973da2d7176f0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                                  version\u003d\u00271.0\u0027)"},{"line_number":123,"context_line":"        version_cap \u003d RPC_VERSION_ALIASES.get("},{"line_number":124,"context_line":"            CONF.upgrade_levels.conductor,"},{"line_number":125,"context_line":"            self.__class__.RPC_API_VERSION)"},{"line_number":126,"context_line":"        serializer \u003d objects_base.IronicObjectSerializer()"},{"line_number":127,"context_line":"        self.client \u003d rpc.get_client(target,"},{"line_number":128,"context_line":"                                     version_cap\u003dversion_cap,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba63e191_86454271","line":125,"in_reply_to":"da6ed579_3ba02543","updated":"2016-01-20 09:56:16.000000000","message":"Yes, API service will not start. It will return: \n Value for option conductor is not valid: Valid values are [4.3, libverty, 4.2], but found \u0027foo\u0027 \n\nI will add a test for that.","commit_id":"6ef7b5687a9e0baf617c30558745053c6f538690"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"847d5a14fcea2923a881b15abb9a5990fafe0fdf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                      \u0027version of your existing conductor services. Then the \u0027"},{"line_number":51,"context_line":"                      \u0027latest ironic-api service is able to communicate \u0027"},{"line_number":52,"context_line":"                      \u0027with old ironic-conductor services in a compatible \u0027"},{"line_number":53,"context_line":"                      \u0027format.\u0027))"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CONF.register_opts(rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_f45173d9","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":29},"updated":"2016-01-27 03:48:29.000000000","message":"Better to add a comment on default value being used, as mentioned in the commit message so that ironic.conf file has that documentation on default value being used.\n\"If no appropriate value was given, the version cap will be the RPC_API_VERSION\"","commit_id":"e913e29f2fa13bc36cb878034d994fe623e7ec95"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e370e0cf312ef8d1c9519f067e86f5abcbda8ff3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                      \u0027version of your existing conductor services. Then the \u0027"},{"line_number":51,"context_line":"                      \u0027latest ironic-api service is able to communicate \u0027"},{"line_number":52,"context_line":"                      \u0027with old ironic-conductor services in a compatible \u0027"},{"line_number":53,"context_line":"                      \u0027format.\u0027))"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CONF.register_opts(rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_09faf0bd","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":29},"in_reply_to":"7a5de9d1_e720e6f9","updated":"2016-01-28 11:02:19.000000000","message":"Thanks for the clarification. I\u0027m fine with adding a note, but since this variable will come into play with value of RPC_API_VERSION if one puts no value to this variable, will it be useful to add that information into help text? \nI leave that to your discretion.","commit_id":"e913e29f2fa13bc36cb878034d994fe623e7ec95"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"2fc96f8c292380b0d0710c0601d6b269b9045578","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                      \u0027version of your existing conductor services. Then the \u0027"},{"line_number":51,"context_line":"                      \u0027latest ironic-api service is able to communicate \u0027"},{"line_number":52,"context_line":"                      \u0027with old ironic-conductor services in a compatible \u0027"},{"line_number":53,"context_line":"                      \u0027format.\u0027))"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"CONF.register_opts(rpcapi_cap_options, group\u003d\u0027upgrade_levels\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_e720e6f9","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":29},"in_reply_to":"9a68dd71_f45173d9","updated":"2016-01-28 08:19:47.000000000","message":"Thanks, but I have a concern to add a comment on the help messages. Because there is no real `default value` for the option, this will mixed with the default parameter of Opt. \nAnd the default value is not part of choices, which will also cause misunderstand. \nBTW, If you read the code in L125, I think that is a better place to put a note. But I prefer to treat this as a nit to help people understand the code.","commit_id":"e913e29f2fa13bc36cb878034d994fe623e7ec95"}],"ironic/tests/unit/conductor/test_rpcapi.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"79f289d47515024e522e628ccab32c413c8c3633","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        expected_error \u003d \"Valid values are .* but found \u0027fake\u0027\""},{"line_number":392,"context_line":"        self.assertRaisesRegex(ValueError, expected_error, CONF.set_override,"},{"line_number":393,"context_line":"                               \u0027conductor\u0027, \u0027fake\u0027, \u0027upgrade_levels\u0027,"},{"line_number":394,"context_line":"                               enforce_type\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_2791089a","line":394,"updated":"2016-01-21 16:20:16.000000000","message":"I have to admit that I don\u0027t understand how the config choices stuff works. I would have thought that the \u0027normal\u0027 path such as in the test above would have triggered the assertion. It seems odd to have to call this override since we don\u0027t explicitly do that in the ironic code.\n\nHow/when is the config value checked against the choices, in ironic?","commit_id":"74b2b55b0b60eda050867902dc489b6b384f6c5d"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"69e2535409a78f3ca88b16185645e45062e7d789","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        expected_error \u003d \"Valid values are .* but found \u0027fake\u0027\""},{"line_number":392,"context_line":"        self.assertRaisesRegex(ValueError, expected_error, CONF.set_override,"},{"line_number":393,"context_line":"                               \u0027conductor\u0027, \u0027fake\u0027, \u0027upgrade_levels\u0027,"},{"line_number":394,"context_line":"                               enforce_type\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_0cc16580","line":394,"in_reply_to":"9a68dd71_2791089a","updated":"2016-01-22 08:15:59.000000000","message":"It was checked when first access to the config value in Ironic. In this case, it was during the init of ConductorAPI. set_override with enforce_type\u003dTrue will trigger the same process to convert values using option\u0027s type.","commit_id":"74b2b55b0b60eda050867902dc489b6b384f6c5d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"997605e17b8c099478c36ce3f40a7c99932c3291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5a5ae5dd_dc69babf","line":395,"updated":"2016-02-04 22:45:50.000000000","message":"Can we add a test for a None value?  Basically to show that if the config option is not set that we get RPC_API_VERSION as the value of rpcapi.client.version_cap","commit_id":"e913e29f2fa13bc36cb878034d994fe623e7ec95"}],"releasenotes/notes/version-conductor-rpc-version-cap-678c67936f1b0162.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9b88417293013ff0deef1c61101f9e34feab8c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a rpc version cap which will convert rpc call to"},{"line_number":4,"context_line":"    a compatiable format with the version cap."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a config [upgrade_levels]condcutor_rpcapi_cap"},{"line_number":7,"context_line":"    to pin the rpc api to an old version during upgrade."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a740942_28809bbf","line":4,"updated":"2015-12-07 22:47:34.000000000","message":"s/compatiable/\n\nI wonder if this needs a feature. Isn\u0027t this part of the feature \u0027live-upgrades\u0027?","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e0e564d7d5cea858b60a76dd9e1923ea4e4b48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a rpc version cap which will convert rpc call to"},{"line_number":4,"context_line":"    a compatiable format with the version cap."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a config [upgrade_levels]condcutor_rpcapi_cap"},{"line_number":7,"context_line":"    to pin the rpc api to an old version during upgrade."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a740942_b1aee82b","line":4,"in_reply_to":"7a740942_28809bbf","updated":"2015-12-09 06:41:11.000000000","message":"Live upgrade is such a big future.... But I am fine to not mention the rpc version now.","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f9b88417293013ff0deef1c61101f9e34feab8c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    a compatiable format with the version cap."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a config [upgrade_levels]condcutor_rpcapi_cap"},{"line_number":7,"context_line":"    to pin the rpc api to an old version during upgrade."},{"line_number":8,"context_line":"    This will make api talk to conductor in a compatiable"},{"line_number":9,"context_line":"    format."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a740942_4875e7f7","line":7,"updated":"2015-12-07 22:47:34.000000000","message":"s/rpc api/RPC API/\n\nWould something like this be clearer? s/an old version/the version being used by the service being upgraded/\n\nI can\u0027t remember now, if we mention the default behaviour of configs in our renos - you might want to take a look.","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"18e0e564d7d5cea858b60a76dd9e1923ea4e4b48","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    a compatiable format with the version cap."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a config [upgrade_levels]condcutor_rpcapi_cap"},{"line_number":7,"context_line":"    to pin the rpc api to an old version during upgrade."},{"line_number":8,"context_line":"    This will make api talk to conductor in a compatiable"},{"line_number":9,"context_line":"    format."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a740942_d1e614af","line":7,"in_reply_to":"7a740942_4875e7f7","updated":"2015-12-09 06:41:11.000000000","message":"Yep, in reno describes the behavior of  the config","commit_id":"bb9fabd351a3edb36f587f9125f1e238ec27ab89"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"421fca2b0f5d4b20bb990364a56c3fc5e61f3e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Adds a config [upgrade_levels]condcutor to pin the RPC"},{"line_number":4,"context_line":"    API to the version being used by Ironic Conductor"},{"line_number":5,"context_line":"    services being upgraded. This will make API talk to"},{"line_number":6,"context_line":"    Conductor in a compatiable format."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a740942_a6d173fd","line":3,"updated":"2015-12-10 14:11:10.000000000","message":"misspelled conductor","commit_id":"e12ca3652411d4bd3ab60f6f06d5f4eba324907d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"421fca2b0f5d4b20bb990364a56c3fc5e61f3e41","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds a config [upgrade_levels]condcutor to pin the RPC"},{"line_number":4,"context_line":"    API to the version being used by Ironic Conductor"},{"line_number":5,"context_line":"    services being upgraded. This will make API talk to"},{"line_number":6,"context_line":"    Conductor in a compatiable format."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a740942_c6211ffe","line":6,"updated":"2015-12-10 14:11:10.000000000","message":"maybe \u0027API service\u0027 \u0026 \u0027Conductor service\u0027.\n\nI think we should mention the default behaviour.","commit_id":"e12ca3652411d4bd3ab60f6f06d5f4eba324907d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5d80f86e9c1c7d5904723881e9051383fbca4f6d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds a config [upgrade_levels]conductor to pin the RPC"},{"line_number":4,"context_line":"    API to the version being used by Ironic Conductor"},{"line_number":5,"context_line":"    services being upgraded. This will make API service talk"},{"line_number":6,"context_line":"    to Conductor service in a compatiable format. If no"},{"line_number":7,"context_line":"    appropriate value was given, the version cap will be the"},{"line_number":8,"context_line":"    latest RPC API version."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa69d971_6d86d466","line":6,"updated":"2016-01-04 20:54:54.000000000","message":"/compatiable/compatible/","commit_id":"469f60bb9ba92790bad7aa7d904afa3c9fd1a193"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dfeea7b3c7f95a3e433f8257ef78acc74eec3abc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Adds a config [upgrade_levels]conductor to pin the RPC"},{"line_number":4,"context_line":"    API to the version being used by Ironic Conductor"},{"line_number":5,"context_line":"    services being upgraded. This will make API service talk"},{"line_number":6,"context_line":"    to Conductor service in a compatible format. If no"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a68dd71_703ce62f","line":3,"updated":"2016-01-20 12:55:05.000000000","message":"nit - I think it makes more sense to write \"Added a [upgrade_levels]conductor config option...\" as \"adds\" seems weird when reading release notes :)","commit_id":"74b2b55b0b60eda050867902dc489b6b384f6c5d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"79f289d47515024e522e628ccab32c413c8c3633","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Adds a config [upgrade_levels]conductor to pin the RPC"},{"line_number":4,"context_line":"    API to the version being used by Ironic Conductor"},{"line_number":5,"context_line":"    services being upgraded. This will make API service talk"},{"line_number":6,"context_line":"    to Conductor service in a compatible format. If no"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a68dd71_87f554cc","line":3,"in_reply_to":"9a68dd71_703ce62f","updated":"2016-01-21 16:20:16.000000000","message":"I took a look at existing renos [1] and they seem to be in the present tense. We should be consistent, but personally I don\u0027t care what tense.\n\n[1] http://docs.openstack.org/releasenotes/ironic/current-series.html","commit_id":"74b2b55b0b60eda050867902dc489b6b384f6c5d"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"69e2535409a78f3ca88b16185645e45062e7d789","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Adds a config [upgrade_levels]conductor to pin the RPC"},{"line_number":4,"context_line":"    API to the version being used by Ironic Conductor"},{"line_number":5,"context_line":"    services being upgraded. This will make API service talk"},{"line_number":6,"context_line":"    to Conductor service in a compatible format. If no"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a68dd71_cce10d9c","line":3,"in_reply_to":"9a68dd71_87f554cc","updated":"2016-01-22 08:15:59.000000000","message":"hmm, I prefer to keep consistent. :) Thanks Vdrok and ruby","commit_id":"74b2b55b0b60eda050867902dc489b6b384f6c5d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"79f289d47515024e522e628ccab32c413c8c3633","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    services being upgraded. This will make API service talk"},{"line_number":6,"context_line":"    to Conductor service in a compatible format. If no"},{"line_number":7,"context_line":"    appropriate value was given, the version cap will be the"},{"line_number":8,"context_line":"    latest RPC API version."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a68dd71_47a99c7a","line":8,"updated":"2016-01-21 16:20:16.000000000","message":"Since this is experimental, do we want to do a reno for it? And if we do, should we mention that it is experimental/not usable yet?","commit_id":"74b2b55b0b60eda050867902dc489b6b384f6c5d"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"69e2535409a78f3ca88b16185645e45062e7d789","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    services being upgraded. This will make API service talk"},{"line_number":6,"context_line":"    to Conductor service in a compatible format. If no"},{"line_number":7,"context_line":"    appropriate value was given, the version cap will be the"},{"line_number":8,"context_line":"    latest RPC API version."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a68dd71_8c16b5a5","line":8,"in_reply_to":"9a68dd71_47a99c7a","updated":"2016-01-22 08:15:59.000000000","message":"OK, I will add the experimental thing.","commit_id":"74b2b55b0b60eda050867902dc489b6b384f6c5d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0c8f5a5d8c2a8ee52495ed2b0e02f9b2b17ce8a1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    to the version being used by Ironic Conductor services being upgraded."},{"line_number":5,"context_line":"    This will make API service talk to Conductor service in a compatible"},{"line_number":6,"context_line":"    format. If no appropriate value was given, the version cap will be the"},{"line_number":7,"context_line":"    latest RPC API version. This option is not usable until Ironic support"},{"line_number":8,"context_line":"    live upgrade feature."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a68dd71_20aa7786","line":7,"updated":"2016-01-26 20:15:57.000000000","message":"nit: s/usable/useful/ (jroll\u0027s suggestion if he doesn\u0027t suggest it)\n\ns/support/supports/","commit_id":"e913e29f2fa13bc36cb878034d994fe623e7ec95"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"a748a6c22c85561f805d7af4164858a17a57ab10","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    to the version being used by Ironic Conductor services being upgraded."},{"line_number":5,"context_line":"    This will make API service talk to Conductor service in a compatible"},{"line_number":6,"context_line":"    format. If no appropriate value was given, the version cap will be the"},{"line_number":7,"context_line":"    latest RPC API version. This option is not usable until Ironic support"},{"line_number":8,"context_line":"    live upgrade feature."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a68dd71_9e8e1626","line":7,"in_reply_to":"9a68dd71_20aa7786","updated":"2016-01-27 02:32:51.000000000","message":"Thanks Ruby, I will correct this if there is a new patch set needed.","commit_id":"e913e29f2fa13bc36cb878034d994fe623e7ec95"}]}
