)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b48165c60a5b3c322823f6ed0cea22be6f938d04","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The driver.utils.capabilities_to_dict is a pretty useful function,"},{"line_number":10,"context_line":"but it needs an improvement to the exception message to help the"},{"line_number":11,"context_line":"user understand the error motivation. Tests for this function need"},{"line_number":12,"context_line":"a refactoring to become more readable and useful, the are some exception"},{"line_number":13,"context_line":"message comparing are not executed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change improves capabilities_to_dict error handling and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_bd600f02","line":12,"updated":"2015-12-14 14:54:14.000000000","message":"this part of message looks incorrect.\n\u0027 the are some exception message comparing are not executed.\u0027","commit_id":"8807e7b3ff81a659984a61783ee67195eb054ece"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"63c777f24d8f9a5e94cb8d71fe3a3b6f5e876dba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The driver.utils.capabilities_to_dict is a pretty useful function,"},{"line_number":10,"context_line":"but it needs an improvement to the exception message to help the"},{"line_number":11,"context_line":"user understand the error motivation. Tests for this function need"},{"line_number":12,"context_line":"a refactoring to become more readable and useful, the are some exception"},{"line_number":13,"context_line":"message comparing are not executed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change improves capabilities_to_dict error handling and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a710552_a47766d3","line":12,"in_reply_to":"7a740942_bd600f02","updated":"2015-12-15 00:26:16.000000000","message":"Make sense, s/the are/there were, actually there were some exception asserts that should be inside of \u0027for\u0027 loops to assert that every case throws the exception, but they were outside of the \u0027for\u0027, so they only asserted that the last iteration throws the expected exception message. That\u0027s what I want to meant with that part.","commit_id":"8807e7b3ff81a659984a61783ee67195eb054ece"}],"ironic/drivers/utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e3d99a6d91f6aa41c1983da21f7cc9bdc9a840c9","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                _(\"Value of \u0027capabilities\u0027 must be string. Got %s\")"},{"line_number":234,"context_line":"                % type(capabilities))"},{"line_number":235,"context_line":"        for capability in capabilities.split(\u0027,\u0027):"},{"line_number":236,"context_line":"            parts \u003d capability.split(\u0027:\u0027)"},{"line_number":237,"context_line":"            if len(parts) \u003d\u003d 2 and parts[0] and parts[1]:"},{"line_number":238,"context_line":"                capabilities_dict[parts[0].strip()] \u003d parts[1].strip()"},{"line_number":239,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_a1bf1da9","line":236,"updated":"2015-12-10 14:26:08.000000000","message":"Better to remove leading and trailing spaces before comparing it for the parts.\n\nparts \u003d [x.strip(\u0027 \u0027) for x in capability.split(\u0027:\u0027)]","commit_id":"d0636abb0d91fb5f1cb66490b1241409cc02ef5f"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"0efcae216701d72cb0f40e7a83c22c404d5b3b0f","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                _(\"Value of \u0027capabilities\u0027 must be string. Got %s\")"},{"line_number":234,"context_line":"                % type(capabilities))"},{"line_number":235,"context_line":"        for capability in capabilities.split(\u0027,\u0027):"},{"line_number":236,"context_line":"            parts \u003d capability.split(\u0027:\u0027)"},{"line_number":237,"context_line":"            if len(parts) \u003d\u003d 2 and parts[0] and parts[1]:"},{"line_number":238,"context_line":"                capabilities_dict[parts[0].strip()] \u003d parts[1].strip()"},{"line_number":239,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_32ba9de2","line":236,"in_reply_to":"7a740942_a1bf1da9","updated":"2015-12-10 14:55:36.000000000","message":"Done","commit_id":"d0636abb0d91fb5f1cb66490b1241409cc02ef5f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c78d61c8c48bfbe717abf88dc6375457c03f3182","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            else:"},{"line_number":240,"context_line":"                exception_msg \u003d ("},{"line_number":241,"context_line":"                    _(\"Malformed capabilities: \u0027%s\u0027. Format should be\""},{"line_number":242,"context_line":"                      \" \u0027key:val\u0027.\") % capabilities"},{"line_number":243,"context_line":"                )"},{"line_number":244,"context_line":"                raise exception.InvalidParameterValue(exception_msg)"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_d78ea826","line":242,"updated":"2015-12-10 15:25:43.000000000","message":"Why \"capability\" that causes error is not used here (like previous code)?","commit_id":"d0636abb0d91fb5f1cb66490b1241409cc02ef5f"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"a235272a83eb3bb082254b50b67cf6774632c60e","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            else:"},{"line_number":240,"context_line":"                exception_msg \u003d ("},{"line_number":241,"context_line":"                    _(\"Malformed capabilities: \u0027%s\u0027. Format should be\""},{"line_number":242,"context_line":"                      \" \u0027key:val\u0027.\") % capabilities"},{"line_number":243,"context_line":"                )"},{"line_number":244,"context_line":"                raise exception.InvalidParameterValue(exception_msg)"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_da780ffb","line":242,"in_reply_to":"7a740942_d78ea826","updated":"2015-12-10 15:41:35.000000000","message":"That\u0027s the motivation of having capabilities, only \"capability\" in some cases won\u0027t inform the error properly, if the capability is something like a blank space, returning only it to the user will not help to understand what was malformed cause, IMO. So I added the full capabilities string and the format \u0027key:val\u0027 in the message to make it more helpful.","commit_id":"d0636abb0d91fb5f1cb66490b1241409cc02ef5f"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9dacac4b9dc630b4c1167558f55f2845c0aff9c4","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                _(\"Value of \u0027capabilities\u0027 must be string. Got %s\")"},{"line_number":234,"context_line":"                % type(capabilities))"},{"line_number":235,"context_line":"        for capability in capabilities.split(\u0027,\u0027):"},{"line_number":236,"context_line":"            parts \u003d [x.strip(\u0027 \u0027) for x in capability.split(\u0027:\u0027)]"},{"line_number":237,"context_line":"            if len(parts) \u003d\u003d 2 and parts[0] and parts[1]:"},{"line_number":238,"context_line":"                capabilities_dict[parts[0]] \u003d parts[1]"},{"line_number":239,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_325a7684","line":236,"updated":"2015-12-11 06:33:06.000000000","message":"strip() is enough, you don\u0027t have to use  \u0027  \u0027 to remove extra white-space.","commit_id":"3c8993bb28be119d97728308438a84d6d4eecfd2"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"7559fb30e477fe52b04b74029600638a2b53325c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                _(\"Value of \u0027capabilities\u0027 must be string. Got %s\")"},{"line_number":234,"context_line":"                % type(capabilities))"},{"line_number":235,"context_line":"        for capability in capabilities.split(\u0027,\u0027):"},{"line_number":236,"context_line":"            parts \u003d [x.strip(\u0027 \u0027) for x in capability.split(\u0027:\u0027)]"},{"line_number":237,"context_line":"            if len(parts) \u003d\u003d 2 and parts[0] and parts[1]:"},{"line_number":238,"context_line":"                capabilities_dict[parts[0]] \u003d parts[1]"},{"line_number":239,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_6d3811a1","line":236,"in_reply_to":"7a740942_325a7684","updated":"2015-12-11 12:02:53.000000000","message":"Done","commit_id":"3c8993bb28be119d97728308438a84d6d4eecfd2"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"9dacac4b9dc630b4c1167558f55f2845c0aff9c4","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            else:"},{"line_number":240,"context_line":"                exception_msg \u003d ("},{"line_number":241,"context_line":"                    _(\"Malformed capabilities: \u0027%s\u0027. Format should be\""},{"line_number":242,"context_line":"                      \" \u0027key:val\u0027.\") % capabilities"},{"line_number":243,"context_line":"                )"},{"line_number":244,"context_line":"                raise exception.InvalidParameterValue(exception_msg)"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_92024a08","line":242,"updated":"2015-12-11 06:33:06.000000000","message":"nit: In general, we left the space at end of the first line, not at beginning of the second.line.","commit_id":"3c8993bb28be119d97728308438a84d6d4eecfd2"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"7559fb30e477fe52b04b74029600638a2b53325c","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            else:"},{"line_number":240,"context_line":"                exception_msg \u003d ("},{"line_number":241,"context_line":"                    _(\"Malformed capabilities: \u0027%s\u0027. Format should be\""},{"line_number":242,"context_line":"                      \" \u0027key:val\u0027.\") % capabilities"},{"line_number":243,"context_line":"                )"},{"line_number":244,"context_line":"                raise exception.InvalidParameterValue(exception_msg)"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_adbb590e","line":242,"in_reply_to":"7a740942_92024a08","updated":"2015-12-11 12:02:53.000000000","message":"Done","commit_id":"3c8993bb28be119d97728308438a84d6d4eecfd2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b48165c60a5b3c322823f6ed0cea22be6f938d04","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                    _(\"Malformed capabilities: \u0027%s\u0027. Format should be \""},{"line_number":242,"context_line":"                      \"\u0027key:val\u0027.\") % capabilities"},{"line_number":243,"context_line":"                )"},{"line_number":244,"context_line":"                raise exception.InvalidParameterValue(exception_msg)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    return capabilities_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_209ab262","line":244,"updated":"2015-12-14 14:54:14.000000000","message":"Would it be better to parse all the capabilities and then raise an exception informing all malformed capability names instead of raising it on first found instance of malformed capability?","commit_id":"8807e7b3ff81a659984a61783ee67195eb054ece"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"63c777f24d8f9a5e94cb8d71fe3a3b6f5e876dba","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                    _(\"Malformed capabilities: \u0027%s\u0027. Format should be \""},{"line_number":242,"context_line":"                      \"\u0027key:val\u0027.\") % capabilities"},{"line_number":243,"context_line":"                )"},{"line_number":244,"context_line":"                raise exception.InvalidParameterValue(exception_msg)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    return capabilities_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_844b4ab0","line":244,"in_reply_to":"7a740942_209ab262","updated":"2015-12-15 00:26:16.000000000","message":"Great idea, Done.","commit_id":"8807e7b3ff81a659984a61783ee67195eb054ece"}],"ironic/tests/unit/drivers/test_utils.py":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"dbc913ad732773b1c39eae7be8b68f2e3e81120a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        capabilities_with_blank_space \u003d \u0027 a:b, c:d, e:f\u0027"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        self.assertEqual("},{"line_number":193,"context_line":"            {\u0027 a\u0027: \u0027b\u0027, \u0027 c\u0027: \u0027d\u0027, \u0027 e\u0027: \u0027f\u0027},"},{"line_number":194,"context_line":"            driver_utils.capabilities_to_dict(capabilities_with_blank_space)"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_8867c424","line":193,"updated":"2015-12-10 03:34:49.000000000","message":"I don\u0027t think this should be accepted, better to remove blank_space use strip() like get_node_capability() as well. This is can improve the robust to handle user input. \n\nAlthough this was only used for OneView driver, but it could be used for other cases in the future.\n\nFor instance, one of the common use cases for capabilities is to compare with Nova flavor which use \u0027\u003d\u003d\u0027 to compare if I remember correctly.","commit_id":"f25f298f5d5d94837b2705038e38879962296a06"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"55d47df69828767c7a76496950197545c116b449","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        capabilities_with_blank_space \u003d \u0027 a:b, c:d, e:f\u0027"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        self.assertEqual("},{"line_number":193,"context_line":"            {\u0027 a\u0027: \u0027b\u0027, \u0027 c\u0027: \u0027d\u0027, \u0027 e\u0027: \u0027f\u0027},"},{"line_number":194,"context_line":"            driver_utils.capabilities_to_dict(capabilities_with_blank_space)"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_cf9e1d07","line":193,"in_reply_to":"7a740942_8867c424","updated":"2015-12-10 11:59:20.000000000","message":"Done","commit_id":"f25f298f5d5d94837b2705038e38879962296a06"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e3d99a6d91f6aa41c1983da21f7cc9bdc9a840c9","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.assertEqual("},{"line_number":193,"context_line":"            {\u0027a\u0027: \u0027b\u0027, \u0027c\u0027: \u0027d\u0027, \u0027e\u0027: \u0027f\u0027},"},{"line_number":194,"context_line":"            driver_utils.capabilities_to_dict(capabilities_with_blank_space)"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_capabilities_to_dict_with_only_key_or_value_fail(self):"},{"line_number":198,"context_line":"        capabilities_only_key_or_value \u003d \u0027xpto\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_dc3572db","line":195,"updated":"2015-12-10 14:26:08.000000000","message":"May be you can add a negative testcase for a capability having a space as value. :\n\ncapabilities\u003d\u0027foo:1, bar:   \u0027","commit_id":"d0636abb0d91fb5f1cb66490b1241409cc02ef5f"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"0efcae216701d72cb0f40e7a83c22c404d5b3b0f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.assertEqual("},{"line_number":193,"context_line":"            {\u0027a\u0027: \u0027b\u0027, \u0027c\u0027: \u0027d\u0027, \u0027e\u0027: \u0027f\u0027},"},{"line_number":194,"context_line":"            driver_utils.capabilities_to_dict(capabilities_with_blank_space)"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_capabilities_to_dict_with_only_key_or_value_fail(self):"},{"line_number":198,"context_line":"        capabilities_only_key_or_value \u003d \u0027xpto\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_b2e76d11","line":195,"in_reply_to":"7a740942_dc3572db","updated":"2015-12-10 14:55:36.000000000","message":"Done","commit_id":"d0636abb0d91fb5f1cb66490b1241409cc02ef5f"}]}
