)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"240f5ac590eca0b70978c69fb398527a9e32bd27","unresolved":false,"context_lines":[{"line_number":11,"context_line":"would change the default values of \u0027localhost\u0027 to the value \u0027ironic\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To prevent this we mock out the calls to system.getfqdn() and"},{"line_number":14,"context_line":"system.gethostname()"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also regenerate the etc/ironic/ironic.conf.sample file"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a7e1126_3bb62edd","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":20},"updated":"2015-12-17 06:54:33.000000000","message":"If you really want to use mock, please explicit declare the mock value you return","commit_id":"a5d25205564379aba363f4be3e0d6148066db39a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c2ae5c0457dcc7b82598dc5d5a16be5510e00f0f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"To prevent this we mock out the calls to system.getfqdn() and"},{"line_number":14,"context_line":"system.gethostname()"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also regenerate the etc/ironic/ironic.conf.sample file"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibaec7f2488896824e225e4f159a6284f31f17328"},{"line_number":19,"context_line":"Closes-Bug: #1524768"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da6ed579_6655fe1b","line":16,"updated":"2016-01-12 09:30:04.000000000","message":"was it really done? or was the diff just empty?","commit_id":"2269abbb4211132ccea802c34eea3d5b329c2f37"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8eda7291821877cafd621ed0afe7d3d40d1fe9ef","unresolved":false,"context_lines":[{"line_number":13,"context_line":"To prevent this we mock out the calls to system.getfqdn() and"},{"line_number":14,"context_line":"system.gethostname()"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also regenerate the etc/ironic/ironic.conf.sample file"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibaec7f2488896824e225e4f159a6284f31f17328"},{"line_number":19,"context_line":"Closes-Bug: #1524768"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da6ed579_c4a36f9d","line":16,"in_reply_to":"da6ed579_6655fe1b","updated":"2016-01-12 15:01:03.000000000","message":"No it was not done. When I rebased the sample file was correct.\n\nI will update this if the patch gets done again or if people feel it is necessary.","commit_id":"2269abbb4211132ccea802c34eea3d5b329c2f37"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"727701213b29baf95767350910e5822278669f11","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"#password\u003d"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":""},{"line_number":1661,"context_line":"[oslo_messaging_qpid]"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"#"},{"line_number":1664,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7a740942_099d6109","line":1661,"updated":"2015-12-14 15:41:00.000000000","message":"This brings back config options that were removed here I1c24c49f6a07fc4289d8732b0ab4e6ced179e47e . I think rebuilding venv would help.","commit_id":"d4c6851fbcadbcf3bb2c90ea4bf9d33909d5509a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5171a73e794e0797b178756a1f854d0544f76bba","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"#password\u003d"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":""},{"line_number":1661,"context_line":"[oslo_messaging_qpid]"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"#"},{"line_number":1664,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7a740942_347d146d","line":1661,"in_reply_to":"7a740942_099d6109","updated":"2015-12-14 15:51:17.000000000","message":"Oh, we have !\u003d3.1.0 for oslo.messaging :(","commit_id":"d4c6851fbcadbcf3bb2c90ea4bf9d33909d5509a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"907e90371e86f8a1cdcab713e6b63b61ddcbee04","unresolved":false,"context_lines":[{"line_number":1658,"context_line":"#password\u003d"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":""},{"line_number":1661,"context_line":"[oslo_messaging_qpid]"},{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"#"},{"line_number":1664,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7a740942_37f3d374","line":1661,"in_reply_to":"7a740942_347d146d","updated":"2015-12-14 16:57:14.000000000","message":"Yes I did do:\n\n tox -egenconfig -r\n\nI think oslo.messaging 3.1.0 broke things, so it got excluded in global-requirements\n\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt#L97","commit_id":"d4c6851fbcadbcf3bb2c90ea4bf9d33909d5509a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4d751cc2b94582d8289042914668523bdfcc0b9d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"# the node name must be valid within an AMQP key, and if using"},{"line_number":126,"context_line":"# ZeroMQ, a valid hostname, FQDN, or IP address. (string"},{"line_number":127,"context_line":"# value)"},{"line_number":128,"context_line":"#host\u003dlocalhost"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da6ed579_4a128f58","line":128,"range":{"start_line":128,"start_character":6,"end_line":128,"end_character":15},"updated":"2016-01-14 20:29:15.000000000","message":"The patch intentionally caused this to change.","commit_id":"0a75c41e210454e5e026b6ea3299b8a8fdc6f610"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4d751cc2b94582d8289042914668523bdfcc0b9d","unresolved":false,"context_lines":[{"line_number":312,"context_line":"# Name of this node. Must be a valid hostname, FQDN, or IP"},{"line_number":313,"context_line":"# address. Must match \"host\" option, if running Nova. (string"},{"line_number":314,"context_line":"# value)"},{"line_number":315,"context_line":"#rpc_zmq_host\u003dlocalhost"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"# Seconds to wait before a cast expires (TTL). Only supported"},{"line_number":318,"context_line":"# by impl_zmq. (integer value)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"da6ed579_aa50eb0b","line":315,"range":{"start_line":315,"start_character":1,"end_line":315,"end_character":13},"updated":"2016-01-14 20:29:15.000000000","message":"The patch intentionally caused this to change.","commit_id":"0a75c41e210454e5e026b6ea3299b8a8fdc6f610"}],"ironic/common/config_generator/generator.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a0af7f66771a9121bf65e9429455072c791ac962","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    elif value in (FAKE_HOSTNAME, FAKE_FQDN):"},{"line_number":259,"context_line":"        if \u0027host\u0027 in name:"},{"line_number":260,"context_line":"            return \u0027ironic\u0027"},{"line_number":261,"context_line":"    elif value.endswith(FAKE_HOSTNAME):"},{"line_number":262,"context_line":"        return value.replace(FAKE_HOSTNAME, \u0027ironic\u0027)"},{"line_number":263,"context_line":"    elif value.endswith(FAKE_FQDN):"},{"line_number":264,"context_line":"        return value.replace(FAKE_FQDN, \u0027ironic\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_4b7a9d25","line":261,"updated":"2015-12-14 04:34:30.000000000","message":"If we fixed the hostname and fqdn as constants, we can eliminate this case.\nI confirmed this path is dead by inserting breakpoint here.","commit_id":"cde7742d5aaa31d6d62e3c15d73da4e1c37a21b8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8857a47b8d8e512fe28a14b683c10900bf88eb10","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    elif value in (FAKE_HOSTNAME, FAKE_FQDN):"},{"line_number":259,"context_line":"        if \u0027host\u0027 in name:"},{"line_number":260,"context_line":"            return \u0027ironic\u0027"},{"line_number":261,"context_line":"    elif value.endswith(FAKE_HOSTNAME):"},{"line_number":262,"context_line":"        return value.replace(FAKE_HOSTNAME, \u0027ironic\u0027)"},{"line_number":263,"context_line":"    elif value.endswith(FAKE_FQDN):"},{"line_number":264,"context_line":"        return value.replace(FAKE_FQDN, \u0027ironic\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_2eb5c3eb","line":261,"in_reply_to":"7a740942_4b7a9d25","updated":"2015-12-14 15:20:50.000000000","message":"Good catch. Thanks :)","commit_id":"cde7742d5aaa31d6d62e3c15d73da4e1c37a21b8"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a0af7f66771a9121bf65e9429455072c791ac962","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            return \u0027ironic\u0027"},{"line_number":261,"context_line":"    elif value.endswith(FAKE_HOSTNAME):"},{"line_number":262,"context_line":"        return value.replace(FAKE_HOSTNAME, \u0027ironic\u0027)"},{"line_number":263,"context_line":"    elif value.endswith(FAKE_FQDN):"},{"line_number":264,"context_line":"        return value.replace(FAKE_FQDN, \u0027ironic\u0027)"},{"line_number":265,"context_line":"    elif value.strip() !\u003d value:"},{"line_number":266,"context_line":"        return \u0027\"%s\"\u0027 % value"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_0b70153f","line":263,"updated":"2015-12-14 04:34:30.000000000","message":"Ditto.\n\nWe can remove the line 261 to 264.","commit_id":"cde7742d5aaa31d6d62e3c15d73da4e1c37a21b8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8857a47b8d8e512fe28a14b683c10900bf88eb10","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            return \u0027ironic\u0027"},{"line_number":261,"context_line":"    elif value.endswith(FAKE_HOSTNAME):"},{"line_number":262,"context_line":"        return value.replace(FAKE_HOSTNAME, \u0027ironic\u0027)"},{"line_number":263,"context_line":"    elif value.endswith(FAKE_FQDN):"},{"line_number":264,"context_line":"        return value.replace(FAKE_FQDN, \u0027ironic\u0027)"},{"line_number":265,"context_line":"    elif value.strip() !\u003d value:"},{"line_number":266,"context_line":"        return \u0027\"%s\"\u0027 % value"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_ced0bf21","line":263,"in_reply_to":"7a740942_0b70153f","updated":"2015-12-14 15:20:50.000000000","message":"Done","commit_id":"cde7742d5aaa31d6d62e3c15d73da4e1c37a21b8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1d10da692c02b493822ff1cc3228cb158a951294","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    elif value \u003d\u003d _get_my_ip():"},{"line_number":257,"context_line":"        return \u002710.0.0.1\u0027"},{"line_number":258,"context_line":"    elif value in (FAKE_HOSTNAME, FAKE_FQDN):"},{"line_number":259,"context_line":"        if \u0027host\u0027 in name:"},{"line_number":260,"context_line":"            return \u0027ironic\u0027"},{"line_number":261,"context_line":"    elif value.strip() !\u003d value:"},{"line_number":262,"context_line":"        return \u0027\"%s\"\u0027 % value"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_6d3c1530","line":259,"updated":"2015-12-14 17:34:52.000000000","message":"I\u0027m not sure about this, if it is not a \u0027.*host.*\u0027 config option it should be \u0027fakehost\u0027 instead of \u0027ironic\u0027? Maybe it could be just mocked with \u0027ironic\u0027 value from the start?","commit_id":"d4c6851fbcadbcf3bb2c90ea4bf9d33909d5509a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2eb3404a7d171409d2e12c046761e1b7c170a8c6","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    elif value \u003d\u003d _get_my_ip():"},{"line_number":257,"context_line":"        return \u002710.0.0.1\u0027"},{"line_number":258,"context_line":"    elif value in (FAKE_HOSTNAME, FAKE_FQDN):"},{"line_number":259,"context_line":"        if \u0027host\u0027 in name:"},{"line_number":260,"context_line":"            return \u0027ironic\u0027"},{"line_number":261,"context_line":"    elif value.strip() !\u003d value:"},{"line_number":262,"context_line":"        return \u0027\"%s\"\u0027 % value"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_53f9bcc7","line":259,"in_reply_to":"5a710552_136254d9","updated":"2015-12-14 17:57:20.000000000","message":"I mean why not just do\n\n @mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)\n\nand the same for fqdn and remove this elif completely","commit_id":"d4c6851fbcadbcf3bb2c90ea4bf9d33909d5509a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"774b1b93a0cd435c9de9f8d8278be8d8e2bd78ee","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    elif value \u003d\u003d _get_my_ip():"},{"line_number":257,"context_line":"        return \u002710.0.0.1\u0027"},{"line_number":258,"context_line":"    elif value in (FAKE_HOSTNAME, FAKE_FQDN):"},{"line_number":259,"context_line":"        if \u0027host\u0027 in name:"},{"line_number":260,"context_line":"            return \u0027ironic\u0027"},{"line_number":261,"context_line":"    elif value.strip() !\u003d value:"},{"line_number":262,"context_line":"        return \u0027\"%s\"\u0027 % value"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_9334044b","line":259,"in_reply_to":"5a710552_53f9bcc7","updated":"2015-12-14 18:03:10.000000000","message":"Ah, that makes sense. Changing L80 \u0026 L81","commit_id":"d4c6851fbcadbcf3bb2c90ea4bf9d33909d5509a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"365ceafa5dddeb74792c69ec6e860ea31a6a150b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    elif value \u003d\u003d _get_my_ip():"},{"line_number":257,"context_line":"        return \u002710.0.0.1\u0027"},{"line_number":258,"context_line":"    elif value in (FAKE_HOSTNAME, FAKE_FQDN):"},{"line_number":259,"context_line":"        if \u0027host\u0027 in name:"},{"line_number":260,"context_line":"            return \u0027ironic\u0027"},{"line_number":261,"context_line":"    elif value.strip() !\u003d value:"},{"line_number":262,"context_line":"        return \u0027\"%s\"\u0027 % value"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_136254d9","line":259,"in_reply_to":"5a710552_6d3c1530","updated":"2015-12-14 17:53:36.000000000","message":"It would make sense to me to just do:\n\n return \u0027ironic\u0027\n\nAnd delete the:\n if \u0027host\u0027 in name:\n\nIs that what you mean?","commit_id":"d4c6851fbcadbcf3bb2c90ea4bf9d33909d5509a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e9ac4e0568fb8664fd2104c7b14265572f312e84","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    elif value \u003d\u003d _get_my_ip():"},{"line_number":257,"context_line":"        return \u002710.0.0.1\u0027"},{"line_number":258,"context_line":"    elif value in (FAKE_HOSTNAME, FAKE_FQDN):"},{"line_number":259,"context_line":"        return \u0027ironic\u0027"},{"line_number":260,"context_line":"    elif value.strip() !\u003d value:"},{"line_number":261,"context_line":"        return \u0027\"%s\"\u0027 % value"},{"line_number":262,"context_line":"    return value"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_b3afc093","line":259,"updated":"2015-12-14 18:02:58.000000000","message":"/me does wonder if it would be better if this was \u0027localhost\u0027","commit_id":"a8cdeb0da887f1cd2decf8a480d5528a3bcc6777"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"9a32ccc0f6f47273949f2687c817edf47c2bb236","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Don\u0027t let the system hostname or FQDN affect config file values"},{"line_number":78,"context_line":"@mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)"},{"line_number":79,"context_line":"@mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)"},{"line_number":80,"context_line":"def generate(argv):"},{"line_number":81,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":82,"context_line":"        description\u003d\u0027generate sample configuration file\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_13fc943d","line":79,"updated":"2015-12-14 18:05:32.000000000","message":"I do wonder if this would be better for it to return \u0027localhost\u0027. As is it is duplicating the previous behavior.\n\nBut I think a default value of \u0027localhost\u0027 makes more sense than \u0027ironic\u0027","commit_id":"a5d25205564379aba363f4be3e0d6148066db39a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c7b252b2659733f5209f6b842d94b34c5d10445c","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Don\u0027t let the system hostname or FQDN affect config file values"},{"line_number":78,"context_line":"@mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)"},{"line_number":79,"context_line":"@mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)"},{"line_number":80,"context_line":"def generate(argv):"},{"line_number":81,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":82,"context_line":"        description\u003d\u0027generate sample configuration file\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_96111eaf","line":79,"in_reply_to":"3a7e1126_5bc1bae3","updated":"2015-12-17 11:36:51.000000000","message":"This patch does not change the default behavior. It keeps it producing the same values for the config file as before (except when someone ran this on a system with a hostname/FQDN of \u0027localhost\u0027)\n\nI would prefer to change it from \u0027ironic\u0027 to \u0027localhost\u0027 in a different patch as that is a separate change in my opinion.","commit_id":"a5d25205564379aba363f4be3e0d6148066db39a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d731c42f1bd4642863a00638451e02c1d5ded681","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Don\u0027t let the system hostname or FQDN affect config file values"},{"line_number":78,"context_line":"@mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)"},{"line_number":79,"context_line":"@mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)"},{"line_number":80,"context_line":"def generate(argv):"},{"line_number":81,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":82,"context_line":"        description\u003d\u0027generate sample configuration file\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_53f3e173","line":79,"in_reply_to":"5a710552_13fc943d","updated":"2015-12-15 06:05:32.000000000","message":"John,\n\nI think that the line 78-79 are correct to duplicate the previous behavior.\n\nI figure out that the line 78 \n @mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)\nis solely for \u0027rpc_zmq_host\u0027 \nhttps://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_zmq.py#L69-L70\n\nand the line 79 \n @mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)\nis for solely for Ironic\u0027s \u0027host\u0027  https://github.com/openstack/ironic/blob/master/ironic/common/service.py#L43-L44\n\nBut considering  \"sample_default\u003d\u0027localhost\u0027\" of \u0027rpc_zmq_host\u0027, the line 78 would be\n  @mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027localhost\u0027)\nif we could change the previous behavior.\n\nBest regards,\nNaohiro","commit_id":"a5d25205564379aba363f4be3e0d6148066db39a"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"240f5ac590eca0b70978c69fb398527a9e32bd27","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Don\u0027t let the system hostname or FQDN affect config file values"},{"line_number":78,"context_line":"@mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)"},{"line_number":79,"context_line":"@mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)"},{"line_number":80,"context_line":"def generate(argv):"},{"line_number":81,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":82,"context_line":"        description\u003d\u0027generate sample configuration file\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_5bc1bae3","line":79,"in_reply_to":"5a710552_53f3e173","updated":"2015-12-17 06:54:33.000000000","message":"Agree with Naohiro , I prefer the \u0027localhost\u0027 as a default value. Also because you change the default behavior, why not change in line 254: if \u0027host\u0027 in name: return \u0027localhost\u0027. \n\nThe mock stuff which looks so strange to me.","commit_id":"a5d25205564379aba363f4be3e0d6148066db39a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6fc265436aa829eefc5404582163690f2bf0f969","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Don\u0027t let the system hostname or FQDN affect config file values"},{"line_number":78,"context_line":"@mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)"},{"line_number":79,"context_line":"@mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)"},{"line_number":80,"context_line":"def generate(argv):"},{"line_number":81,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":82,"context_line":"        description\u003d\u0027generate sample configuration file\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_3651cf36","line":79,"updated":"2016-01-14 18:59:11.000000000","message":"Ok, I\u0027ll bite. Dumb question -- why do we want to mock these? What calls them/how are they being used?","commit_id":"2269abbb4211132ccea802c34eea3d5b329c2f37"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bca5e658344faaff12548c951d67ff6b1525348e","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Don\u0027t let the system hostname or FQDN affect config file values"},{"line_number":78,"context_line":"@mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)"},{"line_number":79,"context_line":"@mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)"},{"line_number":80,"context_line":"def generate(argv):"},{"line_number":81,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":82,"context_line":"        description\u003d\u0027generate sample configuration file\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_e1acce8d","line":79,"in_reply_to":"da6ed579_3651cf36","updated":"2016-01-14 19:43:37.000000000","message":"So some of the libraries call these functions. And when the host that the config generation is run on is named \u0027localhost\u0027 it causes the generated config file to differ from what is generated on a system not named \u0027localhost\u0027","commit_id":"2269abbb4211132ccea802c34eea3d5b329c2f37"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c1c377e07948b3fe8f79c494ddf357109167e3bf","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Don\u0027t let the system hostname or FQDN affect config file values"},{"line_number":78,"context_line":"@mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)"},{"line_number":79,"context_line":"@mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)"},{"line_number":80,"context_line":"def generate(argv):"},{"line_number":81,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":82,"context_line":"        description\u003d\u0027generate sample configuration file\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_61aa1e87","line":79,"in_reply_to":"da6ed579_3651cf36","updated":"2016-01-14 19:33:19.000000000","message":"They\u0027re used in config defaults.","commit_id":"2269abbb4211132ccea802c34eea3d5b329c2f37"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6e59526b8f4e56c4a1d68d197023625324f7bfc3","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Don\u0027t let the system hostname or FQDN affect config file values"},{"line_number":78,"context_line":"@mock.patch.object(socket, \u0027gethostname\u0027, lambda: \u0027ironic\u0027)"},{"line_number":79,"context_line":"@mock.patch.object(socket, \u0027getfqdn\u0027, lambda: \u0027ironic\u0027)"},{"line_number":80,"context_line":"def generate(argv):"},{"line_number":81,"context_line":"    parser \u003d argparse.ArgumentParser("},{"line_number":82,"context_line":"        description\u003d\u0027generate sample configuration file\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_278d16d6","line":79,"in_reply_to":"da6ed579_e1acce8d","updated":"2016-01-14 20:24:52.000000000","message":"So, reading more IRC conversation, it seems like the goal is for these to be \u0027localhost\u0027, which this doesn\u0027t do.","commit_id":"2269abbb4211132ccea802c34eea3d5b329c2f37"}]}