)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"558bd0de8319748fc7b75d5616f777c5069e4ba9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"plugin is in use, and devstack should not run the ironic code in the"},{"line_number":11,"context_line":"devstack tree."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note that this is not yet configured to run in the gate."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I147ea059f75720132dd82ff9e7cd3bfdff7fa584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_9e29093a","line":13,"updated":"2015-12-10 21:26:02.000000000","message":"Maybe could add a comment that plugin.sh is a modified version from devstack of: extras.d/50-ironic.sh","commit_id":"a0dcef410e3a415c880e67d2d173a87f10110e10"}],"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"11fbba0de52931af5ce46049944f4580b28a8534","unresolved":false,"context_lines":[{"line_number":61,"context_line":"# Set up defaults for functional / integration testing"},{"line_number":62,"context_line":"IRONIC_NODE_UUID\u003d${IRONIC_NODE_UUID:-`uuidgen`}"},{"line_number":63,"context_line":"IRONIC_SCRIPTS_DIR\u003d${IRONIC_SCRIPTS_DIR:-$DEST/ironic/devstack/tools/ironic/scripts}"},{"line_number":64,"context_line":"IRONIC_TEMPLATES_DIR\u003d${IRONIC_TEMPLATES_DIR:-$DEST/ironic/devstack/tools/ironic/templates}"},{"line_number":65,"context_line":"IRONIC_BAREMETAL_BASIC_OPS\u003d$(trueorfalse False IRONIC_BAREMETAL_BASIC_OPS)"},{"line_number":66,"context_line":"IRONIC_ENABLED_DRIVERS\u003d${IRONIC_ENABLED_DRIVERS:-fake,pxe_ssh,pxe_ipmitool}"},{"line_number":67,"context_line":"IRONIC_SSH_USERNAME\u003d${IRONIC_SSH_USERNAME:-`whoami`}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a740942_32261dbb","line":64,"updated":"2015-12-10 14:51:47.000000000","message":"nit: maybe have\n\n IRONIC_DEVSTACK_DIR\u003d$DEST/ironic/devstack\n\nfor convenience","commit_id":"76fbd9ba06c91bf0bdc26e3299cdbc9eba78233d"}],"devstack/override-defaults":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"558bd0de8319748fc7b75d5616f777c5069e4ba9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7a740942_795a3785","updated":"2015-12-10 21:26:02.000000000","message":"I think this file has to be called \u0027override_defaults\u0027  underscore not hyphen.\n\nhttp://docs.openstack.org/developer/devstack/plugins.html","commit_id":"a0dcef410e3a415c880e67d2d173a87f10110e10"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7ff8deeac967a0af32dd55c190d2e7a5e9aaa528","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7a740942_ed7de11c","in_reply_to":"7a740942_795a3785","updated":"2015-12-11 12:12:43.000000000","message":"Looking at the code it seems that the documentation is wrong [0], it\u0027s checking for a file called override-defaults with hyphen. It\u0027s confusing indeed\n\n[0] https://github.com/openstack-dev/devstack/blob/5f23dbe978cad874863ab5c2876be1e76d2efcfa/functions-common#L1729-L1734","commit_id":"a0dcef410e3a415c880e67d2d173a87f10110e10"}],"devstack/plugin.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cce096a2170ad6c0614abd3c1776c3cab49d7f78","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if is_service_enabled ir-api ir-cond; then"},{"line_number":8,"context_line":"    if [[ \"$1\" \u003d\u003d \"source\" ]]; then"},{"line_number":9,"context_line":"        # Initial source"},{"line_number":10,"context_line":"        source $TOP_DIR/lib/ironic"},{"line_number":11,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":12,"context_line":"        echo_summary \"Installing Ironic\""},{"line_number":13,"context_line":"        install_ironic"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a740942_a67733d3","line":10,"updated":"2015-12-10 14:09:47.000000000","message":"isn\u0027t it the same as line 5? also ironic-inspector lives happily without the \"source\" part at all: https://github.com/openstack/ironic-inspector/blob/master/devstack/plugin.sh#L264-L294","commit_id":"5a49b136f40be88c11a45fd4454296d1b3a7b0b6"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6cd5c48a1cfd636bb67059f939af242ff8d5dc7a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if is_service_enabled ir-api ir-cond; then"},{"line_number":8,"context_line":"    if [[ \"$1\" \u003d\u003d \"source\" ]]; then"},{"line_number":9,"context_line":"        # Initial source"},{"line_number":10,"context_line":"        source $TOP_DIR/lib/ironic"},{"line_number":11,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":12,"context_line":"        echo_summary \"Installing Ironic\""},{"line_number":13,"context_line":"        install_ironic"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a740942_9c728a10","line":10,"in_reply_to":"7a740942_a67733d3","updated":"2015-12-10 14:46:43.000000000","message":"You\u0027re right, I\u0027ll remove. This was copied from extras.d in devstack.\n\nAs for inspector, you have all of your functions defined in this file, while I\u0027m defining them in lib/ironic here, so I need to source it in line 5 so the functions exist. :)","commit_id":"5a49b136f40be88c11a45fd4454296d1b3a7b0b6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cce096a2170ad6c0614abd3c1776c3cab49d7f78","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":30,"context_line":"        start_ironic"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        if [[ \"$IRONIC_BAREMETAL_BASIC_OPS\" \u003d \"True\" ]]; then"},{"line_number":33,"context_line":"            prepare_baremetal_basic_ops"},{"line_number":34,"context_line":"        fi"},{"line_number":35,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a740942_a625f3c2","line":32,"updated":"2015-12-10 14:09:47.000000000","message":"nit: as this variable is initialized in lib/ironic, would be nice to move this check there, hiding it behind some generic function like \"configure_ironic_extra\"","commit_id":"5a49b136f40be88c11a45fd4454296d1b3a7b0b6"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6cd5c48a1cfd636bb67059f939af242ff8d5dc7a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":30,"context_line":"        start_ironic"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        if [[ \"$IRONIC_BAREMETAL_BASIC_OPS\" \u003d \"True\" ]]; then"},{"line_number":33,"context_line":"            prepare_baremetal_basic_ops"},{"line_number":34,"context_line":"        fi"},{"line_number":35,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a740942_dcd6d2c2","line":32,"in_reply_to":"7a740942_a625f3c2","updated":"2015-12-10 14:46:43.000000000","message":"Remind me to come back to this once I get things working :)","commit_id":"5a49b136f40be88c11a45fd4454296d1b3a7b0b6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"89082328344a56b86aaea52341da90da982b16b4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        echo_summary \"Installing Ironic\""},{"line_number":10,"context_line":"        install_ironic"},{"line_number":11,"context_line":"        install_ironicclient"},{"line_number":12,"context_line":"        cleanup_ironic"},{"line_number":13,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":14,"context_line":"        echo_summary \"Configuring Ironic\""},{"line_number":15,"context_line":"        configure_ironic"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7a740942_e442de3d","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":22},"updated":"2015-12-11 11:04:05.000000000","message":"Why do we need to call cleanup function here?","commit_id":"a0dcef410e3a415c880e67d2d173a87f10110e10"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c17aad4d7610a17a0a2dcd38f28fe4dbd833ed6c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        echo_summary \"Installing Ironic\""},{"line_number":10,"context_line":"        install_ironic"},{"line_number":11,"context_line":"        install_ironicclient"},{"line_number":12,"context_line":"        cleanup_ironic"},{"line_number":13,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":14,"context_line":"        echo_summary \"Configuring Ironic\""},{"line_number":15,"context_line":"        configure_ironic"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7a740942_ed97218e","line":12,"in_reply_to":"7a740942_e442de3d","updated":"2015-12-11 12:00:20.000000000","message":"I think it\u0027s supposed to be called before configure_ironic to ensure we\u0027re starting from scratch. to avoid confusion I\u0027d move it before all installs, but it can be done in a separate patch","commit_id":"a0dcef410e3a415c880e67d2d173a87f10110e10"}],"devstack/settings":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cce096a2170ad6c0614abd3c1776c3cab49d7f78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"enable_service ironic"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7a740942_06a2c74b","line":1,"updated":"2015-12-10 14:09:47.000000000","message":"I suspect you have to put all the ir-* stuff here as well. at least that\u0027s how I understood the documentation.","commit_id":"5a49b136f40be88c11a45fd4454296d1b3a7b0b6"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"61bf47eae31fdcb06885bf5ff8706fe28af7bfde","unresolved":false,"context_lines":[{"line_number":1,"context_line":"enable_service ironic"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7a740942_5cbd02d6","line":1,"in_reply_to":"7a740942_06a2c74b","updated":"2015-12-10 14:28:53.000000000","message":"What ir-* stuff?","commit_id":"5a49b136f40be88c11a45fd4454296d1b3a7b0b6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"172c2730b40165d314e1c735856f3a55b0bd8510","unresolved":false,"context_lines":[{"line_number":1,"context_line":"enable_service ironic"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7a740942_bc3f4624","line":1,"in_reply_to":"7a740942_5cbd02d6","updated":"2015-12-10 14:30:38.000000000","message":"enable_service ironic ir-cond ir-api","commit_id":"5a49b136f40be88c11a45fd4454296d1b3a7b0b6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"11fbba0de52931af5ce46049944f4580b28a8534","unresolved":false,"context_lines":[{"line_number":1,"context_line":"enable_service ironic"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a740942_724b455a","line":1,"updated":"2015-12-10 14:51:47.000000000","message":"I suspect if you don\u0027t put ir-api and ir-cond here, run_service function might not work for them","commit_id":"76fbd9ba06c91bf0bdc26e3299cdbc9eba78233d"}]}