)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"dc18033979b1d887019f6d8542113bdcc8c3582b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"env varibales DIB_VARS"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7d373f17fe6bfea105e97b81d14e92fd44a42502"},{"line_number":15,"context_line":"Partial-bug: #1526403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"ba0121b8_856c65d1","line":15,"updated":"2016-03-30 17:47:53.000000000","message":"Maybe I\u0027m missing something, but after reading this bug I\u0027m not sure what this patch has to do with it.","commit_id":"c77818691dd59cdeadf565d5112089c3cc352371"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2da7a0d4cb2c0615a23b01a52906e7f59a66c285","unresolved":false,"context_lines":[{"line_number":12,"context_line":"env varibales DIB_VARS"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7d373f17fe6bfea105e97b81d14e92fd44a42502"},{"line_number":15,"context_line":"Partial-bug: #1526403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"ba0121b8_b9724d0f","line":15,"in_reply_to":"ba0121b8_856c65d1","updated":"2016-03-31 12:42:13.000000000","message":"This is long story... When I started working on multitenancy patches I created this commit in order to test them at real hardware. Probably at the moment this patch is not so related to ironic-multitenancy but it is desirable. Do you think we should remove it from the multitenancy chain?","commit_id":"c77818691dd59cdeadf565d5112089c3cc352371"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"cd6202ce8276c677614b857bc19d5dc10aee2cb0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch allows to build user image with disk-image-builder"},{"line_number":10,"context_line":"by setting IRONIC_BUILD_USER_IMAGE\u003dTrue. Also it is possible"},{"line_number":11,"context_line":"to pass additional options via DISK_IMAGE_BUILDER_OPTS and set"},{"line_number":12,"context_line":"env varibales DIB_VARS"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7d373f17fe6bfea105e97b81d14e92fd44a42502"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":58,"id":"1a122d0e_e3e07028","line":12,"updated":"2016-04-28 15:17:53.000000000","message":"Typo: \"variables\", and I think you want a \"via\" after it.","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"}],"devstack/doc/source/guides/ironic-options.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5406efdc4e5a4e7f09c14c96afd6d950af852b84","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Ironic and DevStack"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a7b0d38_e006951f","line":1,"updated":"2015-12-23 18:09:08.000000000","message":"I think this file should be added to some of the other pages, otherwise how the user will see it?","commit_id":"b56ad88e9d6fcc6a8dffa21f7989c8a3ae13d9e3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5406efdc4e5a4e7f09c14c96afd6d950af852b84","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"diskimage-builder is a flexible suite of components for building a wide-range"},{"line_number":16,"context_line":"of disk images, filesystem images and ramdisk images for use with OpenStack."},{"line_number":17,"context_line":"To build user image with DIB use IRONIC_BUILD_USER_IMAGE flag. To additional"},{"line_number":18,"context_line":"variables use DIB_VARS space separated list of variables. Additional options"},{"line_number":19,"context_line":"can be passed with DISK_IMAGE_BUILDER_OPTS space separated options list."},{"line_number":20,"context_line":"Image will be uploaded to glance with ir-user-$IRONIC_DEPLOY_DRIVER name."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a7b0d38_002de1a6","line":17,"updated":"2015-12-23 18:09:08.000000000","message":"To pass additional parameters to diskimage-builder...?","commit_id":"b56ad88e9d6fcc6a8dffa21f7989c8a3ae13d9e3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a7ab2a70ad19c5c152d2899d2440fb54a649f7ac","unresolved":false,"context_lines":[{"line_number":5,"context_line":"This is a guide to configuration parameters that devstack accepts regarding"},{"line_number":6,"context_line":"the Ironic service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"It is not yet a complete list, and only includes sections for Neutron"},{"line_number":9,"context_line":"integration and the use / enrollment of external hardware."},{"line_number":10,"context_line":"Other sections will be added later."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Build User Image with DIB"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da6ed579_c7f0ec00","line":9,"range":{"start_line":8,"start_character":62,"end_line":9,"end_character":57},"updated":"2016-01-14 04:54:50.000000000","message":"These are currently not present here, right?","commit_id":"11e3be9959e25a8ce39a27ab33bd078d801ef0f5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4015164b4ef4bf09dd4fd955a9df2791c0006f07","unresolved":false,"context_lines":[{"line_number":5,"context_line":"This is a guide to configuration parameters that devstack accepts regarding"},{"line_number":6,"context_line":"the Ironic service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"It is not yet a complete list, and only includes sections for Neutron"},{"line_number":9,"context_line":"integration and the use / enrollment of external hardware."},{"line_number":10,"context_line":"Other sections will be added later."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Build User Image with DIB"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a5ae5dd_45ad9499","line":9,"range":{"start_line":8,"start_character":62,"end_line":9,"end_character":57},"in_reply_to":"da6ed579_3cca374f","updated":"2016-02-08 09:37:40.000000000","message":"May be you can add this also in the next patch to avoid confusion.","commit_id":"11e3be9959e25a8ce39a27ab33bd078d801ef0f5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ddc687427ae27c9b4340d4287219ed4006deaec4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"This is a guide to configuration parameters that devstack accepts regarding"},{"line_number":6,"context_line":"the Ironic service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"It is not yet a complete list, and only includes sections for Neutron"},{"line_number":9,"context_line":"integration and the use / enrollment of external hardware."},{"line_number":10,"context_line":"Other sections will be added later."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Build User Image with DIB"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da6ed579_3cca374f","line":9,"range":{"start_line":8,"start_character":62,"end_line":9,"end_character":57},"in_reply_to":"da6ed579_c7f0ec00","updated":"2016-01-14 08:30:32.000000000","message":"It is added in next commit in the chain https://review.openstack.org/#/c/256364/10/devstack/doc/source/guides/ironic-options.rst","commit_id":"11e3be9959e25a8ce39a27ab33bd078d801ef0f5"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"bd6f5fe22783976e59c5ce02ed20f2a533ac0efb","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    IRONIC_BUILD_USER_IMAGE\u003dTrue"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    IRONIC_USER_IMAGE_BUILD_OPTS\u003d\"baremetal ubuntu vm\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    IRONIC_USER_IMAGE_NAME\u003d\"user-image-name\""}],"source_content_type":"text/x-rst","patch_set":36,"id":"dae33548_fd16674a","line":28,"range":{"start_line":28,"start_character":34,"end_line":28,"end_character":53},"updated":"2016-02-18 02:33:20.000000000","message":"concern: not sure if it works with both \u0027baremetal\u0027 and \u0027vm\u0027 elements, did you try and make sure it working with Ironic?\n\nHow about \"dhcp-all-interfaces grub2\" dib elements? I think these should be required by default for user images.","commit_id":"dec51a50bba0145cde137fb1025b0d73a21b3346"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f7b8030ee120a9c7b41910f2fa061149b2f3358f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Ironic and DevStack"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is a guide to configuration parameters that devstack accepts regarding"},{"line_number":6,"context_line":"the Ironic service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"It is not yet a complete list. Other sections will be added later."}],"source_content_type":"text/x-rst","patch_set":57,"id":"1a122d0e_e8ab961c","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":33},"updated":"2016-04-25 03:26:06.000000000","message":"nit: how about:  s/to configuration/to configure?","commit_id":"d47ad2765e4d3e56894b45c09c7c6b526369a0cd"},{"author":{"_account_id":7933,"name":"Philippe Godin","email":"godp1301@gmail.com","username":"godp1301"},"change_message_id":"3c0a7112ad9b00d5dfacd738ffc1057b3e61a73c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Ironic and DevStack"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is a guide to configuration parameters that devstack accepts regarding"},{"line_number":6,"context_line":"the Ironic service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"It is not yet a complete list. Other sections will be added later."}],"source_content_type":"text/x-rst","patch_set":57,"id":"1a122d0e_5eb81c2a","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":33},"in_reply_to":"1a122d0e_aa0ad21d","updated":"2016-04-28 13:44:00.000000000","message":"English isn\u0027t my native language either but how about: This guide describes the devstack configuration parameters in regards of the ironic service.","commit_id":"d47ad2765e4d3e56894b45c09c7c6b526369a0cd"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b561771b9bd99c675374ed23f9427ac98e8bb9af","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Ironic and DevStack"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This is a guide to configuration parameters that devstack accepts regarding"},{"line_number":6,"context_line":"the Ironic service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"It is not yet a complete list. Other sections will be added later."}],"source_content_type":"text/x-rst","patch_set":57,"id":"1a122d0e_aa0ad21d","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":33},"in_reply_to":"1a122d0e_e8ab961c","updated":"2016-04-28 11:47:01.000000000","message":"I think that \"This is a guide to configuration parameters ...\" is correct here. Native speakers please comment if it is wrong.","commit_id":"d47ad2765e4d3e56894b45c09c7c6b526369a0cd"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"cd6202ce8276c677614b857bc19d5dc10aee2cb0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Additional options can be passed with DISK_IMAGE_BUILDER_OPTS,"},{"line_number":17,"context_line":"space separated options list. Image will be uploaded to glance with"},{"line_number":18,"context_line":"IRONIC_USER_IMAGE_NAME. If it is not set default name will be used"},{"line_number":19,"context_line":"ir-user-$IRONIC_DEPLOY_DRIVER name."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":58,"id":"1a122d0e_43d2045d","line":19,"updated":"2016-04-28 15:17:53.000000000","message":"\"If the name is not set, \u0027ir-user-$IRONIC_DEPLOY_DRIVER\u0027 will be used by default.\"","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"}],"devstack/lib/ironic":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"948ece5df782ab7cb5f6a7572557f6c2b2fb4d01","unresolved":false,"context_lines":[{"line_number":869,"context_line":"        --container-format\u003dari \\"},{"line_number":870,"context_line":"        \u003c $IRONIC_DEPLOY_RAMDISK_PATH  | grep \u0027 id \u0027 | get_field 2)"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":"    if is_ironic_hardware \u0026\u0026 [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":873,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":874,"context_line":"        for var in $DIB_VARS; do"},{"line_number":875,"context_line":"            export $var"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"5a5ae5dd_d6b28e4b","line":872,"updated":"2016-02-08 14:48:26.000000000","message":"this isn\u0027t related to the deploy image -- please put in a separate function.\n\nalso, I don\u0027t understand what this has to do with the is_ironic_hardware variable -- I may just as well build the user-image for VMs","commit_id":"f81b841fd9b710961ae0c8c9f55e9e2877e58f27"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e70ec75691d25eb74c3df3d3650369fa79ca0da3","unresolved":false,"context_lines":[{"line_number":869,"context_line":"        --container-format\u003dari \\"},{"line_number":870,"context_line":"        \u003c $IRONIC_DEPLOY_RAMDISK_PATH  | grep \u0027 id \u0027 | get_field 2)"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":"    if is_ironic_hardware \u0026\u0026 [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":873,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":874,"context_line":"        for var in $DIB_VARS; do"},{"line_number":875,"context_line":"            export $var"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"5a5ae5dd_521c6069","line":872,"in_reply_to":"5a5ae5dd_d6b28e4b","updated":"2016-02-08 17:35:46.000000000","message":"you are right Devananda, moved it to separate function.","commit_id":"f81b841fd9b710961ae0c8c9f55e9e2877e58f27"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c202ac1981788b02145ec5ba4b7f136d12627849","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# Space separated list of options that will be passed to DIB command."},{"line_number":146,"context_line":"# Image will be uploaded to glance with ir-user-$IRONIC_DEPLOY_DRIVER name."},{"line_number":147,"context_line":"DISK_IMAGE_BUILDER_OPTS\u003d${DISK_IMAGE_BUILDER_OPTS:-\u0027baremetal ubuntu vm\u0027}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Space separated list of variables that will be passed to DIB."},{"line_number":150,"context_line":"# Example DIB_RELEASE\u003dtrusty"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_35d2c535","line":147,"updated":"2016-02-09 09:40:03.000000000","message":"lets call it something like IRONIC_USER_IMAGE_BUILD_OPTS. the way you call it now has high chances of overlapping with something else_","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"38b2de2a55216e91376b3115f74b91a62b44a073","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# Space separated list of options that will be passed to DIB command."},{"line_number":146,"context_line":"# Image will be uploaded to glance with ir-user-$IRONIC_DEPLOY_DRIVER name."},{"line_number":147,"context_line":"DISK_IMAGE_BUILDER_OPTS\u003d${DISK_IMAGE_BUILDER_OPTS:-\u0027baremetal ubuntu vm\u0027}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Space separated list of variables that will be passed to DIB."},{"line_number":150,"context_line":"# Example DIB_RELEASE\u003dtrusty"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_5ef755f5","line":147,"in_reply_to":"5a5ae5dd_35d2c535","updated":"2016-02-09 13:27:40.000000000","message":"Agreed, will update it in next patchset.","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c202ac1981788b02145ec5ba4b7f136d12627849","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Space separated list of variables that will be passed to DIB."},{"line_number":150,"context_line":"# Example DIB_RELEASE\u003dtrusty"},{"line_number":151,"context_line":"DIB_VARS\u003d${DIB_VARS:-\u0027\u0027}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":154,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_55d74123","line":151,"updated":"2016-02-09 09:40:03.000000000","message":"what\u0027s the point of this variable? why can\u0027t users just expoort DIB_RELEASE\u003dtrusty?","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"38b2de2a55216e91376b3115f74b91a62b44a073","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Space separated list of variables that will be passed to DIB."},{"line_number":150,"context_line":"# Example DIB_RELEASE\u003dtrusty"},{"line_number":151,"context_line":"DIB_VARS\u003d${DIB_VARS:-\u0027\u0027}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":154,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_beb8c92b","line":151,"in_reply_to":"5a5ae5dd_55d74123","updated":"2016-02-09 13:27:40.000000000","message":"There are other options that can be configured, I don\u0027t want to double code in devstack patches for them. For example: DIB_DISTRIBUTION_MIRROR DIB_DEBIAN_COMPONENTS DIB_LOCAL_CONFIG_USERNAME etc...","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a5a2eee799a5218dc01be163154622e2048482b","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Space separated list of variables that will be passed to DIB."},{"line_number":150,"context_line":"# Example DIB_RELEASE\u003dtrusty"},{"line_number":151,"context_line":"DIB_VARS\u003d${DIB_VARS:-\u0027\u0027}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":154,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_de16e5f0","line":151,"in_reply_to":"5a5ae5dd_beb8c92b","updated":"2016-02-09 13:28:41.000000000","message":"why do you need any code for them? users can just export these variables in their environment.","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4333e12dbaca7f5a490466a5a37b2b5ef9570bc8","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Space separated list of variables that will be passed to DIB."},{"line_number":150,"context_line":"# Example DIB_RELEASE\u003dtrusty"},{"line_number":151,"context_line":"DIB_VARS\u003d${DIB_VARS:-\u0027\u0027}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":154,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_120b117f","line":151,"in_reply_to":"5a5ae5dd_d2d019fa","updated":"2016-02-09 13:53:09.000000000","message":"then you need to take care of proper ordering. looks like more problems than benefits","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a7402e69895563724ee1407d8c9b3d091f6f80fb","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Space separated list of variables that will be passed to DIB."},{"line_number":150,"context_line":"# Example DIB_RELEASE\u003dtrusty"},{"line_number":151,"context_line":"DIB_VARS\u003d${DIB_VARS:-\u0027\u0027}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":154,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_d2d019fa","line":151,"in_reply_to":"5a5ae5dd_de16e5f0","updated":"2016-02-09 13:50:46.000000000","message":"what if user wants to build ramdisk and user image with different DIB options? https://review.openstack.org/#/c/264579/","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4333e12dbaca7f5a490466a5a37b2b5ef9570bc8","unresolved":false,"context_lines":[{"line_number":807,"context_line":"    if [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":808,"context_line":"    echo \"Building user image with DIB\""},{"line_number":809,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":810,"context_line":"        for var in $DIB_VARS; do"},{"line_number":811,"context_line":"            export $var"},{"line_number":812,"context_line":"        done"},{"line_number":813,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $DISK_IMAGE_BUILDER_OPTS"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_128231c9","line":810,"range":{"start_line":810,"start_character":8,"end_line":810,"end_character":30},"updated":"2016-02-09 13:53:09.000000000","message":"I think this won\u0027t work if any of values contain spaces, right? e.g\n\n DIB_VARS\u003d\"foo\u003d\u0027bar baz\u0027\"","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5494a53074618b976c1407c62b3fbcc9e5f60bd6","unresolved":false,"context_lines":[{"line_number":807,"context_line":"    if [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":808,"context_line":"    echo \"Building user image with DIB\""},{"line_number":809,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":810,"context_line":"        for var in $DIB_VARS; do"},{"line_number":811,"context_line":"            export $var"},{"line_number":812,"context_line":"        done"},{"line_number":813,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $DISK_IMAGE_BUILDER_OPTS"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_5573b3b4","line":810,"range":{"start_line":810,"start_character":8,"end_line":810,"end_character":30},"in_reply_to":"5a5ae5dd_128231c9","updated":"2016-02-09 22:10:04.000000000","message":"right, we can use \u0027;\u0027 separated list here. But agreed more problems than benefits.","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c202ac1981788b02145ec5ba4b7f136d12627849","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $DISK_IMAGE_BUILDER_OPTS"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        openstack --os-token $token --os-url http://$GLANCE_HOSTPORT image create \\"},{"line_number":816,"context_line":"            ir-user-$IRONIC_DEPLOY_DRIVER \\"},{"line_number":817,"context_line":"            --public --disk-format\u003dqcow2 \\"},{"line_number":818,"context_line":"            --container-format\u003dbare \\"},{"line_number":819,"context_line":"            --file $TOP_DIR/ir-user-${IRONIC_DEPLOY_DRIVER}.qcow2"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_f5dbcd4d","line":816,"updated":"2016-02-09 09:40:03.000000000","message":"I think this name should be configurable. also not sure why you include the deploy driver name, an instance image should not depend on a driver..","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3a5a2eee799a5218dc01be163154622e2048482b","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $DISK_IMAGE_BUILDER_OPTS"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        openstack --os-token $token --os-url http://$GLANCE_HOSTPORT image create \\"},{"line_number":816,"context_line":"            ir-user-$IRONIC_DEPLOY_DRIVER \\"},{"line_number":817,"context_line":"            --public --disk-format\u003dqcow2 \\"},{"line_number":818,"context_line":"            --container-format\u003dbare \\"},{"line_number":819,"context_line":"            --file $TOP_DIR/ir-user-${IRONIC_DEPLOY_DRIVER}.qcow2"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_5ee195fd","line":816,"in_reply_to":"5a5ae5dd_5e5c35ed","updated":"2016-02-09 13:28:41.000000000","message":"+1","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"38b2de2a55216e91376b3115f74b91a62b44a073","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $DISK_IMAGE_BUILDER_OPTS"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        openstack --os-token $token --os-url http://$GLANCE_HOSTPORT image create \\"},{"line_number":816,"context_line":"            ir-user-$IRONIC_DEPLOY_DRIVER \\"},{"line_number":817,"context_line":"            --public --disk-format\u003dqcow2 \\"},{"line_number":818,"context_line":"            --container-format\u003dbare \\"},{"line_number":819,"context_line":"            --file $TOP_DIR/ir-user-${IRONIC_DEPLOY_DRIVER}.qcow2"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_5e5c35ed","line":816,"in_reply_to":"5a5ae5dd_f5dbcd4d","updated":"2016-02-09 13:27:40.000000000","message":"What do you think about IRONIC_USER_IMAGE_NAME variable?","commit_id":"fd11b084eddef4788cd4f11f707f4a618efcaa5b"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"3b14ed055ce9c9a0e43e42f32f2b88cc3aaa373a","unresolved":false,"context_lines":[{"line_number":822,"context_line":""},{"line_number":823,"context_line":"function build_dib_user_image {"},{"line_number":824,"context_line":"    if [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":825,"context_line":"    echo \"Building user image with DIB\""},{"line_number":826,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":827,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $IRONIC_USER_IMAGE_BUILD_OPTS"},{"line_number":828,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"3a57f1b5_0b8ee1cf","line":825,"range":{"start_line":825,"start_character":4,"end_line":825,"end_character":39},"updated":"2016-02-12 19:39:34.000000000","message":"should we indent this line for readability?","commit_id":"bbffce1d30cdde73519d0494a10120e72d6292a4"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"3b14ed055ce9c9a0e43e42f32f2b88cc3aaa373a","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    if [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":825,"context_line":"    echo \"Building user image with DIB\""},{"line_number":826,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":827,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $IRONIC_USER_IMAGE_BUILD_OPTS"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        openstack --os-token $token --os-url http://$GLANCE_HOSTPORT image create \\"},{"line_number":830,"context_line":"            $IRONIC_USER_IMAGE_NAME \\"}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"3a57f1b5_abf1cd6c","line":827,"range":{"start_line":827,"start_character":67,"end_line":827,"end_character":69},"updated":"2016-02-12 19:39:34.000000000","message":"nit: two spaces here.","commit_id":"bbffce1d30cdde73519d0494a10120e72d6292a4"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"bd6f5fe22783976e59c5ce02ed20f2a533ac0efb","unresolved":false,"context_lines":[{"line_number":142,"context_line":"# The path to the libvirt hooks directory, used if IRONIC_VM_LOG_ROTATE is True"},{"line_number":143,"context_line":"IRONIC_LIBVIRT_HOOKS_PATH\u003d${IRONIC_LIBVIRT_HOOKS_PATH:-/etc/libvirt/hooks/}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# This flag is uses to build user image with disk-image-builder"},{"line_number":146,"context_line":"# disk-image-builder options can be set via DISK_IMAGE_BUILDER_OPTS"},{"line_number":147,"context_line":"IRONIC_BUILD_USER_IMAGE\u003d$(trueorfalse False IRONIC_BUILD_USER_IMAGE)"},{"line_number":148,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"dae33548_3de72f41","line":145,"range":{"start_line":145,"start_character":15,"end_line":145,"end_character":19},"updated":"2016-02-18 02:33:20.000000000","message":"s/uses/used?","commit_id":"dec51a50bba0145cde137fb1025b0d73a21b3346"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"bd6f5fe22783976e59c5ce02ed20f2a533ac0efb","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Space separated list of options that will be passed to DIB command."},{"line_number":150,"context_line":"# Image will be uploaded to glance with ir-user-$IRONIC_DEPLOY_DRIVER name."},{"line_number":151,"context_line":"IRONIC_USER_IMAGE_BUILD_OPTS\u003d${IRONIC_USER_IMAGE_BUILD_OPTS:-\u0027baremetal ubuntu vm\u0027}"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Ironic user image name, if is not set ir-user-$IRONIC_DEPLOY_DRIVER is used."},{"line_number":154,"context_line":"IRONIC_USER_IMAGE_NAME\u003d${IRONIC_USER_IMAGE_NAME:-ir-user-$IRONIC_DEPLOY_DRIVER}"}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"dae33548_fd6b07b5","line":151,"range":{"start_line":151,"start_character":62,"end_line":151,"end_character":81},"updated":"2016-02-18 02:33:20.000000000","message":"concern: not sure if it works with both \u0027baremetal\u0027 and \u0027vm\u0027 elements, did you try and make sure it working?\n\nHow about \"dhcp-all-interfaces grub2\" dib elements? I think these should be required by default for user images.","commit_id":"dec51a50bba0145cde137fb1025b0d73a21b3346"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"f7b8030ee120a9c7b41910f2fa061149b2f3358f","unresolved":false,"context_lines":[{"line_number":198,"context_line":"IRONIC_TERMINAL_SSL\u003d$(trueorfalse False IRONIC_TERMINAL_SSL)"},{"line_number":199,"context_line":"IRONIC_TERMINAL_CERT_DIR\u003d${IRONIC_TERMINAL_CERT_DIR:-$IRONIC_DATA_DIR/terminal_cert/}"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# This flag is uses to build user image with disk-image-builder"},{"line_number":202,"context_line":"# disk-image-builder options can be set via DISK_IMAGE_BUILDER_OPTS"},{"line_number":203,"context_line":"IRONIC_BUILD_USER_IMAGE\u003d$(trueorfalse False IRONIC_BUILD_USER_IMAGE)"},{"line_number":204,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":57,"id":"1a122d0e_884ae281","line":201,"range":{"start_line":201,"start_character":15,"end_line":201,"end_character":19},"updated":"2016-04-25 03:26:06.000000000","message":"nit: s/uses/used?","commit_id":"d47ad2765e4d3e56894b45c09c7c6b526369a0cd"},{"author":{"_account_id":7933,"name":"Philippe Godin","email":"godp1301@gmail.com","username":"godp1301"},"change_message_id":"3c0a7112ad9b00d5dfacd738ffc1057b3e61a73c","unresolved":false,"context_lines":[{"line_number":198,"context_line":"IRONIC_TERMINAL_SSL\u003d$(trueorfalse False IRONIC_TERMINAL_SSL)"},{"line_number":199,"context_line":"IRONIC_TERMINAL_CERT_DIR\u003d${IRONIC_TERMINAL_CERT_DIR:-$IRONIC_DATA_DIR/terminal_cert/}"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# This flag is uses to build user image with disk-image-builder"},{"line_number":202,"context_line":"# disk-image-builder options can be set via DISK_IMAGE_BUILDER_OPTS"},{"line_number":203,"context_line":"IRONIC_BUILD_USER_IMAGE\u003d$(trueorfalse False IRONIC_BUILD_USER_IMAGE)"},{"line_number":204,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":57,"id":"1a122d0e_be7df06e","line":201,"range":{"start_line":201,"start_character":15,"end_line":201,"end_character":19},"in_reply_to":"1a122d0e_884ae281","updated":"2016-04-28 13:44:00.000000000","message":"+1","commit_id":"d47ad2765e4d3e56894b45c09c7c6b526369a0cd"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"cd6202ce8276c677614b857bc19d5dc10aee2cb0","unresolved":false,"context_lines":[{"line_number":203,"context_line":"IRONIC_BUILD_USER_IMAGE\u003d$(trueorfalse False IRONIC_BUILD_USER_IMAGE)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"# Space separated list of options that will be passed to DIB command."},{"line_number":206,"context_line":"# Image will be uploaded to glance with ir-user-$IRONIC_DEPLOY_DRIVER name."},{"line_number":207,"context_line":"IRONIC_USER_IMAGE_BUILD_OPTS\u003d${IRONIC_USER_IMAGE_BUILD_OPTS:-\u0027baremetal ubuntu vm\u0027}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Ironic user image name, if is not set ir-user-$IRONIC_DEPLOY_DRIVER is used."}],"source_content_type":"application/x-shellscript","patch_set":58,"id":"1a122d0e_23d54842","line":206,"updated":"2016-04-28 15:17:53.000000000","message":"Delete this line - it duplicates information that belongs below.","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"cd6202ce8276c677614b857bc19d5dc10aee2cb0","unresolved":false,"context_lines":[{"line_number":206,"context_line":"# Image will be uploaded to glance with ir-user-$IRONIC_DEPLOY_DRIVER name."},{"line_number":207,"context_line":"IRONIC_USER_IMAGE_BUILD_OPTS\u003d${IRONIC_USER_IMAGE_BUILD_OPTS:-\u0027baremetal ubuntu vm\u0027}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Ironic user image name, if is not set ir-user-$IRONIC_DEPLOY_DRIVER is used."},{"line_number":210,"context_line":"IRONIC_USER_IMAGE_NAME\u003d${IRONIC_USER_IMAGE_NAME:-ir-user-$IRONIC_DEPLOY_DRIVER}"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"}],"source_content_type":"application/x-shellscript","patch_set":58,"id":"1a122d0e_83c89ca9","line":209,"updated":"2016-04-28 15:17:53.000000000","message":"\"Image name used in Glance\", maybe?","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e470279feac65207514b9b7a0ab817e44b06db4f","unresolved":false,"context_lines":[{"line_number":989,"context_line":"}"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"function build_dib_user_image {"},{"line_number":992,"context_line":"    if [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":993,"context_line":"    echo \"Building user image with DIB\""},{"line_number":994,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":995,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $IRONIC_USER_IMAGE_BUILD_OPTS"}],"source_content_type":"application/x-shellscript","patch_set":58,"id":"1a122d0e_2f8b1020","line":992,"updated":"2016-05-03 01:29:10.000000000","message":"please remove the if from inside the function, because building the image is the whole point of the function...","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"01967e9c0f968985151d7ab1b493795862b94d28","unresolved":false,"context_lines":[{"line_number":989,"context_line":"}"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"function build_dib_user_image {"},{"line_number":992,"context_line":"    if [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":993,"context_line":"    echo \"Building user image with DIB\""},{"line_number":994,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":995,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $IRONIC_USER_IMAGE_BUILD_OPTS"}],"source_content_type":"application/x-shellscript","patch_set":58,"id":"7aa08908_14a9b17b","line":992,"in_reply_to":"1a122d0e_2f8b1020","updated":"2016-06-07 18:07:21.000000000","message":"+1","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"cd6202ce8276c677614b857bc19d5dc10aee2cb0","unresolved":false,"context_lines":[{"line_number":990,"context_line":""},{"line_number":991,"context_line":"function build_dib_user_image {"},{"line_number":992,"context_line":"    if [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":993,"context_line":"    echo \"Building user image with DIB\""},{"line_number":994,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":995,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $IRONIC_USER_IMAGE_BUILD_OPTS"},{"line_number":996,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":58,"id":"1a122d0e_63cbc0a4","line":993,"updated":"2016-04-28 15:17:53.000000000","message":"Indent this line one step further.","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"01967e9c0f968985151d7ab1b493795862b94d28","unresolved":false,"context_lines":[{"line_number":992,"context_line":"    if [[ \"$IRONIC_BUILD_USER_IMAGE\" \u003d\u003d \"True\" ]]; then"},{"line_number":993,"context_line":"    echo \"Building user image with DIB\""},{"line_number":994,"context_line":"        pip_install_gr \"diskimage-builder\""},{"line_number":995,"context_line":"        disk-image-create -o $TOP_DIR/ir-user-$IRONIC_DEPLOY_DRIVER  $IRONIC_USER_IMAGE_BUILD_OPTS"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        openstack --os-token $token --os-url http://$GLANCE_HOSTPORT image create \\"},{"line_number":998,"context_line":"            $IRONIC_USER_IMAGE_NAME \\"}],"source_content_type":"application/x-shellscript","patch_set":58,"id":"7aa08908_d4a28998","line":995,"range":{"start_line":995,"start_character":29,"end_line":995,"end_character":67},"updated":"2016-06-07 18:07:21.000000000","message":"Why not group all image files together? just like other image files does -- $TOP_DIR/files/...?","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"e470279feac65207514b9b7a0ab817e44b06db4f","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"        configure_ironic_auxiliary"},{"line_number":1080,"context_line":"    fi"},{"line_number":1081,"context_line":"    upload_baremetal_ironic_deploy"},{"line_number":1082,"context_line":"    build_dib_user_image"},{"line_number":1083,"context_line":"    if [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"False\" ]]; then"},{"line_number":1084,"context_line":"        create_bridge_and_vms"},{"line_number":1085,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":58,"id":"1a122d0e_8f8064f9","line":1082,"updated":"2016-05-03 01:29:10.000000000","message":"... and wrap the function call in an if statement instead","commit_id":"6a498a6172afed5ce0b960b61f804282ea824e76"}],"doc/source/dev/devstack-ironic-options.rst":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a72acc08ec1bea8c1a9c822ede24b48a5bd639e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _devstack ironic options:"},{"line_number":2,"context_line":".. include:: ../../../devstack/doc/source/guides/ironic-options.rst"}],"source_content_type":"text/x-rst","patch_set":39,"id":"1af94dfe_a9ad748a","line":2,"range":{"start_line":2,"start_character":49,"end_line":2,"end_character":63},"updated":"2016-03-15 15:34:22.000000000","message":"let\u0027s call it devstack-ironic-options.rst because that file is specific for devstack right?","commit_id":"68dc75d54340132c1025d0e4f78daa74fa7021a9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dcc4c09b8aca048db80691278e54300dd82761b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _devstack ironic options:"},{"line_number":2,"context_line":".. include:: ../../../devstack/doc/source/guides/ironic-options.rst"}],"source_content_type":"text/x-rst","patch_set":39,"id":"1af94dfe_69bfbed0","line":2,"range":{"start_line":2,"start_character":49,"end_line":2,"end_character":63},"in_reply_to":"1af94dfe_9cf9cf50","updated":"2016-03-16 10:24:20.000000000","message":"Oh right, I see devstack in the path there. Agreed, please ignore my comment.","commit_id":"68dc75d54340132c1025d0e4f78daa74fa7021a9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"47bdd1942a752171a999add25010e612ac02585f","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _devstack ironic options:"},{"line_number":2,"context_line":".. include:: ../../../devstack/doc/source/guides/ironic-options.rst"}],"source_content_type":"text/x-rst","patch_set":39,"id":"1af94dfe_9cf9cf50","line":2,"range":{"start_line":2,"start_character":49,"end_line":2,"end_character":63},"in_reply_to":"1af94dfe_a9ad748a","updated":"2016-03-15 16:41:12.000000000","message":"I already thought about it and decided to use ironic-options.rst since this file is in devstack folder so it should be devstack related options.","commit_id":"68dc75d54340132c1025d0e4f78daa74fa7021a9"}]}
