)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"28633c5d5bf85737e9752f2bb0158c16e37f0550","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I52a69ad3bc8fc528e7f20e6b03a98f327acaaa74"},{"line_number":12,"context_line":"Change-Id: I7938f26015d953efdf720774b5ad2cee4068ac90"},{"line_number":13,"context_line":"Partial-bug: #1526403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":54,"id":"ba0121b8_b68cf6da","line":13,"updated":"2016-03-31 23:31:13.000000000","message":"That bug doesn\u0027t reference anything this patch is about.","commit_id":"d0078dcaa801f0941fb4939ea29679c48abd4ef4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d6a0574b941583fb2b05d6ed406b15224c6f1ef1","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I52a69ad3bc8fc528e7f20e6b03a98f327acaaa74"},{"line_number":12,"context_line":"Change-Id: I7938f26015d953efdf720774b5ad2cee4068ac90"},{"line_number":13,"context_line":"Partial-bug: #1526403"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":54,"id":"ba0121b8_13595f35","line":13,"in_reply_to":"ba0121b8_b68cf6da","updated":"2016-04-01 12:49:48.000000000","message":"It is related. This refactoring is needed in order to add additional attributes to ironic node.","commit_id":"d0078dcaa801f0941fb4939ea29679c48abd4ef4"}],"devstack/doc/source/guides/ironic-options.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fa23cbac69e6684d6850a54ebf3eecfd94b0fbdf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"if the IRONIC_HW_NODES_FILE variable is set and refers to a valid"},{"line_number":37,"context_line":"INI-formatted file. In this file, each section represents an Ironic Node,"},{"line_number":38,"context_line":"and options in that section define the properties of that Node."},{"line_number":39,"context_line":"Here is an example:"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"::"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a7b0d38_b4d8cb54","line":39,"updated":"2015-12-23 20:09:18.000000000","message":"Apart from that, worth mentioning which drivers are supported (the ones that use IPMI or SSH power and management I beleive) and the list of options that is going to be parsed in each case.","commit_id":"47cd3c617c9d0d75b9755aadd5c7374eb4cb985b"},{"author":{"_account_id":20863,"name":"Sharat Sharma","email":"sharat.sharma@in.ibm.com","username":"sharat.sharma"},"change_message_id":"8dec32412f63c2c9c53cf6ae63cb12d91ab770de","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Hardware node registration in Ironic"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Hardware nodes can be automatically enrolled in Ironic during devstack setup,"},{"line_number":37,"context_line":"if the IRONIC_IPMI_NODES_FILE variable is set and refers to a valid"},{"line_number":38,"context_line":"INI-formatted file. In this file, each section represents an Ironic Node,"},{"line_number":39,"context_line":"and options in that section define the properties of that Node."}],"source_content_type":"text/x-rst","patch_set":55,"id":"ba0121b8_5211185c","line":36,"range":{"start_line":36,"start_character":76,"end_line":36,"end_character":77},"updated":"2016-04-01 09:05:41.000000000","message":"remove comma","commit_id":"34c361e6ec5e12efdb26d9997fa686f07a6d594f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"be85d67e8ba13738b5871bea5b7d8ed0665f76e5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Hardware node registration in Ironic"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Hardware nodes can be automatically enrolled in Ironic during devstack setup,"},{"line_number":37,"context_line":"if the IRONIC_IPMI_NODES_FILE variable is set and refers to a valid"},{"line_number":38,"context_line":"INI-formatted file. In this file, each section represents an Ironic Node,"},{"line_number":39,"context_line":"and options in that section define the properties of that Node."}],"source_content_type":"text/x-rst","patch_set":55,"id":"ba0121b8_b3b8732b","line":36,"range":{"start_line":36,"start_character":76,"end_line":36,"end_character":77},"in_reply_to":"ba0121b8_5211185c","updated":"2016-04-01 12:49:57.000000000","message":"Done","commit_id":"34c361e6ec5e12efdb26d9997fa686f07a6d594f"},{"author":{"_account_id":6287,"name":"David Lenwell","email":"dlenwell@gmail.com","username":"dlenwell"},"change_message_id":"7a6aeb3f122395818cdc31b4b651745944be8457","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Hardware nodes can be automatically enrolled in Ironic during devstack setup"},{"line_number":37,"context_line":"if the IRONIC_IPMI_NODES_FILE variable is set and refers to a valid"},{"line_number":38,"context_line":"INI-formatted file. In this file, each section represents an Ironic Node,"},{"line_number":39,"context_line":"and options in that section define the properties of that Node."},{"line_number":40,"context_line":"Here is an example:"}],"source_content_type":"text/x-rst","patch_set":60,"id":"5a18252c_f2ca8619","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":24},"updated":"2016-04-13 06:56:05.000000000","message":"The name of this property makes me think that enrollment is driver dependent and only works with ipmi nodes.. Why wouldn\u0027t this be IRONIC_NODES and then have driver\u003d in the property for each node defined. That way one could import amt nodes or whatever driver for mix and matched hardware one has in ones lab. Or am I missing something and you\u0027d define a different file for each driver?\nplease pardon me if I missed this in discussion in an earlier revision.","commit_id":"45c01a26e5a770524b215ed5d3bdd1b263b68ccd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"28a3e58d74a1567b71d23ff20a52108c83eee57a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Ironic and DevStack"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":64,"id":"bab6814e_82e1ca2c","line":1,"updated":"2016-05-26 11:54:21.000000000","message":"You need to reference this file somewhere in doc tree.","commit_id":"0557789f842e46df300d14911c84db68827a28a6"}],"devstack/lib/ironic":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1f38517f8803daaea965442cbd8491c1fef4ffeb","unresolved":false,"context_lines":[{"line_number":637,"context_line":"    if ! is_ironic_hardware; then"},{"line_number":638,"context_line":"        local ironic_nodes_file\u003d$IRONIC_VM_NODES_FILE"},{"line_number":639,"context_line":"    else"},{"line_number":640,"context_line":"        local ironic_nodes_file\u003d$IRONIC_IPMI_NODES_FILE"},{"line_number":641,"context_line":"    fi"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    local total_nodes\u003d0"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1a7b0d38_63414f0b","line":640,"updated":"2015-12-23 18:16:41.000000000","message":"Is there a need for 2 different variables for nodes file? You have an if on l665 anyway.","commit_id":"47cd3c617c9d0d75b9755aadd5c7374eb4cb985b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"219bb6a63955a5c876cb7b236dca4e80f12be0e2","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        min_memory_mb\u003d$(( $memory_mb \u003c ${min_memory_mb:\u003d$memory_mb} ? $memory_mb : $min_memory_mb ))"},{"line_number":754,"context_line":"        min_cpus\u003d$(( $cpus \u003c ${min_cpus:\u003d$cpus} ? $cpus : $min_cpus ))"},{"line_number":755,"context_line":"        min_adjusted_disk\u003d$(($local_gb \u003c ${min_adjusted_disk:\u003d$local_gb} ? $local_gb : $min_adjusted_disk ))"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        total_nodes\u003d$((total_nodes+1))"},{"line_number":758,"context_line":"        total_cpus\u003d$((total_cpus+$cpus))"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_f65c6a4c","line":755,"range":{"start_line":755,"start_character":8,"end_line":755,"end_character":108},"updated":"2016-02-08 14:58:32.000000000","message":"what is this change expected to do? judging by the gate run it sets min_adjusted_disk to 10 while it used to (and should) set it to 9.","commit_id":"c067585249be0c657e235f58a8ffe80b64975790"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"afeb67beab8b7f3f0f33e9381c088255d6390c68","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        min_memory_mb\u003d$(( $memory_mb \u003c ${min_memory_mb:\u003d$memory_mb} ? $memory_mb : $min_memory_mb ))"},{"line_number":754,"context_line":"        min_cpus\u003d$(( $cpus \u003c ${min_cpus:\u003d$cpus} ? $cpus : $min_cpus ))"},{"line_number":755,"context_line":"        min_adjusted_disk\u003d$(($local_gb \u003c ${min_adjusted_disk:\u003d$local_gb} ? $local_gb : $min_adjusted_disk ))"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        total_nodes\u003d$((total_nodes+1))"},{"line_number":758,"context_line":"        total_cpus\u003d$((total_cpus+$cpus))"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"5a5ae5dd_63b8b52a","line":755,"range":{"start_line":755,"start_character":8,"end_line":755,"end_character":108},"in_reply_to":"5a5ae5dd_f65c6a4c","updated":"2016-02-08 15:53:16.000000000","message":"It should be 9 GB. And it looks like I did a mistake in the script. It should look like:\n\nmin_adjusted_disk\u003d$(($adjusted_disk \u003c ${min_adjusted_disk:\u003d$adjusted_disk} ? $adjusted_disk : $min_adjusted_disk ))\n\nDmitry thank for nice catch! I fill fix it.","commit_id":"c067585249be0c657e235f58a8ffe80b64975790"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b6cc414e847b04b1d7782952a87b1b1f00f46465","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#mac_address\u003d0c:c4:7a:51:e6:c0"},{"line_number":62,"context_line":"#cpus\u003d4"},{"line_number":63,"context_line":"IRONIC_IPMI_NODES_FILE\u003d${IRONIC_IPMI_NODES_FILE:-$IRONIC_DATA_DIR/ironic_ipmi_nodes}"},{"line_number":64,"context_line":"IRONIC_VM_NODES_FILE\u003d${IRONIC_VM_NODES_FILE:-$IRONIC_DATA_DIR/ironic_vm_nodes}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Set up defaults for functional / integration testing"},{"line_number":67,"context_line":"IRONIC_NODE_UUID\u003d${IRONIC_NODE_UUID:-`uuidgen`}"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"3a57f1b5_d5565429","line":64,"updated":"2016-02-12 00:59:53.000000000","message":"Where does the default file come from? Does this just work because we use the defaults if this file doesn\u0027t exist?","commit_id":"d361c6f11a06cba6068ded8089c72c11df39038a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"130500f0a85c672450ecb2b7daff5332072edd31","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#mac_address\u003d0c:c4:7a:51:e6:c0"},{"line_number":62,"context_line":"#cpus\u003d4"},{"line_number":63,"context_line":"IRONIC_IPMI_NODES_FILE\u003d${IRONIC_IPMI_NODES_FILE:-$IRONIC_DATA_DIR/ironic_ipmi_nodes}"},{"line_number":64,"context_line":"IRONIC_VM_NODES_FILE\u003d${IRONIC_VM_NODES_FILE:-$IRONIC_DATA_DIR/ironic_vm_nodes}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Set up defaults for functional / integration testing"},{"line_number":67,"context_line":"IRONIC_NODE_UUID\u003d${IRONIC_NODE_UUID:-`uuidgen`}"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"3a57f1b5_60a32001","line":64,"in_reply_to":"3a57f1b5_d5565429","updated":"2016-02-12 01:02:13.000000000","message":"Never mind, I see it\u0027s built in create-node.sh.","commit_id":"d361c6f11a06cba6068ded8089c72c11df39038a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b6cc414e847b04b1d7782952a87b1b1f00f46465","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        total_cpus\u003d$((total_cpus+$cpus))"},{"line_number":762,"context_line":"    done"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    nova flavor-create --ephemeral $ephemeral_disk baremetal auto $min_memory_mb $min_adjusted_disk $min_cpus"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"    nova flavor-key baremetal set \"cpu_arch\"\u003d\"$cpu_arch\""},{"line_number":767,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"3a57f1b5_158cecd8","line":764,"updated":"2016-02-12 00:59:53.000000000","message":"I worry about this combined with the use of ExactRAMFilter, etc.","commit_id":"d361c6f11a06cba6068ded8089c72c11df39038a"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"479400d8edccc248c386db1ff284261936ab6e95","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        if [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"False\" ]]; then"},{"line_number":745,"context_line":"            if is_deployed_by_ipmitool; then"},{"line_number":746,"context_line":"                local vbmc_port"},{"line_number":747,"context_line":"                vbmc_port\u003d$(iniget $ironic_nodes_file $node_name vbmc_port)"},{"line_number":748,"context_line":"                local node_options\u003d\"\\"},{"line_number":749,"context_line":"                    -i ipmi_address\u003d127.0.0.1 \\"},{"line_number":750,"context_line":"                    -i ipmi_username\u003dadmin \\"}],"source_content_type":"application/x-shellscript","patch_set":42,"id":"1af94dfe_3fc5cd8d","line":747,"range":{"start_line":747,"start_character":16,"end_line":747,"end_character":75},"updated":"2016-03-16 17:40:46.000000000","message":"might be worth adding a default to 623 here, especially as this option is not included in the example.","commit_id":"1a33acf0159ed14792e9636668b12b4ab6af584d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5d9383ff083e6088e1fc418055aec0911b931bd9","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    die_if_not_set $LINENO chassis_id \"Failed to create chassis\""},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    if [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"False\" ]]; then"},{"line_number":689,"context_line":"        local ironic_node_cpu\u003d$IRONIC_VM_SPECS_CPU"},{"line_number":690,"context_line":"        local ironic_node_ram\u003d$IRONIC_VM_SPECS_RAM"},{"line_number":691,"context_line":"        local ironic_node_disk\u003d$IRONIC_VM_SPECS_DISK"},{"line_number":692,"context_line":"        local ironic_ephemeral_disk\u003d$IRONIC_VM_EPHEMERAL_DISK"}],"source_content_type":"application/x-shellscript","patch_set":44,"id":"fa0719c6_e1c9ca5a","line":689,"updated":"2016-03-23 12:12:10.000000000","message":"Seems that this section should be removed now?","commit_id":"fca53a84d347764fdbdd3c5e93511789a010d4e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8ee98b8bfd73a8f77e53c2f1d89ea9196f9d978f","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    die_if_not_set $LINENO chassis_id \"Failed to create chassis\""},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    if [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"False\" ]]; then"},{"line_number":689,"context_line":"        local ironic_node_cpu\u003d$IRONIC_VM_SPECS_CPU"},{"line_number":690,"context_line":"        local ironic_node_ram\u003d$IRONIC_VM_SPECS_RAM"},{"line_number":691,"context_line":"        local ironic_node_disk\u003d$IRONIC_VM_SPECS_DISK"},{"line_number":692,"context_line":"        local ironic_ephemeral_disk\u003d$IRONIC_VM_EPHEMERAL_DISK"}],"source_content_type":"application/x-shellscript","patch_set":44,"id":"fa0719c6_11e7a540","line":689,"in_reply_to":"fa0719c6_e1c9ca5a","updated":"2016-03-24 14:57:42.000000000","message":"Right, it is not needed anymore, I\u0027ve missed it during rebase.","commit_id":"fca53a84d347764fdbdd3c5e93511789a010d4e5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5d9383ff083e6088e1fc418055aec0911b931bd9","unresolved":false,"context_lines":[{"line_number":753,"context_line":"                    -i ipmi_address\u003d127.0.0.1 \\"},{"line_number":754,"context_line":"                    -i ipmi_username\u003dadmin \\"},{"line_number":755,"context_line":"                    -i ipmi_password\u003dpassword"},{"line_number":756,"context_line":"                    -i ipmit_port\u003d$vbmc_port"},{"line_number":757,"context_line":"                    \""},{"line_number":758,"context_line":"            else"},{"line_number":759,"context_line":"                local ssh_virt_type"}],"source_content_type":"application/x-shellscript","patch_set":44,"id":"fa0719c6_e1da6ae7","line":756,"updated":"2016-03-23 12:12:10.000000000","message":"ipmit_port is wrong - seems that ipmitool jobs fail because of it.","commit_id":"fca53a84d347764fdbdd3c5e93511789a010d4e5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8ee98b8bfd73a8f77e53c2f1d89ea9196f9d978f","unresolved":false,"context_lines":[{"line_number":753,"context_line":"                    -i ipmi_address\u003d127.0.0.1 \\"},{"line_number":754,"context_line":"                    -i ipmi_username\u003dadmin \\"},{"line_number":755,"context_line":"                    -i ipmi_password\u003dpassword"},{"line_number":756,"context_line":"                    -i ipmit_port\u003d$vbmc_port"},{"line_number":757,"context_line":"                    \""},{"line_number":758,"context_line":"            else"},{"line_number":759,"context_line":"                local ssh_virt_type"}],"source_content_type":"application/x-shellscript","patch_set":44,"id":"fa0719c6_7684170a","line":756,"in_reply_to":"fa0719c6_e1da6ae7","updated":"2016-03-24 14:57:42.000000000","message":"Done","commit_id":"fca53a84d347764fdbdd3c5e93511789a010d4e5"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"0f7481f6c9eb9f0d29f09e95f78c67e036bd606b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#cpus\u003d4"},{"line_number":63,"context_line":"IRONIC_IPMI_NODES_FILE\u003d${IRONIC_IPMI_NODES_FILE:-$IRONIC_DATA_DIR/ironic_ipmi_nodes}"},{"line_number":64,"context_line":"IRONIC_VM_NODES_FILE\u003d${IRONIC_VM_NODES_FILE:-$IRONIC_DATA_DIR/ironic_vm_nodes}"},{"line_number":65,"context_line":"# CSV file is going to be deprecated in N relase."},{"line_number":66,"context_line":"# Use IRONIC_IPMI_NODES_FILE INI fyle syntax instead."},{"line_number":67,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Set up defaults for functional / integration testing"}],"source_content_type":"application/x-shellscript","patch_set":54,"id":"ba0121b8_dc98b26c","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":53},"updated":"2016-03-31 20:55:29.000000000","message":"should we echo a message to the user about this deprecation?","commit_id":"d0078dcaa801f0941fb4939ea29679c48abd4ef4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d6a0574b941583fb2b05d6ed406b15224c6f1ef1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#cpus\u003d4"},{"line_number":63,"context_line":"IRONIC_IPMI_NODES_FILE\u003d${IRONIC_IPMI_NODES_FILE:-$IRONIC_DATA_DIR/ironic_ipmi_nodes}"},{"line_number":64,"context_line":"IRONIC_VM_NODES_FILE\u003d${IRONIC_VM_NODES_FILE:-$IRONIC_DATA_DIR/ironic_vm_nodes}"},{"line_number":65,"context_line":"# CSV file is going to be deprecated in N relase."},{"line_number":66,"context_line":"# Use IRONIC_IPMI_NODES_FILE INI fyle syntax instead."},{"line_number":67,"context_line":"IRONIC_IPMIINFO_FILE\u003d${IRONIC_IPMIINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Set up defaults for functional / integration testing"}],"source_content_type":"application/x-shellscript","patch_set":54,"id":"ba0121b8_1322ffa2","line":66,"range":{"start_line":65,"start_character":0,"end_line":66,"end_character":53},"in_reply_to":"ba0121b8_dc98b26c","updated":"2016-04-01 12:49:48.000000000","message":"I have added echo message to convert_csv_to_ini function.","commit_id":"d0078dcaa801f0941fb4939ea29679c48abd4ef4"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"612d54a8d4d9f4615117195a23da91e77a4e825f","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        i\u003d$((i+1))"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    done \u003c $IRONIC_IPMIINFO_FILE"},{"line_number":802,"context_line":"}"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"function enroll_nodes {"},{"line_number":805,"context_line":"    local chassis_id"}],"source_content_type":"application/x-shellscript","patch_set":62,"id":"dab17558_f8705774","line":802,"updated":"2016-05-16 10:12:16.000000000","message":"This function doesn\u0027t work for all possible driver cases the HWINFO file supports now.","commit_id":"aac13e1d3d1e2f49503c2190b1c5396fa04a9d70"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"28a3e58d74a1567b71d23ff20a52108c83eee57a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"if [ ! -z \"$IRONIC_IPMIINFO_FILE\" ]; then"},{"line_number":68,"context_line":"    deprecated \"IRONIC_IPMIINFO_FILE is deprecated, please switch to IRONIC_HWINFO_FILE. IRONIC_IPMIINFO_FILE will be removed in Ocata.\""},{"line_number":69,"context_line":"fi"},{"line_number":70,"context_line":"IRONIC_HWINFO_FILE\u003d${IRONIC_HWINFO_FILE:-${IRONIC_IPMIINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}}"},{"line_number":71,"context_line":"if [ -f \"$IRONIC_HWINFO_FILE\" ]; then"},{"line_number":72,"context_line":"    deprecated \"IRONIC_HWINFO_FILE scv syntax file is deprecated, please switch to IRONIC_HWINFO_INI_FILE ini syntax file.\""},{"line_number":73,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":64,"id":"bab6814e_e29b76c7","line":70,"updated":"2016-05-26 11:54:21.000000000","message":"You\u0027re deprecating IRONIC_HWINFO_FILE which in turn deprecated IRONIC_IPMIINFO_FILE, right? It might be the time to remove IRONIC_IPMIINFO_FILE then.","commit_id":"0557789f842e46df300d14911c84db68827a28a6"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"15e019e760f82b50e7c8cbbd89179bf148906c2e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"if [ ! -z \"$IRONIC_IPMIINFO_FILE\" ]; then"},{"line_number":68,"context_line":"    deprecated \"IRONIC_IPMIINFO_FILE is deprecated, please switch to IRONIC_HWINFO_FILE. IRONIC_IPMIINFO_FILE will be removed in Ocata.\""},{"line_number":69,"context_line":"fi"},{"line_number":70,"context_line":"IRONIC_HWINFO_FILE\u003d${IRONIC_HWINFO_FILE:-${IRONIC_IPMIINFO_FILE:-$IRONIC_DATA_DIR/hardware_info}}"},{"line_number":71,"context_line":"if [ -f \"$IRONIC_HWINFO_FILE\" ]; then"},{"line_number":72,"context_line":"    deprecated \"IRONIC_HWINFO_FILE scv syntax file is deprecated, please switch to IRONIC_HWINFO_INI_FILE ini syntax file.\""},{"line_number":73,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":64,"id":"bab6814e_a2aa0e6f","line":70,"in_reply_to":"bab6814e_e29b76c7","updated":"2016-05-26 12:09:36.000000000","message":"IRONIC_IPMIINFO_FILE was only deprecated 6 weeks ago so I\u0027m not sure it can be removed yet.","commit_id":"0557789f842e46df300d14911c84db68827a28a6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"28a3e58d74a1567b71d23ff20a52108c83eee57a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"fi"},{"line_number":74,"context_line":"# The file is INI syntax. Section names are ironic node names."},{"line_number":75,"context_line":"# Each section contains list of node options"},{"line_number":76,"context_line":"#[node-1]"},{"line_number":77,"context_line":"#ipmi_address\u003d1.1.1.1"},{"line_number":78,"context_line":"#mac_address\u003d0c:c4:7a:51:e6:c0"},{"line_number":79,"context_line":"#cpus\u003d4"}],"source_content_type":"application/x-shellscript","patch_set":64,"id":"bab6814e_6214a643","line":76,"updated":"2016-05-26 11:54:21.000000000","message":"There already is an example in the doc, might want to remove this.","commit_id":"0557789f842e46df300d14911c84db68827a28a6"}],"devstack/tools/ironic/scripts/create-node.sh":[{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"0f7481f6c9eb9f0d29f09e95f78c67e036bd606b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# Extra G to allow fuzz for partition table : flavor size and registered size"},{"line_number":16,"context_line":"# need to be different to actual size."},{"line_number":17,"context_line":"DISK\u003d$(( $4 + 1))"},{"line_number":18,"context_line":"ARCH\u003d$5"},{"line_number":19,"context_line":"BRIDGE\u003d$6"},{"line_number":20,"context_line":"EMULATOR\u003d$7"},{"line_number":21,"context_line":"VBMC_PORT\u003d$8"}],"source_content_type":"text/x-sh","patch_set":54,"id":"ba0121b8_7cefe61d","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"updated":"2016-03-31 20:55:29.000000000","message":"Think I would rather see this done as:\ncase $5 in\n    i386|i686) ARCH\u003d\u0027i686\u0027 ;;\n    amd64|x86_64) ARCH\u003d\u0027x86_64\u0027 ;;\n    *) echo \"Unsupported arch $4!\" ; exit 1 ;;\nesac","commit_id":"d0078dcaa801f0941fb4939ea29679c48abd4ef4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d6a0574b941583fb2b05d6ed406b15224c6f1ef1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# Extra G to allow fuzz for partition table : flavor size and registered size"},{"line_number":16,"context_line":"# need to be different to actual size."},{"line_number":17,"context_line":"DISK\u003d$(( $4 + 1))"},{"line_number":18,"context_line":"ARCH\u003d$5"},{"line_number":19,"context_line":"BRIDGE\u003d$6"},{"line_number":20,"context_line":"EMULATOR\u003d$7"},{"line_number":21,"context_line":"VBMC_PORT\u003d$8"}],"source_content_type":"text/x-sh","patch_set":54,"id":"ba0121b8_e11fb8b4","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"ba0121b8_7cefe61d","updated":"2016-04-01 12:49:48.000000000","message":"I don\u0027t understand why this case is needed?\nAt the moment vm_cpu arch is hardcoded to amd64 https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L656.\n\nAnd in this script amd64 is replaced with x86_64, while ironic node is registered with x86_64 https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L700\n\nThis patch introduce new variable IRONIC_VM_SPECS_CPU_ARCH that defines node arch explicitly.","commit_id":"d0078dcaa801f0941fb4939ea29679c48abd4ef4"}]}