)]}'
{"devstack/doc/source/guides/ironic-options.rst":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"aef11541be40d0d3448a8fa64720bd7bd463ba57","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    # Ironic provision network name"},{"line_number":92,"context_line":"    IRONIC_PROVISION_NETWORK_NAME\u003dironic-provision"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # Provision network provider type. Can be flat of vlan."},{"line_number":95,"context_line":"    IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003dvlan"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # If provider type is vlan. VLAN_ID may be specified. If it is not set,"}],"source_content_type":"text/x-rst","patch_set":34,"id":"3a57f1b5_e0e5d037","line":94,"updated":"2016-02-12 01:07:46.000000000","message":"nit: s/of/or/","commit_id":"572d1bc6e78fb588f2d0932bea1e150975986e90"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"889a306951d5deb830adaad9de4120a091c097d4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # Ironic provision network name"},{"line_number":71,"context_line":"    IRONIC_PROVISION_NETWORK_NAME\u003dironic-provision"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # Provision network provider type. Can be flat of vlan."},{"line_number":74,"context_line":"    IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003dvlan"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # If provider type is vlan. VLAN_ID may be specified. If it is not set,"}],"source_content_type":"text/x-rst","patch_set":64,"id":"dab17558_e1eb40a2","line":73,"updated":"2016-05-17 11:25:43.000000000","message":"s/of/or","commit_id":"66d25fdead784c4001a421d0bc10097c9b505ac7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5d0913f5adc6b0c33a6bb0d5ab10e1596fbc148b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # Ironic provision network name"},{"line_number":71,"context_line":"    IRONIC_PROVISION_NETWORK_NAME\u003dironic-provision"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # Provision network provider type. Can be flat of vlan."},{"line_number":74,"context_line":"    IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003dvlan"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    # If provider type is vlan. VLAN_ID may be specified. If it is not set,"}],"source_content_type":"text/x-rst","patch_set":64,"id":"bab6814e_a73615e5","line":73,"in_reply_to":"dab17558_e1eb40a2","updated":"2016-05-24 16:16:34.000000000","message":"Done","commit_id":"66d25fdead784c4001a421d0bc10097c9b505ac7"}],"devstack/lib/ironic":[{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"20f0237202253e14484da521c43b1356934515e3","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# Ironic provision network name"},{"line_number":161,"context_line":"IRONIC_PROVISION_NETWORK_NAME\u003d${IRONIC_PROVISION_NETWORK_NAME:-}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# Provision network provider type. Can be flat of vlan."},{"line_number":164,"context_line":"IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003d${IRONIC_PROVISION_PROVIDER_NETWORK_TYPE:-\u0027vlan\u0027}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"# If IRONIC_PROVISION_PROVIDER_NETWORK_TYPE is vlan. VLAN_ID may be specified. If it is not set,"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ba63e191_d8eb2077","line":163,"range":{"start_line":163,"start_character":47,"end_line":163,"end_character":49},"updated":"2016-01-20 02:29:09.000000000","message":"s/of/or/, right?","commit_id":"043b9e889c1e30fb80b43ca712cbfeda1aab00ce"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"63c63d822389ce289b2ebfa63ceae9343e9312d0","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    # othervise assign ip to br interface directly."},{"line_number":350,"context_line":"    if [[ \"$IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\" \u003d\u003d \"vlan\" ]]; then"},{"line_number":351,"context_line":"        sudo vconfig add $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":352,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_15b469cf","line":352,"range":{"start_line":352,"start_character":13,"end_line":352,"end_character":21},"updated":"2016-02-09 09:46:44.000000000","message":"Wouldn\u0027t it better to use \u0027ip link IF up\u0027 for RHEL7/CentOS7?","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"4f1de8893eaf0f90bfc2031e29eeb15aa48531ef","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    # othervise assign ip to br interface directly."},{"line_number":350,"context_line":"    if [[ \"$IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\" \u003d\u003d \"vlan\" ]]; then"},{"line_number":351,"context_line":"        sudo vconfig add $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":352,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"3a57f1b5_adb7d0f3","line":352,"range":{"start_line":352,"start_character":13,"end_line":352,"end_character":21},"in_reply_to":"5a5ae5dd_0b7206ae","updated":"2016-02-12 02:13:51.000000000","message":"Thanks for the consideration.","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"635b02f8f177245b984ad0c140bcd1e4988cfd96","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    # othervise assign ip to br interface directly."},{"line_number":350,"context_line":"    if [[ \"$IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\" \u003d\u003d \"vlan\" ]]; then"},{"line_number":351,"context_line":"        sudo vconfig add $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":352,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_0b7206ae","line":352,"range":{"start_line":352,"start_character":13,"end_line":352,"end_character":21},"in_reply_to":"5a5ae5dd_15b469cf","updated":"2016-02-09 12:05:56.000000000","message":"ifconfig is going to be deprecated, but it is still present in RHEL7 and CentOS7. Replaced it with ip link","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"63c63d822389ce289b2ebfa63ceae9343e9312d0","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    if [[ \"$IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\" \u003d\u003d \"vlan\" ]]; then"},{"line_number":351,"context_line":"        sudo vconfig add $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":352,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"},{"line_number":356,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_d5c6d148","line":353,"range":{"start_line":353,"start_character":13,"end_line":353,"end_character":21},"updated":"2016-02-09 09:46:44.000000000","message":"ditto","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"635b02f8f177245b984ad0c140bcd1e4988cfd96","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    if [[ \"$IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\" \u003d\u003d \"vlan\" ]]; then"},{"line_number":351,"context_line":"        sudo vconfig add $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":352,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"},{"line_number":356,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_cbd94e85","line":353,"range":{"start_line":353,"start_character":13,"end_line":353,"end_character":21},"in_reply_to":"5a5ae5dd_d5c6d148","updated":"2016-02-09 12:05:56.000000000","message":"Done","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"63c63d822389ce289b2ebfa63ceae9343e9312d0","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"},{"line_number":356,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":357,"context_line":"    fi"},{"line_number":358,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_55e181cf","line":355,"range":{"start_line":355,"start_character":13,"end_line":355,"end_character":21},"updated":"2016-02-09 09:46:44.000000000","message":"ditto","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"635b02f8f177245b984ad0c140bcd1e4988cfd96","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"},{"line_number":356,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":357,"context_line":"    fi"},{"line_number":358,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_6be61a46","line":355,"range":{"start_line":355,"start_character":13,"end_line":355,"end_character":21},"in_reply_to":"5a5ae5dd_55e181cf","updated":"2016-02-09 12:05:56.000000000","message":"Done","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"63c63d822389ce289b2ebfa63ceae9343e9312d0","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"},{"line_number":356,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":357,"context_line":"    fi"},{"line_number":358,"context_line":"}"},{"line_number":359,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_d5cd715e","line":356,"range":{"start_line":356,"start_character":13,"end_line":356,"end_character":21},"updated":"2016-02-09 09:46:44.000000000","message":"ditto","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"635b02f8f177245b984ad0c140bcd1e4988cfd96","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":354,"context_line":"    else"},{"line_number":355,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE up"},{"line_number":356,"context_line":"        sudo ifconfig $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SUBNET_GATEWAY/$provision_net_prefix"},{"line_number":357,"context_line":"    fi"},{"line_number":358,"context_line":"}"},{"line_number":359,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_8be35633","line":356,"range":{"start_line":356,"start_character":13,"end_line":356,"end_character":21},"in_reply_to":"5a5ae5dd_d5cd715e","updated":"2016-02-09 12:05:56.000000000","message":"Done","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"63c63d822389ce289b2ebfa63ceae9343e9312d0","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    local bridge_subint"},{"line_number":366,"context_line":"    bridge_subint\u003d$(cat /proc/net/dev | sed -n \"s/^\\(${OVS_PHYSICAL_BRIDGE}\\.[0-9]*\\).*/\\1/p\")"},{"line_number":367,"context_line":"    for sub_int in $bridge_subint; do"},{"line_number":368,"context_line":"        sudo ifconfig $sub_int down"},{"line_number":369,"context_line":"        sudo ip link del dev $sub_int"},{"line_number":370,"context_line":"    done"},{"line_number":371,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_95d7f9ec","line":368,"range":{"start_line":368,"start_character":13,"end_line":368,"end_character":21},"updated":"2016-02-09 09:46:44.000000000","message":"ditto for down","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"635b02f8f177245b984ad0c140bcd1e4988cfd96","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    local bridge_subint"},{"line_number":366,"context_line":"    bridge_subint\u003d$(cat /proc/net/dev | sed -n \"s/^\\(${OVS_PHYSICAL_BRIDGE}\\.[0-9]*\\).*/\\1/p\")"},{"line_number":367,"context_line":"    for sub_int in $bridge_subint; do"},{"line_number":368,"context_line":"        sudo ifconfig $sub_int down"},{"line_number":369,"context_line":"        sudo ip link del dev $sub_int"},{"line_number":370,"context_line":"    done"},{"line_number":371,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5a5ae5dd_2bcfc2b4","line":368,"range":{"start_line":368,"start_character":13,"end_line":368,"end_character":21},"in_reply_to":"5a5ae5dd_95d7f9ec","updated":"2016-02-09 12:05:56.000000000","message":"Done","commit_id":"a1297d74769f9c7eaa90de93bfc795ad7bfb3c63"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"aef11541be40d0d3448a8fa64720bd7bd463ba57","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":336,"context_line":"    local subnet_id\u003d\"$(neutron subnet-create --ip_version 4 \\"},{"line_number":337,"context_line":"        ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} \\"},{"line_number":338,"context_line":"        --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME \\"},{"line_number":339,"context_line":"        --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id \\"},{"line_number":340,"context_line":"        $IRONIC_PROVISION_SUBNET_PREFIX | grep \u0027 id \u0027 | get_field 2)\""}],"source_content_type":"application/x-shellscript","patch_set":34,"id":"3a57f1b5_600d60e7","line":337,"updated":"2016-02-12 01:07:46.000000000","message":"I learned some new syntax today, that\u0027s cool :)","commit_id":"572d1bc6e78fb588f2d0932bea1e150975986e90"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"889a306951d5deb830adaad9de4120a091c097d4","unresolved":false,"context_lines":[{"line_number":219,"context_line":"# Ironic provision network name"},{"line_number":220,"context_line":"IRONIC_PROVISION_NETWORK_NAME\u003d${IRONIC_PROVISION_NETWORK_NAME:-}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# Provision network provider type. Can be flat of vlan."},{"line_number":223,"context_line":"IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003d${IRONIC_PROVISION_PROVIDER_NETWORK_TYPE:-\u0027vlan\u0027}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# If IRONIC_PROVISION_PROVIDER_NETWORK_TYPE is vlan. VLAN_ID may be specified. If it is not set,"}],"source_content_type":"application/x-shellscript","patch_set":64,"id":"dab17558_014804cb","line":222,"updated":"2016-05-17 11:25:43.000000000","message":"s/of/or","commit_id":"66d25fdead784c4001a421d0bc10097c9b505ac7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"24a2508e95449ed0a47ec4bbfc448f5724df7e40","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    die_if_not_set $LINENO subnet_id \"Failure creating SUBNET_ID for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    iniset $IRONIC_CONF_FILE neutron provisioning_network_uuid $net_id"},{"line_number":451,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT network_provider neutron_plugin"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":454,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"}],"source_content_type":"application/x-shellscript","patch_set":70,"id":"3aaa91ec_5d8d6e30","line":451,"updated":"2016-06-22 13:37:16.000000000","message":"It\u0027s not used anymore and should be removed.","commit_id":"26ad8c2ff6e5c214ac3b62be12d4272f9a3bce5e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e4fea4e0cc87a081ca977a491619cf460a1b8e6","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    die_if_not_set $LINENO subnet_id \"Failure creating SUBNET_ID for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    iniset $IRONIC_CONF_FILE neutron provisioning_network_uuid $net_id"},{"line_number":451,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT network_provider neutron_plugin"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":454,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"}],"source_content_type":"application/x-shellscript","patch_set":72,"id":"1aa78d24_0df12802","line":451,"range":{"start_line":451,"start_character":4,"end_line":451,"end_character":68},"updated":"2016-07-13 20:52:37.000000000","message":"As has been pointed out in previous revisions, the setting is no longer called network_provider, and as I understand it seems not necessary.","commit_id":"df504ae311f6d2873da57f0ca01b69728468a03b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"85c40c1214cf78d3edfb37aba59f9bc0d916edc1","unresolved":false,"context_lines":[{"line_number":448,"context_line":"    die_if_not_set $LINENO subnet_id \"Failure creating SUBNET_ID for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    iniset $IRONIC_CONF_FILE neutron provisioning_network_uuid $net_id"},{"line_number":451,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT network_provider neutron_plugin"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":454,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"}],"source_content_type":"application/x-shellscript","patch_set":72,"id":"1aa78d24_a45614cc","line":451,"range":{"start_line":451,"start_character":4,"end_line":451,"end_character":68},"in_reply_to":"1aa78d24_0df12802","updated":"2016-07-14 11:01:58.000000000","message":"Done","commit_id":"df504ae311f6d2873da57f0ca01b69728468a03b"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"56fa886c4cb9fea87c2a208066551d94b4c33170","unresolved":false,"context_lines":[{"line_number":499,"context_line":"    die_if_not_set $LINENO subnet_id \"Failure creating SUBNET_ID for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    iniset $IRONIC_CONF_FILE neutron provisioning_network_uuid $net_id"},{"line_number":502,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT network_provider neutron_plugin"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":505,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"}],"source_content_type":"application/x-shellscript","patch_set":74,"id":"1aa78d24_89f691f7","line":502,"range":{"start_line":502,"start_character":12,"end_line":502,"end_character":28},"updated":"2016-07-14 10:33:04.000000000","message":"no need for network_provider here..","commit_id":"2873d2c8eaeb2f74afd4a8abf047f3a71e07c0ed"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"adabb2677ad893c442a2f0afd70a372e9ec0a80a","unresolved":false,"context_lines":[{"line_number":477,"context_line":"}"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"function configure_ironic_provision_network {"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    die_if_not_set $LINENO IRONIC_PROVISION_SUBNET_PREFIX \"You must specify the IRONIC_PROVISION_SUBNET_PREFIX\""},{"line_number":482,"context_line":"    die_if_not_set $LINENO PHYSICAL_NETWORK \"You must specify the PHYSICAL_NETWORK\""},{"line_number":483,"context_line":"    die_if_not_set $LINENO IRONIC_PROVISION_SUBNET_GATEWAY \"You must specify the IRONIC_PROVISION_SUBNET_GATEWAY\""}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_0b40eb55","line":480,"updated":"2016-07-18 10:09:28.000000000","message":"Most nit:\n\nShould we also test if IRONIC_PROVISION_NETWORK_NAME has been passed here ? Like we do in the \"cleanup_ironic_provision_network\" function.\n\n if [[ -z \"${IRONIC_PROVISION_NETWORK_NAME}\" ]]; then\n     return 0\n fi\n\nI know we have a conditional at plugin.sh, but, it looks inconsistent to have the \"configure_\" function to assert it in one file and the \"clean_\" function to assert it in another.","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"62997945b1cc2e3c25baa5022286adc5811bd566","unresolved":false,"context_lines":[{"line_number":477,"context_line":"}"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"function configure_ironic_provision_network {"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    die_if_not_set $LINENO IRONIC_PROVISION_SUBNET_PREFIX \"You must specify the IRONIC_PROVISION_SUBNET_PREFIX\""},{"line_number":482,"context_line":"    die_if_not_set $LINENO PHYSICAL_NETWORK \"You must specify the PHYSICAL_NETWORK\""},{"line_number":483,"context_line":"    die_if_not_set $LINENO IRONIC_PROVISION_SUBNET_GATEWAY \"You must specify the IRONIC_PROVISION_SUBNET_GATEWAY\""}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_a6f2b698","line":480,"in_reply_to":"dada55a8_0b40eb55","updated":"2016-07-18 10:28:01.000000000","message":"I think that we need to call configure_ironic_provision_network only if we need it, and if configure_ironic_provision_network failed, it should lead to deployment failure.","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a421da598796613a40588279b20c96b60708c019","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    net_id\u003d$(neutron net-create --provider:network_type $IRONIC_PROVISION_PROVIDER_NETWORK_TYPE \\"},{"line_number":487,"context_line":"        --provider:physical_network \"$PHYSICAL_NETWORK\" \\"},{"line_number":488,"context_line":"        ${IRONIC_PROVISION_SEGMENTATION_ID:+--provider:segmentation_id $IRONIC_PROVISION_SEGMENTATION_ID} \\"},{"line_number":489,"context_line":"        ${IRONIC_PROVISION_NETWORK_NAME} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":492,"context_line":"    local subnet_id"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_204d0973","line":489,"range":{"start_line":489,"start_character":42,"end_line":489,"end_character":68},"updated":"2016-07-18 11:00:45.000000000","message":"we should really switch to OSC commands instead of doing all this..","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"611cb5ba17f79855a9858599fbd2ba878d9307f8","unresolved":false,"context_lines":[{"line_number":486,"context_line":"    net_id\u003d$(neutron net-create --provider:network_type $IRONIC_PROVISION_PROVIDER_NETWORK_TYPE \\"},{"line_number":487,"context_line":"        --provider:physical_network \"$PHYSICAL_NETWORK\" \\"},{"line_number":488,"context_line":"        ${IRONIC_PROVISION_SEGMENTATION_ID:+--provider:segmentation_id $IRONIC_PROVISION_SEGMENTATION_ID} \\"},{"line_number":489,"context_line":"        ${IRONIC_PROVISION_NETWORK_NAME} | grep \u0027 id \u0027 | get_field 2)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":492,"context_line":"    local subnet_id"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_9420774b","line":489,"range":{"start_line":489,"start_character":42,"end_line":489,"end_character":68},"in_reply_to":"dada55a8_204d0973","updated":"2016-07-18 12:51:47.000000000","message":"Done","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a421da598796613a40588279b20c96b60708c019","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":492,"context_line":"    local subnet_id"},{"line_number":493,"context_line":"    subnet_id\u003d\"$(neutron subnet-create --ip_version 4 \\"},{"line_number":494,"context_line":"        ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} \\"},{"line_number":495,"context_line":"        --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME \\"},{"line_number":496,"context_line":"        --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id \\"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_803e75b6","line":493,"range":{"start_line":493,"start_character":52,"end_line":493,"end_character":53},"updated":"2016-07-18 11:00:45.000000000","message":"I wonder if it makes sense to have this configurable","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"611cb5ba17f79855a9858599fbd2ba878d9307f8","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    die_if_not_set $LINENO net_id \"Failure creating net_id for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":492,"context_line":"    local subnet_id"},{"line_number":493,"context_line":"    subnet_id\u003d\"$(neutron subnet-create --ip_version 4 \\"},{"line_number":494,"context_line":"        ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} \\"},{"line_number":495,"context_line":"        --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME \\"},{"line_number":496,"context_line":"        --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id \\"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_f47d73e8","line":493,"range":{"start_line":493,"start_character":52,"end_line":493,"end_character":53},"in_reply_to":"dada55a8_803e75b6","updated":"2016-07-18 12:51:47.000000000","message":"I think we can add it in future, once we start using ipv6. For now I prefer to left it hardcoded.","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a421da598796613a40588279b20c96b60708c019","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} \\"},{"line_number":495,"context_line":"        --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME \\"},{"line_number":496,"context_line":"        --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id \\"},{"line_number":497,"context_line":"        $IRONIC_PROVISION_SUBNET_PREFIX | grep \u0027 id \u0027 | get_field 2)\""},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    die_if_not_set $LINENO subnet_id \"Failure creating SUBNET_ID for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":500,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_60570103","line":497,"range":{"start_line":497,"start_character":41,"end_line":497,"end_character":67},"updated":"2016-07-18 11:00:45.000000000","message":"ditto","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"611cb5ba17f79855a9858599fbd2ba878d9307f8","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        ${IRONIC_PROVISION_ALLOCATION_POOL:+--allocation-pool $IRONIC_PROVISION_ALLOCATION_POOL} \\"},{"line_number":495,"context_line":"        --name $IRONIC_PROVISION_PROVIDER_SUBNET_NAME \\"},{"line_number":496,"context_line":"        --gateway $IRONIC_PROVISION_SUBNET_GATEWAY $net_id \\"},{"line_number":497,"context_line":"        $IRONIC_PROVISION_SUBNET_PREFIX | grep \u0027 id \u0027 | get_field 2)\""},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    die_if_not_set $LINENO subnet_id \"Failure creating SUBNET_ID for $IRONIC_PROVISION_NETWORK_NAME\""},{"line_number":500,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_b4465bbd","line":497,"range":{"start_line":497,"start_character":41,"end_line":497,"end_character":67},"in_reply_to":"dada55a8_60570103","updated":"2016-07-18 12:51:47.000000000","message":"Done","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a421da598796613a40588279b20c96b60708c019","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    iniset $IRONIC_CONF_FILE neutron provisioning_network_uuid $net_id"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":504,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    # Set provision network GW on physical interface"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_c05fcd0c","line":503,"range":{"start_line":503,"start_character":103,"end_line":503,"end_character":150},"updated":"2016-07-18 11:00:45.000000000","message":"ditto","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"611cb5ba17f79855a9858599fbd2ba878d9307f8","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    iniset $IRONIC_CONF_FILE neutron provisioning_network_uuid $net_id"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":504,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    # Set provision network GW on physical interface"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_6ff52a82","line":503,"range":{"start_line":503,"start_character":103,"end_line":503,"end_character":150},"in_reply_to":"dada55a8_c05fcd0c","updated":"2016-07-18 12:51:47.000000000","message":"Done","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"611cb5ba17f79855a9858599fbd2ba878d9307f8","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    iniset $IRONIC_CONF_FILE neutron provisioning_network_uuid $net_id"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`neutron net-show ${net_id} | grep -w \u0027provider:segmentation_id\u0027| get_field 2`}"},{"line_number":504,"context_line":"    provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    # Set provision network GW on physical interface"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_f41613a6","line":503,"range":{"start_line":503,"start_character":103,"end_line":503,"end_character":150},"in_reply_to":"dada55a8_c05fcd0c","updated":"2016-07-18 12:51:47.000000000","message":"Done","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"62997945b1cc2e3c25baa5022286adc5811bd566","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"function cleanup_ironic_provision_network {"},{"line_number":520,"context_line":"    if [[ -z \"${IRONIC_PROVISION_NETWORK_NAME}\" ]]; then"},{"line_number":521,"context_line":"        return 0"},{"line_number":522,"context_line":"    fi"},{"line_number":523,"context_line":"    # Cleanup OVS_PHYSICAL_BRIDGE subinterfaces"},{"line_number":524,"context_line":"    local bridge_subint"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_71207a4a","line":521,"updated":"2016-07-18 10:28:01.000000000","message":"I doubt that we need this check here. After Lucas comment on L480. Imagine that we change local.conf and there is no IRONIC_PROVISION_NETWORK_NAME anymore. It means that run cleaning will not remove provisioning_network setup. It seems that cleaning should be not rely on local.conf variables.\nWDYT?","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1d36e4f7e23bbe7245616507fc9910cd4c41f44d","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"function cleanup_ironic_provision_network {"},{"line_number":520,"context_line":"    if [[ -z \"${IRONIC_PROVISION_NETWORK_NAME}\" ]]; then"},{"line_number":521,"context_line":"        return 0"},{"line_number":522,"context_line":"    fi"},{"line_number":523,"context_line":"    # Cleanup OVS_PHYSICAL_BRIDGE subinterfaces"},{"line_number":524,"context_line":"    local bridge_subint"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_e04bf157","line":521,"in_reply_to":"dada55a8_71207a4a","updated":"2016-07-18 10:58:12.000000000","message":"++ could be a follow-up patch","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"611cb5ba17f79855a9858599fbd2ba878d9307f8","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"function cleanup_ironic_provision_network {"},{"line_number":520,"context_line":"    if [[ -z \"${IRONIC_PROVISION_NETWORK_NAME}\" ]]; then"},{"line_number":521,"context_line":"        return 0"},{"line_number":522,"context_line":"    fi"},{"line_number":523,"context_line":"    # Cleanup OVS_PHYSICAL_BRIDGE subinterfaces"},{"line_number":524,"context_line":"    local bridge_subint"}],"source_content_type":"application/x-shellscript","patch_set":77,"id":"dada55a8_f4f2936e","line":521,"in_reply_to":"dada55a8_e04bf157","updated":"2016-07-18 12:51:47.000000000","message":"Done","commit_id":"75fc071b54a07fbdbaabaebd359299170bd7fda2"}],"devstack/plugin.sh":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cc108c305548227ae7211d23eb90918d32764daf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # Start the ironic API and ironic taskmgr components"},{"line_number":31,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":32,"context_line":"        start_ironic"},{"line_number":33,"context_line":"        prepare_baremetal_basic_ops"},{"line_number":34,"context_line":"    fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    if [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"da6ed579_cfa091a8","line":33,"updated":"2016-01-11 22:56:45.000000000","message":"configure_ironic_provision_network is called before setup-network.sh (which is called only in prepare_baremetal_basic_ops) and because of that bringing up brbm.\u003cprovision vlan\u003e interface fails on fedora. Seems that it still should be fixed.","commit_id":"0933e22a086974dab474de089fb941d40a64dbcd"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b81ba34e50809b5df0b47aba6ac434ac2f591b76","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # Start the ironic API and ironic taskmgr components"},{"line_number":31,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":32,"context_line":"        start_ironic"},{"line_number":33,"context_line":"        prepare_baremetal_basic_ops"},{"line_number":34,"context_line":"    fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    if [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"da6ed579_287a0378","line":33,"in_reply_to":"da6ed579_cfa091a8","updated":"2016-01-13 23:25:00.000000000","message":"you are right, thanks for review. It has been fixed.","commit_id":"0933e22a086974dab474de089fb941d40a64dbcd"}]}