)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"ab1cd2890e5af8f81defc5cf852d234705a4190e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"},{"line_number":121,"context_line":"IRONIC_SERVICE_PORT_INT\u003d${IRONIC_SERVICE_PORT_INT:-16385}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":124,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a710552_eb45e4b2","line":121,"updated":"2015-12-16 10:16:11.000000000","message":"what\u0027s the meaning of ’INT‘?","commit_id":"288f4a9ccecded5fca9edc9137589aa51c806339"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"77aca583b8e5f395dc6a56b0b3b6a87fc078a013","unresolved":false,"context_lines":[{"line_number":118,"context_line":"fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"},{"line_number":121,"context_line":"IRONIC_SERVICE_PORT_INT\u003d${IRONIC_SERVICE_PORT_INT:-16385}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":124,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a710552_dd19c97a","line":121,"in_reply_to":"5a710552_eb45e4b2","updated":"2015-12-16 12:32:57.000000000","message":"I guess it\u0027s \u0027intermediate\u0027, I just keep devstake naming","commit_id":"288f4a9ccecded5fca9edc9137589aa51c806339"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"ab1cd2890e5af8f81defc5cf852d234705a4190e","unresolved":false,"context_lines":[{"line_number":503,"context_line":"    local service_hostport\u003d$IRONIC_HOSTPORT"},{"line_number":504,"context_line":"    local service_protocol\u003d$IRONIC_SERVICE_PROTOCOL"},{"line_number":505,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":506,"context_line":"        service_hostport\u003d$SERVICE_HOST:${IRONIC_SERVICE_PORT_INT}"},{"line_number":507,"context_line":"        service_protocol\u003d\"http\""},{"line_number":508,"context_line":"    fi"},{"line_number":509,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a710552_862457af","line":506,"updated":"2015-12-16 10:16:11.000000000","message":"It seems that we will set the proxy port for ir-api on 16385, right? Could you add comments about this to be more clear?","commit_id":"288f4a9ccecded5fca9edc9137589aa51c806339"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"77aca583b8e5f395dc6a56b0b3b6a87fc078a013","unresolved":false,"context_lines":[{"line_number":503,"context_line":"    local service_hostport\u003d$IRONIC_HOSTPORT"},{"line_number":504,"context_line":"    local service_protocol\u003d$IRONIC_SERVICE_PROTOCOL"},{"line_number":505,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":506,"context_line":"        service_hostport\u003d$SERVICE_HOST:${IRONIC_SERVICE_PORT_INT}"},{"line_number":507,"context_line":"        service_protocol\u003d\"http\""},{"line_number":508,"context_line":"    fi"},{"line_number":509,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a710552_60482a88","line":506,"in_reply_to":"5a710552_862457af","updated":"2015-12-16 12:32:57.000000000","message":"ok","commit_id":"288f4a9ccecded5fca9edc9137589aa51c806339"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"b263c61e316621c5335981e3086f5db179337237","unresolved":false,"context_lines":[{"line_number":114,"context_line":"if is_ssl_enabled_service \"ironic\" || is_service_enabled tls-proxy; then"},{"line_number":115,"context_line":"    IRONIC_SERVICE_PROTOCOL\u003d\"https\""},{"line_number":116,"context_line":"else"},{"line_number":117,"context_line":"    IRONIC_SERVICE_PROTOCOL\u003d\"http\""},{"line_number":118,"context_line":"fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da6ed579_b79d6b0c","line":117,"range":{"start_line":117,"start_character":29,"end_line":117,"end_character":33},"updated":"2016-01-16 04:09:49.000000000","message":"as we have replaced this with SERVICE_PROTOCOL in https://review.openstack.org/#/c/266257/ , please rebase your patch and fix that.","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a71c0d23f339d31842ea51ea91b89d1a7873fc","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    fi"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    # Register SSL certificates if provided"},{"line_number":308,"context_line":"    if is_ssl_enabled_service ironic; then"},{"line_number":309,"context_line":"        ensure_certificates IRONIC"},{"line_number":310,"context_line":"        iniset $IRONIC_CONF_FILE ssl cert_file \"$IRONIC_SSL_CERT\""},{"line_number":311,"context_line":"        iniset $IRONIC_CONF_FILE ssl key_file \"$IRONIC_SSL_KEY\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa69d971_63c48790","line":308,"updated":"2016-01-05 12:40:37.000000000","message":"ironic should be added to SSL_ENABLED_SERVICES IIUC.","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dccb1d8f67cb895659fa23b667d893993bae0624","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    fi"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    # Register SSL certificates if provided"},{"line_number":308,"context_line":"    if is_ssl_enabled_service ironic; then"},{"line_number":309,"context_line":"        ensure_certificates IRONIC"},{"line_number":310,"context_line":"        iniset $IRONIC_CONF_FILE ssl cert_file \"$IRONIC_SSL_CERT\""},{"line_number":311,"context_line":"        iniset $IRONIC_CONF_FILE ssl key_file \"$IRONIC_SSL_KEY\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da6ed579_e8b738f3","line":308,"in_reply_to":"da6ed579_c8a839de","updated":"2016-01-13 09:36:39.000000000","message":"Thanks, although idk if it should go to devstack or should be added here. If it goes to devstack, please add a depends-on to commit message.","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"06ccdb310120584177176ba5c9772ca89fc8e0fa","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    fi"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    # Register SSL certificates if provided"},{"line_number":308,"context_line":"    if is_ssl_enabled_service ironic; then"},{"line_number":309,"context_line":"        ensure_certificates IRONIC"},{"line_number":310,"context_line":"        iniset $IRONIC_CONF_FILE ssl cert_file \"$IRONIC_SSL_CERT\""},{"line_number":311,"context_line":"        iniset $IRONIC_CONF_FILE ssl key_file \"$IRONIC_SSL_KEY\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da6ed579_2b51ca0e","line":308,"in_reply_to":"da6ed579_e8b738f3","updated":"2016-01-13 09:55:32.000000000","message":"to keep consistency, I\u0027ve added it to devstack as other services do, and it depends on this patch - it looks like more reasonable.","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"de589efede865fe9399c54a3da1825a76829c8d1","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    fi"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    # Register SSL certificates if provided"},{"line_number":308,"context_line":"    if is_ssl_enabled_service ironic; then"},{"line_number":309,"context_line":"        ensure_certificates IRONIC"},{"line_number":310,"context_line":"        iniset $IRONIC_CONF_FILE ssl cert_file \"$IRONIC_SSL_CERT\""},{"line_number":311,"context_line":"        iniset $IRONIC_CONF_FILE ssl key_file \"$IRONIC_SSL_KEY\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da6ed579_c8a839de","line":308,"in_reply_to":"fa69d971_63c48790","updated":"2016-01-13 07:47:40.000000000","message":"it\u0027s here https://review.openstack.org/#/c/266751/","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"88a71c0d23f339d31842ea51ea91b89d1a7873fc","unresolved":false,"context_lines":[{"line_number":502,"context_line":"function start_ironic_api {"},{"line_number":503,"context_line":"    local service_hostport\u003d$IRONIC_HOSTPORT"},{"line_number":504,"context_line":"    local service_protocol\u003d$IRONIC_SERVICE_PROTOCOL"},{"line_number":505,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":506,"context_line":"        # In case of using TLS termination proxy, \u002716385\u0027 port"},{"line_number":507,"context_line":"        # will be used for ironic API."},{"line_number":508,"context_line":"        service_hostport\u003d$SERVICE_HOST:${IRONIC_SERVICE_PORT_INT}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa69d971_03190b22","line":505,"updated":"2016-01-05 12:40:37.000000000","message":"In case of tls-proxy, shouldn\u0027t we start it?","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"06ccdb310120584177176ba5c9772ca89fc8e0fa","unresolved":false,"context_lines":[{"line_number":502,"context_line":"function start_ironic_api {"},{"line_number":503,"context_line":"    local service_hostport\u003d$IRONIC_HOSTPORT"},{"line_number":504,"context_line":"    local service_protocol\u003d$IRONIC_SERVICE_PROTOCOL"},{"line_number":505,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":506,"context_line":"        # In case of using TLS termination proxy, \u002716385\u0027 port"},{"line_number":507,"context_line":"        # will be used for ironic API."},{"line_number":508,"context_line":"        service_hostport\u003d$SERVICE_HOST:${IRONIC_SERVICE_PORT_INT}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da6ed579_0beac60f","line":505,"in_reply_to":"da6ed579_082dec45","updated":"2016-01-13 09:55:32.000000000","message":"ahh, you are right, I thought somehow it was already refactored in devstack, I\u0027ll add this for now.","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dccb1d8f67cb895659fa23b667d893993bae0624","unresolved":false,"context_lines":[{"line_number":502,"context_line":"function start_ironic_api {"},{"line_number":503,"context_line":"    local service_hostport\u003d$IRONIC_HOSTPORT"},{"line_number":504,"context_line":"    local service_protocol\u003d$IRONIC_SERVICE_PROTOCOL"},{"line_number":505,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":506,"context_line":"        # In case of using TLS termination proxy, \u002716385\u0027 port"},{"line_number":507,"context_line":"        # will be used for ironic API."},{"line_number":508,"context_line":"        service_hostport\u003d$SERVICE_HOST:${IRONIC_SERVICE_PORT_INT}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da6ed579_082dec45","line":505,"in_reply_to":"da6ed579_c8f6f9f8","updated":"2016-01-13 09:36:39.000000000","message":"Huh? You mean adding tls-proxy to SSL_ENABLED_SERVICES? I was looking at https://github.com/openstack-dev/devstack/blob/master/lib/cinder#L524-L527","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"de589efede865fe9399c54a3da1825a76829c8d1","unresolved":false,"context_lines":[{"line_number":502,"context_line":"function start_ironic_api {"},{"line_number":503,"context_line":"    local service_hostport\u003d$IRONIC_HOSTPORT"},{"line_number":504,"context_line":"    local service_protocol\u003d$IRONIC_SERVICE_PROTOCOL"},{"line_number":505,"context_line":"    if is_service_enabled tls-proxy; then"},{"line_number":506,"context_line":"        # In case of using TLS termination proxy, \u002716385\u0027 port"},{"line_number":507,"context_line":"        # will be used for ironic API."},{"line_number":508,"context_line":"        service_hostport\u003d$SERVICE_HOST:${IRONIC_SERVICE_PORT_INT}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da6ed579_c8f6f9f8","line":505,"in_reply_to":"fa69d971_03190b22","updated":"2016-01-13 07:47:40.000000000","message":"If user want proxy he/she should add it to SSL_ENABLED_SERVICES explicitly, and it will run.","commit_id":"56e5603fa50d77682aff65346dd0eb59cbb45a29"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6fb15f4ac14344cc986c6cd97bc793225ca3043f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    if is_ssl_enabled_service ironic; then"},{"line_number":319,"context_line":"        ensure_certificates IRONIC"},{"line_number":320,"context_line":"        iniset $IRONIC_CONF_FILE ssl cert_file \"$IRONIC_SSL_CERT\""},{"line_number":321,"context_line":"        iniset $IRONIC_CONF_FILE ssl key_file \"$IRONIC_SSL_KEY\""},{"line_number":322,"context_line":"        iniset $IRONIC_CONF_FILE api enable_ssl_api true"},{"line_number":323,"context_line":"    fi"},{"line_number":324,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1af94dfe_73c0292b","line":321,"updated":"2016-03-16 18:48:54.000000000","message":"ca_file may be set in $IRONIC_SSL_CA too, I think it should be added.","commit_id":"6480f968ef9b3cd6a72c411f1a176b1a5816b501"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6fb15f4ac14344cc986c6cd97bc793225ca3043f","unresolved":false,"context_lines":[{"line_number":507,"context_line":"    fi"},{"line_number":508,"context_line":"    # Start proxies if enabled"},{"line_number":509,"context_line":"    if is_service_enabled ir-api \u0026\u0026 is_service_enabled tls-proxy; then"},{"line_number":510,"context_line":"        start_tls_proxy \u0027*\u0027 IRONIC_SERVICE_PORT $SERVICE_HOST $IRONIC_SERVICE_PORT_INT \u0026"},{"line_number":511,"context_line":"    fi"},{"line_number":512,"context_line":"}"},{"line_number":513,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1af94dfe_13272565","line":510,"updated":"2016-03-16 18:48:54.000000000","message":"$IRONIC_SERVICE_PORT","commit_id":"6480f968ef9b3cd6a72c411f1a176b1a5816b501"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2774c071967a6d2bd5107015a120d6a61416d9c7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"# Ironic connection info.  Note the port must be specified."},{"line_number":126,"context_line":"IRONIC_SERVICE_PROTOCOL\u003d${IRONIC_SERVICE_PROTOCOL:-$SERVICE_PROTOCOL}"},{"line_number":127,"context_line":"IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"},{"line_number":128,"context_line":"IRONIC_SERVICE_PORT_INT\u003d${IRONIC_SERVICE_PORT_INT:-16385}"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":131,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a461143_a220d19c","line":128,"updated":"2017-01-26 13:59:12.000000000","message":"no need to introduce new variable, just pick different default values for IRONIC_SERVICE_PORT based on ssl enabled or not.\n\nif is_ssl_enabled_service \"ironic\" || is_service_enabled tls-proxy; then\n    IRONIC_SERVICE_PROTOCOL\u003d\"https\"\n    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}\n    IRONIC_SERVICE_PROTOCOL\u003d\"https\"\nelse\n    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}\n    IRONIC_SERVICE_PROTOCOL\u003d${IRONIC_SERVICE_PROTOCOL:-$SERVICE_PROTOCOL}\nfi","commit_id":"7c5704011e10d73a4eb4307e3066d8b1e717f7ba"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2774c071967a6d2bd5107015a120d6a61416d9c7","unresolved":false,"context_lines":[{"line_number":508,"context_line":"    fi"},{"line_number":509,"context_line":"    # Start proxies if enabled"},{"line_number":510,"context_line":"    if is_service_enabled ir-api \u0026\u0026 is_service_enabled tls-proxy; then"},{"line_number":511,"context_line":"        start_tls_proxy \u0027*\u0027 $IRONIC_SERVICE_PORT $SERVICE_HOST $IRONIC_SERVICE_PORT_INT \u0026"},{"line_number":512,"context_line":"    fi"},{"line_number":513,"context_line":"}"},{"line_number":514,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3a461143_0211a552","line":511,"range":{"start_line":511,"start_character":88,"end_line":511,"end_character":89},"updated":"2017-01-26 13:59:12.000000000","message":"why it is needed?","commit_id":"7c5704011e10d73a4eb4307e3066d8b1e717f7ba"}]}