)]}'
{"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a549534b26d0e4aa1a68e72aaaaa796ec74cc81c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if (not agent_commands and task.node.driver_internal_info.get("},{"line_number":232,"context_line":"                \u0027cleaning_reboot\u0027) is True):"},{"line_number":233,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":234,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":235,"context_line":"            del task.node.driver_internal_info[\u0027cleaning_reboot\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_af3e2bd8","line":232,"range":{"start_line":232,"start_character":38,"end_line":232,"end_character":42},"updated":"2016-01-03 22:56:50.000000000","message":"Why are you comparing using \"is\" here? That\u0027s not testing \"trueness\" but rather identity against the \"True\" object. I think the better thing to do here is:\n\nif (not agent_commands and\n    task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):\n\n(small formatting nit, I think it\u0027s nicer to split the line at the \"and\" if required because it makes it easier for the reader of the code to understand the logic)","commit_id":"ad41a993babd75f38ac3fa97af4c20bcf7a69160"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c97b86e6083beb05daa4b755b548885d5f2a731a","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if (not agent_commands and task.node.driver_internal_info.get("},{"line_number":232,"context_line":"                \u0027cleaning_reboot\u0027) is True):"},{"line_number":233,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":234,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":235,"context_line":"            del task.node.driver_internal_info[\u0027cleaning_reboot\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_5a972f90","line":232,"range":{"start_line":232,"start_character":38,"end_line":232,"end_character":42},"in_reply_to":"fa69d971_af3e2bd8","updated":"2016-01-04 00:04:44.000000000","message":"This is actually a different bug -- we should check cleaning_reboot for true, not just existence. I\u0027ve adjusted  the parens to make this more clear and taken your advice regarding tabs.","commit_id":"ad41a993babd75f38ac3fa97af4c20bcf7a69160"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"a549534b26d0e4aa1a68e72aaaaa796ec74cc81c","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                    LOG.exception(msg)"},{"line_number":295,"context_line":"                    return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"            if task.node.clean_step.get(\u0027reboot_requested\u0027) is True:"},{"line_number":298,"context_line":"                self._cleaning_reboot(task)"},{"line_number":299,"context_line":"                return"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_6f2113b4","line":297,"range":{"start_line":297,"start_character":63,"end_line":297,"end_character":67},"updated":"2016-01-03 22:56:50.000000000","message":"\"as above\"","commit_id":"ad41a993babd75f38ac3fa97af4c20bcf7a69160"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c97b86e6083beb05daa4b755b548885d5f2a731a","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                    LOG.exception(msg)"},{"line_number":295,"context_line":"                    return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"            if task.node.clean_step.get(\u0027reboot_requested\u0027) is True:"},{"line_number":298,"context_line":"                self._cleaning_reboot(task)"},{"line_number":299,"context_line":"                return"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_1a91b799","line":297,"range":{"start_line":297,"start_character":63,"end_line":297,"end_character":67},"in_reply_to":"fa69d971_6f2113b4","updated":"2016-01-04 00:04:44.000000000","message":"Same as above. We\u0027re not checking merely for existence, we\u0027re making sure it\u0027s true.","commit_id":"ad41a993babd75f38ac3fa97af4c20bcf7a69160"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"47a7c44729edf6d0f246246b5365996eccac90df","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        at the beginning of cleaning and before executing each step in the"},{"line_number":224,"context_line":"        agent. If the version has changed between steps, the agent is unable"},{"line_number":225,"context_line":"        to tell if an ordering change will cause a cleaning issue. Therefore,"},{"line_number":226,"context_line":"        we restart cleaning."},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":"        node \u003d task.node"},{"line_number":229,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_2a16a6a7","line":226,"range":{"start_line":226,"start_character":19,"end_line":226,"end_character":27},"updated":"2016-01-04 04:53:15.000000000","message":"Update doc string for \u0027cleaning reboot\u0027","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"97843da5593f0395a23a09264440da4a67a7c091","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        at the beginning of cleaning and before executing each step in the"},{"line_number":224,"context_line":"        agent. If the version has changed between steps, the agent is unable"},{"line_number":225,"context_line":"        to tell if an ordering change will cause a cleaning issue. Therefore,"},{"line_number":226,"context_line":"        we restart cleaning."},{"line_number":227,"context_line":"        \"\"\""},{"line_number":228,"context_line":"        node \u003d task.node"},{"line_number":229,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_f9f011ff","line":226,"range":{"start_line":226,"start_character":19,"end_line":226,"end_character":27},"in_reply_to":"fa69d971_2a16a6a7","updated":"2016-01-05 22:42:05.000000000","message":"Done","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"47a7c44729edf6d0f246246b5365996eccac90df","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            LOG.error(msg)"},{"line_number":311,"context_line":"            return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _cleaning_reboot(self, task):"},{"line_number":314,"context_line":"        \"\"\"Reboots a node out of band after a clean step that requires it."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        If an agent clean step has \u0027reboot_requested\u0027: True, reboots the"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_ca5a6a83","line":313,"range":{"start_line":313,"start_character":8,"end_line":313,"end_character":24},"updated":"2016-01-04 04:53:15.000000000","message":"Testcases required for this method.","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dc2434a90f0f7d153aeb69be395626bc34271f15","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            LOG.error(msg)"},{"line_number":311,"context_line":"            return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _cleaning_reboot(self, task):"},{"line_number":314,"context_line":"        \"\"\"Reboots a node out of band after a clean step that requires it."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        If an agent clean step has \u0027reboot_requested\u0027: True, reboots the"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_ddd46b48","line":313,"range":{"start_line":313,"start_character":8,"end_line":313,"end_character":24},"in_reply_to":"fa69d971_ca5a6a83","updated":"2016-01-04 12:03:02.000000000","message":"++","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"97843da5593f0395a23a09264440da4a67a7c091","unresolved":false,"context_lines":[{"line_number":310,"context_line":"            LOG.error(msg)"},{"line_number":311,"context_line":"            return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def _cleaning_reboot(self, task):"},{"line_number":314,"context_line":"        \"\"\"Reboots a node out of band after a clean step that requires it."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        If an agent clean step has \u0027reboot_requested\u0027: True, reboots the"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_39eb0915","line":313,"range":{"start_line":313,"start_character":8,"end_line":313,"end_character":24},"in_reply_to":"fa69d971_ddd46b48","updated":"2016-01-05 22:42:05.000000000","message":"Done","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ef31093c0a97d1deb24aeb9f56e4a325ec31d20e","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        if (not agent_commands and"},{"line_number":236,"context_line":"            task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):"},{"line_number":237,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":238,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":239,"context_line":"            del task.node.driver_internal_info[\u0027cleaning_reboot\u0027]"},{"line_number":240,"context_line":"            task.node.save()"},{"line_number":241,"context_line":"            self.notify_conductor_resume_clean(task)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_2f329fa7","line":238,"updated":"2016-01-07 02:30:00.000000000","message":"So the node finished a cleaning step AND the node was rebooted after the cleaning step, right?\n\nMaybe remove \u0027just\u0027 (which makes it sound like that was what was just done). So eg\n\nNode finished a cleaning step that requested a reboot, the reboot was initiated, and this is the first heartbeat after rebooting. Continue cleaning.","commit_id":"a32589cdee371858f8cbf9fcbebe4bf09302dc02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ef31093c0a97d1deb24aeb9f56e4a325ec31d20e","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):"},{"line_number":237,"context_line":"            # Node just finished a cleaning step that requested a reboot, and"},{"line_number":238,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":239,"context_line":"            del task.node.driver_internal_info[\u0027cleaning_reboot\u0027]"},{"line_number":240,"context_line":"            task.node.save()"},{"line_number":241,"context_line":"            self.notify_conductor_resume_clean(task)"},{"line_number":242,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_cfdbc34d","line":239,"updated":"2016-01-07 02:30:00.000000000","message":"this won\u0027t work.\n\nyou\u0027ll need to do something like\n\ninfo \u003d task.node.driver_internal_info\ninfo.pop(\u0027cleaning_reboot\u0027)\ntask.node.driver_internal_info \u003d info","commit_id":"a32589cdee371858f8cbf9fcbebe4bf09302dc02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ef31093c0a97d1deb24aeb9f56e4a325ec31d20e","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    LOG.exception(msg)"},{"line_number":299,"context_line":"                    return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"            if task.node.clean_step.get(\u0027reboot_requested\u0027):"},{"line_number":302,"context_line":"                self._cleaning_reboot(task)"},{"line_number":303,"context_line":"                return"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_8f8cebda","line":301,"updated":"2016-01-07 02:30:00.000000000","message":"Where is it documented (if anywhere) that a clean step can have this \u0027reboot_requested\u0027? I\u0027d think \u0027reboot_after\u0027 makes more sense but anyway.","commit_id":"a32589cdee371858f8cbf9fcbebe4bf09302dc02"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"50f6465dfd4dcf7c14c394c9a9c62e0ef561ef13","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    LOG.exception(msg)"},{"line_number":299,"context_line":"                    return manager_utils.cleaning_error_handler(task, msg)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"            if task.node.clean_step.get(\u0027reboot_requested\u0027):"},{"line_number":302,"context_line":"                self._cleaning_reboot(task)"},{"line_number":303,"context_line":"                return"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_67737a81","line":301,"in_reply_to":"fa69d971_8f8cebda","updated":"2016-02-10 23:49:08.000000000","message":"reboot_requested actually already exists in some test cases, and in pydocs on the IPA side:\n\nhttps://github.com/openstack/ironic-python-agent/blob/0144e79df5dab0837a55a981fa23298908af14cf/ironic_python_agent/extensions/clean.py#L33\n\nLike the other thing -- I\u0027ll change this if you feel strongly about it, but we\u0027ve been using this key downstream already and would prefer to not have to write transition code for downstream.","commit_id":"a32589cdee371858f8cbf9fcbebe4bf09302dc02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ef31093c0a97d1deb24aeb9f56e4a325ec31d20e","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        # Signify that we\u0027ve rebooted"},{"line_number":334,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":335,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"},{"line_number":336,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":337,"context_line":"        task.node.save()"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_4fc7d363","line":335,"updated":"2016-01-07 02:30:00.000000000","message":"maybe \u0027cleaning_rebooted\u0027? the action has already been started.\n\nOr \u0027rebooting_after_clean_step\u0027 (clearer but longer)\n\nOr leave it, although it makes me think that a reboot needs to be done/started.","commit_id":"a32589cdee371858f8cbf9fcbebe4bf09302dc02"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"50f6465dfd4dcf7c14c394c9a9c62e0ef561ef13","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        # Signify that we\u0027ve rebooted"},{"line_number":334,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":335,"context_line":"        driver_internal_info[\u0027cleaning_reboot\u0027] \u003d True"},{"line_number":336,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":337,"context_line":"        task.node.save()"},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_a7f3b209","line":335,"in_reply_to":"fa69d971_4fc7d363","updated":"2016-02-10 23:49:08.000000000","message":"I have a strong preference for leaving it as we\u0027re already using this key downstream. If you feel strongly about it I can change it. \n\nI promise to use the hours I don\u0027t spend writing downstream translation code to work upstream instead ;).","commit_id":"a32589cdee371858f8cbf9fcbebe4bf09302dc02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ef31093c0a97d1deb24aeb9f56e4a325ec31d20e","unresolved":false,"context_lines":[{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def _get_completed_cleaning_command(self, task, commands):"},{"line_number":481,"context_line":"        \"\"\"Returns None or a completed cleaning command from the agent.\"\"\""},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        if not commands:"},{"line_number":484,"context_line":"            return"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_8f7f0b14","line":482,"updated":"2016-01-07 02:30:00.000000000","message":"maybe add a description for\n\n :param commands:","commit_id":"a32589cdee371858f8cbf9fcbebe4bf09302dc02"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"50f6465dfd4dcf7c14c394c9a9c62e0ef561ef13","unresolved":false,"context_lines":[{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def _get_completed_cleaning_command(self, task, commands):"},{"line_number":481,"context_line":"        \"\"\"Returns None or a completed cleaning command from the agent.\"\"\""},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        if not commands:"},{"line_number":484,"context_line":"            return"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_e7a1aaaa","line":482,"in_reply_to":"fa69d971_8f7f0b14","updated":"2016-02-10 23:49:08.000000000","message":"Done","commit_id":"a32589cdee371858f8cbf9fcbebe4bf09302dc02"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"74c112ae903b2ac3eace2267869c998e9ea85f6c","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            # Node finished a cleaning step that requested a reboot, and"},{"line_number":242,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":243,"context_line":"            info \u003d task.node.driver_internal_info"},{"line_number":244,"context_line":"            info.pop(\u0027cleaning_reboot\u0027)"},{"line_number":245,"context_line":"            task.node.driver_internal_info \u003d info"},{"line_number":246,"context_line":"            self.notify_conductor_resume_clean(task)"},{"line_number":247,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a57f1b5_d95d6a7a","line":244,"range":{"start_line":244,"start_character":12,"end_line":244,"end_character":39},"updated":"2016-02-11 05:53:10.000000000","message":"Though it does not looks like it could get KeyError, may be for safety it could be:\ninfo.pop(\u0027cleaning_reboot\u0027, None)","commit_id":"187e1c39f07ecfddd8ae908d4ce8d8c422853e86"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2dfec9097aa80b625ad9c3a56458d21d221ce1d8","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            # Node finished a cleaning step that requested a reboot, and"},{"line_number":242,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":243,"context_line":"            info \u003d task.node.driver_internal_info"},{"line_number":244,"context_line":"            info.pop(\u0027cleaning_reboot\u0027)"},{"line_number":245,"context_line":"            task.node.driver_internal_info \u003d info"},{"line_number":246,"context_line":"            self.notify_conductor_resume_clean(task)"},{"line_number":247,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a57f1b5_7de43be0","line":244,"range":{"start_line":244,"start_character":12,"end_line":244,"end_character":39},"in_reply_to":"3a57f1b5_d95d6a7a","updated":"2016-02-11 17:19:45.000000000","message":"Done","commit_id":"187e1c39f07ecfddd8ae908d4ce8d8c422853e86"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"68ea4bd8ebc53060a1ef0d4fc4ef0e9684b439f5","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            info \u003d task.node.driver_internal_info"},{"line_number":244,"context_line":"            info.pop(\u0027cleaning_reboot\u0027)"},{"line_number":245,"context_line":"            task.node.driver_internal_info \u003d info"},{"line_number":246,"context_line":"            self.notify_conductor_resume_clean(task)"},{"line_number":247,"context_line":"            return"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        command \u003d self._get_completed_cleaning_command(task, agent_commands)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a57f1b5_14674726","line":246,"updated":"2016-02-11 06:21:31.000000000","message":"Let\u0027s consider the following situation: agent not started after reboot because bad FW used for update. Cleaning aborted and FW restored manually. \u0027cleaning_reboot\u0027 not deleted. Wrong notify_conductor_resume_clean() call can be executed here when node switched to cleaning state again.","commit_id":"187e1c39f07ecfddd8ae908d4ce8d8c422853e86"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2dfec9097aa80b625ad9c3a56458d21d221ce1d8","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            info \u003d task.node.driver_internal_info"},{"line_number":244,"context_line":"            info.pop(\u0027cleaning_reboot\u0027)"},{"line_number":245,"context_line":"            task.node.driver_internal_info \u003d info"},{"line_number":246,"context_line":"            self.notify_conductor_resume_clean(task)"},{"line_number":247,"context_line":"            return"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        command \u003d self._get_completed_cleaning_command(task, agent_commands)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a57f1b5_5ddfff0c","line":246,"in_reply_to":"3a57f1b5_14674726","updated":"2016-02-11 17:19:45.000000000","message":"So we should make sure that when cleaning fails, we pull the cleaning_reboot attribute off internal_driver_info if it exists?\n\nThis actually explains some behavior I\u0027ve seen downstream where sometimes a node that failed cleaning will immediately reboot upon starting cleaning and sometimes won\u0027t. I\u0027ll look into how to solve for this case. LMK if you have any suggestions better than what I noted above.","commit_id":"187e1c39f07ecfddd8ae908d4ce8d8c422853e86"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"52a4913b32ef5e4329d9a66f0a46697049d4f59c","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        :param task: a TaskManager instance"},{"line_number":367,"context_line":"        \"\"\""},{"line_number":368,"context_line":"        try:"},{"line_number":369,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":370,"context_line":"        except Exception as e:"},{"line_number":371,"context_line":"            manager_utils.cleaning_error_handler(task, e)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a57f1b5_e4baf6bf","line":368,"updated":"2016-02-11 09:14:29.000000000","message":"If in-band updating of system BIOS has been done by agent probably settings cleared to defaults and boot order changed. Maybe also set boot_devices.PXE here again?","commit_id":"187e1c39f07ecfddd8ae908d4ce8d8c422853e86"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"af2a357bfaaba3076305e78815a20e95804d4ed1","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        it returns CLEAN_VERSION_MISMATCH. For automated cleaning, we restart"},{"line_number":291,"context_line":"        the entire cleaning cycle. For manual cleaning, we don\u0027t."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        Additionally, if a clean_step includes the reboot_requested property"},{"line_number":294,"context_line":"        set to True, this method will coordinate the reboot once the step is"},{"line_number":295,"context_line":"        completed."},{"line_number":296,"context_line":"        \"\"\""},{"line_number":297,"context_line":"        node \u003d task.node"},{"line_number":298,"context_line":"        # For manual clean, the target provision state is MANAGEABLE, whereas"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_8773f714","line":295,"range":{"start_line":293,"start_character":0,"end_line":295,"end_character":18},"updated":"2016-03-28 06:38:33.000000000","message":"We need a doc for users to list clean_step or args we can pass with. I know they are vendor specfic, but at least for such a property is useful, I don\u0027t think users will read the code","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f79a54ee4eae73714a0e65eb39f701d1aef43fb4","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        it returns CLEAN_VERSION_MISMATCH. For automated cleaning, we restart"},{"line_number":291,"context_line":"        the entire cleaning cycle. For manual cleaning, we don\u0027t."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        Additionally, if a clean_step includes the reboot_requested property"},{"line_number":294,"context_line":"        set to True, this method will coordinate the reboot once the step is"},{"line_number":295,"context_line":"        completed."},{"line_number":296,"context_line":"        \"\"\""},{"line_number":297,"context_line":"        node \u003d task.node"},{"line_number":298,"context_line":"        # For manual clean, the target provision state is MANAGEABLE, whereas"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_cdbba974","line":295,"range":{"start_line":293,"start_character":0,"end_line":295,"end_character":18},"in_reply_to":"ba0121b8_27e4040c","updated":"2016-03-28 17:41:56.000000000","message":"Hilariously, it\u0027s already documented as working despite it not working: http://docs.openstack.org/developer/ironic-python-agent/#custom-hardwaremanagers-and-cleaning","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bd7e54acb5cf96b44f2b6ab1d24aa8cc869eaadf","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        it returns CLEAN_VERSION_MISMATCH. For automated cleaning, we restart"},{"line_number":291,"context_line":"        the entire cleaning cycle. For manual cleaning, we don\u0027t."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        Additionally, if a clean_step includes the reboot_requested property"},{"line_number":294,"context_line":"        set to True, this method will coordinate the reboot once the step is"},{"line_number":295,"context_line":"        completed."},{"line_number":296,"context_line":"        \"\"\""},{"line_number":297,"context_line":"        node \u003d task.node"},{"line_number":298,"context_line":"        # For manual clean, the target provision state is MANAGEABLE, whereas"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_27e4040c","line":295,"range":{"start_line":293,"start_character":0,"end_line":295,"end_character":18},"in_reply_to":"da0c15f0_8773f714","updated":"2016-03-28 17:19:09.000000000","message":"+1 this is a good point, will add docs. Most docs for custom in-band steps are in IPA, I\u0027ll add the docs there.","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"98a73ff9d051e3477286431f750422211cbf18f2","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if (not agent_commands and"},{"line_number":304,"context_line":"            task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):"},{"line_number":305,"context_line":"            # Node finished a cleaning step that requested a reboot, and"},{"line_number":306,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":307,"context_line":"            info \u003d task.node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_b76dbf34","line":304,"updated":"2016-03-25 14:27:10.000000000","message":"If you push another, could you indent this further for readability? :)","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bd7e54acb5cf96b44f2b6ab1d24aa8cc869eaadf","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if (not agent_commands and"},{"line_number":304,"context_line":"            task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):"},{"line_number":305,"context_line":"            # Node finished a cleaning step that requested a reboot, and"},{"line_number":306,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":307,"context_line":"            info \u003d task.node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_b2e170d3","line":304,"in_reply_to":"da0c15f0_07ec078e","updated":"2016-03-28 17:19:09.000000000","message":"Done","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"af2a357bfaaba3076305e78815a20e95804d4ed1","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if (not agent_commands and"},{"line_number":304,"context_line":"            task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):"},{"line_number":305,"context_line":"            # Node finished a cleaning step that requested a reboot, and"},{"line_number":306,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":307,"context_line":"            info \u003d task.node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_07ec078e","line":304,"in_reply_to":"da0c15f0_b76dbf34","updated":"2016-03-28 06:38:33.000000000","message":"+1","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6b752526a52a7691b58db806ea4e9f855a23daf7","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                                   \u0027step\u0027: node.clean_step,"},{"line_number":317,"context_line":"                                   \u0027command\u0027: command})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if not command:"},{"line_number":320,"context_line":"            # Command is not done yet"},{"line_number":321,"context_line":"            return"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if command.get(\u0027command_status\u0027) \u003d\u003d \u0027FAILED\u0027:"},{"line_number":324,"context_line":"            msg \u003d (_(\u0027Agent returned error for clean step %(step)s on node \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_44a47d56","line":321,"range":{"start_line":319,"start_character":8,"end_line":321,"end_character":18},"updated":"2016-03-25 08:29:15.000000000","message":"this should be moved before L313, if not agent_commands and no \u0027cleaning_reboot\u0027, we can just return, there\u0027s no need to call _get_completed_cleaning_command() any more.","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6ed64daaccb94730f186e70cd39d99f0b76f494c","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                                   \u0027step\u0027: node.clean_step,"},{"line_number":317,"context_line":"                                   \u0027command\u0027: command})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if not command:"},{"line_number":320,"context_line":"            # Command is not done yet"},{"line_number":321,"context_line":"            return"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if command.get(\u0027command_status\u0027) \u003d\u003d \u0027FAILED\u0027:"},{"line_number":324,"context_line":"            msg \u003d (_(\u0027Agent returned error for clean step %(step)s on node \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_67f51eca","line":321,"range":{"start_line":319,"start_character":8,"end_line":321,"end_character":18},"in_reply_to":"da0c15f0_179aab14","updated":"2016-03-26 01:51:59.000000000","message":"ok Jim, but if the author push another patch, I think we can remove the check at the beginning of _get_completed_cleaning_command to keep it clean, and saving one extra method call.","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"98a73ff9d051e3477286431f750422211cbf18f2","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                                   \u0027step\u0027: node.clean_step,"},{"line_number":317,"context_line":"                                   \u0027command\u0027: command})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if not command:"},{"line_number":320,"context_line":"            # Command is not done yet"},{"line_number":321,"context_line":"            return"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if command.get(\u0027command_status\u0027) \u003d\u003d \u0027FAILED\u0027:"},{"line_number":324,"context_line":"            msg \u003d (_(\u0027Agent returned error for clean step %(step)s on node \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_179aab14","line":321,"range":{"start_line":319,"start_character":8,"end_line":321,"end_character":18},"in_reply_to":"da0c15f0_44a47d56","updated":"2016-03-25 14:27:10.000000000","message":"_get_completed_cleaning_command already has that short-circuit at the beginning, I think it\u0027s probably fine as-is. (just one extra method call that returns immediately)","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bd7e54acb5cf96b44f2b6ab1d24aa8cc869eaadf","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                                   \u0027step\u0027: node.clean_step,"},{"line_number":317,"context_line":"                                   \u0027command\u0027: command})"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        if not command:"},{"line_number":320,"context_line":"            # Command is not done yet"},{"line_number":321,"context_line":"            return"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if command.get(\u0027command_status\u0027) \u003d\u003d \u0027FAILED\u0027:"},{"line_number":324,"context_line":"            msg \u003d (_(\u0027Agent returned error for clean step %(step)s on node \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_d2dce41a","line":321,"range":{"start_line":319,"start_character":8,"end_line":321,"end_character":18},"in_reply_to":"da0c15f0_67f51eca","updated":"2016-03-28 17:19:09.000000000","message":"Done","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b0180df3a9c006ba029cf519ac131d9777ea112d","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        try:"},{"line_number":422,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":423,"context_line":"        except Exception as e:"},{"line_number":424,"context_line":"            manager_utils.cleaning_error_handler(task, e)"},{"line_number":425,"context_line":"            # do not set cleaning_reboot if we didn\u0027t reboot"},{"line_number":426,"context_line":"            return"},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_f650be0c","line":424,"range":{"start_line":424,"start_character":12,"end_line":424,"end_character":57},"updated":"2016-03-26 12:13:44.000000000","message":"This would give a message related to power action on the node. The message should also indicate actual reason for power action. Probably linking clean step with power action in the message could be useful.\n\nEx:\n...\nexcept Exception as e:\n    msg \u003d (_(\u0027Reboot requested by clean step %(step)s \u0027\n             \u0027failed for node %(node)s: %(err)s\u0027) % \n             { \u0027step\u0027: node.clean_step,\n               \u0027node\u0027: node.uuid,\n               \u0027err\u0027: e })\n    LOG.error(msg)\n    # do not set cleaning_reboot if we didn\u0027t reboot\n    return manager_utils.cleaning_error_handler(task, msg)","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"bd7e54acb5cf96b44f2b6ab1d24aa8cc869eaadf","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        try:"},{"line_number":422,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":423,"context_line":"        except Exception as e:"},{"line_number":424,"context_line":"            manager_utils.cleaning_error_handler(task, e)"},{"line_number":425,"context_line":"            # do not set cleaning_reboot if we didn\u0027t reboot"},{"line_number":426,"context_line":"            return"},{"line_number":427,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba0121b8_92c42c41","line":424,"range":{"start_line":424,"start_character":12,"end_line":424,"end_character":57},"in_reply_to":"da0c15f0_f650be0c","updated":"2016-03-28 17:19:09.000000000","message":"Done","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c926190289ae57c5c4820ea0945aea2a8afcaff9","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                         fetched with agent_client.get_commands_status()"},{"line_number":600,"context_line":"        \"\"\""},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        last_command \u003d commands[-1]"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        if last_command[\u0027command_name\u0027] !\u003d \u0027execute_clean_step\u0027:"},{"line_number":605,"context_line":"            # catches race condition where execute_clean_step is still"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_3510a74e","line":602,"updated":"2016-03-28 18:28:08.000000000","message":"I feel like we should still have the short circuit here, so that it isn\u0027t called without commands, else we\u0027ll end up with an IndexError.","commit_id":"a9b029cb4a92f143212cf2edfcefcbc8fb979493"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"f25795e1762b61297c919857c584deea905e5e7c","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        manual_clean \u003d node.target_provision_state \u003d\u003d states.MANAGEABLE"},{"line_number":301,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if (not agent_commands and"},{"line_number":304,"context_line":"                task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):"},{"line_number":305,"context_line":"            # Node finished a cleaning step that requested a reboot, and"},{"line_number":306,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":307,"context_line":"            info \u003d task.node.driver_internal_info"},{"line_number":308,"context_line":"            info.pop(\u0027cleaning_reboot\u0027, None)"},{"line_number":309,"context_line":"            task.node.driver_internal_info \u003d info"},{"line_number":310,"context_line":"            self.notify_conductor_resume_clean(task)"},{"line_number":311,"context_line":"            return"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if not agent_commands:"},{"line_number":314,"context_line":"            # Agent has no commands whatsoever"},{"line_number":315,"context_line":"            return"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        command \u003d self._get_completed_cleaning_command(task, agent_commands)"},{"line_number":318,"context_line":"        LOG.debug(\u0027Cleaning command status for node %(node)s on step %(step)s:\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_bf76493c","line":315,"range":{"start_line":303,"start_character":0,"end_line":315,"end_character":18},"updated":"2016-03-29 02:29:38.000000000","message":"What about have this two together to improve code readability further?\nif not agent_commands:\n   if task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027):\n      # Node finished a cleaning step that requested a reboot, and\n      # this is the first heartbeat after booting. Continue cleaning.\n      ...\n   else:\n     # Agent has no commands whatsoever\n     return","commit_id":"bf985bcdd94f953b7d72a2c28481cb2f3ff50508"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fbad57ddb81c1d4ed728697106764f5cd90657dd","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        manual_clean \u003d node.target_provision_state \u003d\u003d states.MANAGEABLE"},{"line_number":301,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if (not agent_commands and"},{"line_number":304,"context_line":"                task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):"},{"line_number":305,"context_line":"            # Node finished a cleaning step that requested a reboot, and"},{"line_number":306,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":307,"context_line":"            info \u003d task.node.driver_internal_info"},{"line_number":308,"context_line":"            info.pop(\u0027cleaning_reboot\u0027, None)"},{"line_number":309,"context_line":"            task.node.driver_internal_info \u003d info"},{"line_number":310,"context_line":"            self.notify_conductor_resume_clean(task)"},{"line_number":311,"context_line":"            return"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if not agent_commands:"},{"line_number":314,"context_line":"            # Agent has no commands whatsoever"},{"line_number":315,"context_line":"            return"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        command \u003d self._get_completed_cleaning_command(task, agent_commands)"},{"line_number":318,"context_line":"        LOG.debug(\u0027Cleaning command status for node %(node)s on step %(step)s:\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_9ce68513","line":315,"range":{"start_line":303,"start_character":0,"end_line":315,"end_character":18},"in_reply_to":"ba0121b8_23568329","updated":"2016-03-30 16:02:07.000000000","message":"Agreed it would be a bit more readable","commit_id":"bf985bcdd94f953b7d72a2c28481cb2f3ff50508"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7027f47616ddf366a394899737ae74c7958fc296","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        manual_clean \u003d node.target_provision_state \u003d\u003d states.MANAGEABLE"},{"line_number":301,"context_line":"        agent_commands \u003d self._client.get_commands_status(task.node)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if (not agent_commands and"},{"line_number":304,"context_line":"                task.node.driver_internal_info.get(\u0027cleaning_reboot\u0027)):"},{"line_number":305,"context_line":"            # Node finished a cleaning step that requested a reboot, and"},{"line_number":306,"context_line":"            # this is the first heartbeat after booting. Continue cleaning."},{"line_number":307,"context_line":"            info \u003d task.node.driver_internal_info"},{"line_number":308,"context_line":"            info.pop(\u0027cleaning_reboot\u0027, None)"},{"line_number":309,"context_line":"            task.node.driver_internal_info \u003d info"},{"line_number":310,"context_line":"            self.notify_conductor_resume_clean(task)"},{"line_number":311,"context_line":"            return"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if not agent_commands:"},{"line_number":314,"context_line":"            # Agent has no commands whatsoever"},{"line_number":315,"context_line":"            return"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        command \u003d self._get_completed_cleaning_command(task, agent_commands)"},{"line_number":318,"context_line":"        LOG.debug(\u0027Cleaning command status for node %(node)s on step %(step)s:\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_23568329","line":315,"range":{"start_line":303,"start_character":0,"end_line":315,"end_character":18},"in_reply_to":"ba0121b8_bf76493c","updated":"2016-03-29 15:21:06.000000000","message":"This is a good idea and I\u0027ll push it if we need another patchset.","commit_id":"bf985bcdd94f953b7d72a2c28481cb2f3ff50508"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"c891a90b1834e875fd0e0c377ba3f28695bfef81","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        :param commands: a set of command results from the agent, typically"},{"line_number":599,"context_line":"                         fetched with agent_client.get_commands_status()"},{"line_number":600,"context_line":"        \"\"\""},{"line_number":601,"context_line":"        if not commands:"},{"line_number":602,"context_line":"            return"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        last_command \u003d commands[-1]"},{"line_number":605,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_31826d53","line":602,"range":{"start_line":601,"start_character":7,"end_line":602,"end_character":18},"updated":"2016-03-29 02:48:10.000000000","message":"seems this can be removed now, as you already checked it before calling this method, and I don\u0027t see this method called by others, but I think it\u0027s fine as is.","commit_id":"bf985bcdd94f953b7d72a2c28481cb2f3ff50508"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7027f47616ddf366a394899737ae74c7958fc296","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        :param commands: a set of command results from the agent, typically"},{"line_number":599,"context_line":"                         fetched with agent_client.get_commands_status()"},{"line_number":600,"context_line":"        \"\"\""},{"line_number":601,"context_line":"        if not commands:"},{"line_number":602,"context_line":"            return"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        last_command \u003d commands[-1]"},{"line_number":605,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_631d1b73","line":602,"range":{"start_line":601,"start_character":7,"end_line":602,"end_character":18},"in_reply_to":"ba0121b8_31826d53","updated":"2016-03-29 15:21:06.000000000","message":"I readded it at Jim\u0027s request; we\u0027d rather the method be robust against IndexErrors in line 604 :)","commit_id":"bf985bcdd94f953b7d72a2c28481cb2f3ff50508"}],"ironic/tests/unit/drivers/modules/test_agent_base_vendor.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"74c112ae903b2ac3eace2267869c998e9ea85f6c","unresolved":false,"context_lines":[{"line_number":839,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":840,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":841,"context_line":"            self.passthru.continue_cleaning(task)"},{"line_number":842,"context_line":"            notify_mock.assert_called_once_with(mock.ANY, task)"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"    @mock.patch.object(agent_base_vendor,"},{"line_number":845,"context_line":"                       \u0027_get_post_clean_step_hook\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a57f1b5_394fdebe","line":842,"range":{"start_line":842,"start_character":12,"end_line":842,"end_character":63},"updated":"2016-02-11 05:53:10.000000000","message":"Add a statement to validate \u0027cleaning_reboot\u0027 is popped.\nself.assertNotIn(\u0027cleaning_reboot\u0027,                          task.node.driver_internal_info)","commit_id":"187e1c39f07ecfddd8ae908d4ce8d8c422853e86"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2dfec9097aa80b625ad9c3a56458d21d221ce1d8","unresolved":false,"context_lines":[{"line_number":839,"context_line":"        with task_manager.acquire(self.context, self.node[\u0027uuid\u0027],"},{"line_number":840,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":841,"context_line":"            self.passthru.continue_cleaning(task)"},{"line_number":842,"context_line":"            notify_mock.assert_called_once_with(mock.ANY, task)"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"    @mock.patch.object(agent_base_vendor,"},{"line_number":845,"context_line":"                       \u0027_get_post_clean_step_hook\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a57f1b5_1db2e706","line":842,"range":{"start_line":842,"start_character":12,"end_line":842,"end_character":63},"in_reply_to":"3a57f1b5_394fdebe","updated":"2016-02-11 17:19:45.000000000","message":"Done","commit_id":"187e1c39f07ecfddd8ae908d4ce8d8c422853e86"}],"releasenotes/notes/agent-can-request-reboot-6238e13e2e898f68.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"98a73ff9d051e3477286431f750422211cbf18f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"    - This adds the reboot_requested option that for"},{"line_number":4,"context_line":"      in-band cleaning. If set to true, Ironic will reboot"},{"line_number":5,"context_line":"      the node after that step has completed and before"},{"line_number":6,"context_line":"      continuing with the next step. This option is useful"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"da0c15f0_b70c9f43","line":3,"updated":"2016-03-25 14:27:10.000000000","message":"Nit: s/that//","commit_id":"ec1c44dae48c0d804b13fec29605a67298a4fdbe"}],"releasenotes/notes/support-reboot-requested-for-agent-driver.yaml":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ec50145384b1b897e1deb86a0c831df8f2a44708","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Clean steps defined in the agent can now specify \u0027reboot_requested\u0027: True"},{"line_number":4,"context_line":"    to have the node rebooted before continuing on with the next steps. This"},{"line_number":5,"context_line":"    behavior has been documented, but was remained unimplemented until now."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa69d971_18323511","line":3,"range":{"start_line":3,"start_character":71,"end_line":3,"end_character":72},"updated":"2015-12-31 19:57:28.000000000","message":"I think this : may be messing up formatting somehow.","commit_id":"c29111e64ad375565509836dcb7ccbeda67032d3"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"47a7c44729edf6d0f246246b5365996eccac90df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \"Clean steps defined in the agent can now"},{"line_number":4,"context_line":"    specify a bool, reboot_requested. If true,"},{"line_number":5,"context_line":"    the node will be rebooted out of band"},{"line_number":6,"context_line":"    before continuing with the next step.\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa69d971_ca57ca00","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":5},"updated":"2016-01-04 04:53:15.000000000","message":"I think quotes \u0027\" \"\u0027 are not required.","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"97843da5593f0395a23a09264440da4a67a7c091","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \"Clean steps defined in the agent can now"},{"line_number":4,"context_line":"    specify a bool, reboot_requested. If true,"},{"line_number":5,"context_line":"    the node will be rebooted out of band"},{"line_number":6,"context_line":"    before continuing with the next step.\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa69d971_58c35bed","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":5},"in_reply_to":"fa69d971_48743767","updated":"2016-01-05 22:42:05.000000000","message":"Redid this properly; also Lucas should\u0027ve answered your question and made it more clear with my edits.","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dc2434a90f0f7d153aeb69be395626bc34271f15","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \"Clean steps defined in the agent can now"},{"line_number":4,"context_line":"    specify a bool, reboot_requested. If true,"},{"line_number":5,"context_line":"    the node will be rebooted out of band"},{"line_number":6,"context_line":"    before continuing with the next step.\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa69d971_dde1cbd1","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":5},"in_reply_to":"fa69d971_ca57ca00","updated":"2016-01-04 12:03:02.000000000","message":"quick q, \"defined in the agent\" means only in-band clean steps?\n\n(also agree about the quotes)","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6d027524d0b9fe9f323266a59d01935f7ce1464a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - \"Clean steps defined in the agent can now"},{"line_number":4,"context_line":"    specify a bool, reboot_requested. If true,"},{"line_number":5,"context_line":"    the node will be rebooted out of band"},{"line_number":6,"context_line":"    before continuing with the next step.\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa69d971_48743767","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":5},"in_reply_to":"fa69d971_dde1cbd1","updated":"2016-01-04 12:13:35.000000000","message":"And one more thing regarding this note - if generated with reno, it should end with random substring (e.g. add-ipv6-pxe-support-8fb51c355cc977c4). Generation should be done with \"reno new \u003cfilename\u003e\"","commit_id":"cbf38c35b64178957ab5ee4251476bd659cdf16f"}]}
