)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"c6f530afe099f8aa25687758314b2424e2db191f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Activate iLO license as part of manual cleaning process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added ``activate_licnese`` method to iLO management interface"},{"line_number":10,"context_line":"to support activation of iLO license as part of manual cleaning."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9af33a9455a5e0d5280e31c9e1f20778ce022437"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_5c54cffc","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":24},"updated":"2016-01-11 03:28:36.000000000","message":"you might need to change the commit msg to remove the name of the method added. Adding the functionality to the commit would make sense.","commit_id":"9bde6ed408faaa49953026aa95f4b87112b70633"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2c5de8d54b83ec570f9f2f968c95acac6726ea01","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9af33a9455a5e0d5280e31c9e1f20778ce022437"},{"line_number":13,"context_line":"Closes-Bug: #1526218"},{"line_number":14,"context_line":"Co-Authored-By: Ankit Kumar \u003cankit.dhn31@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_626fd892","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":27},"updated":"2016-01-13 14:10:48.000000000","message":"Add \u0027Depends-On: I0e34407133684e34c4ab9446b3521a24f3038f92\u0027\nThis depends on manual cleaning API","commit_id":"85f981cbd09c02ce1b13076f06a1cfcc63e68555"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Debayan Ray \u003cdebayan.ray@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-28 22:32:13 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Activate iLO license as part of manual cleaning process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a method to iLO management interface for supporting"},{"line_number":10,"context_line":"activation of iLO license as a part of manual cleaning."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9aed3d3a_cae024fd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":55},"updated":"2016-02-29 14:24:53.000000000","message":"Since this change applies only to iLO drivers, it may be better to mention it. Ex:\n\n\"Add clean step in iLO drivers to activate iLO license\"","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Debayan Ray \u003cdebayan.ray@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-28 22:32:13 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Activate iLO license as part of manual cleaning process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a method to iLO management interface for supporting"},{"line_number":10,"context_line":"activation of iLO license as a part of manual cleaning."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9aed3d3a_3c90cd94","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":55},"in_reply_to":"9aed3d3a_cae024fd","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-02-28 22:32:13 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Activate iLO license as part of manual cleaning process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a method to iLO management interface for supporting"},{"line_number":10,"context_line":"activation of iLO license as a part of manual cleaning."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1526218"},{"line_number":13,"context_line":"Depends-On: I0e34407133684e34c4ab9446b3521a24f3038f92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9aed3d3a_2a4ef03a","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":54},"updated":"2016-02-29 14:24:53.000000000","message":"There is no new method added to IloManagement. I think you meant to say \u0027Added a manual clean step for supporting activation of iLO license\u0027.","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-02-28 22:32:13 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Activate iLO license as part of manual cleaning process"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a method to iLO management interface for supporting"},{"line_number":10,"context_line":"activation of iLO license as a part of manual cleaning."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1526218"},{"line_number":13,"context_line":"Depends-On: I0e34407133684e34c4ab9446b3521a24f3038f92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9aed3d3a_5cd6714f","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":54},"in_reply_to":"9aed3d3a_2a4ef03a","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"}],"doc/source/drivers/ilo.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aff3749d151a2d365486fc8869880e73368b78f1","unresolved":false,"context_lines":[{"line_number":723,"context_line":"  -``reset_ilo``:"},{"line_number":724,"context_line":"    Resets the iLO. By default, enabled with priority 1."},{"line_number":725,"context_line":"  -``reset_bios_to_default``:"},{"line_number":726,"context_line":"    Resets system ROM sttings to default. By default, enabled with priority 10."},{"line_number":727,"context_line":"    This clean step is supported only on Gen9 and above servers."},{"line_number":728,"context_line":"  -``reset_secure_boot_keys_to_default``:"},{"line_number":729,"context_line":"    Resets secure boot keys to manufacturer\u0027s defaults. This step is supported"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_45f08ec9","line":726,"range":{"start_line":726,"start_character":22,"end_line":726,"end_character":29},"updated":"2016-03-03 06:37:08.000000000","message":"nit: s/sttings/settings","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"c7888a387f48e2cd630ad86f0794c6989a059b3b","unresolved":false,"context_lines":[{"line_number":723,"context_line":"  -``reset_ilo``:"},{"line_number":724,"context_line":"    Resets the iLO. By default, enabled with priority 1."},{"line_number":725,"context_line":"  -``reset_bios_to_default``:"},{"line_number":726,"context_line":"    Resets system ROM sttings to default. By default, enabled with priority 10."},{"line_number":727,"context_line":"    This clean step is supported only on Gen9 and above servers."},{"line_number":728,"context_line":"  -``reset_secure_boot_keys_to_default``:"},{"line_number":729,"context_line":"    Resets secure boot keys to manufacturer\u0027s defaults. This step is supported"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_5c2ea4a5","line":726,"range":{"start_line":726,"start_character":22,"end_line":726,"end_character":29},"in_reply_to":"7af24918_45f08ec9","updated":"2016-03-03 10:12:11.000000000","message":"Done","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aff3749d151a2d365486fc8869880e73368b78f1","unresolved":false,"context_lines":[{"line_number":770,"context_line":"    on usage."},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"* iLO with firmware version 1.5 is minimally required to support all the"},{"line_number":773,"context_line":"  operations."},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"For more information on node manual cleaning, see :ref:`manual_cleaning`"},{"line_number":776,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_8591f649","line":773,"range":{"start_line":773,"start_character":1,"end_line":773,"end_character":13},"updated":"2016-03-03 06:37:08.000000000","message":"Also add a note that this operation cannot be performed using virtual media based drivers like iscsi_ilo and agent_ilo as they need this license in \u0027active\u0027 state to use virtual media to boot into to start cleaning operation. Virtual media is an advanced feature.","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"c7888a387f48e2cd630ad86f0794c6989a059b3b","unresolved":false,"context_lines":[{"line_number":770,"context_line":"    on usage."},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"* iLO with firmware version 1.5 is minimally required to support all the"},{"line_number":773,"context_line":"  operations."},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"For more information on node manual cleaning, see :ref:`manual_cleaning`"},{"line_number":776,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_3719317a","line":773,"range":{"start_line":773,"start_character":1,"end_line":773,"end_character":13},"in_reply_to":"7af24918_8591f649","updated":"2016-03-03 10:12:11.000000000","message":"Done. Please check.","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aff3749d151a2d365486fc8869880e73368b78f1","unresolved":false,"context_lines":[{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"Activating iLO Advanced license as manual clean step"},{"line_number":1230,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1231,"context_line":"iLO drivers can activate the iLO Advanced License key as a manual cleaning"},{"line_number":1232,"context_line":"step. Any manual cleaning step can only be initiated when a node is in the"},{"line_number":1233,"context_line":"``manageable`` state. Once the manual cleaning is finished, the node will be"},{"line_number":1234,"context_line":"put in the ``manageable`` state again. A user can follow the starting steps in"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_d0129e56","line":1231,"range":{"start_line":1231,"start_character":42,"end_line":1231,"end_character":49},"updated":"2016-03-03 06:37:08.000000000","message":"nit: s/License/license/","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"c7888a387f48e2cd630ad86f0794c6989a059b3b","unresolved":false,"context_lines":[{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"Activating iLO Advanced license as manual clean step"},{"line_number":1230,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1231,"context_line":"iLO drivers can activate the iLO Advanced License key as a manual cleaning"},{"line_number":1232,"context_line":"step. Any manual cleaning step can only be initiated when a node is in the"},{"line_number":1233,"context_line":"``manageable`` state. Once the manual cleaning is finished, the node will be"},{"line_number":1234,"context_line":"put in the ``manageable`` state again. A user can follow the starting steps in"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_b7b701f4","line":1231,"range":{"start_line":1231,"start_character":42,"end_line":1231,"end_character":49},"in_reply_to":"7af24918_d0129e56","updated":"2016-03-03 10:12:11.000000000","message":"Done","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aff3749d151a2d365486fc8869880e73368b78f1","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"iLO drivers can activate the iLO Advanced License key as a manual cleaning"},{"line_number":1232,"context_line":"step. Any manual cleaning step can only be initiated when a node is in the"},{"line_number":1233,"context_line":"``manageable`` state. Once the manual cleaning is finished, the node will be"},{"line_number":1234,"context_line":"put in the ``manageable`` state again. A user can follow the starting steps in"},{"line_number":1235,"context_line":":ref:`manual_cleaning` to initiate a manual clean to set the node provision"},{"line_number":1236,"context_line":"state."},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"An example of a manual clean step to activate license as the only clean step"},{"line_number":1239,"context_line":"could be::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_d04a9e25","line":1236,"range":{"start_line":1234,"start_character":39,"end_line":1236,"end_character":6},"updated":"2016-03-03 06:37:08.000000000","message":"May be we can just say:\n\u0027User can follow steps from :ref:`manual_cleaning`to initiate manual cleaning operation on a node.\u0027","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"c7888a387f48e2cd630ad86f0794c6989a059b3b","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"iLO drivers can activate the iLO Advanced License key as a manual cleaning"},{"line_number":1232,"context_line":"step. Any manual cleaning step can only be initiated when a node is in the"},{"line_number":1233,"context_line":"``manageable`` state. Once the manual cleaning is finished, the node will be"},{"line_number":1234,"context_line":"put in the ``manageable`` state again. A user can follow the starting steps in"},{"line_number":1235,"context_line":":ref:`manual_cleaning` to initiate a manual clean to set the node provision"},{"line_number":1236,"context_line":"state."},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"An example of a manual clean step to activate license as the only clean step"},{"line_number":1239,"context_line":"could be::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_17cd1566","line":1236,"range":{"start_line":1234,"start_character":39,"end_line":1236,"end_character":6},"in_reply_to":"7af24918_d04a9e25","updated":"2016-03-03 10:12:11.000000000","message":"Done","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aff3749d151a2d365486fc8869880e73368b78f1","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"        }"},{"line_number":1247,"context_line":"    }]"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"* The different attributes of ``activate_license`` clean step are as follows:"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"  .. csv-table::"},{"line_number":1252,"context_line":"   :header: \"Attribute\", \"Description\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_ab0de3e9","line":1249,"range":{"start_line":1249,"start_character":0,"end_line":1249,"end_character":19},"updated":"2016-03-03 06:37:08.000000000","message":"This would cause \u0027tab\u0027 and a boolet point here in formatting, looks bit odd.","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"c7888a387f48e2cd630ad86f0794c6989a059b3b","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"        }"},{"line_number":1247,"context_line":"    }]"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"* The different attributes of ``activate_license`` clean step are as follows:"},{"line_number":1250,"context_line":""},{"line_number":1251,"context_line":"  .. csv-table::"},{"line_number":1252,"context_line":"   :header: \"Attribute\", \"Description\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_d7e56ddc","line":1249,"range":{"start_line":1249,"start_character":0,"end_line":1249,"end_character":19},"in_reply_to":"7af24918_ab0de3e9","updated":"2016-03-03 10:12:11.000000000","message":"Done","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aff3749d151a2d365486fc8869880e73368b78f1","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"   \"``interface``\", \"Interface of clean step, here ``management``\""},{"line_number":1256,"context_line":"   \"``step``\", \"Name of clean step, here ``activate_license``\""},{"line_number":1257,"context_line":"   \"``args``\", \"Keyword-argument entry (\u003cname\u003e: \u003cvalue\u003e) being passed to clean step\""},{"line_number":1258,"context_line":"   \"``args.ilo_license_key``\", \"The HPE iLO Advanced license key to activate enterprise features\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_d0dc5e75","line":1258,"range":{"start_line":1258,"start_character":5,"end_line":1258,"end_character":27},"updated":"2016-03-03 06:37:08.000000000","message":"Mention that this is a mandatory argument for this step.","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"c7888a387f48e2cd630ad86f0794c6989a059b3b","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"   \"``interface``\", \"Interface of clean step, here ``management``\""},{"line_number":1256,"context_line":"   \"``step``\", \"Name of clean step, here ``activate_license``\""},{"line_number":1257,"context_line":"   \"``args``\", \"Keyword-argument entry (\u003cname\u003e: \u003cvalue\u003e) being passed to clean step\""},{"line_number":1258,"context_line":"   \"``args.ilo_license_key``\", \"The HPE iLO Advanced license key to activate enterprise features\""}],"source_content_type":"text/x-rst","patch_set":13,"id":"7af24918_77c3b9ed","line":1258,"range":{"start_line":1258,"start_character":5,"end_line":1258,"end_character":27},"in_reply_to":"7af24918_d0dc5e75","updated":"2016-03-03 10:12:11.000000000","message":"Done","commit_id":"84706efea80d8473e5c09f8dd147071bd1c20bfc"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"10e183e22044b69920cca3396d917f2b1329b3e1","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"* The manual cleaning operations supported are:"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"  -``activate_license``:"},{"line_number":767,"context_line":"    Activates the iLO Advanced license. This is an out-of-band manual cleaning"},{"line_number":768,"context_line":"    step associated with ``management`` interface. See"},{"line_number":769,"context_line":"    `Activating iLO Advanced license as manual clean step`_ for user guidance"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_a974af67","line":766,"updated":"2016-03-03 14:54:49.000000000","message":"Nit: space between - and `","commit_id":"f224b83b10691a22ed9d26ebbeb4e1dccb9578db"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"10e183e22044b69920cca3396d917f2b1329b3e1","unresolved":false,"context_lines":[{"line_number":769,"context_line":"    `Activating iLO Advanced license as manual clean step`_ for user guidance"},{"line_number":770,"context_line":"    on usage. Please note that this operation cannot be performed using virtual"},{"line_number":771,"context_line":"    media based drivers like ``iscsi_ilo`` and ``agent_ilo`` as they need this"},{"line_number":772,"context_line":"    type of advanced license already active to use virtual media to boot into"},{"line_number":773,"context_line":"    to start cleaning operation. Virtual media is an advanced feature. If an"},{"line_number":774,"context_line":"    advanced license is already active and the user wants to overwrite the"},{"line_number":775,"context_line":"    current license key, for example in case of a multi-server activation key"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_89f8d3c4","line":772,"updated":"2016-03-03 14:54:49.000000000","message":":(\n\nThinking about this more... is this true? There\u0027s no need to boot the node to get it from enroll -\u003e manageable, and this is an OOB clean step. So a user enrolling nodes for use with vmedia drivers could enroll it, get it to manageable, run this clean step, and then clean it.\n\nOr am I missing something?","commit_id":"f224b83b10691a22ed9d26ebbeb4e1dccb9578db"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1c5cc96d8335e5e7b944ace39b323777ce71c590","unresolved":false,"context_lines":[{"line_number":769,"context_line":"    `Activating iLO Advanced license as manual clean step`_ for user guidance"},{"line_number":770,"context_line":"    on usage. Please note that this operation cannot be performed using virtual"},{"line_number":771,"context_line":"    media based drivers like ``iscsi_ilo`` and ``agent_ilo`` as they need this"},{"line_number":772,"context_line":"    type of advanced license already active to use virtual media to boot into"},{"line_number":773,"context_line":"    to start cleaning operation. Virtual media is an advanced feature. If an"},{"line_number":774,"context_line":"    advanced license is already active and the user wants to overwrite the"},{"line_number":775,"context_line":"    current license key, for example in case of a multi-server activation key"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_db0a9a89","line":772,"in_reply_to":"7af24918_89f8d3c4","updated":"2016-03-03 16:39:12.000000000","message":"Agent based drivers were doing inband cleaning. But now iscsi based drivers also perform inband cleaning when cleaning is invoked.\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L792\n\nHence both virtual meadia based drivers (agent_ilo and iscsi_ilo) perform inband cleaning and that would need virtual media to be functional.","commit_id":"f224b83b10691a22ed9d26ebbeb4e1dccb9578db"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"e98d45fffa2543d110781d97756bbeaff66dfe48","unresolved":false,"context_lines":[{"line_number":769,"context_line":"    `Activating iLO Advanced license as manual clean step`_ for user guidance"},{"line_number":770,"context_line":"    on usage. Please note that this operation cannot be performed using virtual"},{"line_number":771,"context_line":"    media based drivers like ``iscsi_ilo`` and ``agent_ilo`` as they need this"},{"line_number":772,"context_line":"    type of advanced license already active to use virtual media to boot into"},{"line_number":773,"context_line":"    to start cleaning operation. Virtual media is an advanced feature. If an"},{"line_number":774,"context_line":"    advanced license is already active and the user wants to overwrite the"},{"line_number":775,"context_line":"    current license key, for example in case of a multi-server activation key"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_a6c96eae","line":772,"in_reply_to":"7af24918_89f8d3c4","updated":"2016-03-03 17:34:50.000000000","message":"Also, manual cleaning will be go thru manageable -\u003e cleaning -\u003e wait for cleaning -\u003e manageable (coming back again). The node has to boot from to perform cleaning as I suppose there could be some manual cleaning steps (can\u0027t think of nay examples now tho, will RAID configuration be such a candidate? not sure..) which might require the node to at least boot with deploy image. Hence, the manual cleaning framework itself will make sure the node boots from deploy image and then initiate the manual cleaning steps.\nHmm.. did I understand and answer you properly? :)","commit_id":"f224b83b10691a22ed9d26ebbeb4e1dccb9578db"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"99c375eb012cec5cd334e73c4bd8d703784923f2","unresolved":false,"context_lines":[{"line_number":769,"context_line":"    `Activating iLO Advanced license as manual clean step`_ for user guidance"},{"line_number":770,"context_line":"    on usage. Please note that this operation cannot be performed using virtual"},{"line_number":771,"context_line":"    media based drivers like ``iscsi_ilo`` and ``agent_ilo`` as they need this"},{"line_number":772,"context_line":"    type of advanced license already active to use virtual media to boot into"},{"line_number":773,"context_line":"    to start cleaning operation. Virtual media is an advanced feature. If an"},{"line_number":774,"context_line":"    advanced license is already active and the user wants to overwrite the"},{"line_number":775,"context_line":"    current license key, for example in case of a multi-server activation key"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_49323da8","line":772,"in_reply_to":"7af24918_a6c96eae","updated":"2016-03-03 17:43:10.000000000","message":"Yeah, this makes sense to me now... We do need to boot the agent regardless to start manual cleaning.","commit_id":"f224b83b10691a22ed9d26ebbeb4e1dccb9578db"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4945f5db33f768983dabc5ef4667e8fd7d3f0d1a","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"   \"``interface``\", \"Interface of clean step, here ``management``\""},{"line_number":1263,"context_line":"   \"``step``\", \"Name of clean step, here ``activate_license``\""},{"line_number":1264,"context_line":"   \"``args``\", \"Keyword-argument entry (\u003cname\u003e: \u003cvalue\u003e) being passed to clean step\""},{"line_number":1265,"context_line":"   \"``args.ilo_license_key``\", \"The HPE iLO Advanced license key to activate enterprise features. This is mandatory.\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_b92c0c03","line":1265,"range":{"start_line":1265,"start_character":36,"end_line":1265,"end_character":39},"updated":"2016-03-03 12:44:57.000000000","message":"Nit: It seems a little redundant to include HPE in the statement, but I\u0027m okay regardless.","commit_id":"f224b83b10691a22ed9d26ebbeb4e1dccb9578db"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"3fb4b69e05c7c4011cce8bcb8d34214e8317db0b","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"   \"``interface``\", \"Interface of clean step, here ``management``\""},{"line_number":1263,"context_line":"   \"``step``\", \"Name of clean step, here ``activate_license``\""},{"line_number":1264,"context_line":"   \"``args``\", \"Keyword-argument entry (\u003cname\u003e: \u003cvalue\u003e) being passed to clean step\""},{"line_number":1265,"context_line":"   \"``args.ilo_license_key``\", \"The HPE iLO Advanced license key to activate enterprise features. This is mandatory.\""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_cf3dc6de","line":1265,"range":{"start_line":1265,"start_character":36,"end_line":1265,"end_character":39},"in_reply_to":"7af24918_b92c0c03","updated":"2016-03-03 12:51:57.000000000","message":"Ok. Didn\u0027t change it then.","commit_id":"f224b83b10691a22ed9d26ebbeb4e1dccb9578db"}],"ironic/drivers/modules/ilo/management.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":307,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":308,"context_line":"            \u0027description\u0027: \u0027This ilo license key to be activated.\u0027,"},{"line_number":309,"context_line":"            \u0027required\u0027: True"},{"line_number":310,"context_line":"        }"},{"line_number":311,"context_line":"    })"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_9c52badc","line":308,"range":{"start_line":308,"start_character":33,"end_line":308,"end_character":36},"updated":"2015-12-23 03:06:37.000000000","message":"s/ ilo/ iLO\n\n\u0027iLO license key to activate.\u0027","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":307,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":308,"context_line":"            \u0027description\u0027: \u0027This ilo license key to be activated.\u0027,"},{"line_number":309,"context_line":"            \u0027required\u0027: True"},{"line_number":310,"context_line":"        }"},{"line_number":311,"context_line":"    })"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_421f0408","line":308,"range":{"start_line":308,"start_character":33,"end_line":308,"end_character":36},"in_reply_to":"1a7b0d38_9c52badc","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        ilo_license_key \u003d kwargs.get(\u0027ilo_license_key\u0027)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if not ilo_license_key:"},{"line_number":322,"context_line":"            msg \u003d _LE(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":323,"context_line":"                      \"in clean step. Step \u0027activate_license\u0027 is NOT \""},{"line_number":324,"context_line":"                      \"performed on node!!\")"},{"line_number":325,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_3cb626dd","line":322,"range":{"start_line":322,"start_character":18,"end_line":322,"end_character":22},"updated":"2015-12-23 03:06:37.000000000","message":"s/ _LE/ _","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        ilo_license_key \u003d kwargs.get(\u0027ilo_license_key\u0027)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if not ilo_license_key:"},{"line_number":322,"context_line":"            msg \u003d _LE(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":323,"context_line":"                      \"in clean step. Step \u0027activate_license\u0027 is NOT \""},{"line_number":324,"context_line":"                      \"performed on node!!\")"},{"line_number":325,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_c2d9b458","line":322,"range":{"start_line":322,"start_character":18,"end_line":322,"end_character":22},"in_reply_to":"1a7b0d38_3cb626dd","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if not ilo_license_key:"},{"line_number":322,"context_line":"            msg \u003d _LE(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":323,"context_line":"                      \"in clean step. Step \u0027activate_license\u0027 is NOT \""},{"line_number":324,"context_line":"                      \"performed on node!!\")"},{"line_number":325,"context_line":"            LOG.error(msg)"},{"line_number":326,"context_line":"            raise exception.MissingParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_bc7c5621","line":323,"range":{"start_line":323,"start_character":65,"end_line":323,"end_character":68},"updated":"2015-12-23 03:06:37.000000000","message":"NOT, keep it small case.","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if not ilo_license_key:"},{"line_number":322,"context_line":"            msg \u003d _LE(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":323,"context_line":"                      \"in clean step. Step \u0027activate_license\u0027 is NOT \""},{"line_number":324,"context_line":"                      \"performed on node!!\")"},{"line_number":325,"context_line":"            LOG.error(msg)"},{"line_number":326,"context_line":"            raise exception.MissingParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_62da484d","line":323,"range":{"start_line":323,"start_character":65,"end_line":323,"end_character":68},"in_reply_to":"1a7b0d38_bc7c5621","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        if not ilo_license_key:"},{"line_number":322,"context_line":"            msg \u003d _LE(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":323,"context_line":"                      \"in clean step. Step \u0027activate_license\u0027 is NOT \""},{"line_number":324,"context_line":"                      \"performed on node!!\")"},{"line_number":325,"context_line":"            LOG.error(msg)"},{"line_number":326,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_9c739a4d","line":324,"range":{"start_line":324,"start_character":40,"end_line":324,"end_character":44},"updated":"2015-12-23 03:06:37.000000000","message":"s/!! /./\n\nAdd node uuid in the message.","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        if not ilo_license_key:"},{"line_number":322,"context_line":"            msg \u003d _LE(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":323,"context_line":"                      \"in clean step. Step \u0027activate_license\u0027 is NOT \""},{"line_number":324,"context_line":"                      \"performed on node!!\")"},{"line_number":325,"context_line":"            LOG.error(msg)"},{"line_number":326,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_82df3c39","line":324,"range":{"start_line":324,"start_character":40,"end_line":324,"end_character":44},"in_reply_to":"1a7b0d38_9c739a4d","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c634d975dafac946cdcee1a5639e6147f53e4bdc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from ironic.common import boot_devices"},{"line_number":23,"context_line":"from ironic.common import exception"},{"line_number":24,"context_line":"from ironic.common.i18n import _"},{"line_number":25,"context_line":"from ironic.common.i18n import _LE"},{"line_number":26,"context_line":"from ironic.common.i18n import _LI"},{"line_number":27,"context_line":"from ironic.common.i18n import _LW"},{"line_number":28,"context_line":"from ironic.conductor import task_manager"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_54257b06","line":25,"range":{"start_line":25,"start_character":31,"end_line":25,"end_character":34},"updated":"2016-01-11 10:32:57.000000000","message":"This is not used.","commit_id":"9bde6ed408faaa49953026aa95f4b87112b70633"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"079061c0c3bddec868c15eced8a6d6986b023f41","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":307,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":308,"context_line":"            \u0027description\u0027: \u0027iLO license key to activate.\u0027,"},{"line_number":309,"context_line":"            \u0027required\u0027: True"},{"line_number":310,"context_line":"        }"},{"line_number":311,"context_line":"    })"},{"line_number":312,"context_line":"    def activate_license(self, task, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_09a63e53","line":309,"range":{"start_line":309,"start_character":13,"end_line":309,"end_character":21},"updated":"2016-01-08 16:24:54.000000000","message":"What is the purpose of \"required\" here? I dont see it used down the code also.","commit_id":"9bde6ed408faaa49953026aa95f4b87112b70633"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c634d975dafac946cdcee1a5639e6147f53e4bdc","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":307,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":308,"context_line":"            \u0027description\u0027: \u0027iLO license key to activate.\u0027,"},{"line_number":309,"context_line":"            \u0027required\u0027: True"},{"line_number":310,"context_line":"        }"},{"line_number":311,"context_line":"    })"},{"line_number":312,"context_line":"    def activate_license(self, task, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_a57047a5","line":309,"range":{"start_line":309,"start_character":13,"end_line":309,"end_character":21},"in_reply_to":"fa69d971_09a63e53","updated":"2016-01-11 10:32:57.000000000","message":"It is to inform user that ilo_license_key is a required key for this manual step to execute.","commit_id":"9bde6ed408faaa49953026aa95f4b87112b70633"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c634d975dafac946cdcee1a5639e6147f53e4bdc","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        if not ilo_license_key:"},{"line_number":322,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":323,"context_line":"                      \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":324,"context_line":"                      \"performed on node!!\"), task.node.uuid)"},{"line_number":325,"context_line":"            LOG.error(msg)"},{"line_number":326,"context_line":"            raise exception.MissingParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_34dd67e0","line":323,"range":{"start_line":323,"start_character":23,"end_line":323,"end_character":25},"updated":"2016-01-11 10:32:57.000000000","message":"indentation is not proper.","commit_id":"9bde6ed408faaa49953026aa95f4b87112b70633"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c634d975dafac946cdcee1a5639e6147f53e4bdc","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        if not ilo_license_key:"},{"line_number":322,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":323,"context_line":"                      \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":324,"context_line":"                      \"performed on node!!\"), task.node.uuid)"},{"line_number":325,"context_line":"            LOG.error(msg)"},{"line_number":326,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_54da5be9","line":324,"range":{"start_line":324,"start_character":22,"end_line":324,"end_character":23},"updated":"2016-01-11 10:32:57.000000000","message":"ditto.","commit_id":"9bde6ed408faaa49953026aa95f4b87112b70633"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1771c8bfdb154d6394400c1767a03d75e5f8a097","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":306,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":307,"context_line":"            \u0027description\u0027: \u0027iLO license key to activate.\u0027,"},{"line_number":308,"context_line":"            \u0027required\u0027: True"},{"line_number":309,"context_line":"        }"},{"line_number":310,"context_line":"    })"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_3f3d44c4","line":307,"range":{"start_line":307,"start_character":39,"end_line":307,"end_character":40},"updated":"2016-01-14 10:10:05.000000000","message":"I feel the description needs to be more indicative of the argument information. whether its a string, may be example of the format of the license key string there in the description would be more helpful to the user.","commit_id":"85f981cbd09c02ce1b13076f06a1cfcc63e68555"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1771c8bfdb154d6394400c1767a03d75e5f8a097","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        if not ilo_license_key:"},{"line_number":321,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":322,"context_line":"                     \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":323,"context_line":"                     \"performed on node!!\"), task.node.uuid)"},{"line_number":324,"context_line":"            LOG.error(msg)"},{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_9ff6b0f7","line":323,"range":{"start_line":323,"start_character":55,"end_line":323,"end_character":59},"updated":"2016-01-14 10:10:05.000000000","message":"no any placeholder for ``task.node.uuid`` in the log msg.","commit_id":"85f981cbd09c02ce1b13076f06a1cfcc63e68555"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1771c8bfdb154d6394400c1767a03d75e5f8a097","unresolved":false,"context_lines":[{"line_number":324,"context_line":"            LOG.error(msg)"},{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return _execute_ilo_clean_step("},{"line_number":328,"context_line":"            task.node, \u0027activate_license\u0027, ilo_license_key)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_843985f4","line":327,"range":{"start_line":327,"start_character":8,"end_line":327,"end_character":14},"updated":"2016-01-14 10:10:05.000000000","message":"Some more informative logging statements would help in case of debugging.","commit_id":"85f981cbd09c02ce1b13076f06a1cfcc63e68555"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d878e14941e19c3217c38968eb3db0967d99b4b6","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        if not ilo_license_key:"},{"line_number":321,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":322,"context_line":"                     \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":323,"context_line":"                     \"performed on node!!\"), task.node.uuid)"},{"line_number":324,"context_line":"            LOG.error(msg)"},{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_63aff594","line":323,"range":{"start_line":323,"start_character":35,"end_line":323,"end_character":41},"updated":"2016-02-25 09:33:32.000000000","message":"s/ \u0027!!\u0027/ ./","commit_id":"0c722e344091e5ef02f5cdd20a12e6efc918d988"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d878e14941e19c3217c38968eb3db0967d99b4b6","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        if not ilo_license_key:"},{"line_number":321,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":322,"context_line":"                     \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":323,"context_line":"                     \"performed on node!!\"), task.node.uuid)"},{"line_number":324,"context_line":"            LOG.error(msg)"},{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_e372e548","line":323,"range":{"start_line":323,"start_character":45,"end_line":323,"end_character":59},"updated":"2016-02-25 09:33:32.000000000","message":"task.node.uuid is not used in the message. Should use it.","commit_id":"0c722e344091e5ef02f5cdd20a12e6efc918d988"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"3abd1216e9e118c6eb7b9f9439fd36128139b17b","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        if not ilo_license_key:"},{"line_number":321,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":322,"context_line":"                     \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":323,"context_line":"                     \"performed on node!!\"), task.node.uuid)"},{"line_number":324,"context_line":"            LOG.error(msg)"},{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_09050d13","line":323,"range":{"start_line":323,"start_character":35,"end_line":323,"end_character":41},"in_reply_to":"bae84128_63aff594","updated":"2016-02-29 06:17:57.000000000","message":"Done","commit_id":"0c722e344091e5ef02f5cdd20a12e6efc918d988"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"3abd1216e9e118c6eb7b9f9439fd36128139b17b","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        if not ilo_license_key:"},{"line_number":321,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":322,"context_line":"                     \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":323,"context_line":"                     \"performed on node!!\"), task.node.uuid)"},{"line_number":324,"context_line":"            LOG.error(msg)"},{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_4401bc04","line":323,"range":{"start_line":323,"start_character":45,"end_line":323,"end_character":59},"in_reply_to":"bae84128_e372e548","updated":"2016-02-29 06:17:57.000000000","message":"Have updated that accordingly in patch-set #10.","commit_id":"0c722e344091e5ef02f5cdd20a12e6efc918d988"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c29c30cfd44ec0b243c94cd0ba8a6affea602c58","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        if not ilo_license_key:"},{"line_number":321,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":322,"context_line":"                     \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":323,"context_line":"                     \"performed on node %s.\"), task.node.uuid)"},{"line_number":324,"context_line":"            LOG.error(msg)"},{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_39d23c35","line":323,"updated":"2016-02-25 10:03:16.000000000","message":"\u0027%\u0027 instead of \u0027,\u0027 should be here for formatting.","commit_id":"3c0bc8a6256e1d373b31356ac5fb62117a838f08"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"88f54e705971ae58cfde384696a594f4051ddb22","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        if not ilo_license_key:"},{"line_number":321,"context_line":"            msg \u003d (_(\"\u0027ilo_license_key\u0027 parameter value is missing \""},{"line_number":322,"context_line":"                     \"in clean step. Step \u0027activate_license\u0027 is not \""},{"line_number":323,"context_line":"                     \"performed on node %s.\"), task.node.uuid)"},{"line_number":324,"context_line":"            LOG.error(msg)"},{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_242d9895","line":323,"in_reply_to":"bae84128_39d23c35","updated":"2016-02-29 06:17:45.000000000","message":"Done","commit_id":"3c0bc8a6256e1d373b31356ac5fb62117a838f08"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"bfd6775df483d783526e4d066fdf16d3feefe220","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        LOG.debug(\"iLO license activation for \""},{"line_number":328,"context_line":"                  \"node: %(node)s ... in progress\","},{"line_number":329,"context_line":"                  task.node.uuid)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return _execute_ilo_clean_step("}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_b009422f","line":328,"range":{"start_line":328,"start_character":25,"end_line":328,"end_character":33},"updated":"2016-02-26 07:52:22.000000000","message":"s/%(node)s/%s.","commit_id":"bc35bf20fc4738c0aac1ac190a36fe6446bda88a"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"06032c21a1f668505c398ab24ea7b44c40d416bd","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        LOG.debug(\"iLO license activation for \""},{"line_number":328,"context_line":"                  \"node: %(node)s ... in progress\","},{"line_number":329,"context_line":"                  task.node.uuid)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return _execute_ilo_clean_step("}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_092eada4","line":328,"range":{"start_line":328,"start_character":25,"end_line":328,"end_character":33},"in_reply_to":"9aed3d3a_b009422f","updated":"2016-02-29 06:17:31.000000000","message":"Have updated that accordingly in patch-set #10.","commit_id":"bc35bf20fc4738c0aac1ac190a36fe6446bda88a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":306,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":307,"context_line":"            \u0027description\u0027: ("},{"line_number":308,"context_line":"                \u0027This argument indicates the iLO (Advanced) license key to be \u0027"},{"line_number":309,"context_line":"                \u0027activated on HPE ProLiant server(s). This license gives \u0027"},{"line_number":310,"context_line":"                \u0027premium and advanced features to support enterprise data \u0027"},{"line_number":311,"context_line":"                \u0027center.\u0027"},{"line_number":312,"context_line":"            ),"},{"line_number":313,"context_line":"            \u0027required\u0027: True"},{"line_number":314,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_ca7024df","line":311,"range":{"start_line":308,"start_character":17,"end_line":311,"end_character":25},"updated":"2016-02-29 14:24:53.000000000","message":"May be this description can be shortened...\n\ns/\u0027This argument indicates the iLO (Advanced) license key to be activated on HPE ProLiant server(s). This license gives premium and advanced features to support enterprise data center.\u0027 / \u0027HP iLO Advanced license key to activate iLO advanced features.\u0027","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    @base.clean_step(priority\u003d0, abortable\u003dFalse, argsinfo\u003d{"},{"line_number":306,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":307,"context_line":"            \u0027description\u0027: ("},{"line_number":308,"context_line":"                \u0027This argument indicates the iLO (Advanced) license key to be \u0027"},{"line_number":309,"context_line":"                \u0027activated on HPE ProLiant server(s). This license gives \u0027"},{"line_number":310,"context_line":"                \u0027premium and advanced features to support enterprise data \u0027"},{"line_number":311,"context_line":"                \u0027center.\u0027"},{"line_number":312,"context_line":"            ),"},{"line_number":313,"context_line":"            \u0027required\u0027: True"},{"line_number":314,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_a13ddade","line":311,"range":{"start_line":308,"start_character":17,"end_line":311,"end_character":25},"in_reply_to":"9aed3d3a_ca7024df","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        }"},{"line_number":315,"context_line":"    })"},{"line_number":316,"context_line":"    def activate_license(self, task, **kwargs):"},{"line_number":317,"context_line":"        \"\"\"Activates iLO (Advanced) license."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        :param task: a TaskManager object."},{"line_number":320,"context_line":"        :raises: MissingParameterValue, if no license key is provided."}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_0a25ecbf","line":317,"range":{"start_line":317,"start_character":25,"end_line":317,"end_character":35},"updated":"2016-02-29 14:24:53.000000000","message":"s/ \u0027(Advanced)\u0027 / \u0027Advanced\u0027 /","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        }"},{"line_number":315,"context_line":"    })"},{"line_number":316,"context_line":"    def activate_license(self, task, **kwargs):"},{"line_number":317,"context_line":"        \"\"\"Activates iLO (Advanced) license."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        :param task: a TaskManager object."},{"line_number":320,"context_line":"        :raises: MissingParameterValue, if no license key is provided."}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_412faea0","line":317,"range":{"start_line":317,"start_character":25,"end_line":317,"end_character":35},"in_reply_to":"9aed3d3a_0a25ecbf","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        :param task: a TaskManager object."},{"line_number":320,"context_line":"        :raises: MissingParameterValue, if no license key is provided."},{"line_number":321,"context_line":"        :raises: NodeCleaningFailure, on failure to execute step."},{"line_number":322,"context_line":"        \"\"\""},{"line_number":323,"context_line":"        ilo_license_key \u003d kwargs.get(\u0027ilo_license_key\u0027)"},{"line_number":324,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_2d6baab8","line":321,"range":{"start_line":321,"start_character":60,"end_line":321,"end_character":64},"updated":"2016-02-29 14:24:53.000000000","message":"s/ step / clean step /","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        :param task: a TaskManager object."},{"line_number":320,"context_line":"        :raises: MissingParameterValue, if no license key is provided."},{"line_number":321,"context_line":"        :raises: NodeCleaningFailure, on failure to execute step."},{"line_number":322,"context_line":"        \"\"\""},{"line_number":323,"context_line":"        ilo_license_key \u003d kwargs.get(\u0027ilo_license_key\u0027)"},{"line_number":324,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_a114ba4c","line":321,"range":{"start_line":321,"start_character":60,"end_line":321,"end_character":64},"in_reply_to":"9aed3d3a_2d6baab8","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        if not ilo_license_key:"},{"line_number":327,"context_line":"            msg \u003d (_(\"Value of \u0027ilo_license_key\u0027 is missing in clean step. \""},{"line_number":328,"context_line":"                     \"Step \u0027activate_license\u0027 is not performed on %(node)s.\")"},{"line_number":329,"context_line":"                   % {\u0027node\u0027: node.uuid})"},{"line_number":330,"context_line":"            LOG.error(msg)"},{"line_number":331,"context_line":"            raise exception.MissingParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_992e7441","line":328,"range":{"start_line":328,"start_character":49,"end_line":328,"end_character":65},"updated":"2016-02-29 14:24:53.000000000","message":"s/\u0027not performed on\u0027 /\u0027not execute for\u0027/","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        if not ilo_license_key:"},{"line_number":327,"context_line":"            msg \u003d (_(\"Value of \u0027ilo_license_key\u0027 is missing in clean step. \""},{"line_number":328,"context_line":"                     \"Step \u0027activate_license\u0027 is not performed on %(node)s.\")"},{"line_number":329,"context_line":"                   % {\u0027node\u0027: node.uuid})"},{"line_number":330,"context_line":"            LOG.error(msg)"},{"line_number":331,"context_line":"            raise exception.MissingParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_7c02550b","line":328,"range":{"start_line":328,"start_character":49,"end_line":328,"end_character":65},"in_reply_to":"9aed3d3a_992e7441","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            LOG.error(msg)"},{"line_number":331,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        LOG.debug(\"Activation of iLO license on node: %(node)s ... \""},{"line_number":334,"context_line":"                  \"in progress\", {\u0027node\u0027: node.uuid})"},{"line_number":335,"context_line":"        _execute_ilo_clean_step(node, \u0027activate_license\u0027, ilo_license_key)"},{"line_number":336,"context_line":"        LOG.info(_LI(\"Activation of iLO license on node: %(node)s ... \""},{"line_number":337,"context_line":"                     \"done\"), {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_d9975c38","line":334,"range":{"start_line":333,"start_character":19,"end_line":334,"end_character":53},"updated":"2016-02-29 14:24:53.000000000","message":"s/ \u0027Activation of iLO license on node: %(node)s ... in progress\u0027 / \u0027Activating iLO license for node %(node)s\u0027 /","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            LOG.error(msg)"},{"line_number":331,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        LOG.debug(\"Activation of iLO license on node: %(node)s ... \""},{"line_number":334,"context_line":"                  \"in progress\", {\u0027node\u0027: node.uuid})"},{"line_number":335,"context_line":"        _execute_ilo_clean_step(node, \u0027activate_license\u0027, ilo_license_key)"},{"line_number":336,"context_line":"        LOG.info(_LI(\"Activation of iLO license on node: %(node)s ... \""},{"line_number":337,"context_line":"                     \"done\"), {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_1c186974","line":334,"range":{"start_line":333,"start_character":19,"end_line":334,"end_character":53},"in_reply_to":"9aed3d3a_d9975c38","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        LOG.debug(\"Activation of iLO license on node: %(node)s ... \""},{"line_number":334,"context_line":"                  \"in progress\", {\u0027node\u0027: node.uuid})"},{"line_number":335,"context_line":"        _execute_ilo_clean_step(node, \u0027activate_license\u0027, ilo_license_key)"},{"line_number":336,"context_line":"        LOG.info(_LI(\"Activation of iLO license on node: %(node)s ... \""},{"line_number":337,"context_line":"                     \"done\"), {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_7967304d","line":337,"range":{"start_line":336,"start_character":21,"end_line":337,"end_character":27},"updated":"2016-02-29 14:24:53.000000000","message":"s/ \"Activation of iLO license on node: %(node)s ... done\"/ \"iLO license activated for node %(node)s.\"/","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        LOG.debug(\"Activation of iLO license on node: %(node)s ... \""},{"line_number":334,"context_line":"                  \"in progress\", {\u0027node\u0027: node.uuid})"},{"line_number":335,"context_line":"        _execute_ilo_clean_step(node, \u0027activate_license\u0027, ilo_license_key)"},{"line_number":336,"context_line":"        LOG.info(_LI(\"Activation of iLO license on node: %(node)s ... \""},{"line_number":337,"context_line":"                     \"done\"), {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_3c344ddc","line":337,"range":{"start_line":336,"start_character":21,"end_line":337,"end_character":27},"in_reply_to":"9aed3d3a_7967304d","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cac8d9fb71bbf3a970497aa27874218c29a783b9","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":307,"context_line":"            \u0027description\u0027: ("},{"line_number":308,"context_line":"                \u0027This argument indicates the HPE iLO Advanced license key to \u0027"},{"line_number":309,"context_line":"                \u0027activate iLO advanced features.\u0027"},{"line_number":310,"context_line":"            ),"},{"line_number":311,"context_line":"            \u0027required\u0027: True"},{"line_number":312,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_52129663","line":309,"updated":"2016-03-01 15:13:36.000000000","message":"This description reads a bit strange (I\u0027m a non native english speaker tho)...\n\nThe \"This argument indicates\" seems a bit off...\n\nWhat about:\n\n\"The HPE iLO Advanced license key to activate enterprise features\"","commit_id":"e6ed4f88432669ac493113637912030ba0b8a665"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1aea1b7c9abd463c8a483dadc49bd0787ab4030d","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":307,"context_line":"            \u0027description\u0027: ("},{"line_number":308,"context_line":"                \u0027This argument indicates the HPE iLO Advanced license key to \u0027"},{"line_number":309,"context_line":"                \u0027activate iLO advanced features.\u0027"},{"line_number":310,"context_line":"            ),"},{"line_number":311,"context_line":"            \u0027required\u0027: True"},{"line_number":312,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_d5e5f0a8","line":309,"in_reply_to":"7af24918_52129663","updated":"2016-03-01 15:18:08.000000000","message":"+1, I\u0027d fix it","commit_id":"e6ed4f88432669ac493113637912030ba0b8a665"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"54b6019f97833f92a69257ccb136cc495e90b5bf","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":307,"context_line":"            \u0027description\u0027: ("},{"line_number":308,"context_line":"                \u0027This argument indicates the HPE iLO Advanced license key to \u0027"},{"line_number":309,"context_line":"                \u0027activate iLO advanced features.\u0027"},{"line_number":310,"context_line":"            ),"},{"line_number":311,"context_line":"            \u0027required\u0027: True"},{"line_number":312,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_9c5c0827","line":309,"in_reply_to":"7af24918_52129663","updated":"2016-03-02 06:19:42.000000000","message":"On a lighter note, me too not a native english speaker, taking your suggestion as you are still in close proximity to them :-). thx, anyways.","commit_id":"e6ed4f88432669ac493113637912030ba0b8a665"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"54b6019f97833f92a69257ccb136cc495e90b5bf","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        \u0027ilo_license_key\u0027: {"},{"line_number":307,"context_line":"            \u0027description\u0027: ("},{"line_number":308,"context_line":"                \u0027This argument indicates the HPE iLO Advanced license key to \u0027"},{"line_number":309,"context_line":"                \u0027activate iLO advanced features.\u0027"},{"line_number":310,"context_line":"            ),"},{"line_number":311,"context_line":"            \u0027required\u0027: True"},{"line_number":312,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_fc41cc3a","line":309,"in_reply_to":"7af24918_d5e5f0a8","updated":"2016-03-02 06:19:42.000000000","message":"Done","commit_id":"e6ed4f88432669ac493113637912030ba0b8a665"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1aea1b7c9abd463c8a483dadc49bd0787ab4030d","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        ilo_license_key \u003d kwargs.get(\u0027ilo_license_key\u0027)"},{"line_number":322,"context_line":"        node \u003d task.node"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        if not ilo_license_key:"},{"line_number":325,"context_line":"            msg \u003d (_(\"Value of \u0027ilo_license_key\u0027 is missing in clean step. \""},{"line_number":326,"context_line":"                     \"Step \u0027activate_license\u0027 is not executed for %(node)s.\")"},{"line_number":327,"context_line":"                   % {\u0027node\u0027: node.uuid})"},{"line_number":328,"context_line":"            LOG.error(msg)"},{"line_number":329,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        LOG.debug(\"Activating iLO license for node %(node)s ...\","},{"line_number":332,"context_line":"                  {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_1504787c","line":329,"range":{"start_line":324,"start_character":9,"end_line":329,"end_character":54},"updated":"2016-03-01 15:18:08.000000000","message":"this essentially duplicates what \"required\" argsinfo flag does. on the other hand don\u0027t we want some verification? at least that it\u0027s a string (or what do you expect?)","commit_id":"e6ed4f88432669ac493113637912030ba0b8a665"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"54b6019f97833f92a69257ccb136cc495e90b5bf","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        ilo_license_key \u003d kwargs.get(\u0027ilo_license_key\u0027)"},{"line_number":322,"context_line":"        node \u003d task.node"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        if not ilo_license_key:"},{"line_number":325,"context_line":"            msg \u003d (_(\"Value of \u0027ilo_license_key\u0027 is missing in clean step. \""},{"line_number":326,"context_line":"                     \"Step \u0027activate_license\u0027 is not executed for %(node)s.\")"},{"line_number":327,"context_line":"                   % {\u0027node\u0027: node.uuid})"},{"line_number":328,"context_line":"            LOG.error(msg)"},{"line_number":329,"context_line":"            raise exception.MissingParameterValue(msg)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        LOG.debug(\"Activating iLO license for node %(node)s ...\","},{"line_number":332,"context_line":"                  {\u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_bcf3c409","line":329,"range":{"start_line":324,"start_character":9,"end_line":329,"end_character":54},"in_reply_to":"7af24918_1504787c","updated":"2016-03-02 06:19:42.000000000","message":"yes, Dmitry, you are right.\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/utils.py#L401\n\nModifying this to check for string type value instead.","commit_id":"e6ed4f88432669ac493113637912030ba0b8a665"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"260ef88ea49b4279f052cf1d47fd13e7d7381194","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        node \u003d task.node"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if not isinstance(ilo_license_key, six.string_types):"},{"line_number":324,"context_line":"            msg \u003d (_(\"Value of \u0027ilo_license_key\u0027 must be a string value \""},{"line_number":325,"context_line":"                     \"instead of \u0027%(value)s\u0027. Step \u0027activate_license\u0027 is not \""},{"line_number":326,"context_line":"                     \"executed for %(node)s.\")"},{"line_number":327,"context_line":"                   % {\u0027value\u0027: ilo_license_key, \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_616977be","line":324,"updated":"2016-03-02 13:27:34.000000000","message":"nit: s/value//","commit_id":"2d029b5962cf3644af62e707cf36f72c938c7cb0"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"fffcabedad2d81e7b3783feb0f0f47c55af25298","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        node \u003d task.node"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if not isinstance(ilo_license_key, six.string_types):"},{"line_number":324,"context_line":"            msg \u003d (_(\"Value of \u0027ilo_license_key\u0027 must be a string value \""},{"line_number":325,"context_line":"                     \"instead of \u0027%(value)s\u0027. Step \u0027activate_license\u0027 is not \""},{"line_number":326,"context_line":"                     \"executed for %(node)s.\")"},{"line_number":327,"context_line":"                   % {\u0027value\u0027: ilo_license_key, \u0027node\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_da5e74e8","line":324,"in_reply_to":"7af24918_616977be","updated":"2016-03-03 05:31:27.000000000","message":"Done","commit_id":"2d029b5962cf3644af62e707cf36f72c938c7cb0"}],"ironic/tests/unit/drivers/modules/ilo/test_management.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":305,"context_line":"            # -------------------------------------------------------------------"},{"line_number":306,"context_line":"            # GIVEN"},{"line_number":307,"context_line":"            # -------------------------------------------------------------------"},{"line_number":308,"context_line":"            activate_license_args \u003d {"},{"line_number":309,"context_line":"                \u0027ilo_license_key\u0027: \u0027a_secretive_ilo_license__key\u0027}"},{"line_number":310,"context_line":"            # -------------------------------------------------------------------"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_bcdbf6ec","line":307,"range":{"start_line":307,"start_character":14,"end_line":307,"end_character":81},"updated":"2015-12-23 03:06:37.000000000","message":"Remove these # comments. They are not required.","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":305,"context_line":"            # -------------------------------------------------------------------"},{"line_number":306,"context_line":"            # GIVEN"},{"line_number":307,"context_line":"            # -------------------------------------------------------------------"},{"line_number":308,"context_line":"            activate_license_args \u003d {"},{"line_number":309,"context_line":"                \u0027ilo_license_key\u0027: \u0027a_secretive_ilo_license__key\u0027}"},{"line_number":310,"context_line":"            # -------------------------------------------------------------------"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_02c34c58","line":307,"range":{"start_line":307,"start_character":14,"end_line":307,"end_character":81},"in_reply_to":"1a7b0d38_bcdbf6ec","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            # GIVEN"},{"line_number":307,"context_line":"            # -------------------------------------------------------------------"},{"line_number":308,"context_line":"            activate_license_args \u003d {"},{"line_number":309,"context_line":"                \u0027ilo_license_key\u0027: \u0027a_secretive_ilo_license__key\u0027}"},{"line_number":310,"context_line":"            # -------------------------------------------------------------------"},{"line_number":311,"context_line":"            # WHEN"},{"line_number":312,"context_line":"            # -------------------------------------------------------------------"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_5ccc5235","line":309,"range":{"start_line":309,"start_character":36,"end_line":309,"end_character":64},"updated":"2015-12-23 03:06:37.000000000","message":"Better to add the key in the actual GUID format.","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            # GIVEN"},{"line_number":307,"context_line":"            # -------------------------------------------------------------------"},{"line_number":308,"context_line":"            activate_license_args \u003d {"},{"line_number":309,"context_line":"                \u0027ilo_license_key\u0027: \u0027a_secretive_ilo_license__key\u0027}"},{"line_number":310,"context_line":"            # -------------------------------------------------------------------"},{"line_number":311,"context_line":"            # WHEN"},{"line_number":312,"context_line":"            # -------------------------------------------------------------------"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_a2a280ac","line":309,"range":{"start_line":309,"start_character":36,"end_line":309,"end_character":64},"in_reply_to":"1a7b0d38_5ccc5235","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                \u0027ilo_license_key\u0027: \u0027a_secretive_ilo_license__key\u0027}"},{"line_number":310,"context_line":"            # -------------------------------------------------------------------"},{"line_number":311,"context_line":"            # WHEN"},{"line_number":312,"context_line":"            # -------------------------------------------------------------------"},{"line_number":313,"context_line":"            task.driver.management.activate_license(task,"},{"line_number":314,"context_line":"                                                    **activate_license_args)"},{"line_number":315,"context_line":"            # -------------------------------------------------------------------"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_5cf3f273","line":312,"range":{"start_line":312,"start_character":14,"end_line":312,"end_character":81},"updated":"2015-12-23 03:06:37.000000000","message":"ditto","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                \u0027ilo_license_key\u0027: \u0027a_secretive_ilo_license__key\u0027}"},{"line_number":310,"context_line":"            # -------------------------------------------------------------------"},{"line_number":311,"context_line":"            # WHEN"},{"line_number":312,"context_line":"            # -------------------------------------------------------------------"},{"line_number":313,"context_line":"            task.driver.management.activate_license(task,"},{"line_number":314,"context_line":"                                                    **activate_license_args)"},{"line_number":315,"context_line":"            # -------------------------------------------------------------------"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_62a8088d","line":312,"range":{"start_line":312,"start_character":14,"end_line":312,"end_character":81},"in_reply_to":"1a7b0d38_5cf3f273","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            task.driver.management.activate_license(task,"},{"line_number":314,"context_line":"                                                    **activate_license_args)"},{"line_number":315,"context_line":"            # -------------------------------------------------------------------"},{"line_number":316,"context_line":"            # THEN"},{"line_number":317,"context_line":"            # -------------------------------------------------------------------"},{"line_number":318,"context_line":"            clean_step_mock.assert_called_once_with("},{"line_number":319,"context_line":"                task.node, \u0027activate_license\u0027, \u0027a_secretive_ilo_license__key\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_fce73eaa","line":316,"range":{"start_line":316,"start_character":14,"end_line":316,"end_character":18},"updated":"2015-12-23 03:06:37.000000000","message":"ditto","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            task.driver.management.activate_license(task,"},{"line_number":314,"context_line":"                                                    **activate_license_args)"},{"line_number":315,"context_line":"            # -------------------------------------------------------------------"},{"line_number":316,"context_line":"            # THEN"},{"line_number":317,"context_line":"            # -------------------------------------------------------------------"},{"line_number":318,"context_line":"            clean_step_mock.assert_called_once_with("},{"line_number":319,"context_line":"                task.node, \u0027activate_license\u0027, \u0027a_secretive_ilo_license__key\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_82adfc9c","line":316,"range":{"start_line":316,"start_character":14,"end_line":316,"end_character":18},"in_reply_to":"1a7b0d38_fce73eaa","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":327,"context_line":"            # -------------------------------------------------------------------"},{"line_number":328,"context_line":"            # GIVEN"},{"line_number":329,"context_line":"            # -------------------------------------------------------------------"},{"line_number":330,"context_line":"            activate_license_args \u003d {\u0027ilo_license_key\u0027: None}"},{"line_number":331,"context_line":"            # ---------------------------------------------------------------"},{"line_number":332,"context_line":"            # WHEN \u0026 THEN"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_bc02163d","line":329,"range":{"start_line":329,"start_character":14,"end_line":329,"end_character":81},"updated":"2015-12-23 03:06:37.000000000","message":"ditto","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":327,"context_line":"            # -------------------------------------------------------------------"},{"line_number":328,"context_line":"            # GIVEN"},{"line_number":329,"context_line":"            # -------------------------------------------------------------------"},{"line_number":330,"context_line":"            activate_license_args \u003d {\u0027ilo_license_key\u0027: None}"},{"line_number":331,"context_line":"            # ---------------------------------------------------------------"},{"line_number":332,"context_line":"            # WHEN \u0026 THEN"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_22977049","line":329,"range":{"start_line":329,"start_character":14,"end_line":329,"end_character":81},"in_reply_to":"1a7b0d38_bc02163d","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"aa529e6016e859be27ad88026c360d2f27858931","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            activate_license_args \u003d {\u0027ilo_license_key\u0027: None}"},{"line_number":331,"context_line":"            # ---------------------------------------------------------------"},{"line_number":332,"context_line":"            # WHEN \u0026 THEN"},{"line_number":333,"context_line":"            # ---------------------------------------------------------------"},{"line_number":334,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":335,"context_line":"                              task.driver.management.activate_license,"},{"line_number":336,"context_line":"                              task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_dcffe232","line":333,"range":{"start_line":333,"start_character":14,"end_line":333,"end_character":77},"updated":"2015-12-23 03:06:37.000000000","message":"ditto","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"51b2e00d61c049726ea3e47dc6c6addb3364a529","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            activate_license_args \u003d {\u0027ilo_license_key\u0027: None}"},{"line_number":331,"context_line":"            # ---------------------------------------------------------------"},{"line_number":332,"context_line":"            # WHEN \u0026 THEN"},{"line_number":333,"context_line":"            # ---------------------------------------------------------------"},{"line_number":334,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":335,"context_line":"                              task.driver.management.activate_license,"},{"line_number":336,"context_line":"                              task,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4294e441","line":333,"range":{"start_line":333,"start_character":14,"end_line":333,"end_character":77},"in_reply_to":"1a7b0d38_dcffe232","updated":"2016-01-11 05:57:23.000000000","message":"Done","commit_id":"b7b8b595034ec2dc46a7a051ac9b98b7cadd74ca"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c634d975dafac946cdcee1a5639e6147f53e4bdc","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @mock.patch.object(ilo_management, \u0027_execute_ilo_clean_step\u0027,"},{"line_number":313,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":314,"context_line":"    def test_activate_license_throws_error_if_no_license_key_provided("},{"line_number":315,"context_line":"            self, clean_step_mock):"},{"line_number":316,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":317,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_d4316b5b","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":69},"updated":"2016-01-11 10:32:57.000000000","message":"nit: method name looks too long. Can it be shorten e.g. \ntest_activate_license_exc()","commit_id":"9bde6ed408faaa49953026aa95f4b87112b70633"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c634d975dafac946cdcee1a5639e6147f53e4bdc","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                              task.driver.management.activate_license,"},{"line_number":321,"context_line":"                              task,"},{"line_number":322,"context_line":"                              **activate_license_args)"},{"line_number":323,"context_line":"            self.assertFalse(clean_step_mock.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_f446efbe","line":323,"range":{"start_line":323,"start_character":17,"end_line":323,"end_character":28},"updated":"2016-01-11 10:32:57.000000000","message":"Add mock for LOG.error","commit_id":"9bde6ed408faaa49953026aa95f4b87112b70633"}],"releasenotes/notes/ilo-license-activate-manual-clean-step-84d335998d708b49.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"cc104ae26fc4cbfbb00ce57981917caa5d91bf3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - iLO drivers now provide out-of-band iLO license"},{"line_number":4,"context_line":"    activation as a manual cleaning step for HPE ProLiant"},{"line_number":5,"context_line":"    server(s)."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9aed3d3a_392be895","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":14},"updated":"2016-02-29 14:24:53.000000000","message":"May be this can be rephrased as:-\n\u0027Support for activation of iLO advanced license as a manual cleaning step in iLO drivers.\u0027","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"38c5f4378e90b217371eb412fdf2de06b82efdf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - iLO drivers now provide out-of-band iLO license"},{"line_number":4,"context_line":"    activation as a manual cleaning step for HPE ProLiant"},{"line_number":5,"context_line":"    server(s)."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9aed3d3a_9ca7590a","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":14},"in_reply_to":"9aed3d3a_392be895","updated":"2016-03-01 04:05:57.000000000","message":"Done","commit_id":"1c291d539c6b46509f83d0aeb4a7913ab6e7e56c"}]}