)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"03dc9319b6ec44f89e6a906ba29b92bec6d5792c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"which tests Ironic API /v1/nodes/(node_ident)/states/*"},{"line_number":14,"context_line":"support microversions."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Depends-On: If9b03d03ef29fdeaa75dda823e4904aae1023e70"},{"line_number":17,"context_line":"Change-Id: Ibf0c73aa6795aaa52e945fd6baa821de20a599e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bab6814e_0fceac81","line":16,"range":{"start_line":16,"start_character":12,"end_line":16,"end_character":53},"updated":"2016-05-20 11:31:01.000000000","message":"this is merged (and updated already)","commit_id":"f2f6d9132c7e32d5d2830fd464ece59ed92be436"}],"ironic_tempest_plugin/clients.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ADMIN_CREDS \u003d common_creds.get_configured_credentials(\u0027identity_admin\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class Manager(clients.Manager):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_868d7f33","line":25,"updated":"2016-02-03 17:39:31.000000000","message":"Is this still needed?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class Manager(clients.Manager):"},{"line_number":29,"context_line":"    def __init__(self, credentials, service\u003dNone, api_microversions\u003dNone):"},{"line_number":30,"context_line":"        \"\"\"Initialization of Manager class."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Setup all services clients and make them available for tests cases."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_4b9b10ca","line":29,"updated":"2016-02-03 17:39:31.000000000","message":"credentials was originally a default argument (credentials\u003dADMIN_CREDS). This changes it so that it is a positional argument with no default value. Did you really want to do this?\n\nWhat\u0027s wrong with keeping it as credentials\u003dADMIN_CREDS?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class Manager(clients.Manager):"},{"line_number":29,"context_line":"    def __init__(self, credentials, service\u003dNone, api_microversions\u003dNone):"},{"line_number":30,"context_line":"        \"\"\"Initialization of Manager class."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Setup all services clients and make them available for tests cases."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_f13d6ac4","line":29,"in_reply_to":"5a5ae5dd_4b9b10ca","updated":"2016-02-08 12:07:25.000000000","message":"I removed default value because I was just thinking about API test and I forgot that this method is used by scenario test also. I will revert.","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def __init__(self, credentials, service\u003dNone, api_microversions\u003dNone):"},{"line_number":30,"context_line":"        \"\"\"Initialization of Manager class."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Setup all services clients and make them available for tests cases."},{"line_number":33,"context_line":"        :param credentials: type Credentials or TestResources"},{"line_number":34,"context_line":"        :param service: Service name"},{"line_number":35,"context_line":"        :param api_microversions: This is dict of services catalog type"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_ab8de47c","line":32,"updated":"2016-02-03 17:39:31.000000000","message":"s/services/service/\n\ns/tests/test/ OR s/tests cases/tests/ ?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def __init__(self, credentials, service\u003dNone, api_microversions\u003dNone):"},{"line_number":30,"context_line":"        \"\"\"Initialization of Manager class."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Setup all services clients and make them available for tests cases."},{"line_number":33,"context_line":"        :param credentials: type Credentials or TestResources"},{"line_number":34,"context_line":"        :param service: Service name"},{"line_number":35,"context_line":"        :param api_microversions: This is dict of services catalog type"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_51cc7eba","line":32,"in_reply_to":"5a5ae5dd_ab8de47c","updated":"2016-02-08 12:07:25.000000000","message":"Done.","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Initialization of Manager class."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Setup all services clients and make them available for tests cases."},{"line_number":33,"context_line":"        :param credentials: type Credentials or TestResources"},{"line_number":34,"context_line":"        :param service: Service name"},{"line_number":35,"context_line":"        :param api_microversions: This is dict of services catalog type"},{"line_number":36,"context_line":"               and their microversion which will be set on respective"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_2b17b452","line":33,"updated":"2016-02-03 17:39:31.000000000","message":"I had to find out what Credentials and TestResources were. Maybe\n\ns/Credentials/tempest_lib/auth.Credentials/\n\ns/TestResources/tempest.common.cred_provider.TestResources/","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"\"\"Initialization of Manager class."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        Setup all services clients and make them available for tests cases."},{"line_number":33,"context_line":"        :param credentials: type Credentials or TestResources"},{"line_number":34,"context_line":"        :param service: Service name"},{"line_number":35,"context_line":"        :param api_microversions: This is dict of services catalog type"},{"line_number":36,"context_line":"               and their microversion which will be set on respective"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_d1a70ea5","line":33,"in_reply_to":"5a5ae5dd_2b17b452","updated":"2016-02-08 12:07:25.000000000","message":"Done","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        :param service: Service name"},{"line_number":35,"context_line":"        :param api_microversions: This is dict of services catalog type"},{"line_number":36,"context_line":"               and their microversion which will be set on respective"},{"line_number":37,"context_line":"               services clients."},{"line_number":38,"context_line":"               {\u003cservice catalog type\u003e: request_microversion}"},{"line_number":39,"context_line":"               Example :"},{"line_number":40,"context_line":"                {\u0027compute\u0027: request_microversion}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_8679ff95","line":37,"updated":"2016-02-03 17:39:31.000000000","message":"s/services/service/","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        :param service: Service name"},{"line_number":35,"context_line":"        :param api_microversions: This is dict of services catalog type"},{"line_number":36,"context_line":"               and their microversion which will be set on respective"},{"line_number":37,"context_line":"               services clients."},{"line_number":38,"context_line":"               {\u003cservice catalog type\u003e: request_microversion}"},{"line_number":39,"context_line":"               Example :"},{"line_number":40,"context_line":"                {\u0027compute\u0027: request_microversion}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_31af827e","line":37,"in_reply_to":"5a5ae5dd_8679ff95","updated":"2016-02-08 12:07:25.000000000","message":"Done","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"03dc9319b6ec44f89e6a906ba29b92bec6d5792c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    - request_microversion of volume will be set on all"},{"line_number":53,"context_line":"                      volume service clients."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        super(Manager, self).__init__(credentials, service, api_microversions)"},{"line_number":56,"context_line":"        self.baremetal_client \u003d BaremetalClient("},{"line_number":57,"context_line":"            self.auth_provider,"},{"line_number":58,"context_line":"            CONF.baremetal.catalog_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_cfcdc4b8","line":55,"range":{"start_line":55,"start_character":57,"end_line":55,"end_character":76},"updated":"2016-05-20 11:31:01.000000000","message":"there is no such argument","commit_id":"f2f6d9132c7e32d5d2830fd464ece59ed92be436"}],"ironic_tempest_plugin/services/baremetal/base.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def get_headers(self):"},{"line_number":48,"context_line":"        headers \u003d super(BaremetalClient, self).get_headers()"},{"line_number":49,"context_line":"        if self.api_microversion:"},{"line_number":50,"context_line":"            headers[\u0027x-openstack-ironic-api-version\u0027] \u003d self.api_microversion"},{"line_number":51,"context_line":"        return headers"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def set_api_microversion(self, microversion):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_01c2d985","line":50,"updated":"2016-02-03 17:39:31.000000000","message":"the ironic client uses \u0027X-OpenStack-Ironic-API-Version\u0027. Don\u0027t know if it matters much. eg if looking through logs?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def get_headers(self):"},{"line_number":48,"context_line":"        headers \u003d super(BaremetalClient, self).get_headers()"},{"line_number":49,"context_line":"        if self.api_microversion:"},{"line_number":50,"context_line":"            headers[\u0027x-openstack-ironic-api-version\u0027] \u003d self.api_microversion"},{"line_number":51,"context_line":"        return headers"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def set_api_microversion(self, microversion):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_5400ec65","line":50,"in_reply_to":"5a5ae5dd_01c2d985","updated":"2016-02-08 12:07:25.000000000","message":"Done","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"}],"ironic_tempest_plugin/services/baremetal/v1/json/baremetal_client.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                                 target)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    @base.handle_errors"},{"line_number":268,"context_line":"    def set_node_provision_state(self, node_uuid, state):"},{"line_number":269,"context_line":"        \"\"\"Set provision state of the specified node."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        :param node_uuid: The unique identifier of the node."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_e1d1bdfc","line":268,"updated":"2016-02-03 17:39:31.000000000","message":"do we also want to handle the optional config drive (when setting to \u0027active\u0027)?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                                 target)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    @base.handle_errors"},{"line_number":268,"context_line":"    def set_node_provision_state(self, node_uuid, state):"},{"line_number":269,"context_line":"        \"\"\"Set provision state of the specified node."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        :param node_uuid: The unique identifier of the node."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_348210c9","line":268,"in_reply_to":"5a5ae5dd_e1d1bdfc","updated":"2016-02-08 12:07:25.000000000","message":"Done","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f9dc2c01b42cb0b79c98163a3c5f0a0f32918918","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        :param node_uuid: The unique identifier of the node."},{"line_number":272,"context_line":"        :state: desired state to set"},{"line_number":273,"context_line":"                (active/rebuild/deleted/inspect/manage/provide)."},{"line_number":274,"context_line":"        :config_drive: A gzipped, base64-encoded configuration drive string"},{"line_number":275,"context_line":"                       OR the path to the configuration drive file OR the"},{"line_number":276,"context_line":"                       path to a directory containing the config drive files."},{"line_number":277,"context_line":"                       In case it\u0027s a directory, a config drive will be"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_37cce560","line":274,"updated":"2016-05-25 09:15:34.000000000","message":"It should be only \"A gzipped, base64-encoded configuration drive string\" at this point, its generation happens on nova side.","commit_id":"75d80b00e3240bfe546ab96d3186ecf8fca82579"}],"ironic_tempest_plugin/tests/api/admin/base.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                                       api_microversions\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Creates isolated creds."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param name: name, will be used for naming ic and related stuff"},{"line_number":87,"context_line":"        :param type_of_creds: admin, alt or primary"},{"line_number":88,"context_line":"        :param cleanup_in_class: defines place where to delete"},{"line_number":89,"context_line":"        :returns: SharesClient -- shares client with isolated creds."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_a14e65bf","line":86,"updated":"2016-02-03 17:39:31.000000000","message":"what\u0027s \u0027ic\u0027?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                                       api_microversions\u003dNone):"},{"line_number":84,"context_line":"        \"\"\"Creates isolated creds."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param name: name, will be used for naming ic and related stuff"},{"line_number":87,"context_line":"        :param type_of_creds: admin, alt or primary"},{"line_number":88,"context_line":"        :param cleanup_in_class: defines place where to delete"},{"line_number":89,"context_line":"        :returns: SharesClient -- shares client with isolated creds."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_349e9007","line":86,"in_reply_to":"5a5ae5dd_a14e65bf","updated":"2016-02-08 12:07:25.000000000","message":"ic means isolated creds. I fixed.","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param name: name, will be used for naming ic and related stuff"},{"line_number":87,"context_line":"        :param type_of_creds: admin, alt or primary"},{"line_number":88,"context_line":"        :param cleanup_in_class: defines place where to delete"},{"line_number":89,"context_line":"        :returns: SharesClient -- shares client with isolated creds."},{"line_number":90,"context_line":"        :returns: To client added dict attr \u0027creds\u0027 with"},{"line_number":91,"context_line":"        :returns: key elements \u0027tenant\u0027 and \u0027user\u0027."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_01009933","line":88,"updated":"2016-02-03 17:39:31.000000000","message":"I don\u0027t see this param but I do see api_microversions, which isn\u0027t documented here.","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param name: name, will be used for naming ic and related stuff"},{"line_number":87,"context_line":"        :param type_of_creds: admin, alt or primary"},{"line_number":88,"context_line":"        :param cleanup_in_class: defines place where to delete"},{"line_number":89,"context_line":"        :returns: SharesClient -- shares client with isolated creds."},{"line_number":90,"context_line":"        :returns: To client added dict attr \u0027creds\u0027 with"},{"line_number":91,"context_line":"        :returns: key elements \u0027tenant\u0027 and \u0027user\u0027."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_1f0e0de5","line":88,"in_reply_to":"5a5ae5dd_01009933","updated":"2016-02-08 12:07:25.000000000","message":"Done","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        :param cleanup_in_class: defines place where to delete"},{"line_number":89,"context_line":"        :returns: SharesClient -- shares client with isolated creds."},{"line_number":90,"context_line":"        :returns: To client added dict attr \u0027creds\u0027 with"},{"line_number":91,"context_line":"        :returns: key elements \u0027tenant\u0027 and \u0027user\u0027."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        if name is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_216d9504","line":91,"updated":"2016-02-03 17:39:31.000000000","message":"I\u0027m not quite sure how to interpret the above three lines. Is it really one :returns: that spans more than one line?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        :param cleanup_in_class: defines place where to delete"},{"line_number":89,"context_line":"        :returns: SharesClient -- shares client with isolated creds."},{"line_number":90,"context_line":"        :returns: To client added dict attr \u0027creds\u0027 with"},{"line_number":91,"context_line":"        :returns: key elements \u0027tenant\u0027 and \u0027user\u0027."},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        if name is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_7f886171","line":91,"in_reply_to":"5a5ae5dd_216d9504","updated":"2016-02-08 12:07:25.000000000","message":"Done","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b9ade61b3bd6214383850e661562485fd0e0d60d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                                                       cfg_max_version)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def get_client_with_isolated_creds(cls,"},{"line_number":82,"context_line":"                                       name\u003dNone,"},{"line_number":83,"context_line":"                                       type_of_creds\u003d\"admin\"):"},{"line_number":84,"context_line":"        \"\"\"Creates isolated creds."}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_52b9de2d","line":81,"updated":"2016-05-24 15:33:16.000000000","message":"Not sure if we need it now.","commit_id":"75d80b00e3240bfe546ab96d3186ecf8fca82579"}],"ironic_tempest_plugin/tests/api/admin/test_nodestates.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # Validate that provision state is set within timeout"},{"line_number":48,"context_line":"        start \u003d timeutils.utcnow()"},{"line_number":49,"context_line":"        while timeutils.delta_seconds("},{"line_number":50,"context_line":"                start, timeutils.utcnow()) \u003c self.unprovision_timeout:"},{"line_number":51,"context_line":"            _, node \u003d self.client.show_node(node_uuid)"},{"line_number":52,"context_line":"            if node[\u0027provision_state\u0027] \u003d\u003d target_state:"},{"line_number":53,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_fc1de40f","line":50,"updated":"2016-02-03 17:39:31.000000000","message":"doesn\u0027t the timeout value depend on the target state? Eg, I see that we have configs for active_timeout, deploywait_timeout. Maybe that should be passed in as a parameter.","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # Validate that provision state is set within timeout"},{"line_number":48,"context_line":"        start \u003d timeutils.utcnow()"},{"line_number":49,"context_line":"        while timeutils.delta_seconds("},{"line_number":50,"context_line":"                start, timeutils.utcnow()) \u003c self.unprovision_timeout:"},{"line_number":51,"context_line":"            _, node \u003d self.client.show_node(node_uuid)"},{"line_number":52,"context_line":"            if node[\u0027provision_state\u0027] \u003d\u003d target_state:"},{"line_number":53,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_bf29f99c","line":50,"in_reply_to":"5a5ae5dd_fc1de40f","updated":"2016-02-08 12:07:25.000000000","message":"As you say \"active\" and \"deleted\" have their timeout \"active_timeout\" and \"clean_callback_timeout\" for each, but for others, for example, \"manage\" doesn\u0027t have timeout value. how can we handle them?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            if node[\u0027provision_state\u0027] \u003d\u003d target_state:"},{"line_number":53,"context_line":"                return"},{"line_number":54,"context_line":"        message \u003d (\u0027Failed to set provision state within \u0027"},{"line_number":55,"context_line":"                   \u0027the required time: %s sec.\u0027 % self.unprovision_timeout)"},{"line_number":56,"context_line":"        raise exceptions.TimeoutException(message)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.idempotent_id(\u0027cd8afa5e-3f57-4e43-8185-beb83d3c9015\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_fccba470","line":55,"updated":"2016-02-03 17:39:31.000000000","message":"I think it\u0027d be useful if the message also indicated the target_state.","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            if node[\u0027provision_state\u0027] \u003d\u003d target_state:"},{"line_number":53,"context_line":"                return"},{"line_number":54,"context_line":"        message \u003d (\u0027Failed to set provision state within \u0027"},{"line_number":55,"context_line":"                   \u0027the required time: %s sec.\u0027 % self.unprovision_timeout)"},{"line_number":56,"context_line":"        raise exceptions.TimeoutException(message)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.idempotent_id(\u0027cd8afa5e-3f57-4e43-8185-beb83d3c9015\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_1a1ffb5b","line":55,"in_reply_to":"5a5ae5dd_fccba470","updated":"2016-02-08 12:07:25.000000000","message":"Done","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    @test.idempotent_id(\u0027ccb8fca9-2ba0-480c-a037-34c3bd09dc74\u0027)"},{"line_number":75,"context_line":"    def test_set_node_provision_state(self):"},{"line_number":76,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"},{"line_number":77,"context_line":"        # Nodes appear in NONE state by default until v1.1"},{"line_number":78,"context_line":"        self.assertEqual(None, node[\u0027provision_state\u0027])"},{"line_number":79,"context_line":"        provision_states_list \u003d [\u0027active\u0027, \u0027deleted\u0027]"},{"line_number":80,"context_line":"        target_states_list \u003d [\u0027active\u0027, None]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_dcd108fd","line":77,"updated":"2016-02-03 17:39:31.000000000","message":"actually until v1.2. ie,\n\nv1.1 is the last version where nodes appear in NONE state.\n\nMaybe s/until/up to and including/\n\nor s/v1.1/v1.2/","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    @test.idempotent_id(\u0027ccb8fca9-2ba0-480c-a037-34c3bd09dc74\u0027)"},{"line_number":75,"context_line":"    def test_set_node_provision_state(self):"},{"line_number":76,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"},{"line_number":77,"context_line":"        # Nodes appear in NONE state by default until v1.1"},{"line_number":78,"context_line":"        self.assertEqual(None, node[\u0027provision_state\u0027])"},{"line_number":79,"context_line":"        provision_states_list \u003d [\u0027active\u0027, \u0027deleted\u0027]"},{"line_number":80,"context_line":"        target_states_list \u003d [\u0027active\u0027, None]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_bf7b39bd","line":77,"in_reply_to":"5a5ae5dd_dcd108fd","updated":"2016-02-08 12:07:25.000000000","message":"really? in http://docs.openstack.org/developer/ironic/webapi/v1.html , written like 1.2 : Renamed NOSTATE node state to available","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self._validate_provision_state(node[\u0027uuid\u0027], target_state)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class TestNodeStatesV1_4(TestNodeStatesV1_2):"},{"line_number":107,"context_line":"    min_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"},{"line_number":108,"context_line":"                                      versions.MINOR_4_MANAGEABLE_STATE)"},{"line_number":109,"context_line":"    max_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_bc90cced","line":106,"updated":"2016-02-03 17:39:31.000000000","message":"Wondering why the parent is TestNodeStatesV1_2 instead of TestNodeStates. Does it matter?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self._validate_provision_state(node[\u0027uuid\u0027], target_state)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class TestNodeStatesV1_4(TestNodeStatesV1_2):"},{"line_number":107,"context_line":"    min_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"},{"line_number":108,"context_line":"                                      versions.MINOR_4_MANAGEABLE_STATE)"},{"line_number":109,"context_line":"    max_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_e37b53bc","line":106,"in_reply_to":"5a5ae5dd_bc90cced","updated":"2016-02-08 12:07:25.000000000","message":"in this case, there is no problem with inheriting TestNodeStates. https://github.com/openstack/qa-specs/blob/master/specs/tempest/api-microversions-testing-support.rst","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    max_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"},{"line_number":110,"context_line":"                                      versions.MINOR_5_NODE_NAME)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @test.idempotent_id(\u00273d606003-05ce-4b5a-964d-bdee382fafe9\u0027)"},{"line_number":113,"context_line":"    def test_set_node_provision_state(self):"},{"line_number":114,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"},{"line_number":115,"context_line":"        # Nodes appear in AVAILABLE state by default from v1.2 to v1.10"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_3cd61cc6","line":112,"updated":"2016-02-03 17:39:31.000000000","message":"where do these ids come from?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    max_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"},{"line_number":110,"context_line":"                                      versions.MINOR_5_NODE_NAME)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @test.idempotent_id(\u00273d606003-05ce-4b5a-964d-bdee382fafe9\u0027)"},{"line_number":113,"context_line":"    def test_set_node_provision_state(self):"},{"line_number":114,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"},{"line_number":115,"context_line":"        # Nodes appear in AVAILABLE state by default from v1.2 to v1.10"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_5a50130b","line":112,"in_reply_to":"5a5ae5dd_3cd61cc6","updated":"2016-02-08 12:07:25.000000000","message":"We need to generate ID for each test cases and I generated this by check-uuid command.\nPlease see: http://docs.openstack.org/developer/tempest/HACKING.html#test-identification-with-idempotent-id","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"209e0f156f5ca10facc5f38d6f7ce865ff8e5770","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                                                 \u0027raid_level\u0027: \u00271\u0027}]}"},{"line_number":181,"context_line":"        self.client.set_node_raid_config(node[\u0027uuid\u0027], target_raid_config)"},{"line_number":182,"context_line":"        _, ret \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":183,"context_line":"        self.assertEqual(target_raid_config, ret[\u0027target_raid_config\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_37f877e5","line":183,"updated":"2016-02-03 17:39:31.000000000","message":"these tests are great.\n\nWe also have v1.13, where \u0027abort\u0027 verb was added to cleanwait. I\u0027m guessing that\u0027ll be done in another patch?","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"6f9c6f41baa76e983b4253256fb5bc52442c05bc","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                                                 \u0027raid_level\u0027: \u00271\u0027}]}"},{"line_number":181,"context_line":"        self.client.set_node_raid_config(node[\u0027uuid\u0027], target_raid_config)"},{"line_number":182,"context_line":"        _, ret \u003d self.client.show_node(node[\u0027uuid\u0027])"},{"line_number":183,"context_line":"        self.assertEqual(target_raid_config, ret[\u0027target_raid_config\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_9a4a0b54","line":183,"in_reply_to":"5a5ae5dd_37f877e5","updated":"2016-02-08 12:07:25.000000000","message":"OK, I will do it in separated patch.","commit_id":"fb59f9bcd24c433eea22838c2d318fdfd1868e3f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"979d9c8e72e31ee25c6eab646c44e24d5381580d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        raise exceptions.TimeoutException(message)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @test.idempotent_id(\u0027cd8afa5e-3f57-4e43-8185-beb83d3c9015\u0027)"},{"line_number":61,"context_line":"    def test_list_nodestates(self):"},{"line_number":62,"context_line":"        _, nodestates \u003d self.client.list_nodestates(self.node[\u0027uuid\u0027])"},{"line_number":63,"context_line":"        for key in nodestates:"},{"line_number":64,"context_line":"            self.assertEqual(nodestates[key], self.node[key])"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_a7c60e14","line":61,"updated":"2016-05-24 15:29:16.000000000","message":"I *think* it does not work, as the node in resource_setup is always created with 1.1 version IIUC, and this test runs with all the microversions tested in this file.","commit_id":"b365b40be4639d56ccad10be664b28e0445eaac6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"979d9c8e72e31ee25c6eab646c44e24d5381580d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self._validate_provision_state(node[\u0027uuid\u0027], target_state)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class TestNodeStatesV1_2(TestNodeStates):"},{"line_number":90,"context_line":"    min_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"},{"line_number":91,"context_line":"                                      versions.MINOR_2_AVAILABLE_STATE)"},{"line_number":92,"context_line":"    max_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_27ca1e50","line":89,"updated":"2016-05-24 15:29:16.000000000","message":"Do we really need to run test_list_nodestates and test_set_node_power_state for each api microversion test? As this is what happens now when you inherit from TestNodeStates.\n\nIt makes some sense, eg we ensure that both show and list_node_states use the same microversion, or that we don\u0027t break power states, but I\u0027m not sure.","commit_id":"b365b40be4639d56ccad10be664b28e0445eaac6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"979d9c8e72e31ee25c6eab646c44e24d5381580d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            self._validate_provision_state(node[\u0027uuid\u0027], target_state)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class TestNodeStatesV1_12(TestNodeStatesV1_11):"},{"line_number":174,"context_line":"    min_microversion \u003d \u0027{}.{}\u0027.format(versions.BASE_VERSION,"},{"line_number":175,"context_line":"                                      versions.MINOR_12_RAID_CONFIG)"},{"line_number":176,"context_line":"    max_microversion \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_a78e0e25","line":173,"updated":"2016-05-24 15:29:16.000000000","message":"This will fail, as will be running test_set_node_provision_state from TestNodeStates base class, which will be checking for states that were present in 1.1, not 1.12","commit_id":"b365b40be4639d56ccad10be664b28e0445eaac6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5975c8345f164ad984009273cde94d88171727f8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from ironic_tempest_plugin.tests.api.admin import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class _TestNodeStates(base.BaseBaremetalTest):"},{"line_number":24,"context_line":"    \"\"\"Tests for baremetal NodeStates.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_97fcb13f","line":23,"updated":"2016-05-25 09:21:14.000000000","message":"This test case is still being run, disregarding _ in the beginning of the name, will make it a mixin instead.","commit_id":"b8c7518a532d1e72c3a5972b27b55192fcbf5953"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e4099adbf0ed99c0cd598e9abb5c425d1f0a8ade","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def test_set_node_provision_state(self):"},{"line_number":81,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027])"},{"line_number":82,"context_line":"        # Nodes appear in NONE state by default until v1.1"},{"line_number":83,"context_line":"        self.assertEqual(None, node[\u0027provision_state\u0027])"},{"line_number":84,"context_line":"        provision_states_list \u003d [\u0027active\u0027, \u0027deleted\u0027]"},{"line_number":85,"context_line":"        target_states_list \u003d [\u0027active\u0027, None]"},{"line_number":86,"context_line":"        for (provision_state, target_state) in zip(provision_states_list,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_6a083fda","line":83,"range":{"start_line":83,"start_character":13,"end_line":83,"end_character":24},"updated":"2016-05-25 11:23:36.000000000","message":"nit: assertIsNone","commit_id":"2f6d37129bb6197a091f0d4a5f1ff96ebac42396"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e4099adbf0ed99c0cd598e9abb5c425d1f0a8ade","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(None, node[\u0027provision_state\u0027])"},{"line_number":84,"context_line":"        provision_states_list \u003d [\u0027active\u0027, \u0027deleted\u0027]"},{"line_number":85,"context_line":"        target_states_list \u003d [\u0027active\u0027, None]"},{"line_number":86,"context_line":"        for (provision_state, target_state) in zip(provision_states_list,"},{"line_number":87,"context_line":"                                                   target_states_list):"},{"line_number":88,"context_line":"            self.client.set_node_provision_state(node[\u0027uuid\u0027], provision_state)"},{"line_number":89,"context_line":"            self._validate_provision_state(node[\u0027uuid\u0027], target_state)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class TestNodeStatesV1_2(TestNodeStatesMixin, base.BaseBaremetalTest):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_8abac3df","line":89,"range":{"start_line":86,"start_character":0,"end_line":89,"end_character":70},"updated":"2016-05-25 11:23:36.000000000","message":"nit: we could move this snippet to a helper method","commit_id":"2f6d37129bb6197a091f0d4a5f1ff96ebac42396"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9df4146b92765b2fcbc954a792e1d676eff82d57","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(None, node[\u0027provision_state\u0027])"},{"line_number":84,"context_line":"        provision_states_list \u003d [\u0027active\u0027, \u0027deleted\u0027]"},{"line_number":85,"context_line":"        target_states_list \u003d [\u0027active\u0027, None]"},{"line_number":86,"context_line":"        for (provision_state, target_state) in zip(provision_states_list,"},{"line_number":87,"context_line":"                                                   target_states_list):"},{"line_number":88,"context_line":"            self.client.set_node_provision_state(node[\u0027uuid\u0027], provision_state)"},{"line_number":89,"context_line":"            self._validate_provision_state(node[\u0027uuid\u0027], target_state)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class TestNodeStatesV1_2(TestNodeStatesMixin, base.BaseBaremetalTest):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_edaa89d1","line":89,"range":{"start_line":86,"start_character":0,"end_line":89,"end_character":70},"in_reply_to":"bab6814e_0d142d42","updated":"2016-05-25 11:35:35.000000000","message":"I\u0027m an idiot, these are already running, apparently with the fake driver :)","commit_id":"2f6d37129bb6197a091f0d4a5f1ff96ebac42396"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"1a356b399008d6517ada634ba476e381486eaccb","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(None, node[\u0027provision_state\u0027])"},{"line_number":84,"context_line":"        provision_states_list \u003d [\u0027active\u0027, \u0027deleted\u0027]"},{"line_number":85,"context_line":"        target_states_list \u003d [\u0027active\u0027, None]"},{"line_number":86,"context_line":"        for (provision_state, target_state) in zip(provision_states_list,"},{"line_number":87,"context_line":"                                                   target_states_list):"},{"line_number":88,"context_line":"            self.client.set_node_provision_state(node[\u0027uuid\u0027], provision_state)"},{"line_number":89,"context_line":"            self._validate_provision_state(node[\u0027uuid\u0027], target_state)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class TestNodeStatesV1_2(TestNodeStatesMixin, base.BaseBaremetalTest):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_0d142d42","line":89,"range":{"start_line":86,"start_character":0,"end_line":89,"end_character":70},"in_reply_to":"bab6814e_8abac3df","updated":"2016-05-25 11:33:31.000000000","message":"I\u0027d be a bit surprised if this works without setting instance_info, unless this is run with the fake driver...\n\nIf it does somehow work, it\u0027s going to add another 10 minutes or whatever to our tempest runs (times the number of times this happens below)","commit_id":"2f6d37129bb6197a091f0d4a5f1ff96ebac42396"}]}
