)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"41a98df120ce03c0f366e9d664450285ff9f282b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use new log style when LOG.error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use new log style where Logger.exception() is used by passing an"},{"line_number":10,"context_line":"exception object as the argument[1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] http://docs.openstack.org/developer/oslo.log/usage.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_53db6aec","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":40},"updated":"2015-12-28 10:12:15.000000000","message":"Title talking about error, and here exception","commit_id":"af65b4295c7c6032cd66d3909bbacbf02dbd7986"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"5e2efaaf6f9c54144f1d5b9cb34a83171ee0862a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Use new log style where Logger.exception() is used by passing an"},{"line_number":10,"context_line":"exception object as the argument[1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] http://docs.openstack.org/developer/oslo.log/usage.html"},{"line_number":13,"context_line":"Closes-Bug: #1529534"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I16f78e7c4b0b656b78339758bae2a6d1dcd43a3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_dc3d10de","line":12,"updated":"2015-12-29 08:56:32.000000000","message":"The message is not so clear at first glimpse. You are talking about this:\nhttp://docs.openstack.org/developer/oslo.log/usage.html#no-more-implicit-conversion-to-unicode-str\n\nAgree with Anton, It\u0027s better to mention both of exception() and error()","commit_id":"af65b4295c7c6032cd66d3909bbacbf02dbd7986"}],"ironic/common/glance_service/base_image_service.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"41a98df120ce03c0f366e9d664450285ff9f282b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                    reason \u003d six.text_type(e)"},{"line_number":138,"context_line":"                    raise exception.GlanceConnectionFailed(host\u003dhost,"},{"line_number":139,"context_line":"                                                           port\u003dport,"},{"line_number":140,"context_line":"                                                           reason\u003dreason)"},{"line_number":141,"context_line":"                time.sleep(1)"},{"line_number":142,"context_line":"            except image_excs as e:"},{"line_number":143,"context_line":"                exc_type, exc_value, exc_trace \u003d sys.exc_info()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_93b9d27b","line":140,"range":{"start_line":140,"start_character":66,"end_line":140,"end_character":72},"updated":"2015-12-28 10:12:15.000000000","message":"It would be better to wrap it on same line, as it was with str(), also you didn\u0027t mention about this change in commit message","commit_id":"af65b4295c7c6032cd66d3909bbacbf02dbd7986"}],"ironic/common/images.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"41a98df120ce03c0f366e9d664450285ff9f282b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except Exception as e:"},{"line_number":150,"context_line":"            unicode_exception \u003d six.text_type(e)"},{"line_number":151,"context_line":"            LOG.exception(_LE(\"vfat image creation failed. Error: %s\"),"},{"line_number":152,"context_line":"                          unicode_exception)"},{"line_number":153,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027vfat\u0027, error\u003de)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_7342266a","line":152,"range":{"start_line":152,"start_character":26,"end_line":152,"end_character":43},"updated":"2015-12-28 10:12:15.000000000","message":"There are no needs to pass exception info here, log exception will add it by itself","commit_id":"af65b4295c7c6032cd66d3909bbacbf02dbd7986"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"734c5a5fecd4bfe317870236ff3fccb91c6f0e49","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except Exception as e:"},{"line_number":150,"context_line":"            unicode_exception \u003d six.text_type(e)"},{"line_number":151,"context_line":"            LOG.exception(_LE(\"vfat image creation failed. Error: %s\"),"},{"line_number":152,"context_line":"                          unicode_exception)"},{"line_number":153,"context_line":"            raise exception.ImageCreationFailed(image_type\u003d\u0027vfat\u0027, error\u003de)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_be283c34","line":152,"range":{"start_line":152,"start_character":26,"end_line":152,"end_character":43},"in_reply_to":"1a7b0d38_7342266a","updated":"2015-12-29 07:04:31.000000000","message":"Agree with Anton. There is no need to use text_type in this case.\n\nThe key point is that we need to pass text type as a first argument of LOG.xxxx methods. However, this is not a case. Note that %s does the same thing.","commit_id":"af65b4295c7c6032cd66d3909bbacbf02dbd7986"}],"ironic/common/service.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"41a98df120ce03c0f366e9d664450285ff9f282b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            self.rpcserver.wait()"},{"line_number":96,"context_line":"        except Exception as e:"},{"line_number":97,"context_line":"            LOG.exception(_LE(\u0027Service error occurred when stopping the \u0027"},{"line_number":98,"context_line":"                              \u0027RPC server. Error: %s\u0027), six.text_type(e))"},{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            self.manager.del_host(deregister\u003dself.deregister)"},{"line_number":101,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_d31f5a6a","line":98,"range":{"start_line":98,"start_character":60,"end_line":98,"end_character":69},"updated":"2015-12-28 10:12:15.000000000","message":"ditto","commit_id":"af65b4295c7c6032cd66d3909bbacbf02dbd7986"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"41a98df120ce03c0f366e9d664450285ff9f282b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.manager.del_host(deregister\u003dself.deregister)"},{"line_number":101,"context_line":"        except Exception as e:"},{"line_number":102,"context_line":"            LOG.exception(_LE(\u0027Service error occurred when cleaning up \u0027"},{"line_number":103,"context_line":"                              \u0027the RPC manager. Error: %s\u0027), six.text_type(e))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        super(RPCService, self).stop(graceful\u003dTrue)"},{"line_number":106,"context_line":"        LOG.info(_LI(\u0027Stopped RPC server for service %(service)s on host \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_530cca40","line":103,"range":{"start_line":103,"start_character":65,"end_line":103,"end_character":74},"updated":"2015-12-28 10:12:15.000000000","message":"ditto","commit_id":"af65b4295c7c6032cd66d3909bbacbf02dbd7986"}]}