)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f487f22249bb2b342526a990490ef623a4f67153","unresolved":false,"context_lines":[{"line_number":500,"context_line":"# of inactivity by default. IdleTimeout\u003d0 means AMT will not"},{"line_number":501,"context_line":"# go to sleep at all. Setting awake_interval\u003d0 will disable"},{"line_number":502,"context_line":"# awake call. (integer value)"},{"line_number":503,"context_line":"#awake_interval\u003d60"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"# Maximum number of times to attempt an AMT operation, before"},{"line_number":506,"context_line":"# failing (integer value)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa69d971_0ef100cd","line":503,"updated":"2016-01-06 12:12:36.000000000","message":"this needs to be regenerated.","commit_id":"552f993cfa3b26880afc7d81d24937b93f12abc7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"da2b91f1471001fb8afbe48cf4d88442cafd0da2","unresolved":false,"context_lines":[{"line_number":500,"context_line":"# of inactivity by default. IdleTimeout\u003d0 means AMT will not"},{"line_number":501,"context_line":"# go to sleep at all. Setting awake_interval\u003d0 will disable"},{"line_number":502,"context_line":"# awake call. (integer value)"},{"line_number":503,"context_line":"#awake_interval\u003d60"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"# Maximum number of times to attempt an AMT operation, before"},{"line_number":506,"context_line":"# failing (integer value)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa69d971_a2904044","line":503,"in_reply_to":"fa69d971_0ef100cd","updated":"2016-01-11 06:46:57.000000000","message":"These two options are already existed but move from ironic.drivers.modules.amt.power to ironic.drivers.modules.amt.common","commit_id":"552f993cfa3b26880afc7d81d24937b93f12abc7"}],"ironic/drivers/modules/amt/common.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f487f22249bb2b342526a990490ef623a4f67153","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    cfg.IntOpt(\u0027action_wait\u0027,"},{"line_number":70,"context_line":"               default\u003d10,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Amount of time (in seconds) to wait, before retrying \u0027"},{"line_number":72,"context_line":"                      \u0027an AMT operation\u0027)),"},{"line_number":73,"context_line":"]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_aedf9438","line":72,"updated":"2016-01-06 12:12:36.000000000","message":"This is only for waking up, so maybe mention it? Also there should be dots at the end of help strings.","commit_id":"552f993cfa3b26880afc7d81d24937b93f12abc7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"da2b91f1471001fb8afbe48cf4d88442cafd0da2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    cfg.IntOpt(\u0027action_wait\u0027,"},{"line_number":70,"context_line":"               default\u003d10,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Amount of time (in seconds) to wait, before retrying \u0027"},{"line_number":72,"context_line":"                      \u0027an AMT operation\u0027)),"},{"line_number":73,"context_line":"]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_a2bb60e4","line":72,"in_reply_to":"fa69d971_aedf9438","updated":"2016-01-11 06:46:57.000000000","message":"This is not only for wake up, this was used for other actions too, but move it from power.py to common.py","commit_id":"552f993cfa3b26880afc7d81d24937b93f12abc7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f487f22249bb2b342526a990490ef623a4f67153","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                             \u0027max_attempt\u0027: CONF.amt.max_attempts})"},{"line_number":273,"context_line":"                status[\u0027iter\u0027] +\u003d 1"},{"line_number":274,"context_line":"            else:"},{"line_number":275,"context_line":"                LOG.debug((\u0027Successfully wake up AMT interface on node \u0027"},{"line_number":276,"context_line":"                           \u0027%(node_id)s.\u0027), {\u0027node_id\u0027: node.uuid})"},{"line_number":277,"context_line":"                AMT_AWAKE_CACHE[node.uuid] \u003d now"},{"line_number":278,"context_line":"                raise loopingcall.LoopingCallDone()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_4e24d85c","line":275,"updated":"2016-01-06 12:12:36.000000000","message":"nit - woke up","commit_id":"552f993cfa3b26880afc7d81d24937b93f12abc7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"da2b91f1471001fb8afbe48cf4d88442cafd0da2","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                             \u0027max_attempt\u0027: CONF.amt.max_attempts})"},{"line_number":273,"context_line":"                status[\u0027iter\u0027] +\u003d 1"},{"line_number":274,"context_line":"            else:"},{"line_number":275,"context_line":"                LOG.debug((\u0027Successfully wake up AMT interface on node \u0027"},{"line_number":276,"context_line":"                           \u0027%(node_id)s.\u0027), {\u0027node_id\u0027: node.uuid})"},{"line_number":277,"context_line":"                AMT_AWAKE_CACHE[node.uuid] \u003d now"},{"line_number":278,"context_line":"                raise loopingcall.LoopingCallDone()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_a2892028","line":275,"in_reply_to":"fa69d971_4e24d85c","updated":"2016-01-11 06:46:57.000000000","message":"Done","commit_id":"552f993cfa3b26880afc7d81d24937b93f12abc7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e88b79a09202249a305d933f6d2bc8e5bfc62472","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        def _wait(status):"},{"line_number":258,"context_line":"            if status[\u0027iter\u0027] \u003e\u003d CONF.amt.max_attempts:"},{"line_number":259,"context_line":"                LOG.error(_LE(\u0027Unable to wake up AMT interface on node \u0027"},{"line_number":260,"context_line":"                          \u0027%(node_id)s.\u0027),"},{"line_number":261,"context_line":"                          {\u0027node_id\u0027: node.uuid})"},{"line_number":262,"context_line":"                raise exception.AMTConnectFailure()"},{"line_number":263,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_b6e8ec17","line":260,"updated":"2016-01-18 06:35:57.000000000","message":"incorrect indent","commit_id":"b8092cd732e2f957dde441ab16e057f19615b408"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8bd5b27de3b81e89ed1d991496bfaff426587a60","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                      \u0027sleep after 60 seconds of inactivity by default. \u0027"},{"line_number":63,"context_line":"                      \u0027IdleTimeout\u003d0 means AMT will not go to sleep at all. \u0027"},{"line_number":64,"context_line":"                      \u0027Setting awake_interval\u003d0 will disable awake call.\u0027)),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027max_attempts\u0027,"},{"line_number":66,"context_line":"               default\u003d3,"},{"line_number":67,"context_line":"               help\u003d_(\u0027Maximum number of times to attempt an AMT operation, \u0027"},{"line_number":68,"context_line":"                      \u0027before failing.\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_441ff16b","line":65,"range":{"start_line":65,"start_character":16,"end_line":65,"end_character":28},"updated":"2016-02-06 12:53:03.000000000","message":"Would it be useful to cap upper limit for this config parameter?","commit_id":"62e20363d4321c7d6499c27835b993126dac1b1b"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"f61f703459bd1a5b9d683f9ec319f7401f52eaa7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                      \u0027IdleTimeout\u003d0 means AMT will not go to sleep at all. \u0027"},{"line_number":64,"context_line":"                      \u0027Setting awake_interval\u003d0 will disable awake call.\u0027)),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027max_attempts\u0027,"},{"line_number":66,"context_line":"               default\u003d3,"},{"line_number":67,"context_line":"               help\u003d_(\u0027Maximum number of times to attempt an AMT operation, \u0027"},{"line_number":68,"context_line":"                      \u0027before failing.\u0027)),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027action_wait\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_ee3e0527","line":66,"updated":"2016-01-31 08:43:45.000000000","message":"Should we add \u0027min\u003d0\u0027 here as L58?","commit_id":"62e20363d4321c7d6499c27835b993126dac1b1b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8bd5b27de3b81e89ed1d991496bfaff426587a60","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                      \u0027Setting awake_interval\u003d0 will disable awake call.\u0027)),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027max_attempts\u0027,"},{"line_number":66,"context_line":"               default\u003d3,"},{"line_number":67,"context_line":"               help\u003d_(\u0027Maximum number of times to attempt an AMT operation, \u0027"},{"line_number":68,"context_line":"                      \u0027before failing.\u0027)),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027action_wait\u0027,"},{"line_number":70,"context_line":"               default\u003d10,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_619e9808","line":67,"range":{"start_line":67,"start_character":31,"end_line":67,"end_character":37},"updated":"2016-02-06 12:53:03.000000000","message":"nit: Can it be:-\n\u0027Maximum number of attempts to complete an AMT operation.\u0027","commit_id":"62e20363d4321c7d6499c27835b993126dac1b1b"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"f61f703459bd1a5b9d683f9ec319f7401f52eaa7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"               help\u003d_(\u0027Maximum number of times to attempt an AMT operation, \u0027"},{"line_number":68,"context_line":"                      \u0027before failing.\u0027)),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027action_wait\u0027,"},{"line_number":70,"context_line":"               default\u003d10,"},{"line_number":71,"context_line":"               help\u003d_(\u0027Amount of time (in seconds) to wait, before retrying \u0027"},{"line_number":72,"context_line":"                      \u0027an AMT operation.\u0027)),"},{"line_number":73,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_8e4751bb","line":70,"updated":"2016-01-31 08:43:45.000000000","message":"ditto","commit_id":"62e20363d4321c7d6499c27835b993126dac1b1b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8bd5b27de3b81e89ed1d991496bfaff426587a60","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    AMT interface goes to sleep after a period of time if the host is off."},{"line_number":238,"context_line":"    This method will ping AMT interface to wake it up. Because there is"},{"line_number":239,"context_line":"    no guarantee that the AMT address in driver_info is correct, only"},{"line_number":240,"context_line":"    ping the IP five times. In the case where AMT interface is in a deep"},{"line_number":241,"context_line":"    sleep, there is a need to wait longer. So make use max_attempts and"},{"line_number":242,"context_line":"    action_wait options to control the time."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    :param node: an Ironic node object."}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_e4385df0","line":241,"range":{"start_line":240,"start_character":28,"end_line":241,"end_character":42},"updated":"2016-02-06 12:53:03.000000000","message":"Is there any heuristic that can be used to configure max_attempts based on sleep level?","commit_id":"62e20363d4321c7d6499c27835b993126dac1b1b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"8e974bc71c594ebf23b03c9d30cee6758d9ba8f3","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    now \u003d time.time()"},{"line_number":252,"context_line":"    last_awake \u003d AMT_AWAKE_CACHE.get(node.uuid, 0)"},{"line_number":253,"context_line":"    if now - last_awake \u003e awake_interval:"},{"line_number":254,"context_line":"        cmd_args \u003d [\u0027ping\u0027, \u0027-i\u0027, 0.2, \u0027-c\u0027, 5,"},{"line_number":255,"context_line":"                    node.driver_info[\u0027amt_address\u0027]]"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        def _wait(status):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_d353db37","line":254,"updated":"2016-01-29 14:38:52.000000000","message":"It\u0027s really needed to send 5 packets if max_attempts \u003e 1?","commit_id":"62e20363d4321c7d6499c27835b993126dac1b1b"}],"ironic/drivers/modules/amt/power.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f487f22249bb2b342526a990490ef623a4f67153","unresolved":false,"context_lines":[{"line_number":36,"context_line":"pywsman \u003d importutils.try_import(\u0027pywsman\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"},{"line_number":39,"context_line":"CONF.import_opt(\u0027max_attempts\u0027, \u0027ironic.drivers.modules.amt.common\u0027,"},{"line_number":40,"context_line":"                group\u003d\u0027amt\u0027)"},{"line_number":41,"context_line":"CONF.import_opt(\u0027action_wait\u0027, \u0027ironic.drivers.modules.amt.common\u0027,"},{"line_number":42,"context_line":"                group\u003d\u0027amt\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_cea448bb","line":39,"updated":"2016-01-06 12:12:36.000000000","message":"No need to import_opt as you import the whole module on L 33","commit_id":"552f993cfa3b26880afc7d81d24937b93f12abc7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"da2b91f1471001fb8afbe48cf4d88442cafd0da2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"pywsman \u003d importutils.try_import(\u0027pywsman\u0027)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"},{"line_number":39,"context_line":"CONF.import_opt(\u0027max_attempts\u0027, \u0027ironic.drivers.modules.amt.common\u0027,"},{"line_number":40,"context_line":"                group\u003d\u0027amt\u0027)"},{"line_number":41,"context_line":"CONF.import_opt(\u0027action_wait\u0027, \u0027ironic.drivers.modules.amt.common\u0027,"},{"line_number":42,"context_line":"                group\u003d\u0027amt\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_bd95c533","line":39,"in_reply_to":"fa69d971_cea448bb","updated":"2016-01-11 06:46:57.000000000","message":"Done","commit_id":"552f993cfa3b26880afc7d81d24937b93f12abc7"}]}
