)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9a6e9051143f0e956abe1c2885309223ed219ffd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA\u003d$(trueorfalse False IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# The path to the libvirt hooks directory, used if IRONIC_VM_LOG_ROTATE is True"},{"line_number":139,"context_line":"IRONIC_LIBVIRT_HOOKS_PATH\u003d${IRONIC_LIBVIRT_HOOKS_PATH:-/etc/libvirt/hooks/}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":142,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa69d971_f6b32296","line":139,"range":{"start_line":139,"start_character":73,"end_line":139,"end_character":74},"updated":"2016-01-06 13:25:51.000000000","message":"nit: trailing slash is not needed","commit_id":"ac54456a8ed225512fd5702952a454675280db75"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0cd7c893f164aa5996d7809b92f7d21ceb9392f0","unresolved":false,"context_lines":[{"line_number":136,"context_line":"IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA\u003d$(trueorfalse False IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# The path to the libvirt hooks directory, used if IRONIC_VM_LOG_ROTATE is True"},{"line_number":139,"context_line":"IRONIC_LIBVIRT_HOOKS_PATH\u003d${IRONIC_LIBVIRT_HOOKS_PATH:-/etc/libvirt/hooks/}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":142,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa69d971_2778628f","line":139,"range":{"start_line":139,"start_character":73,"end_line":139,"end_character":74},"in_reply_to":"fa69d971_8c405537","updated":"2016-01-07 17:34:17.000000000","message":"Talked in IRC, we\u0027re just going to email the list as a heads up. This variable hasn\u0027t been in long.","commit_id":"ac54456a8ed225512fd5702952a454675280db75"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f7d88df6e553629eb86056cd264e10e02ec66cbc","unresolved":false,"context_lines":[{"line_number":136,"context_line":"IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA\u003d$(trueorfalse False IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# The path to the libvirt hooks directory, used if IRONIC_VM_LOG_ROTATE is True"},{"line_number":139,"context_line":"IRONIC_LIBVIRT_HOOKS_PATH\u003d${IRONIC_LIBVIRT_HOOKS_PATH:-/etc/libvirt/hooks/}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"},{"line_number":142,"context_line":"function get_pxe_boot_file {"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa69d971_8c405537","line":139,"range":{"start_line":139,"start_character":73,"end_line":139,"end_character":74},"in_reply_to":"fa69d971_f6b32296","updated":"2016-01-07 17:12:21.000000000","message":"So dumb question. We had IRONIC_QEMU_HOOK_PATH before. What if someone is using that and then upgrades to this. It\u0027ll break their environment. Is this something we care about? (I\u0027m not sure since this is devstack and not our code.)","commit_id":"ac54456a8ed225512fd5702952a454675280db75"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9a6e9051143f0e956abe1c2885309223ed219ffd","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    sudo mkdir -p $IRONIC_LIBVIRT_HOOKS_PATH"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    # Copy the qemu hook to the right directory"},{"line_number":567,"context_line":"    sudo cp $IRONIC_DEVSTACK_FILES_DIR/hooks/qemu $IRONIC_LIBVIRT_HOOKS_PATH/qemu"},{"line_number":568,"context_line":"    sudo sed -e \""},{"line_number":569,"context_line":"        s|%LOG_DIR%|$IRONIC_VM_LOG_DIR|g;"},{"line_number":570,"context_line":"    \" -i $IRONIC_LIBVIRT_HOOKS_PATH/qemu"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa69d971_165d9646","line":567,"updated":"2016-01-06 13:25:51.000000000","message":"nit: maybe issue a warning if file already exists (and is not identical to our version)?","commit_id":"ac54456a8ed225512fd5702952a454675280db75"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"0cd7c893f164aa5996d7809b92f7d21ceb9392f0","unresolved":false,"context_lines":[{"line_number":564,"context_line":"    sudo mkdir -p $IRONIC_LIBVIRT_HOOKS_PATH"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    # Copy the qemu hook to the right directory"},{"line_number":567,"context_line":"    sudo cp $IRONIC_DEVSTACK_FILES_DIR/hooks/qemu $IRONIC_LIBVIRT_HOOKS_PATH/qemu"},{"line_number":568,"context_line":"    sudo sed -e \""},{"line_number":569,"context_line":"        s|%LOG_DIR%|$IRONIC_VM_LOG_DIR|g;"},{"line_number":570,"context_line":"    \" -i $IRONIC_LIBVIRT_HOOKS_PATH/qemu"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa69d971_4761d6d2","line":567,"in_reply_to":"fa69d971_165d9646","updated":"2016-01-07 17:34:17.000000000","message":"As opposed to everything else devstack stomps on without warning? :)","commit_id":"ac54456a8ed225512fd5702952a454675280db75"}]}
