)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"3f47ba57f5841caba53764edfd592486ea8af7d0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1) Add dump_sdr() function for dumping SDR data to a file."},{"line_number":10,"context_line":"2) Add returns (stdout, stderr) to send_raw()."},{"line_number":11,"context_line":"This changes intended for out of tree drivers which use ipmi and"},{"line_number":12,"context_line":"should not double Ironic code base."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibe0efdbf5133356fc5e7d9129913f9dd0307e9af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bae84128_2e7c09eb","line":12,"updated":"2016-02-24 06:19:47.000000000","message":"the second change looks reasonable, but wonder should we add dump_sdr() only for an out-of-tree driver?","commit_id":"59ebc51fa685827be3b9406d765ec47145a37a4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f97bfe44b2dab812a94e8826ed437ba2915a6627","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1) Add dump_sdr() function for dumping SDR data to a file."},{"line_number":10,"context_line":"2) Add returns (stdout, stderr) to send_raw()."},{"line_number":11,"context_line":"This changes intended for out of tree drivers which use ipmi and"},{"line_number":12,"context_line":"should not double Ironic code base."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibe0efdbf5133356fc5e7d9129913f9dd0307e9af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bae84128_4b1b3481","line":12,"in_reply_to":"bae84128_2e7c09eb","updated":"2016-02-24 09:59:01.000000000","message":"We can do this https://review.openstack.org/#/c/283499/3/ironic_staging_drivers/intel_nm/ipmi.py but code depend on ipmitool driver internals. Or unneeded copy-paste from ipmitool code is needed.","commit_id":"59ebc51fa685827be3b9406d765ec47145a37a4d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c65ccbb49bbe393dd7cfae7d3a20a272a64e8879","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1) Add dump_sdr() function for dumping SDR data to a file."},{"line_number":10,"context_line":"2) Add returns (stdout, stderr) to send_raw()."},{"line_number":11,"context_line":"This changes intended for out of tree drivers which use ipmi and"},{"line_number":12,"context_line":"should not double Ironic code base."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibe0efdbf5133356fc5e7d9129913f9dd0307e9af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_554dd23c","line":12,"updated":"2016-03-03 10:22:08.000000000","message":"I would prefer to separate these changes into their own patches cause they are unrelated AFAIUI.\n\nI think that\u0027s a good behavior and make the project logs organized if the patches only makes one and only one thing.","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2e1a55a3b6c5feca19e354f6fd474a5a39b8dc84","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1) Add dump_sdr() function for dumping SDR data to a file."},{"line_number":10,"context_line":"2) Add returns (stdout, stderr) to send_raw()."},{"line_number":11,"context_line":"This changes intended for out of tree drivers which use ipmi and"},{"line_number":12,"context_line":"should not double Ironic code base."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibe0efdbf5133356fc5e7d9129913f9dd0307e9af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_83127255","line":12,"in_reply_to":"7af24918_554dd23c","updated":"2016-03-03 14:21:29.000000000","message":"Done","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9b07f43150f9f69449384b698cdb271120f7f89f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1) Add dump_sdr() function for dumping SDR data to a file."},{"line_number":10,"context_line":"2) Add returns (stdout, stderr) to send_raw()."},{"line_number":11,"context_line":"This changes intended for out of tree drivers which use ipmi and"},{"line_number":12,"context_line":"should not double Ironic code base."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibe0efdbf5133356fc5e7d9129913f9dd0307e9af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_a61eaab8","line":12,"in_reply_to":"7af24918_554dd23c","updated":"2016-03-03 11:19:29.000000000","message":"Will do.","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"40abf65a7c833d47a5a406506ee937153da0d6f7","unresolved":false,"context_lines":[{"line_number":670,"context_line":"    except (exception.PasswordFileFailedToCreate,"},{"line_number":671,"context_line":"            processutils.ProcessExecutionError) as e:"},{"line_number":672,"context_line":"        LOG.exception(_LE(\u0027IPMI \"raw bytes\" failed for node %(node_id)s \u0027"},{"line_number":673,"context_line":"                      \u0027with error: %(error)s.\u0027),"},{"line_number":674,"context_line":"                      {\u0027node_id\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":675,"context_line":"        raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":676,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_f29b5464","line":673,"updated":"2016-03-03 10:13:49.000000000","message":"here too","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c65ccbb49bbe393dd7cfae7d3a20a272a64e8879","unresolved":false,"context_lines":[{"line_number":677,"context_line":"    return out, err"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"def dump_sdr(task, filename):"},{"line_number":681,"context_line":"    \"\"\"Dump SDR data to a file."},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    :param task: a TaskManager instance."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_1524ea5d","line":680,"updated":"2016-03-03 10:22:08.000000000","message":"I don\u0027t see this being used anywhere?\n\nI see send_raw being used in some places and also exposed as a vendor passthru method. What about dump_sdr() ? How and where we are going to use it?","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9b07f43150f9f69449384b698cdb271120f7f89f","unresolved":false,"context_lines":[{"line_number":677,"context_line":"    return out, err"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"def dump_sdr(task, filename):"},{"line_number":681,"context_line":"    \"\"\"Dump SDR data to a file."},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    :param task: a TaskManager instance."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_a6e34aa3","line":680,"in_reply_to":"7af24918_1524ea5d","updated":"2016-03-03 11:19:29.000000000","message":"Good question. Here: https://review.openstack.org/#/c/283499/","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c65ccbb49bbe393dd7cfae7d3a20a272a64e8879","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    \"\"\"Dump SDR data to a file."},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    :param task: a TaskManager instance."},{"line_number":684,"context_line":"    :param filename: File name for dump."},{"line_number":685,"context_line":"    :raises: IPMIFailure on an error from ipmitool."},{"line_number":686,"context_line":"    :raises: MissingParameterValue if a required parameter is missing."},{"line_number":687,"context_line":"    :raises: InvalidParameterValue when an invalid value is specified."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_95491a63","line":684,"updated":"2016-03-03 10:22:08.000000000","message":"Is it the name of the file (does it get dumped to a specific location with that name) ?\n\nOr it\u0027s the file path?","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2e1a55a3b6c5feca19e354f6fd474a5a39b8dc84","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    \"\"\"Dump SDR data to a file."},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    :param task: a TaskManager instance."},{"line_number":684,"context_line":"    :param filename: File name for dump."},{"line_number":685,"context_line":"    :raises: IPMIFailure on an error from ipmitool."},{"line_number":686,"context_line":"    :raises: MissingParameterValue if a required parameter is missing."},{"line_number":687,"context_line":"    :raises: InvalidParameterValue when an invalid value is specified."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_03a2e2fc","line":684,"in_reply_to":"7af24918_95491a63","updated":"2016-03-03 14:21:29.000000000","message":"Done","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9b07f43150f9f69449384b698cdb271120f7f89f","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    \"\"\"Dump SDR data to a file."},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    :param task: a TaskManager instance."},{"line_number":684,"context_line":"    :param filename: File name for dump."},{"line_number":685,"context_line":"    :raises: IPMIFailure on an error from ipmitool."},{"line_number":686,"context_line":"    :raises: MissingParameterValue if a required parameter is missing."},{"line_number":687,"context_line":"    :raises: InvalidParameterValue when an invalid value is specified."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_2681fac3","line":684,"in_reply_to":"7af24918_95491a63","updated":"2016-03-03 11:19:29.000000000","message":"It\u0027s path. Should be fixed.","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"40abf65a7c833d47a5a406506ee937153da0d6f7","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    except (exception.PasswordFileFailedToCreate,"},{"line_number":701,"context_line":"            processutils.ProcessExecutionError) as e:"},{"line_number":702,"context_line":"        LOG.exception(_LE(\u0027IPMI \"sdr dump\" failed for node %(node_id)s \u0027"},{"line_number":703,"context_line":"                      \u0027with error: %(error)s.\u0027),"},{"line_number":704,"context_line":"                      {\u0027node_id\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":705,"context_line":"        raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":706,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_327bfc29","line":703,"updated":"2016-03-03 10:13:49.000000000","message":"nit - wrong indentation.","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2e1a55a3b6c5feca19e354f6fd474a5a39b8dc84","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    except (exception.PasswordFileFailedToCreate,"},{"line_number":701,"context_line":"            processutils.ProcessExecutionError) as e:"},{"line_number":702,"context_line":"        LOG.exception(_LE(\u0027IPMI \"sdr dump\" failed for node %(node_id)s \u0027"},{"line_number":703,"context_line":"                      \u0027with error: %(error)s.\u0027),"},{"line_number":704,"context_line":"                      {\u0027node_id\u0027: node_uuid, \u0027error\u0027: e})"},{"line_number":705,"context_line":"        raise exception.IPMIFailure(cmd\u003dcmd)"},{"line_number":706,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c84bfc85","line":703,"in_reply_to":"7af24918_327bfc29","updated":"2016-03-03 14:21:29.000000000","message":"I tried to change this, but pep8 fails.","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"}],"ironic/tests/unit/drivers/modules/test_ipmitool.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"40abf65a7c833d47a5a406506ee937153da0d6f7","unresolved":false,"context_lines":[{"line_number":2104,"context_line":"    def test_dump_sdr_fail(self, mock_exec):"},{"line_number":2105,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":2106,"context_line":"            mock_exec.side_effect \u003d iter("},{"line_number":2107,"context_line":"                [processutils.ProcessExecutionError()])"},{"line_number":2108,"context_line":"            self.assertRaises(exception.IPMIFailure, ipmi.dump_sdr, task,"},{"line_number":2109,"context_line":"                              \u0027foo_file\u0027)"},{"line_number":2110,"context_line":"        mock_exec.assert_called_once_with(self.info, \u0027sdr dump foo_file\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_12cfe029","line":2107,"updated":"2016-03-03 10:13:49.000000000","message":"IIRC this was fixed in mock, you can just do \n\n mock_exec.side_effect \u003d processutils.ProcessExecutionError()","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2e1a55a3b6c5feca19e354f6fd474a5a39b8dc84","unresolved":false,"context_lines":[{"line_number":2104,"context_line":"    def test_dump_sdr_fail(self, mock_exec):"},{"line_number":2105,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":2106,"context_line":"            mock_exec.side_effect \u003d iter("},{"line_number":2107,"context_line":"                [processutils.ProcessExecutionError()])"},{"line_number":2108,"context_line":"            self.assertRaises(exception.IPMIFailure, ipmi.dump_sdr, task,"},{"line_number":2109,"context_line":"                              \u0027foo_file\u0027)"},{"line_number":2110,"context_line":"        mock_exec.assert_called_once_with(self.info, \u0027sdr dump foo_file\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_e87eb868","line":2107,"in_reply_to":"7af24918_12cfe029","updated":"2016-03-03 14:21:29.000000000","message":"Done","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"40abf65a7c833d47a5a406506ee937153da0d6f7","unresolved":false,"context_lines":[{"line_number":2107,"context_line":"                [processutils.ProcessExecutionError()])"},{"line_number":2108,"context_line":"            self.assertRaises(exception.IPMIFailure, ipmi.dump_sdr, task,"},{"line_number":2109,"context_line":"                              \u0027foo_file\u0027)"},{"line_number":2110,"context_line":"        mock_exec.assert_called_once_with(self.info, \u0027sdr dump foo_file\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_d213b8b6","line":2110,"updated":"2016-03-03 10:13:49.000000000","message":"Also please add a unittest to check that send_raw now returns (out, err)","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2e1a55a3b6c5feca19e354f6fd474a5a39b8dc84","unresolved":false,"context_lines":[{"line_number":2107,"context_line":"                [processutils.ProcessExecutionError()])"},{"line_number":2108,"context_line":"            self.assertRaises(exception.IPMIFailure, ipmi.dump_sdr, task,"},{"line_number":2109,"context_line":"                              \u0027foo_file\u0027)"},{"line_number":2110,"context_line":"        mock_exec.assert_called_once_with(self.info, \u0027sdr dump foo_file\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_43234aa7","line":2110,"in_reply_to":"7af24918_d213b8b6","updated":"2016-03-03 14:21:29.000000000","message":"Done","commit_id":"fa70ec8c23d9b0246a344ab15025a4c963daf4a2"}]}
