)]}'
{"ironic/drivers/modules/intel/nm_commands.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7dbee23b919be38eb7de6d4e20aa466d88a9e644","unresolved":false,"context_lines":[{"line_number":83,"context_line":"IPMI_VERSIONS \u003d {"},{"line_number":84,"context_line":"    0x01: \u00271.0\u0027,"},{"line_number":85,"context_line":"    0x02: \u00272.0\u0027,"},{"line_number":86,"context_line":"    0x03: \u00273.0\u0027"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_5a545420","line":86,"updated":"2016-01-26 12:30:27.000000000","message":"Might be worth adding a comment about this as ipmi 3.0 does not exist :)","commit_id":"b74af90b4833ba23b5872a864c276cc0f82d189e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"40b731f4067a73195f836c08c92af94cf93479e4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"IPMI_VERSIONS \u003d {"},{"line_number":84,"context_line":"    0x01: \u00271.0\u0027,"},{"line_number":85,"context_line":"    0x02: \u00272.0\u0027,"},{"line_number":86,"context_line":"    0x03: \u00273.0\u0027"},{"line_number":87,"context_line":"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_a2a68151","line":86,"in_reply_to":"9a68dd71_5a545420","updated":"2016-01-26 15:07:24.000000000","message":"This is NM IPMI version, I plan to add extended comments after testing.","commit_id":"b74af90b4833ba23b5872a864c276cc0f82d189e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7dbee23b919be38eb7de6d4e20aa466d88a9e644","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def _int16(x):"},{"line_number":140,"context_line":"    return int(x, 16)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def _raw_to_int(raw_data):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_3ff072c9","line":140,"updated":"2016-01-26 12:30:27.000000000","message":"It seems that this function is not really needed.","commit_id":"b74af90b4833ba23b5872a864c276cc0f82d189e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"40b731f4067a73195f836c08c92af94cf93479e4","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def _int16(x):"},{"line_number":140,"context_line":"    return int(x, 16)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def _raw_to_int(raw_data):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_4249c58d","line":140,"in_reply_to":"9a68dd71_3ff072c9","updated":"2016-01-26 15:07:24.000000000","message":"Done","commit_id":"b74af90b4833ba23b5872a864c276cc0f82d189e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7dbee23b919be38eb7de6d4e20aa466d88a9e644","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"def _add_to_dict(data_dict, values, names):"},{"line_number":166,"context_line":"    for i in range(len(values)):"},{"line_number":167,"context_line":"        data_dict[names[i]] \u003d values[i]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def _add_domain_policy_id(cmd, data, nm_command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_7f4a6a29","line":167,"updated":"2016-01-26 12:30:27.000000000","message":"data_dict.update(dict(zip(names, values)))?","commit_id":"b74af90b4833ba23b5872a864c276cc0f82d189e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"40b731f4067a73195f836c08c92af94cf93479e4","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"def _add_to_dict(data_dict, values, names):"},{"line_number":166,"context_line":"    for i in range(len(values)):"},{"line_number":167,"context_line":"        data_dict[names[i]] \u003d values[i]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def _add_domain_policy_id(cmd, data, nm_command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_25393b42","line":167,"in_reply_to":"9a68dd71_7f4a6a29","updated":"2016-01-26 15:07:24.000000000","message":"Done","commit_id":"b74af90b4833ba23b5872a864c276cc0f82d189e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7dbee23b919be38eb7de6d4e20aa466d88a9e644","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    return cmd"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"def get_version(data):"},{"line_number":388,"context_line":"    cmd \u003d []"},{"line_number":389,"context_line":"    _append_to_command(cmd, INTEL_NM_NETFN)"},{"line_number":390,"context_line":"    _append_to_command(cmd, INTEL_NM_VERSION_GET)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_b91c7d14","line":387,"updated":"2016-01-26 12:30:27.000000000","message":"Why do we need data here?","commit_id":"b74af90b4833ba23b5872a864c276cc0f82d189e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"40b731f4067a73195f836c08c92af94cf93479e4","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    return cmd"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"def get_version(data):"},{"line_number":388,"context_line":"    cmd \u003d []"},{"line_number":389,"context_line":"    _append_to_command(cmd, INTEL_NM_NETFN)"},{"line_number":390,"context_line":"    _append_to_command(cmd, INTEL_NM_VERSION_GET)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_65865367","line":387,"in_reply_to":"9a68dd71_b91c7d14","updated":"2016-01-26 15:07:24.000000000","message":"This is simple solution for generalize _execute_nm_command() function in nm_vendor.py","commit_id":"b74af90b4833ba23b5872a864c276cc0f82d189e"}]}
