)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d254b4c13c97258ee6497b033e9eadd778bc2570","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This updates the documentation to include manual cleaning."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"(I haven\u0027t yet tested that these changes are good.)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8f91214911e8916c329c20a140e1d0957b1cc137"},{"line_number":14,"context_line":"Partial-Bug: #1526290"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dae33548_6f246bc4","line":11,"updated":"2016-02-17 19:57:56.000000000","message":"We should delete this after verifying that the patch is good :)","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"}],"doc/source/deploy/cleaning.rst":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0f334eef42cf7b8ff1b06ff1da7b18fe9ab71942","unresolved":false,"context_lines":[{"line_number":93,"context_line":"PUT /v1/nodes/\u003cnode_ident\u003e/states/provision"},{"line_number":94,"context_line":"-------------------------------------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Manual cleaning can only be performed when a node is in the ``manageable``"},{"line_number":97,"context_line":"state. The REST API request to initiate it is available in API version 1.15 and"},{"line_number":98,"context_line":"higher::"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a57f1b5_ef82d851","line":96,"updated":"2016-02-11 06:39:17.000000000","message":"This is double of l80.","commit_id":"7a0eb50fdf51d3504a6ccea8be112e657a8e96f5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0f334eef42cf7b8ff1b06ff1da7b18fe9ab71942","unresolved":false,"context_lines":[{"line_number":124,"context_line":"RAID without non-root volumes, and then all devices would be erased"},{"line_number":125,"context_line":"(in that order)."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"A cleaning step is represented by a dictionary (JSON), in the form::"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  {"},{"line_number":130,"context_line":"      \u0027interface\u0027: \u003cinterface\u003e,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a57f1b5_2f91d099","line":127,"updated":"2016-02-11 06:39:17.000000000","message":"Better move this info before example.","commit_id":"7a0eb50fdf51d3504a6ccea8be112e657a8e96f5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8fb45c1428e4c1899dbe9dd35bbaeeddff02b61d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"RAID without non-root volumes, and then all devices would be erased"},{"line_number":125,"context_line":"(in that order)."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"A cleaning step is represented by a dictionary (JSON), in the form::"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  {"},{"line_number":130,"context_line":"      \u0027interface\u0027: \u003cinterface\u003e,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a57f1b5_d02f78f4","line":127,"in_reply_to":"3a57f1b5_2f91d099","updated":"2016-02-11 07:49:43.000000000","message":"+1","commit_id":"7a0eb50fdf51d3504a6ccea8be112e657a8e96f5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0f334eef42cf7b8ff1b06ff1da7b18fe9ab71942","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    ironic node-set-provision-state"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"The target/verb is \u0027clean\u0027 and the argument \u0027clean-steps\u0027 must be specified."},{"line_number":158,"context_line":"Its value is one of:"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"- a JSON string"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a57f1b5_0f3bb49d","line":157,"updated":"2016-02-11 06:39:17.000000000","message":"Better to provide also examples of this command.","commit_id":"7a0eb50fdf51d3504a6ccea8be112e657a8e96f5"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"612265ff926a4007538d9689a215c2b37a5e1fcf","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    ironic node-set-provision-state"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"The target/verb is \u0027clean\u0027 and the argument \u0027clean-steps\u0027 must be specified."},{"line_number":158,"context_line":"Its value is one of:"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"- a JSON string"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dae33548_baa26097","line":157,"in_reply_to":"3a57f1b5_0f3bb49d","updated":"2016-02-17 07:14:01.000000000","message":"And please add the API micro version info, like --ironic-api-version 1.15 because the default one is still 1.9","commit_id":"7a0eb50fdf51d3504a6ccea8be112e657a8e96f5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8a71741882f85afa514ac0a05eab9e3b6a8bc8a9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"To enable automated cleaning, ensure that your ironic.conf is set as follows: ::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  [conductor]"},{"line_number":49,"context_line":"  clean_nodes\u003dtrue"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This will enable the default set of cleaning steps, based on your hardware and"},{"line_number":52,"context_line":"ironic drivers. If you\u0027re using an agent_* driver, this includes, by default,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_4ffc0772","line":49,"updated":"2016-02-17 19:36:45.000000000","message":"Should be automated_clean, the new option (with maybe reference to the old option)?","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d254b4c13c97258ee6497b033e9eadd778bc2570","unresolved":false,"context_lines":[{"line_number":46,"context_line":"To enable automated cleaning, ensure that your ironic.conf is set as follows: ::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  [conductor]"},{"line_number":49,"context_line":"  clean_nodes\u003dtrue"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This will enable the default set of cleaning steps, based on your hardware and"},{"line_number":52,"context_line":"ironic drivers. If you\u0027re using an agent_* driver, this includes, by default,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_cac2c533","line":49,"in_reply_to":"dae33548_4ffc0772","updated":"2016-02-17 19:57:56.000000000","message":"Oh, it landed? Yes, then \"automated_clean\". I don\u0027t think we should mention the old option; that\u0027ll be in the release notes.","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fc9d6229d2d6e11f62d9763c61dccad71c22617f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"To enable automated cleaning, ensure that your ironic.conf is set as follows: ::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  [conductor]"},{"line_number":49,"context_line":"  clean_nodes\u003dtrue"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"This will enable the default set of cleaning steps, based on your hardware and"},{"line_number":52,"context_line":"ironic drivers. If you\u0027re using an agent_* driver, this includes, by default,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_96c71063","line":49,"in_reply_to":"dae33548_cac2c533","updated":"2016-02-18 17:23:12.000000000","message":"the change was already made in the other patch. I had to rebase to get it :)","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d254b4c13c97258ee6497b033e9eadd778bc2570","unresolved":false,"context_lines":[{"line_number":105,"context_line":"provision state from ``manageable`` state via \u0027target\u0027: \u0027clean\u0027."},{"line_number":106,"context_line":"The PUT will also require the argument \u0027clean_steps\u0027 to be specified. This"},{"line_number":107,"context_line":"is an ordered list of cleaning steps, with a cleaning step being represented"},{"line_number":108,"context_line":"as a dictionary encoded as JSON."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"A cleaning step is represented by a dictionary (JSON), in the form::"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_8adf1d68","line":108,"updated":"2016-02-17 19:57:56.000000000","message":"Maybe delete \u0027, with a cleaning step...\u0027 and end that sentence with a period, and delete the blank line. since line 110 sez that.","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d254b4c13c97258ee6497b033e9eadd778bc2570","unresolved":false,"context_lines":[{"line_number":129,"context_line":"node will be put in ``clean failed`` provision state with an appropriate error"},{"line_number":130,"context_line":"message."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"An example of the request body for this API::"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  \"clean_steps\": [{"},{"line_number":135,"context_line":"      \"interface\": \"raid\","}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_ea64e9b9","line":132,"updated":"2016-02-17 19:57:56.000000000","message":"The request body has to have \"target\":\"clean\" too","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8a71741882f85afa514ac0a05eab9e3b6a8bc8a9","unresolved":false,"context_lines":[{"line_number":316,"context_line":"(if an in-band step failed), or performing general hardware troubleshooting on"},{"line_number":317,"context_line":"the node."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"When the node is repaired, you can move the node back to ``available`` state,"},{"line_number":320,"context_line":"to allow it to be scheduled by nova."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_af72f30e","line":319,"updated":"2016-02-17 19:36:45.000000000","message":"Should we say \"provide\" here, since that\u0027s the verb you\u0027d use in the api?","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"a8592dc18d1d6faba061ddeec368e8aeaa1b6080","unresolved":false,"context_lines":[{"line_number":316,"context_line":"(if an in-band step failed), or performing general hardware troubleshooting on"},{"line_number":317,"context_line":"the node."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"When the node is repaired, you can move the node back to ``available`` state,"},{"line_number":320,"context_line":"to allow it to be scheduled by nova."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_bca7b809","line":319,"in_reply_to":"dae33548_aa4941b9","updated":"2016-02-18 08:04:16.000000000","message":"but you already have ironic node-set-provision-state provide below in L328, this is duplicate","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d254b4c13c97258ee6497b033e9eadd778bc2570","unresolved":false,"context_lines":[{"line_number":316,"context_line":"(if an in-band step failed), or performing general hardware troubleshooting on"},{"line_number":317,"context_line":"the node."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"When the node is repaired, you can move the node back to ``available`` state,"},{"line_number":320,"context_line":"to allow it to be scheduled by nova."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_aa4941b9","line":319,"in_reply_to":"dae33548_af72f30e","updated":"2016-02-17 19:57:56.000000000","message":"Sure, maybe s/state/state (via \"ironic node-set-provision-state provide\"),/","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"60a8d5a0fee628d714d1ca86271c6d85184a1f37","unresolved":false,"context_lines":[{"line_number":316,"context_line":"(if an in-band step failed), or performing general hardware troubleshooting on"},{"line_number":317,"context_line":"the node."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"When the node is repaired, you can move the node back to ``available`` state,"},{"line_number":320,"context_line":"to allow it to be scheduled by nova."},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_7361bf04","line":319,"in_reply_to":"dae33548_bca7b809","updated":"2016-02-18 16:57:07.000000000","message":"Good point Tan :)","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bd83a774ede5022a1e5c95f3ad0e18ae0834dcfb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"In order for manual cleaning to work, you may need to configure a"},{"line_number":92,"context_line":"`Cleaning Network`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"PUT /v1/nodes/\u003cnode_ident\u003e/states/provision"},{"line_number":95,"context_line":"-------------------------------------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Manual cleaning can only be performed when a node is in the ``manageable``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_c6fc2441","line":94,"updated":"2016-02-19 14:32:51.000000000","message":"I\u0027d call it \"Starting manual cleaning via API\"","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"927ca8f75c23e34c2edae81d2582bcab9ca8b172","unresolved":false,"context_lines":[{"line_number":91,"context_line":"In order for manual cleaning to work, you may need to configure a"},{"line_number":92,"context_line":"`Cleaning Network`_."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"PUT /v1/nodes/\u003cnode_ident\u003e/states/provision"},{"line_number":95,"context_line":"-------------------------------------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Manual cleaning can only be performed when a node is in the ``manageable``"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_b90ef338","line":94,"in_reply_to":"bae84128_c6fc2441","updated":"2016-02-22 20:46:23.000000000","message":"+1. Much more English :)","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bd83a774ede5022a1e5c95f3ad0e18ae0834dcfb","unresolved":false,"context_lines":[{"line_number":148,"context_line":"(in that order)."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"ironic node-set-provision-state"},{"line_number":151,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"The CLI from python-ironicclient (version 1.2 and higher) corresponding to the"},{"line_number":154,"context_line":"REST API for manual cleaning is::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_a6f92050","line":151,"updated":"2016-02-19 14:32:51.000000000","message":"I think this heading should be on the same level as previous one, not inside it. And I\u0027d call it \"Starting manual cleaning via CLI\"","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"927ca8f75c23e34c2edae81d2582bcab9ca8b172","unresolved":false,"context_lines":[{"line_number":148,"context_line":"(in that order)."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"ironic node-set-provision-state"},{"line_number":151,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"The CLI from python-ironicclient (version 1.2 and higher) corresponding to the"},{"line_number":154,"context_line":"REST API for manual cleaning is::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_f904fb18","line":151,"in_reply_to":"bae84128_929f8b4f","updated":"2016-02-22 20:46:23.000000000","message":"Done","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a71f4de5f304376e0bae28398b07c8a2d8e5b45","unresolved":false,"context_lines":[{"line_number":148,"context_line":"(in that order)."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"ironic node-set-provision-state"},{"line_number":151,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"The CLI from python-ironicclient (version 1.2 and higher) corresponding to the"},{"line_number":154,"context_line":"REST API for manual cleaning is::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_929f8b4f","line":151,"in_reply_to":"bae84128_a6f92050","updated":"2016-02-22 19:11:18.000000000","message":"++","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bd83a774ede5022a1e5c95f3ad0e18ae0834dcfb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"The CLI from python-ironicclient (version 1.2 and higher) corresponding to the"},{"line_number":154,"context_line":"REST API for manual cleaning is::"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    ironic node-set-provision-state"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"The target/verb is \u0027clean\u0027 and the argument \u0027clean-steps\u0027 must be specified."},{"line_number":159,"context_line":"Its value is one of:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_06956ce3","line":156,"updated":"2016-02-19 14:32:51.000000000","message":"this sounds a bit weird to me, as this CLI corresponds to more than just manual cleaning. Maybe something like\n\n Manual cleaning is supported in the ``ironic node-set-provision-state`` command starting with python-ironicclient 1.2.","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"927ca8f75c23e34c2edae81d2582bcab9ca8b172","unresolved":false,"context_lines":[{"line_number":153,"context_line":"The CLI from python-ironicclient (version 1.2 and higher) corresponding to the"},{"line_number":154,"context_line":"REST API for manual cleaning is::"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    ironic node-set-provision-state"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"The target/verb is \u0027clean\u0027 and the argument \u0027clean-steps\u0027 must be specified."},{"line_number":159,"context_line":"Its value is one of:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_d9013708","line":156,"in_reply_to":"bae84128_06956ce3","updated":"2016-02-22 20:46:23.000000000","message":"Done","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bd83a774ede5022a1e5c95f3ad0e18ae0834dcfb","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"An example of doing this with a JSON string::"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    ironic node-set-provision-state --ironic-api-version 1.15 \\"},{"line_number":172,"context_line":"    clean --clean-steps \u0027{\"clean_steps\": [...]}\u0027"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Or with a file::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_e6996821","line":171,"updated":"2016-02-19 14:32:51.000000000","message":"it feel more naturally to me to move --ironic-api-version before the command (i.e. ironic --ironic-api-version 1.15 node-set-provision-state clean)","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"927ca8f75c23e34c2edae81d2582bcab9ca8b172","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"An example of doing this with a JSON string::"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    ironic node-set-provision-state --ironic-api-version 1.15 \\"},{"line_number":172,"context_line":"    clean --clean-steps \u0027{\"clean_steps\": [...]}\u0027"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Or with a file::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_4401be04","line":171,"in_reply_to":"bae84128_e6996821","updated":"2016-02-22 20:46:23.000000000","message":"Done","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bd83a774ede5022a1e5c95f3ad0e18ae0834dcfb","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Or with a file::"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    ironic node-set-provision-state --ironic-api-version 1.15 \\"},{"line_number":177,"context_line":"    clean --clean-steps my-clean-steps.txt"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Or with stdin::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_469f7403","line":176,"updated":"2016-02-19 14:32:51.000000000","message":"ditto","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"927ca8f75c23e34c2edae81d2582bcab9ca8b172","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Or with a file::"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    ironic node-set-provision-state --ironic-api-version 1.15 \\"},{"line_number":177,"context_line":"    clean --clean-steps my-clean-steps.txt"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Or with stdin::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_24063a1d","line":176,"in_reply_to":"bae84128_469f7403","updated":"2016-02-22 20:46:23.000000000","message":"Done","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bd83a774ede5022a1e5c95f3ad0e18ae0834dcfb","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Or with stdin::"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    cat my-clean-steps.txt | ironic node-set-provision-state \\"},{"line_number":182,"context_line":"    --ironic-api-version 1.15 clean --clean-steps -"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Cleaning Network"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_26a4f055","line":181,"updated":"2016-02-19 14:32:51.000000000","message":"ditto","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"927ca8f75c23e34c2edae81d2582bcab9ca8b172","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Or with stdin::"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    cat my-clean-steps.txt | ironic node-set-provision-state \\"},{"line_number":182,"context_line":"    --ironic-api-version 1.15 clean --clean-steps -"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Cleaning Network"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bae84128_84074617","line":181,"in_reply_to":"bae84128_26a4f055","updated":"2016-02-22 20:46:23.000000000","message":"Done","commit_id":"25558b3bdc7b9b93aec27ab343f492cd911fdf6f"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"723dfbd1b90c22f3c785968192df0c4a15d2d982","unresolved":false,"context_lines":[{"line_number":33,"context_line":"With automated cleaning, nodes move to ``cleaning`` state when moving from"},{"line_number":34,"context_line":"``active`` -\u003e ``available`` state (when the hardware is recycled from one"},{"line_number":35,"context_line":"workload to another). Nodes also traverse cleaning when going from"},{"line_number":36,"context_line":"``manageable`` -\u003e ``available`` state (before the first workload is"},{"line_number":37,"context_line":"assigned to the nodes). For a full understanding of all state transitions"},{"line_number":38,"context_line":"into cleaning, please see :ref:`states`."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bae84128_4653626b","line":36,"range":{"start_line":36,"start_character":39,"end_line":36,"end_character":64},"updated":"2016-02-23 13:21:54.000000000","message":"Can a node receive a workload and from \u0027active\u0027 become \u0027available\u0027 again, and then, go to \u0027manageable\u0027 for any reason? I think it is possible, so, when the node go through the cleaning at \u0027manageable\u0027 -\u003e \u0027available\u0027, this same cleaning will not be the cleaning before the \u0027first\u0027 workload, because the node received an instance earlier.  Maybe we should not mention the \u0027first\u0027 workload, and just say something like: \u0027before any workload is assigned to the nodes\u0027. What do you think?","commit_id":"f2d9886f991c5c8c07383c1af82823b3b5dcf067"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2612feb36583d11daf5816ae79c15c31165b34d8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"With automated cleaning, nodes move to ``cleaning`` state when moving from"},{"line_number":34,"context_line":"``active`` -\u003e ``available`` state (when the hardware is recycled from one"},{"line_number":35,"context_line":"workload to another). Nodes also traverse cleaning when going from"},{"line_number":36,"context_line":"``manageable`` -\u003e ``available`` state (before the first workload is"},{"line_number":37,"context_line":"assigned to the nodes). For a full understanding of all state transitions"},{"line_number":38,"context_line":"into cleaning, please see :ref:`states`."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bae84128_4bfc783e","line":36,"range":{"start_line":36,"start_character":39,"end_line":36,"end_character":64},"in_reply_to":"bae84128_4653626b","updated":"2016-02-25 14:23:13.000000000","message":"You\u0027re right, but I think it\u0027s valuable to emphasize that a node goes through cleaning before it\u0027s available for its first deployment.","commit_id":"f2d9886f991c5c8c07383c1af82823b3b5dcf067"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"88be8b2dd748762fd8e793f8df71c7592ca20cf8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"With automated cleaning, nodes move to ``cleaning`` state when moving from"},{"line_number":34,"context_line":"``active`` -\u003e ``available`` state (when the hardware is recycled from one"},{"line_number":35,"context_line":"workload to another). Nodes also traverse cleaning when going from"},{"line_number":36,"context_line":"``manageable`` -\u003e ``available`` state (before the first workload is"},{"line_number":37,"context_line":"assigned to the nodes). For a full understanding of all state transitions"},{"line_number":38,"context_line":"into cleaning, please see :ref:`states`."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aed3d3a_537744d4","line":36,"range":{"start_line":36,"start_character":39,"end_line":36,"end_character":64},"in_reply_to":"bae84128_4bfc783e","updated":"2016-02-25 18:00:39.000000000","message":"Yeah, I think it is important to mention that cleaning is done before the first deployment and before any subsequent deployments. Maybe it could be worded differently.\n\nMaybe s/before the first/For example, before the first/ ?\n\nSinval, if you think that is better or some other wording might be clearer, please feel free to update it. Thanks.","commit_id":"f2d9886f991c5c8c07383c1af82823b3b5dcf067"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2612feb36583d11daf5816ae79c15c31165b34d8","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    PUT /v1/nodes/\u003cnode_ident\u003e/states/provision"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"(Additional information is available `here \u003chttp://docs.openstack.org/developer/ironic/webapi/v1.html#nodes\u003e`_.)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"This API will allow operators to put a node directly into ``cleaning``"},{"line_number":106,"context_line":"provision state from ``manageable`` state via \u0027target\u0027: \u0027clean\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bae84128_6b67bc25","line":103,"range":{"start_line":103,"start_character":110,"end_line":103,"end_character":111},"updated":"2016-02-25 14:23:13.000000000","message":"nit: dot should go after )","commit_id":"f2d9886f991c5c8c07383c1af82823b3b5dcf067"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"88be8b2dd748762fd8e793f8df71c7592ca20cf8","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    PUT /v1/nodes/\u003cnode_ident\u003e/states/provision"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"(Additional information is available `here \u003chttp://docs.openstack.org/developer/ironic/webapi/v1.html#nodes\u003e`_.)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"This API will allow operators to put a node directly into ``cleaning``"},{"line_number":106,"context_line":"provision state from ``manageable`` state via \u0027target\u0027: \u0027clean\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9aed3d3a_1335bc45","line":103,"range":{"start_line":103,"start_character":110,"end_line":103,"end_character":111},"in_reply_to":"bae84128_6b67bc25","updated":"2016-02-25 18:00:39.000000000","message":"Actually, I think this is correct. The difference is where the parens are. The sentence is within the paren, and the period ends the sentence. So egs:\n\nThis is a sentence (that isn\u0027t very good).\n\n(This is a sentence that isn\u0027t very good.)","commit_id":"f2d9886f991c5c8c07383c1af82823b3b5dcf067"}],"doc/source/deploy/install-guide.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8fb45c1428e4c1899dbe9dd35bbaeeddff02b61d","unresolved":false,"context_lines":[{"line_number":1731,"context_line":""},{"line_number":1732,"context_line":"When a node is moved from the ``manageable`` to ``available`` provision"},{"line_number":1733,"context_line":"state, the node will go through automated cleaning if configured to do so (see"},{"line_number":1734,"context_line":":ref:`CleaningNetworkSetup`)."},{"line_number":1735,"context_line":"To move a node from ``manageable`` to ``available`` provision state::"},{"line_number":1736,"context_line":""},{"line_number":1737,"context_line":"    ironic --ironic-api-version 1.11 node-set-provision-state $NODE_UUID provide"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a57f1b5_cfb91c7b","line":1734,"range":{"start_line":1734,"start_character":0,"end_line":1734,"end_character":29},"updated":"2016-02-11 07:49:43.000000000","message":"Would it be better to have this pointing to \n:ref:`automated_cleaning`","commit_id":"7a0eb50fdf51d3504a6ccea8be112e657a8e96f5"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"612265ff926a4007538d9689a215c2b37a5e1fcf","unresolved":false,"context_lines":[{"line_number":1731,"context_line":""},{"line_number":1732,"context_line":"When a node is moved from the ``manageable`` to ``available`` provision"},{"line_number":1733,"context_line":"state, the node will go through automated cleaning if configured to do so (see"},{"line_number":1734,"context_line":":ref:`CleaningNetworkSetup`)."},{"line_number":1735,"context_line":"To move a node from ``manageable`` to ``available`` provision state::"},{"line_number":1736,"context_line":""},{"line_number":1737,"context_line":"    ironic --ironic-api-version 1.11 node-set-provision-state $NODE_UUID provide"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dae33548_468a601c","line":1734,"range":{"start_line":1734,"start_character":0,"end_line":1734,"end_character":29},"in_reply_to":"3a57f1b5_cfb91c7b","updated":"2016-02-17 07:14:01.000000000","message":"+1 to introduce antomated_cleaning, cleaningNetworksetup only tell user to configure a clean network","commit_id":"7a0eb50fdf51d3504a6ccea8be112e657a8e96f5"}],"doc/source/deploy/upgrade-guide.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8a71741882f85afa514ac0a05eab9e3b6a8bc8a9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"workloads to ensure the node is ready for another workload. This can include"},{"line_number":89,"context_line":"erasing the hard drives, updating firmware, and other steps. For more"},{"line_number":90,"context_line":"information, see :ref:`automated_cleaning`."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"If Ironic is configured with automated cleaning enabled (defaults to True) and"},{"line_number":93,"context_line":"to use Neutron as the DHCP provider (also the default), you will need to set the"},{"line_number":94,"context_line":"`cleaning_network_uuid` option in the Ironic configuration file before starting"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_cfe3f7a2","line":91,"updated":"2016-02-17 19:36:45.000000000","message":"Should we put something about config option clean_nodes changing to automated_clean?","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"167c254457c15d04f25921354e9a78542e070727","unresolved":false,"context_lines":[{"line_number":88,"context_line":"workloads to ensure the node is ready for another workload. This can include"},{"line_number":89,"context_line":"erasing the hard drives, updating firmware, and other steps. For more"},{"line_number":90,"context_line":"information, see :ref:`automated_cleaning`."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"If Ironic is configured with automated cleaning enabled (defaults to True) and"},{"line_number":93,"context_line":"to use Neutron as the DHCP provider (also the default), you will need to set the"},{"line_number":94,"context_line":"`cleaning_network_uuid` option in the Ironic configuration file before starting"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_f5d68e4d","line":91,"in_reply_to":"dae33548_6a7619d8","updated":"2016-02-17 20:01:15.000000000","message":"Ah, good point.","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"60a8d5a0fee628d714d1ca86271c6d85184a1f37","unresolved":false,"context_lines":[{"line_number":88,"context_line":"workloads to ensure the node is ready for another workload. This can include"},{"line_number":89,"context_line":"erasing the hard drives, updating firmware, and other steps. For more"},{"line_number":90,"context_line":"information, see :ref:`automated_cleaning`."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"If Ironic is configured with automated cleaning enabled (defaults to True) and"},{"line_number":93,"context_line":"to use Neutron as the DHCP provider (also the default), you will need to set the"},{"line_number":94,"context_line":"`cleaning_network_uuid` option in the Ironic configuration file before starting"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_d339aaa5","line":91,"in_reply_to":"dae33548_86538316","updated":"2016-02-18 16:57:07.000000000","message":"Sigh. The docs are a bit of a mess. I don\u0027t even think we should have this upgrade section here. Anyone that wants this, should be looking at the kilo version of docs: http://docs.openstack.org/developer/ironic/kilo/deploy/upgrade-guide.html.","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"d254b4c13c97258ee6497b033e9eadd778bc2570","unresolved":false,"context_lines":[{"line_number":88,"context_line":"workloads to ensure the node is ready for another workload. This can include"},{"line_number":89,"context_line":"erasing the hard drives, updating firmware, and other steps. For more"},{"line_number":90,"context_line":"information, see :ref:`automated_cleaning`."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"If Ironic is configured with automated cleaning enabled (defaults to True) and"},{"line_number":93,"context_line":"to use Neutron as the DHCP provider (also the default), you will need to set the"},{"line_number":94,"context_line":"`cleaning_network_uuid` option in the Ironic configuration file before starting"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_6a7619d8","line":91,"in_reply_to":"dae33548_cfe3f7a2","updated":"2016-02-17 19:57:56.000000000","message":"No, I don\u0027t think so. This is upgrading from Juno to Kilo. The \u0027automated_clean\u0027 is in Mitaka, and it should be mentioned in the release notes/upgrading part for liberty-\u003emitaka.","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"a8592dc18d1d6faba061ddeec368e8aeaa1b6080","unresolved":false,"context_lines":[{"line_number":88,"context_line":"workloads to ensure the node is ready for another workload. This can include"},{"line_number":89,"context_line":"erasing the hard drives, updating firmware, and other steps. For more"},{"line_number":90,"context_line":"information, see :ref:`automated_cleaning`."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"If Ironic is configured with automated cleaning enabled (defaults to True) and"},{"line_number":93,"context_line":"to use Neutron as the DHCP provider (also the default), you will need to set the"},{"line_number":94,"context_line":"`cleaning_network_uuid` option in the Ironic configuration file before starting"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dae33548_86538316","line":91,"in_reply_to":"dae33548_f5d68e4d","updated":"2016-02-18 08:04:16.000000000","message":"There is a one concern here, as you said, this is upgrading from Juno to Kilo but in :ref:`automated_cleaning`, there is nowhere to mention clean_nodes option anymore. At least from my side, I will try to enable automated_cleaning option for Kilo","commit_id":"aab8570d27576ca8c4eb3884f4ef0ef11530321e"}]}
