)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"50086539999992b59bb23c1b054b1a6f5b58f261","unresolved":false,"context_lines":[{"line_number":16,"context_line":"based IPA ramdisk. \"fedora\" and \"ubuntu\" are supported"},{"line_number":17,"context_line":"values for IRONIC_IPA_RAMDISK_DISTRO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Proposing the https://review.openstack.org/#/c/239855/ to ironic."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1510797"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_bbe558dd","line":19,"range":{"start_line":19,"start_character":14,"end_line":19,"end_character":19},"updated":"2016-01-07 15:26:53.000000000","message":"This reference to  is not required here. But do abandon review https://review.openstack.org/#/c/239855/","commit_id":"0ce932b635872aa5d72e4a864d70f94ae034b2d8"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"272a9397f1a2e99fa8d0fe3644079e63440de39a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"By default, lib/ironic will continue building coreos"},{"line_number":16,"context_line":"based IPA ramdisk. \"fedora\" and \"ubuntu\" are supported"},{"line_number":17,"context_line":"values for IRONIC_IPA_RAMDISK_DISTRO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1510797"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7af24918_f4316e5b","line":17,"updated":"2016-03-03 15:04:54.000000000","message":"This commit message needs updating to align with the code this patch is now adding.","commit_id":"04cfb3515db7390693e1db1e8260f17a26eb2c14"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"1127f1afc881f0b57a1cc2fe97c7d7ca44da6325","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"By default, lib/ironic will continue building coreos"},{"line_number":16,"context_line":"based IPA ramdisk. \"fedora\" and \"ubuntu\" are supported"},{"line_number":17,"context_line":"values for IRONIC_IPA_RAMDISK_DISTRO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1510797"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7af24918_2a31865a","line":17,"in_reply_to":"7af24918_f4316e5b","updated":"2016-03-04 05:57:47.000000000","message":"Done","commit_id":"04cfb3515db7390693e1db1e8260f17a26eb2c14"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"12cb77dbaca294ecb4e8e056f5923279b6e8ffe5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds support for building and configuring"},{"line_number":10,"context_line":"dib based agent ramdisk for Ironic. The environment"},{"line_number":11,"context_line":"variable IRONIC_DIB_RAMDISK_OPTIONS can be used to"},{"line_number":12,"context_line":"mention the preferred distro to build the ramdisk."},{"line_number":13,"context_line":"The supported types are: coreos, tinyipa and dib."},{"line_number":14,"context_line":"By default, lib/ironic will continue building coreos"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7af24918_7fd987f2","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":35},"updated":"2016-03-04 10:23:32.000000000","message":"this option is called IRONIC_RAMDISK_TYPE","commit_id":"614e2b2780907657e4c304b01f8a5642cc83aa2a"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"a6dd1b85ef5bffd81e6140846530bb65159a2d64","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds support for building and configuring"},{"line_number":10,"context_line":"dib based agent ramdisk for Ironic. The environment"},{"line_number":11,"context_line":"variable IRONIC_DIB_RAMDISK_OPTIONS can be used to"},{"line_number":12,"context_line":"mention the preferred distro to build the ramdisk."},{"line_number":13,"context_line":"The supported types are: coreos, tinyipa and dib."},{"line_number":14,"context_line":"By default, lib/ironic will continue building coreos"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7af24918_047a9d23","line":11,"range":{"start_line":11,"start_character":9,"end_line":11,"end_character":35},"in_reply_to":"7af24918_7fd987f2","updated":"2016-03-04 16:51:36.000000000","message":"Done","commit_id":"614e2b2780907657e4c304b01f8a5642cc83aa2a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"12cb77dbaca294ecb4e8e056f5923279b6e8ffe5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"and the platform on which to build the dib based"},{"line_number":20,"context_line":"ironic-python-agent ramdisk."},{"line_number":21,"context_line":"Default value for IRONIC_DIB_RAMDISK_OPTIONS"},{"line_number":22,"context_line":"is \"ubuntu\" when \u0027dib\u0027 is the selected distro."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: 1510797"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7af24918_9f8c53db","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":10},"updated":"2016-03-04 10:23:32.000000000","message":"\u0027-a amd64 ubuntu\u0027 is the default value","commit_id":"614e2b2780907657e4c304b01f8a5642cc83aa2a"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"a6dd1b85ef5bffd81e6140846530bb65159a2d64","unresolved":false,"context_lines":[{"line_number":19,"context_line":"and the platform on which to build the dib based"},{"line_number":20,"context_line":"ironic-python-agent ramdisk."},{"line_number":21,"context_line":"Default value for IRONIC_DIB_RAMDISK_OPTIONS"},{"line_number":22,"context_line":"is \"ubuntu\" when \u0027dib\u0027 is the selected distro."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: 1510797"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7af24918_64756130","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":10},"in_reply_to":"7af24918_9f8c53db","updated":"2016-03-04 16:51:36.000000000","message":"Done","commit_id":"614e2b2780907657e4c304b01f8a5642cc83aa2a"}],"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"63e85b6ada78fd13d476944a467b843c47ef88b9","unresolved":false,"context_lines":[{"line_number":785,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":786,"context_line":"    if [ \"$IRONIC_IPA_RAMDISK_DISTRO\" \u003d \"coreos\" ]; then"},{"line_number":787,"context_line":"        build_ipa_coreos_ramdisk $kernel_path $ramdisk_path"},{"line_number":788,"context_line":"    elif [[ \"$IRONIC_IPA_RAMDISK_DISTRO\" \u003d \"fedora\" || \"$IRONIC_IPA_RAMDISK_DISTRO\" \u003d \"ubuntu\" ]]; then"},{"line_number":789,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_IPA_RAMDISK_DISTRO"},{"line_number":790,"context_line":"    else"},{"line_number":791,"context_line":"        die \"IRONIC_IPA_RAMDISK_DISTRO\u003d$IRONIC_IPA_RAMDISK_DISTRO is not supported.\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da6ed579_7c78eac4","line":788,"updated":"2016-01-13 10:56:40.000000000","message":"centos and rhel7 work pretty well. I suggest dropping this check at all","commit_id":"72ba4a64861b5e05256049f0abf5a5f5586eead1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cb86186bcf870e5a0f98bc087ce1d1e81aaceecd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":107,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":108,"context_line":"# built using diskimage-builder."},{"line_number":109,"context_line":"IRONIC_IPA_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":112,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_666beb85","line":109,"updated":"2016-01-15 12:42:31.000000000","message":"let\u0027s s/IPA/AGENT/ for consistency with parameters below","commit_id":"f7bb008ab259a548824046ac212af3489df746a7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"aeea2aefc58dc1b5d326f18f95407e0b24cf28c3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":107,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":108,"context_line":"# built using diskimage-builder."},{"line_number":109,"context_line":"IRONIC_IPA_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":112,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_45719443","line":109,"in_reply_to":"da6ed579_654b782c","updated":"2016-01-18 16:31:29.000000000","message":"++ yeah if you expand the acronyms AGENT sounds better indeed","commit_id":"f7bb008ab259a548824046ac212af3489df746a7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cbdabba5f5b0350690c76fc2f240442c11a9fa6e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":107,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":108,"context_line":"# built using diskimage-builder."},{"line_number":109,"context_line":"IRONIC_IPA_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":112,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_80759664","line":109,"in_reply_to":"da6ed579_666beb85","updated":"2016-01-15 17:04:12.000000000","message":"Some configurations uses \"IPA\" in their name (e.g IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA) so i think it\u0027s already inconsistent :-( \n\nAnd IMHO IPA is the right name for it, so maybe we should keep this name? WDYT?","commit_id":"f7bb008ab259a548824046ac212af3489df746a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5ffd829a7795919559fcf17ca012d14c8533d2b6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":107,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":108,"context_line":"# built using diskimage-builder."},{"line_number":109,"context_line":"IRONIC_IPA_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":112,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_ad9d2e0b","line":109,"in_reply_to":"da6ed579_80759664","updated":"2016-01-15 18:05:26.000000000","message":"In IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA it reads well as \"ISCSI_WITH_IRONIC_PYTHON_AGENT\". Here it reads is \"IRONIC_IRONIC_PYTHON_AGENT_RAMDISK_DISTRO\" which just does not look right to me :)","commit_id":"f7bb008ab259a548824046ac212af3489df746a7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ddcb42a0c6a7540acde93792a50734792839a7cc","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":107,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":108,"context_line":"# built using diskimage-builder."},{"line_number":109,"context_line":"IRONIC_IPA_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":112,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_654b782c","line":109,"in_reply_to":"da6ed579_ad9d2e0b","updated":"2016-01-18 16:29:14.000000000","message":"+1 to Dmitry. I think it makes sense to replace IPA in above line as AGENT.\nLucas WDYT?","commit_id":"f7bb008ab259a548824046ac212af3489df746a7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cbdabba5f5b0350690c76fc2f240442c11a9fa6e","unresolved":false,"context_lines":[{"line_number":817,"context_line":"    sudo chmod 644 \"${tempfile}.initramfs\""},{"line_number":818,"context_line":"    sudo mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":819,"context_line":"    sudo mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":820,"context_line":"    sudo rm -f \"$tempfile\""},{"line_number":821,"context_line":"}"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_d4f4b3f1","line":820,"updated":"2016-01-15 17:04:12.000000000","message":"This rm will leave some files behind (.kernel, .d) [0]\n\nI think that you want to do a:\n\nsudo rm -rf ${tempfile}*\n\nOr for safety, explicitly remove the other files\n\nsudo rm -rf ${tempfile}.d\nsudo rm -f ${tempfile}.kernel\n\n[0] https://github.com/openstack/diskimage-builder/blob/2ff566b80ae51d74d2497610a6c61911ec344fb1/elements/ironic-agent/cleanup.d/99-ramdisk-create#L45","commit_id":"f7bb008ab259a548824046ac212af3489df746a7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ddcb42a0c6a7540acde93792a50734792839a7cc","unresolved":false,"context_lines":[{"line_number":817,"context_line":"    sudo chmod 644 \"${tempfile}.initramfs\""},{"line_number":818,"context_line":"    sudo mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":819,"context_line":"    sudo mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":820,"context_line":"    sudo rm -f \"$tempfile\""},{"line_number":821,"context_line":"}"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_e52be831","line":820,"in_reply_to":"da6ed579_d4f4b3f1","updated":"2016-01-18 16:29:14.000000000","message":"+1","commit_id":"f7bb008ab259a548824046ac212af3489df746a7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6c29c0be2a4b050b2a856e1f2c6c4d434c5155da","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":107,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":108,"context_line":"# built using diskimage-builder."},{"line_number":109,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":112,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a5ae5dd_72e4d3ab","line":109,"updated":"2016-02-09 09:28:29.000000000","message":"another patch introduces a similar option, could you please rebase on top of it: https://review.openstack.org/#/c/259089/","commit_id":"677433084df75d088d7bac9031ab810ade20d798"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"42ffba6a96cf627b13799ba75e7cfd51c6aa208f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":107,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":108,"context_line":"# built using diskimage-builder."},{"line_number":109,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":112,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3a57f1b5_0c1462f3","line":109,"in_reply_to":"5a5ae5dd_72e4d3ab","updated":"2016-02-10 06:44:06.000000000","message":"Done","commit_id":"677433084df75d088d7bac9031ab810ade20d798"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6c29c0be2a4b050b2a856e1f2c6c4d434c5155da","unresolved":false,"context_lines":[{"line_number":812,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":813,"context_line":"    sudo -E disk-image-create -a amd64 \\"},{"line_number":814,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":815,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":816,"context_line":"    sudo chmod 644 \"${tempfile}.vmlinuz\""},{"line_number":817,"context_line":"    sudo chmod 644 \"${tempfile}.initramfs\""},{"line_number":818,"context_line":"    sudo mv \"${tempfile}.vmlinuz\" \"$kernel_path\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a5ae5dd_92e14f9d","line":815,"updated":"2016-02-09 09:28:29.000000000","message":"you have to make sure that diskimage-builder is installed before using it:\n\n pip_install_gr diskimage-builder\n\nalso it does not require sudo\n\nalso I suggest you build it directly in the destination directory without creating a temporary one, and just leave the .d directory intact","commit_id":"677433084df75d088d7bac9031ab810ade20d798"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"42ffba6a96cf627b13799ba75e7cfd51c6aa208f","unresolved":false,"context_lines":[{"line_number":812,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":813,"context_line":"    sudo -E disk-image-create -a amd64 \\"},{"line_number":814,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":815,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":816,"context_line":"    sudo chmod 644 \"${tempfile}.vmlinuz\""},{"line_number":817,"context_line":"    sudo chmod 644 \"${tempfile}.initramfs\""},{"line_number":818,"context_line":"    sudo mv \"${tempfile}.vmlinuz\" \"$kernel_path\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3a57f1b5_8c17f2ec","line":815,"in_reply_to":"5a5ae5dd_92e14f9d","updated":"2016-02-10 06:44:06.000000000","message":"pip_install_gr diskimage-builder is being checked before calling this function, in upload_baremetal_ironic_deploy.\nFor the destination directory - IRONIC_DEPLOY_KERNEL_PATH and IRONIC_DEPLOY_RAMDISK_PATH can be differen values and its not possible to provide kernel and ramdisk path using disk-image-create. \nAlso why the .d directory should be left intact. Does it affect anything when we remove it.","commit_id":"677433084df75d088d7bac9031ab810ade20d798"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"f8147b82faa50cec93c45bff805428bf6978820c","unresolved":false,"context_lines":[{"line_number":812,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":813,"context_line":"    sudo -E disk-image-create -a amd64 \\"},{"line_number":814,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":815,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":816,"context_line":"    sudo chmod 644 \"${tempfile}.vmlinuz\""},{"line_number":817,"context_line":"    sudo chmod 644 \"${tempfile}.initramfs\""},{"line_number":818,"context_line":"    sudo mv \"${tempfile}.vmlinuz\" \"$kernel_path\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a5ae5dd_f5974d38","line":815,"in_reply_to":"5a5ae5dd_92e14f9d","updated":"2016-02-09 09:42:48.000000000","message":"thanks. I will try out the https://review.openstack.org/#/c/259089/25 patch, and rebase mine on it. If it works, I will post the rebased one.","commit_id":"677433084df75d088d7bac9031ab810ade20d798"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"10c7d946b0e02a16514eec68469cbfda979f4cb8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"# Use DIB to create deploy ramdisk and kernel."},{"line_number":97,"context_line":"IRONIC_BUILD_DEPLOY_RAMDISK\u003d$(trueorfalse True IRONIC_BUILD_DEPLOY_RAMDISK)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Ironic IPA ramdisk type, supported types are: coreos, tinyipa."},{"line_number":100,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-coreos}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# If not use DIB, these files are used as deploy ramdisk/kernel."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_09b471f0","line":99,"updated":"2016-02-19 09:41:17.000000000","message":"coreos, tinyipa and dib?","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"37016359d4fe0c2318a760c7a3977d60dc9db92e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"# Use DIB to create deploy ramdisk and kernel."},{"line_number":97,"context_line":"IRONIC_BUILD_DEPLOY_RAMDISK\u003d$(trueorfalse True IRONIC_BUILD_DEPLOY_RAMDISK)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Ironic IPA ramdisk type, supported types are: coreos, tinyipa."},{"line_number":100,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-coreos}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# If not use DIB, these files are used as deploy ramdisk/kernel."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_ca34e2fc","line":99,"in_reply_to":"bae84128_09b471f0","updated":"2016-02-23 08:46:53.000000000","message":"Done","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"10c7d946b0e02a16514eec68469cbfda979f4cb8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_a962a5ab","line":113,"updated":"2016-02-19 09:41:17.000000000","message":"The name of the variables does not match here, I think you want to have:\n\ns/IRONIC_AGENT_RAMDISK_DISTRO/IRONIC_IPA_RAMDISK_DISTRO\n\n?","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"37016359d4fe0c2318a760c7a3977d60dc9db92e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_aa307e02","line":113,"in_reply_to":"bae84128_29d855ef","updated":"2016-02-23 08:46:53.000000000","message":"have used IRONIC_AGENT_RAMDISK_DISTRO. IS this fine ?","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2d3645438b52ccd64b6f067d241bf46cf6d93285","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_IPA_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_29d855ef","line":113,"in_reply_to":"bae84128_a962a5ab","updated":"2016-02-19 09:45:52.000000000","message":"I think the opposite","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"10c7d946b0e02a16514eec68469cbfda979f4cb8","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        build_ipa_coreos_ramdisk $kernel_path $ramdisk_path"},{"line_number":806,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":807,"context_line":"        build_tinyipa_ramdisk $kernel_path $ramdisk_path"},{"line_number":808,"context_line":"    else"},{"line_number":809,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_IPA_RAMDISK_DISTRO"},{"line_number":810,"context_line":"    fi"},{"line_number":811,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_89ad218b","line":808,"updated":"2016-02-19 09:41:17.000000000","message":"Mostly nit: But would be good to have a type check here, otherwise someone can put IRONIC_RAMDISK_TYPE\u003d\"blahhh\" and it\u0027s going to work. e.g\n\n elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"dib\" ]; then\n     build_ipa_dib ...\n else\n     die \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\"","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"37016359d4fe0c2318a760c7a3977d60dc9db92e","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        build_ipa_coreos_ramdisk $kernel_path $ramdisk_path"},{"line_number":806,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":807,"context_line":"        build_tinyipa_ramdisk $kernel_path $ramdisk_path"},{"line_number":808,"context_line":"    else"},{"line_number":809,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_IPA_RAMDISK_DISTRO"},{"line_number":810,"context_line":"    fi"},{"line_number":811,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_ca1b427f","line":808,"in_reply_to":"bae84128_89ad218b","updated":"2016-02-23 08:46:53.000000000","message":"Done","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2d3645438b52ccd64b6f067d241bf46cf6d93285","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":807,"context_line":"        build_tinyipa_ramdisk $kernel_path $ramdisk_path"},{"line_number":808,"context_line":"    else"},{"line_number":809,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_IPA_RAMDISK_DISTRO"},{"line_number":810,"context_line":"    fi"},{"line_number":811,"context_line":"}"},{"line_number":812,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_69f9bd4d","line":809,"range":{"start_line":809,"start_character":59,"end_line":809,"end_character":83},"updated":"2016-02-19 09:45:52.000000000","message":"IRONIC_AGENT_RAMDISK_DISTRO","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"37016359d4fe0c2318a760c7a3977d60dc9db92e","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":807,"context_line":"        build_tinyipa_ramdisk $kernel_path $ramdisk_path"},{"line_number":808,"context_line":"    else"},{"line_number":809,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_IPA_RAMDISK_DISTRO"},{"line_number":810,"context_line":"    fi"},{"line_number":811,"context_line":"}"},{"line_number":812,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"bae84128_2a13ce67","line":809,"range":{"start_line":809,"start_character":59,"end_line":809,"end_character":83},"in_reply_to":"bae84128_69f9bd4d","updated":"2016-02-23 08:46:53.000000000","message":"Done","commit_id":"3c7777a67ea12402e42978677fb315c3b4868773"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"692b96b29475e3b34db0d4dc76c6d03bd15def97","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_AGENT_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_8e29c09d","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":27},"updated":"2016-02-24 12:39:55.000000000","message":"It is possible to set not only DISTRO via parameters, we can define custom packages/elements etc here. It would be good to have variable that allows to pass any option to dib command.\nIRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027coreos\u0027}","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"ccb63594d0a6190f8ffa9d6874df7aed39630720","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_AGENT_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9aed3d3a_30f9a881","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":27},"in_reply_to":"9aed3d3a_4e95b2e2","updated":"2016-02-26 10:57:39.000000000","message":"Oki..","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a8f15eb2bfc7fbbf5b03f9cda794612b63015e58","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_AGENT_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9aed3d3a_4e95b2e2","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":27},"in_reply_to":"9aed3d3a_c4540b56","updated":"2016-02-26 10:12:23.000000000","message":"it is possoble to specify it like:\nIRONIC_DIB_RAMDISK_OPTIONS\u003d\"-a amd64 ubuntu\"","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"ccb63594d0a6190f8ffa9d6874df7aed39630720","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_AGENT_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9aed3d3a_70f3309f","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":27},"in_reply_to":"bae84128_34723a7d","updated":"2016-02-26 10:57:39.000000000","message":"Done","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"d138b044464fe82fa91c8ec03314ec4ea931bef2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_AGENT_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9aed3d3a_c4540b56","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":27},"in_reply_to":"bae84128_34723a7d","updated":"2016-02-26 08:18:48.000000000","message":"have made the changes. But what about the case where in we specify \u0027fedora\u0027/\u0027ubuntu\u0027 distro to be built. In this case the we will feed in only the platform name in the config file. Then, -a amd64 option will be missed out while passing to disk-image-create.","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"323cbfb0518a92a54330a8e8467ff6b8560c9ab7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_AGENT_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_a391fd54","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":27},"in_reply_to":"bae84128_8e29c09d","updated":"2016-02-25 09:28:03.000000000","message":"Hi, In patch set 4 of this patch there was a comment and we had removed the options to dib command. Are you referring to something similar.","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"34490fc1857e5079d9f0f3acb48d48a7879960ea","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_AGENT_RAMDISK_DISTRO\u003d${IRONIC_AGENT_RAMDISK_DISTRO:-coreos}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_34723a7d","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":27},"in_reply_to":"bae84128_a391fd54","updated":"2016-02-25 12:06:53.000000000","message":"dib accepts space separated list of options after command. for example:\ndisk-image-create -a amd64 -p package1,package2, ubuntu-minimal ironic-agent\nSo in fact it is possible to set IRONIC_AGENT_RAMDISK_DISTRO\u003d\"-p package1,package2 coreos\" and it will work.\nI\u0027m thinking about renaming IRONIC_AGENT_RAMDISK_DISTRO to IRONIC_DIB_RAMDISK_OPTIONS","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"692b96b29475e3b34db0d4dc76c6d03bd15def97","unresolved":false,"context_lines":[{"line_number":801,"context_line":"function build_ipa_ramdisk {"},{"line_number":802,"context_line":"    local kernel_path\u003d$1"},{"line_number":803,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":804,"context_line":"    if [ \"$IRONIC_RAMDISK_TYPE\" \u003d \"coreos\" ]; then"},{"line_number":805,"context_line":"        build_ipa_coreos_ramdisk $kernel_path $ramdisk_path"},{"line_number":806,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":807,"context_line":"        build_tinyipa_ramdisk $kernel_path $ramdisk_path"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_2e0eb4e4","line":804,"range":{"start_line":804,"start_character":4,"end_line":804,"end_character":50},"updated":"2016-02-24 12:39:55.000000000","message":"I prefer to use \u0027case\u0027 instead of if here:\n\ncase $IRONIC_RAMDISK_TYPE in\n \u0027coreos\u0027)\n    ...\n  ;;\n  \u0027tinyipa\u0027)\n    ...\n  ;;\n \u0027dib\u0027)\n    ...\n  ;;\n*)\n  ...\n  ;;\nesac","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"323cbfb0518a92a54330a8e8467ff6b8560c9ab7","unresolved":false,"context_lines":[{"line_number":801,"context_line":"function build_ipa_ramdisk {"},{"line_number":802,"context_line":"    local kernel_path\u003d$1"},{"line_number":803,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":804,"context_line":"    if [ \"$IRONIC_RAMDISK_TYPE\" \u003d \"coreos\" ]; then"},{"line_number":805,"context_line":"        build_ipa_coreos_ramdisk $kernel_path $ramdisk_path"},{"line_number":806,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":807,"context_line":"        build_tinyipa_ramdisk $kernel_path $ramdisk_path"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_035549c5","line":804,"range":{"start_line":804,"start_character":4,"end_line":804,"end_character":50},"in_reply_to":"bae84128_2e0eb4e4","updated":"2016-02-25 09:28:03.000000000","message":"Done","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"692b96b29475e3b34db0d4dc76c6d03bd15def97","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":807,"context_line":"        build_tinyipa_ramdisk $kernel_path $ramdisk_path"},{"line_number":808,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"dib\" ]; then"},{"line_number":809,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_AGENT_RAMDISK_DISTRO"},{"line_number":810,"context_line":"    else"},{"line_number":811,"context_line":"        die \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\""},{"line_number":812,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_eebcccdd","line":809,"range":{"start_line":809,"start_character":57,"end_line":809,"end_character":85},"updated":"2016-02-24 12:39:55.000000000","message":"not sure that we need to pass IRONIC_AGENT_RAMDISK_DISTRO variable here. It is global variable and can be access directly from function.","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"323cbfb0518a92a54330a8e8467ff6b8560c9ab7","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"tinyipa\" ]; then"},{"line_number":807,"context_line":"        build_tinyipa_ramdisk $kernel_path $ramdisk_path"},{"line_number":808,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"dib\" ]; then"},{"line_number":809,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_AGENT_RAMDISK_DISTRO"},{"line_number":810,"context_line":"    else"},{"line_number":811,"context_line":"        die \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\""},{"line_number":812,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_a3473d1c","line":809,"range":{"start_line":809,"start_character":57,"end_line":809,"end_character":85},"in_reply_to":"bae84128_eebcccdd","updated":"2016-02-25 09:28:03.000000000","message":"Done","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"39cc3d7fa085d8ebef6a691094fb9dbfa9caa30c","unresolved":false,"context_lines":[{"line_number":808,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"dib\" ]; then"},{"line_number":809,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_AGENT_RAMDISK_DISTRO"},{"line_number":810,"context_line":"    else"},{"line_number":811,"context_line":"        die \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\""},{"line_number":812,"context_line":"    fi"},{"line_number":813,"context_line":"}"},{"line_number":814,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_795c074b","line":811,"updated":"2016-02-24 12:10:07.000000000","message":"die $LINENO \"Ramdisk type ...\"","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"323cbfb0518a92a54330a8e8467ff6b8560c9ab7","unresolved":false,"context_lines":[{"line_number":808,"context_line":"    elif [ \"$IRONIC_RAMDISK_TYPE\" \u003d\u003d \"dib\" ]; then"},{"line_number":809,"context_line":"        build_ipa_dib_ramdisk $kernel_path $ramdisk_path $IRONIC_AGENT_RAMDISK_DISTRO"},{"line_number":810,"context_line":"    else"},{"line_number":811,"context_line":"        die \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\""},{"line_number":812,"context_line":"    fi"},{"line_number":813,"context_line":"}"},{"line_number":814,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_83403909","line":811,"in_reply_to":"bae84128_795c074b","updated":"2016-02-25 09:28:03.000000000","message":"Done","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"692b96b29475e3b34db0d4dc76c6d03bd15def97","unresolved":false,"context_lines":[{"line_number":852,"context_line":"function build_ipa_dib_ramdisk {"},{"line_number":853,"context_line":"    local kernel_path\u003d$1"},{"line_number":854,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":855,"context_line":"    local distro\u003d$3"},{"line_number":856,"context_line":"    local tempfile"},{"line_number":857,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":858,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_4eccd888","line":855,"range":{"start_line":855,"start_character":4,"end_line":855,"end_character":19},"updated":"2016-02-24 12:39:55.000000000","message":"please check my previous comment","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"323cbfb0518a92a54330a8e8467ff6b8560c9ab7","unresolved":false,"context_lines":[{"line_number":852,"context_line":"function build_ipa_dib_ramdisk {"},{"line_number":853,"context_line":"    local kernel_path\u003d$1"},{"line_number":854,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":855,"context_line":"    local distro\u003d$3"},{"line_number":856,"context_line":"    local tempfile"},{"line_number":857,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":858,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_433631b5","line":855,"range":{"start_line":855,"start_character":4,"end_line":855,"end_character":19},"in_reply_to":"bae84128_4eccd888","updated":"2016-02-25 09:28:03.000000000","message":"Done","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"34490fc1857e5079d9f0f3acb48d48a7879960ea","unresolved":false,"context_lines":[{"line_number":856,"context_line":"    local tempfile"},{"line_number":857,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":858,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":859,"context_line":"    sudo -E disk-image-create -a amd64 \\"},{"line_number":860,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":861,"context_line":"                    \"$distro\" ironic-agent"},{"line_number":862,"context_line":"    sudo chmod 644 \"${tempfile}.vmlinuz\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_54eedeec","line":859,"range":{"start_line":859,"start_character":30,"end_line":859,"end_character":38},"updated":"2016-02-25 12:06:53.000000000","message":"Please remove hardcode here, it is better to add this option as default to IRONIC_DIB_RAMDISK_OPTIONS.\nIRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027-a amd64 coreos\u0027}","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"39cc3d7fa085d8ebef6a691094fb9dbfa9caa30c","unresolved":false,"context_lines":[{"line_number":863,"context_line":"    sudo chmod 644 \"${tempfile}.initramfs\""},{"line_number":864,"context_line":"    sudo mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":865,"context_line":"    sudo mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":866,"context_line":"    sudo rm -rf ${tempfile}.d"},{"line_number":867,"context_line":"    sudo rm -f ${tempfile}.kernel"},{"line_number":868,"context_line":"}"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_4be5ea06","line":867,"range":{"start_line":866,"start_character":4,"end_line":867,"end_character":33},"updated":"2016-02-24 12:10:07.000000000","message":"These are being built in a separated working directory right (e.g /tmp/tmp.7pgGClmsqb). If so, why we just don\u0027t remove the whole directory instead of specific files?\n\nThat won\u0027t leave any temporary files around.","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"323cbfb0518a92a54330a8e8467ff6b8560c9ab7","unresolved":false,"context_lines":[{"line_number":863,"context_line":"    sudo chmod 644 \"${tempfile}.initramfs\""},{"line_number":864,"context_line":"    sudo mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":865,"context_line":"    sudo mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":866,"context_line":"    sudo rm -rf ${tempfile}.d"},{"line_number":867,"context_line":"    sudo rm -f ${tempfile}.kernel"},{"line_number":868,"context_line":"}"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bae84128_e3bae509","line":867,"range":{"start_line":866,"start_character":4,"end_line":867,"end_character":33},"in_reply_to":"bae84128_4be5ea06","updated":"2016-02-25 09:28:03.000000000","message":"Done","commit_id":"0abbc4fa3a41cd5c41a0d1f9aab29ad31d428599"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c44d6125346b9ecd1d0ea6dd61f03667c9a57f93","unresolved":false,"context_lines":[{"line_number":899,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":900,"context_line":"    local tempfile"},{"line_number":901,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":902,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":903,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":904,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":905,"context_line":"                    ironic-agent"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9aed3d3a_caad3733","line":902,"range":{"start_line":902,"start_character":19,"end_line":902,"end_character":26},"updated":"2016-02-26 07:29:24.000000000","message":"distro variable is not defined, what do you think about:\n\"\nBuilding IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\"","commit_id":"2187c00fb522ebed2624350e80b2bd8193d57d1c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"38be5f83bcb709c5fde6e25ddc2a4acfe38542e2","unresolved":false,"context_lines":[{"line_number":899,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":900,"context_line":"    local tempfile"},{"line_number":901,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":902,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":903,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":904,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":905,"context_line":"                    ironic-agent"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9aed3d3a_8e66f1ea","line":902,"range":{"start_line":902,"start_character":19,"end_line":902,"end_character":26},"in_reply_to":"9aed3d3a_caad3733","updated":"2016-03-01 10:31:12.000000000","message":"Done","commit_id":"2187c00fb522ebed2624350e80b2bd8193d57d1c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"84ea6b8d890ebf9f3dd26d6abe3b2a5930f6bde5","unresolved":false,"context_lines":[{"line_number":899,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":900,"context_line":"    local tempfile"},{"line_number":901,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":902,"context_line":"    echo \"Building $distro ironic-python-agent deploy ramdisk\""},{"line_number":903,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":904,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":905,"context_line":"                    ironic-agent"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9aed3d3a_a4cbc771","line":902,"range":{"start_line":902,"start_character":19,"end_line":902,"end_character":26},"in_reply_to":"9aed3d3a_caad3733","updated":"2016-02-26 08:12:08.000000000","message":"Thanks.. will update it.","commit_id":"2187c00fb522ebed2624350e80b2bd8193d57d1c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1fbca24f702fb3bf1a60e4b5184e65ada9c838b2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"# ramdisk should be built on. The supported values now are \"coreos\", \"ubuntu\""},{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027-a amd64 coreos\u0027}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"7af24918_a2b0ab44","line":112,"updated":"2016-03-02 10:31:48.000000000","message":"This comment does not seem to apply for this option, I think you want to put it over the $IRONIC_RAMDISK_TYPE variable","commit_id":"d5af5bf71606685e9194f676a6fad4e685ed4cbc"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8457aa710fb8a4e9dce588315f3c87cb8e9d304e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"# ramdisk should be built on. The supported values now are \"coreos\", \"ubuntu\""},{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027-a amd64 coreos\u0027}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"7af24918_85d5761d","line":112,"in_reply_to":"7af24918_a2b0ab44","updated":"2016-03-03 05:34:25.000000000","message":"Done","commit_id":"d5af5bf71606685e9194f676a6fad4e685ed4cbc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1fbca24f702fb3bf1a60e4b5184e65ada9c838b2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027-a amd64 coreos\u0027}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"7af24918_8708212f","line":113,"updated":"2016-03-02 10:31:48.000000000","message":"\"coreos\" does not seem to be a valid dib element \n\nI can not find it in their tree, tried locally as well after a devstack run and it fails:\n\nI think you mean \"fedora\" or \"ubuntu\" there.\n\n [stack@localhost tmp]$ disk-image-create -o test_ipa -a amd64 coreos ironic-agent\n Building elements: base  coreos ironic-agent\n ERROR: Element \u0027coreos\u0027 not found in \u0027/usr/bin/../share/diskimage-builder/elements\u0027","commit_id":"d5af5bf71606685e9194f676a6fad4e685ed4cbc"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8457aa710fb8a4e9dce588315f3c87cb8e9d304e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# and \"fedora\".  \"coreos\" ramdisk runs ironic-python-agent in a docker"},{"line_number":111,"context_line":"# container.  \"ubuntu\" and \"fedora\" based ironic-python-agent ramdisk are"},{"line_number":112,"context_line":"# built using diskimage-builder."},{"line_number":113,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027-a amd64 coreos\u0027}"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":116,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"7af24918_05d16623","line":113,"in_reply_to":"7af24918_8708212f","updated":"2016-03-03 05:34:25.000000000","message":"Yes Lucas, thanks for pointing out. It could mean other platforms like centos and rhel7 too (as pointed out by Dmitry in patch 4 comments). Have made ubuntu as the default value.","commit_id":"d5af5bf71606685e9194f676a6fad4e685ed4cbc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8233fd5c7c37287dd643e497af997e345e598487","unresolved":false,"context_lines":[{"line_number":112,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":113,"context_line":"# to build the dib based ironic-python-agent ramdisk."},{"line_number":114,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":115,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027-a amd64 ubuntu\u0027}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":118,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_55da8779","line":115,"updated":"2016-03-07 11:35:25.000000000","message":"-a amd64 is the default, no need to pass it","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"c784d97fdb6f60452a09a93f577ef7272b8d4b74","unresolved":false,"context_lines":[{"line_number":112,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":113,"context_line":"# to build the dib based ironic-python-agent ramdisk."},{"line_number":114,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":115,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027-a amd64 ubuntu\u0027}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe.vmlinuz}"},{"line_number":118,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_61b94e79","line":115,"in_reply_to":"5aef4532_55da8779","updated":"2016-03-09 10:40:37.000000000","message":"Done","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8233fd5c7c37287dd643e497af997e345e598487","unresolved":false,"context_lines":[{"line_number":897,"context_line":"    local kernel_path\u003d$1"},{"line_number":898,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":899,"context_line":"    local tempfile"},{"line_number":900,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":901,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":902,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":903,"context_line":"                    -o \"$tempfile\" \\"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_b5e78b3f","line":900,"updated":"2016-03-07 11:35:25.000000000","message":"it\u0027s a bit weird to create a file which is later not used (and confuses actually - see comments below). Better:\n\n local tempdir\u003d$(mktemp -d --tmpdir\u003d$DEST)\n ...\n disk-image-builder ... -o \"$tempdir/ironic-agent\"\n ...\n sudo chmod -R +r $tempdir\n mv \"$tempdir/ironic-agent.kernel\" \"$kernel_path\"\n ...\n sudo rm -rf $tempdir","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"c784d97fdb6f60452a09a93f577ef7272b8d4b74","unresolved":false,"context_lines":[{"line_number":897,"context_line":"    local kernel_path\u003d$1"},{"line_number":898,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":899,"context_line":"    local tempfile"},{"line_number":900,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":901,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":902,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":903,"context_line":"                    -o \"$tempfile\" \\"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_4165321c","line":900,"in_reply_to":"5aef4532_b5e78b3f","updated":"2016-03-09 10:40:37.000000000","message":"Done","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8233fd5c7c37287dd643e497af997e345e598487","unresolved":false,"context_lines":[{"line_number":899,"context_line":"    local tempfile"},{"line_number":900,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":901,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":902,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":903,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":904,"context_line":"                    ironic-agent"},{"line_number":905,"context_line":"    sudo chmod -R 644 \"${tempfile}\""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_95e40f3c","line":902,"updated":"2016-03-07 11:35:25.000000000","message":"no need to call DIB with sudo","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"699abbf3197981f3c3f7f46a22ed1e1ed467e293","unresolved":false,"context_lines":[{"line_number":899,"context_line":"    local tempfile"},{"line_number":900,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":901,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":902,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":903,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":904,"context_line":"                    ironic-agent"},{"line_number":905,"context_line":"    sudo chmod -R 644 \"${tempfile}\""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_990e538a","line":902,"in_reply_to":"5aef4532_95e40f3c","updated":"2016-03-10 06:42:42.000000000","message":"DIB operation fails if we do not have the sudo option. So looks like this is neede. \nGet this error - http://paste.openstack.org/show/489951/ ; if sudo option is not given","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"c784d97fdb6f60452a09a93f577ef7272b8d4b74","unresolved":false,"context_lines":[{"line_number":899,"context_line":"    local tempfile"},{"line_number":900,"context_line":"    tempfile\u003d$(mktemp --tmpdir\u003d$DEST)"},{"line_number":901,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":902,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":903,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":904,"context_line":"                    ironic-agent"},{"line_number":905,"context_line":"    sudo chmod -R 644 \"${tempfile}\""}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_414c129e","line":902,"in_reply_to":"5aef4532_95e40f3c","updated":"2016-03-09 10:40:37.000000000","message":"Will verify and change in the next patch,","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8233fd5c7c37287dd643e497af997e345e598487","unresolved":false,"context_lines":[{"line_number":902,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":903,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":904,"context_line":"                    ironic-agent"},{"line_number":905,"context_line":"    sudo chmod -R 644 \"${tempfile}\""},{"line_number":906,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":907,"context_line":"    mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":908,"context_line":"    sudo rm -rf ${tempfile}"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_f5cf53b1","line":905,"updated":"2016-03-07 11:35:25.000000000","message":"${tempfile} itself is not a useful thing - see above","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"c784d97fdb6f60452a09a93f577ef7272b8d4b74","unresolved":false,"context_lines":[{"line_number":902,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":903,"context_line":"                    -o \"$tempfile\" \\"},{"line_number":904,"context_line":"                    ironic-agent"},{"line_number":905,"context_line":"    sudo chmod -R 644 \"${tempfile}\""},{"line_number":906,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":907,"context_line":"    mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":908,"context_line":"    sudo rm -rf ${tempfile}"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_816bbaf0","line":905,"in_reply_to":"5aef4532_f5cf53b1","updated":"2016-03-09 10:40:37.000000000","message":"Done","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8233fd5c7c37287dd643e497af997e345e598487","unresolved":false,"context_lines":[{"line_number":905,"context_line":"    sudo chmod -R 644 \"${tempfile}\""},{"line_number":906,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":907,"context_line":"    mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":908,"context_line":"    sudo rm -rf ${tempfile}"},{"line_number":909,"context_line":"}"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_d5d4d748","line":908,"updated":"2016-03-07 11:35:25.000000000","message":"ditto","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"c784d97fdb6f60452a09a93f577ef7272b8d4b74","unresolved":false,"context_lines":[{"line_number":905,"context_line":"    sudo chmod -R 644 \"${tempfile}\""},{"line_number":906,"context_line":"    mv \"${tempfile}.vmlinuz\" \"$kernel_path\""},{"line_number":907,"context_line":"    mv \"${tempfile}.initramfs\" \"$ramdisk_path\""},{"line_number":908,"context_line":"    sudo rm -rf ${tempfile}"},{"line_number":909,"context_line":"}"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"# build deploy kernel+ramdisk, then upload them to glance"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"5aef4532_61702edd","line":908,"in_reply_to":"5aef4532_d5d4d748","updated":"2016-03-09 10:40:37.000000000","message":"Done","commit_id":"2d2858da452fdb7c31863c9c3108f404d2875958"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2afe412657c648bf7a26620a902f0ce27221ddc2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":120,"context_line":"# to build the dib based ironic-python-agent ramdisk."},{"line_number":121,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":122,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":125,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"9a061dce_e7d9f223","line":122,"updated":"2016-04-06 09:20:45.000000000","message":"I wonder if we need dhcp-all-interfaces element. it\u0027s something we use in tripleo...","commit_id":"30d1b67e9b565e8c268ee8c49b63f5ca4de10508"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7c41a3bf5578328d36d90f62746e452d1df4938b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":120,"context_line":"# to build the dib based ironic-python-agent ramdisk."},{"line_number":121,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":122,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":125,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"9a061dce_a58a3b19","line":122,"in_reply_to":"9a061dce_e7d9f223","updated":"2016-04-06 15:32:43.000000000","message":"We don\u0027t in the install guide: \nhttp://docs.openstack.org/developer/ironic/deploy/install-guide.html#buildingdibbaseddeployramdisk","commit_id":"30d1b67e9b565e8c268ee8c49b63f5ca4de10508"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2afe412657c648bf7a26620a902f0ce27221ddc2","unresolved":false,"context_lines":[{"line_number":960,"context_line":"    local tempdir"},{"line_number":961,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d$DEST)"},{"line_number":962,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":963,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":964,"context_line":"                    -o  \"$tempdir/ironic-agent\" \\"},{"line_number":965,"context_line":"                    ironic-agent"},{"line_number":966,"context_line":"    sudo chmod -R +r $tempdir"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"9a061dce_c7d66ef0","line":963,"updated":"2016-04-06 09:20:45.000000000","message":"1. disk-image-create does not need sudo\n\n2. will putting IRONIC_DIB_RAMDISK_OPTIONS to \"\" work if we specify 2 options? e.g. \"fedora dhcp-all-interfaces\"?","commit_id":"30d1b67e9b565e8c268ee8c49b63f5ca4de10508"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6801cfd045c1895af0db7d8b1df88e494170dff6","unresolved":false,"context_lines":[{"line_number":960,"context_line":"    local tempdir"},{"line_number":961,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d$DEST)"},{"line_number":962,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":963,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":964,"context_line":"                    -o  \"$tempdir/ironic-agent\" \\"},{"line_number":965,"context_line":"                    ironic-agent"},{"line_number":966,"context_line":"    sudo chmod -R +r $tempdir"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"9a061dce_66a82478","line":963,"in_reply_to":"9a061dce_c6bbf0e3","updated":"2016-04-06 17:44:58.000000000","message":"Got it. The note about sudo still applies.","commit_id":"30d1b67e9b565e8c268ee8c49b63f5ca4de10508"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"75a813acc5126332f31a52d8de40c95be9ec307f","unresolved":false,"context_lines":[{"line_number":960,"context_line":"    local tempdir"},{"line_number":961,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d$DEST)"},{"line_number":962,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":963,"context_line":"    sudo -E disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":964,"context_line":"                    -o  \"$tempdir/ironic-agent\" \\"},{"line_number":965,"context_line":"                    ironic-agent"},{"line_number":966,"context_line":"    sudo chmod -R +r $tempdir"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"9a061dce_c6bbf0e3","line":963,"in_reply_to":"9a061dce_c7d66ef0","updated":"2016-04-06 17:43:30.000000000","message":"it will work if the variable has two values seperated by space. Please see the child patch https://review.openstack.org/#/c/264590/16/devstack/lib/ironic L1008. We add iso element there and it works.\n\n- I didnt get this part \u0027will putting IRONIC_DIB_RAMDISK_OPTIONS to \"\"\u0027. Are you asking the value to be None or multiple values?","commit_id":"30d1b67e9b565e8c268ee8c49b63f5ca4de10508"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4b0fa20a50077a2912bc2cb2d4397cfdf88dcc92","unresolved":false,"context_lines":[{"line_number":98,"context_line":"IRONIC_BUILD_DEPLOY_RAMDISK\u003d$(trueorfalse True IRONIC_BUILD_DEPLOY_RAMDISK)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Ironic IPA ramdisk type, supported types are: coreos, tinyipa and dib."},{"line_number":101,"context_line":"# The variable is used to mention the distro on which ironic-python-agent"},{"line_number":102,"context_line":"# ramdisk should be built on. \"coreos\" ramdisk runs ironic-python-agent"},{"line_number":103,"context_line":"# in a docker container. \"dib\" based ironic-python-agent ramdisk are"},{"line_number":104,"context_line":"# built using diskimage-builder."}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"9a061dce_8c9265f4","line":101,"updated":"2016-04-08 00:12:56.000000000","message":"\u0027distro\u0027 is a very misleading term here. DIB and TinyIPA are not distributions. Additionally, we don\u0027t run IPA in a docker container in CoreOS anymore, so this is exceptionally misleading.\n\nPerhaps just refer to it as a build method, and leave the detailed descriptions to the documentation? If a bad description gets embedded here, I have no belief whatsoever it\u0027ll ever be fixed.","commit_id":"4b62dc0bda5a2a7cdfc31edab9c5d4b98e642256"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6c3677eb8f03afb5e61b7d8ed4db2dda8047fb7b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"IRONIC_BUILD_DEPLOY_RAMDISK\u003d$(trueorfalse True IRONIC_BUILD_DEPLOY_RAMDISK)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Ironic IPA ramdisk type, supported types are: coreos, tinyipa and dib."},{"line_number":101,"context_line":"# The variable is used to mention the distro on which ironic-python-agent"},{"line_number":102,"context_line":"# ramdisk should be built on. \"coreos\" ramdisk runs ironic-python-agent"},{"line_number":103,"context_line":"# in a docker container. \"dib\" based ironic-python-agent ramdisk are"},{"line_number":104,"context_line":"# built using diskimage-builder."}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"1a122d0e_096e0f96","line":101,"in_reply_to":"9a061dce_8c9265f4","updated":"2016-05-03 04:17:33.000000000","message":"Ok. I will update the patch with suggested documentation.","commit_id":"4b62dc0bda5a2a7cdfc31edab9c5d4b98e642256"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4b0fa20a50077a2912bc2cb2d4397cfdf88dcc92","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    local kernel_path\u003d$1"},{"line_number":971,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":972,"context_line":"    local tempdir"},{"line_number":973,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d$DEST)"},{"line_number":974,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":975,"context_line":"    disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":976,"context_line":"                    -o  \"$tempdir/ironic-agent\" \\"}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"9a061dce_4cb32d98","line":973,"updated":"2016-04-08 00:12:56.000000000","message":"nit: I would prefer ${DEST} since it\u0027s being followed by anything other than whitespace, although this works fine :). Change at your discretion.","commit_id":"4b62dc0bda5a2a7cdfc31edab9c5d4b98e642256"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6c3677eb8f03afb5e61b7d8ed4db2dda8047fb7b","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    local kernel_path\u003d$1"},{"line_number":971,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":972,"context_line":"    local tempdir"},{"line_number":973,"context_line":"    tempdir\u003d$(mktemp -d --tmpdir\u003d$DEST)"},{"line_number":974,"context_line":"    echo \"Building IPA ramdisk with DIB options: $IRONIC_DIB_RAMDISK_OPTIONS\""},{"line_number":975,"context_line":"    disk-image-create \"$IRONIC_DIB_RAMDISK_OPTIONS\" \\"},{"line_number":976,"context_line":"                    -o  \"$tempdir/ironic-agent\" \\"}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"1a122d0e_a9039bbd","line":973,"in_reply_to":"9a061dce_4cb32d98","updated":"2016-05-03 04:17:33.000000000","message":"Ok. np. will update in the next patch.","commit_id":"4b62dc0bda5a2a7cdfc31edab9c5d4b98e642256"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"23f1d9f3b64f9125ae5edf73313142f107ec639b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    tinyipa)"},{"line_number":144,"context_line":"        IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.vmlinuz}"},{"line_number":145,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.gz}"},{"line_number":146,"context_line":"    ;;"},{"line_number":147,"context_line":"    *)"},{"line_number":148,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":149,"context_line":"    ;;"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_7885c757","line":146,"updated":"2016-05-03 08:55:34.000000000","message":"We need to add dib as an option over here too, right? Otherwise it won\u0027t pass this case conditional if the value of IRONIC_RAMDISK_TYPE is \"dib\"","commit_id":"25ffc0d60870e7eca542a45c75fa763c0387d652"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8d03d79564b5dc791a54c128547935accce68296","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    tinyipa)"},{"line_number":144,"context_line":"        IRONIC_AGENT_KERNEL_URL\u003d${IRONIC_AGENT_KERNEL_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.vmlinuz}"},{"line_number":145,"context_line":"        IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/tinyipa-${IPA_DOWNLOAD_BRANCH}.gz}"},{"line_number":146,"context_line":"    ;;"},{"line_number":147,"context_line":"    *)"},{"line_number":148,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":149,"context_line":"    ;;"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_aa4ff732","line":146,"in_reply_to":"1a122d0e_7885c757","updated":"2016-05-03 16:27:40.000000000","message":"This is being addressed as part of https://review.openstack.org/302403.","commit_id":"25ffc0d60870e7eca542a45c75fa763c0387d652"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"acf9c4d5b691ef17ff2cee28ab5b601faf480f5c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":153,"context_line":"# to build the dib based ironic-python-agent ramdisk."},{"line_number":154,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":155,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":158,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_cf3ffcb3","line":155,"updated":"2016-05-03 00:59:51.000000000","message":"instead of \"ubuntu ironic-agent\", I would suggest the following defaults: ubuntu-minimal simple-init ironic-agent -p openssh-server","commit_id":"25ffc0d60870e7eca542a45c75fa763c0387d652"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"377d3154d23464b295318e2c10da888b84c15b7c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":153,"context_line":"# to build the dib based ironic-python-agent ramdisk."},{"line_number":154,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":155,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":158,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_091c4f12","line":155,"in_reply_to":"1a122d0e_cf3ffcb3","updated":"2016-05-03 04:16:40.000000000","message":"Thanks for the comment Deva, i never tried the DIB ramdisk this way. but the current suggested one works for sure.\n\nEven in ironic documentation we suggest the one which this patch suggests.","commit_id":"25ffc0d60870e7eca542a45c75fa763c0387d652"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"acf9c4d5b691ef17ff2cee28ab5b601faf480f5c","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            build_ipa_dib_ramdisk $kernel_path $ramdisk_path"},{"line_number":965,"context_line":"            ;;"},{"line_number":966,"context_line":"        *)"},{"line_number":967,"context_line":"            die $LINENO \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\""},{"line_number":968,"context_line":"            ;;"},{"line_number":969,"context_line":"    esac"},{"line_number":970,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_af3c40c0","line":967,"updated":"2016-05-03 00:59:51.000000000","message":"this error message should list the allowed types, eg, \n\n  die $LINENO \"Ramdisk type $IRONIC_RAMDISK_TYPE not support. Must be one of \u0027ubuntu\u0027, \u0027coreos\u0027, or \u0027tinyipa\u0027.\"","commit_id":"25ffc0d60870e7eca542a45c75fa763c0387d652"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8d03d79564b5dc791a54c128547935accce68296","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            build_ipa_dib_ramdisk $kernel_path $ramdisk_path"},{"line_number":965,"context_line":"            ;;"},{"line_number":966,"context_line":"        *)"},{"line_number":967,"context_line":"            die $LINENO \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\""},{"line_number":968,"context_line":"            ;;"},{"line_number":969,"context_line":"    esac"},{"line_number":970,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_0a042bc4","line":967,"in_reply_to":"1a122d0e_184ad327","updated":"2016-05-03 16:27:40.000000000","message":":)","commit_id":"25ffc0d60870e7eca542a45c75fa763c0387d652"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"23f1d9f3b64f9125ae5edf73313142f107ec639b","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            build_ipa_dib_ramdisk $kernel_path $ramdisk_path"},{"line_number":965,"context_line":"            ;;"},{"line_number":966,"context_line":"        *)"},{"line_number":967,"context_line":"            die $LINENO \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\""},{"line_number":968,"context_line":"            ;;"},{"line_number":969,"context_line":"    esac"},{"line_number":970,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_184ad327","line":967,"in_reply_to":"1a122d0e_af3c40c0","updated":"2016-05-03 08:55:34.000000000","message":"+1 \n\nnit: s/ubuntu/dib","commit_id":"25ffc0d60870e7eca542a45c75fa763c0387d652"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"377d3154d23464b295318e2c10da888b84c15b7c","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            build_ipa_dib_ramdisk $kernel_path $ramdisk_path"},{"line_number":965,"context_line":"            ;;"},{"line_number":966,"context_line":"        *)"},{"line_number":967,"context_line":"            die $LINENO \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported\""},{"line_number":968,"context_line":"            ;;"},{"line_number":969,"context_line":"    esac"},{"line_number":970,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_c9e097fd","line":967,"in_reply_to":"1a122d0e_af3c40c0","updated":"2016-05-03 04:16:40.000000000","message":"Ok","commit_id":"25ffc0d60870e7eca542a45c75fa763c0387d652"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"48a1ffde5dfefb92f5506cc809d150db272da1be","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    *)"},{"line_number":150,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":151,"context_line":"    ;;"},{"line_number":152,"context_line":"esac"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":155,"context_line":"# to build the dib based ironic-python-agent ramdisk."}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"dab17558_8ae7f1aa","line":152,"updated":"2016-05-11 11:45:46.000000000","message":"We need to add an: \n\nif IRONIC_BUILD_DEPLOY_RAMDISK \u003d\u003d True; then\n\naround this case statement because without it running stack with IRONIC_RAMDISK_TYPE\u003ddib will fail every time as it\u0027ll hit the die statement.","commit_id":"f3dea592bde992b2c298150aabd801a01a8f7ce8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fca6dbb277b815b26a400c011874cd1c58318ce8","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    *)"},{"line_number":150,"context_line":"        die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected \u0027coreos\u0027 or \u0027tinyipa\u0027\""},{"line_number":151,"context_line":"    ;;"},{"line_number":152,"context_line":"esac"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":155,"context_line":"# to build the dib based ironic-python-agent ramdisk."}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"dab17558_b3aca436","line":152,"in_reply_to":"dab17558_8ae7f1aa","updated":"2016-05-12 17:05:55.000000000","message":"The dib support for IRONIC_RAMDISK_TYPE is addressed by the patch https://review.openstack.org/302403. This doesnt require the IRONIC_BUILD_DEPLOY_RAMDISK to be set to true.","commit_id":"f3dea592bde992b2c298150aabd801a01a8f7ce8"},{"author":{"_account_id":8106,"name":"Haomeng,Wang","email":"wanghaomeng@gmail.com","username":"whaom"},"change_message_id":"35187f740d362d94218b4bef8bc16ff8d825fd67","unresolved":false,"context_lines":[{"line_number":996,"context_line":"            build_ipa_dib_ramdisk $kernel_path $ramdisk_path"},{"line_number":997,"context_line":"            ;;"},{"line_number":998,"context_line":"        *)"},{"line_number":999,"context_line":"            die $LINENO \"Ramdisk type $IRONIC_RAMDISK_TYPE not supported. Must be one of \u0027dib\u0027, \u0027coreos\u0027, or \u0027tinyipa\u0027.\""},{"line_number":1000,"context_line":"            ;;"},{"line_number":1001,"context_line":"    esac"},{"line_number":1002,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":29,"id":"dab17558_b480a1c0","line":999,"range":{"start_line":999,"start_character":59,"end_line":999,"end_character":72},"updated":"2016-05-16 08:51:21.000000000","message":"nit: s/not supported/is not supported ?","commit_id":"b780f2c8238bcad6eb433743b75505ced7cca361"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba649cf1dffb090b1f9f563f09ca08391e29c4fb","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"            build_ipa_dib_ramdisk $kernel_path $ramdisk_path"},{"line_number":1004,"context_line":"            ;;"},{"line_number":1005,"context_line":"        *)"},{"line_number":1006,"context_line":"            die $LINENO \"Unrecognised IRONIC_RAMDISK_TYPE: $IRONIC_RAMDISK_TYPE. Expected either of \u0027dib\u0027, \u0027coreos\u0027, or \u0027tinyipa\u0027.\""},{"line_number":1007,"context_line":"            ;;"},{"line_number":1008,"context_line":"    esac"},{"line_number":1009,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":30,"id":"9abb7d3a_5fc61717","line":1006,"updated":"2016-06-02 17:30:21.000000000","message":"nit, s/either of//","commit_id":"38e46e15300dc2453a00ec7b5c38f0499eee99ce"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba649cf1dffb090b1f9f563f09ca08391e29c4fb","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"}"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":"function build_tinyipa_ramdisk {"},{"line_number":1027,"context_line":"    echo \"Building ironic-python-agent deploy ramdisk\""},{"line_number":1028,"context_line":"    local kernel_path\u003d$1"},{"line_number":1029,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":1030,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"}],"source_content_type":"application/x-shellscript","patch_set":30,"id":"9abb7d3a_5fed778d","line":1027,"updated":"2016-06-02 17:30:21.000000000","message":"should this be updated too then?","commit_id":"38e46e15300dc2453a00ec7b5c38f0499eee99ce"}]}
