)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e6f1dafa5f59f13351581b43ccbe281fdbf62ea","unresolved":false,"context_lines":[{"line_number":12,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003dtrue can be set in localrc"},{"line_number":13,"context_line":"to create and upload ISO image for the deploy ramdisk."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Proposing https://review.openstack.org/#/c/239918/ to ironic."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I03a31490323b4bff9700146844a7009212840c60"},{"line_number":18,"context_line":"Closes-Bug: 1510914"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_bbcf9828","line":15,"range":{"start_line":15,"start_character":25,"end_line":15,"end_character":34},"updated":"2016-01-07 16:03:26.000000000","message":"Reference to devstack review is not required here. But do abandon that review.","commit_id":"69d7d02c629353b9623630cf5ea6179565cc06f2"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"c207ad4464ee476e5013610e42d4eb3818c4eef4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003dtrue can be set in localrc"},{"line_number":13,"context_line":"to create and upload ISO image for the deploy ramdisk."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Proposing https://review.openstack.org/#/c/239918/ to ironic."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I03a31490323b4bff9700146844a7009212840c60"},{"line_number":18,"context_line":"Closes-Bug: 1510914"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6ed579_a4ff37a9","line":15,"range":{"start_line":15,"start_character":25,"end_line":15,"end_character":34},"in_reply_to":"fa69d971_bbcf9828","updated":"2016-01-13 05:14:25.000000000","message":"Done","commit_id":"69d7d02c629353b9623630cf5ea6179565cc06f2"}],"devstack/lib/ironic":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"126656edfc90e07403dd2cd0d33f2285a040d978","unresolved":false,"context_lines":[{"line_number":115,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":116,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."},{"line_number":119,"context_line":"# Set this variable to \"true\" to build an ISO for deploy ramdisk and"},{"line_number":120,"context_line":"# upload to Glance."},{"line_number":121,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003d$(trueorfalse False IRONIC_DEPLOY_ISO_REQUIRED)"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"5aef4532_46d028f8","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":71},"updated":"2016-03-11 07:01:39.000000000","message":"Are we trying to enable virtual media driver test without real hardware?","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"30217b9bb911be242f610e4d8cb0f3ed93172483","unresolved":false,"context_lines":[{"line_number":115,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":116,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."},{"line_number":119,"context_line":"# Set this variable to \"true\" to build an ISO for deploy ramdisk and"},{"line_number":120,"context_line":"# upload to Glance."},{"line_number":121,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003d$(trueorfalse False IRONIC_DEPLOY_ISO_REQUIRED)"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1af94dfe_d2fe4437","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":71},"in_reply_to":"1af94dfe_0f7407fb","updated":"2016-03-17 06:14:42.000000000","message":"That\u0027s because DevStack can work without bare metal hardware such as http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack\n\nIf $IRONIC_IS_HARDWARE is NOT true, I think stack.sh should stop with an error to inform user that vmedia deployment test only available with real hardware.\n\nDo you think you don\u0027t need the error in this case?","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"2fedead0847d57efa5bb2f596bb6636cac4198ab","unresolved":false,"context_lines":[{"line_number":115,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":116,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."},{"line_number":119,"context_line":"# Set this variable to \"true\" to build an ISO for deploy ramdisk and"},{"line_number":120,"context_line":"# upload to Glance."},{"line_number":121,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003d$(trueorfalse False IRONIC_DEPLOY_ISO_REQUIRED)"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1af94dfe_0f7407fb","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":71},"in_reply_to":"1af94dfe_bcad9433","updated":"2016-03-17 05:34:48.000000000","message":"We are still not clear why the $IRONIC_IS_HARDWARE check is needed. What will happen if the check is not present.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8e6b81839d59352df4d039608ed74c0927a04821","unresolved":false,"context_lines":[{"line_number":115,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":116,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."},{"line_number":119,"context_line":"# Set this variable to \"true\" to build an ISO for deploy ramdisk and"},{"line_number":120,"context_line":"# upload to Glance."},{"line_number":121,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003d$(trueorfalse False IRONIC_DEPLOY_ISO_REQUIRED)"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1af94dfe_8ef80bc5","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":71},"in_reply_to":"1af94dfe_d2fe4437","updated":"2016-03-17 11:46:22.000000000","message":"Done","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ddd6595c6b385a1fb615b466c229eea8f5add3eb","unresolved":false,"context_lines":[{"line_number":115,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":116,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."},{"line_number":119,"context_line":"# Set this variable to \"true\" to build an ISO for deploy ramdisk and"},{"line_number":120,"context_line":"# upload to Glance."},{"line_number":121,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003d$(trueorfalse False IRONIC_DEPLOY_ISO_REQUIRED)"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1af94dfe_bcad9433","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":71},"in_reply_to":"3afc51ec_4f29e136","updated":"2016-03-16 02:12:01.000000000","message":"Okay, I understood that this change requires real hardware to to test virtual media driver.\n\niRMC Thirdparty-CI preparation is also underway.\n\nSo my understanding is that IRONIC_DEPLOY_ISO_REQUIRED should be True only if\"$IRONIC_IS_HARDWARE\" \u003d\u003d \"True\".","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"977794c189adc17d43b099a2b3a7ea74186cd584","unresolved":false,"context_lines":[{"line_number":115,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":116,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."},{"line_number":119,"context_line":"# Set this variable to \"true\" to build an ISO for deploy ramdisk and"},{"line_number":120,"context_line":"# upload to Glance."},{"line_number":121,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003d$(trueorfalse False IRONIC_DEPLOY_ISO_REQUIRED)"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_4f29e136","line":118,"range":{"start_line":118,"start_character":2,"end_line":118,"end_character":71},"in_reply_to":"5aef4532_46d028f8","updated":"2016-03-15 05:40:45.000000000","message":"1. the iLO CI is already there. It not available for patches just because of some internal hardware issue for logs. So the patch is already being tested against real hardware.\n\n2. Yes this is to enable virtual media drivers.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"126656edfc90e07403dd2cd0d33f2285a040d978","unresolved":false,"context_lines":[{"line_number":124,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":127,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."},{"line_number":128,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"5aef4532_c62438b4","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":74},"updated":"2016-03-11 07:01:39.000000000","message":"Don\u0027t we need to update this comment too?","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8e6b81839d59352df4d039608ed74c0927a04821","unresolved":false,"context_lines":[{"line_number":124,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":127,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."},{"line_number":128,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1af94dfe_6e0dbfe7","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":74},"in_reply_to":"1af94dfe_171e2363","updated":"2016-03-17 11:46:22.000000000","message":"Done","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ddd6595c6b385a1fb615b466c229eea8f5add3eb","unresolved":false,"context_lines":[{"line_number":124,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":127,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."},{"line_number":128,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1af94dfe_171e2363","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":74},"in_reply_to":"3afc51ec_8f1f6907","updated":"2016-03-16 02:12:01.000000000","message":"If you are going to add iscsi_ilo and agent_ilo, please add iscsi_irmc and agent_irmc as well.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"977794c189adc17d43b099a2b3a7ea74186cd584","unresolved":false,"context_lines":[{"line_number":124,"context_line":"IRONIC_AGENT_RAMDISK_URL\u003d${IRONIC_AGENT_RAMDISK_URL:-http://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem.cpio.gz}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":127,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."},{"line_number":128,"context_line":"IRONIC_DEPLOY_DRIVER\u003d${IRONIC_DEPLOY_DRIVER:-pxe_ssh}"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# TODO(agordeev): replace \u0027ubuntu\u0027 with host distro name getting"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_8f1f6907","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":74},"in_reply_to":"5aef4532_c62438b4","updated":"2016-03-15 05:40:45.000000000","message":"Good catch.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"126656edfc90e07403dd2cd0d33f2285a040d978","unresolved":false,"context_lines":[{"line_number":215,"context_line":"}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"function is_deploy_iso_required {"},{"line_number":218,"context_line":"    [[ \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":219,"context_line":"    return 1"},{"line_number":220,"context_line":"}"},{"line_number":221,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"5aef4532_c62a782f","line":218,"range":{"start_line":218,"start_character":4,"end_line":218,"end_character":49},"updated":"2016-03-11 07:01:39.000000000","message":"Don\u0027t we need to check \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"True\" too?","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8e6b81839d59352df4d039608ed74c0927a04821","unresolved":false,"context_lines":[{"line_number":215,"context_line":"}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"function is_deploy_iso_required {"},{"line_number":218,"context_line":"    [[ \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":219,"context_line":"    return 1"},{"line_number":220,"context_line":"}"},{"line_number":221,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1af94dfe_ee18af20","line":218,"range":{"start_line":218,"start_character":4,"end_line":218,"end_character":49},"in_reply_to":"1af94dfe_b7ac8fee","updated":"2016-03-17 11:46:22.000000000","message":"Done","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ddd6595c6b385a1fb615b466c229eea8f5add3eb","unresolved":false,"context_lines":[{"line_number":215,"context_line":"}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"function is_deploy_iso_required {"},{"line_number":218,"context_line":"    [[ \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":219,"context_line":"    return 1"},{"line_number":220,"context_line":"}"},{"line_number":221,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"1af94dfe_b7ac8fee","line":218,"range":{"start_line":218,"start_character":4,"end_line":218,"end_character":49},"in_reply_to":"3afc51ec_4fe0c1fa","updated":"2016-03-16 02:12:01.000000000","message":"The reason is that we need real hardware as I commented at L.118.\n\nI believe that user has to be notified error if user set \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" without real hardware.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"977794c189adc17d43b099a2b3a7ea74186cd584","unresolved":false,"context_lines":[{"line_number":215,"context_line":"}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"function is_deploy_iso_required {"},{"line_number":218,"context_line":"    [[ \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":219,"context_line":"    return 1"},{"line_number":220,"context_line":"}"},{"line_number":221,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_4fe0c1fa","line":218,"range":{"start_line":218,"start_character":4,"end_line":218,"end_character":49},"in_reply_to":"5aef4532_c62a782f","updated":"2016-03-15 05:40:45.000000000","message":"I dont understand why we need the check you are mentioning.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1f1d4aeb80ec2834be23b767fe056077502244fc","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        else"},{"line_number":703,"context_line":"            local node_options\u003d\"\\"},{"line_number":704,"context_line":"                -i deploy_kernel\u003d$IRONIC_DEPLOY_KERNEL_ID \\"},{"line_number":705,"context_line":"                -i deploy_ramdisk\u003d$IRONIC_DEPLOY_RAMDISK_ID \\"},{"line_number":706,"context_line":"                -i ssh_virt_type\u003d$IRONIC_SSH_VIRT_TYPE \\"},{"line_number":707,"context_line":"                -i ssh_address\u003d$IRONIC_VM_SSH_ADDRESS \\"},{"line_number":708,"context_line":"                -i ssh_port\u003d$IRONIC_VM_SSH_PORT \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"5aef4532_88c26983","line":705,"updated":"2016-03-10 13:17:05.000000000","message":"I think you also need to add IRONIC_DEPLOY_ISO_ID instead of kernel-ramdisk here if is_deploy_iso_required. Or is this patch intended to only build it, not to use it in nodes?","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"977794c189adc17d43b099a2b3a7ea74186cd584","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        else"},{"line_number":703,"context_line":"            local node_options\u003d\"\\"},{"line_number":704,"context_line":"                -i deploy_kernel\u003d$IRONIC_DEPLOY_KERNEL_ID \\"},{"line_number":705,"context_line":"                -i deploy_ramdisk\u003d$IRONIC_DEPLOY_RAMDISK_ID \\"},{"line_number":706,"context_line":"                -i ssh_virt_type\u003d$IRONIC_SSH_VIRT_TYPE \\"},{"line_number":707,"context_line":"                -i ssh_address\u003d$IRONIC_VM_SSH_ADDRESS \\"},{"line_number":708,"context_line":"                -i ssh_port\u003d$IRONIC_VM_SSH_PORT \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_2fbc55db","line":705,"in_reply_to":"5aef4532_88c26983","updated":"2016-03-15 05:40:45.000000000","message":"+1","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"476f0732759fef6164d714d337c6175269e2d6d7","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        else"},{"line_number":703,"context_line":"            local node_options\u003d\"\\"},{"line_number":704,"context_line":"                -i deploy_kernel\u003d$IRONIC_DEPLOY_KERNEL_ID \\"},{"line_number":705,"context_line":"                -i deploy_ramdisk\u003d$IRONIC_DEPLOY_RAMDISK_ID \\"},{"line_number":706,"context_line":"                -i ssh_virt_type\u003d$IRONIC_SSH_VIRT_TYPE \\"},{"line_number":707,"context_line":"                -i ssh_address\u003d$IRONIC_VM_SSH_ADDRESS \\"},{"line_number":708,"context_line":"                -i ssh_port\u003d$IRONIC_VM_SSH_PORT \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_35c94227","line":705,"in_reply_to":"5aef4532_88c26983","updated":"2016-03-16 04:37:20.000000000","message":"Done","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1f1d4aeb80ec2834be23b767fe056077502244fc","unresolved":false,"context_lines":[{"line_number":886,"context_line":"    echo \"Building coreos ironic-python-agent deploy ramdisk\""},{"line_number":887,"context_line":"    local kernel_path\u003d$1"},{"line_number":888,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":889,"context_line":"    local iso_path\u003d$3"},{"line_number":890,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":891,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"},{"line_number":892,"context_line":"    imagebuild/coreos/build_coreos_image.sh"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"5aef4532_ed921ff5","line":889,"updated":"2016-03-10 13:17:05.000000000","message":"docker restart should not be removed.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"476f0732759fef6164d714d337c6175269e2d6d7","unresolved":false,"context_lines":[{"line_number":886,"context_line":"    echo \"Building coreos ironic-python-agent deploy ramdisk\""},{"line_number":887,"context_line":"    local kernel_path\u003d$1"},{"line_number":888,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":889,"context_line":"    local iso_path\u003d$3"},{"line_number":890,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":891,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"},{"line_number":892,"context_line":"    imagebuild/coreos/build_coreos_image.sh"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_35bca2db","line":889,"in_reply_to":"3afc51ec_6fb2dd07","updated":"2016-03-16 04:37:20.000000000","message":"Done","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"977794c189adc17d43b099a2b3a7ea74186cd584","unresolved":false,"context_lines":[{"line_number":886,"context_line":"    echo \"Building coreos ironic-python-agent deploy ramdisk\""},{"line_number":887,"context_line":"    local kernel_path\u003d$1"},{"line_number":888,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":889,"context_line":"    local iso_path\u003d$3"},{"line_number":890,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":891,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"},{"line_number":892,"context_line":"    imagebuild/coreos/build_coreos_image.sh"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_6fb2dd07","line":889,"in_reply_to":"5aef4532_ed921ff5","updated":"2016-03-15 05:40:45.000000000","message":"+1","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"476f0732759fef6164d714d337c6175269e2d6d7","unresolved":false,"context_lines":[{"line_number":886,"context_line":"    echo \"Building coreos ironic-python-agent deploy ramdisk\""},{"line_number":887,"context_line":"    local kernel_path\u003d$1"},{"line_number":888,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":889,"context_line":"    local iso_path\u003d$3"},{"line_number":890,"context_line":"    git_clone $IRONIC_PYTHON_AGENT_REPO $IRONIC_PYTHON_AGENT_DIR $IRONIC_PYTHON_AGENT_BRANCH"},{"line_number":891,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"},{"line_number":892,"context_line":"    imagebuild/coreos/build_coreos_image.sh"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_15c1a654","line":889,"in_reply_to":"5aef4532_ed921ff5","updated":"2016-03-16 04:37:20.000000000","message":"Done","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1f1d4aeb80ec2834be23b767fe056077502244fc","unresolved":false,"context_lines":[{"line_number":954,"context_line":"        install_diskimage_builder"},{"line_number":955,"context_line":"    fi"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" ]; then"},{"line_number":958,"context_line":"        local IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.kernel"},{"line_number":959,"context_line":"        local IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.initramfs"},{"line_number":960,"context_line":"        local IRONIC_DEPLOY_ISO_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.iso"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"5aef4532_88cf0955","line":957,"updated":"2016-03-10 13:17:05.000000000","message":"You don\u0027t check if $IRONIC_DEPLOY_ISO is empty here. Is it intentional? It may exist already, even if IRONIC_DEPLOY_KERNEL and IRONIC_DEPLOY_RAMDISK are empty.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"476f0732759fef6164d714d337c6175269e2d6d7","unresolved":false,"context_lines":[{"line_number":954,"context_line":"        install_diskimage_builder"},{"line_number":955,"context_line":"    fi"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" ]; then"},{"line_number":958,"context_line":"        local IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.kernel"},{"line_number":959,"context_line":"        local IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.initramfs"},{"line_number":960,"context_line":"        local IRONIC_DEPLOY_ISO_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.iso"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_d5445eb8","line":957,"in_reply_to":"5aef4532_88cf0955","updated":"2016-03-16 04:37:20.000000000","message":"Done","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"977794c189adc17d43b099a2b3a7ea74186cd584","unresolved":false,"context_lines":[{"line_number":954,"context_line":"        install_diskimage_builder"},{"line_number":955,"context_line":"    fi"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" ]; then"},{"line_number":958,"context_line":"        local IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.kernel"},{"line_number":959,"context_line":"        local IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.initramfs"},{"line_number":960,"context_line":"        local IRONIC_DEPLOY_ISO_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.iso"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3afc51ec_8f948943","line":957,"in_reply_to":"5aef4532_88cf0955","updated":"2016-03-15 05:40:45.000000000","message":"yeah good catch. we should check that too.","commit_id":"04fb77cff0b0ab1cb599707e6caa7ae85dca6b5c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0ef405e3b1edfad65a45ba752bb912acb86fa8c8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"# This refers the options for disk-image-create and the platform on which"},{"line_number":110,"context_line":"# to build the dib based ironic-python-agent ramdisk."},{"line_number":111,"context_line":"# \"ubuntu\" is set as the default value."},{"line_number":112,"context_line":"IRONIC_DIB_RAMDISK_OPTIONS\u003d${IRONIC_DIB_RAMDISK_OPTIONS:-\u0027ubuntu\u0027}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."},{"line_number":115,"context_line":"# Set this variable to \"true\" to build an ISO for deploy ramdisk and"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ba0121b8_801c9314","line":112,"updated":"2016-03-29 20:32:16.000000000","message":"without ramdisk or ramdisk-minimal dib will create user image. I think this element should be added to default IRONIC_DIB_RAMDISK_OPTIONS","commit_id":"7c10b37929a3e267ced4b70deadc4b15255122b6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"184dea51e4c8d0641a2cbac45133dd34456dc96b","unresolved":false,"context_lines":[{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        if is_deployed_by_ipmitool; then"},{"line_number":728,"context_line":"            local node_options\u003d\"\\"},{"line_number":729,"context_line":"                if is_deploy_iso_required"},{"line_number":730,"context_line":"                    -i deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID"},{"line_number":731,"context_line":"                else"},{"line_number":732,"context_line":"                    -i deploy_kernel\u003d$IRONIC_DEPLOY_KERNEL_ID \\"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_73c90e26","line":729,"updated":"2016-04-06 15:30:43.000000000","message":"Should be \n\n if is_deploy_iso_required; then\n\nIt cannot work, as it is added in this section, where \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"False\", while is_deploy_iso_required requires it to be true.\n\nAnd it is inside a string? Will it work?","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e59c3cae6f4d4d6e087dc5c9583573121dad333b","unresolved":false,"context_lines":[{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        if is_deployed_by_ipmitool; then"},{"line_number":728,"context_line":"            local node_options\u003d\"\\"},{"line_number":729,"context_line":"                if is_deploy_iso_required"},{"line_number":730,"context_line":"                    -i deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID"},{"line_number":731,"context_line":"                else"},{"line_number":732,"context_line":"                    -i deploy_kernel\u003d$IRONIC_DEPLOY_KERNEL_ID \\"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_92048e18","line":729,"in_reply_to":"9a061dce_73c90e26","updated":"2016-04-06 19:31:18.000000000","message":"the change shouldnt be here. I will test the patch after removing it in next patch.","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"184dea51e4c8d0641a2cbac45133dd34456dc96b","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                -i ipmi_password\u003dpassword\""},{"line_number":738,"context_line":"        else"},{"line_number":739,"context_line":"            local node_options\u003d\"\\"},{"line_number":740,"context_line":"                if is_deploy_iso_required"},{"line_number":741,"context_line":"                    -i deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID"},{"line_number":742,"context_line":"                else"},{"line_number":743,"context_line":"                    -i deploy_kernel\u003d$IRONIC_DEPLOY_KERNEL_ID \\"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_d3da9ae7","line":740,"updated":"2016-04-06 15:30:43.000000000","message":"ditto","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e59c3cae6f4d4d6e087dc5c9583573121dad333b","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                -i ipmi_password\u003dpassword\""},{"line_number":738,"context_line":"        else"},{"line_number":739,"context_line":"            local node_options\u003d\"\\"},{"line_number":740,"context_line":"                if is_deploy_iso_required"},{"line_number":741,"context_line":"                    -i deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID"},{"line_number":742,"context_line":"                else"},{"line_number":743,"context_line":"                    -i deploy_kernel\u003d$IRONIC_DEPLOY_KERNEL_ID \\"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_dd00d703","line":740,"in_reply_to":"9a061dce_d3da9ae7","updated":"2016-04-06 19:31:18.000000000","message":"ditto","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"184dea51e4c8d0641a2cbac45133dd34456dc96b","unresolved":false,"context_lines":[{"line_number":938,"context_line":"function build_ipa_ramdisk {"},{"line_number":939,"context_line":"    local kernel_path\u003d$1"},{"line_number":940,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":941,"context_line":"    local iso_path\u003d$3"},{"line_number":942,"context_line":"    case $IRONIC_RAMDISK_TYPE in"},{"line_number":943,"context_line":"        \u0027coreos\u0027)"},{"line_number":944,"context_line":"            build_ipa_coreos_ramdisk $kernel_path $ramdisk_path $iso_path"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_ee225551","line":941,"updated":"2016-04-06 15:30:43.000000000","message":"Same function is defined on L919","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e59c3cae6f4d4d6e087dc5c9583573121dad333b","unresolved":false,"context_lines":[{"line_number":938,"context_line":"function build_ipa_ramdisk {"},{"line_number":939,"context_line":"    local kernel_path\u003d$1"},{"line_number":940,"context_line":"    local ramdisk_path\u003d$2"},{"line_number":941,"context_line":"    local iso_path\u003d$3"},{"line_number":942,"context_line":"    case $IRONIC_RAMDISK_TYPE in"},{"line_number":943,"context_line":"        \u0027coreos\u0027)"},{"line_number":944,"context_line":"            build_ipa_coreos_ramdisk $kernel_path $ramdisk_path $iso_path"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_5db16746","line":941,"in_reply_to":"9a061dce_ee225551","updated":"2016-04-06 19:31:18.000000000","message":"Thanks, for pointing this. Addressed in next patch.","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"5cdf7229f90589a0bc65e4dac089a4bbf4a57fbf","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    cp tinyipa.gz $ramdisk_path"},{"line_number":986,"context_line":"    cp tinyipa.vmlinuz $kernel_path"},{"line_number":987,"context_line":"    make clean"},{"line_number":988,"context_line":"    cd -"},{"line_number":989,"context_line":"}"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"# install_diskimage_builder() - Collect source and prepare or install from pip"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_1816ea4b","line":988,"updated":"2016-04-06 15:58:07.000000000","message":"Need to add tinyipa iso build support","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e59c3cae6f4d4d6e087dc5c9583573121dad333b","unresolved":false,"context_lines":[{"line_number":985,"context_line":"    cp tinyipa.gz $ramdisk_path"},{"line_number":986,"context_line":"    cp tinyipa.vmlinuz $kernel_path"},{"line_number":987,"context_line":"    make clean"},{"line_number":988,"context_line":"    cd -"},{"line_number":989,"context_line":"}"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"# install_diskimage_builder() - Collect source and prepare or install from pip"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_5d9847c0","line":988,"in_reply_to":"9a061dce_1816ea4b","updated":"2016-04-06 19:31:18.000000000","message":"ok, but i cannot test it in my env.","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"184dea51e4c8d0641a2cbac45133dd34456dc96b","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"        install_diskimage_builder"},{"line_number":1032,"context_line":"    fi"},{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" -o -z $IRONIC_DEPLOY_ISO ]; then"},{"line_number":1035,"context_line":"        local IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.kernel"},{"line_number":1036,"context_line":"        local IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.initramfs"},{"line_number":1037,"context_line":"        local IRONIC_DEPLOY_ISO_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.iso"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_25fc6bb7","line":1034,"updated":"2016-04-06 15:30:43.000000000","message":"No quotes around $IRONIC_DEPLOY_ISO, devstack seems to complain about it\n\n 2016-04-05 18:51:05.677 | /opt/stack/new/ironic/devstack/lib/ironic: line 1034: [: argument expected","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e59c3cae6f4d4d6e087dc5c9583573121dad333b","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"        install_diskimage_builder"},{"line_number":1032,"context_line":"    fi"},{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"    if [ -z \"$IRONIC_DEPLOY_KERNEL\" -o -z \"$IRONIC_DEPLOY_RAMDISK\" -o -z $IRONIC_DEPLOY_ISO ]; then"},{"line_number":1035,"context_line":"        local IRONIC_DEPLOY_KERNEL_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.kernel"},{"line_number":1036,"context_line":"        local IRONIC_DEPLOY_RAMDISK_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.initramfs"},{"line_number":1037,"context_line":"        local IRONIC_DEPLOY_ISO_PATH\u003d$TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER.iso"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_bdc08351","line":1034,"in_reply_to":"9a061dce_25fc6bb7","updated":"2016-04-06 19:31:18.000000000","message":"I didnt see it complaining , anyway i will do as per suggestion. This code is excercised in ilo driver CI, and wher ei dont see any issue with this.","commit_id":"ecd0e2f48a9f3ce3f6840428af331cb986efbd00"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1e9ea9493ca3a307a38fa15ae65754042794a82e","unresolved":false,"context_lines":[{"line_number":978,"context_line":"    cd $IRONIC_PYTHON_AGENT_DIR"},{"line_number":979,"context_line":"    if is_deploy_iso_required; then"},{"line_number":980,"context_line":"        imagebuild/coreos/iso-image-create -k $kernel_path -i $ramdisk_path -o $iso_path"},{"line_number":981,"context_line":"    fi"},{"line_number":982,"context_line":"    cd -"},{"line_number":983,"context_line":"}"},{"line_number":984,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"5a18252c_52e95ee5","line":981,"updated":"2016-04-14 13:44:21.000000000","message":"This isn\u0027t how you build an iso for tinyipa, you need to use \"make iso\" inside the imagebuild/tinyipa directory before make clean is called.","commit_id":"9440680522c68f68a2f0712c647f5d98c1daa6a4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ce3f8297048c2da8175249d3c40933d7fe9e21c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"# (The value must be an absolute path)"},{"line_number":136,"context_line":"IRONIC_DEPLOY_RAMDISK\u003d${IRONIC_DEPLOY_RAMDISK:-}"},{"line_number":137,"context_line":"IRONIC_DEPLOY_KERNEL\u003d${IRONIC_DEPLOY_KERNEL:-}"},{"line_number":138,"context_line":"IRONIC_DEPLOY_ISO\u003d${IRONIC_DEPLOY_ISO:-}"},{"line_number":139,"context_line":"IRONIC_DEPLOY_ELEMENT\u003d${IRONIC_DEPLOY_ELEMENT:-deploy-ironic}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# NOTE(jroll) this needs to be updated when stable branches are cut"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_c036a8e6","line":138,"updated":"2016-06-02 18:18:25.000000000","message":"does the comment at line 134 also pertain to this?","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"405bee40e96be3954f8fc90cd7f08f038c8fedae","unresolved":false,"context_lines":[{"line_number":135,"context_line":"# (The value must be an absolute path)"},{"line_number":136,"context_line":"IRONIC_DEPLOY_RAMDISK\u003d${IRONIC_DEPLOY_RAMDISK:-}"},{"line_number":137,"context_line":"IRONIC_DEPLOY_KERNEL\u003d${IRONIC_DEPLOY_KERNEL:-}"},{"line_number":138,"context_line":"IRONIC_DEPLOY_ISO\u003d${IRONIC_DEPLOY_ISO:-}"},{"line_number":139,"context_line":"IRONIC_DEPLOY_ELEMENT\u003d${IRONIC_DEPLOY_ELEMENT:-deploy-ironic}"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# NOTE(jroll) this needs to be updated when stable branches are cut"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_b7e11a01","line":138,"in_reply_to":"9abb7d3a_c036a8e6","updated":"2016-06-02 23:51:07.000000000","message":"Yes, it works as IRONIC_DEPLOY_RAMDISK/IRONIC_DEPLOY_KERNEL works.","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ce3f8297048c2da8175249d3c40933d7fe9e21c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"}"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"function is_deploy_iso_required {"},{"line_number":284,"context_line":"    [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"True\" \u0026\u0026  \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":285,"context_line":"    return 1"},{"line_number":286,"context_line":"}"},{"line_number":287,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_8524b2af","line":284,"updated":"2016-06-02 18:18:25.000000000","message":"i noticed this in a previous patch by you (I think it was you). Any reason for having two blank spaces (after \u0027\u0026\u0026\u0027)?","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"405bee40e96be3954f8fc90cd7f08f038c8fedae","unresolved":false,"context_lines":[{"line_number":281,"context_line":"}"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"function is_deploy_iso_required {"},{"line_number":284,"context_line":"    [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"True\" \u0026\u0026  \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":285,"context_line":"    return 1"},{"line_number":286,"context_line":"}"},{"line_number":287,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_57c8ae74","line":284,"in_reply_to":"9abb7d3a_8524b2af","updated":"2016-06-02 23:51:07.000000000","message":"No particular reason, Will change it.","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ce3f8297048c2da8175249d3c40933d7fe9e21c","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"            ;;"},{"line_number":1014,"context_line":"        \u0027dib\u0027)"},{"line_number":1015,"context_line":"            if is_deploy_iso_required; then"},{"line_number":1016,"context_line":"                build_ipa_dib_ramdisk $kernel_path $ramdisk_path $iso_path"},{"line_number":1017,"context_line":"            else"},{"line_number":1018,"context_line":"                build_ipa_dib_ramdisk $kernel_path $ramdisk_path"},{"line_number":1019,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_a07ba47a","line":1016,"updated":"2016-06-02 18:18:25.000000000","message":"why don\u0027t you just have this line instead of the if/else? It looks like build_ipa_dib_ramdisk() checks/handles based on is_deploy_iso_required anyway. And doing this would make it more consistent with what you did in lines 1009 \u0026 1012.","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"405bee40e96be3954f8fc90cd7f08f038c8fedae","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"            ;;"},{"line_number":1014,"context_line":"        \u0027dib\u0027)"},{"line_number":1015,"context_line":"            if is_deploy_iso_required; then"},{"line_number":1016,"context_line":"                build_ipa_dib_ramdisk $kernel_path $ramdisk_path $iso_path"},{"line_number":1017,"context_line":"            else"},{"line_number":1018,"context_line":"                build_ipa_dib_ramdisk $kernel_path $ramdisk_path"},{"line_number":1019,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_37aa4a71","line":1016,"in_reply_to":"9abb7d3a_a07ba47a","updated":"2016-06-02 23:51:07.000000000","message":"Ok.","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ce3f8297048c2da8175249d3c40933d7fe9e21c","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"                        -o $TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER"},{"line_number":1129,"context_line":"                fi"},{"line_number":1130,"context_line":"            else"},{"line_number":1131,"context_line":"                die $LINENO \"Deploy kernel+ramdisk files don\u0027t exist and cannot be built in OFFLINE mode\""},{"line_number":1132,"context_line":"            fi"},{"line_number":1133,"context_line":"        else"},{"line_number":1134,"context_line":"            if is_deployed_with_ipa_ramdisk; then"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_c0918854","line":1131,"updated":"2016-06-02 18:18:25.000000000","message":"what if only the .iso is missing?","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"405bee40e96be3954f8fc90cd7f08f038c8fedae","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"                        -o $TOP_DIR/files/ir-deploy-$IRONIC_DEPLOY_DRIVER"},{"line_number":1129,"context_line":"                fi"},{"line_number":1130,"context_line":"            else"},{"line_number":1131,"context_line":"                die $LINENO \"Deploy kernel+ramdisk files don\u0027t exist and cannot be built in OFFLINE mode\""},{"line_number":1132,"context_line":"            fi"},{"line_number":1133,"context_line":"        else"},{"line_number":1134,"context_line":"            if is_deployed_with_ipa_ramdisk; then"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_f7f44288","line":1131,"in_reply_to":"9abb7d3a_c0918854","updated":"2016-06-02 23:51:07.000000000","message":"ok will add/modify message accordingly.","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ce3f8297048c2da8175249d3c40933d7fe9e21c","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"            if is_deployed_with_ipa_ramdisk; then"},{"line_number":1135,"context_line":"                # download the agent image tarball"},{"line_number":1136,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_DEPLOY_KERNEL_PATH"},{"line_number":1137,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":1138,"context_line":"            else"},{"line_number":1139,"context_line":"                die $LINENO \"Deploy kernel+ramdisk files don\u0027t exist and their building was disabled explicitly by IRONIC_BUILD_DEPLOY_RAMDISK\""},{"line_number":1140,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_a0b3a409","line":1137,"updated":"2016-06-02 18:18:25.000000000","message":"is the .iso going to be available too?","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"405bee40e96be3954f8fc90cd7f08f038c8fedae","unresolved":false,"context_lines":[{"line_number":1134,"context_line":"            if is_deployed_with_ipa_ramdisk; then"},{"line_number":1135,"context_line":"                # download the agent image tarball"},{"line_number":1136,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_DEPLOY_KERNEL_PATH"},{"line_number":1137,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":1138,"context_line":"            else"},{"line_number":1139,"context_line":"                die $LINENO \"Deploy kernel+ramdisk files don\u0027t exist and their building was disabled explicitly by IRONIC_BUILD_DEPLOY_RAMDISK\""},{"line_number":1140,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_5749cecf","line":1137,"in_reply_to":"9abb7d3a_a0b3a409","updated":"2016-06-02 23:51:07.000000000","message":"Never tried this part of the code in the iLO gate. I dont want to add the code which is not tried even once.","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ce3f8297048c2da8175249d3c40933d7fe9e21c","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_DEPLOY_KERNEL_PATH"},{"line_number":1137,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":1138,"context_line":"            else"},{"line_number":1139,"context_line":"                die $LINENO \"Deploy kernel+ramdisk files don\u0027t exist and their building was disabled explicitly by IRONIC_BUILD_DEPLOY_RAMDISK\""},{"line_number":1140,"context_line":"            fi"},{"line_number":1141,"context_line":"        fi"},{"line_number":1142,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_80866011","line":1139,"updated":"2016-06-02 18:18:25.000000000","message":"what about the .iso?","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"405bee40e96be3954f8fc90cd7f08f038c8fedae","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_DEPLOY_KERNEL_PATH"},{"line_number":1137,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":1138,"context_line":"            else"},{"line_number":1139,"context_line":"                die $LINENO \"Deploy kernel+ramdisk files don\u0027t exist and their building was disabled explicitly by IRONIC_BUILD_DEPLOY_RAMDISK\""},{"line_number":1140,"context_line":"            fi"},{"line_number":1141,"context_line":"        fi"},{"line_number":1142,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_971176b2","line":1139,"in_reply_to":"9abb7d3a_80866011","updated":"2016-06-02 23:51:07.000000000","message":"this should be modified only if ISO is added in true part of \u0027if\u0027.","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f141b69d388550d5d159961076cbfde2549003b","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"    die_if_not_set $LINENO IRONIC_DEPLOY_RAMDISK_ID \"Failed to load ramdisk image into glance\""},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    if is_deploy_iso_required; then"},{"line_number":1162,"context_line":"        IRONIC_DEPLOY_ISO_ID\u003d$(openstack \\"},{"line_number":1163,"context_line":"            image create \\"},{"line_number":1164,"context_line":"            $(basename $IRONIC_DEPLOY_ISO_PATH) \\"},{"line_number":1165,"context_line":"            --public --disk-format\u003diso \\"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_421c4d13","line":1162,"updated":"2016-05-30 12:33:50.000000000","message":"seems unused","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a1842477c28169f2953a02baf57e984748d61b02","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"    die_if_not_set $LINENO IRONIC_DEPLOY_RAMDISK_ID \"Failed to load ramdisk image into glance\""},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    if is_deploy_iso_required; then"},{"line_number":1162,"context_line":"        IRONIC_DEPLOY_ISO_ID\u003d$(openstack \\"},{"line_number":1163,"context_line":"            image create \\"},{"line_number":1164,"context_line":"            $(basename $IRONIC_DEPLOY_ISO_PATH) \\"},{"line_number":1165,"context_line":"            --public --disk-format\u003diso \\"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_ed4cfbc9","line":1162,"in_reply_to":"9abb7d3a_421c4d13","updated":"2016-05-31 23:25:17.000000000","message":"+1 this is unused","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"405bee40e96be3954f8fc90cd7f08f038c8fedae","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"    die_if_not_set $LINENO IRONIC_DEPLOY_RAMDISK_ID \"Failed to load ramdisk image into glance\""},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    if is_deploy_iso_required; then"},{"line_number":1162,"context_line":"        IRONIC_DEPLOY_ISO_ID\u003d$(openstack \\"},{"line_number":1163,"context_line":"            image create \\"},{"line_number":1164,"context_line":"            $(basename $IRONIC_DEPLOY_ISO_PATH) \\"},{"line_number":1165,"context_line":"            --public --disk-format\u003diso \\"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_7799721f","line":1162,"in_reply_to":"9abb7d3a_ed4cfbc9","updated":"2016-06-02 23:51:07.000000000","message":"Ok i actually use this in ilo driver devstack-gate plugin. I will try to modify in the ironic devstack, and use it at gate and then see if that works.","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f141b69d388550d5d159961076cbfde2549003b","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"            $(basename $IRONIC_DEPLOY_ISO_PATH) \\"},{"line_number":1165,"context_line":"            --public --disk-format\u003diso \\"},{"line_number":1166,"context_line":"            --container-format\u003dbare \\"},{"line_number":1167,"context_line":"            \u003c $IRONIC_DEPLOY_ISO_PATH  | grep \u0027 id \u0027 | get_field 2)"},{"line_number":1168,"context_line":"        die_if_not_set $LINENO IRONIC_DEPLOY_ISO_ID \"Failed to load ramdisk iso into glance\""},{"line_number":1169,"context_line":"    fi"},{"line_number":1170,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_a21b791a","line":1167,"updated":"2016-05-30 12:33:50.000000000","message":"instead of this grep magic please use \"-f value -c id\"","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"405bee40e96be3954f8fc90cd7f08f038c8fedae","unresolved":false,"context_lines":[{"line_number":1164,"context_line":"            $(basename $IRONIC_DEPLOY_ISO_PATH) \\"},{"line_number":1165,"context_line":"            --public --disk-format\u003diso \\"},{"line_number":1166,"context_line":"            --container-format\u003dbare \\"},{"line_number":1167,"context_line":"            \u003c $IRONIC_DEPLOY_ISO_PATH  | grep \u0027 id \u0027 | get_field 2)"},{"line_number":1168,"context_line":"        die_if_not_set $LINENO IRONIC_DEPLOY_ISO_ID \"Failed to load ramdisk iso into glance\""},{"line_number":1169,"context_line":"    fi"},{"line_number":1170,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_57938efa","line":1167,"in_reply_to":"9abb7d3a_a21b791a","updated":"2016-06-02 23:51:07.000000000","message":"Ok","commit_id":"daeb6ebfa6fe305acb62d80a200fd587f7fe9850"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"06d9abef95ec0838f0e274ae2cb485bcc1bdca26","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"                # download the agent image tarball"},{"line_number":1164,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_DEPLOY_KERNEL_PATH"},{"line_number":1165,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":1166,"context_line":"                wget \"$IRONIC_AGENT_ISO_URL\" -O $IRONIC_DEPLOY_ISO_PATH"},{"line_number":1167,"context_line":"            else"},{"line_number":1168,"context_line":"                die $LINENO \"Deploy kernel+ramdisk or iso files don\u0027t exist and their building was disabled explicitly by IRONIC_BUILD_DEPLOY_RAMDISK\""},{"line_number":1169,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"7aa08908_b2cad14d","line":1166,"updated":"2016-06-06 11:25:00.000000000","message":"This currently is breaking the tests for this patch, IRONIC_AGENT_ISO_URL doesn\u0027t exist, so wget is erroring out. Also if you intend to make this downloadable then you will need an additional patch into project-config to enable creating an ISO and uploading it as part of the IPA post merge job.","commit_id":"fb14e72c1dd746a128a4cbfb06e89db5489d7c0d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"20ee9c17aa74837be8cb52c62f9174096ad5c8dd","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"                # download the agent image tarball"},{"line_number":1164,"context_line":"                wget \"$IRONIC_AGENT_KERNEL_URL\" -O $IRONIC_DEPLOY_KERNEL_PATH"},{"line_number":1165,"context_line":"                wget \"$IRONIC_AGENT_RAMDISK_URL\" -O $IRONIC_DEPLOY_RAMDISK_PATH"},{"line_number":1166,"context_line":"                wget \"$IRONIC_AGENT_ISO_URL\" -O $IRONIC_DEPLOY_ISO_PATH"},{"line_number":1167,"context_line":"            else"},{"line_number":1168,"context_line":"                die $LINENO \"Deploy kernel+ramdisk or iso files don\u0027t exist and their building was disabled explicitly by IRONIC_BUILD_DEPLOY_RAMDISK\""},{"line_number":1169,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"7aa08908_cff79289","line":1166,"in_reply_to":"7aa08908_b2cad14d","updated":"2016-06-08 16:41:54.000000000","message":"Thanks for pointing out issue. BUt i just added the code for completeness. I already stated i cannot test this part of code in iLO CI. I am ok to not add ISO related code here as i cannot test that.","commit_id":"fb14e72c1dd746a128a4cbfb06e89db5489d7c0d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"af45013b58eacb1c94e77765b9e7ba3b37bbb6d1","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"            $(basename $IRONIC_DEPLOY_ISO_PATH) \\"},{"line_number":1194,"context_line":"            --public --disk-format\u003diso \\"},{"line_number":1195,"context_line":"            --container-format\u003dbare \\"},{"line_number":1196,"context_line":"            \u003c $IRONIC_DEPLOY_ISO_PATH  | grep \u0027 id \u0027 | get_field 2)"},{"line_number":1197,"context_line":"        die_if_not_set $LINENO IRONIC_DEPLOY_ISO_ID \"Failed to load ramdisk iso into glance\""},{"line_number":1198,"context_line":"    fi"},{"line_number":1199,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"7aa08908_8de7b6e3","line":1196,"updated":"2016-06-06 11:42:43.000000000","message":"\"-f value -c id\" added to the command should work instead of grepping.","commit_id":"fb14e72c1dd746a128a4cbfb06e89db5489d7c0d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"20ee9c17aa74837be8cb52c62f9174096ad5c8dd","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"            $(basename $IRONIC_DEPLOY_ISO_PATH) \\"},{"line_number":1194,"context_line":"            --public --disk-format\u003diso \\"},{"line_number":1195,"context_line":"            --container-format\u003dbare \\"},{"line_number":1196,"context_line":"            \u003c $IRONIC_DEPLOY_ISO_PATH  | grep \u0027 id \u0027 | get_field 2)"},{"line_number":1197,"context_line":"        die_if_not_set $LINENO IRONIC_DEPLOY_ISO_ID \"Failed to load ramdisk iso into glance\""},{"line_number":1198,"context_line":"    fi"},{"line_number":1199,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"7aa08908_0f451ab2","line":1196,"in_reply_to":"7aa08908_8de7b6e3","updated":"2016-06-08 16:41:54.000000000","message":"yes. forgot to do that in previous patch. But even above code (for deploy ramdisk and deploy kernel) has the same code what i have added here.","commit_id":"fb14e72c1dd746a128a4cbfb06e89db5489d7c0d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"af45013b58eacb1c94e77765b9e7ba3b37bbb6d1","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"            --public --disk-format\u003diso \\"},{"line_number":1195,"context_line":"            --container-format\u003dbare \\"},{"line_number":1196,"context_line":"            \u003c $IRONIC_DEPLOY_ISO_PATH  | grep \u0027 id \u0027 | get_field 2)"},{"line_number":1197,"context_line":"        die_if_not_set $LINENO IRONIC_DEPLOY_ISO_ID \"Failed to load ramdisk iso into glance\""},{"line_number":1198,"context_line":"    fi"},{"line_number":1199,"context_line":"}"},{"line_number":1200,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"7aa08908_cd3a5ecd","line":1197,"range":{"start_line":1197,"start_character":68,"end_line":1197,"end_character":75},"updated":"2016-06-06 11:42:43.000000000","message":"I guess it should be \"deploy iso\" :)","commit_id":"fb14e72c1dd746a128a4cbfb06e89db5489d7c0d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"20ee9c17aa74837be8cb52c62f9174096ad5c8dd","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"            --public --disk-format\u003diso \\"},{"line_number":1195,"context_line":"            --container-format\u003dbare \\"},{"line_number":1196,"context_line":"            \u003c $IRONIC_DEPLOY_ISO_PATH  | grep \u0027 id \u0027 | get_field 2)"},{"line_number":1197,"context_line":"        die_if_not_set $LINENO IRONIC_DEPLOY_ISO_ID \"Failed to load ramdisk iso into glance\""},{"line_number":1198,"context_line":"    fi"},{"line_number":1199,"context_line":"}"},{"line_number":1200,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"7aa08908_8f0f4a87","line":1197,"range":{"start_line":1197,"start_character":68,"end_line":1197,"end_character":75},"in_reply_to":"7aa08908_cd3a5ecd","updated":"2016-06-08 16:41:54.000000000","message":"yes. :)","commit_id":"fb14e72c1dd746a128a4cbfb06e89db5489d7c0d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d45a85f20acf276e3cf2e6cd76820587eed96bca","unresolved":false,"context_lines":[{"line_number":169,"context_line":"# Some drivers in Ironic require deploy ramdisk in bootable ISO format."},{"line_number":170,"context_line":"# Set this variable to \"true\" to build an ISO for deploy ramdisk and"},{"line_number":171,"context_line":"# upload to Glance."},{"line_number":172,"context_line":"IRONIC_DEPLOY_ISO_REQUIRED\u003d$(trueorfalse False IRONIC_DEPLOY_ISO_REQUIRED)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# Which deploy driver to use - valid choices right now"},{"line_number":175,"context_line":"# are ``pxe_ssh``, ``pxe_ipmitool``, ``agent_ssh`` and ``agent_ipmitool``."}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"7aa08908_30235da9","line":172,"updated":"2016-06-10 12:42:29.000000000","message":"Should add an if statement here, so that we can fail early if local.conf isn\u0027t configured correctly.\n\nif IRONIC_DEPLOY_ISO_REQUIRED \u003d \u0027True\u0027 \u0026\u0026 IRONIC_BUILD_DEPLOY_RAMDISK \u003d \u0027False\u0027 \u0026\u0026 [ -n IRONIC_DEPLOY_ISO ]; then\n    die \"Prebuilt ISOs are not available, provide an ISO via IRONIC_DEPLOY_ISO or set IRONIC_BUILD_DEPLOY_RAMDISK\u003dTrue to use ISOs\"\nfi","commit_id":"81567516b7b4b30755918566bd26febb81b1183b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d45a85f20acf276e3cf2e6cd76820587eed96bca","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    return 1"},{"line_number":291,"context_line":"}"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"function is_deploy_iso_required {"},{"line_number":294,"context_line":"    [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"True\" \u0026\u0026 \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":295,"context_line":"    return 1"},{"line_number":296,"context_line":"}"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"function setup_virtualbmc {"},{"line_number":299,"context_line":"    # Install pyghmi from source, if requested, otherwise it will be"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"7aa08908_a672730f","line":296,"range":{"start_line":293,"start_character":0,"end_line":296,"end_character":1},"updated":"2016-06-10 12:42:29.000000000","message":"I\u0027m not sure this check needs to take into account IRONIC_IS_HARDWARE, we\u0027ve discussed using virtual media for optimising simulated baremetal deployments too, for example something like the virtual box driver could take advantage of it in the future. Just checking IRONIC_DEPLOY_ISO_REQUIRED should be fine.","commit_id":"81567516b7b4b30755918566bd26febb81b1183b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3c9e09e1220c2938e19a4ea24454371bd2f49929","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    return 1"},{"line_number":291,"context_line":"}"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"function is_deploy_iso_required {"},{"line_number":294,"context_line":"    [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"True\" \u0026\u0026 \"$IRONIC_DEPLOY_ISO_REQUIRED\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":295,"context_line":"    return 1"},{"line_number":296,"context_line":"}"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"function setup_virtualbmc {"},{"line_number":299,"context_line":"    # Install pyghmi from source, if requested, otherwise it will be"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"7aa08908_43ffa865","line":296,"range":{"start_line":293,"start_character":0,"end_line":296,"end_character":1},"in_reply_to":"7aa08908_a672730f","updated":"2016-06-14 17:17:52.000000000","message":"I just remember that this was done as part of comment and verified that the code works. I believe since currently virtual media drivers are only third party drivers, we we should retain the existing condition. We can remove the part you said when we have simauted virtual media driver at gate.","commit_id":"81567516b7b4b30755918566bd26febb81b1183b"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"d45a85f20acf276e3cf2e6cd76820587eed96bca","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                    -i ucs_username\u003d$bmc_username -i ucs_service_profile\u003d$ucs_service_profile\""},{"line_number":898,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":899,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER -ne \"pxe_ilo\" ]]; then"},{"line_number":900,"context_line":"                    node_options\u003d\"-i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":901,"context_line":"                fi"},{"line_number":902,"context_line":"            fi"},{"line_number":903,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"7aa08908_b0b90d18","line":900,"updated":"2016-06-10 12:42:29.000000000","message":"Doesn\u0027t an ilo node require credentials?","commit_id":"81567516b7b4b30755918566bd26febb81b1183b"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"3c9e09e1220c2938e19a4ea24454371bd2f49929","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                    -i ucs_username\u003d$bmc_username -i ucs_service_profile\u003d$ucs_service_profile\""},{"line_number":898,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":899,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER -ne \"pxe_ilo\" ]]; then"},{"line_number":900,"context_line":"                    node_options\u003d\"-i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":901,"context_line":"                fi"},{"line_number":902,"context_line":"            fi"},{"line_number":903,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"7aa08908_4e0d0f8e","line":900,"in_reply_to":"7aa08908_b0b90d18","updated":"2016-06-14 17:17:52.000000000","message":":) i think i overlooked that part because of pxe_ilo driver. Thanks for pointing. Actually we have it in our devstack-gate plugin(https://github.com/hpproliant/devstack-gate), so it works at our gate. anyway i gradually plan to move the things to ironic upstream devstack plugin instead of our plugin. As a side note, there are lot of changes which are not merged in the devstack-gate plugin which we use in our ilo gate.","commit_id":"81567516b7b4b30755918566bd26febb81b1183b"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"50973a4c05441a000fa0c3ce1ca2128b1a65e406","unresolved":false,"context_lines":[{"line_number":276,"context_line":"}"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"function is_deployed_with_ipa_ramdisk {"},{"line_number":279,"context_line":"    is_deployed_by_agent || [[ \"$IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":280,"context_line":"    return 1"},{"line_number":281,"context_line":"}"},{"line_number":282,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"3aaa91ec_f3491090","line":279,"updated":"2016-06-21 23:47:42.000000000","message":"IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA is no longer used as the bash ramdisk is deprecated.","commit_id":"b22e746a4dda5f4701ebfe0133a13fea6cf958a9"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"994f84d3fe3bb824bda475e5e3ff30d62c0620cd","unresolved":false,"context_lines":[{"line_number":938,"context_line":"            elif is_deployed_by_ilo; then"},{"line_number":939,"context_line":"                node_options+\u003d\" -i ilo_address\u003d$bmc_address -i ilo_password\u003d$bmc_passwd\\"},{"line_number":940,"context_line":"                    -i ilo_username\u003d$bmc_username\""},{"line_number":941,"context_line":"                if [[ $IRONIC_DEPLOY_DRIVER -ne \"pxe_ilo\" ]]; then"},{"line_number":942,"context_line":"                    node_options+\u003d\" -i ilo_deploy_iso\u003d$IRONIC_DEPLOY_ISO_ID\""},{"line_number":943,"context_line":"                fi"},{"line_number":944,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":29,"id":"1aa78d24_148135c4","line":941,"range":{"start_line":941,"start_character":22,"end_line":941,"end_character":57},"updated":"2016-07-13 20:05:04.000000000","message":"nit: I rather pin it to the specific drivers that use VirtualMedia since another driver can come to scene on the future and break things.","commit_id":"6edfdfac311e55c9dfce77a6f25b900c8777b79c"}]}