)]}'
{"devstack/tools/ironic/scripts/setup-network.sh":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"805792efe24b529f637f509618ddd72575ff8145","unresolved":false,"context_lines":[{"line_number":17,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d\"$LIBVIRT_CONNECT_URI\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Only add bridge if missing"},{"line_number":20,"context_line":"(sudo ovs-vsctl list-br | grep ${BRIDGE_NAME}$) || (sudo ovs-vsctl add-br ${BRIDGE_NAME}; sudo ifconfig ${BRIDGE_NAME} up)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Remove bridge before replacing it."},{"line_number":23,"context_line":"(virsh net-list | grep \"${BRIDGE_NAME} \") \u0026\u0026 virsh net-destroy ${BRIDGE_NAME}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa69d971_acc94eae","line":20,"updated":"2016-01-08 13:08:46.000000000","message":"What if it exists but is down? Maybe we should call ifconfig up in any case?","commit_id":"ec9e4599d9bada1d50a6ec5cbe5938fde9c4c1e6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e6d20c6c3c332727fedfba1808e304e63eb536c1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d\"$LIBVIRT_CONNECT_URI\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Only add bridge if missing"},{"line_number":20,"context_line":"(sudo ovs-vsctl list-br | grep ${BRIDGE_NAME}$) || (sudo ovs-vsctl add-br ${BRIDGE_NAME}; sudo ifconfig ${BRIDGE_NAME} up)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Remove bridge before replacing it."},{"line_number":23,"context_line":"(virsh net-list | grep \"${BRIDGE_NAME} \") \u0026\u0026 virsh net-destroy ${BRIDGE_NAME}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa69d971_2cc8fe73","line":20,"in_reply_to":"fa69d971_acc94eae","updated":"2016-01-08 13:12:45.000000000","message":"Done","commit_id":"ec9e4599d9bada1d50a6ec5cbe5938fde9c4c1e6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"08658260dd5273d88b7f4f4af3d5dc30f294a63c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d\"$LIBVIRT_CONNECT_URI\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Only add bridge if missing. Bring it UP permanently."},{"line_number":20,"context_line":"(sudo ovs-vsctl list-br | grep ${BRIDGE_NAME}$) || sudo ovs-vsctl add-br ${BRIDGE_NAME}"},{"line_number":21,"context_line":"sudo ifconfig ${BRIDGE_NAME} up"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa69d971_ac34ee49","line":19,"range":{"start_line":19,"start_character":30,"end_line":19,"end_character":54},"updated":"2016-01-08 13:17:11.000000000","message":"Changing interface state with is just a running state change.  AFAIK, Libvirt is \"supposed\" to start the interface when needed, but needs to know that it is enabled.","commit_id":"53ae435dfc4495cc3daf891f00b6b415af08a6bf"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"db1684cde00b68a40f38cf0b8576a51a09fc3862","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"export VIRSH_DEFAULT_CONNECT_URI\u003d\"$LIBVIRT_CONNECT_URI\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Only add bridge if missing. Bring it UP permanently."},{"line_number":20,"context_line":"(sudo ovs-vsctl list-br | grep ${BRIDGE_NAME}$) || sudo ovs-vsctl add-br ${BRIDGE_NAME}"},{"line_number":21,"context_line":"sudo ifconfig ${BRIDGE_NAME} up"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa69d971_ee03bbb6","line":19,"range":{"start_line":19,"start_character":30,"end_line":19,"end_character":54},"in_reply_to":"fa69d971_ac34ee49","updated":"2016-01-08 13:25:32.000000000","message":"Thanks for review Julia. Libvirt will not touch external interface during \u0027net-start\u0027. We need to ensure that bridge is UP manually.","commit_id":"53ae435dfc4495cc3daf891f00b6b415af08a6bf"}]}