)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1ca4ec0dbab80c8afe66e28edb46f355320ba749","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vmud213 \u003cvinay50muddu@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-11 10:08:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issues with uefi-ipxe booting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1532679"},{"line_number":10,"context_line":"Change-Id: Idf78195d228b4861f85fbcae9a269edd95523ad7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_96a1b896","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":15},"updated":"2016-01-11 10:53:27.000000000","message":"Can you please add more details of defect fix after fix summary line.","commit_id":"c2f219601f10f3dedea33abb49f4a40008730881"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7944b05f9f8dfb301312c7b9de6c38b375a73459","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vmud213 \u003cvinay50muddu@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-11 10:08:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issues with uefi-ipxe booting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1532679"},{"line_number":10,"context_line":"Change-Id: Idf78195d228b4861f85fbcae9a269edd95523ad7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6ed579_4c9339fb","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":15},"in_reply_to":"fa69d971_96a1b896","updated":"2016-01-12 10:10:27.000000000","message":"Ok. I will update the summary.","commit_id":"c2f219601f10f3dedea33abb49f4a40008730881"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a843347c0f22feaadb7908dd43d298d362435ac2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix issues with uefi-ipxe booting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When booting from ipxe in uefi boot mode, once the node boots with deploy"},{"line_number":10,"context_line":"image, ironic is supposed to make changes to the ipxe config to make it boot"},{"line_number":11,"context_line":"the instance image from boot_partition."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1532679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da6ed579_9c12a2b3","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":28},"updated":"2016-01-12 18:41:56.000000000","message":"The commit message seems to be confusing. ironic needs to make changes is anyway known when the bug is raised.","commit_id":"a63ad23f1a330180d6bfb83c7d4634227fc5eb48"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e442bf1603abe69399ce06ed3702f5121ecb2715","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix issues with uefi-ipxe booting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When booting from ipxe in uefi boot mode, once the node boots with deploy"},{"line_number":10,"context_line":"image, ironic is supposed to make changes to the ipxe config to make it boot"},{"line_number":11,"context_line":"the instance image from boot_partition."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1532679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da6ed579_06e170fe","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":28},"in_reply_to":"da6ed579_9c12a2b3","updated":"2016-01-13 01:42:20.000000000","message":"I tried to explain why this commit is for. May be i need to further add the following sentence after line:11\n\"This fix introduces those changes which were missing earlier.\"","commit_id":"a63ad23f1a330180d6bfb83c7d4634227fc5eb48"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1ca4ec0dbab80c8afe66e28edb46f355320ba749","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    else:"},{"line_number":245,"context_line":"        boot_disk_type \u003d \u0027boot_partition\u0027"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    if boot_mode \u003d\u003d \u0027uefi\u0027 and not CONF.pxe.ipxe_enabled:"},{"line_number":248,"context_line":"        pattern \u003d \u0027^((set )?default)\u003d.*$\u0027"},{"line_number":249,"context_line":"        boot_line \u003d \u0027\\\\1\u003d%s\u0027 % boot_disk_type"},{"line_number":250,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_f9ffc7fe","line":247,"range":{"start_line":247,"start_character":30,"end_line":247,"end_character":31},"updated":"2016-01-11 10:53:27.000000000","message":"Add testcase for this change.","commit_id":"c2f219601f10f3dedea33abb49f4a40008730881"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"7944b05f9f8dfb301312c7b9de6c38b375a73459","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    else:"},{"line_number":245,"context_line":"        boot_disk_type \u003d \u0027boot_partition\u0027"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    if boot_mode \u003d\u003d \u0027uefi\u0027 and not CONF.pxe.ipxe_enabled:"},{"line_number":248,"context_line":"        pattern \u003d \u0027^((set )?default)\u003d.*$\u0027"},{"line_number":249,"context_line":"        boot_line \u003d \u0027\\\\1\u003d%s\u0027 % boot_disk_type"},{"line_number":250,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_4c81f98e","line":247,"range":{"start_line":247,"start_character":30,"end_line":247,"end_character":31},"in_reply_to":"fa69d971_df5bc384","updated":"2016-01-12 10:10:27.000000000","message":"Will do in the next patch set.","commit_id":"c2f219601f10f3dedea33abb49f4a40008730881"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7d3ad782f2e83fa8d000ff025551b8b418c4b1fe","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    else:"},{"line_number":245,"context_line":"        boot_disk_type \u003d \u0027boot_partition\u0027"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    if boot_mode \u003d\u003d \u0027uefi\u0027 and not CONF.pxe.ipxe_enabled:"},{"line_number":248,"context_line":"        pattern \u003d \u0027^((set )?default)\u003d.*$\u0027"},{"line_number":249,"context_line":"        boot_line \u003d \u0027\\\\1\u003d%s\u0027 % boot_disk_type"},{"line_number":250,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_df5bc384","line":247,"range":{"start_line":247,"start_character":30,"end_line":247,"end_character":31},"in_reply_to":"fa69d971_f9ffc7fe","updated":"2016-01-11 11:44:12.000000000","message":"++","commit_id":"c2f219601f10f3dedea33abb49f4a40008730881"}],"ironic/drivers/modules/ipxe_config.template":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1ca4ec0dbab80c8afe66e28edb46f355320ba749","unresolved":false,"context_lines":[{"line_number":11,"context_line":"boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":boot_partition"},{"line_number":14,"context_line":"kernel {{ pxe_options.aki_path }} root\u003d{{ ROOT }} ro text {{ pxe_options.pxe_append_params|default(\"\", true) }} initrd\u003dramdisk"},{"line_number":15,"context_line":"initrd {{ pxe_options.ari_path }}"},{"line_number":16,"context_line":"boot"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa69d971_36c56c5b","line":14,"range":{"start_line":14,"start_character":119,"end_line":14,"end_character":126},"updated":"2016-01-11 10:53:27.000000000","message":"nit: To follow the convention, can we do?\ns/ ramdisk/ boot_ramdisk","commit_id":"c2f219601f10f3dedea33abb49f4a40008730881"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7d3ad782f2e83fa8d000ff025551b8b418c4b1fe","unresolved":false,"context_lines":[{"line_number":11,"context_line":"boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":boot_partition"},{"line_number":14,"context_line":"kernel {{ pxe_options.aki_path }} root\u003d{{ ROOT }} ro text {{ pxe_options.pxe_append_params|default(\"\", true) }} initrd\u003dramdisk"},{"line_number":15,"context_line":"initrd {{ pxe_options.ari_path }}"},{"line_number":16,"context_line":"boot"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa69d971_ff600737","line":14,"range":{"start_line":14,"start_character":119,"end_line":14,"end_character":126},"in_reply_to":"fa69d971_36c56c5b","updated":"2016-01-11 11:44:12.000000000","message":"-1\n\nAFAIUI this name has to match the name in the initrd parameter which is \"ramdisk\".","commit_id":"c2f219601f10f3dedea33abb49f4a40008730881"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"871515a8437ad5b791a1b2195097879515be78fc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":boot_partition"},{"line_number":14,"context_line":"kernel {{ pxe_options.aki_path }} root\u003d{{ ROOT }} ro text {{ pxe_options.pxe_append_params|default(\"\", true) }} initrd\u003dramdisk"},{"line_number":15,"context_line":"initrd {{ pxe_options.ari_path }}"},{"line_number":16,"context_line":"boot"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da6ed579_750cd342","line":14,"range":{"start_line":14,"start_character":119,"end_line":14,"end_character":126},"in_reply_to":"fa69d971_ff600737","updated":"2016-01-12 03:37:49.000000000","message":"Thanks Lucas.","commit_id":"c2f219601f10f3dedea33abb49f4a40008730881"}],"ironic/tests/unit/drivers/ipxe_config.template":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a9486e4c68c55c541d621e1857d7940ad43440e8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":boot_partition"},{"line_number":14,"context_line":"kernel http://1.2.3.4:1234/kernel root\u003d{{ ROOT }} ro text test_param initrd\u003dramdisk"},{"line_number":15,"context_line":"initrd http://1.2.3.4:1234/ramdisk"},{"line_number":16,"context_line":"boot"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da6ed579_5c3bcaeb","line":14,"range":{"start_line":14,"start_character":69,"end_line":14,"end_character":75},"updated":"2016-01-12 18:50:22.000000000","message":"This config template is for bios, correct? Do we require changes to bios config template too? if yes, should be a seperate patch.","commit_id":"a63ad23f1a330180d6bfb83c7d4634227fc5eb48"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"13b50d20b25ad1bfe543966a87ef9f147935c0ec","unresolved":false,"context_lines":[{"line_number":11,"context_line":"boot"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":":boot_partition"},{"line_number":14,"context_line":"kernel http://1.2.3.4:1234/kernel root\u003d{{ ROOT }} ro text test_param initrd\u003dramdisk"},{"line_number":15,"context_line":"initrd http://1.2.3.4:1234/ramdisk"},{"line_number":16,"context_line":"boot"},{"line_number":17,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da6ed579_1269bbbe","line":14,"range":{"start_line":14,"start_character":69,"end_line":14,"end_character":75},"in_reply_to":"da6ed579_5c3bcaeb","updated":"2016-01-12 19:15:06.000000000","message":"For iPXE we use the same template for BIOS and UEFI and both will have this parameter (it\u0027s hardcoded, we do the same for the deploy ramdisk)","commit_id":"a63ad23f1a330180d6bfb83c7d4634227fc5eb48"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a9486e4c68c55c541d621e1857d7940ad43440e8","unresolved":false,"context_lines":[{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"    def _create_config(self, ipxe\u003dFalse, boot_mode\u003dNone, boot_loader\u003d\u0027elilo\u0027):"},{"line_number":1051,"context_line":"        (fd, fname) \u003d tempfile.mkstemp()"},{"line_number":1052,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027 and not ipxe:"},{"line_number":1053,"context_line":"            if boot_loader \u003d\u003d \u0027grub\u0027:"},{"line_number":1054,"context_line":"                pxe_cfg \u003d _UEFI_PXECONF_DEPLOY_GRUB"},{"line_number":1055,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_9c4aa282","line":1052,"range":{"start_line":1052,"start_character":35,"end_line":1052,"end_character":38},"updated":"2016-01-12 18:50:22.000000000","message":"Add one more test case for this change. i.e. \n\"if boot_mode \u003d\u003d \u0027uefi\u0027 and ipxe\"","commit_id":"a63ad23f1a330180d6bfb83c7d4634227fc5eb48"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"e442bf1603abe69399ce06ed3702f5121ecb2715","unresolved":false,"context_lines":[{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"    def _create_config(self, ipxe\u003dFalse, boot_mode\u003dNone, boot_loader\u003d\u0027elilo\u0027):"},{"line_number":1051,"context_line":"        (fd, fname) \u003d tempfile.mkstemp()"},{"line_number":1052,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027 and not ipxe:"},{"line_number":1053,"context_line":"            if boot_loader \u003d\u003d \u0027grub\u0027:"},{"line_number":1054,"context_line":"                pxe_cfg \u003d _UEFI_PXECONF_DEPLOY_GRUB"},{"line_number":1055,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_46f20871","line":1052,"range":{"start_line":1052,"start_character":35,"end_line":1052,"end_character":38},"in_reply_to":"da6ed579_9c4aa282","updated":"2016-01-13 01:42:20.000000000","message":"I already included 2 test scenarios for UEFI-IPXE.\n\ntest_switch_uefi_ipxe_config_partition_image\ntest_switch_uefi_ipxe_config_whole_disk_image\n\nRemaining are either already covered or not in this scope.","commit_id":"a63ad23f1a330180d6bfb83c7d4634227fc5eb48"}],"releasenotes/notes/ipxe-uefi-f5be11c7b0606a84.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c19036200ce58939bfc0c8d929b52c6fa71704fd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fixes bug where ironic reboots the node"},{"line_number":4,"context_line":"    with deploy image instead of the user image"},{"line_number":5,"context_line":"    during second reboot in uefi boot mode when"},{"line_number":6,"context_line":"    ipxe is enabled. The ipxe template is"},{"line_number":7,"context_line":"    modified with minor change to the code."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    See also https://bugs.launchpad.net/ironic/+bug/1532679"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_87b9947b","line":7,"range":{"start_line":6,"start_character":21,"end_line":7,"end_character":43},"updated":"2016-01-14 05:22:47.000000000","message":"Fix code details are not required.","commit_id":"fd6f489de74f54da3758e5d2e0dafed4ed02d69f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c19036200ce58939bfc0c8d929b52c6fa71704fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ipxe is enabled. The ipxe template is"},{"line_number":7,"context_line":"    modified with minor change to the code."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    See also https://bugs.launchpad.net/ironic/+bug/1532679"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_e79170f2","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":25},"updated":"2016-01-14 05:22:47.000000000","message":"Bug link is not required.","commit_id":"fd6f489de74f54da3758e5d2e0dafed4ed02d69f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"19fe8549b4f5ced03a0c81d060c541a158403389","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ipxe is enabled. The ipxe template is"},{"line_number":7,"context_line":"    modified with minor change to the code."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    See also https://bugs.launchpad.net/ironic/+bug/1532679"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_5ed0301f","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":25},"in_reply_to":"da6ed579_e79170f2","updated":"2016-01-14 13:15:33.000000000","message":"Agreed, I will put up a new patch-set fixing it.","commit_id":"fd6f489de74f54da3758e5d2e0dafed4ed02d69f"}]}
