)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"63a3ff0afc2768a4594c87501154216cb3e09fff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit adds a new config variable"},{"line_number":10,"context_line":"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT, which can be"},{"line_number":11,"context_line":"set to True to configure the Swift related config"},{"line_number":12,"context_line":"parameters of [glance] section in ironic.conf."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1bad2b06b268825e181b7b3125d08c977f54f7b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a68dd71_450b5424","line":12,"updated":"2016-01-25 11:17:32.000000000","message":"Just to understand the use case here, we want to have a node with a agent_* driver registered, SWIFT_ENABLED_TEMPURL \u003d\u003d True but glance not configured to use Swift. Is that correct?\n\nWhat\u0027s the use case here?","commit_id":"177693ed03aa7343496e61a7fd86b307b717132d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ac23ef93201763f605ca8d319e595c78944a1379","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit adds a new config variable"},{"line_number":10,"context_line":"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT, which can be"},{"line_number":11,"context_line":"set to True to configure the Swift related config"},{"line_number":12,"context_line":"parameters of [glance] section in ironic.conf."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1bad2b06b268825e181b7b3125d08c977f54f7b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_448162fa","line":12,"in_reply_to":"7a5de9d1_c67de56d","updated":"2016-02-24 10:28:37.000000000","message":"If I understood correctly you are trying to do not configure [glance] section if IRONIC_DEPLOY_DRIVER is pxe_ilo right?\nBut it is the way how it works at the moment glance section will be configured by ironic devstack plugin only if driver IRONIC_DEPLOY_DRIVER starts with agent and it will be untouched in case pxe_ilo","commit_id":"177693ed03aa7343496e61a7fd86b307b717132d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"4606ac9caaa93fd97b1fc6437f89c31a87c48f74","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit adds a new config variable"},{"line_number":10,"context_line":"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT, which can be"},{"line_number":11,"context_line":"set to True to configure the Swift related config"},{"line_number":12,"context_line":"parameters of [glance] section in ironic.conf."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1bad2b06b268825e181b7b3125d08c977f54f7b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a5de9d1_c67de56d","line":12,"in_reply_to":"9a68dd71_450b5424","updated":"2016-02-02 07:55:39.000000000","message":"No Lucas. Fot agent_ilo and iscsi_ilo drivers we need to do some config settings in [glance] section for swift. This variable just tells that so that the ilo drivers plugin can do that configuration. This configuration is not required for pxe_ilo driver. Hence this variable is needed.","commit_id":"177693ed03aa7343496e61a7fd86b307b717132d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ec249dbb7fffeec4e0ba3ef3bc992a5336b9e91b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit adds a new config variable"},{"line_number":10,"context_line":"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT, which can be"},{"line_number":11,"context_line":"set to True to configure the Swift related config"},{"line_number":12,"context_line":"parameters of [glance] section in ironic.conf."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1bad2b06b268825e181b7b3125d08c977f54f7b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a5de9d1_aea642bf","line":12,"updated":"2016-01-28 10:50:39.000000000","message":"Just to understand the use case here, we want to have a node with a agent_* driver registered, SWIFT_ENABLED_TEMPURL \u003d\u003d True but glance not configured to use Swift. Is that correct?\n\nWhat\u0027s the use case here?","commit_id":"459e7f3870bb42c7a6047c3e5c3c17a1c6f925b6"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"79b67a46f68f3263b1796f6b3b7997c727d02a45","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-14 11:33:31 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[IRONIC] Config variable to configure [glance] section"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some drivers require glance with swift backend to"},{"line_number":10,"context_line":"be able to store some deployment artifacts, e.g."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_b62557c3","line":7,"updated":"2016-05-25 17:30:01.000000000","message":"You don\u0027t need [IRONIC] here.","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8164b99915c926a777cec6bdfdf4331e6d769189","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nisha Agarwal \u003cagarwalnisha1980@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-14 11:33:31 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[IRONIC] Config variable to configure [glance] section"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some drivers require glance with swift backend to"},{"line_number":10,"context_line":"be able to store some deployment artifacts, e.g."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_03a20399","line":7,"in_reply_to":"bab6814e_b62557c3","updated":"2016-05-26 10:55:38.000000000","message":"Done","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e765e23a487459423a5f3fbd94a0f0fed96c126","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Some drivers require glance with swift backend to"},{"line_number":10,"context_line":"be able to store some deployment artifacts, e.g."},{"line_number":11,"context_line":"in case of iscsi_ilo driver it may be boot_iso that"},{"line_number":12,"context_line":"is constructed from deploy_kernel and deploy_ramdisk."},{"line_number":13,"context_line":"This requires some configuration and this change is"},{"line_number":14,"context_line":"intended for such drivers."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_8a3763af","line":12,"updated":"2016-05-25 11:23:18.000000000","message":"These should be user image kernel and ramdisk, not deploy images :)","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8164b99915c926a777cec6bdfdf4331e6d769189","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Some drivers require glance with swift backend to"},{"line_number":10,"context_line":"be able to store some deployment artifacts, e.g."},{"line_number":11,"context_line":"in case of iscsi_ilo driver it may be boot_iso that"},{"line_number":12,"context_line":"is constructed from deploy_kernel and deploy_ramdisk."},{"line_number":13,"context_line":"This requires some configuration and this change is"},{"line_number":14,"context_line":"intended for such drivers."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_83bc33bc","line":12,"in_reply_to":"bab6814e_8a3763af","updated":"2016-05-26 10:55:38.000000000","message":"thanks . done :)","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"}],"devstack/lib/ironic":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5984020cc4164c3c56a2e19687cee268191adaf6","unresolved":false,"context_lines":[{"line_number":203,"context_line":"}"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"function is_deployed_with_ipa_ramdisk {"},{"line_number":206,"context_line":"    f is_deployed_by_agent || [[ \"$IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":207,"context_line":"    return 1"},{"line_number":208,"context_line":"}"},{"line_number":209,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6ed579_4dba0e0c","line":206,"updated":"2016-01-13 11:47:42.000000000","message":"This f should be removed.","commit_id":"d07a6c4882c094ebfc5a6c7a2ca5e031d9795238"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"e540041d40b903206155b0839c4c7ed2898a294d","unresolved":false,"context_lines":[{"line_number":203,"context_line":"}"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"function is_deployed_with_ipa_ramdisk {"},{"line_number":206,"context_line":"    f is_deployed_by_agent || [[ \"$IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":207,"context_line":"    return 1"},{"line_number":208,"context_line":"}"},{"line_number":209,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6ed579_b312d507","line":206,"in_reply_to":"da6ed579_4dba0e0c","updated":"2016-01-14 09:02:21.000000000","message":"thanks for the catch. WIll update in the next patch set.","commit_id":"d07a6c4882c094ebfc5a6c7a2ca5e031d9795238"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5984020cc4164c3c56a2e19687cee268191adaf6","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        if [[ \"$SWIFT_ENABLE_TEMPURLS\" \u003d\u003d \"True\" ]] ; then"},{"line_number":408,"context_line":"            iniset $IRONIC_CONF_FILE glance swift_temp_url_key $SWIFT_TEMPURL_KEY"},{"line_number":409,"context_line":"        else"},{"line_number":410,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":411,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":412,"context_line":"                        \"set to some agent_* driver OR configuration of \" \\"},{"line_number":413,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6ed579_2da0fa9e","line":410,"updated":"2016-01-13 11:47:42.000000000","message":"But it is not the case when you just want to configure glance, right? Maybe it should be smth like:\n\n if is_deployed_by_agent and swift_enable_tempurls:\n   iniset ...\n else:\n   die ...\n\n(I\u0027m not good at bash, just to explain what I mean :))\n\nOr even better, move L425-427 block higher than L406 and add this check there.","commit_id":"d07a6c4882c094ebfc5a6c7a2ca5e031d9795238"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"e540041d40b903206155b0839c4c7ed2898a294d","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        if [[ \"$SWIFT_ENABLE_TEMPURLS\" \u003d\u003d \"True\" ]] ; then"},{"line_number":408,"context_line":"            iniset $IRONIC_CONF_FILE glance swift_temp_url_key $SWIFT_TEMPURL_KEY"},{"line_number":409,"context_line":"        else"},{"line_number":410,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":411,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":412,"context_line":"                        \"set to some agent_* driver OR configuration of \" \\"},{"line_number":413,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6ed579_f33e0d8b","line":410,"in_reply_to":"da6ed579_2da0fa9e","updated":"2016-01-14 09:02:21.000000000","message":"is_glance_configuration_required() takes care of is_deployed_by_agent() and \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\" both.We want the glance to be configured when either of above is true and \"SWIFT_ENABLE_TEMPURLS\" is set to true. \n\nDoes this explain what i meant to do here?\nActually i dont understand what you see wrong in the suggested code.","commit_id":"d07a6c4882c094ebfc5a6c7a2ca5e031d9795238"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6a3789acec1507685c871c7cc2450e9294583f2c","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        if [[ \"$SWIFT_ENABLE_TEMPURLS\" \u003d\u003d \"True\" ]] ; then"},{"line_number":408,"context_line":"            iniset $IRONIC_CONF_FILE glance swift_temp_url_key $SWIFT_TEMPURL_KEY"},{"line_number":409,"context_line":"        else"},{"line_number":410,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":411,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":412,"context_line":"                        \"set to some agent_* driver OR configuration of \" \\"},{"line_number":413,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da6ed579_3fd1c423","line":410,"in_reply_to":"da6ed579_f33e0d8b","updated":"2016-01-14 10:16:59.000000000","message":"Yep, I must have missed the comment above the newly created variable. Do you mean the case with iscsi_ilo driver when boot_iso is uploaded to swift? If so, it would be nice to clarify this in the commit message.","commit_id":"d07a6c4882c094ebfc5a6c7a2ca5e031d9795238"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6f9768db30951f3167a92208e2db48aad5307ab6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"}"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"function is_glance_configuration_required {"},{"line_number":188,"context_line":"    is_deployed_by_agent || [[ \"$IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":189,"context_line":"    return 1"},{"line_number":190,"context_line":"}"},{"line_number":191,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba63e191_5c6bcf1e","line":188,"range":{"start_line":188,"start_character":4,"end_line":188,"end_character":24},"updated":"2016-01-19 13:09:43.000000000","message":"This should also check for the iscsi_ilo driver as it requires swift, unless the user has opted to set it up for swiftless deploy, which is documented, but not a default.","commit_id":"177693ed03aa7343496e61a7fd86b307b717132d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a34ef4c87f7d9194b6af1acc0302929a7745185b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"}"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"function is_glance_configuration_required {"},{"line_number":188,"context_line":"    is_deployed_by_agent || [[ \"$IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\" \u003d\u003d \"True\" ]] \u0026\u0026 return 0"},{"line_number":189,"context_line":"    return 1"},{"line_number":190,"context_line":"}"},{"line_number":191,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a68dd71_7459768d","line":188,"range":{"start_line":188,"start_character":4,"end_line":188,"end_character":24},"in_reply_to":"ba63e191_5c6bcf1e","updated":"2016-01-25 05:29:52.000000000","message":"I didnt get Julia, how is it particular about a driver here? Even the iscsi_ilo driver supports the agent ramdisk so this check is true for iscsi_ilo drivers also by default. Am i missing something or understanding something wrong?","commit_id":"177693ed03aa7343496e61a7fd86b307b717132d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6f9768db30951f3167a92208e2db48aad5307ab6","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        else"},{"line_number":392,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":393,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":394,"context_line":"                        \"set to some agent_* driver OR configuration of \" \\"},{"line_number":395,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":396,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":397,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba63e191_796d8503","line":394,"range":{"start_line":394,"start_character":32,"end_line":394,"end_character":36},"updated":"2016-01-19 13:09:43.000000000","message":"nit: s/some/an/\n\nAdditionally, this should likely mention iscsi_ilo as driver that requires swift by default.","commit_id":"177693ed03aa7343496e61a7fd86b307b717132d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"a34ef4c87f7d9194b6af1acc0302929a7745185b","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        else"},{"line_number":392,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":393,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":394,"context_line":"                        \"set to some agent_* driver OR configuration of \" \\"},{"line_number":395,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":396,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":397,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a68dd71_f41fa6b4","line":394,"range":{"start_line":394,"start_character":32,"end_line":394,"end_character":36},"in_reply_to":"ba63e191_796d8503","updated":"2016-01-25 05:29:52.000000000","message":"+1 to what Julia said.","commit_id":"177693ed03aa7343496e61a7fd86b307b717132d"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"7b0ec7777031ae90f35a278a9d5c51c4d5b0be60","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        else"},{"line_number":392,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":393,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":394,"context_line":"                        \"set to some agent_* driver OR configuration of \" \\"},{"line_number":395,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":396,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":397,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7a5de9d1_fe76373d","line":394,"range":{"start_line":394,"start_character":32,"end_line":394,"end_character":36},"in_reply_to":"ba63e191_796d8503","updated":"2016-02-23 08:52:03.000000000","message":"Done","commit_id":"177693ed03aa7343496e61a7fd86b307b717132d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e0c46ba569e884c2484b3f52dd42ff38626a47f7","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        else"},{"line_number":414,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":415,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":416,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":417,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":418,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":419,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5aef4532_105d1147","line":416,"updated":"2016-03-09 19:00:18.000000000","message":"This \"OR iscsi_ilo\" bit seems to be confusing, as setting driver to iscsi_ilo will not make is_glance_configuration_required to return true. \"... IRONIC_DEPLOY_DRIVER was set to some agent_* driver OR configuration of Glance with Swift was explicitly requested ...\" seems to be more precise description of what happens. Or maybe it was meant to check if the driver is iscsi_ilo, set IRONIC_CONFIGURE_GLANCE_WITH_SWIFT to true? If so, it does not happen.\n\nAlso, people keep wondering why this is needed, so it might be worth adding to commit message something like \"Some drivers require glance with swift backend to be able to store some deployment artifacts, e.g. in case of iscsi_ilo driver it may be delpoy_iso that is constructed from deploy_kernel and deploy_ramdisk. This requires some configuration and this change is intended for such drivers.\"","commit_id":"9ae2636e31e43cfebd1308bb353f457a3ac5d3cc"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5785e1eadbad695e0064496cef07c4ab1d13eaee","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        else"},{"line_number":414,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":415,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":416,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":417,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":418,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":419,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5aef4532_68827dc9","line":416,"in_reply_to":"5aef4532_105d1147","updated":"2016-03-10 13:18:43.000000000","message":"Sorry, after looking to ilo code, I meant boot_iso instead of deploy_iso here.","commit_id":"9ae2636e31e43cfebd1308bb353f457a3ac5d3cc"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"e3eb26dbbb5401f04934fbb202e1001efefcb681","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        else"},{"line_number":414,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":415,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":416,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":417,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":418,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":419,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3afc51ec_12809cbf","line":416,"in_reply_to":"5aef4532_105d1147","updated":"2016-03-15 06:44:45.000000000","message":"This is required for both agent_ilo and iscsi_ilo.","commit_id":"9ae2636e31e43cfebd1308bb353f457a3ac5d3cc"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"e3eb26dbbb5401f04934fbb202e1001efefcb681","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        else"},{"line_number":414,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":415,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":416,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":417,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":418,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":419,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3afc51ec_d24914b9","line":416,"in_reply_to":"5aef4532_68827dc9","updated":"2016-03-15 06:44:45.000000000","message":"thanks. modified the commit message","commit_id":"9ae2636e31e43cfebd1308bb353f457a3ac5d3cc"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"79b67a46f68f3263b1796f6b3b7997c727d02a45","unresolved":false,"context_lines":[{"line_number":188,"context_line":"IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA\u003d$(trueorfalse False IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# To explicitly enable configuration of Glance with Swift"},{"line_number":191,"context_line":"# (which is required by some vendor drivers ), set this"},{"line_number":192,"context_line":"# variable to true."},{"line_number":193,"context_line":"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003d$(trueorfalse False IRONIC_CONFIGURE_GLANCE_WITH_SWIFT)"},{"line_number":194,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bab6814e_962013b2","line":191,"updated":"2016-05-25 17:30:01.000000000","message":"Typo: remove the space before )","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8164b99915c926a777cec6bdfdf4331e6d769189","unresolved":false,"context_lines":[{"line_number":188,"context_line":"IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA\u003d$(trueorfalse False IRONIC_DEPLOY_DRIVER_ISCSI_WITH_IPA)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# To explicitly enable configuration of Glance with Swift"},{"line_number":191,"context_line":"# (which is required by some vendor drivers ), set this"},{"line_number":192,"context_line":"# variable to true."},{"line_number":193,"context_line":"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003d$(trueorfalse False IRONIC_CONFIGURE_GLANCE_WITH_SWIFT)"},{"line_number":194,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bab6814e_c3b2bbe4","line":191,"in_reply_to":"bab6814e_962013b2","updated":"2016-05-26 10:55:38.000000000","message":"Done","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e765e23a487459423a5f3fbd94a0f0fed96c126","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        else"},{"line_number":490,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":491,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":492,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":493,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":494,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":495,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bab6814e_8a05a3c3","line":492,"updated":"2016-05-25 11:23:18.000000000","message":"No need to mention iscsi_ilo here, as the choice is based on IRONIC_CONFIGURE_GLANCE_WITH_SWIFT variable, not the driver used.","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"8164b99915c926a777cec6bdfdf4331e6d769189","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        else"},{"line_number":490,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":491,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":492,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":493,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":494,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":495,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bab6814e_ad904844","line":492,"in_reply_to":"bab6814e_8a05a3c3","updated":"2016-05-26 10:55:38.000000000","message":"Hi, added this as per Julia\u0027s comments on patch set 2. \nAre you sure this is not required ?","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"067abc1d88ba39c0ba43f93c3af357802b76dc2d","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        else"},{"line_number":490,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":491,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":492,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":493,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":494,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":495,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bab6814e_de3e108a","line":492,"in_reply_to":"bab6814e_ad904844","updated":"2016-05-26 11:02:18.000000000","message":"So, you don\u0027t actually check what driver is requested anywhere, that what was suggested by Julia IIUC. If you think only setting IRONIC_CONFIGURE_GLANCE_WITH_SWIFT is enough, iscsi_ilo should be removed. If you want to special case iscsi_ilo, you can change is_glance_configuration_required to also add something like\n\n ... || driver \u003d\u003d \"iscsi_ilo\"\n\nthen, mentioning it explicitly in the message would make sense.","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":19722,"name":"Vaishnavi","email":"itsvaishnavi@gmail.com","username":"Vaishnavi"},"change_message_id":"6aaf23fc4075c52c74c190bd89f8ef5a420d0f95","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        else"},{"line_number":490,"context_line":"            die $LINENO \"SWIFT_ENABLE_TEMPURLS must be True. This is \" \\"},{"line_number":491,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":492,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":493,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":494,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":495,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9abb7d3a_b89dc2bd","line":492,"in_reply_to":"bab6814e_de3e108a","updated":"2016-06-02 06:48:36.000000000","message":"Thanks. modified.","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"79b67a46f68f3263b1796f6b3b7997c727d02a45","unresolved":false,"context_lines":[{"line_number":491,"context_line":"                        \"required either because IRONIC_DEPLOY_DRIVER was \" \\"},{"line_number":492,"context_line":"                        \"set to some agent_* driver OR iscsi_ilo driver OR configuration of \" \\"},{"line_number":493,"context_line":"                        \"Glance with Swift was explicitly requested with \" \\"},{"line_number":494,"context_line":"                        \"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003dTrue\""},{"line_number":495,"context_line":"        fi"},{"line_number":496,"context_line":"        iniset $IRONIC_CONF_FILE glance swift_endpoint_url http://${HOST_IP}:${SWIFT_DEFAULT_BIND_PORT:-8080}"},{"line_number":497,"context_line":"        iniset $IRONIC_CONF_FILE glance swift_api_version v1"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bab6814e_f62fdf9e","line":494,"updated":"2016-05-25 17:30:01.000000000","message":"You can easily find out which of these three problems has occurred - make operators\u0027 lives easier, and tell them the cause of the error in the error message!","commit_id":"f3a4d70a384201e9e7415352073d76435c46a3e2"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1f921e42bd400d7895df2d58d0768ec1c4dbe104","unresolved":false,"context_lines":[{"line_number":207,"context_line":"IRONIC_VBMC_LOGFILE\u003d${IRONIC_VBMC_LOGFILE:-$IRONIC_VM_LOG_DIR/virtualbmc.log}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# To explicitly enable configuration of Glance with Swift"},{"line_number":210,"context_line":"# (which is required by some vendor drivers), set this"},{"line_number":211,"context_line":"# variable to true."},{"line_number":212,"context_line":"IRONIC_CONFIGURE_GLANCE_WITH_SWIFT\u003d$(trueorfalse False IRONIC_CONFIGURE_GLANCE_WITH_SWIFT)"},{"line_number":213,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7aa08908_d1b86678","line":210,"range":{"start_line":210,"start_character":24,"end_line":210,"end_character":43},"updated":"2016-06-15 07:41:11.000000000","message":"nit: it would be better to add example of \u0027some vendor drivers\u0027 such as \u0027iscsi_ilo\u0027, because user usually doesn\u0027t see the commit message.","commit_id":"65343d8b0335e0c8926e1ed981e02ea168dc48d7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4750c9c171fe0cdcd7b2de581145636fffc9456c","unresolved":false,"context_lines":[{"line_number":557,"context_line":"    fi"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    # Set these options for scenarios in which the agent fetches the image"},{"line_number":560,"context_line":"    # directly from glance, and don\u0027t set them where the image is pushed"},{"line_number":561,"context_line":"    # over iSCSI."},{"line_number":562,"context_line":"    if is_glance_configuration_required; then"},{"line_number":563,"context_line":"        if [[ \"$SWIFT_ENABLE_TEMPURLS\" \u003d\u003d \"True\" ]] ; then"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"1aa78d24_98ca066d","line":560,"updated":"2016-07-05 20:00:45.000000000","message":"Does this need to be updated?","commit_id":"a48cabd0d63baa8c49f599005b794ada4a7ab871"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e7b530b380357a8f0db5ee0da1553075804ddac6","unresolved":false,"context_lines":[{"line_number":557,"context_line":"    fi"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    # Set these options for scenarios in which the agent fetches the image"},{"line_number":560,"context_line":"    # directly from glance, and don\u0027t set them where the image is pushed"},{"line_number":561,"context_line":"    # over iSCSI."},{"line_number":562,"context_line":"    if is_glance_configuration_required; then"},{"line_number":563,"context_line":"        if [[ \"$SWIFT_ENABLE_TEMPURLS\" \u003d\u003d \"True\" ]] ; then"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"1aa78d24_c70c94ee","line":560,"in_reply_to":"1aa78d24_98ca066d","updated":"2016-07-12 03:34:10.000000000","message":"I am not sure what you are looking at to be updated here. Please suggest, i will update.","commit_id":"a48cabd0d63baa8c49f599005b794ada4a7ab871"}]}
