)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"167dbf219d27a5f1474a801fbef8ec5878d6da34","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_ba2847e3","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":27},"updated":"2016-01-24 04:54:08.000000000","message":"Tescase required for his case.","commit_id":"4c89ddcea3c87a7772e55ea27158c057bc34eb97"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0e6f179d011343d3df106921ef8e222e516c21d8","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_9a3207a6","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":27},"in_reply_to":"9a68dd71_6140d534","updated":"2016-01-25 11:03:34.000000000","message":"++","commit_id":"4c89ddcea3c87a7772e55ea27158c057bc34eb97"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"a5f97f3771725739d1319952c53638a4d3604c0e","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6140d534","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":27},"in_reply_to":"9a68dd71_ba2847e3","updated":"2016-01-25 08:20:42.000000000","message":"Agree, a new test case is needed.","commit_id":"4c89ddcea3c87a7772e55ea27158c057bc34eb97"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"dd4c6e1d2bc596d64b056557e351842f04f2a14c","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_890492c0","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":28},"updated":"2016-01-28 14:52:49.000000000","message":"I don\u0027t think this check is necessary, as _check_name_acceptable() will check the empty name, see L953.","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"f3292a162508fa76004a753bbe9b4122fa1b8745","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_5271ec74","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":28},"in_reply_to":"7a5de9d1_0004d047","updated":"2016-02-01 09:19:58.000000000","message":"Thanks Zhenguo. I am a little confused about changing to \u0027if not name\u0027. If so, when updating a node name instead of removing, here the \u0027name\u0027 is an not None parameter, the \u0027not name\u0027 check will pass the \u0027_check_name_acceptable\u0027, which really should be called to check whether the updated name is acceptable.\n\nBesides, I am cool to change this check back and make the corresponding change in test case too, to see whether there are some other comments. WDYT?","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"21fbe1dc7d5b953766be87371ce9e6e103709d76","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_0004d047","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":28},"in_reply_to":"7a5de9d1_007e1019","updated":"2016-01-29 03:41:40.000000000","message":"if so, why not change it to \u0027if not name\u0027 to cover more cases? and add the same check before _check_name_acceptable() everywhere.","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"8a9c65429b9a9e4ee911c737f9714c8e7c0c731c","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_989b0566","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":28},"in_reply_to":"7a5de9d1_5271ec74","updated":"2016-02-01 10:01:53.000000000","message":"hi Kan, I mean the check in _check_name_acceptable() is \u0027if name\u0027 instead of \u0027if name is not None\u0027, so if you want to add check here, it\u0027s better to sync with that. \u0027not name\u0027 will not be checked at all.","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"20e81f4810938f13db17d832138c66deb2e90b78","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_007e1019","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":28},"in_reply_to":"7a5de9d1_890492c0","updated":"2016-01-29 03:25:38.000000000","message":"Thanks Zhenguo. I got a comment from Tan then to add this check, please refer to the comment history.\n\nTo me the check here can prevent \u0027_check_name_acceptable\u0027 be called, which is easier to understand in logic, as well as avoid generating the error_msg.\n@Zhenguo @Tan WDYT?","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"6e48c937bc908647bb12215c670df5d5ddc33eea","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                msg % node_ident, status_code\u003dhttp_client.CONFLICT)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"        name \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)"},{"line_number":1181,"context_line":"        if name is not None:"},{"line_number":1182,"context_line":"            error_msg \u003d _(\"Node %(node)s: Cannot change name to invalid \""},{"line_number":1183,"context_line":"                          \"name \u0027%(name)s\u0027\") % {\u0027node\u0027: node_ident,"},{"line_number":1184,"context_line":"                                                \u0027name\u0027: name}"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_b334e2fb","line":1181,"range":{"start_line":1181,"start_character":8,"end_line":1181,"end_character":28},"in_reply_to":"7a5de9d1_989b0566","updated":"2016-02-01 10:33:18.000000000","message":"Sure, will make a new patch to address that. Thanks Zhenguo.","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"5cb04334daa1233d6f645a647e29defb73269eee","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"            #             one that doesn\u0027t exist."},{"line_number":1128,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1129,"context_line":"            raise e"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        error_msg \u003d _(\"Cannot create node with invalid name \""},{"line_number":1132,"context_line":"                      \"%(name)s\") % {\u0027name\u0027: node.name}"},{"line_number":1133,"context_line":"        if node.name:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_3ab89429","line":1130,"updated":"2016-02-02 05:53:18.000000000","message":"The error_msg is useless for other cases, better to add condition here:\nif node.name:\n   error_msg\n   self._check_name_acceptable()","commit_id":"0f6de1c53cbacd94e0abcb7881421ff818465f80"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"cd1e1e442c39b14130b4fdff78c93909737dc275","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"            #             one that doesn\u0027t exist."},{"line_number":1128,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1129,"context_line":"            raise e"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        error_msg \u003d _(\"Cannot create node with invalid name \""},{"line_number":1132,"context_line":"                      \"%(name)s\") % {\u0027name\u0027: node.name}"},{"line_number":1133,"context_line":"        if node.name:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_0d532018","line":1130,"in_reply_to":"7a5de9d1_3ab89429","updated":"2016-02-02 06:20:58.000000000","message":"My bad. Thanks Tan.","commit_id":"0f6de1c53cbacd94e0abcb7881421ff818465f80"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"98c32a1a28bab0e07bded44abcd2b5ed40485585","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1129,"context_line":"            raise e"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        if node.name:"},{"line_number":1132,"context_line":"            error_msg \u003d _(\"Cannot create node with invalid name \""},{"line_number":1133,"context_line":"                          \"%(name)s\") % {\u0027name\u0027: node.name}"},{"line_number":1134,"context_line":"            self._check_name_acceptable(node.name, error_msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_fb9d020b","line":1131,"updated":"2016-02-02 15:45:59.000000000","message":"There already is a check in self._check_name_acceptable so I think there is no need to add it here.","commit_id":"6c981b5d2dde825c117605d75e9538b6cd26cde8"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"d63eabf78a6b5d6c9c929ea7ccc642102a534ddb","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1129,"context_line":"            raise e"},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"        if node.name:"},{"line_number":1132,"context_line":"            error_msg \u003d _(\"Cannot create node with invalid name \""},{"line_number":1133,"context_line":"                          \"%(name)s\") % {\u0027name\u0027: node.name}"},{"line_number":1134,"context_line":"            self._check_name_acceptable(node.name, error_msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_e4c6cf15","line":1131,"in_reply_to":"7a5de9d1_fb9d020b","updated":"2016-02-03 05:35:19.000000000","message":"Thanks Vladyslav. I got comments then to add this check to keep consistency, please refer to the comment history.\nThe check here can prevent \u0027_check_name_acceptable\u0027 be called, which is easier to understand in logic, as well as avoid generating the error_msg. WDYT?","commit_id":"6c981b5d2dde825c117605d75e9538b6cd26cde8"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"23ea49f654e7662951f67597b0e379c5265885af","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def get_patch_value(patch, path):"},{"line_number":70,"context_line":"    for p in patch:"},{"line_number":71,"context_line":"        if p[\u0027path\u0027] \u003d\u003d path and p[\u0027op\u0027] !\u003d \u0027remove\u0027:"},{"line_number":72,"context_line":"            return p[\u0027value\u0027]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_d9d7d121","line":71,"updated":"2016-01-18 07:17:21.000000000","message":"Since this will return None as new name for your purpose, so there is no need to check name acceptable again. I would suggest you to do things in ironic/api/controllers/v1/node.py:L1180:\n\nname \u003d api_utils.get_patch_value(patch, \u0027/name\u0027)\nif name is not None:\n  err_msg \u003d ...\n  self.check_name_acceptable(name, error_msg)\ntry:\n  ...","commit_id":"ca24653a914593d5e5017da2e932d62f757bad0d"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"9abfc013886a065c44377a542b70ede38ebc60cd","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def get_patch_value(patch, path):"},{"line_number":70,"context_line":"    for p in patch:"},{"line_number":71,"context_line":"        if p[\u0027path\u0027] \u003d\u003d path and p[\u0027op\u0027] !\u003d \u0027remove\u0027:"},{"line_number":72,"context_line":"            return p[\u0027value\u0027]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_075f400f","line":71,"in_reply_to":"da6ed579_d9d7d121","updated":"2016-01-18 07:56:58.000000000","message":"Thanks Tan, will address a new patch soon.","commit_id":"ca24653a914593d5e5017da2e932d62f757bad0d"}],"ironic/tests/unit/api/v1/test_nodes.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f65de98a02158bdb71b2b6d93886bfa3cdad4d8f","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"                                     \u0027op\u0027: \u0027remove\u0027}],"},{"line_number":1284,"context_line":"                                   headers\u003d{api_base.Version.string: \"1.5\"})"},{"line_number":1285,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":1286,"context_line":"        self.assertEqual(http_client.OK, response.status_code)"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"    @mock.patch.object(api_utils, \u0027get_rpc_node\u0027)"},{"line_number":1289,"context_line":"    def test_patch_update_drive_console_enabled(self, mock_rpc_node):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_f21663f0","line":1286,"range":{"start_line":1286,"start_character":13,"end_line":1286,"end_character":24},"updated":"2016-01-27 05:29:32.000000000","message":"better to add mock for _check_name_acceptable()\nself.assertFalse(mock_check_name_acceptable.called)","commit_id":"e8e43a7a962ab0459185682981e1b7d0d54764af"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"d03b187148d084f56355af743565085acc3448eb","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"                                     \u0027op\u0027: \u0027remove\u0027}],"},{"line_number":1284,"context_line":"                                   headers\u003d{api_base.Version.string: \"1.5\"})"},{"line_number":1285,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":1286,"context_line":"        self.assertEqual(http_client.OK, response.status_code)"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"    @mock.patch.object(api_utils, \u0027get_rpc_node\u0027)"},{"line_number":1289,"context_line":"    def test_patch_update_drive_console_enabled(self, mock_rpc_node):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_efdf5938","line":1286,"range":{"start_line":1286,"start_character":13,"end_line":1286,"end_character":24},"in_reply_to":"9a68dd71_f21663f0","updated":"2016-01-27 07:51:54.000000000","message":"Thanks, will address a new patch.","commit_id":"e8e43a7a962ab0459185682981e1b7d0d54764af"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"625db1598d5f0620389fed9bf1f198355a8f47a0","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":1276,"context_line":"        self.assertEqual(http_client.CONFLICT, response.status_code)"},{"line_number":1277,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    def test_patch_name_remove_ok(self):"},{"line_number":1280,"context_line":"        self.mock_update_node.return_value \u003d self.node"},{"line_number":1281,"context_line":"        with mock.patch.object(api_node.NodesController,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_e93194ed","line":1278,"updated":"2016-01-28 11:02:36.000000000","message":"(just update it if you happen to submit a new patch set)\n\nnit, use the mock decorator to avoid indentation and be more consistent with other mocks in the file:\n\n @mock.patch.object(api_node.NodesController, \u0027_check_name_acceptable\u0027)\n def test_patch_name_remove_ok(self, cna_mock):\n     ...","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"20e81f4810938f13db17d832138c66deb2e90b78","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":1276,"context_line":"        self.assertEqual(http_client.CONFLICT, response.status_code)"},{"line_number":1277,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    def test_patch_name_remove_ok(self):"},{"line_number":1280,"context_line":"        self.mock_update_node.return_value \u003d self.node"},{"line_number":1281,"context_line":"        with mock.patch.object(api_node.NodesController,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_a0305c9f","line":1278,"in_reply_to":"7a5de9d1_e93194ed","updated":"2016-01-29 03:25:38.000000000","message":"Thanks Lucas, will address in the next patch.","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"}],"releasenotes/notes/node-name-remove-720aa8007f2f8b75.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"625db1598d5f0620389fed9bf1f198355a8f47a0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fixes bug to make up the function of"},{"line_number":4,"context_line":"    remove node name, which is an optional"},{"line_number":5,"context_line":"    property and should be removable"},{"line_number":6,"context_line":"    (set back to None)."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a5de9d1_69cfe4b0","line":6,"updated":"2016-01-28 11:02:36.000000000","message":"This reads very confusing. I\u0027m not a native english speaker but what about:\n\n\"Fixes an issue that prevented the node name to be removed as part of the node update.\"","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"20e81f4810938f13db17d832138c66deb2e90b78","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fixes bug to make up the function of"},{"line_number":4,"context_line":"    remove node name, which is an optional"},{"line_number":5,"context_line":"    property and should be removable"},{"line_number":6,"context_line":"    (set back to None)."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a5de9d1_602a642e","line":6,"in_reply_to":"7a5de9d1_69cfe4b0","updated":"2016-01-29 03:25:38.000000000","message":"Thanks Lucas, will follow your suggestion in the next patch.","commit_id":"bf16c04ee4f2fe2ac03c883cc8d4a5cc83a8f4d1"}]}
