)]}'
{"ironic/tests/unit/objects/test_node.py":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"4efeedd88bddd8298dab3743bffbfef8f878a8eb","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"            mock_get_node.assert_called_once_with(node_name)"},{"line_number":67,"context_line":"            self.assertEqual(self.context, node._context)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_save(self):"},{"line_number":70,"context_line":"        uuid \u003d self.fake_node[\u0027uuid\u0027]"},{"line_number":71,"context_line":"        with mock.patch.object(self.dbapi, \u0027get_node_by_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_68dcc946","line":68,"updated":"2016-01-18 09:18:09.000000000","message":"nit:better to add a negative test to return NodeNotFound like test_get_by_name_node_not_found","commit_id":"a91a4a1a52210eb9f804569fb1e67e8a517da320"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"390f30a2050ec93d36288d5c10579f5a0ecc5771","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                               autospec\u003dTrue) as mock_get_node:"},{"line_number":72,"context_line":"            node_name \u003d \u0027non-existent\u0027"},{"line_number":73,"context_line":"            mock_get_node.side_effect \u003d iter("},{"line_number":74,"context_line":"                [exception.NodeNotFound(node\u003dnode_name)])"},{"line_number":75,"context_line":"            self.assertRaises(exception.NodeNotFound,"},{"line_number":76,"context_line":"                              objects.Node.get_by_name, self.context,"},{"line_number":77,"context_line":"                              node_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_a9e24c2d","line":74,"updated":"2016-06-03 09:20:38.000000000","message":"this iter() thing is no longer needed, you can just put an exception there","commit_id":"aa104fbc871dcc4519b18e992c19d79ff7c2841e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"312e7f35420511787134b1d35cd8d0483eaf4f36","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                               autospec\u003dTrue) as mock_get_node:"},{"line_number":72,"context_line":"            node_name \u003d \u0027non-existent\u0027"},{"line_number":73,"context_line":"            mock_get_node.side_effect \u003d iter("},{"line_number":74,"context_line":"                [exception.NodeNotFound(node\u003dnode_name)])"},{"line_number":75,"context_line":"            self.assertRaises(exception.NodeNotFound,"},{"line_number":76,"context_line":"                              objects.Node.get_by_name, self.context,"},{"line_number":77,"context_line":"                              node_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_445bc7f6","line":74,"in_reply_to":"9abb7d3a_a9e24c2d","updated":"2016-06-03 09:40:06.000000000","message":"Done","commit_id":"aa104fbc871dcc4519b18e992c19d79ff7c2841e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"390f30a2050ec93d36288d5c10579f5a0ecc5771","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                               autospec\u003dTrue) as mock_get_node:"},{"line_number":93,"context_line":"            instance \u003d \u0027non-existent\u0027"},{"line_number":94,"context_line":"            mock_get_node.side_effect \u003d iter("},{"line_number":95,"context_line":"                [exception.InstanceNotFound(instance\u003dinstance)])"},{"line_number":96,"context_line":"            self.assertRaises(exception.InstanceNotFound,"},{"line_number":97,"context_line":"                              objects.Node.get_by_instance_uuid, self.context,"},{"line_number":98,"context_line":"                              instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_09d0b852","line":95,"updated":"2016-06-03 09:20:38.000000000","message":"ditto","commit_id":"aa104fbc871dcc4519b18e992c19d79ff7c2841e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"312e7f35420511787134b1d35cd8d0483eaf4f36","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                               autospec\u003dTrue) as mock_get_node:"},{"line_number":93,"context_line":"            instance \u003d \u0027non-existent\u0027"},{"line_number":94,"context_line":"            mock_get_node.side_effect \u003d iter("},{"line_number":95,"context_line":"                [exception.InstanceNotFound(instance\u003dinstance)])"},{"line_number":96,"context_line":"            self.assertRaises(exception.InstanceNotFound,"},{"line_number":97,"context_line":"                              objects.Node.get_by_instance_uuid, self.context,"},{"line_number":98,"context_line":"                              instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_e46c7b9e","line":95,"in_reply_to":"9abb7d3a_09d0b852","updated":"2016-06-03 09:40:06.000000000","message":"Done","commit_id":"aa104fbc871dcc4519b18e992c19d79ff7c2841e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2fc68a99af90b4c3ffc915434b04af99e0f57b6f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                               autospec\u003dTrue) as mock_get_node:"},{"line_number":98,"context_line":"            instance \u003d \u0027non-existent\u0027"},{"line_number":99,"context_line":"            mock_get_node.side_effect \u003d \\"},{"line_number":100,"context_line":"                exception.InstanceNotFound(instance\u003dinstance)"},{"line_number":101,"context_line":"            self.assertRaises(exception.InstanceNotFound,"},{"line_number":102,"context_line":"                              objects.Node.get_by_instance_uuid, self.context,"},{"line_number":103,"context_line":"                              instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_52a62fad","line":100,"updated":"2018-02-01 18:05:18.000000000","message":"nit: I\u0027d prefer brackets, not \\","commit_id":"927e2d3f569111d1630fd537316da58d38dae03a"}]}