)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e2bd6bf05382a04333c1a93768bd7b8dec8c2a3d","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"#use_web_server_for_images\u003dfalse"},{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"# DEPRECATED. This option is deprecated. Please use "},{"line_number":1160,"context_line":"# [deploy]erase_devices_priority instead."},{"line_number":1161,"context_line":"#"},{"line_number":1162,"context_line":"# Options defined in ironic.drivers.modules.ilo.deploy"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a68dd71_4424560c","line":1159,"updated":"2016-01-21 07:36:35.000000000","message":"extra space","commit_id":"8e8936dbec67b466503b3f2ad3a284889d35d3ef"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b09f461d076c0a52504947a0c02308f3cb367830","unresolved":false,"context_lines":[{"line_number":1157,"context_line":""},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"# DEPRECATED. This option is deprecated. Please use "},{"line_number":1160,"context_line":"# [deploy]erase_devices_priority instead."},{"line_number":1161,"context_line":"#"},{"line_number":1162,"context_line":"# Options defined in ironic.drivers.modules.ilo.deploy"},{"line_number":1163,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a68dd71_b547701c","line":1160,"updated":"2016-01-21 12:01:20.000000000","message":"This file should not be changed manually, only with tox -egenconfig. You should use deprecated_for_removal\u003dTrue and deprecated_reason\u003d\u0027reason\u0027 when this option is being defined in ilo/deploy.py. See http://docs.openstack.org/developer/oslo.config/opts.html","commit_id":"8e8936dbec67b466503b3f2ad3a284889d35d3ef"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e2bd6bf05382a04333c1a93768bd7b8dec8c2a3d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"clean_opts \u003d ["},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027clean_priority_erase_devices\u0027,"},{"line_number":41,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":42,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"},{"line_number":43,"context_line":"                      \u0027disabled and will not run during cleaning.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_248a82c0","line":40,"updated":"2016-01-21 07:36:35.000000000","message":"1. you should add Deprecated notification here.\n2. This will break existing users\u0027s environment, better to keep back compatibility for this. And IMHO, a deprecated config should keep one or two releases for above reason.","commit_id":"8e8936dbec67b466503b3f2ad3a284889d35d3ef"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d627fb74f163207bdc554bd7dc3e2d99b59f7aed","unresolved":false,"context_lines":[{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"clean_opts \u003d ["},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027clean_priority_erase_devices\u0027,"},{"line_number":41,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":42,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"},{"line_number":43,"context_line":"                      \u0027disabled and will not run during cleaning.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_97eef989","line":40,"in_reply_to":"9a68dd71_248a82c0","updated":"2016-01-21 10:15:23.000000000","message":"+1","commit_id":"8e8936dbec67b466503b3f2ad3a284889d35d3ef"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d627fb74f163207bdc554bd7dc3e2d99b59f7aed","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        \"\"\""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        new_priorities \u003d {"},{"line_number":220,"context_line":"            \u0027erase_devices\u0027: CONF.deploy.erase_devices_priority,"},{"line_number":221,"context_line":"        }"},{"line_number":222,"context_line":"        return deploy_utils.agent_get_clean_steps("},{"line_number":223,"context_line":"            task, interface\u003d\u0027deploy\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_922b67eb","line":220,"range":{"start_line":220,"start_character":34,"end_line":220,"end_character":40},"updated":"2016-01-21 10:15:23.000000000","message":"Need to update testcases.\nhttps://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/ilo/test_deploy.py#L368-L400","commit_id":"8e8936dbec67b466503b3f2ad3a284889d35d3ef"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b09f461d076c0a52504947a0c02308f3cb367830","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        \"\"\""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        new_priorities \u003d {"},{"line_number":220,"context_line":"            \u0027erase_devices\u0027: CONF.deploy.erase_devices_priority,"},{"line_number":221,"context_line":"        }"},{"line_number":222,"context_line":"        return deploy_utils.agent_get_clean_steps("},{"line_number":223,"context_line":"            task, interface\u003d\u0027deploy\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_55c5d439","line":220,"range":{"start_line":220,"start_character":34,"end_line":220,"end_character":40},"in_reply_to":"9a68dd71_922b67eb","updated":"2016-01-21 12:01:20.000000000","message":"It\u0027d be better to do\n\n \u0027erase_devices\u0027: CONF.ilo.clean_priority_erase_devices or CONF.deploy.erase_devices_priority\n\nwhile the old option is not removed completely.","commit_id":"8e8936dbec67b466503b3f2ad3a284889d35d3ef"}]}