)]}'
{"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ad2e0a90ce91506effb0ed1e4a4ed5eb658674d2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        # Powering off the Node before initiating boot for node cleaning."},{"line_number":188,"context_line":"        # If node is in system POST, setting boot device fails."},{"line_number":189,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":190,"context_line":"        super(IloVirtualMediaIscsiDeploy, self).prepare_cleaning(task)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"class IloVirtualMediaAgentDeploy(agent.AgentDeploy):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_343d6add","line":190,"updated":"2016-02-18 14:28:01.000000000","message":"prepare_cleaning() method should return a proper value, so \n\n return super(IloVirtualMediaIscsiDeploy, self).prepare_cleaning(task)","commit_id":"3de3aac6cbde1efff52e48c0446ab778dac43c18"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a26673786bd04ae93c85df63fb31a3fa20fc8bff","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        # Powering off the Node before initiating boot for node cleaning."},{"line_number":188,"context_line":"        # If node is in system POST, setting boot device fails."},{"line_number":189,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":190,"context_line":"        super(IloVirtualMediaIscsiDeploy, self).prepare_cleaning(task)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"class IloVirtualMediaAgentDeploy(agent.AgentDeploy):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_d6e7c244","line":190,"in_reply_to":"dae33548_343d6add","updated":"2016-02-19 04:51:56.000000000","message":"Done","commit_id":"3de3aac6cbde1efff52e48c0446ab778dac43c18"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ad2e0a90ce91506effb0ed1e4a4ed5eb658674d2","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        # Powering off the Node before initiating boot for node cleaning."},{"line_number":236,"context_line":"        # If node is in system POST, setting boot device fails."},{"line_number":237,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":238,"context_line":"        super(IloVirtualMediaAgentDeploy, self).prepare_cleaning(task)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def get_clean_steps(self, task):"},{"line_number":241,"context_line":"        \"\"\"Get the list of clean steps from the agent."}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_3f0b8325","line":238,"updated":"2016-02-18 14:28:01.000000000","message":"ditto","commit_id":"3de3aac6cbde1efff52e48c0446ab778dac43c18"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a26673786bd04ae93c85df63fb31a3fa20fc8bff","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        # Powering off the Node before initiating boot for node cleaning."},{"line_number":236,"context_line":"        # If node is in system POST, setting boot device fails."},{"line_number":237,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":238,"context_line":"        super(IloVirtualMediaAgentDeploy, self).prepare_cleaning(task)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def get_clean_steps(self, task):"},{"line_number":241,"context_line":"        \"\"\"Get the list of clean steps from the agent."}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_b6ecbe2a","line":238,"in_reply_to":"dae33548_3f0b8325","updated":"2016-02-19 04:51:56.000000000","message":"Done","commit_id":"3de3aac6cbde1efff52e48c0446ab778dac43c18"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ad2e0a90ce91506effb0ed1e4a4ed5eb658674d2","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        # Powering off the Node before initiating boot for node cleaning."},{"line_number":325,"context_line":"        # If node is in system POST, setting boot device fails."},{"line_number":326,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":327,"context_line":"        super(IloPXEDeploy, self).prepare_cleaning(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_1f295f8a","line":327,"updated":"2016-02-18 14:28:01.000000000","message":"ditto","commit_id":"3de3aac6cbde1efff52e48c0446ab778dac43c18"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a26673786bd04ae93c85df63fb31a3fa20fc8bff","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        # Powering off the Node before initiating boot for node cleaning."},{"line_number":325,"context_line":"        # If node is in system POST, setting boot device fails."},{"line_number":326,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":327,"context_line":"        super(IloPXEDeploy, self).prepare_cleaning(task)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_16f2ca06","line":327,"in_reply_to":"dae33548_1f295f8a","updated":"2016-02-19 04:51:56.000000000","message":"Done","commit_id":"3de3aac6cbde1efff52e48c0446ab778dac43c18"}],"ironic/tests/unit/drivers/modules/ilo/test_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"40852fa6dd7805073ba6fc57918281e309ef0b7b","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            self.assertFalse(func_prepare_node_for_deploy.called)"},{"line_number":284,"context_line":"            iscsi_deploy_prepare_mock.assert_called_once_with(mock.ANY, task)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @mock.patch.object(iscsi_deploy.ISCSIDeploy, \u0027prepare_cleaning\u0027,"},{"line_number":287,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":288,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, spec_set\u003dTrue,"},{"line_number":289,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_3e92e29e","line":286,"updated":"2016-02-22 11:35:55.000000000","message":"Ideally, you would need to ensure that a node was not powered on in the whole chain of function calls after power off, but I guess it would overcomplicate the test, so maybe that\u0027s fine.","commit_id":"f297a8896acc09e94d8704fd4c4d843e6330f424"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"564dcea98cbb0459e841ee5527bc7d91df0709df","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            self.assertFalse(func_prepare_node_for_deploy.called)"},{"line_number":284,"context_line":"            iscsi_deploy_prepare_mock.assert_called_once_with(mock.ANY, task)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @mock.patch.object(iscsi_deploy.ISCSIDeploy, \u0027prepare_cleaning\u0027,"},{"line_number":287,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":288,"context_line":"    @mock.patch.object(manager_utils, \u0027node_power_action\u0027, spec_set\u003dTrue,"},{"line_number":289,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_346e8195","line":286,"in_reply_to":"bae84128_3e92e29e","updated":"2016-02-22 15:04:22.000000000","message":"Yes, but it would complicate the testcase.","commit_id":"f297a8896acc09e94d8704fd4c4d843e6330f424"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"40852fa6dd7805073ba6fc57918281e309ef0b7b","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                       autospec\u003dTrue)"},{"line_number":290,"context_line":"    def test_prepare_cleaning(self, node_power_action_mock,"},{"line_number":291,"context_line":"                              iscsi_prep_clean_mock):"},{"line_number":292,"context_line":"        self.node.save()"},{"line_number":293,"context_line":"        iscsi_prep_clean_mock.return_value \u003d states.CLEANWAIT"},{"line_number":294,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":295,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_de0f762c","line":292,"updated":"2016-02-22 11:35:55.000000000","message":"not needed.","commit_id":"f297a8896acc09e94d8704fd4c4d843e6330f424"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"564dcea98cbb0459e841ee5527bc7d91df0709df","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                       autospec\u003dTrue)"},{"line_number":290,"context_line":"    def test_prepare_cleaning(self, node_power_action_mock,"},{"line_number":291,"context_line":"                              iscsi_prep_clean_mock):"},{"line_number":292,"context_line":"        self.node.save()"},{"line_number":293,"context_line":"        iscsi_prep_clean_mock.return_value \u003d states.CLEANWAIT"},{"line_number":294,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":295,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_b410d102","line":292,"in_reply_to":"bae84128_de0f762c","updated":"2016-02-22 15:04:22.000000000","message":"Done","commit_id":"f297a8896acc09e94d8704fd4c4d843e6330f424"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"40852fa6dd7805073ba6fc57918281e309ef0b7b","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                       autospec\u003dTrue)"},{"line_number":438,"context_line":"    def test_prepare_cleaning(self, node_power_action_mock,"},{"line_number":439,"context_line":"                              agent_prep_clean_mock):"},{"line_number":440,"context_line":"        self.node.save()"},{"line_number":441,"context_line":"        agent_prep_clean_mock.return_value \u003d states.CLEANWAIT"},{"line_number":442,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":443,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_7e274ab6","line":440,"updated":"2016-02-22 11:35:55.000000000","message":"not needed.","commit_id":"f297a8896acc09e94d8704fd4c4d843e6330f424"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"564dcea98cbb0459e841ee5527bc7d91df0709df","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                       autospec\u003dTrue)"},{"line_number":438,"context_line":"    def test_prepare_cleaning(self, node_power_action_mock,"},{"line_number":439,"context_line":"                              agent_prep_clean_mock):"},{"line_number":440,"context_line":"        self.node.save()"},{"line_number":441,"context_line":"        agent_prep_clean_mock.return_value \u003d states.CLEANWAIT"},{"line_number":442,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":443,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_f4fa59bc","line":440,"in_reply_to":"bae84128_7e274ab6","updated":"2016-02-22 15:04:22.000000000","message":"Done","commit_id":"f297a8896acc09e94d8704fd4c4d843e6330f424"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"40852fa6dd7805073ba6fc57918281e309ef0b7b","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                       autospec\u003dTrue)"},{"line_number":571,"context_line":"    def test_prepare_cleaning(self, node_power_action_mock,"},{"line_number":572,"context_line":"                              iscsi_prep_clean_mock):"},{"line_number":573,"context_line":"        self.node.save()"},{"line_number":574,"context_line":"        iscsi_prep_clean_mock.return_value \u003d states.CLEANWAIT"},{"line_number":575,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":576,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_5e2a467f","line":573,"updated":"2016-02-22 11:35:55.000000000","message":"not needed.","commit_id":"f297a8896acc09e94d8704fd4c4d843e6330f424"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"564dcea98cbb0459e841ee5527bc7d91df0709df","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                       autospec\u003dTrue)"},{"line_number":571,"context_line":"    def test_prepare_cleaning(self, node_power_action_mock,"},{"line_number":572,"context_line":"                              iscsi_prep_clean_mock):"},{"line_number":573,"context_line":"        self.node.save()"},{"line_number":574,"context_line":"        iscsi_prep_clean_mock.return_value \u003d states.CLEANWAIT"},{"line_number":575,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":576,"context_line":"                                  shared\u003dFalse) as task:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_3405e1bb","line":573,"in_reply_to":"bae84128_5e2a467f","updated":"2016-02-22 15:04:22.000000000","message":"Done","commit_id":"f297a8896acc09e94d8704fd4c4d843e6330f424"}],"releasenotes/notes/ilo-automated-cleaning-fails-14ee438de3dd8690.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"44979596fea08298cb7dc51c5e939f4d9d1dba3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes issue where automated cleaning fails for iLO"},{"line_number":4,"context_line":"    drivers. "},{"line_number":5,"context_line":"    Automated cleaning fails for iLO driver if iLO is"},{"line_number":6,"context_line":"    in System POST state. iLO does not allow setting"},{"line_number":7,"context_line":"    of boot device when it is in System POST state."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a5de9d1_fd56e85a","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":13},"updated":"2016-01-29 13:57:23.000000000","message":"Nit: whitespace.","commit_id":"ecdc285b5f685d00abede22f769bbe7a1a016e4f"}]}
