)]}'
{"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"ab6fbc43846c91ef967bc1f79ab84236e0a80fd8","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                if count !\u003d 1:"},{"line_number":240,"context_line":"                    node \u003d query.one()"},{"line_number":241,"context_line":"                    if node[\u0027reservation\u0027] is None:"},{"line_number":242,"context_line":"                        raise exception.NodeNotLocked(node\u003dnode_id)"},{"line_number":243,"context_line":"                    else:"},{"line_number":244,"context_line":"                        raise exception.NodeLocked(node\u003dnode.uuid,"},{"line_number":245,"context_line":"                                                   host\u003dnode[\u0027reservation\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_55e71440","line":242,"range":{"start_line":242,"start_character":59,"end_line":242,"end_character":66},"updated":"2016-01-27 08:51:03.000000000","message":"Can you fix here also??","commit_id":"d1c65add5445ce8960c53502aae2e8da11849368"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"79e6e08d046743c55f22d8108fd70da255c3d9fe","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                if count !\u003d 1:"},{"line_number":240,"context_line":"                    node \u003d query.one()"},{"line_number":241,"context_line":"                    if node[\u0027reservation\u0027] is None:"},{"line_number":242,"context_line":"                        raise exception.NodeNotLocked(node\u003dnode_id)"},{"line_number":243,"context_line":"                    else:"},{"line_number":244,"context_line":"                        raise exception.NodeLocked(node\u003dnode.uuid,"},{"line_number":245,"context_line":"                                                   host\u003dnode[\u0027reservation\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_7ac59359","line":242,"range":{"start_line":242,"start_character":59,"end_line":242,"end_character":66},"in_reply_to":"7a5de9d1_636df531","updated":"2016-01-27 15:02:27.000000000","message":"+1","commit_id":"d1c65add5445ce8960c53502aae2e8da11849368"},{"author":{"_account_id":14923,"name":"Sinval Vieira Mendes Neto","email":"sinvalneto01@gmail.com","username":"sinvalvieira"},"change_message_id":"d6334c0f83cce2742144fd3d478494f3ca363d31","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                if count !\u003d 1:"},{"line_number":240,"context_line":"                    node \u003d query.one()"},{"line_number":241,"context_line":"                    if node[\u0027reservation\u0027] is None:"},{"line_number":242,"context_line":"                        raise exception.NodeNotLocked(node\u003dnode_id)"},{"line_number":243,"context_line":"                    else:"},{"line_number":244,"context_line":"                        raise exception.NodeLocked(node\u003dnode.uuid,"},{"line_number":245,"context_line":"                                                   host\u003dnode[\u0027reservation\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_636df531","line":242,"range":{"start_line":242,"start_character":59,"end_line":242,"end_character":66},"in_reply_to":"9a68dd71_55e71440","updated":"2016-01-27 13:03:34.000000000","message":"+1","commit_id":"d1c65add5445ce8960c53502aae2e8da11849368"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"cf3176134430580a9517c84755e5021524157c6a","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            elif \u0027instance_uuid\u0027 in e.columns:"},{"line_number":344,"context_line":"                raise exception.InstanceAssociated("},{"line_number":345,"context_line":"                    instance_uuid\u003dvalues[\u0027instance_uuid\u0027],"},{"line_number":346,"context_line":"                    node\u003dnode_id)"},{"line_number":347,"context_line":"            else:"},{"line_number":348,"context_line":"                raise e"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_6d6db703","line":346,"range":{"start_line":346,"start_character":25,"end_line":346,"end_character":32},"updated":"2016-01-28 09:14:09.000000000","message":"and this one.","commit_id":"93ca514b7c5b5d5c41a20dba448e9fa27eda7ddc"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"b1fcf2ce9af654bc6499b0be2cdafea09a8122cf","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            elif \u0027instance_uuid\u0027 in e.columns:"},{"line_number":344,"context_line":"                raise exception.InstanceAssociated("},{"line_number":345,"context_line":"                    instance_uuid\u003dvalues[\u0027instance_uuid\u0027],"},{"line_number":346,"context_line":"                    node\u003dnode_id)"},{"line_number":347,"context_line":"            else:"},{"line_number":348,"context_line":"                raise e"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_9fba9ae0","line":346,"range":{"start_line":346,"start_character":25,"end_line":346,"end_character":32},"in_reply_to":"7a5de9d1_6d6db703","updated":"2016-01-28 09:24:29.000000000","message":"Thanks Zhenguo for pointing this out. \n\nI thought about this. Does not have the clear way to replace this id with uuid for now, for the node object is got in function \u0027_do_update_node\u0027. And here the node object can not be got unless redo the query operation here, but I think it is ugly, so I left it here as it is. WDYT? Any clue?","commit_id":"93ca514b7c5b5d5c41a20dba448e9fa27eda7ddc"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d968f74eeab80e394a7a63a3592ac68f4cd756dc","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            elif \u0027instance_uuid\u0027 in e.columns:"},{"line_number":344,"context_line":"                raise exception.InstanceAssociated("},{"line_number":345,"context_line":"                    instance_uuid\u003dvalues[\u0027instance_uuid\u0027],"},{"line_number":346,"context_line":"                    node\u003dnode_id)"},{"line_number":347,"context_line":"            else:"},{"line_number":348,"context_line":"                raise e"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_057017db","line":346,"range":{"start_line":346,"start_character":25,"end_line":346,"end_character":32},"in_reply_to":"7a5de9d1_782574a9","updated":"2016-02-01 01:33:22.000000000","message":"thanks Kan, I agree with leaving the node_id here, and maybe we can change that later when we get some chances.","commit_id":"93ca514b7c5b5d5c41a20dba448e9fa27eda7ddc"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"f0d190c5ec88013fb4a3429dc89d7ec8ac7ec229","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            elif \u0027instance_uuid\u0027 in e.columns:"},{"line_number":344,"context_line":"                raise exception.InstanceAssociated("},{"line_number":345,"context_line":"                    instance_uuid\u003dvalues[\u0027instance_uuid\u0027],"},{"line_number":346,"context_line":"                    node\u003dnode_id)"},{"line_number":347,"context_line":"            else:"},{"line_number":348,"context_line":"                raise e"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_d5f1d1ce","line":346,"range":{"start_line":346,"start_character":25,"end_line":346,"end_character":32},"in_reply_to":"7a5de9d1_9fba9ae0","updated":"2016-01-28 09:55:54.000000000","message":"after thinking this more, we have prevented updating instance_uuid in _do_update_node(), seems this exception won\u0027t be raised at all.","commit_id":"93ca514b7c5b5d5c41a20dba448e9fa27eda7ddc"},{"author":{"_account_id":14810,"name":"Kan","email":"sofaopenstack@gmail.com","username":"Kan"},"change_message_id":"50feb832586772d7c1dc23c7096315d3fc809a37","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            elif \u0027instance_uuid\u0027 in e.columns:"},{"line_number":344,"context_line":"                raise exception.InstanceAssociated("},{"line_number":345,"context_line":"                    instance_uuid\u003dvalues[\u0027instance_uuid\u0027],"},{"line_number":346,"context_line":"                    node\u003dnode_id)"},{"line_number":347,"context_line":"            else:"},{"line_number":348,"context_line":"                raise e"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_782574a9","line":346,"range":{"start_line":346,"start_character":25,"end_line":346,"end_character":32},"in_reply_to":"7a5de9d1_d5f1d1ce","updated":"2016-01-28 10:09:32.000000000","message":"The \u0027instance_uuid\u0027 check would raise NodeAssociated exception here, which prevents raising the InstanceAssociated exception:\nhttps://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/api.py#L360\n\nBut I am not quite sure whether the DBDuplicateEntry exception would be raised here:\nhttps://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/api.py#L377","commit_id":"93ca514b7c5b5d5c41a20dba448e9fa27eda7ddc"}]}
