)]}'
{"etc/ironic/ansible_deploy/roles/deploy/tasks/download.yaml":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"103cecb42413e31e63622a373042acbadea553bd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    - name: upload download-complete script"},{"line_number":21,"context_line":"      become: yes"},{"line_number":22,"context_line":"      copy:"},{"line_number":23,"context_line":"        src: aria2c_download_complete.sh"},{"line_number":24,"context_line":"        dest: /tmp/aria2c_download_complete.sh"},{"line_number":25,"context_line":"        mode: 755"},{"line_number":26,"context_line":"    - name: download"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_a96a17eb","line":23,"updated":"2016-04-26 16:12:59.000000000","message":"it seems you\u0027ve forgot to include this file to the commit","commit_id":"41b30ad9190469fd2c51935b73de7b6f491d577e"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"d4ec8ee89a0943eeafaeb5dd34ed364983a65f4f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    - name: upload download-complete script"},{"line_number":21,"context_line":"      become: yes"},{"line_number":22,"context_line":"      copy:"},{"line_number":23,"context_line":"        src: aria2c_download_complete.sh"},{"line_number":24,"context_line":"        dest: /tmp/aria2c_download_complete.sh"},{"line_number":25,"context_line":"        mode: 755"},{"line_number":26,"context_line":"    - name: download"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_8d8aa7bd","line":23,"in_reply_to":"1a122d0e_a96a17eb","updated":"2016-04-27 16:55:08.000000000","message":"Done","commit_id":"41b30ad9190469fd2c51935b73de7b6f491d577e"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"103cecb42413e31e63622a373042acbadea553bd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        dest: /tmp/aria2c_download_complete.sh"},{"line_number":25,"context_line":"        mode: 755"},{"line_number":26,"context_line":"    - name: download"},{"line_number":27,"context_line":"      shell: aria2c --daemon\u003dtrue --log\u003d/aria2c.log --console-log-level\u003dwarn --on-bt-download-complete\u003d/tmp/aria2c_download_complete.sh --check-certificate\u003dfalse --file-allocation\u003dnone --allow-overwrite\u003dtrue --bt-enable-lpd\u003dtrue --seed-ratio\u003d0.0 --bt-tracker-interval\u003d2 --enable-dht\u003dfalse --enable-dht6\u003dfalse --disable-ipv6\u003dtrue --follow-torrent\u003dmem --dir\u003d/tmp/target --bt-tracker-connect-timeout\u003d2 --bt-tracker-interval\u003d5 --bt-tracker-timeout\u003d10 --seed-time\u003d999 \"{{ image_url }}\""},{"line_number":28,"context_line":"    - name: link image file"},{"line_number":29,"context_line":"      file: src\u003d/tmp/target/{{ torrent.filename }} dest\u003d/tmp/{{ node_uuid }}.img state\u003dlink"},{"line_number":30,"context_line":"    - name: wait for download finished"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_bbe53da5","line":27,"updated":"2016-04-26 16:12:59.000000000","message":"you do not need \"shell\" module here as you are not using any shell things. \"command\" would be enough, and is a bit faster.\n\nis this command returning more or less immediately?","commit_id":"41b30ad9190469fd2c51935b73de7b6f491d577e"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"d4ec8ee89a0943eeafaeb5dd34ed364983a65f4f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        dest: /tmp/aria2c_download_complete.sh"},{"line_number":25,"context_line":"        mode: 755"},{"line_number":26,"context_line":"    - name: download"},{"line_number":27,"context_line":"      shell: aria2c --daemon\u003dtrue --log\u003d/aria2c.log --console-log-level\u003dwarn --on-bt-download-complete\u003d/tmp/aria2c_download_complete.sh --check-certificate\u003dfalse --file-allocation\u003dnone --allow-overwrite\u003dtrue --bt-enable-lpd\u003dtrue --seed-ratio\u003d0.0 --bt-tracker-interval\u003d2 --enable-dht\u003dfalse --enable-dht6\u003dfalse --disable-ipv6\u003dtrue --follow-torrent\u003dmem --dir\u003d/tmp/target --bt-tracker-connect-timeout\u003d2 --bt-tracker-interval\u003d5 --bt-tracker-timeout\u003d10 --seed-time\u003d999 \"{{ image_url }}\""},{"line_number":28,"context_line":"    - name: link image file"},{"line_number":29,"context_line":"      file: src\u003d/tmp/target/{{ torrent.filename }} dest\u003d/tmp/{{ node_uuid }}.img state\u003dlink"},{"line_number":30,"context_line":"    - name: wait for download finished"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_6d874bb5","line":27,"in_reply_to":"1a122d0e_bbe53da5","updated":"2016-04-27 16:55:08.000000000","message":"Done","commit_id":"41b30ad9190469fd2c51935b73de7b6f491d577e"}],"ironic/common/bittorrent.py":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"5adbd56f0787343df871e6092ce0483921cf4fae","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    with open(os.path.join(CONF.bittorrent.deluge_autoadd_dir,"},{"line_number":79,"context_line":"                           image_id + \u0027.torrent\u0027), \u0027wb\u0027) as f:"},{"line_number":80,"context_line":"        f.write(libtorrent.bencode(image_torrent))"},{"line_number":81,"context_line":"    return get_magnet_link(image_torrent)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_53066e1c","line":81,"updated":"2016-04-27 17:33:32.000000000","message":"I think you should log some of this at INFO level too - the magnet link, for instance, and things like \"Torrent file written\".","commit_id":"4592b63f738572e54d3ee2fe20ba997fcb01f5c5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2c0ad3459f16cbfdf448faf442dae349a835cdd9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"def cache_image(image_id, context\u003dNone):"},{"line_number":84,"context_line":"    LOG.debug(\u0027Caching image %s to local directory\u0027, image_id)"},{"line_number":85,"context_line":"    cache \u003d image_cache.ImageCache(CONF.bittorrent.torrent_images_chache_dir,"},{"line_number":86,"context_line":"                                   999999999999, 1455183444)"},{"line_number":87,"context_line":"    cache.fetch_image(image_id, get_image_path(image_id), ctx\u003dcontext,"},{"line_number":88,"context_line":"                      force_raw\u003dFalse)"},{"line_number":89,"context_line":"    if not is_torrent_valid(image_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_79370fff","line":86,"range":{"start_line":86,"start_character":35,"end_line":86,"end_character":59},"updated":"2016-08-11 12:17:01.000000000","message":"Better to add config options for these :)","commit_id":"83ca2fd24fc71876e65971f92a8834fd24c970b1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2c0ad3459f16cbfdf448faf442dae349a835cdd9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                   999999999999, 1455183444)"},{"line_number":87,"context_line":"    cache.fetch_image(image_id, get_image_path(image_id), ctx\u003dcontext,"},{"line_number":88,"context_line":"                      force_raw\u003dFalse)"},{"line_number":89,"context_line":"    if not is_torrent_valid(image_id):"},{"line_number":90,"context_line":"        LOG.debug(\u0027Creating torrent file for image %s\u0027, image_id)"},{"line_number":91,"context_line":"        create_torrent(image_id)"},{"line_number":92,"context_line":"    LOG.debug(\u0027Add torrent file for image %s to torrent client for seeding\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_19dff3d9","line":89,"range":{"start_line":89,"start_character":11,"end_line":89,"end_character":37},"updated":"2016-08-11 12:17:01.000000000","message":"This can cause some trouble when we want to add more trackers right? The torrent won\u0027t be recreated until none of the nodes will be using the image + some configurable time interval. Can we fix this in is_torrent_valid? Also we need to cleanup torrent_autoadd_dir on instance teardown.","commit_id":"83ca2fd24fc71876e65971f92a8834fd24c970b1"}],"requirements.txt":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ba07177e9b87f67919fe5893b9358d70da29905a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0 # MIT"},{"line_number":45,"context_line":"psutil\u003c2.0.0,\u003e\u003d1.1.1 # BSD"},{"line_number":46,"context_line":"futurist\u003e\u003d0.11.0 # Apache-2.0"},{"line_number":47,"context_line":"python-libtorrent\u003e\u003d0.16.13 # BSD"}],"source_content_type":"text/plain","patch_set":8,"id":"1a122d0e_2630b655","line":47,"updated":"2016-04-28 15:47:04.000000000","message":"I guess you\u0027ll need to add this to global-requirements?","commit_id":"0b20b29b9f41a1824de95ea38c1abe0940040636"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4763935593db2360920e89d507a0e9febf16a7dc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0 # MIT"},{"line_number":45,"context_line":"psutil\u003c2.0.0,\u003e\u003d1.1.1 # BSD"},{"line_number":46,"context_line":"futurist\u003e\u003d0.11.0 # Apache-2.0"},{"line_number":47,"context_line":"python-libtorrent\u003e\u003d0.16.13 # BSD"}],"source_content_type":"text/plain","patch_set":9,"id":"7aa08908_2d294638","line":47,"updated":"2016-06-10 11:39:57.000000000","message":"The tests are failed because python-libtorrent is missed from global requirements.\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt","commit_id":"17f5fc1061b426b45271bfac9d3460f402402744"}]}
