)]}'
{"ironic/drivers/modules/irmc/common.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e69571b65f837877562db9b4a1733d53c9194adb","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    error_msgs \u003d []"},{"line_number":125,"context_line":"    if (d_info[\u0027irmc_auth_method\u0027].lower() not in (\u0027basic\u0027, \u0027digest\u0027)):"},{"line_number":126,"context_line":"        error_msgs.append("},{"line_number":127,"context_line":"            _(\"Value %s is not supported for \u0027irmc_auth_method\u0027. \""},{"line_number":128,"context_line":"              \"Supported values are: \u0027basic\u0027, \u0027digest\u0027\") %"},{"line_number":129,"context_line":"            d_info[\u0027irmc_auth_method\u0027])"},{"line_number":130,"context_line":"    if d_info[\u0027irmc_port\u0027] not in (80, 443):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b85f7f0d","line":127,"range":{"start_line":127,"start_character":21,"end_line":127,"end_character":23},"updated":"2016-02-15 04:45:39.000000000","message":"nit: add this value in quotes \u0027%s\u0027","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a18ba43f69ae0df7ebd168dada9a717d864a8bda","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    error_msgs \u003d []"},{"line_number":125,"context_line":"    if (d_info[\u0027irmc_auth_method\u0027].lower() not in (\u0027basic\u0027, \u0027digest\u0027)):"},{"line_number":126,"context_line":"        error_msgs.append("},{"line_number":127,"context_line":"            _(\"Value %s is not supported for \u0027irmc_auth_method\u0027. \""},{"line_number":128,"context_line":"              \"Supported values are: \u0027basic\u0027, \u0027digest\u0027\") %"},{"line_number":129,"context_line":"            d_info[\u0027irmc_auth_method\u0027])"},{"line_number":130,"context_line":"    if d_info[\u0027irmc_port\u0027] not in (80, 443):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_f8d74721","line":127,"range":{"start_line":127,"start_character":21,"end_line":127,"end_character":23},"in_reply_to":"dae33548_b85f7f0d","updated":"2016-02-15 05:23:52.000000000","message":"Right, I\u0027ll fix that.","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e69571b65f837877562db9b4a1733d53c9194adb","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            d_info[\u0027irmc_auth_method\u0027])"},{"line_number":130,"context_line":"    if d_info[\u0027irmc_port\u0027] not in (80, 443):"},{"line_number":131,"context_line":"        error_msgs.append("},{"line_number":132,"context_line":"            _(\"Value %s is not supported for \u0027irmc_port\u0027. \""},{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_58a59302","line":132,"range":{"start_line":132,"start_character":20,"end_line":132,"end_character":24},"updated":"2016-02-15 04:45:39.000000000","message":"nit: add this value in quotes \u0027%s\u0027","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a18ba43f69ae0df7ebd168dada9a717d864a8bda","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            d_info[\u0027irmc_auth_method\u0027])"},{"line_number":130,"context_line":"    if d_info[\u0027irmc_port\u0027] not in (80, 443):"},{"line_number":131,"context_line":"        error_msgs.append("},{"line_number":132,"context_line":"            _(\"Value %s is not supported for \u0027irmc_port\u0027. \""},{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_98e71b12","line":132,"range":{"start_line":132,"start_character":20,"end_line":132,"end_character":24},"in_reply_to":"dae33548_58a59302","updated":"2016-02-15 05:23:52.000000000","message":"I\u0027ll fix that.","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e69571b65f837877562db9b4a1733d53c9194adb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value %s is not integer type for \u0027irmc_client_timeout\u0027\") %"},{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"},{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_38aa4fd5","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":23},"updated":"2016-02-15 04:45:39.000000000","message":"ditto","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a18ba43f69ae0df7ebd168dada9a717d864a8bda","unresolved":false,"context_lines":[{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value %s is not integer type for \u0027irmc_client_timeout\u0027\") %"},{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"},{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_78e4d70c","line":136,"range":{"start_line":136,"start_character":21,"end_line":136,"end_character":23},"in_reply_to":"dae33548_38aa4fd5","updated":"2016-02-15 05:23:52.000000000","message":"I\u0027ll fix that.","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e69571b65f837877562db9b4a1733d53c9194adb","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"},{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("},{"line_number":140,"context_line":"            _(\"Value %s is not supported for \u0027irmc_sensor_method\u0027. \""},{"line_number":141,"context_line":"              \"Supported values are: \u0027ipmitool\u0027, \u0027scci\u0027\") %"},{"line_number":142,"context_line":"            d_info[\u0027irmc_sensor_method\u0027])"},{"line_number":143,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() not in (\u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_78acd7ed","line":140,"range":{"start_line":140,"start_character":21,"end_line":140,"end_character":23},"updated":"2016-02-15 04:45:39.000000000","message":"ditto","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a18ba43f69ae0df7ebd168dada9a717d864a8bda","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"},{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("},{"line_number":140,"context_line":"            _(\"Value %s is not supported for \u0027irmc_sensor_method\u0027. \""},{"line_number":141,"context_line":"              \"Supported values are: \u0027ipmitool\u0027, \u0027scci\u0027\") %"},{"line_number":142,"context_line":"            d_info[\u0027irmc_sensor_method\u0027])"},{"line_number":143,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() not in (\u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b8ee5fea","line":140,"range":{"start_line":140,"start_character":21,"end_line":140,"end_character":23},"in_reply_to":"dae33548_78acd7ed","updated":"2016-02-15 05:23:52.000000000","message":"I\u0027ll fix that.","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e69571b65f837877562db9b4a1733d53c9194adb","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            d_info[\u0027irmc_sensor_method\u0027])"},{"line_number":143,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() not in (\u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027):"},{"line_number":144,"context_line":"        error_msgs.append("},{"line_number":145,"context_line":"            _(\"Value %s is not supported for \u0027irmc_snmp_version\u0027. \""},{"line_number":146,"context_line":"              \"Supported values are: \u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027\") %"},{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b8b65f3b","line":145,"range":{"start_line":145,"start_character":21,"end_line":145,"end_character":23},"updated":"2016-02-15 04:45:39.000000000","message":"ditto","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a18ba43f69ae0df7ebd168dada9a717d864a8bda","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            d_info[\u0027irmc_sensor_method\u0027])"},{"line_number":143,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() not in (\u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027):"},{"line_number":144,"context_line":"        error_msgs.append("},{"line_number":145,"context_line":"            _(\"Value %s is not supported for \u0027irmc_snmp_version\u0027. \""},{"line_number":146,"context_line":"              \"Supported values are: \u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027\") %"},{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_18baebe1","line":145,"range":{"start_line":145,"start_character":21,"end_line":145,"end_character":23},"in_reply_to":"dae33548_b8b65f3b","updated":"2016-02-15 05:23:52.000000000","message":"I\u0027ll fix that.","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e69571b65f837877562db9b4a1733d53c9194adb","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"},{"line_number":149,"context_line":"        error_msgs.append("},{"line_number":150,"context_line":"            _(\"Value %s is not integer type for \u0027irmc_snmp_port\u0027\") %"},{"line_number":151,"context_line":"            d_info[\u0027irmc_snmp_port\u0027])"},{"line_number":152,"context_line":"    if (d_info[\u0027irmc_snmp_version\u0027].lower() in (\u0027v1\u0027, \u0027v2c\u0027) and"},{"line_number":153,"context_line":"        d_info[\u0027irmc_snmp_community\u0027] and"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_587c7372","line":150,"range":{"start_line":150,"start_character":21,"end_line":150,"end_character":23},"updated":"2016-02-15 04:45:39.000000000","message":"ditto","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a18ba43f69ae0df7ebd168dada9a717d864a8bda","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"},{"line_number":149,"context_line":"        error_msgs.append("},{"line_number":150,"context_line":"            _(\"Value %s is not integer type for \u0027irmc_snmp_port\u0027\") %"},{"line_number":151,"context_line":"            d_info[\u0027irmc_snmp_port\u0027])"},{"line_number":152,"context_line":"    if (d_info[\u0027irmc_snmp_version\u0027].lower() in (\u0027v1\u0027, \u0027v2c\u0027) and"},{"line_number":153,"context_line":"        d_info[\u0027irmc_snmp_community\u0027] and"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_f8be27d3","line":150,"range":{"start_line":150,"start_character":21,"end_line":150,"end_character":23},"in_reply_to":"dae33548_587c7372","updated":"2016-02-15 05:23:52.000000000","message":"I\u0027ll fix that.","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e69571b65f837877562db9b4a1733d53c9194adb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        d_info[\u0027irmc_snmp_community\u0027] and"},{"line_number":154,"context_line":"        not isinstance(d_info[\u0027irmc_snmp_community\u0027], six.string_types)):"},{"line_number":155,"context_line":"        error_msgs.append("},{"line_number":156,"context_line":"            _(\"Value %s is not string type for \u0027irmc_snmp_community\u0027\") %"},{"line_number":157,"context_line":"            d_info[\u0027irmc_snmp_community\u0027])"},{"line_number":158,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() \u003d\u003d \u0027v3\u0027:"},{"line_number":159,"context_line":"        if d_info[\u0027irmc_snmp_security\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_3881af4b","line":156,"range":{"start_line":156,"start_character":21,"end_line":156,"end_character":23},"updated":"2016-02-15 04:45:39.000000000","message":"ditto","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a18ba43f69ae0df7ebd168dada9a717d864a8bda","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        d_info[\u0027irmc_snmp_community\u0027] and"},{"line_number":154,"context_line":"        not isinstance(d_info[\u0027irmc_snmp_community\u0027], six.string_types)):"},{"line_number":155,"context_line":"        error_msgs.append("},{"line_number":156,"context_line":"            _(\"Value %s is not string type for \u0027irmc_snmp_community\u0027\") %"},{"line_number":157,"context_line":"            d_info[\u0027irmc_snmp_community\u0027])"},{"line_number":158,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() \u003d\u003d \u0027v3\u0027:"},{"line_number":159,"context_line":"        if d_info[\u0027irmc_snmp_security\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_98cefb81","line":156,"range":{"start_line":156,"start_character":21,"end_line":156,"end_character":23},"in_reply_to":"dae33548_3881af4b","updated":"2016-02-15 05:23:52.000000000","message":"I\u0027ll fix that.","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e69571b65f837877562db9b4a1733d53c9194adb","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if d_info[\u0027irmc_snmp_security\u0027]:"},{"line_number":160,"context_line":"            if not isinstance(d_info[\u0027irmc_snmp_security\u0027], six.string_types):"},{"line_number":161,"context_line":"                error_msgs.append("},{"line_number":162,"context_line":"                    _(\"Value %s is not string type for \u0027irmc_snmp_security\u0027\") %"},{"line_number":163,"context_line":"                    d_info[\u0027irmc_snmp_security\u0027])"},{"line_number":164,"context_line":"        else:"},{"line_number":165,"context_line":"            error_msgs.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_b88dbf7d","line":162,"range":{"start_line":162,"start_character":29,"end_line":162,"end_character":31},"updated":"2016-02-15 04:45:39.000000000","message":"ditto","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a18ba43f69ae0df7ebd168dada9a717d864a8bda","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if d_info[\u0027irmc_snmp_security\u0027]:"},{"line_number":160,"context_line":"            if not isinstance(d_info[\u0027irmc_snmp_security\u0027], six.string_types):"},{"line_number":161,"context_line":"                error_msgs.append("},{"line_number":162,"context_line":"                    _(\"Value %s is not string type for \u0027irmc_snmp_security\u0027\") %"},{"line_number":163,"context_line":"                    d_info[\u0027irmc_snmp_security\u0027])"},{"line_number":164,"context_line":"        else:"},{"line_number":165,"context_line":"            error_msgs.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_78cb3773","line":162,"range":{"start_line":162,"start_character":29,"end_line":162,"end_character":31},"in_reply_to":"dae33548_b88dbf7d","updated":"2016-02-15 05:23:52.000000000","message":"I\u0027ll fix that.","commit_id":"c0d0d5e3a0c5540c720007ec82934f74f0f43f7c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9eb9cc1611e6c8deaa9708c98d81012fa38ffccf","unresolved":false,"context_lines":[{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value \u0027%s\u0027 is not integer type for \u0027irmc_client_timeout\u0027\") %"},{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"},{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e9cec62b","line":136,"updated":"2016-02-23 14:10:55.000000000","message":"s/integer type/an integer/","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d20b373a784b77e71d00298b7e89432fec8a45fb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value \u0027%s\u0027 is not integer type for \u0027irmc_client_timeout\u0027\") %"},{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"},{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a0e5c809","line":136,"in_reply_to":"bae84128_e9cec62b","updated":"2016-02-24 05:07:10.000000000","message":"I\u0027ll fix that.","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9eb9cc1611e6c8deaa9708c98d81012fa38ffccf","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"},{"line_number":149,"context_line":"        error_msgs.append("},{"line_number":150,"context_line":"            _(\"Value \u0027%s\u0027 is not integer type for \u0027irmc_snmp_port\u0027\") %"},{"line_number":151,"context_line":"            d_info[\u0027irmc_snmp_port\u0027])"},{"line_number":152,"context_line":"    if (d_info[\u0027irmc_snmp_version\u0027].lower() in (\u0027v1\u0027, \u0027v2c\u0027) and"},{"line_number":153,"context_line":"        d_info[\u0027irmc_snmp_community\u0027] and"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c9d302d4","line":150,"updated":"2016-02-23 14:10:55.000000000","message":"ditto","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d20b373a784b77e71d00298b7e89432fec8a45fb","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"},{"line_number":149,"context_line":"        error_msgs.append("},{"line_number":150,"context_line":"            _(\"Value \u0027%s\u0027 is not integer type for \u0027irmc_snmp_port\u0027\") %"},{"line_number":151,"context_line":"            d_info[\u0027irmc_snmp_port\u0027])"},{"line_number":152,"context_line":"    if (d_info[\u0027irmc_snmp_version\u0027].lower() in (\u0027v1\u0027, \u0027v2c\u0027) and"},{"line_number":153,"context_line":"        d_info[\u0027irmc_snmp_community\u0027] and"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c0d1ec24","line":150,"in_reply_to":"bae84128_c9d302d4","updated":"2016-02-24 05:07:10.000000000","message":"I\u0027ll fix that.","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9eb9cc1611e6c8deaa9708c98d81012fa38ffccf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        d_info[\u0027irmc_snmp_community\u0027] and"},{"line_number":154,"context_line":"        not isinstance(d_info[\u0027irmc_snmp_community\u0027], six.string_types)):"},{"line_number":155,"context_line":"        error_msgs.append("},{"line_number":156,"context_line":"            _(\"Value \u0027%s\u0027 is not string type for \u0027irmc_snmp_community\u0027\") %"},{"line_number":157,"context_line":"            d_info[\u0027irmc_snmp_community\u0027])"},{"line_number":158,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() \u003d\u003d \u0027v3\u0027:"},{"line_number":159,"context_line":"        if d_info[\u0027irmc_snmp_security\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_29dd4ee0","line":156,"updated":"2016-02-23 14:10:55.000000000","message":"ditto","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d20b373a784b77e71d00298b7e89432fec8a45fb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        d_info[\u0027irmc_snmp_community\u0027] and"},{"line_number":154,"context_line":"        not isinstance(d_info[\u0027irmc_snmp_community\u0027], six.string_types)):"},{"line_number":155,"context_line":"        error_msgs.append("},{"line_number":156,"context_line":"            _(\"Value \u0027%s\u0027 is not string type for \u0027irmc_snmp_community\u0027\") %"},{"line_number":157,"context_line":"            d_info[\u0027irmc_snmp_community\u0027])"},{"line_number":158,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() \u003d\u003d \u0027v3\u0027:"},{"line_number":159,"context_line":"        if d_info[\u0027irmc_snmp_security\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e099907a","line":156,"in_reply_to":"bae84128_29dd4ee0","updated":"2016-02-24 05:07:10.000000000","message":"I\u0027ll fix that.","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9eb9cc1611e6c8deaa9708c98d81012fa38ffccf","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if d_info[\u0027irmc_snmp_security\u0027]:"},{"line_number":160,"context_line":"            if not isinstance(d_info[\u0027irmc_snmp_security\u0027], six.string_types):"},{"line_number":161,"context_line":"                error_msgs.append("},{"line_number":162,"context_line":"                    _(\"Value \u0027%s\u0027 is not string type for \u0027irmc_snmp_security\u0027\")"},{"line_number":163,"context_line":"                    % d_info[\u0027irmc_snmp_security\u0027])"},{"line_number":164,"context_line":"        else:"},{"line_number":165,"context_line":"            error_msgs.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_09da0ae8","line":162,"updated":"2016-02-23 14:10:55.000000000","message":"\"a string\"","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d20b373a784b77e71d00298b7e89432fec8a45fb","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if d_info[\u0027irmc_snmp_security\u0027]:"},{"line_number":160,"context_line":"            if not isinstance(d_info[\u0027irmc_snmp_security\u0027], six.string_types):"},{"line_number":161,"context_line":"                error_msgs.append("},{"line_number":162,"context_line":"                    _(\"Value \u0027%s\u0027 is not string type for \u0027irmc_snmp_security\u0027\")"},{"line_number":163,"context_line":"                    % d_info[\u0027irmc_snmp_security\u0027])"},{"line_number":164,"context_line":"        else:"},{"line_number":165,"context_line":"            error_msgs.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_6084600a","line":162,"in_reply_to":"bae84128_09da0ae8","updated":"2016-02-24 05:07:10.000000000","message":"I\u0027ll fix that.","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e097092c10c076fb9d6380777735b8feb73e8348","unresolved":false,"context_lines":[{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value \u0027%s\u0027 is not an integer type for \u0027irmc_client_timeout\u0027\") %"},{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"},{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_d5b36196","line":136,"updated":"2016-02-24 09:26:54.000000000","message":"please remove \"type\" words from all these messages. These are not types, these are values.","commit_id":"3301c3d30e7e1164ab2c8de39c911486becf5303"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"7a87eb5fc7d9b0b4d8500279649aa995c0c10114","unresolved":false,"context_lines":[{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value \u0027%s\u0027 is not an integer type for \u0027irmc_client_timeout\u0027\") %"},{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"},{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0c78edf7","line":136,"in_reply_to":"bae84128_d5b36196","updated":"2016-02-25 00:40:46.000000000","message":"Yeah, I agree. I\u0027ll fix that.","commit_id":"3301c3d30e7e1164ab2c8de39c911486becf5303"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"09e79cccd99a39eac9814dc9bf60c4170332ad3a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    if (d_info[\u0027irmc_auth_method\u0027].lower() not in (\u0027basic\u0027, \u0027digest\u0027)):"},{"line_number":126,"context_line":"        error_msgs.append("},{"line_number":127,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_auth_method\u0027. \""},{"line_number":128,"context_line":"              \"Supported values are: \u0027basic\u0027, \u0027digest\u0027\") %"},{"line_number":129,"context_line":"            d_info[\u0027irmc_auth_method\u0027])"},{"line_number":130,"context_line":"    if d_info[\u0027irmc_port\u0027] not in (80, 443):"},{"line_number":131,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_ae5b922d","line":128,"updated":"2016-02-25 14:42:34.000000000","message":"Not needed to provide a list of supported values, they are accessible via driver\u0027s properties.","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"dcc0c0df4fed2a2f4bab44692c722cc8d28388bf","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    if (d_info[\u0027irmc_auth_method\u0027].lower() not in (\u0027basic\u0027, \u0027digest\u0027)):"},{"line_number":126,"context_line":"        error_msgs.append("},{"line_number":127,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_auth_method\u0027. \""},{"line_number":128,"context_line":"              \"Supported values are: \u0027basic\u0027, \u0027digest\u0027\") %"},{"line_number":129,"context_line":"            d_info[\u0027irmc_auth_method\u0027])"},{"line_number":130,"context_line":"    if d_info[\u0027irmc_port\u0027] not in (80, 443):"},{"line_number":131,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_756bd0f1","line":128,"in_reply_to":"bae84128_ae5b922d","updated":"2016-02-29 02:40:09.000000000","message":"I\u0027ll fix that.","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"09e79cccd99a39eac9814dc9bf60c4170332ad3a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if d_info[\u0027irmc_port\u0027] not in (80, 443):"},{"line_number":131,"context_line":"        error_msgs.append("},{"line_number":132,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_port\u0027. \""},{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value \u0027%s\u0027 is not an integer for \u0027irmc_client_timeout\u0027\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_8ee84e18","line":133,"updated":"2016-02-25 14:42:34.000000000","message":"ditto","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"dcc0c0df4fed2a2f4bab44692c722cc8d28388bf","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if d_info[\u0027irmc_port\u0027] not in (80, 443):"},{"line_number":131,"context_line":"        error_msgs.append("},{"line_number":132,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_port\u0027. \""},{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value \u0027%s\u0027 is not an integer for \u0027irmc_client_timeout\u0027\") %"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_1551a436","line":133,"in_reply_to":"bae84128_8ee84e18","updated":"2016-02-29 02:40:09.000000000","message":"I\u0027ll fix that.","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"09e79cccd99a39eac9814dc9bf60c4170332ad3a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        error_msgs.append("},{"line_number":132,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_port\u0027. \""},{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value \u0027%s\u0027 is not an integer for \u0027irmc_client_timeout\u0027\") %"},{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_89b968ef","line":134,"updated":"2016-02-25 14:42:34.000000000","message":"What about\n\ntry:\n    d_info[\u0027irmc_client_timeout\u0027] \u003d int(d_info[\u0027irmc_client_timeout\u0027])\nexcept ValueError:\n    ...","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"dcc0c0df4fed2a2f4bab44692c722cc8d28388bf","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        error_msgs.append("},{"line_number":132,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_port\u0027. \""},{"line_number":133,"context_line":"              \"Supported values are: \u002780\u0027, \u0027443\u0027\") % d_info[\u0027irmc_port\u0027])"},{"line_number":134,"context_line":"    if not isinstance(d_info[\u0027irmc_client_timeout\u0027], int):"},{"line_number":135,"context_line":"        error_msgs.append("},{"line_number":136,"context_line":"            _(\"Value \u0027%s\u0027 is not an integer for \u0027irmc_client_timeout\u0027\") %"},{"line_number":137,"context_line":"            d_info[\u0027irmc_client_timeout\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_758110c3","line":134,"in_reply_to":"bae84128_89b968ef","updated":"2016-02-29 02:40:09.000000000","message":"I answered in the L.148.","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"09e79cccd99a39eac9814dc9bf60c4170332ad3a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("},{"line_number":140,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_sensor_method\u0027. \""},{"line_number":141,"context_line":"              \"Supported values are: \u0027ipmitool\u0027, \u0027scci\u0027\") %"},{"line_number":142,"context_line":"            d_info[\u0027irmc_sensor_method\u0027])"},{"line_number":143,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() not in (\u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027):"},{"line_number":144,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_4ee76640","line":141,"updated":"2016-02-25 14:42:34.000000000","message":"ditto","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"dcc0c0df4fed2a2f4bab44692c722cc8d28388bf","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    if d_info[\u0027irmc_sensor_method\u0027].lower() not in (\u0027ipmitool\u0027, \u0027scci\u0027):"},{"line_number":139,"context_line":"        error_msgs.append("},{"line_number":140,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_sensor_method\u0027. \""},{"line_number":141,"context_line":"              \"Supported values are: \u0027ipmitool\u0027, \u0027scci\u0027\") %"},{"line_number":142,"context_line":"            d_info[\u0027irmc_sensor_method\u0027])"},{"line_number":143,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() not in (\u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027):"},{"line_number":144,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_b50ef838","line":141,"in_reply_to":"bae84128_4ee76640","updated":"2016-02-29 02:40:09.000000000","message":"I\u0027ll fix that.","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"09e79cccd99a39eac9814dc9bf60c4170332ad3a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() not in (\u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027):"},{"line_number":144,"context_line":"        error_msgs.append("},{"line_number":145,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_snmp_version\u0027. \""},{"line_number":146,"context_line":"              \"Supported values are: \u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027\") %"},{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"},{"line_number":149,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_8ecfaeb2","line":146,"updated":"2016-02-25 14:42:34.000000000","message":"ditto","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"dcc0c0df4fed2a2f4bab44692c722cc8d28388bf","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    if d_info[\u0027irmc_snmp_version\u0027].lower() not in (\u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027):"},{"line_number":144,"context_line":"        error_msgs.append("},{"line_number":145,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_snmp_version\u0027. \""},{"line_number":146,"context_line":"              \"Supported values are: \u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027\") %"},{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"},{"line_number":149,"context_line":"        error_msgs.append("}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_b8154d41","line":146,"in_reply_to":"bae84128_8ecfaeb2","updated":"2016-02-29 02:40:09.000000000","message":"I\u0027ll fix that.","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"09e79cccd99a39eac9814dc9bf60c4170332ad3a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_snmp_version\u0027. \""},{"line_number":146,"context_line":"              \"Supported values are: \u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027\") %"},{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"},{"line_number":149,"context_line":"        error_msgs.append("},{"line_number":150,"context_line":"            _(\"Value \u0027%s\u0027 is not an integer for \u0027irmc_snmp_port\u0027\") %"},{"line_number":151,"context_line":"            d_info[\u0027irmc_snmp_port\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_c9aa5085","line":148,"updated":"2016-02-25 14:42:34.000000000","message":"ditto l134","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"dcc0c0df4fed2a2f4bab44692c722cc8d28388bf","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            _(\"Value \u0027%s\u0027 is not supported for \u0027irmc_snmp_version\u0027. \""},{"line_number":146,"context_line":"              \"Supported values are: \u0027v1\u0027, \u0027v2c\u0027, \u0027v3\u0027\") %"},{"line_number":147,"context_line":"            d_info[\u0027irmc_snmp_version\u0027])"},{"line_number":148,"context_line":"    if not isinstance(d_info[\u0027irmc_snmp_port\u0027], int):"},{"line_number":149,"context_line":"        error_msgs.append("},{"line_number":150,"context_line":"            _(\"Value \u0027%s\u0027 is not an integer for \u0027irmc_snmp_port\u0027\") %"},{"line_number":151,"context_line":"            d_info[\u0027irmc_snmp_port\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_b528b8e3","line":148,"in_reply_to":"bae84128_c9aa5085","updated":"2016-02-29 02:40:09.000000000","message":"As I answered in the base patch before, calling int() is not necessary.\n\nhttps://review.openstack.org/#/c/196480/18..25/ironic/drivers/modules/irmc/common.py\n\n\u003eAs far as I tested such as the following cases 1) to 4), the string value 120 is already converted into \u0027int\u0027 at the line 137.\n\nIf user specified a value which is not able to be converted such as \u0027xyz\u0027, the line 137 can catch as not \u0027int\u0027. So I think int() is not necessary.\n\n    diriver_info\n\n 1)ironic node-update $NODE_UUID add driver_info/irmc_snmp_port\u003d120\n\n 2) ironic node-update $NODE_UUID add driver_info/irmc_snmp_port\u003d\"120\"\n\n    /etc/ironic/ironic.conf\n\n 3)\n  [irmc]\n snmp_port \u003d \u0027120\u0027\n\n 4)\n [irmc]\n snmp_port \u003d  120","commit_id":"c03bc2e7609b447ef1934708c049ccb4f285681d"}],"releasenotes/notes/irmc-oob-inspection-6d072c60f6c88ecb.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9eb9cc1611e6c8deaa9708c98d81012fa38ffccf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds out-of-band inspection support for iRMC driver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_69e3d6a4","line":3,"updated":"2016-02-23 14:10:55.000000000","message":"nit: maybe s/driver/drivers/ as you have several of them","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d20b373a784b77e71d00298b7e89432fec8a45fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds out-of-band inspection support for iRMC driver."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_e0707042","line":3,"in_reply_to":"bae84128_69e3d6a4","updated":"2016-02-24 05:07:10.000000000","message":"I\u0027ll fix that.","commit_id":"4748b227e1892f6b6ef9cf8adb484bc8d4c994a3"}]}