)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6fb8b146aa3b364e9fc247cdff07b4ac2aec799e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Aparna \u003caparnavtce@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-17 11:55:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding cacert while Ironic talking to Glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently Ironic doesn\u0027t pass any certificate down for verifying"},{"line_number":10,"context_line":"https connections in glance. Adding the certificate provides secure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_939db068","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":44},"updated":"2016-02-17 14:38:24.000000000","message":"Can this be changed for more clarity. Ex:\n\u0027Support for passing CA certificates to glance API\u0027","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"84f55b4458b930c50f776888d6bd17042a65eabb","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# Enables or disables syslog rfc5424 format for logging. If"},{"line_number":226,"context_line":"# enabled, prefixes the MSG part of the syslog message with"},{"line_number":227,"context_line":"# APP-NAME (RFC5424). This option is ignored if"},{"line_number":228,"context_line":"# log_config_append is set. (boolean value)"},{"line_number":229,"context_line":"#use_syslog_rfc_format\u003dtrue"},{"line_number":230,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dae33548_8b545eff","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":47},"updated":"2016-02-17 12:38:22.000000000","message":"unrelated changes - better to update sample conf in separate patch","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dbb54a18d0dd494542cb7897ea3a4188ab5a353","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# Enables or disables syslog rfc5424 format for logging. If"},{"line_number":226,"context_line":"# enabled, prefixes the MSG part of the syslog message with"},{"line_number":227,"context_line":"# APP-NAME (RFC5424). This option is ignored if"},{"line_number":228,"context_line":"# log_config_append is set. (boolean value)"},{"line_number":229,"context_line":"#use_syslog_rfc_format\u003dtrue"},{"line_number":230,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dae33548_f2e6bb13","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":47},"in_reply_to":"dae33548_8b545eff","updated":"2016-02-17 14:29:23.000000000","message":"Need to update the sample conf file within this patch.\n\nI think some lines are missing here.\nhttps://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L225-L231\n\nPlease regenerate the conf file using\n$ tox -egenconfig","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"0818e7256f946372545eb8ee8ccd1e103ec7f2a5","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"# Enables or disables syslog rfc5424 format for logging. If"},{"line_number":226,"context_line":"# enabled, prefixes the MSG part of the syslog message with"},{"line_number":227,"context_line":"# APP-NAME (RFC5424). This option is ignored if"},{"line_number":228,"context_line":"# log_config_append is set. (boolean value)"},{"line_number":229,"context_line":"#use_syslog_rfc_format\u003dtrue"},{"line_number":230,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"dae33548_6040a736","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":47},"in_reply_to":"dae33548_f2e6bb13","updated":"2016-02-19 04:52:53.000000000","message":"Done","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f1a248fccb64100788532e9e00a28b67a53f1dc1","unresolved":false,"context_lines":[{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"# Path to the SSL certificate that allows to perform secure"},{"line_number":1116,"context_line":"# SSL requests to glance (string value)"},{"line_number":1117,"context_line":"#glance_cafile\u003d\u003cNone\u003e"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"[iboot]"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"bae84128_3a78238f","line":1117,"updated":"2016-02-22 15:28:05.000000000","message":"Also please regenerate this with tox -egenconfig, it does not match the option description content.","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b6fdbacb357401bc84413a0bf7913b4db4ceac19","unresolved":false,"context_lines":[{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"# Path to the SSL certificate that allows to perform secure"},{"line_number":1116,"context_line":"# SSL requests to glance (string value)"},{"line_number":1117,"context_line":"#glance_cafile\u003d\u003cNone\u003e"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"[iboot]"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"bae84128_da7f1013","line":1117,"in_reply_to":"bae84128_3a78238f","updated":"2016-02-24 09:10:16.000000000","message":"Done","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"}],"ironic/common/glance_service/base_image_service.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"cbb2baa7ddaab11f1489384f57b5f49ac8380192","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027]:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.keystone_authtoken.cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":87,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_ace8a6e3","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":54},"updated":"2016-02-16 09:34:20.000000000","message":"why keystone cafile is used?","commit_id":"e2c302f41c289ec06abc8ddd16abbfbe2ce97b01"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"a017a3adf15c756c4eaeac40bd821f01f780c6ad","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027]:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.keystone_authtoken.cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":87,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_73b763f5","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":54},"in_reply_to":"dae33548_00196022","updated":"2016-02-17 08:50:41.000000000","message":"+1, after think about this, agree new option is needed","commit_id":"e2c302f41c289ec06abc8ddd16abbfbe2ce97b01"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"7a79b9a73fcc92e5637da1a7bc640621a425d037","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027]:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.keystone_authtoken.cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":87,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_8880e4c1","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":54},"in_reply_to":"dae33548_00196022","updated":"2016-02-17 12:05:50.000000000","message":"Done","commit_id":"e2c302f41c289ec06abc8ddd16abbfbe2ce97b01"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7660405f1cce1888a304bb016a8f80f11211d948","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027]:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.keystone_authtoken.cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":87,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_00196022","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":54},"in_reply_to":"dae33548_052e92a4","updated":"2016-02-17 05:27:52.000000000","message":"I think we should introduce a new conf variable under [glance] section for this.","commit_id":"e2c302f41c289ec06abc8ddd16abbfbe2ce97b01"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"7a79b9a73fcc92e5637da1a7bc640621a425d037","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027]:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.keystone_authtoken.cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":87,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_2870b80a","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":54},"in_reply_to":"dae33548_73b763f5","updated":"2016-02-17 12:05:50.000000000","message":"Done","commit_id":"e2c302f41c289ec06abc8ddd16abbfbe2ce97b01"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"f64504bb4d84c9db291b2a2d7f6c5abb5d3ca775","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027]:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.keystone_authtoken.cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":87,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_052e92a4","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":54},"in_reply_to":"dae33548_ace8a6e3","updated":"2016-02-17 05:00:18.000000000","message":"I have used keystone cafile to provide the path for glance cacert. But now I think I have to create a new ironic config variable to pass the cacert to glance.","commit_id":"e2c302f41c289ec06abc8ddd16abbfbe2ce97b01"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ceed263cb3d23bbd08ad56d9677712f30d420382","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027]:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.glance.glance_cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":87,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_14aaf318","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":56},"updated":"2016-03-04 04:32:53.000000000","message":"I think we need a check to see if the variable is set before passing it to glance\nif CONF.glance.glance_cafile:\n    params[\u0027cacert\u0027] \u003d CONF.glance.glance_cafile","commit_id":"969c79114857cb2bce54f9687775346a41a6eb01"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"2e58b9c4cb59ff0c0a51408f48794252ba5d2bb8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027]:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.glance.glance_cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":87,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_c4c28e52","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":56},"in_reply_to":"7af24918_14aaf318","updated":"2016-03-04 10:01:50.000000000","message":"Done","commit_id":"969c79114857cb2bce54f9687775346a41a6eb01"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d07704f4f5293e80d9e6ae0be0b90c07dc572cca","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            scheme \u003d \u0027http\u0027"},{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027] and CONF.glance.glance_cafile:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.glance.glance_cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_944f1533","line":83,"range":{"start_line":83,"start_character":7,"end_line":83,"end_character":64},"updated":"2016-03-04 11:00:49.000000000","message":"I think the ca certificate validation is done by the request library and it would do it only for the https requests. This mean the \u0027scheme\u0027 used by image should be \u0027https\u0027. Only then we can pass a ca certificate. Should the check be:-\nif (not params[\u0027insecure\u0027] and \n        CONF.glance.glance_cafile and use_ssl):\n    params[\u0027cacert\u0027] \u003d CONF.glance.glance_cafile","commit_id":"c8e026c56ffca387ae893224240610d9a9a03da5"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"efd7e4bd9608e046e514f5237a341b894cde3d4c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            scheme \u003d \u0027http\u0027"},{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if not params[\u0027insecure\u0027] and CONF.glance.glance_cafile:"},{"line_number":84,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.glance.glance_cafile"},{"line_number":85,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":86,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_e975b032","line":83,"range":{"start_line":83,"start_character":7,"end_line":83,"end_character":64},"in_reply_to":"7af24918_944f1533","updated":"2016-03-05 08:59:55.000000000","message":"Done","commit_id":"c8e026c56ffca387ae893224240610d9a9a03da5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"499db7ab821c365319452f19a2c8f8e8d7cb6041","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if (not params[\u0027insecure\u0027] and CONF.glance.glance_cafile"},{"line_number":84,"context_line":"                and use_ssl):"},{"line_number":85,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.glance.glance_cafile"},{"line_number":86,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":87,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_a77bcf28","line":84,"range":{"start_line":84,"start_character":15,"end_line":84,"end_character":28},"updated":"2016-03-05 14:18:39.000000000","message":"Need to add testcase for the case when use_ssl\u003dFalse","commit_id":"e9492f6192325a6efe0e0d9ed7f9c46c7f177c46"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"7f657796c70eb45323d15b426bd6471a5dae6cb7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        params \u003d {}"},{"line_number":82,"context_line":"        params[\u0027insecure\u0027] \u003d CONF.glance.glance_api_insecure"},{"line_number":83,"context_line":"        if (not params[\u0027insecure\u0027] and CONF.glance.glance_cafile"},{"line_number":84,"context_line":"                and use_ssl):"},{"line_number":85,"context_line":"            params[\u0027cacert\u0027] \u003d CONF.glance.glance_cafile"},{"line_number":86,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":87,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_119f7c04","line":84,"range":{"start_line":84,"start_character":15,"end_line":84,"end_character":28},"in_reply_to":"7af24918_a77bcf28","updated":"2016-03-07 09:00:21.000000000","message":"The test case for http(use_ssl\u003dFalse) is already there.","commit_id":"e9492f6192325a6efe0e0d9ed7f9c46c7f177c46"}],"ironic/common/image_service.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cdc3d540b120ecdd9b98fadd773612bdf52dbafe","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \u0027supported by ironic.\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027glance_cafile\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Path to the SSL certificate that allows to perform \u0027"},{"line_number":77,"context_line":"                      \u0027secure SSL requests to glance\u0027)),"},{"line_number":78,"context_line":"]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"CONF.register_opts(glance_opts, group\u003d\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_efb82de8","line":77,"updated":"2016-02-19 10:39:47.000000000","message":"nit: \"Only used if glance_api_insecure is False\"","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b4de20aa97230bcc9e0f211ec1771f58a2cfefb1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \u0027supported by ironic.\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027glance_cafile\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Path to the SSL certificate that allows to perform \u0027"},{"line_number":77,"context_line":"                      \u0027secure SSL requests to glance\u0027)),"},{"line_number":78,"context_line":"]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"CONF.register_opts(glance_opts, group\u003d\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_85e12b9d","line":77,"in_reply_to":"bae84128_efb82de8","updated":"2016-02-22 06:25:25.000000000","message":"Done","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"81f6eab14af3ba0eaeb59f8d9c6c3e0fc19e93ce","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \u0027supported by ironic.\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027glance_cafile\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Path to the SSL certificate that allows to perform \u0027"},{"line_number":77,"context_line":"                      \u0027secure SSL requests to glance. It is used only if\u0027"},{"line_number":78,"context_line":"                      \u0027glance_api_insecure is False.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_71965bf1","line":77,"updated":"2016-02-22 12:13:08.000000000","message":"nit: space required before trailing \u0027","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"de8a5a635b87ed05ae41248869c72567b1c0a971","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \u0027supported by ironic.\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027glance_cafile\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Path to the SSL certificate that allows to perform \u0027"},{"line_number":77,"context_line":"                      \u0027secure SSL requests to glance. It is used only if\u0027"},{"line_number":78,"context_line":"                      \u0027glance_api_insecure is False.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_7df0ac91","line":77,"in_reply_to":"bae84128_71965bf1","updated":"2016-02-23 15:11:06.000000000","message":"The wording here implies that one cannot make secure calls to Glance without setting this option, which of course is not true.\n\nMaybe we can reword with something like \"Optional path to a CA certificate bundle to be used to validate the SSL certificate served by glance.\" What do others think?","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"90491fb647835f2cc19b558cdca405448bc46ed9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \u0027supported by ironic.\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027glance_cafile\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Path to the SSL certificate that allows to perform \u0027"},{"line_number":77,"context_line":"                      \u0027secure SSL requests to glance. It is used only if\u0027"},{"line_number":78,"context_line":"                      \u0027glance_api_insecure is False.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_1edfd70d","line":77,"in_reply_to":"bae84128_7df0ac91","updated":"2016-02-23 15:36:18.000000000","message":"++ It\u0027s better worded","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b9f165100facb70323a5ddb65d0d6bdb8fa7fa2e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \u0027supported by ironic.\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027glance_cafile\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Path to the SSL certificate that allows to perform \u0027"},{"line_number":77,"context_line":"                      \u0027secure SSL requests to glance. It is used only if\u0027"},{"line_number":78,"context_line":"                      \u0027glance_api_insecure is False.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_4e006d66","line":77,"in_reply_to":"bae84128_7df0ac91","updated":"2016-02-24 06:20:19.000000000","message":"Thanks, I will make the change. Can you explain how the secure https communication happens without passing the certificate?","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"ceed263cb3d23bbd08ad56d9677712f30d420382","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \u0027supported by ironic.\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027glance_cafile\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Optional path to a CA certificate bundle to be used to \u0027"},{"line_number":77,"context_line":"                      \u0027validate the SSL certificate served by glance. It is \u0027"},{"line_number":78,"context_line":"                      \u0027used only if glance_api_insecure is False.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"CONF.register_opts(glance_opts, group\u003d\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_54bf5b60","line":78,"range":{"start_line":77,"start_character":69,"end_line":78,"end_character":65},"updated":"2016-03-04 04:32:53.000000000","message":"s/ \u0027It is used only if glance_api_insecure is False\u0027/ It is used when \"glance_api_insecure\" is set to False /","commit_id":"969c79114857cb2bce54f9687775346a41a6eb01"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"2e58b9c4cb59ff0c0a51408f48794252ba5d2bb8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                      \u0027supported by ironic.\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027glance_cafile\u0027,"},{"line_number":76,"context_line":"               help\u003d_(\u0027Optional path to a CA certificate bundle to be used to \u0027"},{"line_number":77,"context_line":"                      \u0027validate the SSL certificate served by glance. It is \u0027"},{"line_number":78,"context_line":"                      \u0027used only if glance_api_insecure is False.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"CONF.register_opts(glance_opts, group\u003d\u0027glance\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_04a756bd","line":78,"range":{"start_line":77,"start_character":69,"end_line":78,"end_character":65},"in_reply_to":"7af24918_54bf5b60","updated":"2016-03-04 10:01:50.000000000","message":"Done","commit_id":"969c79114857cb2bce54f9687775346a41a6eb01"}],"ironic/tests/unit/common/test_glance_service.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dbb54a18d0dd494542cb7897ea3a4188ab5a353","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        self.service.client \u003d None"},{"line_number":625,"context_line":"        params \u003d {\u0027image_href\u0027: \u0027https://123.123.123.123:9292/image_uuid\u0027}"},{"line_number":626,"context_line":"        self.config(auth_strategy\u003d\u0027keystone\u0027, group\u003d\u0027glance\u0027)"},{"line_number":627,"context_line":"        self.config(glance_api_insecure\u003d\u0027True\u0027, group\u003d\u0027glance\u0027)"},{"line_number":628,"context_line":"        wrapped_func \u003d base_image_service.check_image_service(func)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_d02c4e04","line":627,"range":{"start_line":627,"start_character":40,"end_line":627,"end_character":47},"updated":"2016-02-17 14:29:23.000000000","message":"Its Boolean. Should be without quotes\ns/ \u0027True\u0027/ True /","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"0818e7256f946372545eb8ee8ccd1e103ec7f2a5","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        self.service.client \u003d None"},{"line_number":625,"context_line":"        params \u003d {\u0027image_href\u0027: \u0027https://123.123.123.123:9292/image_uuid\u0027}"},{"line_number":626,"context_line":"        self.config(auth_strategy\u003d\u0027keystone\u0027, group\u003d\u0027glance\u0027)"},{"line_number":627,"context_line":"        self.config(glance_api_insecure\u003d\u0027True\u0027, group\u003d\u0027glance\u0027)"},{"line_number":628,"context_line":"        wrapped_func \u003d base_image_service.check_image_service(func)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_dd00b504","line":627,"range":{"start_line":627,"start_character":40,"end_line":627,"end_character":47},"in_reply_to":"dae33548_d02c4e04","updated":"2016-02-19 04:52:53.000000000","message":"Done","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dbb54a18d0dd494542cb7897ea3a4188ab5a353","unresolved":false,"context_lines":[{"line_number":628,"context_line":"        wrapped_func \u003d base_image_service.check_image_service(func)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"},{"line_number":631,"context_line":"                         wrapped_func(self.service, **params))"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"},{"line_number":634,"context_line":"        def func(service, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_0d817dc3","line":631,"range":{"start_line":631,"start_character":25,"end_line":631,"end_character":37},"updated":"2016-02-17 14:29:23.000000000","message":"Need to validate that params do not contain \u0027cacert\u0027 and has  \u0027insecure\u0027 set to True.","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"0818e7256f946372545eb8ee8ccd1e103ec7f2a5","unresolved":false,"context_lines":[{"line_number":628,"context_line":"        wrapped_func \u003d base_image_service.check_image_service(func)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"},{"line_number":631,"context_line":"                         wrapped_func(self.service, **params))"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"},{"line_number":634,"context_line":"        def func(service, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_e04b175e","line":631,"range":{"start_line":631,"start_character":25,"end_line":631,"end_character":37},"in_reply_to":"dae33548_0d817dc3","updated":"2016-02-19 04:52:53.000000000","message":"Done","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"84f55b4458b930c50f776888d6bd17042a65eabb","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"},{"line_number":631,"context_line":"                         wrapped_func(self.service, **params))"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"},{"line_number":634,"context_line":"        def func(service, *args, **kwargs):"},{"line_number":635,"context_line":"            return (self.endpoint, args, kwargs)"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_3ebab20a","line":633,"range":{"start_line":633,"start_character":8,"end_line":633,"end_character":58},"updated":"2016-02-17 12:38:22.000000000","message":"this test doesn\u0027t check your changes, and my guess it will pass w/o them.","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dbb54a18d0dd494542cb7897ea3a4188ab5a353","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"},{"line_number":631,"context_line":"                         wrapped_func(self.service, **params))"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"},{"line_number":634,"context_line":"        def func(service, *args, **kwargs):"},{"line_number":635,"context_line":"            return (self.endpoint, args, kwargs)"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_ad31715c","line":633,"range":{"start_line":633,"start_character":8,"end_line":633,"end_character":58},"in_reply_to":"dae33548_3ebab20a","updated":"2016-02-17 14:29:23.000000000","message":"+1\nNeed to validate that params contain \u0027cacert\u0027 with value of\n\u0027/path/to/certfile\u0027 and has  \u0027insecure\u0027 set to False.","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"0818e7256f946372545eb8ee8ccd1e103ec7f2a5","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"},{"line_number":631,"context_line":"                         wrapped_func(self.service, **params))"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"},{"line_number":634,"context_line":"        def func(service, *args, **kwargs):"},{"line_number":635,"context_line":"            return (self.endpoint, args, kwargs)"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_80304bea","line":633,"range":{"start_line":633,"start_character":8,"end_line":633,"end_character":58},"in_reply_to":"dae33548_ad31715c","updated":"2016-02-19 04:52:53.000000000","message":"Done","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5dbb54a18d0dd494542cb7897ea3a4188ab5a353","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        self.service.client \u003d None"},{"line_number":638,"context_line":"        params \u003d {\u0027image_href\u0027: \u0027https://123.123.123.123:9292/image_uuid\u0027}"},{"line_number":639,"context_line":"        self.config(auth_strategy\u003d\u0027keystone\u0027, group\u003d\u0027glance\u0027)"},{"line_number":640,"context_line":"        self.config(glance_api_insecure\u003d\u0027False\u0027, group\u003d\u0027glance\u0027)"},{"line_number":641,"context_line":"        self.config(glance_cafile\u003d\u0027/path/to/certfile\u0027, group\u003d\u0027glance\u0027)"},{"line_number":642,"context_line":"        wrapped_func \u003d base_image_service.check_image_service(func)"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_901e46b9","line":640,"range":{"start_line":640,"start_character":40,"end_line":640,"end_character":47},"updated":"2016-02-17 14:29:23.000000000","message":"Its Boolean. Should be without quotes\ns/ \u0027False\u0027/ False /","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"0818e7256f946372545eb8ee8ccd1e103ec7f2a5","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        self.service.client \u003d None"},{"line_number":638,"context_line":"        params \u003d {\u0027image_href\u0027: \u0027https://123.123.123.123:9292/image_uuid\u0027}"},{"line_number":639,"context_line":"        self.config(auth_strategy\u003d\u0027keystone\u0027, group\u003d\u0027glance\u0027)"},{"line_number":640,"context_line":"        self.config(glance_api_insecure\u003d\u0027False\u0027, group\u003d\u0027glance\u0027)"},{"line_number":641,"context_line":"        self.config(glance_cafile\u003d\u0027/path/to/certfile\u0027, group\u003d\u0027glance\u0027)"},{"line_number":642,"context_line":"        wrapped_func \u003d base_image_service.check_image_service(func)"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_600bbe24","line":640,"range":{"start_line":640,"start_character":40,"end_line":640,"end_character":47},"in_reply_to":"dae33548_901e46b9","updated":"2016-02-19 04:52:53.000000000","message":"Done","commit_id":"14d43e6941fa808020bceb447ada0e84290d93e6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1f7659740080b4341ad1972af3ce3d8631e4bb51","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        self.config(glance_api_insecure\u003dTrue, group\u003d\u0027glance\u0027)"},{"line_number":640,"context_line":"        wrapped_func \u003d base_image_service.check_image_service(func)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        with mock.patch.object(base_image_service, \u0027client\u0027) as client_mock:"},{"line_number":643,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":644,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":645,"context_line":"            self.assertEqual(True, kwargs.get(\u0027insecure\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_dd623c16","line":642,"range":{"start_line":642,"start_character":23,"end_line":642,"end_character":24},"updated":"2016-02-19 12:05:03.000000000","message":"nit: using decorator @mock.patch.object would be more consistency with other code","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b4de20aa97230bcc9e0f211ec1771f58a2cfefb1","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        self.config(glance_api_insecure\u003dTrue, group\u003d\u0027glance\u0027)"},{"line_number":640,"context_line":"        wrapped_func \u003d base_image_service.check_image_service(func)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        with mock.patch.object(base_image_service, \u0027client\u0027) as client_mock:"},{"line_number":643,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":644,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":645,"context_line":"            self.assertEqual(True, kwargs.get(\u0027insecure\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_e59597e4","line":642,"range":{"start_line":642,"start_character":23,"end_line":642,"end_character":24},"in_reply_to":"bae84128_dd623c16","updated":"2016-02-22 06:25:25.000000000","message":"Done","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"1f7659740080b4341ad1972af3ce3d8631e4bb51","unresolved":false,"context_lines":[{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        with mock.patch.object(base_image_service, \u0027client\u0027) as client_mock:"},{"line_number":643,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":644,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":645,"context_line":"            self.assertEqual(True, kwargs.get(\u0027insecure\u0027))"},{"line_number":646,"context_line":"            self.assertFalse(kwargs.get(\u0027cacert\u0027))"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_8017abec","line":644,"range":{"start_line":644,"start_character":0,"end_line":644,"end_character":62},"updated":"2016-02-19 12:05:03.000000000","message":"nit:imo client_mock.assert_called_once_with(all args) would be better than separate check","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b4de20aa97230bcc9e0f211ec1771f58a2cfefb1","unresolved":false,"context_lines":[{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        with mock.patch.object(base_image_service, \u0027client\u0027) as client_mock:"},{"line_number":643,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":644,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":645,"context_line":"            self.assertEqual(True, kwargs.get(\u0027insecure\u0027))"},{"line_number":646,"context_line":"            self.assertFalse(kwargs.get(\u0027cacert\u0027))"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_25a01f43","line":644,"range":{"start_line":644,"start_character":0,"end_line":644,"end_character":62},"in_reply_to":"bae84128_8017abec","updated":"2016-02-22 06:25:25.000000000","message":"Done","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cdc3d540b120ecdd9b98fadd773612bdf52dbafe","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        with mock.patch.object(base_image_service, \u0027client\u0027) as client_mock:"},{"line_number":643,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":644,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":645,"context_line":"            self.assertEqual(True, kwargs.get(\u0027insecure\u0027))"},{"line_number":646,"context_line":"            self.assertFalse(kwargs.get(\u0027cacert\u0027))"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_fa862912","line":645,"updated":"2016-02-19 10:39:47.000000000","message":"self.assertTrue(kwargs.get(\u0027insecure\u0027))","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b4de20aa97230bcc9e0f211ec1771f58a2cfefb1","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        with mock.patch.object(base_image_service, \u0027client\u0027) as client_mock:"},{"line_number":643,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":644,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":645,"context_line":"            self.assertEqual(True, kwargs.get(\u0027insecure\u0027))"},{"line_number":646,"context_line":"            self.assertFalse(kwargs.get(\u0027cacert\u0027))"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_6526a7cf","line":645,"in_reply_to":"bae84128_fa862912","updated":"2016-02-22 06:25:25.000000000","message":"Checking this using mock.assert_called_once_with","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6099d48841861c2b2a8aec24ce29b34ebd0524ba","unresolved":false,"context_lines":[{"line_number":643,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":644,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":645,"context_line":"            self.assertEqual(True, kwargs.get(\u0027insecure\u0027))"},{"line_number":646,"context_line":"            self.assertFalse(kwargs.get(\u0027cacert\u0027))"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"},{"line_number":649,"context_line":"        def func(service, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_52261269","line":646,"range":{"start_line":646,"start_character":12,"end_line":646,"end_character":50},"updated":"2016-02-19 13:28:20.000000000","message":"should explicitly check that \u0027cacert\u0027 not in kwargs instead of the value is False.","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b4de20aa97230bcc9e0f211ec1771f58a2cfefb1","unresolved":false,"context_lines":[{"line_number":643,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":644,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":645,"context_line":"            self.assertEqual(True, kwargs.get(\u0027insecure\u0027))"},{"line_number":646,"context_line":"            self.assertFalse(kwargs.get(\u0027cacert\u0027))"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_get_image_service__no_client_set_https_secure(self):"},{"line_number":649,"context_line":"        def func(service, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_e518f786","line":646,"range":{"start_line":646,"start_character":12,"end_line":646,"end_character":50},"in_reply_to":"bae84128_52261269","updated":"2016-02-22 06:25:25.000000000","message":"Checking this using mock.assert_called_once_with","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cdc3d540b120ecdd9b98fadd773612bdf52dbafe","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        with mock.patch.object(base_image_service, \u0027client\u0027) as client_mock:"},{"line_number":660,"context_line":"            wrapped_func(self.service, **params)"},{"line_number":661,"context_line":"            client_args, kwargs \u003d client_mock.Client.call_args"},{"line_number":662,"context_line":"            self.assertEqual(False, kwargs.get(\u0027insecure\u0027))"},{"line_number":663,"context_line":"            self.assertEqual(\u0027/path/to/certfile\u0027, kwargs.get(\u0027cacert\u0027))"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_babae1be","line":662,"updated":"2016-02-19 10:39:47.000000000","message":"self.assertFalse(kwargs.get(\u0027insecure\u0027))","commit_id":"02783a152aeaed0358e621ae14971966516d63f6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"d7f7c2ac343b94a74114ebc7a25f878a6fc2a799","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"},{"line_number":630,"context_line":"                         wrapped_func(self.service, **params))"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    @mock.patch.object(base_image_service, \u0027client\u0027, autospec\u003dTrue)"},{"line_number":633,"context_line":"    def test_get_image_service__no_client_set_https_insecure(self,"},{"line_number":634,"context_line":"                                                             client_mock):"},{"line_number":635,"context_line":"        def func(service, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_b8004d03","line":632,"updated":"2016-02-24 11:26:05.000000000","message":"What about positive cases?","commit_id":"969c79114857cb2bce54f9687775346a41a6eb01"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"17cdbb46ee05747df24b75bd71780c868cbdf93f","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        self.assertEqual((\u0027https://123.123.123.123:9292\u0027, (), params),"},{"line_number":630,"context_line":"                         wrapped_func(self.service, **params))"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    @mock.patch.object(base_image_service, \u0027client\u0027, autospec\u003dTrue)"},{"line_number":633,"context_line":"    def test_get_image_service__no_client_set_https_insecure(self,"},{"line_number":634,"context_line":"                                                             client_mock):"},{"line_number":635,"context_line":"        def func(service, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_9e44514a","line":632,"in_reply_to":"bae84128_b8004d03","updated":"2016-02-24 11:38:58.000000000","message":"I am just checking whether client_mock.Client is called with the exact parameters or not since I am adding a new parameter. What do you meant by positive case here?","commit_id":"969c79114857cb2bce54f9687775346a41a6eb01"}],"releasenotes/notes/bug-1548086-ed88646061b88faf.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"de8a5a635b87ed05ae41248869c72567b1c0a971","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to pass CA cerificate to enable secured HTTPS commnication"},{"line_number":4,"context_line":"    between ironic and glance."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a [glance]glance_cafile configuration option to enable support to"},{"line_number":7,"context_line":"    pass certificate for secured communication. It is used only when"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bae84128_dd37384b","line":4,"updated":"2016-02-23 15:11:06.000000000","message":"Perhaps similar rewording here. Also s/cerificate/certificate/","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b6fdbacb357401bc84413a0bf7913b4db4ceac19","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to pass CA cerificate to enable secured HTTPS commnication"},{"line_number":4,"context_line":"    between ironic and glance."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a [glance]glance_cafile configuration option to enable support to"},{"line_number":7,"context_line":"    pass certificate for secured communication. It is used only when"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bae84128_daa6f0ac","line":4,"in_reply_to":"bae84128_dd37384b","updated":"2016-02-24 09:10:16.000000000","message":"Done","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"de8a5a635b87ed05ae41248869c72567b1c0a971","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    between ironic and glance."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a [glance]glance_cafile configuration option to enable support to"},{"line_number":7,"context_line":"    pass certificate for secured communication. It is used only when"},{"line_number":8,"context_line":"    [glance]glance_api_insecure configuration option is False."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bae84128_9d1810d5","line":7,"updated":"2016-02-23 15:11:06.000000000","message":"Ditto","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b6fdbacb357401bc84413a0bf7913b4db4ceac19","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    between ironic and glance."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a [glance]glance_cafile configuration option to enable support to"},{"line_number":7,"context_line":"    pass certificate for secured communication. It is used only when"},{"line_number":8,"context_line":"    [glance]glance_api_insecure configuration option is False."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bae84128_baa16c96","line":7,"in_reply_to":"bae84128_9d1810d5","updated":"2016-02-24 09:10:16.000000000","message":"Done","commit_id":"0999ba6f7b3784ef7c29fe15054ff5b015202b7b"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"18ea65b832715e296cf23c534afbcf5654fb3e2f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds support to pass a optional CA certificate to be used to validate the"},{"line_number":4,"context_line":"    SSL certificate served by glance for secured https communication between"},{"line_number":5,"context_line":"    Glance and Ironic."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Adds a [glance]glance_cafile configuration option to pass a optional"},{"line_number":8,"context_line":"    certificate for secured https communication. It is used only when"},{"line_number":9,"context_line":"    [glance]glance_api_insecure configuration option is False."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7af24918_6f70c0a4","line":6,"updated":"2016-03-04 04:35:58.000000000","message":"Do we need the \u0027upgrade\u0027 section?","commit_id":"969c79114857cb2bce54f9687775346a41a6eb01"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9336601c5aaccc489302d7cd92de0f81e6140186","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds support to pass a optional CA certificate to be used to validate the"},{"line_number":4,"context_line":"    SSL certificate served by glance for secured https communication between"},{"line_number":5,"context_line":"    Glance and Ironic."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Adds a [glance]glance_cafile configuration option to pass a optional"},{"line_number":8,"context_line":"    certificate for secured https communication. It is used only when"},{"line_number":9,"context_line":"    [glance]glance_api_insecure configuration option is False."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7af24918_53fdaa6c","line":6,"in_reply_to":"7af24918_6f70c0a4","updated":"2016-03-04 09:10:23.000000000","message":"Since a new configuration variable is introduced I think we need to add this note under update section.Is that right?","commit_id":"969c79114857cb2bce54f9687775346a41a6eb01"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"499db7ab821c365319452f19a2c8f8e8d7cb6041","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to pass a optional CA certificate to be used to validate the"},{"line_number":4,"context_line":"    SSL certificate served by glance for secured https communication between"},{"line_number":5,"context_line":"    Glance and Ironic."},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7af24918_8778532d","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":50},"updated":"2016-03-05 14:18:39.000000000","message":"Mention [glance]glance_cafile configuration here as well.","commit_id":"e9492f6192325a6efe0e0d9ed7f9c46c7f177c46"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"846c7a299ea644c3752ec1b7f017726cb2aa2b18","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to pass a optional CA certificate to be used to validate the"},{"line_number":4,"context_line":"    SSL certificate served by glance for secured https communication between"},{"line_number":5,"context_line":"    Glance and Ironic."},{"line_number":6,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5aef4532_c6e1d3d2","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":50},"in_reply_to":"7af24918_8778532d","updated":"2016-03-07 10:11:51.000000000","message":"Done","commit_id":"e9492f6192325a6efe0e0d9ed7f9c46c7f177c46"}]}
