)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6617c55b0bb73a7b3853b84aef3192e434d57697","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add restrictions for changing portgroup-node association"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Prevent updates to portgroup.node_uuid if the node is not in"},{"line_number":10,"context_line":"a provision_state that would allow updates to its ports."},{"line_number":11,"context_line":"* Disallow updates to the portgroup.node_uuid field if there"},{"line_number":12,"context_line":"are any ports associated to the portgroup."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_2f2b1a35","line":10,"updated":"2016-06-09 21:59:31.000000000","message":"and what provision states allow updates? I think that info should be mentioned in this commit message.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6617c55b0bb73a7b3853b84aef3192e434d57697","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* Prevent updates to portgroup.node_uuid if the node is not in"},{"line_number":10,"context_line":"a provision_state that would allow updates to its ports."},{"line_number":11,"context_line":"* Disallow updates to the portgroup.node_uuid field if there"},{"line_number":12,"context_line":"are any ports associated to the portgroup."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia7ef313ab7a31c0ee678a7f4c088b92feefff988"},{"line_number":15,"context_line":"Closes-Bug: #1546371"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_af1f0a08","line":12,"updated":"2016-06-09 21:59:31.000000000","message":"nit: s/to/with/","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"}],"ironic/conductor/manager.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"429e39047f5d39602d4cef4c11e4e77fb01ff339","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"                # MANAGEABLE/INSPECTING/ENROLL provisioning state or in"},{"line_number":1769,"context_line":"                # maintenance mode, otherwise InvalidState is raised."},{"line_number":1770,"context_line":"                allowed_update_states \u003d [states.ENROLL,"},{"line_number":1771,"context_line":"                                         states.INSPECTING,"},{"line_number":1772,"context_line":"                                         states.MANAGEABLE]"},{"line_number":1773,"context_line":"                if (node.provision_state not in allowed_update_states"},{"line_number":1774,"context_line":"                    and not node.maintenance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_f5986ec2","line":1771,"updated":"2016-02-29 11:51:01.000000000","message":"AFAIU allowing updates in inspecting state is exactly for the inspector to be able to update it. can we somehow ensure that users can not do it themselves when inspection is ongoing? most probably not (at least not that easy), but this then should be documented.","commit_id":"93b56c7e6da5717b9fafd0ef78a27c8392e70d7f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2e46ef20162a53ee8672af32959e76da05ed95fb","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                    portgroup_uuid)"},{"line_number":1790,"context_line":"                if associated_ports:"},{"line_number":1791,"context_line":"                    action \u003d _(\"Portgroup %(portgroup)s can not be associated \""},{"line_number":1792,"context_line":"                               \"to node %(node)s while it\u0027s ports associated \""},{"line_number":1793,"context_line":"                               \"with another node.\")"},{"line_number":1794,"context_line":"                    raise exception.PortgroupNotEmpty("},{"line_number":1795,"context_line":"                        action % {\u0027portgroup\u0027: portgroup_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_8bcf8aaf","line":1792,"updated":"2016-05-29 20:15:47.000000000","message":"This message is misleading, as you may update all the ports in the portgroup to belong to another node (btw seems to be a bug, you can update node-port association in ACTIVE), but PortgroupNotEmpty will still be raised.","commit_id":"01b1de88e85ab1d81c92143e60bfbd6b9005f181"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"8fc408ae8311a80ab1d1011452e3e38f0ad82a91","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                    portgroup_uuid)"},{"line_number":1790,"context_line":"                if associated_ports:"},{"line_number":1791,"context_line":"                    action \u003d _(\"Portgroup %(portgroup)s can not be associated \""},{"line_number":1792,"context_line":"                               \"to node %(node)s while it\u0027s ports associated \""},{"line_number":1793,"context_line":"                               \"with another node.\")"},{"line_number":1794,"context_line":"                    raise exception.PortgroupNotEmpty("},{"line_number":1795,"context_line":"                        action % {\u0027portgroup\u0027: portgroup_uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_0a087d2b","line":1792,"in_reply_to":"9abb7d3a_8bcf8aaf","updated":"2016-05-31 06:24:41.000000000","message":"Thanks for the comments vdrok, will refine the message here and file a bug for that you can update node-port association in ACTIVE provision state.","commit_id":"01b1de88e85ab1d81c92143e60bfbd6b9005f181"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"97d4c039244b58b598e2d3184f327ce66a105870","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"                 failed."},{"line_number":1749,"context_line":"        :raises: PortgroupMACAlreadyExists if the update is setting a MAC which"},{"line_number":1750,"context_line":"                 is registered on another portgroup already."},{"line_number":1751,"context_line":"        :raises: InvalidState if portgroup-node association are updated while"},{"line_number":1752,"context_line":"                 node not in a MANAGEABLE or ENROLL or INSPECTING state or not"},{"line_number":1753,"context_line":"                 in MAINTENANCE mode."},{"line_number":1754,"context_line":"        :raises: PortgroupNotEmpty if portgroup is not empty"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_7eacdd8c","line":1751,"updated":"2016-06-02 09:26:17.000000000","message":"nit - is updated","commit_id":"ac5e76a2ada00a698e5b8fab9efd9c398f037c8c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"457dc7811c70ceadf0904fb0e4f90a0177b8872b","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"                 failed."},{"line_number":1749,"context_line":"        :raises: PortgroupMACAlreadyExists if the update is setting a MAC which"},{"line_number":1750,"context_line":"                 is registered on another portgroup already."},{"line_number":1751,"context_line":"        :raises: InvalidState if portgroup-node association are updated while"},{"line_number":1752,"context_line":"                 node not in a MANAGEABLE or ENROLL or INSPECTING state or not"},{"line_number":1753,"context_line":"                 in MAINTENANCE mode."},{"line_number":1754,"context_line":"        :raises: PortgroupNotEmpty if portgroup is not empty"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_a9073180","line":1751,"in_reply_to":"9abb7d3a_7eacdd8c","updated":"2016-06-02 09:39:30.000000000","message":"Done","commit_id":"ac5e76a2ada00a698e5b8fab9efd9c398f037c8c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6617c55b0bb73a7b3853b84aef3192e434d57697","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"                                  purpose\u003dlock_purpose) as task:"},{"line_number":1763,"context_line":"            node \u003d task.node"},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"            if \u0027node_id\u0027 in portgroup_obj.obj_what_changed():"},{"line_number":1766,"context_line":"                # NOTE(zhenguo): If portgroup update is modifying the"},{"line_number":1767,"context_line":"                # portgroup-node association then node should be in"},{"line_number":1768,"context_line":"                # MANAGEABLE/INSPECTING/ENROLL provisioning state or in"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_52ec4d8f","line":1765,"updated":"2016-06-09 21:59:31.000000000","message":"I had two thoughts: 1. whether it made more sense to do these checks at the API layer; or 2. whether it made sense to do these checks when the node is not locked.\n\nBut the approach here seems the easiest and I guess one could optimize it later if it seems to be a bottleneck.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c5098c5b48f860d3e5654a8e9c1404391a86f47d","unresolved":false,"context_lines":[{"line_number":1769,"context_line":"                # maintenance mode, otherwise InvalidState is raised."},{"line_number":1770,"context_line":"                allowed_update_states \u003d [states.ENROLL,"},{"line_number":1771,"context_line":"                                         states.INSPECTING,"},{"line_number":1772,"context_line":"                                         states.MANAGEABLE]"},{"line_number":1773,"context_line":"                if (node.provision_state not in allowed_update_states"},{"line_number":1774,"context_line":"                    and not node.maintenance):"},{"line_number":1775,"context_line":"                    action \u003d _(\"Portgroup %(portgroup)s can not be associated \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_922195b7","line":1772,"updated":"2016-06-09 22:06:58.000000000","message":"both port and portgroup updates check for these node states, so it might be a good idea to not duplicate it in case the list of states changes in the future.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6617c55b0bb73a7b3853b84aef3192e434d57697","unresolved":false,"context_lines":[{"line_number":1778,"context_line":""},{"line_number":1779,"context_line":"                    raise exception.InvalidState("},{"line_number":1780,"context_line":"                        action % {\u0027portgroup\u0027: portgroup_uuid,"},{"line_number":1781,"context_line":"                                  \u0027node\u0027: task.node.uuid,"},{"line_number":1782,"context_line":"                                  \u0027allowed\u0027: \u0027, \u0027.join(allowed_update_states)})"},{"line_number":1783,"context_line":""},{"line_number":1784,"context_line":"                # NOTE(zhenguo): If portgroup update is modifying the"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_0f2f3ef7","line":1781,"updated":"2016-06-09 21:59:31.000000000","message":"nit: or node.uuid","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"b9a1e082dbe0ed03c118b68e0f4f732cd524209a","unresolved":false,"context_lines":[{"line_number":1778,"context_line":""},{"line_number":1779,"context_line":"                    raise exception.InvalidState("},{"line_number":1780,"context_line":"                        action % {\u0027portgroup\u0027: portgroup_uuid,"},{"line_number":1781,"context_line":"                                  \u0027node\u0027: task.node.uuid,"},{"line_number":1782,"context_line":"                                  \u0027allowed\u0027: \u0027, \u0027.join(allowed_update_states)})"},{"line_number":1783,"context_line":""},{"line_number":1784,"context_line":"                # NOTE(zhenguo): If portgroup update is modifying the"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_338fb524","line":1781,"in_reply_to":"7aa08908_0f2f3ef7","updated":"2016-06-12 07:22:02.000000000","message":"Done","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6617c55b0bb73a7b3853b84aef3192e434d57697","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                    portgroup_uuid)"},{"line_number":1790,"context_line":"                if associated_ports:"},{"line_number":1791,"context_line":"                    action \u003d _(\"Portgroup %(portgroup)s can not be associated \""},{"line_number":1792,"context_line":"                               \"to node %(node)s while it\u0027s not empty.\")"},{"line_number":1793,"context_line":"                    raise exception.PortgroupNotEmpty("},{"line_number":1794,"context_line":"                        action % {\u0027portgroup\u0027: portgroup_uuid,"},{"line_number":1795,"context_line":"                                  \u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_8f5a0e4f","line":1792,"updated":"2016-06-09 21:59:31.000000000","message":"s/associated to/associated with/\n\nit isn\u0027t clear what \"it\u0027s not empty\" refers to -- is it the node or the Portgroup? How about something like s/while it\u0027s not empty/because there are ports associated with this portgroup/","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"b9a1e082dbe0ed03c118b68e0f4f732cd524209a","unresolved":false,"context_lines":[{"line_number":1789,"context_line":"                    portgroup_uuid)"},{"line_number":1790,"context_line":"                if associated_ports:"},{"line_number":1791,"context_line":"                    action \u003d _(\"Portgroup %(portgroup)s can not be associated \""},{"line_number":1792,"context_line":"                               \"to node %(node)s while it\u0027s not empty.\")"},{"line_number":1793,"context_line":"                    raise exception.PortgroupNotEmpty("},{"line_number":1794,"context_line":"                        action % {\u0027portgroup\u0027: portgroup_uuid,"},{"line_number":1795,"context_line":"                                  \u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f3f24d99","line":1792,"in_reply_to":"7aa08908_8f5a0e4f","updated":"2016-06-12 07:22:02.000000000","message":"thanks Ruby for the suggestion, that would be more clear.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6617c55b0bb73a7b3853b84aef3192e434d57697","unresolved":false,"context_lines":[{"line_number":1792,"context_line":"                               \"to node %(node)s while it\u0027s not empty.\")"},{"line_number":1793,"context_line":"                    raise exception.PortgroupNotEmpty("},{"line_number":1794,"context_line":"                        action % {\u0027portgroup\u0027: portgroup_uuid,"},{"line_number":1795,"context_line":"                                  \u0027node\u0027: task.node.uuid})"},{"line_number":1796,"context_line":""},{"line_number":1797,"context_line":"            if \u0027address\u0027 in portgroup_obj.obj_what_changed():"},{"line_number":1798,"context_line":"                vif \u003d portgroup_obj.extra.get(\u0027vif_portgroup_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_af0b8a2a","line":1795,"updated":"2016-06-09 21:59:31.000000000","message":"nit: s/task.node/node/","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"b9a1e082dbe0ed03c118b68e0f4f732cd524209a","unresolved":false,"context_lines":[{"line_number":1792,"context_line":"                               \"to node %(node)s while it\u0027s not empty.\")"},{"line_number":1793,"context_line":"                    raise exception.PortgroupNotEmpty("},{"line_number":1794,"context_line":"                        action % {\u0027portgroup\u0027: portgroup_uuid,"},{"line_number":1795,"context_line":"                                  \u0027node\u0027: task.node.uuid})"},{"line_number":1796,"context_line":""},{"line_number":1797,"context_line":"            if \u0027address\u0027 in portgroup_obj.obj_what_changed():"},{"line_number":1798,"context_line":"                vif \u003d portgroup_obj.extra.get(\u0027vif_portgroup_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_d3ed91b8","line":1795,"in_reply_to":"7aa08908_af0b8a2a","updated":"2016-06-12 07:22:02.000000000","message":"Done","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c5098c5b48f860d3e5654a8e9c1404391a86f47d","unresolved":false,"context_lines":[{"line_number":2918,"context_line":"            uuid\u003duuidutils.generate_uuid())"},{"line_number":2919,"context_line":"        mock_get_ports.return_value \u003d []"},{"line_number":2920,"context_line":""},{"line_number":2921,"context_line":"        self._start_service()"},{"line_number":2922,"context_line":""},{"line_number":2923,"context_line":"        portgroup.node_id \u003d update_node.id"},{"line_number":2924,"context_line":"        self.service.update_portgroup(self.context, portgroup)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_0d3466dc","line":2921,"updated":"2016-06-09 22:06:58.000000000","message":"why do you start the service here, but you don\u0027t make this call in the test above?","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"b9a1e082dbe0ed03c118b68e0f4f732cd524209a","unresolved":false,"context_lines":[{"line_number":2918,"context_line":"            uuid\u003duuidutils.generate_uuid())"},{"line_number":2919,"context_line":"        mock_get_ports.return_value \u003d []"},{"line_number":2920,"context_line":""},{"line_number":2921,"context_line":"        self._start_service()"},{"line_number":2922,"context_line":""},{"line_number":2923,"context_line":"        portgroup.node_id \u003d update_node.id"},{"line_number":2924,"context_line":"        self.service.update_portgroup(self.context, portgroup)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_d36751b5","line":2921,"in_reply_to":"7aa08908_0d3466dc","updated":"2016-06-12 07:22:02.000000000","message":"as the test above is in a invalid state to update portgroup, but we have to call dbapi get_ports_by_portgroup_id here, so need to _start_service() to init dbapi instance.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b24c6a3261a7ff74e8616c398b8a26a1ee6684ae","unresolved":false,"context_lines":[{"line_number":2918,"context_line":"            uuid\u003duuidutils.generate_uuid())"},{"line_number":2919,"context_line":"        mock_get_ports.return_value \u003d []"},{"line_number":2920,"context_line":""},{"line_number":2921,"context_line":"        self._start_service()"},{"line_number":2922,"context_line":""},{"line_number":2923,"context_line":"        portgroup.node_id \u003d update_node.id"},{"line_number":2924,"context_line":"        self.service.update_portgroup(self.context, portgroup)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_bd9b5265","line":2921,"in_reply_to":"7aa08908_d36751b5","updated":"2016-06-13 14:11:34.000000000","message":"It is inconsistent that this isn\u0027t called in the test above too, because what if the above test failed cuz this wasn\u0027t called and it happened to fail with the same expected outcome? In this case, it didn\u0027t (I don\u0027t think), but it could in some other case, so I think it is good to get into the habit of making unit tests that test similar things, as similar as possible. It also makes it easier for reviewers.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c5098c5b48f860d3e5654a8e9c1404391a86f47d","unresolved":false,"context_lines":[{"line_number":2962,"context_line":""},{"line_number":2963,"context_line":"        self._start_service()"},{"line_number":2964,"context_line":""},{"line_number":2965,"context_line":"        old_node_id \u003d portgroup.node_id"},{"line_number":2966,"context_line":"        portgroup.node_id \u003d update_node.id"},{"line_number":2967,"context_line":"        exc \u003d self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":2968,"context_line":"                                self.service.update_portgroup,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_4d9aeec6","line":2965,"updated":"2016-06-09 22:06:58.000000000","message":"this is node.id, right? (from line 2953)","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"b9a1e082dbe0ed03c118b68e0f4f732cd524209a","unresolved":false,"context_lines":[{"line_number":2962,"context_line":""},{"line_number":2963,"context_line":"        self._start_service()"},{"line_number":2964,"context_line":""},{"line_number":2965,"context_line":"        old_node_id \u003d portgroup.node_id"},{"line_number":2966,"context_line":"        portgroup.node_id \u003d update_node.id"},{"line_number":2967,"context_line":"        exc \u003d self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":2968,"context_line":"                                self.service.update_portgroup,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_53e081fa","line":2965,"in_reply_to":"7aa08908_4d9aeec6","updated":"2016-06-12 07:22:02.000000000","message":"yes, it\u0027s the node.id from line 2953.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"}],"releasenotes/notes/restrict-portgroup-node-association-update-c0a777cb4ea05483.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"97d4c039244b58b598e2d3184f327ce66a105870","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add restrictions to change portgroup-node association."},{"line_number":4,"context_line":"    * Prevent updates to portgroup.node_uuid when node is not in"},{"line_number":5,"context_line":"      a provision_state that allow updates to its ports."},{"line_number":6,"context_line":"    * Disallow updates to the portgroup.node_uuid field if there"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_e90c993d","line":3,"updated":"2016-06-02 09:26:17.000000000","message":"This does not render as expected, you should do\n\n ---\n fixes:\n   - |\n     all the info formatted the same way.\n\nThen it should respect rst formatting.","commit_id":"ac5e76a2ada00a698e5b8fab9efd9c398f037c8c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"457dc7811c70ceadf0904fb0e4f90a0177b8872b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add restrictions to change portgroup-node association."},{"line_number":4,"context_line":"    * Prevent updates to portgroup.node_uuid when node is not in"},{"line_number":5,"context_line":"      a provision_state that allow updates to its ports."},{"line_number":6,"context_line":"    * Disallow updates to the portgroup.node_uuid field if there"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9abb7d3a_89a98d27","line":3,"in_reply_to":"9abb7d3a_e90c993d","updated":"2016-06-02 09:39:30.000000000","message":"Done","commit_id":"ac5e76a2ada00a698e5b8fab9efd9c398f037c8c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1959dd32160fb7aa44aff9304b36553935e37b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Prevent updates to portgroup.node_uuid when node is not in"},{"line_number":5,"context_line":"    a provision_state that allow updates to its ports."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Disallow updates to the portgroup.node_uuid field if there"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_acac5a8d","line":4,"updated":"2016-06-02 11:12:19.000000000","message":"There is no API for portgroups yet, but I think it wouldn\u0027t hurt to mention it.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6617c55b0bb73a7b3853b84aef3192e434d57697","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    a provision_state that allow updates to its ports."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Disallow updates to the portgroup.node_uuid field if there"},{"line_number":8,"context_line":"    are any ports associated to the portgroup."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_123be59d","line":8,"updated":"2016-06-09 21:59:31.000000000","message":"I don\u0027t think we should add this release note. This feature isn\u0027t exposed yet so the only way someone can encounter this bug is to use patches in flight.","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"b9a1e082dbe0ed03c118b68e0f4f732cd524209a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    a provision_state that allow updates to its ports."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Disallow updates to the portgroup.node_uuid field if there"},{"line_number":8,"context_line":"    are any ports associated to the portgroup."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7aa08908_133439f9","line":8,"in_reply_to":"7aa08908_123be59d","updated":"2016-06-12 07:22:02.000000000","message":"Done","commit_id":"3d894c86326e4b4f610a450d269af394f754a242"}]}
