)]}'
{"ironic/common/exception.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class VolumeTargetAlreadyExists(Conflict):"},{"line_number":195,"context_line":"    message \u003d _(\"A volume target with UUID %(uuid)s already exists\")"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"class InvalidUUID(Invalid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_da702bdf","line":195,"range":{"start_line":195,"start_character":4,"end_line":195,"end_character":11},"updated":"2016-05-19 09:33:27.000000000","message":"it should be a ``_msg_fmt`` property and not ``message`` property.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class VolumeTargetAlreadyExists(Conflict):"},{"line_number":195,"context_line":"    message \u003d _(\"A volume target with UUID %(uuid)s already exists\")"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"class InvalidUUID(Invalid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_dd537be0","line":195,"range":{"start_line":195,"start_character":4,"end_line":195,"end_character":11},"in_reply_to":"bab6814e_da702bdf","updated":"2016-06-14 16:30:21.000000000","message":"Done","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"class VolumeTargetNotFound(NotFound):"},{"line_number":329,"context_line":"    message \u003d _(\"A volume target %(target)s could not be found.\")"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class NoDriversLoaded(IronicException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_fa440f75","line":329,"range":{"start_line":329,"start_character":4,"end_line":329,"end_character":11},"updated":"2016-05-19 09:33:27.000000000","message":"ditto","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"class VolumeTargetNotFound(NotFound):"},{"line_number":329,"context_line":"    message \u003d _(\"A volume target %(target)s could not be found.\")"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class NoDriversLoaded(IronicException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_bd4e6f35","line":329,"range":{"start_line":329,"start_character":4,"end_line":329,"end_character":11},"in_reply_to":"bab6814e_fa440f75","updated":"2016-06-14 16:30:21.000000000","message":"Done","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"d1e66eace34ecdd65e4115c1b15e94115ef4d9c4","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class VolumeTargetAlreadyExists(Conflict):"},{"line_number":185,"context_line":"    _msg_fmt \u003d _(\"A volume target with UUID %(uuid)s already exists\")"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"class VolumeTargetValueAlreadyExists(Conflict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_863ef625","line":185,"range":{"start_line":185,"start_character":18,"end_line":185,"end_character":19},"updated":"2016-07-20 21:02:27.000000000","message":"Rephrase as \"Volume target...\" to be consistent with changes to earlier patches in this series.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class VolumeTargetAlreadyExists(Conflict):"},{"line_number":185,"context_line":"    _msg_fmt \u003d _(\"A volume target with UUID %(uuid)s already exists\")"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"class VolumeTargetValueAlreadyExists(Conflict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_d9c97f5c","line":185,"range":{"start_line":185,"start_character":18,"end_line":185,"end_character":19},"in_reply_to":"dada55a8_863ef625","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"d1e66eace34ecdd65e4115c1b15e94115ef4d9c4","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"class VolumeTargetValueAlreadyExists(Conflict):"},{"line_number":189,"context_line":"    _msg_fmt \u003d _(\"A volume target value for UUID %(uuid)s \""},{"line_number":190,"context_line":"                 \"already exists.\")"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_e647f2b9","line":189,"range":{"start_line":189,"start_character":18,"end_line":189,"end_character":19},"updated":"2016-07-20 21:02:27.000000000","message":"Ditto.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"class VolumeTargetValueAlreadyExists(Conflict):"},{"line_number":189,"context_line":"    _msg_fmt \u003d _(\"A volume target value for UUID %(uuid)s \""},{"line_number":190,"context_line":"                 \"already exists.\")"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_99af077d","line":189,"range":{"start_line":189,"start_character":18,"end_line":189,"end_character":19},"in_reply_to":"dada55a8_e647f2b9","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"d1e66eace34ecdd65e4115c1b15e94115ef4d9c4","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"class VolumeTargetNotFound(NotFound):"},{"line_number":324,"context_line":"    _msg_fmt \u003d _(\"A volume target %(target)s could not be found.\")"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"class NoDriversLoaded(IronicException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_660ae27a","line":324,"range":{"start_line":324,"start_character":18,"end_line":324,"end_character":19},"updated":"2016-07-20 21:02:27.000000000","message":"Ditto.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"class VolumeTargetNotFound(NotFound):"},{"line_number":324,"context_line":"    _msg_fmt \u003d _(\"A volume target %(target)s could not be found.\")"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"class NoDriversLoaded(IronicException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f9a9e37c","line":324,"range":{"start_line":324,"start_character":18,"end_line":324,"end_character":19},"in_reply_to":"dada55a8_660ae27a","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7ddd23d6a1b1fae2d1ad37a5bd9de51c4af0385c","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class VolumeTargetAlreadyExists(Conflict):"},{"line_number":172,"context_line":"    _msg_fmt \u003d _(\"Volume target with UUID %(uuid)s already exists\")"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"class VolumeTargetValueAlreadyExists(Conflict):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_9b3942a7","line":172,"range":{"start_line":172,"start_character":64,"end_line":172,"end_character":66},"updated":"2016-07-30 14:56:30.000000000","message":"A period is missing.","commit_id":"016cb90a74df6b99695606d5f3a98ad4f60dbe5d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"376d8f50f81fcb00467f650d2cd7fc8007da91f5","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class VolumeTargetAlreadyExists(Conflict):"},{"line_number":172,"context_line":"    _msg_fmt \u003d _(\"Volume target with UUID %(uuid)s already exists\")"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"class VolumeTargetValueAlreadyExists(Conflict):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_fc6bdcb4","line":172,"range":{"start_line":172,"start_character":64,"end_line":172,"end_character":66},"in_reply_to":"bacf61ea_9b3942a7","updated":"2016-08-01 20:34:03.000000000","message":"Done","commit_id":"016cb90a74df6b99695606d5f3a98ad4f60dbe5d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7eb7e51d44f4761d1d74ba1310942b79dccb7ad8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                 \"%(connector_id)s already exists.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"class VolumeTargetUuidAlreadyExists(Conflict):"},{"line_number":170,"context_line":"    _msg_fmt \u003d _(\"A volume target with UUID %(uuid)s already exists.\")"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_0e9c2868","line":169,"updated":"2016-11-25 11:40:36.000000000","message":"I prefer the way VolumeConnector are named. So this should be VolumeTargetAlreadyExists and the next one probably VolumeTargetExistsForNode or something like that","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54d92f4ac112dfeb04eda3e334ef6a1c20168fa7","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                 \"%(connector_id)s already exists.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"class VolumeTargetUuidAlreadyExists(Conflict):"},{"line_number":170,"context_line":"    _msg_fmt \u003d _(\"A volume target with UUID %(uuid)s already exists.\")"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_99d07b21","line":169,"in_reply_to":"5a74a57a_0e9c2868","updated":"2016-11-25 15:28:39.000000000","message":"Since this is UUID, I would say \"VolumeTargetAlreadyExists\" since this is raised when the same UUID is re-used.  For the other, \"VolumeTargetBootIndexAlreadyExists\" perhaps?","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5a32ef9b52295739986f78226dece5abd787af9f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                 \"%(connector_id)s already exists.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"class VolumeTargetUuidAlreadyExists(Conflict):"},{"line_number":170,"context_line":"    _msg_fmt \u003d _(\"A volume target with UUID %(uuid)s already exists.\")"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_56490db6","line":169,"in_reply_to":"5a74a57a_99d07b21","updated":"2016-11-28 16:38:22.000000000","message":"+ for VolumeTargetBootIndexAlreadyExists.","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7eb7e51d44f4761d1d74ba1310942b79dccb7ad8","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class VolumeTargetAlreadyExists(Conflict):"},{"line_number":174,"context_line":"    _msg_fmt \u003d _(\"A volume target with node ID \u0027%(node_id)s\u0027 and boot index \""},{"line_number":175,"context_line":"                 \"\u0027%(boot_index)s\u0027 already exists.\")"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_2e89e426","line":174,"updated":"2016-11-25 11:40:36.000000000","message":"let\u0027s rename node_id to node_uuid so that people do not try to pass node.id here (I hope you don\u0027t either)","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5a32ef9b52295739986f78226dece5abd787af9f","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class VolumeTargetAlreadyExists(Conflict):"},{"line_number":174,"context_line":"    _msg_fmt \u003d _(\"A volume target with node ID \u0027%(node_id)s\u0027 and boot index \""},{"line_number":175,"context_line":"                 \"\u0027%(boot_index)s\u0027 already exists.\")"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_d6a19d47","line":174,"in_reply_to":"5a74a57a_2e89e426","updated":"2016-11-28 16:38:22.000000000","message":"I removed the reference to the node.","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91fc6c91db3c0ab7c757fc8c7a60651c62af2b74","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class VolumeTargetBootIndexAlreadyExists(Conflict):"},{"line_number":174,"context_line":"    _msg_fmt \u003d _(\"A volume target with boot index \u0027%(boot_index)s\u0027 \""},{"line_number":175,"context_line":"                 \"(for the same node) already exists.\")"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class InvalidUUID(Invalid):"}],"source_content_type":"text/x-python","patch_set":41,"id":"5a74a57a_db7e1e69","line":175,"updated":"2016-11-28 18:59:39.000000000","message":"nit: I feel like this doesn\u0027t need to be a to be in ().","commit_id":"b3b49634810a8fbd05df0ca406fc2bb6da54a66e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"198b3e3cd7a852eaafa10b7fd63c2e0b578f1595","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class VolumeTargetBootIndexAlreadyExists(Conflict):"},{"line_number":174,"context_line":"    _msg_fmt \u003d _(\"A volume target with boot index \u0027%(boot_index)s\u0027 \""},{"line_number":175,"context_line":"                 \"(for the same node) already exists.\")"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class InvalidUUID(Invalid):"}],"source_content_type":"text/x-python","patch_set":41,"id":"5a74a57a_1b53366c","line":175,"in_reply_to":"5a74a57a_db7e1e69","updated":"2016-11-28 19:03:27.000000000","message":"ok. (Let\u0027s see if someone asks for the node\u0027s UUID now.)","commit_id":"b3b49634810a8fbd05df0ca406fc2bb6da54a66e"}],"ironic/db/api.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        :param sort_key: Attribute by which results should be sorted."},{"line_number":687,"context_line":"        :param sort_dir: direction in which results should be sorted."},{"line_number":688,"context_line":"                         (asc, desc)"},{"line_number":689,"context_line":"        :returns: A list of volume targets."},{"line_number":690,"context_line":"        \"\"\""},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    @abc.abstractmethod"},{"line_number":693,"context_line":"    def get_volume_target_by_id(self, target_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_5d19d578","line":690,"range":{"start_line":689,"start_character":8,"end_line":690,"end_character":11},"updated":"2016-05-19 09:33:27.000000000","message":"I would suggest to include the list of exceptions raised in the docstring of each one of these interface methods with the ``:raises:`` tag. This applies to all the api methods.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        :param sort_key: Attribute by which results should be sorted."},{"line_number":687,"context_line":"        :param sort_dir: direction in which results should be sorted."},{"line_number":688,"context_line":"                         (asc, desc)"},{"line_number":689,"context_line":"        :returns: A list of volume targets."},{"line_number":690,"context_line":"        \"\"\""},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    @abc.abstractmethod"},{"line_number":693,"context_line":"    def get_volume_target_by_id(self, target_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_00bbd6c4","line":690,"range":{"start_line":689,"start_character":8,"end_line":690,"end_character":11},"in_reply_to":"bab6814e_5d19d578","updated":"2016-06-14 16:30:21.000000000","message":"Done for items where they raise exceptions.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd0bedfeb16a7cec001edcc9a91de260099b48f6","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        \"\"\"Create a new volume target."},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        :param target_info: Dictionary containing the information about target."},{"line_number":731,"context_line":"        :raises: VolumeTargetAlreadyExists"},{"line_number":732,"context_line":"        :returns: A volume target."},{"line_number":733,"context_line":"        \"\"\""},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_0906971c","line":731,"updated":"2016-07-20 20:59:50.000000000","message":"nit: would kind of be nice to have an explanation, but I don\u0027t think it is required.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        \"\"\"Create a new volume target."},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"        :param target_info: Dictionary containing the information about target."},{"line_number":731,"context_line":"        :raises: VolumeTargetAlreadyExists"},{"line_number":732,"context_line":"        :returns: A volume target."},{"line_number":733,"context_line":"        \"\"\""},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_19779703","line":731,"in_reply_to":"dada55a8_0906971c","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"f2c9438167790cf46ec2a86674538a1592f0a296","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        :param target_id: The id of a volume target."},{"line_number":739,"context_line":"        :param target_info: Dictionary containing the information about"},{"line_number":740,"context_line":"                            target to update."},{"line_number":741,"context_line":"        :raises: VolumeTargetValueAlreadyExists"},{"line_number":742,"context_line":"        :returns: A volume target."},{"line_number":743,"context_line":"        \"\"\""},{"line_number":744,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_207f2567","line":741,"range":{"start_line":741,"start_character":9,"end_line":741,"end_character":15},"updated":"2016-07-21 03:55:38.000000000","message":"Also raises \"VolumeTargetNotFound\" if the target_id does not exist.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        :param target_id: The id of a volume target."},{"line_number":739,"context_line":"        :param target_info: Dictionary containing the information about"},{"line_number":740,"context_line":"                            target to update."},{"line_number":741,"context_line":"        :raises: VolumeTargetValueAlreadyExists"},{"line_number":742,"context_line":"        :returns: A volume target."},{"line_number":743,"context_line":"        \"\"\""},{"line_number":744,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_d44ae626","line":741,"range":{"start_line":741,"start_character":9,"end_line":741,"end_character":15},"in_reply_to":"dada55a8_207f2567","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7ddd23d6a1b1fae2d1ad37a5bd9de51c4af0385c","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        \"\"\"Destroy an volume target."},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        :param target_id: The id of a volume target."},{"line_number":778,"context_line":"        :raises: VolumeTargetNotFound XXX"},{"line_number":779,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_dbb29a05","line":778,"range":{"start_line":778,"start_character":38,"end_line":778,"end_character":41},"updated":"2016-07-30 14:56:30.000000000","message":"if the specified id does not exist.","commit_id":"016cb90a74df6b99695606d5f3a98ad4f60dbe5d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"376d8f50f81fcb00467f650d2cd7fc8007da91f5","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        \"\"\"Destroy an volume target."},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        :param target_id: The id of a volume target."},{"line_number":778,"context_line":"        :raises: VolumeTargetNotFound XXX"},{"line_number":779,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_9ccc60bc","line":778,"range":{"start_line":778,"start_character":38,"end_line":778,"end_character":41},"in_reply_to":"bacf61ea_dbb29a05","updated":"2016-08-01 20:34:03.000000000","message":"Done","commit_id":"016cb90a74df6b99695606d5f3a98ad4f60dbe5d"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"a71b233f410173a2c34f5d157032df87ee0d8029","unresolved":false,"context_lines":[{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        :param target_info: Dictionary containing the information about target."},{"line_number":757,"context_line":"        :returns: A volume target."},{"line_number":758,"context_line":"        :raises: VolumeTargetAlreadyExists when a duplicate volume target"},{"line_number":759,"context_line":"                 exists."},{"line_number":760,"context_line":"        \"\"\""},{"line_number":761,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_b3e651e6","line":758,"range":{"start_line":758,"start_character":17,"end_line":758,"end_character":42},"updated":"2016-08-03 10:35:09.000000000","message":"This also raises VolumeTargetValueAlreadyExists if \"node_id\" + \"boot_index\" breaks this UniqueConstraint:\nhttps://review.openstack.org/#/c/285218/15/ironic/db/sqlalchemy/alembic/versions/1a59178ebdf6_add_volume_targets_table.py@45","commit_id":"85f05344d197e601b868c554e8b553a6556c52a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"be19e64ed7da4fc35fa66eedd5e2c2d028f8361a","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    @abc.abstractmethod"},{"line_number":185,"context_line":"    def destroy_node(self, node_id):"},{"line_number":186,"context_line":"        \"\"\"Destroy a node and all associated interfaces."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param node_id: The id or uuid of a node."},{"line_number":189,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":36,"id":"5a74a57a_1b520814","line":186,"updated":"2016-11-23 13:07:58.000000000","message":"same comment, probably needs to be updated.","commit_id":"effa21e76f52b0672249d33932611e2ddd7b1bb8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2036fe38b8bdb1782040afe7bf4ac5cdf69b5a9b","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    @abc.abstractmethod"},{"line_number":185,"context_line":"    def destroy_node(self, node_id):"},{"line_number":186,"context_line":"        \"\"\"Destroy a node and all associated interfaces."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param node_id: The id or uuid of a node."},{"line_number":189,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":36,"id":"5a74a57a_6ccb1b54","line":186,"in_reply_to":"5a74a57a_1b520814","updated":"2016-11-24 06:27:47.000000000","message":"done","commit_id":"effa21e76f52b0672249d33932611e2ddd7b1bb8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"be19e64ed7da4fc35fa66eedd5e2c2d028f8361a","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                 exists."},{"line_number":760,"context_line":"        \"\"\""},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def update_volume_target(self, target_id, target_info):"},{"line_number":763,"context_line":"        \"\"\"Update properties of a volume target."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        :param target_id: The id of a volume target."}],"source_content_type":"text/x-python","patch_set":36,"id":"5a74a57a_e0ef59ae","line":762,"updated":"2016-11-23 13:07:58.000000000","message":"same as for connectors table, no abstractmethod decorator here.","commit_id":"effa21e76f52b0672249d33932611e2ddd7b1bb8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2036fe38b8bdb1782040afe7bf4ac5cdf69b5a9b","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                 exists."},{"line_number":760,"context_line":"        \"\"\""},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def update_volume_target(self, target_id, target_info):"},{"line_number":763,"context_line":"        \"\"\"Update properties of a volume target."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        :param target_id: The id of a volume target."}],"source_content_type":"text/x-python","patch_set":36,"id":"5a74a57a_2cb123e2","line":762,"in_reply_to":"5a74a57a_e0ef59ae","updated":"2016-11-24 06:27:47.000000000","message":"done","commit_id":"effa21e76f52b0672249d33932611e2ddd7b1bb8"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":778,"context_line":""},{"line_number":779,"context_line":"                                   {"},{"line_number":780,"context_line":"                                       \u0027uuid\u0027: \u0027000000-..\u0027,"},{"line_number":781,"context_line":"                                       \u0027node_id\u0027: 2"},{"line_number":782,"context_line":"                                       \u0027boot_index\u0027: 0,"},{"line_number":783,"context_line":"                                       \u0027volume_id\u0027: \u002712345678-...\u0027"},{"line_number":784,"context_line":"                                       \u0027volume_type\u0027: \u0027some type\u0027,"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_205878fa","line":781,"updated":"2016-12-01 14:41:26.000000000","message":"nit: missing comma","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":798,"context_line":"        :param target_info: Dictionary containing the information about"},{"line_number":799,"context_line":"                            volume target to update."},{"line_number":800,"context_line":"        :returns: A volume target."},{"line_number":801,"context_line":"        :raises: InvalidParameterValue if a UUID is included in target_info"},{"line_number":802,"context_line":"        :raises: VolumeTargetBootIndexAlreadyExists if a volume target already"},{"line_number":803,"context_line":"                 exists with the same boot index and node ID."},{"line_number":804,"context_line":"        :raises: VolumeTargetNotFound if no volume target with this ident"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_401494f4","line":801,"updated":"2016-12-01 14:41:26.000000000","message":"nit: missing period","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        :returns: A volume target."},{"line_number":801,"context_line":"        :raises: InvalidParameterValue if a UUID is included in target_info"},{"line_number":802,"context_line":"        :raises: VolumeTargetBootIndexAlreadyExists if a volume target already"},{"line_number":803,"context_line":"                 exists with the same boot index and node ID."},{"line_number":804,"context_line":"        :raises: VolumeTargetNotFound if no volume target with this ident"},{"line_number":805,"context_line":"                 exists."},{"line_number":806,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_a003a8b7","line":803,"updated":"2016-12-01 14:41:26.000000000","message":"s/same/new/ maybe?","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"00ebd359d28bf7a016c68af0eb30ec9749e1128b","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        :returns: A volume target."},{"line_number":801,"context_line":"        :raises: InvalidParameterValue if a UUID is included in target_info"},{"line_number":802,"context_line":"        :raises: VolumeTargetBootIndexAlreadyExists if a volume target already"},{"line_number":803,"context_line":"                 exists with the same boot index and node ID."},{"line_number":804,"context_line":"        :raises: VolumeTargetNotFound if no volume target with this ident"},{"line_number":805,"context_line":"                 exists."},{"line_number":806,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_e1559f1d","line":803,"in_reply_to":"3a71b18c_46dd8941","updated":"2016-12-01 16:08:27.000000000","message":"Eh, re-reading it\u0027s probably fine.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59fa9b2ccdc6dc3dbd976b3b66bd2316ee7366be","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        :returns: A volume target."},{"line_number":801,"context_line":"        :raises: InvalidParameterValue if a UUID is included in target_info"},{"line_number":802,"context_line":"        :raises: VolumeTargetBootIndexAlreadyExists if a volume target already"},{"line_number":803,"context_line":"                 exists with the same boot index and node ID."},{"line_number":804,"context_line":"        :raises: VolumeTargetNotFound if no volume target with this ident"},{"line_number":805,"context_line":"                 exists."},{"line_number":806,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_46dd8941","line":803,"in_reply_to":"3a71b18c_a003a8b7","updated":"2016-12-01 16:02:24.000000000","message":"well, the problem is that one or both are new. If I just say \u0027new\u0027, it\u0027ll look like both of them are new.\n\nI can reword it as \u0027with the same boot index and node ID as this changed volume target.\u0027","commit_id":"212a645c734976de396a8d251091cacdbfd07775"}],"ironic/db/sqlalchemy/alembic/versions/1a59178ebdf6_add_volume_targets_table.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd0bedfeb16a7cec001edcc9a91de260099b48f6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                    sa.Column(\u0027id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":34,"context_line":"                    sa.Column(\u0027uuid\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":35,"context_line":"                    sa.Column(\u0027node_id\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(\u0027driver_volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027target_properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_c61bcec8","line":36,"range":{"start_line":36,"start_character":31,"end_line":36,"end_character":49},"updated":"2016-07-20 20:59:50.000000000","message":"I think this field is volume_type per the specification","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                    sa.Column(\u0027id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":34,"context_line":"                    sa.Column(\u0027uuid\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":35,"context_line":"                    sa.Column(\u0027node_id\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(\u0027driver_volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027target_properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f4ff2aa8","line":36,"range":{"start_line":36,"start_character":31,"end_line":36,"end_character":49},"in_reply_to":"dada55a8_c61bcec8","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd0bedfeb16a7cec001edcc9a91de260099b48f6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                    sa.Column(\u0027node_id\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(\u0027driver_volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027target_properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":41,"context_line":"                    sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_e6fa5242","line":38,"updated":"2016-07-20 20:59:50.000000000","message":"Specification calls for properties as the field name.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                    sa.Column(\u0027node_id\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(\u0027driver_volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027target_properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":41,"context_line":"                    sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_542b9633","line":38,"in_reply_to":"dada55a8_e6fa5242","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"847a79a57ae937162ce21108f7ed36d1e6944022","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027target_properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":41,"context_line":"                    sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":42,"context_line":"                    sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":43,"context_line":"                    sa.UniqueConstraint(\u0027uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_81d06520","line":40,"updated":"2016-06-14 18:15:32.000000000","message":"line 135 of https://review.openstack.org/#/c/200496/38/specs/approved/volume-connection-information.rst lists a volume_id (string 36) field to be included in this table.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027target_properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":41,"context_line":"                    sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":42,"context_line":"                    sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":43,"context_line":"                    sa.UniqueConstraint(\u0027uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_3430a29e","line":40,"in_reply_to":"7aa08908_81d06520","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"965c1ab8738cae8feedc8e8fa1c773380007bf8c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":41,"context_line":"                    sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":42,"context_line":"                    sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":43,"context_line":"                    sa.UniqueConstraint(\u0027uuid\u0027,"},{"line_number":44,"context_line":"                                        name\u003d\u0027uniq_volumetargets0uuid\u0027),"},{"line_number":45,"context_line":"                    mysql_charset\u003d\u0027utf8\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_0ea83476","line":42,"updated":"2016-07-21 14:04:04.000000000","message":"Looks like this table is missing a unique constraint between node_id and boot_index","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":41,"context_line":"                    sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":42,"context_line":"                    sa.PrimaryKeyConstraint(\u0027id\u0027),"},{"line_number":43,"context_line":"                    sa.UniqueConstraint(\u0027uuid\u0027,"},{"line_number":44,"context_line":"                                        name\u003d\u0027uniq_volumetargets0uuid\u0027),"},{"line_number":45,"context_line":"                    mysql_charset\u003d\u0027utf8\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f4c44a60","line":42,"in_reply_to":"dada55a8_0ea83476","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"8e67cf14612b342a905b13eb3ec79e364ecebe9b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    sa.Column(\u0027volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027volume_id\u0027,"},{"line_number":41,"context_line":"                              sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":42,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a74a57a_069371a4","line":39,"updated":"2016-11-30 16:04:57.000000000","message":"It might be good to have a check constraint to ensure that this is positive, but that\u0027s not part of the spec. I suppose we can check it at some other layer (RPC maybe)","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"00ebd359d28bf7a016c68af0eb30ec9749e1128b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    sa.Column(\u0027volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027volume_id\u0027,"},{"line_number":41,"context_line":"                              sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":42,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_211dd773","line":39,"in_reply_to":"3a71b18c_26308d56","updated":"2016-12-01 16:08:27.000000000","message":"Okay, cool.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59fa9b2ccdc6dc3dbd976b3b66bd2316ee7366be","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    sa.Column(\u0027volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027volume_id\u0027,"},{"line_number":41,"context_line":"                              sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":42,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_26308d56","line":39,"in_reply_to":"3a71b18c_f5cba01c","updated":"2016-12-01 16:02:24.000000000","message":"I don\u0027t think we want to block negative values. Mario looked into it and added a comment -- i\u0027ll put it here: In Nova, negative or None values are used to indicate that a volume should not be used as a boot device.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9c95ee8ec74aafe9f41421fc045a72c1d9f6cc4b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    sa.Column(\u0027volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027volume_id\u0027,"},{"line_number":41,"context_line":"                              sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":42,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a74a57a_3d295738","line":39,"in_reply_to":"5a74a57a_069371a4","updated":"2016-11-30 16:58:44.000000000","message":"Good point. Well, we can always update the spec if we want this constrained to be only positive. (Does that include zero?)\n\nLooks like this is the first Integer value that is not an ID. I am wondering if we want to constrain it at this level, or higher up the food chain. I don\u0027t feel strongly either way.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                    sa.Column(\u0027volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027volume_id\u0027,"},{"line_number":41,"context_line":"                              sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":42,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_f5cba01c","line":39,"in_reply_to":"5a74a57a_3d295738","updated":"2016-12-01 14:41:26.000000000","message":"\"The CHECK clause is parsed but ignored by all storage engines.\" according to mysql docs: http://dev.mysql.com/doc/refman/5.7/en/create-table.html\n\nThere is an \"unsigned\" keyword that can be used, however it only rejects negative values in strict mode, otherwise it sets it to zero.\n\nI vote for checking it in the objects layer :)","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cfc9ebd0e423bf8cae085096eb7f9f5956dd757a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    sa.Column(\u0027created_at\u0027, sa.DateTime(), nullable\u003dTrue),"},{"line_number":32,"context_line":"                    sa.Column(\u0027updated_at\u0027, sa.DateTime(), nullable\u003dTrue),"},{"line_number":33,"context_line":"                    sa.Column(\u0027id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":34,"context_line":"                    sa.Column(\u0027uuid\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":35,"context_line":"                    sa.Column(\u0027node_id\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(\u0027volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":43,"id":"3a71b18c_97518965","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":73},"updated":"2016-12-01 16:35:20.000000000","message":"I don\u0027t think this is correct","commit_id":"d96d68f94fb99a55556362d5ef67cd07cf191fd3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dfcb4603dd2b154ed5e09f75a4bdfee5d672512b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    sa.Column(\u0027created_at\u0027, sa.DateTime(), nullable\u003dTrue),"},{"line_number":32,"context_line":"                    sa.Column(\u0027updated_at\u0027, sa.DateTime(), nullable\u003dTrue),"},{"line_number":33,"context_line":"                    sa.Column(\u0027id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":34,"context_line":"                    sa.Column(\u0027uuid\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":35,"context_line":"                    sa.Column(\u0027node_id\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(\u0027volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":43,"id":"3a71b18c_b87755d3","line":34,"range":{"start_line":34,"start_character":60,"end_line":34,"end_character":73},"in_reply_to":"3a71b18c_97518965","updated":"2016-12-01 17:03:15.000000000","message":"Did it this way cuz it is consistent with what we\u0027ve done in the other tables. TBH, I don\u0027t see how it can be nullable but we seem to code/handle this at a higher level.","commit_id":"d96d68f94fb99a55556362d5ef67cd07cf191fd3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cfc9ebd0e423bf8cae085096eb7f9f5956dd757a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                    sa.Column(\u0027updated_at\u0027, sa.DateTime(), nullable\u003dTrue),"},{"line_number":33,"context_line":"                    sa.Column(\u0027id\u0027, sa.Integer(), nullable\u003dFalse),"},{"line_number":34,"context_line":"                    sa.Column(\u0027uuid\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":35,"context_line":"                    sa.Column(\u0027node_id\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":36,"context_line":"                    sa.Column(\u0027volume_type\u0027, sa.String(length\u003d64),"},{"line_number":37,"context_line":"                              nullable\u003dTrue),"},{"line_number":38,"context_line":"                    sa.Column(\u0027properties\u0027, sa.Text(), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":43,"id":"3a71b18c_179ad914","line":35,"range":{"start_line":35,"start_character":55,"end_line":35,"end_character":68},"updated":"2016-12-01 16:35:20.000000000","message":"Not sure about this either","commit_id":"d96d68f94fb99a55556362d5ef67cd07cf191fd3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cfc9ebd0e423bf8cae085096eb7f9f5956dd757a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    sa.Column(\u0027properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027volume_id\u0027,"},{"line_number":41,"context_line":"                              sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":42,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":43,"context_line":"                    sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":44,"context_line":"                    sa.PrimaryKeyConstraint(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":43,"id":"3a71b18c_17f3b974","line":41,"range":{"start_line":41,"start_character":53,"end_line":41,"end_character":65},"updated":"2016-12-01 16:35:20.000000000","message":"Not sure about this either","commit_id":"d96d68f94fb99a55556362d5ef67cd07cf191fd3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dfcb4603dd2b154ed5e09f75a4bdfee5d672512b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    sa.Column(\u0027properties\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":39,"context_line":"                    sa.Column(\u0027boot_index\u0027, sa.Integer(), nullable\u003dTrue),"},{"line_number":40,"context_line":"                    sa.Column(\u0027volume_id\u0027,"},{"line_number":41,"context_line":"                              sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":42,"context_line":"                    sa.Column(\u0027extra\u0027, sa.Text(), nullable\u003dTrue),"},{"line_number":43,"context_line":"                    sa.ForeignKeyConstraint([\u0027node_id\u0027], [\u0027nodes.id\u0027], ),"},{"line_number":44,"context_line":"                    sa.PrimaryKeyConstraint(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":43,"id":"3a71b18c_f8e54da8","line":41,"range":{"start_line":41,"start_character":53,"end_line":41,"end_character":65},"in_reply_to":"3a71b18c_17f3b974","updated":"2016-12-01 17:03:15.000000000","message":"Julia commented that \u0027the consumer of the data may not always be cinder and cinder\u0027s volume id, but at the same time if someone adds a volume without some sort of tracking ID, at least manually, they may be heading into into territory with warning signs for dragons\u0027","commit_id":"d96d68f94fb99a55556362d5ef67cd07cf191fd3"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":381,"context_line":"            connector_query.filter_by(node_id\u003dnode_id)"},{"line_number":382,"context_line":"            connector_query.delete()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            target_query \u003d model_query(models.VolumeTarget)"},{"line_number":385,"context_line":"            target_query.filter_by(node_id\u003dnode_id)"},{"line_number":386,"context_line":"            target_query.delete()"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            query.delete()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_5d51d5d7","line":385,"range":{"start_line":384,"start_character":12,"end_line":385,"end_character":51},"updated":"2016-05-19 09:33:27.000000000","message":"can be chained.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":381,"context_line":"            connector_query.filter_by(node_id\u003dnode_id)"},{"line_number":382,"context_line":"            connector_query.delete()"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            target_query \u003d model_query(models.VolumeTarget)"},{"line_number":385,"context_line":"            target_query.filter_by(node_id\u003dnode_id)"},{"line_number":386,"context_line":"            target_query.delete()"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"            query.delete()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_dd9d3b67","line":385,"range":{"start_line":384,"start_character":12,"end_line":385,"end_character":51},"in_reply_to":"bab6814e_5d51d5d7","updated":"2016-06-14 16:30:21.000000000","message":"Done","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":938,"context_line":""},{"line_number":939,"context_line":"    def get_volume_targets_by_node_id(self, node_id, limit\u003dNone, marker\u003dNone,"},{"line_number":940,"context_line":"                                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":941,"context_line":"        query \u003d model_query(models.VolumeTarget)"},{"line_number":942,"context_line":"        query \u003d query.filter_by(node_id\u003dnode_id)"},{"line_number":943,"context_line":"        return _paginate_query(models.VolumeTarget, limit, marker, sort_key,"},{"line_number":944,"context_line":"                               sort_dir, query)"},{"line_number":945,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_fd26c966","line":942,"range":{"start_line":941,"start_character":8,"end_line":942,"end_character":48},"updated":"2016-05-19 09:33:27.000000000","message":"can be chained","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":938,"context_line":""},{"line_number":939,"context_line":"    def get_volume_targets_by_node_id(self, node_id, limit\u003dNone, marker\u003dNone,"},{"line_number":940,"context_line":"                                      sort_key\u003dNone, sort_dir\u003dNone):"},{"line_number":941,"context_line":"        query \u003d model_query(models.VolumeTarget)"},{"line_number":942,"context_line":"        query \u003d query.filter_by(node_id\u003dnode_id)"},{"line_number":943,"context_line":"        return _paginate_query(models.VolumeTarget, limit, marker, sort_key,"},{"line_number":944,"context_line":"                               sort_dir, query)"},{"line_number":945,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3d9a7f62","line":942,"range":{"start_line":941,"start_character":8,"end_line":942,"end_character":48},"in_reply_to":"bab6814e_fd26c966","updated":"2016-06-14 16:30:21.000000000","message":"Done","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                               sort_dir, query)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    def create_volume_target(self, target_info):"},{"line_number":947,"context_line":"        if not target_info.get(\u0027uuid\u0027):"},{"line_number":948,"context_line":"            target_info[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        target \u003d models.VolumeTarget()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_9dd69d25","line":947,"range":{"start_line":947,"start_character":8,"end_line":947,"end_character":39},"updated":"2016-05-19 09:33:27.000000000","message":"Instead, to enhance readability:\n\n  if \u0027uuid\u0027 not in target_info:\n    ...","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                               sort_dir, query)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    def create_volume_target(self, target_info):"},{"line_number":947,"context_line":"        if not target_info.get(\u0027uuid\u0027):"},{"line_number":948,"context_line":"            target_info[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        target \u003d models.VolumeTarget()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_7dc7e744","line":947,"range":{"start_line":947,"start_character":8,"end_line":947,"end_character":39},"in_reply_to":"bab6814e_9dd69d25","updated":"2016-06-14 16:30:21.000000000","message":"Done","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"26c77c31a73ce42f152ee59b5661b09f2c511d5f","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                ref.update(target_info)"},{"line_number":972,"context_line":"                session.flush()"},{"line_number":973,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":974,"context_line":"            raise exception.VolumeTargetValueAlreadyExists("},{"line_number":975,"context_line":"                uuid\u003dtarget_info[\u0027uuid\u0027])"},{"line_number":976,"context_line":"        except NoResultFound:"},{"line_number":977,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dtarget_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_446d7998","line":974,"range":{"start_line":974,"start_character":28,"end_line":974,"end_character":58},"updated":"2016-05-25 08:56:41.000000000","message":"Undefined exception.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":971,"context_line":"                ref.update(target_info)"},{"line_number":972,"context_line":"                session.flush()"},{"line_number":973,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":974,"context_line":"            raise exception.VolumeTargetValueAlreadyExists("},{"line_number":975,"context_line":"                uuid\u003dtarget_info[\u0027uuid\u0027])"},{"line_number":976,"context_line":"        except NoResultFound:"},{"line_number":977,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dtarget_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8037c6e1","line":974,"range":{"start_line":974,"start_character":28,"end_line":974,"end_character":58},"in_reply_to":"bab6814e_446d7998","updated":"2016-06-14 16:30:21.000000000","message":"Defined in next revision.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"f2c9438167790cf46ec2a86674538a1592f0a296","unresolved":false,"context_lines":[{"line_number":979,"context_line":"                ref.update(target_info)"},{"line_number":980,"context_line":"                session.flush()"},{"line_number":981,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":982,"context_line":"            raise exception.VolumeTargetValueAlreadyExists("},{"line_number":983,"context_line":"                uuid\u003dtarget_info[\u0027uuid\u0027])"},{"line_number":984,"context_line":"        except NoResultFound:"},{"line_number":985,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dtarget_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_c0560929","line":982,"range":{"start_line":982,"start_character":28,"end_line":982,"end_character":58},"updated":"2016-07-21 03:55:38.000000000","message":"This may have a corresponding unique constraint in sql query[1]. \nBut I can\u0027t find it...\n\n[1] https://review.openstack.org/#/c/285218/4/ironic/db/sqlalchemy/alembic/versions/1a59178ebdf6_add_volume_targets_table.py@30","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"965c1ab8738cae8feedc8e8fa1c773380007bf8c","unresolved":false,"context_lines":[{"line_number":979,"context_line":"                ref.update(target_info)"},{"line_number":980,"context_line":"                session.flush()"},{"line_number":981,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":982,"context_line":"            raise exception.VolumeTargetValueAlreadyExists("},{"line_number":983,"context_line":"                uuid\u003dtarget_info[\u0027uuid\u0027])"},{"line_number":984,"context_line":"        except NoResultFound:"},{"line_number":985,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dtarget_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_4ee34cd9","line":982,"range":{"start_line":982,"start_character":28,"end_line":982,"end_character":58},"in_reply_to":"dada55a8_c0560929","updated":"2016-07-21 14:04:04.000000000","message":"Good catch, it is missing a unique constraint.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"a71b233f410173a2c34f5d157032df87ee0d8029","unresolved":false,"context_lines":[{"line_number":994,"context_line":"            try:"},{"line_number":995,"context_line":"                session.add(target)"},{"line_number":996,"context_line":"                session.flush()"},{"line_number":997,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":998,"context_line":"                raise exception.VolumeTargetAlreadyExists("},{"line_number":999,"context_line":"                    uuid\u003dtarget_info[\u0027uuid\u0027])"},{"line_number":1000,"context_line":"            return target"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_ddf4b688","line":997,"range":{"start_line":997,"start_character":11,"end_line":997,"end_character":43},"updated":"2016-08-03 10:35:09.000000000","message":"This also raises VolumeTargetValueAlreadyExists if \"node_id\" + \"boot_index\" breaks this UniqueConstraint:\nhttps://review.openstack.org/#/c/285218/15/ironic/db/sqlalchemy/alembic/versions/1a59178ebdf6_add_volume_targets_table.py@45","commit_id":"85f05344d197e601b868c554e8b553a6556c52a7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"be19e64ed7da4fc35fa66eedd5e2c2d028f8361a","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"                session.flush()"},{"line_number":1009,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":1010,"context_line":"            raise exception.VolumeTargetValueAlreadyExists("},{"line_number":1011,"context_line":"                uuid\u003dtarget_info.get(\u0027uuid\u0027))"},{"line_number":1012,"context_line":"        except NoResultFound:"},{"line_number":1013,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dtarget_id)"},{"line_number":1014,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":36,"id":"5a74a57a_409f2d03","line":1011,"updated":"2016-11-23 13:07:58.000000000","message":"huh, you\u0027ve checked that it is not in target_info on L998. ref[\u0027uuid\u0027] instead?","commit_id":"effa21e76f52b0672249d33932611e2ddd7b1bb8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2036fe38b8bdb1782040afe7bf4ac5cdf69b5a9b","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"                session.flush()"},{"line_number":1009,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":1010,"context_line":"            raise exception.VolumeTargetValueAlreadyExists("},{"line_number":1011,"context_line":"                uuid\u003dtarget_info.get(\u0027uuid\u0027))"},{"line_number":1012,"context_line":"        except NoResultFound:"},{"line_number":1013,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dtarget_id)"},{"line_number":1014,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":36,"id":"5a74a57a_0c08e790","line":1011,"in_reply_to":"5a74a57a_409f2d03","updated":"2016-11-24 06:27:47.000000000","message":"Yes, this isn\u0027t correct. This occurs when the volume target has the same node_id and boot_index as an existing volume target. I\u0027ve modified the exceptions to make that clearer.","commit_id":"effa21e76f52b0672249d33932611e2ddd7b1bb8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7eb7e51d44f4761d1d74ba1310942b79dccb7ad8","unresolved":false,"context_lines":[{"line_number":995,"context_line":"            except db_exc.DBDuplicateEntry as exc:"},{"line_number":996,"context_line":"                if \u0027boot_index\u0027 in exc.columns:"},{"line_number":997,"context_line":"                    raise exception.VolumeTargetAlreadyExists("},{"line_number":998,"context_line":"                        node_id\u003dtarget_info[\u0027node_id\u0027],"},{"line_number":999,"context_line":"                        boot_index\u003dtarget_info[\u0027boot_index\u0027])"},{"line_number":1000,"context_line":"                raise exception.VolumeTargetUuidAlreadyExists("},{"line_number":1001,"context_line":"                    uuid\u003dtarget_info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_4e8c6035","line":998,"updated":"2016-11-25 11:40:36.000000000","message":"this must be node UUID, I suspect it\u0027s not. We should never output node integer IDs to users, they don\u0027t see them anywhere.","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5a32ef9b52295739986f78226dece5abd787af9f","unresolved":false,"context_lines":[{"line_number":995,"context_line":"            except db_exc.DBDuplicateEntry as exc:"},{"line_number":996,"context_line":"                if \u0027boot_index\u0027 in exc.columns:"},{"line_number":997,"context_line":"                    raise exception.VolumeTargetAlreadyExists("},{"line_number":998,"context_line":"                        node_id\u003dtarget_info[\u0027node_id\u0027],"},{"line_number":999,"context_line":"                        boot_index\u003dtarget_info[\u0027boot_index\u0027])"},{"line_number":1000,"context_line":"                raise exception.VolumeTargetUuidAlreadyExists("},{"line_number":1001,"context_line":"                    uuid\u003dtarget_info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_82536016","line":998,"in_reply_to":"5a74a57a_1f4feb6b","updated":"2016-11-28 16:38:22.000000000","message":"The VolumeTarget is the only one that has a unique constraint on nodeID \u0026 something else. I don\u0027t think we want to do another db access just to get the node UUID (I suppose someone could do that in a subsequent patch if it helps with debugging or whatever, given that it is an exception, one more db access should be fine).\n\nI like Julia\u0027s suggestion. Except no target UUID since this is a create (cuz the user may not have specified the UUID). Creations are synchronous so it should be fine that we don\u0027t spit out more info about the volume target being created.","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b2a403f3b6ef7ee65d8850998d8c52e9555e662f","unresolved":false,"context_lines":[{"line_number":995,"context_line":"            except db_exc.DBDuplicateEntry as exc:"},{"line_number":996,"context_line":"                if \u0027boot_index\u0027 in exc.columns:"},{"line_number":997,"context_line":"                    raise exception.VolumeTargetAlreadyExists("},{"line_number":998,"context_line":"                        node_id\u003dtarget_info[\u0027node_id\u0027],"},{"line_number":999,"context_line":"                        boot_index\u003dtarget_info[\u0027boot_index\u0027])"},{"line_number":1000,"context_line":"                raise exception.VolumeTargetUuidAlreadyExists("},{"line_number":1001,"context_line":"                    uuid\u003dtarget_info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_87873bd6","line":998,"in_reply_to":"5a74a57a_4e8c6035","updated":"2016-11-25 13:07:55.000000000","message":"We would have to have the API code send the UUID instead, that or we would need to look it up here.","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"54d92f4ac112dfeb04eda3e334ef6a1c20168fa7","unresolved":false,"context_lines":[{"line_number":995,"context_line":"            except db_exc.DBDuplicateEntry as exc:"},{"line_number":996,"context_line":"                if \u0027boot_index\u0027 in exc.columns:"},{"line_number":997,"context_line":"                    raise exception.VolumeTargetAlreadyExists("},{"line_number":998,"context_line":"                        node_id\u003dtarget_info[\u0027node_id\u0027],"},{"line_number":999,"context_line":"                        boot_index\u003dtarget_info[\u0027boot_index\u0027])"},{"line_number":1000,"context_line":"                raise exception.VolumeTargetUuidAlreadyExists("},{"line_number":1001,"context_line":"                    uuid\u003dtarget_info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_1f4feb6b","line":998,"in_reply_to":"5a74a57a_87873bd6","updated":"2016-11-25 15:28:39.000000000","message":"The port code doesn\u0027t raise any exceptions like this, and only the database  ID of the node gets passed down from the API.  In order to avoid re-working the data model for volume connection revisions, which I would prefer to avoid unless we do it to ports/portgroups as well, we would just need to look up the node uuid.  Alternatively!  we could change the messages to log the target uuid as well as the boot index.  \"Volume target %s does not have a unique boot_index value %s for the node to which it is assigned.\"","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7eb7e51d44f4761d1d74ba1310942b79dccb7ad8","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"                session.flush()"},{"line_number":1018,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":1019,"context_line":"            raise exception.VolumeTargetAlreadyExists("},{"line_number":1020,"context_line":"                node_id\u003dtarget_info.get(\u0027node_id\u0027, orig_node_id),"},{"line_number":1021,"context_line":"                boot_index\u003dtarget_info.get(\u0027boot_index\u0027, orig_boot_index))"},{"line_number":1022,"context_line":"        except NoResultFound:"},{"line_number":1023,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dident)"}],"source_content_type":"text/x-python","patch_set":40,"id":"5a74a57a_6e83dc04","line":1020,"updated":"2016-11-25 11:40:36.000000000","message":"ditto","commit_id":"2231d71d1ac8c49bb78473d3d87c62b4081c2a0f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"8e67cf14612b342a905b13eb3ec79e364ecebe9b","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                models.VolumeConnector).filter_by(node_id\u003dnode_id)"},{"line_number":387,"context_line":"            volume_connector_query.delete()"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"            volume_target_query \u003d model_query("},{"line_number":390,"context_line":"                models.VolumeTarget).filter_by(node_id\u003dnode_id)"},{"line_number":391,"context_line":"            volume_target_query.delete()"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"5a74a57a_e6f7558a","line":389,"updated":"2016-11-30 16:04:57.000000000","message":"Another way to do this would be \"ON DELETE CASCADE\", since there\u0027s a foreign key constraint: https://dev.mysql.com/doc/refman/5.6/en/create-table-foreign-keys.html\n\nIt appears that other resources don\u0027t do this though, so let\u0027s leave it as-is.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"                session.flush()"},{"line_number":1016,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":1017,"context_line":"            raise exception.VolumeTargetBootIndexAlreadyExists("},{"line_number":1018,"context_line":"                boot_index\u003dtarget_info.get(\u0027boot_index\u0027, orig_boot_index))"},{"line_number":1019,"context_line":"        except NoResultFound:"},{"line_number":1020,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dident)"},{"line_number":1021,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_a0e7283f","line":1018,"updated":"2016-12-01 14:41:26.000000000","message":"Don\u0027t we want to use the new boot_index here? This will show the old one.\n\nLet\u0027s say I have target x with boot_index 0, and target y with boot_index 1. I update target y to be boot_index 0. The error here would be \"A volume target with boot index 1 for the same node already exists\". Seems wrong.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"00ebd359d28bf7a016c68af0eb30ec9749e1128b","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"                session.flush()"},{"line_number":1016,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":1017,"context_line":"            raise exception.VolumeTargetBootIndexAlreadyExists("},{"line_number":1018,"context_line":"                boot_index\u003dtarget_info.get(\u0027boot_index\u0027, orig_boot_index))"},{"line_number":1019,"context_line":"        except NoResultFound:"},{"line_number":1020,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dident)"},{"line_number":1021,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_fc2544ae","line":1018,"in_reply_to":"3a71b18c_469f4903","updated":"2016-12-01 16:08:27.000000000","message":"Oh! I misread this, okay. It makes sense.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59fa9b2ccdc6dc3dbd976b3b66bd2316ee7366be","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"                session.flush()"},{"line_number":1016,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":1017,"context_line":"            raise exception.VolumeTargetBootIndexAlreadyExists("},{"line_number":1018,"context_line":"                boot_index\u003dtarget_info.get(\u0027boot_index\u0027, orig_boot_index))"},{"line_number":1019,"context_line":"        except NoResultFound:"},{"line_number":1020,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dident)"},{"line_number":1021,"context_line":"        return ref"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_469f4903","line":1018,"in_reply_to":"3a71b18c_a0e7283f","updated":"2016-12-01 16:02:24.000000000","message":"Maybe I\u0027m missing something. In your scenario, target_info[\u0027boot_index\u0027] will be 0 (the proposed change that isn\u0027t going to be allowed).\n\nThe code is like that because it could be the case that target is changing the node ID, not the boot index. In which case, this would use the original boot index value. We aren\u0027t spewing out the node ID cuz we really want the node\u0027s UUID but it doesn\u0027t seem worth the effort to get the UUID via another db request.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"8e67cf14612b342a905b13eb3ec79e364ecebe9b","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"                boot_index\u003dtarget_info.get(\u0027boot_index\u0027, orig_boot_index))"},{"line_number":1019,"context_line":"        except NoResultFound:"},{"line_number":1020,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dident)"},{"line_number":1021,"context_line":"        return ref"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"    def destroy_volume_target(self, ident):"},{"line_number":1024,"context_line":"        with _session_for_write():"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a74a57a_e4ae6de6","line":1021,"updated":"2016-11-30 16:04:57.000000000","message":"I am just curious - why not put this below session.flush() on L1015? That\u0027s more consistent with create_volume target, where the return statement is in the context manager. It doesn\u0027t really matter, though.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9c95ee8ec74aafe9f41421fc045a72c1d9f6cc4b","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"                boot_index\u003dtarget_info.get(\u0027boot_index\u0027, orig_boot_index))"},{"line_number":1019,"context_line":"        except NoResultFound:"},{"line_number":1020,"context_line":"            raise exception.VolumeTargetNotFound(target\u003dident)"},{"line_number":1021,"context_line":"        return ref"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"    def destroy_volume_target(self, ident):"},{"line_number":1024,"context_line":"        with _session_for_write():"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a74a57a_1afca23d","line":1021,"in_reply_to":"5a74a57a_e4ae6de6","updated":"2016-11-30 16:58:44.000000000","message":"I think it is due to copy-paste\u0027ism (see other update_X methods) :-( Given that this isn\u0027t the only occurrence of it, it probably isn\u0027t worth just changing it here.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":227,"context_line":"    uuid \u003d Column(String(36))"},{"line_number":228,"context_line":"    node_id \u003d Column(Integer, ForeignKey(\u0027nodes.id\u0027), nullable\u003dTrue)"},{"line_number":229,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":230,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":231,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":232,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_3df97181","line":229,"range":{"start_line":229,"start_character":4,"end_line":229,"end_character":43},"updated":"2016-05-19 09:33:27.000000000","message":"Shouldn\u0027t this be an Enum type? Just fyr: http://docs.sqlalchemy.org/en/latest/core/type_basics.html?highlight\u003denum#sqlalchemy.types.Enum\nOf course, the db needs to support the native enum type.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"26c77c31a73ce42f152ee59b5661b09f2c511d5f","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":227,"context_line":"    uuid \u003d Column(String(36))"},{"line_number":228,"context_line":"    node_id \u003d Column(Integer, ForeignKey(\u0027nodes.id\u0027), nullable\u003dTrue)"},{"line_number":229,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":230,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":231,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":232,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_8f65bf1e","line":229,"range":{"start_line":229,"start_character":4,"end_line":229,"end_character":43},"in_reply_to":"bab6814e_3df97181","updated":"2016-05-25 08:56:41.000000000","message":"If so, we should fix the related spec as well.\nhttps://review.openstack.org/#/c/200496/37/specs/approved/volume-connection-information.rst@119","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":227,"context_line":"    uuid \u003d Column(String(36))"},{"line_number":228,"context_line":"    node_id \u003d Column(Integer, ForeignKey(\u0027nodes.id\u0027), nullable\u003dTrue)"},{"line_number":229,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":230,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":231,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":232,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_209d32bc","line":229,"range":{"start_line":229,"start_character":4,"end_line":229,"end_character":43},"in_reply_to":"bab6814e_8f65bf1e","updated":"2016-06-14 16:30:21.000000000","message":"We won\u0027t be able to use enum since the default support is SQLite. :(","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd0bedfeb16a7cec001edcc9a91de260099b48f6","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":235,"context_line":"    uuid \u003d Column(String(36))"},{"line_number":236,"context_line":"    node_id \u003d Column(Integer, ForeignKey(\u0027nodes.id\u0027), nullable\u003dTrue)"},{"line_number":237,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":238,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":239,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":240,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_066a06ee","line":237,"range":{"start_line":237,"start_character":4,"end_line":237,"end_character":22},"updated":"2016-07-20 20:59:50.000000000","message":"spec calls for this to be called volume_type.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":235,"context_line":"    uuid \u003d Column(String(36))"},{"line_number":236,"context_line":"    node_id \u003d Column(Integer, ForeignKey(\u0027nodes.id\u0027), nullable\u003dTrue)"},{"line_number":237,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":238,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":239,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":240,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_b4cdb25f","line":237,"range":{"start_line":237,"start_character":4,"end_line":237,"end_character":22},"in_reply_to":"dada55a8_066a06ee","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd0bedfeb16a7cec001edcc9a91de260099b48f6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    uuid \u003d Column(String(36))"},{"line_number":236,"context_line":"    node_id \u003d Column(Integer, ForeignKey(\u0027nodes.id\u0027), nullable\u003dTrue)"},{"line_number":237,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":238,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":239,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":240,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_26658a1d","line":238,"range":{"start_line":238,"start_character":4,"end_line":238,"end_character":21},"updated":"2016-07-20 20:59:50.000000000","message":"spec calls for this field to be named properties","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    uuid \u003d Column(String(36))"},{"line_number":236,"context_line":"    node_id \u003d Column(Integer, ForeignKey(\u0027nodes.id\u0027), nullable\u003dTrue)"},{"line_number":237,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":238,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":239,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":240,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f4d72aeb","line":238,"range":{"start_line":238,"start_character":4,"end_line":238,"end_character":21},"in_reply_to":"dada55a8_26658a1d","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"847a79a57ae937162ce21108f7ed36d1e6944022","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":238,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":239,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":240,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_01063585","line":240,"updated":"2016-06-14 18:15:32.000000000","message":"spec calls for volume_id field","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    driver_volume_type \u003d Column(String(64))"},{"line_number":238,"context_line":"    target_properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":239,"context_line":"    boot_index \u003d Column(Integer)"},{"line_number":240,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_54039676","line":240,"in_reply_to":"7aa08908_01063585","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7ddd23d6a1b1fae2d1ad37a5bd9de51c4af0385c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        schema.UniqueConstraint(\u0027uuid\u0027, name\u003d\u0027uniq_volumetargets0uuid\u0027),"},{"line_number":231,"context_line":"        schema.UniqueConstraint(\u0027node_id\u0027,"},{"line_number":232,"context_line":"                                \u0027boot_index\u0027,"},{"line_number":233,"context_line":"                                name\u003d\u0027uniq_volumetarget0node_id0boot_index0\u0027),"},{"line_number":234,"context_line":"        table_args())"},{"line_number":235,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":236,"context_line":"    uuid \u003d Column(String(36))"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_7b19eed6","line":233,"range":{"start_line":233,"start_character":43,"end_line":233,"end_character":55},"updated":"2016-07-30 14:56:30.000000000","message":"\u0027volumetargets\u0027 would be better.\nOthers use plural.","commit_id":"016cb90a74df6b99695606d5f3a98ad4f60dbe5d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"376d8f50f81fcb00467f650d2cd7fc8007da91f5","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        schema.UniqueConstraint(\u0027uuid\u0027, name\u003d\u0027uniq_volumetargets0uuid\u0027),"},{"line_number":231,"context_line":"        schema.UniqueConstraint(\u0027node_id\u0027,"},{"line_number":232,"context_line":"                                \u0027boot_index\u0027,"},{"line_number":233,"context_line":"                                name\u003d\u0027uniq_volumetarget0node_id0boot_index0\u0027),"},{"line_number":234,"context_line":"        table_args())"},{"line_number":235,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":236,"context_line":"    uuid \u003d Column(String(36))"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_9c28e034","line":233,"range":{"start_line":233,"start_character":43,"end_line":233,"end_character":55},"in_reply_to":"bacf61ea_7b19eed6","updated":"2016-08-01 20:34:03.000000000","message":"Done","commit_id":"016cb90a74df6b99695606d5f3a98ad4f60dbe5d"}],"ironic/tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        self.assertEqual(0, target[\u0027boot_index\u0027])"},{"line_number":627,"context_line":"        self.assertEqual(1, target[\u0027node_id\u0027])"},{"line_number":628,"context_line":"        self.assertEqual(volume_idstring, target[\u0027volume_id\u0027])"},{"line_number":629,"context_line":"        self.assertEqual(\u0027{}\u0027, target[\u0027extra\u0027])"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def test_upgrade_and_version(self):"},{"line_number":632,"context_line":"        with patch_with_engine(self.engine):"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_60f8b07d","line":629,"updated":"2016-12-01 14:41:26.000000000","message":"Hm, we\u0027ve never done this in migration testing until volume_connectors table was made. Do we really think this is useful? Seems like it\u0027s basically testing MySQL/sqlalchemy here, I don\u0027t personally see much value in this.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59fa9b2ccdc6dc3dbd976b3b66bd2316ee7366be","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        self.assertEqual(0, target[\u0027boot_index\u0027])"},{"line_number":627,"context_line":"        self.assertEqual(1, target[\u0027node_id\u0027])"},{"line_number":628,"context_line":"        self.assertEqual(volume_idstring, target[\u0027volume_id\u0027])"},{"line_number":629,"context_line":"        self.assertEqual(\u0027{}\u0027, target[\u0027extra\u0027])"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def test_upgrade_and_version(self):"},{"line_number":632,"context_line":"        with patch_with_engine(self.engine):"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_81db0bed","line":629,"in_reply_to":"3a71b18c_60f8b07d","updated":"2016-12-01 16:02:24.000000000","message":"I don\u0027t know. I\u0027m fine taking it out (esp. since it sets the precedent for future tests to also include this.)","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"00ebd359d28bf7a016c68af0eb30ec9749e1128b","unresolved":false,"context_lines":[{"line_number":626,"context_line":"        self.assertEqual(0, target[\u0027boot_index\u0027])"},{"line_number":627,"context_line":"        self.assertEqual(1, target[\u0027node_id\u0027])"},{"line_number":628,"context_line":"        self.assertEqual(volume_idstring, target[\u0027volume_id\u0027])"},{"line_number":629,"context_line":"        self.assertEqual(\u0027{}\u0027, target[\u0027extra\u0027])"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def test_upgrade_and_version(self):"},{"line_number":632,"context_line":"        with patch_with_engine(self.engine):"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_1c520014","line":629,"in_reply_to":"3a71b18c_81db0bed","updated":"2016-12-01 16:08:27.000000000","message":"Yeah, I could go either way, I just don\u0027t see the usefulness of adding it.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"}],"ironic/tests/unit/db/test_nodes.py":[{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        self.assertRaises(exception.VolumeConnectorNotFound,"},{"line_number":368,"context_line":"                          self.dbapi.get_volume_connector_by_id, connector.id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def test_volume_target_get_destroyed_after_destroying_a_node(self):"},{"line_number":371,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        target \u003d utils.create_test_volume_target(node_id\u003dnode.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_3d27b113","line":370,"range":{"start_line":370,"start_character":27,"end_line":370,"end_character":30},"updated":"2016-05-19 09:33:27.000000000","message":"nit: s/get/gets.. apologies for being super critical :)","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"26c77c31a73ce42f152ee59b5661b09f2c511d5f","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        self.assertRaises(exception.VolumeConnectorNotFound,"},{"line_number":368,"context_line":"                          self.dbapi.get_volume_connector_by_id, connector.id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def test_volume_target_get_destroyed_after_destroying_a_node(self):"},{"line_number":371,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        target \u003d utils.create_test_volume_target(node_id\u003dnode.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_e15f3f73","line":370,"range":{"start_line":370,"start_character":27,"end_line":370,"end_character":30},"in_reply_to":"bab6814e_3d27b113","updated":"2016-05-25 08:56:41.000000000","message":"Sorry, I didn\u0027t get your point. Why not \"get\" for consistency?","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"158a8af6f9a3e79692e37e7f5b0f9ad5303455ce","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        self.assertRaises(exception.VolumeConnectorNotFound,"},{"line_number":368,"context_line":"                          self.dbapi.get_volume_connector_by_id, connector.id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def test_volume_target_get_destroyed_after_destroying_a_node(self):"},{"line_number":371,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        target \u003d utils.create_test_volume_target(node_id\u003dnode.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_d7ed998f","line":370,"range":{"start_line":370,"start_character":27,"end_line":370,"end_character":30},"in_reply_to":"bab6814e_970311b8","updated":"2016-05-25 09:21:25.000000000","message":"Hi, Debayan\nGot it, and thanks for your kind explanation :)","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        self.assertRaises(exception.VolumeConnectorNotFound,"},{"line_number":368,"context_line":"                          self.dbapi.get_volume_connector_by_id, connector.id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def test_volume_target_get_destroyed_after_destroying_a_node(self):"},{"line_number":371,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        target \u003d utils.create_test_volume_target(node_id\u003dnode.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a06f6229","line":370,"range":{"start_line":370,"start_character":27,"end_line":370,"end_character":30},"in_reply_to":"bab6814e_d7ed998f","updated":"2016-06-14 16:30:21.000000000","message":"I\u0027ll change these to gets.  It reads a lot better from expressing what the test is doing.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"e55438405bb04ebfcb7a4bc5d1e5ad2f17551b51","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        self.assertRaises(exception.VolumeConnectorNotFound,"},{"line_number":368,"context_line":"                          self.dbapi.get_volume_connector_by_id, connector.id)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def test_volume_target_get_destroyed_after_destroying_a_node(self):"},{"line_number":371,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        target \u003d utils.create_test_volume_target(node_id\u003dnode.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_970311b8","line":370,"range":{"start_line":370,"start_character":27,"end_line":370,"end_character":30},"in_reply_to":"bab6814e_e15f3f73","updated":"2016-05-25 09:12:58.000000000","message":"I was just referring to the grammatical part of the naming, keeping in mind that the test case name usually depicts the intent of the test. So, to keep the consistency it could be either of the two:\n\n  test_volume_target_gets_destroyed_after_destroying_a_node\n  test_volume_targets_get_destroyed_after_destroying_a_node\n\nOf course, it\u0027s an absolute nit.","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":16635,"name":"deray","email":"debayan.ray@gmail.com","username":"deray"},"change_message_id":"1bffce0b91070b399da3cf97a478c0bfe985a783","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        self.assertRaises(exception.VolumeTargetNotFound,"},{"line_number":378,"context_line":"                          self.dbapi.get_volume_target_by_id, target.id)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def test_volume_target_get_destroyed_after_destroying_a_node_uuid(self):"},{"line_number":381,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        target \u003d utils.create_test_volume_target(node_id\u003dnode.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_bdc72111","line":380,"range":{"start_line":380,"start_character":27,"end_line":380,"end_character":30},"updated":"2016-05-19 09:33:27.000000000","message":"ditto as above","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a978e713b89bbde60fa4cbe4a7a46c4a7e6bc59b","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        self.assertRaises(exception.VolumeTargetNotFound,"},{"line_number":378,"context_line":"                          self.dbapi.get_volume_target_by_id, target.id)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def test_volume_target_get_destroyed_after_destroying_a_node_uuid(self):"},{"line_number":381,"context_line":"        node \u003d utils.create_test_node()"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        target \u003d utils.create_test_volume_target(node_id\u003dnode.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_806a2618","line":380,"range":{"start_line":380,"start_character":27,"end_line":380,"end_character":30},"in_reply_to":"bab6814e_bdc72111","updated":"2016-06-14 16:30:21.000000000","message":"Done","commit_id":"bcfcb7013ba03a79cac328f53db8b345f65109d1"}],"ironic/tests/unit/db/test_volume_targets.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7ddd23d6a1b1fae2d1ad37a5bd9de51c4af0385c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                          self.dbapi.update_volume_target,"},{"line_number":106,"context_line":"                          self.target.id,"},{"line_number":107,"context_line":"                          {\u0027uuid\u0027: \u0027\u0027})"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_create_volume_target_duplicated_uuid(self):"},{"line_number":110,"context_line":"        self.assertRaises(exception.VolumeTargetAlreadyExists,"},{"line_number":111,"context_line":"                          db_utils.create_test_volume_target,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_db429a67","line":108,"updated":"2016-07-30 14:56:30.000000000","message":"I prefer adding a test for a case where update_volume_target raises VolumeTargetValueAlreadyExists.","commit_id":"016cb90a74df6b99695606d5f3a98ad4f60dbe5d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"376d8f50f81fcb00467f650d2cd7fc8007da91f5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                          self.dbapi.update_volume_target,"},{"line_number":106,"context_line":"                          self.target.id,"},{"line_number":107,"context_line":"                          {\u0027uuid\u0027: \u0027\u0027})"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_create_volume_target_duplicated_uuid(self):"},{"line_number":110,"context_line":"        self.assertRaises(exception.VolumeTargetAlreadyExists,"},{"line_number":111,"context_line":"                          db_utils.create_test_volume_target,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_e3fb3777","line":108,"in_reply_to":"bacf61ea_db429a67","updated":"2016-08-01 20:34:03.000000000","message":"Done","commit_id":"016cb90a74df6b99695606d5f3a98ad4f60dbe5d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.assertEqual(1, len(res))"},{"line_number":109,"context_line":"        self.assertEqual(self.target.volume_type, res[0].volume_type)"},{"line_number":110,"context_line":"        self.assertEqual(self.target.properties, res[0].properties)"},{"line_number":111,"context_line":"        self.assertEqual(self.target.boot_index, res[0].boot_index)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_get_volume_targets_by_node_id_that_does_not_exist(self):"},{"line_number":114,"context_line":"        self.assertEqual([], self.dbapi.get_volume_targets_by_node_id(99))"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_dbfed504","line":111,"updated":"2016-12-01 14:41:26.000000000","message":"I feel like this should create another target for a different node (or no node). As the test currently stands, I could change get_volume_targets_by_node_id to not filter by node, and this would still pass.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59fa9b2ccdc6dc3dbd976b3b66bd2316ee7366be","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.assertEqual(1, len(res))"},{"line_number":109,"context_line":"        self.assertEqual(self.target.volume_type, res[0].volume_type)"},{"line_number":110,"context_line":"        self.assertEqual(self.target.properties, res[0].properties)"},{"line_number":111,"context_line":"        self.assertEqual(self.target.boot_index, res[0].boot_index)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_get_volume_targets_by_node_id_that_does_not_exist(self):"},{"line_number":114,"context_line":"        self.assertEqual([], self.dbapi.get_volume_targets_by_node_id(99))"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_a193a7a2","line":111,"in_reply_to":"3a71b18c_dbfed504","updated":"2016-12-01 16:02:24.000000000","message":"Good point.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        old_boot_index \u003d self.target.boot_index"},{"line_number":118,"context_line":"        new_boot_index \u003d 100"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.assertNotEqual(old_boot_index, new_boot_index)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        res \u003d self.dbapi.update_volume_target(self.target.id,"},{"line_number":123,"context_line":"                                              {\u0027boot_index\u0027: new_boot_index})"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_bb48395d","line":120,"updated":"2016-12-01 14:41:26.000000000","message":"Instead of hardcoding 100 and making sure they\u0027re the same, why don\u0027t we do new_boot_index \u003d old_boot_index+1?","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59fa9b2ccdc6dc3dbd976b3b66bd2316ee7366be","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        old_boot_index \u003d self.target.boot_index"},{"line_number":118,"context_line":"        new_boot_index \u003d 100"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.assertNotEqual(old_boot_index, new_boot_index)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        res \u003d self.dbapi.update_volume_target(self.target.id,"},{"line_number":123,"context_line":"                                              {\u0027boot_index\u0027: new_boot_index})"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_a13c8730","line":120,"in_reply_to":"3a71b18c_bb48395d","updated":"2016-12-01 16:02:24.000000000","message":"Yup","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b5b16b121d81488e445b582e30655d27e62dcbe","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertRaises(exception.InvalidParameterValue,"},{"line_number":132,"context_line":"                          self.dbapi.update_volume_target,"},{"line_number":133,"context_line":"                          self.target.id,"},{"line_number":134,"context_line":"                          {\u0027uuid\u0027: \u0027\u0027})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_update_volume_target_fails_invalid_id(self):"},{"line_number":137,"context_line":"        self.assertRaises(exception.VolumeTargetNotFound,"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_7bace1ed","line":134,"updated":"2016-12-01 14:41:26.000000000","message":"I\u0027d rather use a real UUID here, to test that it fails because we don\u0027t want UUID to change, not because it\u0027s an invalid UUID. (yes I know we don\u0027t validate the UUID now, but it\u0027s an easy fix for extra reassurance)","commit_id":"212a645c734976de396a8d251091cacdbfd07775"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59fa9b2ccdc6dc3dbd976b3b66bd2316ee7366be","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.assertRaises(exception.InvalidParameterValue,"},{"line_number":132,"context_line":"                          self.dbapi.update_volume_target,"},{"line_number":133,"context_line":"                          self.target.id,"},{"line_number":134,"context_line":"                          {\u0027uuid\u0027: \u0027\u0027})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_update_volume_target_fails_invalid_id(self):"},{"line_number":137,"context_line":"        self.assertRaises(exception.VolumeTargetNotFound,"}],"source_content_type":"text/x-python","patch_set":42,"id":"3a71b18c_41fe536c","line":134,"in_reply_to":"3a71b18c_7bace1ed","updated":"2016-12-01 16:02:24.000000000","message":"Yup.","commit_id":"212a645c734976de396a8d251091cacdbfd07775"}],"ironic/tests/unit/db/utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cd0bedfeb16a7cec001edcc9a91de260099b48f6","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"def get_test_volume_target(**kw):"},{"line_number":314,"context_line":"    fake_properties \u003d {\"target_iqn\": \"iqn.foo\"}"},{"line_number":315,"context_line":"    return {"},{"line_number":316,"context_line":"        \u0027id\u0027: kw.get(\u0027id\u0027, 789),"},{"line_number":317,"context_line":"        \u0027uuid\u0027: kw.get(\u0027uuid\u0027, \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c781\u0027),"},{"line_number":318,"context_line":"        \u0027node_id\u0027: kw.get(\u0027node_id\u0027, 123),"},{"line_number":319,"context_line":"        \u0027driver_volume_type\u0027: kw.get(\u0027driver_volume_type\u0027, \u0027iscsi\u0027),"},{"line_number":320,"context_line":"        \u0027target_properties\u0027: kw.get(\u0027target_properties\u0027, fake_properties),"},{"line_number":321,"context_line":"        \u0027boot_index\u0027: kw.get(\u0027boot_index\u0027, 0),"},{"line_number":322,"context_line":"        \u0027extra\u0027: kw.get(\u0027extra\u0027, {}),"},{"line_number":323,"context_line":"        \u0027created_at\u0027: kw.get(\u0027created_at\u0027),"},{"line_number":324,"context_line":"        \u0027updated_at\u0027: kw.get(\u0027updated_at\u0027),"},{"line_number":325,"context_line":"    }"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_49a88fdb","line":324,"range":{"start_line":315,"start_character":5,"end_line":324,"end_character":43},"updated":"2016-07-20 20:59:50.000000000","message":"This needs to be synced up with the specification.","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1812306435419884806604b2c1f36ff4fa175b9d","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"def get_test_volume_target(**kw):"},{"line_number":314,"context_line":"    fake_properties \u003d {\"target_iqn\": \"iqn.foo\"}"},{"line_number":315,"context_line":"    return {"},{"line_number":316,"context_line":"        \u0027id\u0027: kw.get(\u0027id\u0027, 789),"},{"line_number":317,"context_line":"        \u0027uuid\u0027: kw.get(\u0027uuid\u0027, \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c781\u0027),"},{"line_number":318,"context_line":"        \u0027node_id\u0027: kw.get(\u0027node_id\u0027, 123),"},{"line_number":319,"context_line":"        \u0027driver_volume_type\u0027: kw.get(\u0027driver_volume_type\u0027, \u0027iscsi\u0027),"},{"line_number":320,"context_line":"        \u0027target_properties\u0027: kw.get(\u0027target_properties\u0027, fake_properties),"},{"line_number":321,"context_line":"        \u0027boot_index\u0027: kw.get(\u0027boot_index\u0027, 0),"},{"line_number":322,"context_line":"        \u0027extra\u0027: kw.get(\u0027extra\u0027, {}),"},{"line_number":323,"context_line":"        \u0027created_at\u0027: kw.get(\u0027created_at\u0027),"},{"line_number":324,"context_line":"        \u0027updated_at\u0027: kw.get(\u0027updated_at\u0027),"},{"line_number":325,"context_line":"    }"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_3f9fdbb5","line":324,"range":{"start_line":315,"start_character":5,"end_line":324,"end_character":43},"in_reply_to":"dada55a8_49a88fdb","updated":"2016-07-22 19:14:11.000000000","message":"Done","commit_id":"7e8a2e0fcc2b31f5d3f2fa14aebc5a697dd5dadf"}]}
