)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"04816b15db005e48348e27b226ffffc18b196c16","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"                 not exist."},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        \"\"\""},{"line_number":1564,"context_line":"        LOG.debug(\u0027RPC destroy_volume_target called for volume target\u0027"},{"line_number":1565,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1566,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1567,"context_line":"        with task_manager.acquire(context, target.node_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_fe32e25c","line":1564,"range":{"start_line":1564,"start_character":69,"end_line":1564,"end_character":70},"updated":"2016-07-31 14:42:07.000000000","message":"A space is necessary.","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"31fe7df39b5dc22defd52072c7dec40fd7c1ef2e","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"                 not exist."},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        \"\"\""},{"line_number":1564,"context_line":"        LOG.debug(\u0027RPC destroy_volume_target called for volume target\u0027"},{"line_number":1565,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1566,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1567,"context_line":"        with task_manager.acquire(context, target.node_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_5c8141fa","line":1564,"range":{"start_line":1564,"start_character":69,"end_line":1564,"end_character":70},"in_reply_to":"bacf61ea_fe32e25c","updated":"2016-08-02 18:17:03.000000000","message":"Done","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"                 not exist."},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        \"\"\""},{"line_number":1564,"context_line":"        LOG.debug(\u0027RPC destroy_volume_target called for volume target\u0027"},{"line_number":1565,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1566,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1567,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1568,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1569,"context_line":"            target.destroy()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_afcc9dbb","line":1566,"range":{"start_line":1564,"start_character":8,"end_line":1566,"end_character":42},"updated":"2016-08-01 13:17:03.000000000","message":"I think the most aligned way of logging is replace that by: LOG.debug(\u0027RPC destroy_volume_target called for volume target %s.\u0027, target.uuid)","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"31fe7df39b5dc22defd52072c7dec40fd7c1ef2e","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"                 not exist."},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        \"\"\""},{"line_number":1564,"context_line":"        LOG.debug(\u0027RPC destroy_volume_target called for volume target\u0027"},{"line_number":1565,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1566,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1567,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1568,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1569,"context_line":"            target.destroy()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_5caf817c","line":1566,"range":{"start_line":1564,"start_character":8,"end_line":1566,"end_character":42},"in_reply_to":"bacf61ea_afcc9dbb","updated":"2016-08-02 18:17:03.000000000","message":"As the change currently stands, this is consistent with the style of the other log entries.","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"04816b15db005e48348e27b226ffffc18b196c16","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1568,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1569,"context_line":"            target.destroy()"},{"line_number":1570,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target\u0027"},{"line_number":1571,"context_line":"                         \u0027%(target)s. \u0027"},{"line_number":1572,"context_line":"                         \u0027The node associated with the target was %(node)s\u0027),"},{"line_number":1573,"context_line":"                     {\u0027target\u0027: target.uuid, \u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_fe094285","line":1570,"range":{"start_line":1570,"start_character":60,"end_line":1570,"end_character":61},"updated":"2016-07-31 14:42:07.000000000","message":"ditto","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1568,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1569,"context_line":"            target.destroy()"},{"line_number":1570,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target\u0027"},{"line_number":1571,"context_line":"                         \u0027%(target)s. \u0027"},{"line_number":1572,"context_line":"                         \u0027The node associated with the target was %(node)s\u0027),"},{"line_number":1573,"context_line":"                     {\u0027target\u0027: target.uuid, \u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_cfb3d108","line":1570,"range":{"start_line":1570,"start_character":60,"end_line":1570,"end_character":61},"in_reply_to":"bacf61ea_fe094285","updated":"2016-08-01 13:17:03.000000000","message":"+1","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"31fe7df39b5dc22defd52072c7dec40fd7c1ef2e","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1568,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1569,"context_line":"            target.destroy()"},{"line_number":1570,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target\u0027"},{"line_number":1571,"context_line":"                         \u0027%(target)s. \u0027"},{"line_number":1572,"context_line":"                         \u0027The node associated with the target was %(node)s\u0027),"},{"line_number":1573,"context_line":"                     {\u0027target\u0027: target.uuid, \u0027node\u0027: task.node.uuid})"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_3cb28de5","line":1570,"range":{"start_line":1570,"start_character":60,"end_line":1570,"end_character":61},"in_reply_to":"bacf61ea_fe094285","updated":"2016-08-02 18:17:03.000000000","message":"Done","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"        :returns: a updated volume connector object."},{"line_number":1839,"context_line":"        :raises: NodeLocked if the node is already locked."},{"line_number":1840,"context_line":"        \"\"\""},{"line_number":1841,"context_line":"        connector_uuid \u003d connector.uuid"},{"line_number":1842,"context_line":"        LOG.debug(\"RPC update_volume_connector called for connector %s.\","},{"line_number":1843,"context_line":"                  connector_uuid)"},{"line_number":1844,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_5a9f9d5e","line":1841,"range":{"start_line":1841,"start_character":8,"end_line":1841,"end_character":39},"updated":"2016-08-01 13:17:03.000000000","message":"ditto","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"31fe7df39b5dc22defd52072c7dec40fd7c1ef2e","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"        :returns: a updated volume connector object."},{"line_number":1839,"context_line":"        :raises: NodeLocked if the node is already locked."},{"line_number":1840,"context_line":"        \"\"\""},{"line_number":1841,"context_line":"        connector_uuid \u003d connector.uuid"},{"line_number":1842,"context_line":"        LOG.debug(\"RPC update_volume_connector called for connector %s.\","},{"line_number":1843,"context_line":"                  connector_uuid)"},{"line_number":1844,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_f6764c04","line":1841,"range":{"start_line":1841,"start_character":8,"end_line":1841,"end_character":39},"in_reply_to":"bacf61ea_5a9f9d5e","updated":"2016-08-02 18:17:03.000000000","message":"Done in the earlier change in the series where this change is more relevant.","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1845,"context_line":"        with task_manager.acquire(context, connector.node_id,"},{"line_number":1846,"context_line":"                                  purpose\u003d\u0027volume connector update\u0027):"},{"line_number":1847,"context_line":"            connector.save()"},{"line_number":1848,"context_line":"            LOG.info(_LI(\"Successfully updated volume connector \""},{"line_number":1849,"context_line":"                         \"%(connector)s.\"),"},{"line_number":1850,"context_line":"                     {\u0027connector\u0027: connector_uuid})"},{"line_number":1851,"context_line":"            return connector"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_dab38d08","line":1850,"range":{"start_line":1848,"start_character":0,"end_line":1850,"end_character":51},"updated":"2016-08-01 13:17:03.000000000","message":"LOG.INFO(_LI(\u0027Successfully updated volume connector %s.\u0027, connector.uuid)","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"                     {\u0027connector\u0027: connector_uuid})"},{"line_number":1851,"context_line":"            return connector"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1854,"context_line":"    def update_volume_target(self, context, target):"},{"line_number":1855,"context_line":"        \"\"\"Update a volume target."},{"line_number":1856,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_9a6115ac","line":1853,"range":{"start_line":1853,"start_character":4,"end_line":1853,"end_character":56},"updated":"2016-08-01 13:17:03.000000000","message":"Should it include \u0027exception.NodeNotFound\u0027?","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"            return connector"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1854,"context_line":"    def update_volume_target(self, context, target):"},{"line_number":1855,"context_line":"        \"\"\"Update a volume target."},{"line_number":1856,"context_line":""},{"line_number":1857,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_5a55ddc3","line":1854,"range":{"start_line":1854,"start_character":44,"end_line":1854,"end_character":50},"updated":"2016-08-01 13:17:03.000000000","message":"s/target/volume/ ?","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"31fe7df39b5dc22defd52072c7dec40fd7c1ef2e","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"            return connector"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1854,"context_line":"    def update_volume_target(self, context, target):"},{"line_number":1855,"context_line":"        \"\"\"Update a volume target."},{"line_number":1856,"context_line":""},{"line_number":1857,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_d6ece8bc","line":1854,"range":{"start_line":1854,"start_character":44,"end_line":1854,"end_character":50},"in_reply_to":"bacf61ea_5a55ddc3","updated":"2016-08-02 18:17:03.000000000","message":"I think target is appropriate here.","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1859,"context_line":"        :returns: a updated volume target object."},{"line_number":1860,"context_line":"        :raises: NodeLocked when the node is already locked."},{"line_number":1861,"context_line":"        \"\"\""},{"line_number":1862,"context_line":"        target_uuid \u003d target.uuid"},{"line_number":1863,"context_line":"        LOG.debug(\"RPC update_volume_target called for target %s.\","},{"line_number":1864,"context_line":"                  target_uuid)"},{"line_number":1865,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_ef24d50d","line":1862,"range":{"start_line":1862,"start_character":8,"end_line":1862,"end_character":33},"updated":"2016-08-01 13:17:03.000000000","message":"Not necessary, you can use just \u0027targer.uuid\u0027 since it is used only for logging (L1863)","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"31fe7df39b5dc22defd52072c7dec40fd7c1ef2e","unresolved":false,"context_lines":[{"line_number":1859,"context_line":"        :returns: a updated volume target object."},{"line_number":1860,"context_line":"        :raises: NodeLocked when the node is already locked."},{"line_number":1861,"context_line":"        \"\"\""},{"line_number":1862,"context_line":"        target_uuid \u003d target.uuid"},{"line_number":1863,"context_line":"        LOG.debug(\"RPC update_volume_target called for target %s.\","},{"line_number":1864,"context_line":"                  target_uuid)"},{"line_number":1865,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_56b638f9","line":1862,"range":{"start_line":1862,"start_character":8,"end_line":1862,"end_character":33},"in_reply_to":"bacf61ea_ef24d50d","updated":"2016-08-02 18:17:03.000000000","message":"Done","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1860,"context_line":"        :raises: NodeLocked when the node is already locked."},{"line_number":1861,"context_line":"        \"\"\""},{"line_number":1862,"context_line":"        target_uuid \u003d target.uuid"},{"line_number":1863,"context_line":"        LOG.debug(\"RPC update_volume_target called for target %s.\","},{"line_number":1864,"context_line":"                  target_uuid)"},{"line_number":1865,"context_line":""},{"line_number":1866,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1867,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_6f8e252f","line":1864,"range":{"start_line":1863,"start_character":8,"end_line":1864,"end_character":30},"updated":"2016-08-01 13:17:03.000000000","message":"Nice","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"04816b15db005e48348e27b226ffffc18b196c16","unresolved":false,"context_lines":[{"line_number":1866,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1867,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":1868,"context_line":"            target.save()"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"            return target"},{"line_number":1871,"context_line":""},{"line_number":1872,"context_line":"    @messaging.expected_exceptions(exception.DriverNotFound)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_9e7f66df","line":1869,"updated":"2016-07-31 14:42:07.000000000","message":"LOG.info is missing compared to update_volume_connector method.","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":1866,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1867,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":1868,"context_line":"            target.save()"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"            return target"},{"line_number":1871,"context_line":""},{"line_number":1872,"context_line":"    @messaging.expected_exceptions(exception.DriverNotFound)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_9a08f5db","line":1869,"in_reply_to":"bacf61ea_9e7f66df","updated":"2016-08-01 13:17:03.000000000","message":"+1","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"31fe7df39b5dc22defd52072c7dec40fd7c1ef2e","unresolved":false,"context_lines":[{"line_number":1866,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1867,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":1868,"context_line":"            target.save()"},{"line_number":1869,"context_line":""},{"line_number":1870,"context_line":"            return target"},{"line_number":1871,"context_line":""},{"line_number":1872,"context_line":"    @messaging.expected_exceptions(exception.DriverNotFound)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_367c64eb","line":1869,"in_reply_to":"bacf61ea_9e7f66df","updated":"2016-08-02 18:17:03.000000000","message":"Done","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"5c8079941e9522a0b6f6148df8fc2271b2d0bc4c","unresolved":false,"context_lines":[{"line_number":1571,"context_line":"                         \u0027%(node)s\u0027),"},{"line_number":1572,"context_line":"                     {\u0027connector\u0027: connector.uuid, \u0027node\u0027: task.node.uuid})"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":1575,"context_line":"                                   exception.NodeNotFound)"},{"line_number":1576,"context_line":"    def destroy_volume_target(self, context, target):"},{"line_number":1577,"context_line":"        \"\"\"Delete a volume target."}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_30410664","line":1574,"updated":"2016-09-02 14:04:48.000000000","message":"It would be better to add @METRICS.timer.","commit_id":"ecaf4cd26600496731c1b0a98e050855ede901b5"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"5c8079941e9522a0b6f6148df8fc2271b2d0bc4c","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                     {\u0027connector\u0027: connector.uuid})"},{"line_number":1914,"context_line":"            return connector"},{"line_number":1915,"context_line":""},{"line_number":1916,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":1917,"context_line":"    def update_volume_target(self, context, target):"},{"line_number":1918,"context_line":"        \"\"\"Update a volume target."},{"line_number":1919,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"fa7ab95a_d0529a34","line":1916,"updated":"2016-09-02 14:04:48.000000000","message":"ditto","commit_id":"ecaf4cd26600496731c1b0a98e050855ede901b5"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"4b475116d02352c23b10847ce120c3332c9f9fe2","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"        LOG.debug(\u0027RPC destroy_volume_target called for volume target \u0027"},{"line_number":1579,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1580,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1581,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1582,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1583,"context_line":"            target.destroy()"},{"line_number":1584,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target \u0027"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5da102_93ec60bc","line":1581,"updated":"2016-11-03 21:39:30.000000000","message":"proper locks from discussion in patch set 30 are here, for anyone else looking","commit_id":"fa0018f4089d5ae79f07eb175b85297fd5919891"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"316aa546e35a67e584f50fc45f43926fe0909bbd","unresolved":false,"context_lines":[{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1948,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":1949,"context_line":"            target.save()"},{"line_number":1950,"context_line":"            LOG.info(_LI(\"Successfully updated volume target %(target)s.\"),"},{"line_number":1951,"context_line":"                     {\u0027target\u0027: target.uuid})"},{"line_number":1952,"context_line":"            return target"}],"source_content_type":"text/x-python","patch_set":41,"id":"5a74a57a_04183274","line":1949,"updated":"2016-11-28 20:28:02.000000000","message":"Julia had mentioned that we had to be more careful when updating the volume target, depending on the state of the node.","commit_id":"6e14aca63b22e6096bb37df9d2b36d051851cd0e"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"990bf8ec157720062db982d9d1fae6edf1915688","unresolved":false,"context_lines":[{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1948,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":1949,"context_line":"            target.save()"},{"line_number":1950,"context_line":"            LOG.info(_LI(\"Successfully updated volume target %(target)s.\"),"},{"line_number":1951,"context_line":"                     {\u0027target\u0027: target.uuid})"},{"line_number":1952,"context_line":"            return target"}],"source_content_type":"text/x-python","patch_set":41,"id":"5a74a57a_a475be64","line":1949,"in_reply_to":"5a74a57a_04183274","updated":"2016-11-28 20:34:53.000000000","message":"So, in thinking about this, I don\u0027t think we necessarily need to put checks in the conductor, at least right now.  This is because updates only update informational records.  The changes only take effect when the node is powered down and then powered back up since we need to handle attachments. tl;dr caveats will end up needing to be in documentation, and we could likely put something in later on past the initial support since then it would be a reconciliation.\n\nOff the top of my head.  we could block if power is on and the target boot_index \u003d\u003d 0, but again, this is all informational right now.","commit_id":"6e14aca63b22e6096bb37df9d2b36d051851cd0e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ba2ea453372d1b5d27c6cb98b074b299830a8204","unresolved":false,"context_lines":[{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1948,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":1949,"context_line":"            target.save()"},{"line_number":1950,"context_line":"            LOG.info(_LI(\"Successfully updated volume target %(target)s.\"),"},{"line_number":1951,"context_line":"                     {\u0027target\u0027: target.uuid})"},{"line_number":1952,"context_line":"            return target"}],"source_content_type":"text/x-python","patch_set":41,"id":"5a74a57a_849b6265","line":1949,"in_reply_to":"5a74a57a_a475be64","updated":"2016-11-28 20:39:16.000000000","message":"Thx Julia, I think if nothing breaks with the update then we\u0027re fine. Might not be great from the user\u0027s perspective(if they expect the change to take effect right away) but as long as we document it, we should be good. For now anyway :)","commit_id":"6e14aca63b22e6096bb37df9d2b36d051851cd0e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3ceb74afcbc22e2640b451cd209452d2617c1d31","unresolved":false,"context_lines":[{"line_number":1594,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1595,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1596,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1597,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1598,"context_line":"            target.destroy()"},{"line_number":1599,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target %(target)s. \u0027"},{"line_number":1600,"context_line":"                         \u0027The node associated with the target was %(node)s\u0027),"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_7887720f","line":1597,"updated":"2016-12-01 20:39:23.000000000","message":"Does the node need to be locked for this?","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ad45f353bab150de571f574530a9fc89e6c1aa1","unresolved":false,"context_lines":[{"line_number":1594,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1595,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1596,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1597,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1598,"context_line":"            target.destroy()"},{"line_number":1599,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target %(target)s. \u0027"},{"line_number":1600,"context_line":"                         \u0027The node associated with the target was %(node)s\u0027),"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_844dc074","line":1597,"in_reply_to":"3a71b18c_7887720f","updated":"2016-12-02 03:05:54.000000000","message":"Good questions. For what is being done with the volume target now -- no, I don\u0027t think so. for that matter, I don\u0027t even think the task manager is necessary. It could be deleted at the API layer. However, I suspect we will end up doing something more with this target \u0026 associated node. So I think we should leave it as is with the locked node, until we see where this is going... (Ie, better safe than sorry.)\n\nwdyt?","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"18063aeb7ec6d7c4450611c6572d505cab9902bf","unresolved":false,"context_lines":[{"line_number":1594,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1595,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1596,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1597,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1598,"context_line":"            target.destroy()"},{"line_number":1599,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target %(target)s. \u0027"},{"line_number":1600,"context_line":"                         \u0027The node associated with the target was %(node)s\u0027),"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_3dc0617c","line":1597,"in_reply_to":"3a71b18c_844dc074","updated":"2016-12-02 13:55:50.000000000","message":"Yeah, probably fine, I just don\u0027t like how much we lock things :)","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3ceb74afcbc22e2640b451cd209452d2617c1d31","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1999,"context_line":""},{"line_number":2000,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":2001,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":2002,"context_line":"            target.save()"},{"line_number":2003,"context_line":"            LOG.info(_LI(\"Successfully updated volume target %(target)s.\"),"},{"line_number":2004,"context_line":"                     {\u0027target\u0027: target.uuid})"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_b8790a32","line":2001,"updated":"2016-12-01 20:39:23.000000000","message":"Ditto","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ad45f353bab150de571f574530a9fc89e6c1aa1","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1999,"context_line":""},{"line_number":2000,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":2001,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":2002,"context_line":"            target.save()"},{"line_number":2003,"context_line":"            LOG.info(_LI(\"Successfully updated volume target %(target)s.\"),"},{"line_number":2004,"context_line":"                     {\u0027target\u0027: target.uuid})"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_0442903e","line":2001,"in_reply_to":"3a71b18c_b8790a32","updated":"2016-12-02 03:05:54.000000000","message":"ditto.","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3a12810b6fca19e261a17e54ed8aa031ffee939","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"        LOG.debug(\u0027RPC destroy_volume_target called for volume target \u0027"},{"line_number":1594,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1595,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1596,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1597,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1598,"context_line":"            target.destroy()"},{"line_number":1599,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target %(target)s. \u0027"}],"source_content_type":"text/x-python","patch_set":46,"id":"3a71b18c_48f47d86","line":1596,"range":{"start_line":1596,"start_character":43,"end_line":1596,"end_character":57},"updated":"2016-12-02 14:24:00.000000000","message":"can we safely assume that node_id is never None?","commit_id":"aab505a69842beb776410761d451d13a132bd3d2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"04ac022f86088a8b29e43c85e72f94a2287d5dea","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"        LOG.debug(\u0027RPC destroy_volume_target called for volume target \u0027"},{"line_number":1594,"context_line":"                  \u0027%(target)s\u0027,"},{"line_number":1595,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1596,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":1597,"context_line":"                                  purpose\u003d\u0027volume target deletion\u0027) as task:"},{"line_number":1598,"context_line":"            target.destroy()"},{"line_number":1599,"context_line":"            LOG.info(_LI(\u0027Successfully deleted volume target %(target)s. \u0027"}],"source_content_type":"text/x-python","patch_set":46,"id":"3a71b18c_23e842e2","line":1596,"range":{"start_line":1596,"start_character":43,"end_line":1596,"end_character":57},"in_reply_to":"3a71b18c_48f47d86","updated":"2016-12-02 14:50:50.000000000","message":"I think so, it\u0027s the same situation as with eg ports.","commit_id":"aab505a69842beb776410761d451d13a132bd3d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3a12810b6fca19e261a17e54ed8aa031ffee939","unresolved":false,"context_lines":[{"line_number":1997,"context_line":"        LOG.debug(\"RPC update_volume_target called for target %(target)s.\","},{"line_number":1998,"context_line":"                  {\u0027target\u0027: target.uuid})"},{"line_number":1999,"context_line":""},{"line_number":2000,"context_line":"        with task_manager.acquire(context, target.node_id,"},{"line_number":2001,"context_line":"                                  purpose\u003d\u0027volume target update\u0027):"},{"line_number":2002,"context_line":"            target.save()"},{"line_number":2003,"context_line":"            LOG.info(_LI(\"Successfully updated volume target %(target)s.\"),"}],"source_content_type":"text/x-python","patch_set":46,"id":"3a71b18c_0839a541","line":2000,"range":{"start_line":2000,"start_character":49,"end_line":2000,"end_character":57},"updated":"2016-12-02 14:24:00.000000000","message":"ditto","commit_id":"aab505a69842beb776410761d451d13a132bd3d2"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"aa162198ba9053c2577674942688df35e08cb463","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    |    1.32 - Add do_node_clean"},{"line_number":82,"context_line":"    |    1.33 - Added update and destroy portgroup."},{"line_number":83,"context_line":"    |    1.34 - Added destroy_volume_connector and update_volume_connector"},{"line_number":84,"context_line":"    |    1.35 - Added destory_volume_target and update_volume_target"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_101ff5b7","line":84,"updated":"2016-04-06 11:56:09.000000000","message":"s/destory/destroy/","commit_id":"fe289bca0a2122b0027d0ec07cc0b464888dede5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a9e6814080ae6aa7dded9eb701d726b346e35c06","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    |    1.32 - Add do_node_clean"},{"line_number":82,"context_line":"    |    1.33 - Added update and destroy portgroup."},{"line_number":83,"context_line":"    |    1.34 - Added destroy_volume_connector and update_volume_connector"},{"line_number":84,"context_line":"    |    1.35 - Added destory_volume_target and update_volume_target"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_547da06b","line":84,"in_reply_to":"9a061dce_101ff5b7","updated":"2016-06-14 17:24:51.000000000","message":"Done","commit_id":"fe289bca0a2122b0027d0ec07cc0b464888dede5"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":773,"context_line":"        \"\"\"Delete a volume target."},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        :param context: request context."},{"line_number":776,"context_line":"        :param target: volume target object"},{"line_number":777,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":778,"context_line":"        :raises: NodeLocked if node is locked by another conductor."},{"line_number":779,"context_line":"        :raises: NodeNotFound if the node associated with the target does"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_fa24910d","line":776,"range":{"start_line":776,"start_character":37,"end_line":776,"end_character":43},"updated":"2016-08-01 13:17:03.000000000","message":"ultra nit: just to keep it consistent, add period.","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"31fe7df39b5dc22defd52072c7dec40fd7c1ef2e","unresolved":false,"context_lines":[{"line_number":773,"context_line":"        \"\"\"Delete a volume target."},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        :param context: request context."},{"line_number":776,"context_line":"        :param target: volume target object"},{"line_number":777,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":778,"context_line":"        :raises: NodeLocked if node is locked by another conductor."},{"line_number":779,"context_line":"        :raises: NodeNotFound if the node associated with the target does"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_bfb82f12","line":776,"range":{"start_line":776,"start_character":37,"end_line":776,"end_character":43},"in_reply_to":"bacf61ea_fa24910d","updated":"2016-08-02 18:17:03.000000000","message":"Done","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"419a114eac5f2f5f3083192bba49693a158cde99","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":778,"context_line":"        :raises: NodeLocked if node is locked by another conductor."},{"line_number":779,"context_line":"        :raises: NodeNotFound if the node associated with the target does"},{"line_number":780,"context_line":"                 not exist."},{"line_number":781,"context_line":"        \"\"\""},{"line_number":782,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.36\u0027)"},{"line_number":783,"context_line":"        return cctxt.call(context, \u0027destroy_volume_target\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"fa6399be_782c6802","line":780,"updated":"2016-10-20 18:04:17.000000000","message":"Would it also be possible for this exception to be raised here and below: exception.VolumeTargetNotFound ? I see this exception tested in other parts of this patch set.","commit_id":"fe7fa95a1940b59afc4ae5f31c4becc9a655e296"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"26c512b05432df8478cb4f7e276d269bb4f747e8","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":778,"context_line":"        :raises: NodeLocked if node is locked by another conductor."},{"line_number":779,"context_line":"        :raises: NodeNotFound if the node associated with the target does"},{"line_number":780,"context_line":"                 not exist."},{"line_number":781,"context_line":"        \"\"\""},{"line_number":782,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.36\u0027)"},{"line_number":783,"context_line":"        return cctxt.call(context, \u0027destroy_volume_target\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba5da102_33cd5466","line":780,"in_reply_to":"ba5da102_e72b1e80","updated":"2016-11-03 21:37:54.000000000","message":"I think it\u0027s fine with proper task locks on the node, after discussion here\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2016-11-03.log.html#t2016-11-03T21:26:25","commit_id":"fe7fa95a1940b59afc4ae5f31c4becc9a655e296"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1ea84ca95ad9cadf688bf8ee07183c704340f373","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        :param topic: RPC topic. Defaults to self.topic."},{"line_number":778,"context_line":"        :raises: NodeLocked if node is locked by another conductor."},{"line_number":779,"context_line":"        :raises: NodeNotFound if the node associated with the target does"},{"line_number":780,"context_line":"                 not exist."},{"line_number":781,"context_line":"        \"\"\""},{"line_number":782,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.36\u0027)"},{"line_number":783,"context_line":"        return cctxt.call(context, \u0027destroy_volume_target\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba5da102_e72b1e80","line":780,"in_reply_to":"fa6399be_782c6802","updated":"2016-11-03 19:33:42.000000000","message":"So, technically I think it _could_, if we ignore the decorator, and have some sort of race between two rpc clients.  The decorator in the manager would cause it to be considered a fatal exception to the request.\n\nRealistically, I don\u0027t think it would really be the case unless two rpc clients are racing over the same action, and they already have the object they wish to destroy.  They would both attempt to lock the node. If the node is already locked, NodeLocked would be raised.  If the node corresponding to the target does not exist, then NodeNotFound would be raised.\n\nI guess it could be added and handled in the api client code as well to make a pretty error, but I\u0027m not sure that really gives us any sort of net gain.  Opinions anyone?","commit_id":"fe7fa95a1940b59afc4ae5f31c4becc9a655e296"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"04ac022f86088a8b29e43c85e72f94a2287d5dea","unresolved":false,"context_lines":[{"line_number":812,"context_line":"        :raises: VolumeTargetNotFound if the volume target cannot be found"},{"line_number":813,"context_line":"        \"\"\""},{"line_number":814,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.37\u0027)"},{"line_number":815,"context_line":"        return cctxt.call(context, \u0027destroy_volume_target\u0027,"},{"line_number":816,"context_line":"                          target\u003dtarget)"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def update_volume_target(self, context, target, topic\u003dNone):"}],"source_content_type":"text/x-python","patch_set":46,"id":"3a71b18c_63a07aa0","line":815,"range":{"start_line":815,"start_character":8,"end_line":815,"end_character":14},"updated":"2016-12-02 14:50:50.000000000","message":"conductor method does not seem to return anything","commit_id":"aab505a69842beb776410761d451d13a132bd3d2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"034749f80736670502a05e38e787bfb4bf321893","unresolved":false,"context_lines":[{"line_number":812,"context_line":"        :raises: VolumeTargetNotFound if the volume target cannot be found"},{"line_number":813,"context_line":"        \"\"\""},{"line_number":814,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.37\u0027)"},{"line_number":815,"context_line":"        return cctxt.call(context, \u0027destroy_volume_target\u0027,"},{"line_number":816,"context_line":"                          target\u003dtarget)"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def update_volume_target(self, context, target, topic\u003dNone):"}],"source_content_type":"text/x-python","patch_set":46,"id":"3a71b18c_54372ffe","line":815,"range":{"start_line":815,"start_character":8,"end_line":815,"end_character":14},"in_reply_to":"3a71b18c_63a07aa0","updated":"2016-12-06 18:31:40.000000000","message":"yes, that\u0027s true, it doesn\u0027t explicitly return anything (which means None). This follows the same pattern as the other destroy_* methods. (In fact, as all the other rpc methods I think.)\n\nI\u0027m not sure what cctxt.call() does. Oh, looks like it returns something [1] (if this is the right method).\n\n[1] https://github.com/openstack/oslo.messaging/blob/ea8fad47a57b1c8784a0a7c1fc435c4e38200863/oslo_messaging/rpc/client.py#L151","commit_id":"aab505a69842beb776410761d451d13a132bd3d2"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"39f3af8b9abc20d66b146de36e58b537355df477","unresolved":false,"context_lines":[{"line_number":4966,"context_line":"    def test_update_volume_target_driver_volume_type(self):"},{"line_number":4967,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"},{"line_number":4968,"context_line":"        volume_target \u003d obj_utils.create_test_volume_target("},{"line_number":4969,"context_line":"            self.context, node_id\u003dnode.id, extra\u003d{\u0027vol_id\u0027: \u0027fake-id\u0027})"},{"line_number":4970,"context_line":"        new_driver_volume_type \u003d \u0027fibre_channel\u0027"},{"line_number":4971,"context_line":"        volume_target.driver_volume_type \u003d new_driver_volume_type"},{"line_number":4972,"context_line":"        res \u003d self.service.update_volume_target(self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_09ce972d","line":4969,"range":{"start_line":4969,"start_character":48,"end_line":4969,"end_character":70},"updated":"2016-07-20 21:17:09.000000000","message":"maybe this should be volume_id instead of extra?","commit_id":"e5b9e988a406c239f90b1afb9794cd18b657ce84"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":5147,"context_line":"        self.assertRaises(exception.VolumeTargetNotFound,"},{"line_number":5148,"context_line":"                          volume_target.refresh)"},{"line_number":5149,"context_line":""},{"line_number":5150,"context_line":"    def test_destroy_volume_target_node_locked(self):"},{"line_number":5151,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":5152,"context_line":"                                          reservation\u003d\u0027fake-reserv\u0027)"},{"line_number":5153,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_75539217","line":5150,"range":{"start_line":5150,"start_character":8,"end_line":5150,"end_character":46},"updated":"2016-08-01 13:17:03.000000000","message":"Maybe a test for NodeNotFound?","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":5173,"context_line":"        res \u003d self.service.update_volume_target(self.context, volume_target)"},{"line_number":5174,"context_line":"        self.assertEqual(new_extra, res.extra)"},{"line_number":5175,"context_line":""},{"line_number":5176,"context_line":"    def test_update_volume_target_node_locked(self):"},{"line_number":5177,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027,"},{"line_number":5178,"context_line":"                                          reservation\u003d\u0027fake-reserv\u0027)"},{"line_number":5179,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_1545f644","line":5176,"range":{"start_line":5176,"start_character":8,"end_line":5176,"end_character":45},"updated":"2016-08-01 13:17:03.000000000","message":"Maybe a test for NodeNotFound?","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3ceb74afcbc22e2640b451cd209452d2617c1d31","unresolved":false,"context_lines":[{"line_number":5839,"context_line":"                                self.context, volume_target)"},{"line_number":5840,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":5841,"context_line":"        self.assertEqual(exception.NodeLocked, exc.exc_info[0])"},{"line_number":5842,"context_line":""},{"line_number":5843,"context_line":""},{"line_number":5844,"context_line":"@mgr_utils.mock_record_keepalive"},{"line_number":5845,"context_line":"class UpdateVolumeTargetTestCase(mgr_utils.ServiceSetUpMixin,"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_38e25ad6","line":5842,"updated":"2016-12-01 20:39:23.000000000","message":"Do we want test cases for NodeNotFound or TargetVolumeNotFound?","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ad45f353bab150de571f574530a9fc89e6c1aa1","unresolved":false,"context_lines":[{"line_number":5839,"context_line":"                                self.context, volume_target)"},{"line_number":5840,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":5841,"context_line":"        self.assertEqual(exception.NodeLocked, exc.exc_info[0])"},{"line_number":5842,"context_line":""},{"line_number":5843,"context_line":""},{"line_number":5844,"context_line":"@mgr_utils.mock_record_keepalive"},{"line_number":5845,"context_line":"class UpdateVolumeTargetTestCase(mgr_utils.ServiceSetUpMixin,"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_9f0a69d1","line":5842,"in_reply_to":"3a71b18c_38e25ad6","updated":"2016-12-02 03:05:54.000000000","message":"I don\u0027t really think it is worth it, but sure.","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"3ceb74afcbc22e2640b451cd209452d2617c1d31","unresolved":false,"context_lines":[{"line_number":5901,"context_line":"                                self.context, volume_target2)"},{"line_number":5902,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":5903,"context_line":"        self.assertEqual(exception.VolumeTargetBootIndexAlreadyExists,"},{"line_number":5904,"context_line":"                         exc.exc_info[0])"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_1804be7c","line":5904,"updated":"2016-12-01 20:39:23.000000000","message":"Same question","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3ad45f353bab150de571f574530a9fc89e6c1aa1","unresolved":false,"context_lines":[{"line_number":5901,"context_line":"                                self.context, volume_target2)"},{"line_number":5902,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":5903,"context_line":"        self.assertEqual(exception.VolumeTargetBootIndexAlreadyExists,"},{"line_number":5904,"context_line":"                         exc.exc_info[0])"}],"source_content_type":"text/x-python","patch_set":44,"id":"3a71b18c_fff99dc9","line":5904,"in_reply_to":"3a71b18c_1804be7c","updated":"2016-12-02 03:05:54.000000000","message":"Ok, let me know what you think. :)","commit_id":"0c507658822c4f0b80a5151228886eb8f7bd9106"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"04ac022f86088a8b29e43c85e72f94a2287d5dea","unresolved":false,"context_lines":[{"line_number":5840,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":5841,"context_line":"        self.assertEqual(exception.NodeLocked, exc.exc_info[0])"},{"line_number":5842,"context_line":""},{"line_number":5843,"context_line":"    def test_destroy_volume_target_node_gone(self):"},{"line_number":5844,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"},{"line_number":5845,"context_line":"        volume_target \u003d obj_utils.create_test_volume_target(self.context,"},{"line_number":5846,"context_line":"                                                            node_id\u003dnode.id)"},{"line_number":5847,"context_line":"        self.service.destroy_node(self.context, node.id)"},{"line_number":5848,"context_line":""},{"line_number":5849,"context_line":"        exc \u003d self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":5850,"context_line":"                                self.service.destroy_volume_target,"},{"line_number":5851,"context_line":"                                self.context, volume_target)"},{"line_number":5852,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":5853,"context_line":"        self.assertEqual(exception.NodeNotFound, exc.exc_info[0])"},{"line_number":5854,"context_line":""},{"line_number":5855,"context_line":"    def test_destroy_volume_target_already_destroyed(self):"},{"line_number":5856,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":46,"id":"3a71b18c_834af6aa","line":5853,"range":{"start_line":5843,"start_character":4,"end_line":5853,"end_character":65},"updated":"2016-12-02 14:50:50.000000000","message":"Actually, I\u0027m not sure whether this scenario is possible - if we\u0027ve removed the node, all the volume targets and volume connectors should be gone too, this happens on dbapi level. Same comment to such test for volume connector.","commit_id":"aab505a69842beb776410761d451d13a132bd3d2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8464b08319c8e5f696541d0ce90f829203a4b7b5","unresolved":false,"context_lines":[{"line_number":5840,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":5841,"context_line":"        self.assertEqual(exception.NodeLocked, exc.exc_info[0])"},{"line_number":5842,"context_line":""},{"line_number":5843,"context_line":"    def test_destroy_volume_target_node_gone(self):"},{"line_number":5844,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"},{"line_number":5845,"context_line":"        volume_target \u003d obj_utils.create_test_volume_target(self.context,"},{"line_number":5846,"context_line":"                                                            node_id\u003dnode.id)"},{"line_number":5847,"context_line":"        self.service.destroy_node(self.context, node.id)"},{"line_number":5848,"context_line":""},{"line_number":5849,"context_line":"        exc \u003d self.assertRaises(messaging.rpc.ExpectedException,"},{"line_number":5850,"context_line":"                                self.service.destroy_volume_target,"},{"line_number":5851,"context_line":"                                self.context, volume_target)"},{"line_number":5852,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":5853,"context_line":"        self.assertEqual(exception.NodeNotFound, exc.exc_info[0])"},{"line_number":5854,"context_line":""},{"line_number":5855,"context_line":"    def test_destroy_volume_target_already_destroyed(self):"},{"line_number":5856,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":46,"id":"3a71b18c_15de193f","line":5853,"range":{"start_line":5843,"start_character":4,"end_line":5853,"end_character":65},"in_reply_to":"3a71b18c_834af6aa","updated":"2016-12-02 14:58:20.000000000","message":"Ah, right, if we deleted the node after the volume target was fetched from db in api method and then passed to rpc.","commit_id":"aab505a69842beb776410761d451d13a132bd3d2"}],"ironic/tests/unit/conductor/test_rpcapi.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"04816b15db005e48348e27b226ffffc18b196c16","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                          connector\u003dfake_volume_connector)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def test_destroy_volume_target(self):"},{"line_number":419,"context_line":"        fake_volume_target \u003d dbutils.get_test_volume_target()"},{"line_number":420,"context_line":"        self._test_rpcapi(\u0027destroy_volume_target\u0027,"},{"line_number":421,"context_line":"                          \u0027call\u0027,"},{"line_number":422,"context_line":"                          version\u003d\u00271.36\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_1eaff62a","line":419,"updated":"2016-07-31 14:42:07.000000000","message":"nit: Strictly speaking, it might be better to call ironic.tests.unit.objects.util.get_test_volume_target because an object is required in actual cases. However, other existing tests also use dbutils and the type of arguments is not a matter here. Then, there is no problem about using dbutils.","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"5931791cf604452bfd53bc6261ab1e702370ec7c","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                          connector\u003dfake_volume_connector)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def test_destroy_volume_target(self):"},{"line_number":419,"context_line":"        fake_volume_target \u003d dbutils.get_test_volume_target()"},{"line_number":420,"context_line":"        self._test_rpcapi(\u0027destroy_volume_target\u0027,"},{"line_number":421,"context_line":"                          \u0027call\u0027,"},{"line_number":422,"context_line":"                          version\u003d\u00271.36\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_35711a45","line":419,"in_reply_to":"bacf61ea_1eaff62a","updated":"2016-08-01 13:17:03.000000000","message":"Hi guys, I\u0027m ok with keep this dbutils call and maintain the consistence with the whole code. Consistence first! :)","commit_id":"d905e42bf56dab76455c38af9ed30ebc45045760"}]}
