)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"834394b3825758910fdda2a42d32c72ed1f9c839","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make use of the wipe_root_device_metadata command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ie68cb6296c782e904d40f6e9de0faa52ab2af2bf introduces the"},{"line_number":10,"context_line":"\u0027wipe_root_device_metadata\u0027 commad. This command will clean up all"},{"line_number":11,"context_line":"the magic strings (partition table, RAID, LVM, etc) of the disk."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_fc493e32","line":9,"updated":"2016-03-03 21:31:09.000000000","message":"This change is not merged, please add a depends-on","commit_id":"35fbe21e578352a6bcaba408ef97e96a35fe0715"}],"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"834394b3825758910fdda2a42d32c72ed1f9c839","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    iscsi_options \u003d build_deploy_ramdisk_options(node)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    iqn \u003d iscsi_options[\u0027iscsi_target_iqn\u0027]"},{"line_number":441,"context_line":"    agent_client.wipe_root_device_metadata(node)"},{"line_number":442,"context_line":"    result \u003d agent_client.start_iscsi_target(node, iqn)"},{"line_number":443,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":444,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_e125155c","line":441,"updated":"2016-03-03 21:31:09.000000000","message":"Do we care about the result here?","commit_id":"35fbe21e578352a6bcaba408ef97e96a35fe0715"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"834394b3825758910fdda2a42d32c72ed1f9c839","unresolved":false,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    iqn \u003d iscsi_options[\u0027iscsi_target_iqn\u0027]"},{"line_number":441,"context_line":"    agent_client.wipe_root_device_metadata(node)"},{"line_number":442,"context_line":"    result \u003d agent_client.start_iscsi_target(node, iqn)"},{"line_number":443,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":444,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""},{"line_number":445,"context_line":"                 \"node %(node)s. Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_7c3d2e8e","line":442,"updated":"2016-03-03 21:31:09.000000000","message":"Also, I might be missing something, but wiping metadata is called futher here https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L345 , why do we need to make it before iscsi start? Apart from that in ^^ referred part of code, this wipe is called only when preserve_ephemeral\u003dFalse, now it will be always called. Should this be made conditional depending on instance_info[\u0027preserve_ephemeral\u0027]?","commit_id":"35fbe21e578352a6bcaba408ef97e96a35fe0715"}]}