)]}'
{"doc/source/deploy/install-guide.rst":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e857f65bca844eee62b850ec6fdbdcf037cea284","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"Ironic allows operators to choose which disk label they want their bare"},{"line_number":1378,"context_line":"metal node to be deployed with when Ironic is responsible for partitioning"},{"line_number":1379,"context_line":"the disk; therefore choosing the disk label do not apply when the image"},{"line_number":1380,"context_line":"being deployed is a ``whole disk images``."},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"There are some edge cases where someone may want to choose a specific"},{"line_number":1383,"context_line":"disk label for the images being deployed, including but not limited to:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7af24918_0e1a8c17","line":1380,"updated":"2016-03-07 03:29:35.000000000","message":"since agent_* only can deployed a whole disk images for now, maybe it worth to mention it here? as an example or warning?","commit_id":"2176da51768679584e4919ce08759a91d753a79e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58d113deaa032dc4e2dd45731841839332f3bd99","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"Ironic allows operators to choose which disk label they want their bare"},{"line_number":1378,"context_line":"metal node to be deployed with when Ironic is responsible for partitioning"},{"line_number":1379,"context_line":"the disk; therefore choosing the disk label do not apply when the image"},{"line_number":1380,"context_line":"being deployed is a ``whole disk images``."},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"There are some edge cases where someone may want to choose a specific"},{"line_number":1383,"context_line":"disk label for the images being deployed, including but not limited to:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_77eeb0ed","line":1380,"in_reply_to":"7af24918_0e1a8c17","updated":"2016-03-07 09:36:08.000000000","message":"+1, yeah partition image support is coming but while it\u0027s not here I will add a note to it","commit_id":"2176da51768679584e4919ce08759a91d753a79e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0a8174eb026e689dc671ed5c89e0173fb9038785","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"* For machines in ``bios`` boot mode with disks larger than 2 terabytes"},{"line_number":1386,"context_line":"  it\u0027s recommended to use a ``gpt`` disk label. That\u0027s because"},{"line_number":1387,"context_line":"  a capacity beyond 2 terabytes is not addressable by using the"},{"line_number":1388,"context_line":"  MBR partitioning type. But, although GPT claims to be backwards"},{"line_number":1389,"context_line":"  compatible with legacy BIOS systems `that\u0027s not always the case"},{"line_number":1390,"context_line":"  \u003chttp://www.rodsbooks.com/gdisk/bios.html\u003e`_."},{"line_number":1391,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7af24918_f38108fd","line":1388,"updated":"2016-03-07 05:24:42.000000000","message":"s/ backwards / backward /","commit_id":"2176da51768679584e4919ce08759a91d753a79e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58d113deaa032dc4e2dd45731841839332f3bd99","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"* For machines in ``bios`` boot mode with disks larger than 2 terabytes"},{"line_number":1386,"context_line":"  it\u0027s recommended to use a ``gpt`` disk label. That\u0027s because"},{"line_number":1387,"context_line":"  a capacity beyond 2 terabytes is not addressable by using the"},{"line_number":1388,"context_line":"  MBR partitioning type. But, although GPT claims to be backwards"},{"line_number":1389,"context_line":"  compatible with legacy BIOS systems `that\u0027s not always the case"},{"line_number":1390,"context_line":"  \u003chttp://www.rodsbooks.com/gdisk/bios.html\u003e`_."},{"line_number":1391,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_b7be78d2","line":1388,"in_reply_to":"7af24918_f38108fd","updated":"2016-03-07 09:36:08.000000000","message":"Done","commit_id":"2176da51768679584e4919ce08759a91d753a79e"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"e857f65bca844eee62b850ec6fdbdcf037cea284","unresolved":false,"context_lines":[{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"* When no boot mode setting is provided Ironic will configure it according"},{"line_number":1400,"context_line":"  to the `boot mode \u003cboot_mode_support_\u003e`_; ``bios`` boot mode will use"},{"line_number":1401,"context_line":"  ``msdos`` disk label and ``uefi`` boot mode will use ``gpt``."},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"* Only one disk label - either ``msdos`` or ``gpt`` - can be configured"},{"line_number":1404,"context_line":"  for the node."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7af24918_0edbac1c","line":1401,"updated":"2016-03-07 03:29:35.000000000","message":"if boot mode is uefi, will node has gpt as the capabilities vale?\nOh, I see the code in ironic-lib.","commit_id":"2176da51768679584e4919ce08759a91d753a79e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58d113deaa032dc4e2dd45731841839332f3bd99","unresolved":false,"context_lines":[{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"* When no boot mode setting is provided Ironic will configure it according"},{"line_number":1400,"context_line":"  to the `boot mode \u003cboot_mode_support_\u003e`_; ``bios`` boot mode will use"},{"line_number":1401,"context_line":"  ``msdos`` disk label and ``uefi`` boot mode will use ``gpt``."},{"line_number":1402,"context_line":""},{"line_number":1403,"context_line":"* Only one disk label - either ``msdos`` or ``gpt`` - can be configured"},{"line_number":1404,"context_line":"  for the node."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_979ffc5e","line":1401,"in_reply_to":"7af24918_0edbac1c","updated":"2016-03-07 09:36:08.000000000","message":"No the disk_label capability only needs to be set if you want to force a specific disk label. Of boot_mode is set to uefi but no disk_label is set, the code in ironic-lib will try to figure out which disk label it has to use according to the value of the boot_mode capability. In case it\u0027s UEFI ironic will partition the disk with GPT [0]\n\n[0] https://github.com/openstack/ironic-lib/blob/3bdfe793f40ba34e5f1e2cbe70dc813d95901b38/ironic_lib/disk_utils.py#L173-L174","commit_id":"2176da51768679584e4919ce08759a91d753a79e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0a8174eb026e689dc671ed5c89e0173fb9038785","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"  for the node."},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"* To set the appropriated disk label to a bare metal node the command"},{"line_number":1407,"context_line":"  bellow can be used::"},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/capabilities\u003d\u0027disk_label:gpt\u0027"},{"line_number":1410,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7af24918_33953040","line":1407,"updated":"2016-03-07 05:24:42.000000000","message":"nit: s/ bellow/ below /","commit_id":"2176da51768679584e4919ce08759a91d753a79e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"58d113deaa032dc4e2dd45731841839332f3bd99","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"  for the node."},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"* To set the appropriated disk label to a bare metal node the command"},{"line_number":1407,"context_line":"  bellow can be used::"},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/capabilities\u003d\u0027disk_label:gpt\u0027"},{"line_number":1410,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_376a681b","line":1407,"in_reply_to":"7af24918_33953040","updated":"2016-03-07 09:36:08.000000000","message":"Done","commit_id":"2176da51768679584e4919ce08759a91d753a79e"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"969bfbb5090f7d23721e984a3367260d1391dd59","unresolved":false,"context_lines":[{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/capabilities\u003d\u0027disk_label:gpt\u0027"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"  The nova flavor that will be responsible for requesting such capability"},{"line_number":1417,"context_line":"  also needs to be updated as::"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"    nova flavor-key baremetal set capabilities:disk_label\u003d\"gpt\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_7aafa7e3","line":1416,"range":{"start_line":1416,"start_character":0,"end_line":1416,"end_character":2},"updated":"2016-03-07 14:02:04.000000000","message":"missing * here?","commit_id":"f13cc64b60a1ed7680a5fc28251b0add00bc9952"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2d98021639808ba0813a035c8c6e4c6e53da9f8","unresolved":false,"context_lines":[{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/capabilities\u003d\u0027disk_label:gpt\u0027"},{"line_number":1415,"context_line":""},{"line_number":1416,"context_line":"  The nova flavor that will be responsible for requesting such capability"},{"line_number":1417,"context_line":"  also needs to be updated as::"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"    nova flavor-key baremetal set capabilities:disk_label\u003d\"gpt\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_572ba130","line":1416,"range":{"start_line":1416,"start_character":0,"end_line":1416,"end_character":2},"in_reply_to":"5aef4532_7aafa7e3","updated":"2016-03-07 15:15:35.000000000","message":"Hi there,\n\nThis was intentional, so the nova step is also included in the previous bullet point. See the rendered version: http://docs-draft.openstack.org/20/288520/2/check/gate-ironic-docs/a35a72b//doc/build/html/deploy/install-guide.html#choosing-the-disk-label\n\nIf you think the nova bits looks better as a separated bullet point, I\u0027ve no problem in updating the patch to do it. Let me know :-)","commit_id":"f13cc64b60a1ed7680a5fc28251b0add00bc9952"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"a40067c90c3f7449bfbf0f8d41308ff67a5390b3","unresolved":false,"context_lines":[{"line_number":1371,"context_line":""},{"line_number":1372,"context_line":".. _choosing_the_disk_label:"},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"Choosing the disk label"},{"line_number":1375,"context_line":"-----------------------"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"Ironic allows operators to choose which disk label they want their bare"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_f301b8b0","line":1374,"updated":"2016-03-09 09:55:54.000000000","message":"\"disk label\" term historically used in Ironic (taken from parted) and IMO should not be changed. But please mention in the documentation directly that it\u0027s a type of partition table.","commit_id":"3d1324571ad68bb65cba1f1fe5744a538c57b9fc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"90d109057a25096fa54a1b0b439f6bc97ff574de","unresolved":false,"context_lines":[{"line_number":1371,"context_line":""},{"line_number":1372,"context_line":".. _choosing_the_disk_label:"},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"Choosing the disk label"},{"line_number":1375,"context_line":"-----------------------"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":"Ironic allows operators to choose which disk label they want their bare"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_216aa6ee","line":1374,"in_reply_to":"5aef4532_f301b8b0","updated":"2016-03-09 10:40:01.000000000","message":"+1\n\nI will add a note about it here","commit_id":"3d1324571ad68bb65cba1f1fe5744a538c57b9fc"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"1ce809c3a81d767654f8a8f592cbcb32e3045d31","unresolved":false,"context_lines":[{"line_number":1374,"context_line":"Choosing the disk label"},{"line_number":1375,"context_line":"-----------------------"},{"line_number":1376,"context_line":""},{"line_number":1377,"context_line":".. note::"},{"line_number":1378,"context_line":"   The term ``disk label`` is historically used in Ironic and was taken"},{"line_number":1379,"context_line":"   from `parted \u003chttps://www.gnu.org/software/parted\u003e`_. Apparently"},{"line_number":1380,"context_line":"   everyone seems to have a different word for ``disk label`` - these"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_7fe994b6","line":1377,"range":{"start_line":1377,"start_character":3,"end_line":1377,"end_character":9},"updated":"2016-03-10 13:51:49.000000000","message":"I *do* appreciate this note! Was thinking of \u0027disk type\u0027 myself (:","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"894f1312391e98a08651faeac04b0d4ffc3b2b00","unresolved":false,"context_lines":[{"line_number":1383,"context_line":""},{"line_number":1384,"context_line":"Ironic allows operators to choose which disk label they want their bare"},{"line_number":1385,"context_line":"metal node to be deployed with when Ironic is responsible for partitioning"},{"line_number":1386,"context_line":"the disk; therefore choosing the disk label do not apply when the image"},{"line_number":1387,"context_line":"being deployed is a ``whole disk images``."},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_26b29806","line":1386,"updated":"2016-03-09 18:00:12.000000000","message":"s/do/does","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"19f9a05817957700bcbc55e62d8261253a09ae4d","unresolved":false,"context_lines":[{"line_number":1383,"context_line":""},{"line_number":1384,"context_line":"Ironic allows operators to choose which disk label they want their bare"},{"line_number":1385,"context_line":"metal node to be deployed with when Ironic is responsible for partitioning"},{"line_number":1386,"context_line":"the disk; therefore choosing the disk label do not apply when the image"},{"line_number":1387,"context_line":"being deployed is a ``whole disk images``."},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_dc99db7a","line":1386,"in_reply_to":"5aef4532_26b29806","updated":"2016-03-10 12:04:40.000000000","message":"Done","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"894f1312391e98a08651faeac04b0d4ffc3b2b00","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"Ironic allows operators to choose which disk label they want their bare"},{"line_number":1385,"context_line":"metal node to be deployed with when Ironic is responsible for partitioning"},{"line_number":1386,"context_line":"the disk; therefore choosing the disk label do not apply when the image"},{"line_number":1387,"context_line":"being deployed is a ``whole disk images``."},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":".. note::"},{"line_number":1390,"context_line":"   At present the agent_* drivers do not support deploying partition"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_e6a270ad","line":1387,"updated":"2016-03-09 18:00:12.000000000","message":"s/images/image","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"19f9a05817957700bcbc55e62d8261253a09ae4d","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"Ironic allows operators to choose which disk label they want their bare"},{"line_number":1385,"context_line":"metal node to be deployed with when Ironic is responsible for partitioning"},{"line_number":1386,"context_line":"the disk; therefore choosing the disk label do not apply when the image"},{"line_number":1387,"context_line":"being deployed is a ``whole disk images``."},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":".. note::"},{"line_number":1390,"context_line":"   At present the agent_* drivers do not support deploying partition"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_3c8b9f20","line":1387,"in_reply_to":"5aef4532_e6a270ad","updated":"2016-03-10 12:04:40.000000000","message":"Done","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"1ce809c3a81d767654f8a8f592cbcb32e3045d31","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"   images, therefore forcing the disk label for those drivers is not"},{"line_number":1392,"context_line":"   possible."},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"There are some edge cases where someone may want to choose a specific"},{"line_number":1395,"context_line":"disk label for the images being deployed, including but not limited to:"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"* For machines in ``bios`` boot mode with disks larger than 2 terabytes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_dfb2684b","line":1394,"range":{"start_line":1394,"start_character":15,"end_line":1394,"end_character":25},"updated":"2016-03-10 13:51:49.000000000","message":"Are those really edge cases or just use cases? \u0027Edge\u0027 sounds to me as non-regular behaviour or something like it. Meaning that choosing a specific disk label is not a standard thing.","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"5fc322d69f7e59994e874c02bcc39c5440436548","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"   images, therefore forcing the disk label for those drivers is not"},{"line_number":1392,"context_line":"   possible."},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"There are some edge cases where someone may want to choose a specific"},{"line_number":1395,"context_line":"disk label for the images being deployed, including but not limited to:"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"* For machines in ``bios`` boot mode with disks larger than 2 terabytes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_35d60d4f","line":1394,"range":{"start_line":1394,"start_character":15,"end_line":1394,"end_character":25},"in_reply_to":"5aef4532_7200ab66","updated":"2016-03-10 14:23:36.000000000","message":"Oh ok, I thought it was not an extreme case, but thats fine then.","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ee5044e9c32e7b1ebcbe0b1ae5dd90ab99e9f523","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"   images, therefore forcing the disk label for those drivers is not"},{"line_number":1392,"context_line":"   possible."},{"line_number":1393,"context_line":""},{"line_number":1394,"context_line":"There are some edge cases where someone may want to choose a specific"},{"line_number":1395,"context_line":"disk label for the images being deployed, including but not limited to:"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"* For machines in ``bios`` boot mode with disks larger than 2 terabytes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_7200ab66","line":1394,"range":{"start_line":1394,"start_character":15,"end_line":1394,"end_character":25},"in_reply_to":"5aef4532_dfb2684b","updated":"2016-03-10 14:16:18.000000000","message":"hi,\n\nyes that\u0027s what I mean here by \"edge cases\". Most of the time it won\u0027t require people to force the disk partitioning to use a specific disk label, but there are some small cases that it may be required (usually to workaround problems such as address capacity for MBR and disks \u003e 2TB)","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"20aca77b727d9619d3c1bd2883e146088438f07f","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"The disk label can be configured in Bare Metal service in the following"},{"line_number":1409,"context_line":"way:"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"* When no boot mode setting is provided Ironic will configure it according"},{"line_number":1412,"context_line":"  to the `boot mode \u003cboot_mode_support_\u003e`_; ``bios`` boot mode will use"},{"line_number":1413,"context_line":"  ``msdos`` disk label and ``uefi`` boot mode will use ``gpt``."},{"line_number":1414,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_3f1eec6f","line":1411,"range":{"start_line":1411,"start_character":10,"end_line":1411,"end_character":27},"updated":"2016-03-10 13:56:21.000000000","message":"Isn\u0027t this *disk label* setting?","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ee5044e9c32e7b1ebcbe0b1ae5dd90ab99e9f523","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"The disk label can be configured in Bare Metal service in the following"},{"line_number":1409,"context_line":"way:"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"* When no boot mode setting is provided Ironic will configure it according"},{"line_number":1412,"context_line":"  to the `boot mode \u003cboot_mode_support_\u003e`_; ``bios`` boot mode will use"},{"line_number":1413,"context_line":"  ``msdos`` disk label and ``uefi`` boot mode will use ``gpt``."},{"line_number":1414,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_b20a3324","line":1411,"range":{"start_line":1411,"start_character":10,"end_line":1411,"end_character":27},"in_reply_to":"5aef4532_3f1eec6f","updated":"2016-03-10 14:16:18.000000000","message":"No, it\u0027s actually boot mode. For example, for machines using in UEFI, the UEFI the specification recommend the use of GPT for partition the disk [0]\n\nAs for legacy BIOS, MBR (msdos) is the default way since at the time GPT didn\u0027t exist.\n\n[0] http://www.uefi.org/sites/default/files/resources/UEFI%202_5.pdf#G9.1002458","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b50feaa0635e2d91c3c32cd276903c887c3aebaa","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"The disk label can be configured in Bare Metal service in the following"},{"line_number":1409,"context_line":"way:"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"* When no boot mode setting is provided Ironic will configure it according"},{"line_number":1412,"context_line":"  to the `boot mode \u003cboot_mode_support_\u003e`_; ``bios`` boot mode will use"},{"line_number":1413,"context_line":"  ``msdos`` disk label and ``uefi`` boot mode will use ``gpt``."},{"line_number":1414,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_b5c85d56","line":1411,"range":{"start_line":1411,"start_character":10,"end_line":1411,"end_character":27},"in_reply_to":"5aef4532_75dff539","updated":"2016-03-10 14:26:58.000000000","message":"Oh Lilian I\u0027m sorry, I totally misread the rest of the paragraph here. Yes, it\u0027s disk label!\n\n/me has to refill his cup of joe","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"5fc322d69f7e59994e874c02bcc39c5440436548","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"The disk label can be configured in Bare Metal service in the following"},{"line_number":1409,"context_line":"way:"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"* When no boot mode setting is provided Ironic will configure it according"},{"line_number":1412,"context_line":"  to the `boot mode \u003cboot_mode_support_\u003e`_; ``bios`` boot mode will use"},{"line_number":1413,"context_line":"  ``msdos`` disk label and ``uefi`` boot mode will use ``gpt``."},{"line_number":1414,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_75dff539","line":1411,"range":{"start_line":1411,"start_character":10,"end_line":1411,"end_character":27},"in_reply_to":"5aef4532_b20a3324","updated":"2016-03-10 14:23:36.000000000","message":"Ok, but in this case the disk label is the one configured according to the boot mode, right? I read something similar in the docstrings of the implementation you proposed in another patch.","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"24dd31ca21ad9ff9d42125cbdfced4ee990c5e4d","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"The disk label can be configured in Bare Metal service in the following"},{"line_number":1409,"context_line":"way:"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"* When no boot mode setting is provided Ironic will configure it according"},{"line_number":1412,"context_line":"  to the `boot mode \u003cboot_mode_support_\u003e`_; ``bios`` boot mode will use"},{"line_number":1413,"context_line":"  ``msdos`` disk label and ``uefi`` boot mode will use ``gpt``."},{"line_number":1414,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_508be71e","line":1411,"range":{"start_line":1411,"start_character":10,"end_line":1411,"end_character":27},"in_reply_to":"5aef4532_b5c85d56","updated":"2016-03-10 14:42:29.000000000","message":"I was getting confused haha That\u0027s ok then (:","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"894f1312391e98a08651faeac04b0d4ffc3b2b00","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"* Only one disk label - either ``msdos`` or ``gpt`` - can be configured"},{"line_number":1416,"context_line":"  for the node."},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"* To set the appropriated disk label to a bare metal node the command"},{"line_number":1419,"context_line":"  below can be used::"},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/capabilities\u003d\u0027disk_label:gpt\u0027"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_66a5c0a0","line":1418,"updated":"2016-03-09 18:00:12.000000000","message":"s/appropriated/appropriate","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"19f9a05817957700bcbc55e62d8261253a09ae4d","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"* Only one disk label - either ``msdos`` or ``gpt`` - can be configured"},{"line_number":1416,"context_line":"  for the node."},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"* To set the appropriated disk label to a bare metal node the command"},{"line_number":1419,"context_line":"  below can be used::"},{"line_number":1420,"context_line":""},{"line_number":1421,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/capabilities\u003d\u0027disk_label:gpt\u0027"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_9c7ab322","line":1418,"in_reply_to":"5aef4532_66a5c0a0","updated":"2016-03-10 12:04:40.000000000","message":"Done","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"894f1312391e98a08651faeac04b0d4ffc3b2b00","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"  The nova flavor that will be responsible for requesting such capability"},{"line_number":1424,"context_line":"  also needs to be updated as::"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"    nova flavor-key baremetal set capabilities:disk_label\u003d\"gpt\""},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"Local boot with partition images"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_e605507a","line":1426,"updated":"2016-03-09 18:00:12.000000000","message":"Might be worth mentioning that in standalone case it should be added to instance_info/capabilities.","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":14891,"name":"Lilia Sampaio","email":"liliars@lsd.ufcg.edu.br","username":"liliars"},"change_message_id":"1ce809c3a81d767654f8a8f592cbcb32e3045d31","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"  The nova flavor that will be responsible for requesting such capability"},{"line_number":1424,"context_line":"  also needs to be updated as::"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"    nova flavor-key baremetal set capabilities:disk_label\u003d\"gpt\""},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"Local boot with partition images"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_9f0e20e3","line":1426,"in_reply_to":"5aef4532_e605507a","updated":"2016-03-10 13:51:49.000000000","message":"+1","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"19f9a05817957700bcbc55e62d8261253a09ae4d","unresolved":false,"context_lines":[{"line_number":1423,"context_line":"  The nova flavor that will be responsible for requesting such capability"},{"line_number":1424,"context_line":"  also needs to be updated as::"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"    nova flavor-key baremetal set capabilities:disk_label\u003d\"gpt\""},{"line_number":1427,"context_line":""},{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"Local boot with partition images"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_bca68fab","line":1426,"in_reply_to":"5aef4532_e605507a","updated":"2016-03-10 12:04:40.000000000","message":"Agreed, I will extend this topic to talk about it","commit_id":"d7dbd806e70956ad8ef8de36d27fead1874cf95e"}]}
