)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"55dfb1fb37d1c77f7b54ca4c2361772f67f5d40e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove mock called of ironic-lib inner methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic shouldn\u0027t verify ironic-lib inner methods called, as the"},{"line_number":10,"context_line":"calling code in ironic-lib may change and end up breaking"},{"line_number":11,"context_line":"ironic unit tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_ee8c8081","line":9,"updated":"2016-03-07 02:53:41.000000000","message":"these are not inner methods, for example populate_image() is also directly called in deploy_utils.deploy_disk_image(). But in the case of deploy_partitional_image(), this could use work_on_disk() to test","commit_id":"dc97040c8e9af597b4ede1e9c8665f215a5ef4f1"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e20a0396af13cfa79e1ae1e094ca2b446f974048","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove mock called of ironic-lib inner methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic shouldn\u0027t verify ironic-lib inner methods called, as the"},{"line_number":10,"context_line":"calling code in ironic-lib may change and end up breaking"},{"line_number":11,"context_line":"ironic unit tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_14791794","line":9,"in_reply_to":"7af24918_0e4e0cc1","updated":"2016-03-07 14:57:58.000000000","message":"I\u0027d rather rewrite this as \u0027assertions about ironic-lib method calls that are not called directly by ironic should be tested in ironic-lib\u0027","commit_id":"dc97040c8e9af597b4ede1e9c8665f215a5ef4f1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"e810540af623544b1253d62609f3b06234e03435","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove mock called of ironic-lib inner methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic shouldn\u0027t verify ironic-lib inner methods called, as the"},{"line_number":10,"context_line":"calling code in ironic-lib may change and end up breaking"},{"line_number":11,"context_line":"ironic unit tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_0e4e0cc1","line":9,"in_reply_to":"7af24918_ee8c8081","updated":"2016-03-07 03:34:15.000000000","message":"Tan, populate_image() is directly called in deploy_utils.deploy_disk_image(), so we should mock that in the unit tests about deploy_disk_image(), but deploy_partitional_image only call ironic_lib.work_on_disk(), and populate_image() is called in work_on_disk() in ironic_lib logic, am I clear? and there are many inner methods like block_uuid(),mkfs(),destroy_metadata().","commit_id":"dc97040c8e9af597b4ede1e9c8665f215a5ef4f1"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"299eb239d79c71f72ffe6e012a9eb17c24995c17","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhenguo Niu \u003cNiu.ZGlinux@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-15 10:33:23 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove mock called of ironic-lib inner methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"assertions about ironic-lib method calls that are not called directly"},{"line_number":10,"context_line":"by ironic should be tested in ironic-lib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afc51ec_5b0d2636","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":38},"updated":"2016-03-15 02:51:30.000000000","message":"nit: change the inner methods for the title too","commit_id":"edc103ecd65849053d7ea7520dfefa6303cf3944"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"7413b06954095af8404605aa65a22d4f5fc62b3a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhenguo Niu \u003cNiu.ZGlinux@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-15 10:33:23 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove mock called of ironic-lib inner methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"assertions about ironic-lib method calls that are not called directly"},{"line_number":10,"context_line":"by ironic should be tested in ironic-lib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afc51ec_3b05ba79","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":38},"in_reply_to":"3afc51ec_5b0d2636","updated":"2016-03-15 03:11:27.000000000","message":"Done","commit_id":"edc103ecd65849053d7ea7520dfefa6303cf3944"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e20a0396af13cfa79e1ae1e094ca2b446f974048","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":715,"context_line":"        self.assertEqual(root_uuid, uuid_dict_returned[\u0027root uuid\u0027])"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def test_deploy_partition_image_preserve_ephemeral(self):"},{"line_number":718,"context_line":"        \"\"\"Check if all functions are called with right args.\"\"\""},{"line_number":719,"context_line":"        address \u003d \u0027127.0.0.1\u0027"},{"line_number":720,"context_line":"        port \u003d 3306"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_202b2e32","side":"PARENT","line":717,"updated":"2016-03-07 14:57:58.000000000","message":"While I agree that it should be removed from ironic, I think this should be added in ironic-lib. At least this and the next one tests should be moved there.","commit_id":"c0dea3e12279f59ee50e0f862735e1f7e4d28337"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"6adb73b91e08e8a4bede4bd8a20a96e90b8dc932","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":715,"context_line":"        self.assertEqual(root_uuid, uuid_dict_returned[\u0027root uuid\u0027])"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def test_deploy_partition_image_preserve_ephemeral(self):"},{"line_number":718,"context_line":"        \"\"\"Check if all functions are called with right args.\"\"\""},{"line_number":719,"context_line":"        address \u003d \u0027127.0.0.1\u0027"},{"line_number":720,"context_line":"        port \u003d 3306"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_a45a4d4e","side":"PARENT","line":717,"in_reply_to":"5aef4532_202b2e32","updated":"2016-03-09 08:28:43.000000000","message":"hi vdrok, the make_partition related tests are already in ironic-lib, please reference https://github.com/openstack/ironic-lib/blob/master/ironic_lib/tests/test_disk_utils.py#L251-L341","commit_id":"c0dea3e12279f59ee50e0f862735e1f7e4d28337"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d98224f6373511da05915e10feab48b2448856ea","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        self.assertEqual(disk_utils_calls_expected, disk_utils_mock.mock_calls)"},{"line_number":715,"context_line":"        self.assertEqual(root_uuid, uuid_dict_returned[\u0027root uuid\u0027])"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    def test_deploy_partition_image_preserve_ephemeral(self):"},{"line_number":718,"context_line":"        \"\"\"Check if all functions are called with right args.\"\"\""},{"line_number":719,"context_line":"        address \u003d \u0027127.0.0.1\u0027"},{"line_number":720,"context_line":"        port \u003d 3306"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b6e9dee8","side":"PARENT","line":717,"in_reply_to":"5aef4532_a45a4d4e","updated":"2016-03-09 10:19:20.000000000","message":"Correct, but I don\u0027t see a test with preserve_ephemeral there (and these are more like tests for work_on_disk - https://github.com/openstack/ironic-lib/blob/master/ironic_lib/tests/test_disk_utils.py#L76)","commit_id":"c0dea3e12279f59ee50e0f862735e1f7e4d28337"}]}
