)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"8ca535f932ad86aef8e80278e454ddaf9fb368f5","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"},{"line_number":376,"context_line":"        # Generate the SSL certificate"},{"line_number":377,"context_line":"        cd $IRONIC_TERMINAL_CERT_DIR"},{"line_number":378,"context_line":"        openssl genrsa -des3 -out my.key 1024"},{"line_number":379,"context_line":"        openssl req -new -key my.key -out my.csr"},{"line_number":380,"context_line":"        cp my.key my.key.org"},{"line_number":381,"context_line":"        openssl rsa -in my.key.org -out my.key"},{"line_number":382,"context_line":"        openssl x509 -req -days 3650 -in my.csr -signkey my.key -out my.crt"},{"line_number":383,"context_line":"        cat my.crt my.key \u003e certificate.pem"},{"line_number":384,"context_line":"        cd -"},{"line_number":385,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5aef4532_b530f802","line":382,"range":{"start_line":378,"start_character":8,"end_line":382,"end_character":75},"updated":"2016-03-08 07:01:15.000000000","message":"IMO, to enter each values like password or city name and so on many times makes people annoying. Can you fix to one-line like http://blog.endpoint.com/2014/10/openssl-csr-with-alternative-names-one.html ?","commit_id":"2b589d2bd7b00eb92ee1118e31924337441b93c1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"f1f2c1d1f88ac2d26e91844b0e0b6a483716d584","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"},{"line_number":376,"context_line":"        # Generate the SSL certificate"},{"line_number":377,"context_line":"        cd $IRONIC_TERMINAL_CERT_DIR"},{"line_number":378,"context_line":"        openssl genrsa -des3 -out my.key 1024"},{"line_number":379,"context_line":"        openssl req -new -key my.key -out my.csr"},{"line_number":380,"context_line":"        cp my.key my.key.org"},{"line_number":381,"context_line":"        openssl rsa -in my.key.org -out my.key"},{"line_number":382,"context_line":"        openssl x509 -req -days 3650 -in my.csr -signkey my.key -out my.crt"},{"line_number":383,"context_line":"        cat my.crt my.key \u003e certificate.pem"},{"line_number":384,"context_line":"        cd -"},{"line_number":385,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5aef4532_105268dd","line":382,"range":{"start_line":378,"start_character":8,"end_line":382,"end_character":75},"in_reply_to":"5aef4532_295bed2f","updated":"2016-03-09 02:37:11.000000000","message":"But, seems devstack has wrapped some functions to make certificate, I will try to reuse that.","commit_id":"2b589d2bd7b00eb92ee1118e31924337441b93c1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"417c13bca69298fff37159f7567924cf7371cf37","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"},{"line_number":376,"context_line":"        # Generate the SSL certificate"},{"line_number":377,"context_line":"        cd $IRONIC_TERMINAL_CERT_DIR"},{"line_number":378,"context_line":"        openssl genrsa -des3 -out my.key 1024"},{"line_number":379,"context_line":"        openssl req -new -key my.key -out my.csr"},{"line_number":380,"context_line":"        cp my.key my.key.org"},{"line_number":381,"context_line":"        openssl rsa -in my.key.org -out my.key"},{"line_number":382,"context_line":"        openssl x509 -req -days 3650 -in my.csr -signkey my.key -out my.crt"},{"line_number":383,"context_line":"        cat my.crt my.key \u003e certificate.pem"},{"line_number":384,"context_line":"        cd -"},{"line_number":385,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5aef4532_295bed2f","line":382,"range":{"start_line":378,"start_character":8,"end_line":382,"end_character":75},"in_reply_to":"5aef4532_b530f802","updated":"2016-03-08 08:32:27.000000000","message":"hi Yuiko Takada, they are separate openssl commands, and which are copied from Ironic install guide.","commit_id":"2b589d2bd7b00eb92ee1118e31924337441b93c1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"adc63d6b0611bb4a81d7c7365f208f8989acbcc4","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_server $IRONIC_TFTPSERVER_IP"},{"line_number":372,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_root $IRONIC_TFTPBOOT_DIR"},{"line_number":373,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_master_path $IRONIC_TFTPBOOT_DIR/master_images"},{"line_number":374,"context_line":"    if [[ -n \"$IRONIC_TERMINAL_CERT_DIR\" ]]; then"},{"line_number":375,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"},{"line_number":376,"context_line":"        # Generate the SSL certificate"},{"line_number":377,"context_line":"        openssl req \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa0719c6_1e04947c","line":374,"updated":"2016-03-21 12:47:59.000000000","message":"We need to make sure that directory exists before calling openssl.\n\nmkdir -p $IRONIC_TERMINAL_CERT_DIR","commit_id":"5c51af6f744f31b0256e64753900553752e239d9"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"7e0e79a564015ccd91b655372f8afe913171c27b","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_server $IRONIC_TFTPSERVER_IP"},{"line_number":372,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_root $IRONIC_TFTPBOOT_DIR"},{"line_number":373,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_master_path $IRONIC_TFTPBOOT_DIR/master_images"},{"line_number":374,"context_line":"    if [[ -n \"$IRONIC_TERMINAL_CERT_DIR\" ]]; then"},{"line_number":375,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"},{"line_number":376,"context_line":"        # Generate the SSL certificate"},{"line_number":377,"context_line":"        openssl req \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa0719c6_5cba91e2","line":374,"in_reply_to":"fa0719c6_1e04947c","updated":"2016-03-21 14:11:56.000000000","message":"Done","commit_id":"5c51af6f744f31b0256e64753900553752e239d9"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"38820f75b12095a78bb1daa9be467243b291659a","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        openssl req \\"},{"line_number":378,"context_line":"            -x509 \\"},{"line_number":379,"context_line":"            -days 3650 \\"},{"line_number":380,"context_line":"            -newkey rsa \\"},{"line_number":381,"context_line":"            -nodes \\"},{"line_number":382,"context_line":"            -keyout $IRONIC_TERMINAL_CERT_DIR/certificate.pem.key \\"},{"line_number":383,"context_line":"            -out $IRONIC_TERMINAL_CERT_DIR/certificate.pem \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3afc51ec_f6507dd6","line":380,"range":{"start_line":380,"start_character":20,"end_line":380,"end_character":23},"updated":"2016-03-15 09:56:16.000000000","message":"nits: s/rsa/rsa:1024/","commit_id":"5c51af6f744f31b0256e64753900553752e239d9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"adc63d6b0611bb4a81d7c7365f208f8989acbcc4","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        openssl req \\"},{"line_number":378,"context_line":"            -x509 \\"},{"line_number":379,"context_line":"            -days 3650 \\"},{"line_number":380,"context_line":"            -newkey rsa \\"},{"line_number":381,"context_line":"            -nodes \\"},{"line_number":382,"context_line":"            -keyout $IRONIC_TERMINAL_CERT_DIR/certificate.pem.key \\"},{"line_number":383,"context_line":"            -out $IRONIC_TERMINAL_CERT_DIR/certificate.pem \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa0719c6_3e8878e7","line":380,"range":{"start_line":380,"start_character":20,"end_line":380,"end_character":23},"in_reply_to":"3afc51ec_f6507dd6","updated":"2016-03-21 12:47:59.000000000","message":"Might be combine openssl options to single variable, it will allow to override them in config.\n\nIRONIC_TERMINAL_CERT_OPTIONS\u003d${IRONIC_TERMINAL_CERT_OPTIONS:-\u0027-x509 -days 3650 -newkey rsa -nodes ....\u0027}\n\nand use:\n\nopenssl $IRONIC_TERMINAL_CERT_OPTIONS -keyout $IRONIC_TERMINAL_CERT_DIR/certificate.pem.key -out $IRONIC_TERMINAL_CERT_DIR/certificate.pem","commit_id":"5c51af6f744f31b0256e64753900553752e239d9"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"7e0e79a564015ccd91b655372f8afe913171c27b","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        openssl req \\"},{"line_number":378,"context_line":"            -x509 \\"},{"line_number":379,"context_line":"            -days 3650 \\"},{"line_number":380,"context_line":"            -newkey rsa \\"},{"line_number":381,"context_line":"            -nodes \\"},{"line_number":382,"context_line":"            -keyout $IRONIC_TERMINAL_CERT_DIR/certificate.pem.key \\"},{"line_number":383,"context_line":"            -out $IRONIC_TERMINAL_CERT_DIR/certificate.pem \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa0719c6_3c099d96","line":380,"range":{"start_line":380,"start_character":20,"end_line":380,"end_character":23},"in_reply_to":"fa0719c6_3e8878e7","updated":"2016-03-21 14:11:56.000000000","message":"thanks Vasyl Saienko, but as we use devstack just for test and development, I don\u0027t think we need to configure the cert options, and also there\u0027s no such option for other service\u0027s CA in devstack.","commit_id":"5c51af6f744f31b0256e64753900553752e239d9"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c6de9dc3942524344f9aace451dc53dfb3875d39","unresolved":false,"context_lines":[{"line_number":381,"context_line":"            -nodes \\"},{"line_number":382,"context_line":"            -keyout $IRONIC_TERMINAL_CERT_DIR/certificate.pem.key \\"},{"line_number":383,"context_line":"            -out $IRONIC_TERMINAL_CERT_DIR/certificate.pem \\"},{"line_number":384,"context_line":"            -subj \u0027/O\u003dOpenStack/OU\u003dDevStack Servers\u0027"},{"line_number":385,"context_line":"    fi"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    local pxe_params\u003d\"nofb nomodeset vga\u003dnormal console\u003dttyS0\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5aef4532_6945be15","line":384,"range":{"start_line":384,"start_character":12,"end_line":384,"end_character":52},"updated":"2016-03-09 07:49:41.000000000","message":"I\u0027m not sure this option is proper, but I think it\u0027s ok because we use devstack just as test.","commit_id":"5c51af6f744f31b0256e64753900553752e239d9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"59cbfe278f5e3736be5080d6681903a23841c99f","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_server $IRONIC_TFTPSERVER_IP"},{"line_number":372,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_root $IRONIC_TFTPBOOT_DIR"},{"line_number":373,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_master_path $IRONIC_TFTPBOOT_DIR/master_images"},{"line_number":374,"context_line":"    if [[ -n \"$IRONIC_TERMINAL_CERT_DIR\" ]]; then"},{"line_number":375,"context_line":"        # Make sure the cert directory exist"},{"line_number":376,"context_line":"        sudo mkdir -p $IRONIC_TERMINAL_CERT_DIR"},{"line_number":377,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa0719c6_b38acfbd","line":374,"updated":"2016-03-22 10:29:17.000000000","message":"Not sure if it\u0027s only me but having this variable only here seems a bit obscure. I usually look at the beginning of the file to see what are the options it supports.\n\nAlso, other configurations usually have the DIR variable with a default location and a switch variable to enable disable the feature. E.g console:\n\nIRONIC_VM_LOG_CONSOLE\u003d${IRONIC_VM_LOG_CONSOLE:-True}\nIRONIC_VM_LOG_DIR\u003d${IRONIC_VM_LOG_DIR:-$IRONIC_DATA_DIR/logs/}\n\nDo you think we should do the same for this too?\n\nIRONIC_TERMINAL_SSL \u003d ${IRONIC_TERMINAL_SSL:-False}\nIRONIC_TERMINAL_CERT_DIR \u003d ${IRONIC_TERMINAL_CERT_DIR:$IRONIC_DATA_DIR/terminal_cert}","commit_id":"8d47e2aa7c38099e4adf5bbbc6438dd220f68ea2"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9fe64cabdef2b4f705b22c8c3c7b76aa40e251d9","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_server $IRONIC_TFTPSERVER_IP"},{"line_number":372,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_root $IRONIC_TFTPBOOT_DIR"},{"line_number":373,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_master_path $IRONIC_TFTPBOOT_DIR/master_images"},{"line_number":374,"context_line":"    if [[ -n \"$IRONIC_TERMINAL_CERT_DIR\" ]]; then"},{"line_number":375,"context_line":"        # Make sure the cert directory exist"},{"line_number":376,"context_line":"        sudo mkdir -p $IRONIC_TERMINAL_CERT_DIR"},{"line_number":377,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa0719c6_e64d9573","line":374,"in_reply_to":"fa0719c6_b38acfbd","updated":"2016-03-22 14:24:54.000000000","message":"Thanks Lucas, have done.","commit_id":"8d47e2aa7c38099e4adf5bbbc6438dd220f68ea2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c9a2e22b0587df15fe25e6c9671e7bc2f15c8969","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_server $IRONIC_TFTPSERVER_IP"},{"line_number":389,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_root $IRONIC_TFTPBOOT_DIR"},{"line_number":390,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_master_path $IRONIC_TFTPBOOT_DIR/master_images"},{"line_number":391,"context_line":"    if [[ -n \"$IRONIC_TERMINAL_SSL\" ]]; then"},{"line_number":392,"context_line":"        # Make sure the cert directory exist"},{"line_number":393,"context_line":"        sudo mkdir -p $IRONIC_TERMINAL_CERT_DIR"},{"line_number":394,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa0719c6_65d4d146","line":391,"range":{"start_line":391,"start_character":4,"end_line":391,"end_character":44},"updated":"2016-03-22 16:56:02.000000000","message":"if [[ \"$IRONIC_TERMINAL_SSL\" \u003d\u003d \"True\" ]] ; then","commit_id":"d80f5e66e4c8fd1713a4c874303a4297bd59e96e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"33fe11f70509890e764ee772a01232efeaf47a89","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_server $IRONIC_TFTPSERVER_IP"},{"line_number":389,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_root $IRONIC_TFTPBOOT_DIR"},{"line_number":390,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_master_path $IRONIC_TFTPBOOT_DIR/master_images"},{"line_number":391,"context_line":"    if [[ -n \"$IRONIC_TERMINAL_SSL\" ]]; then"},{"line_number":392,"context_line":"        # Make sure the cert directory exist"},{"line_number":393,"context_line":"        sudo mkdir -p $IRONIC_TERMINAL_CERT_DIR"},{"line_number":394,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa0719c6_27864b65","line":391,"range":{"start_line":391,"start_character":4,"end_line":391,"end_character":44},"in_reply_to":"fa0719c6_65d4d146","updated":"2016-03-23 01:46:42.000000000","message":"Done","commit_id":"d80f5e66e4c8fd1713a4c874303a4297bd59e96e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"50111b50c84d84f33af4df4b1aa9d4a4f1a1c914","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_master_path $IRONIC_TFTPBOOT_DIR/master_images"},{"line_number":391,"context_line":"    if [[ -n \"$IRONIC_TERMINAL_SSL\" ]]; then"},{"line_number":392,"context_line":"        # Make sure the cert directory exist"},{"line_number":393,"context_line":"        sudo mkdir -p $IRONIC_TERMINAL_CERT_DIR"},{"line_number":394,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"},{"line_number":395,"context_line":"        # Generate the SSL certificate"},{"line_number":396,"context_line":"        openssl req \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa0719c6_6551710e","line":393,"updated":"2016-03-22 16:55:07.000000000","message":"Apparently we need to set the permissions for that folder as well:\n\n sudo chown $STACK_USER $IRONIC_TERMINAL_CERT_DIR\n\nLOGS: http://logs.openstack.org/71/289671/4/check/gate-tempest-dsvm-ironic-agent_ssh/e2dd8f1/logs/devstacklog.txt.gz#_2016-03-22_16_32_29_418","commit_id":"d80f5e66e4c8fd1713a4c874303a4297bd59e96e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"33fe11f70509890e764ee772a01232efeaf47a89","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    iniset $IRONIC_CONF_FILE pxe tftp_master_path $IRONIC_TFTPBOOT_DIR/master_images"},{"line_number":391,"context_line":"    if [[ -n \"$IRONIC_TERMINAL_SSL\" ]]; then"},{"line_number":392,"context_line":"        # Make sure the cert directory exist"},{"line_number":393,"context_line":"        sudo mkdir -p $IRONIC_TERMINAL_CERT_DIR"},{"line_number":394,"context_line":"        iniset $IRONIC_CONF_FILE console terminal_cert_dir $IRONIC_TERMINAL_CERT_DIR"},{"line_number":395,"context_line":"        # Generate the SSL certificate"},{"line_number":396,"context_line":"        openssl req \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa0719c6_877d9770","line":393,"in_reply_to":"fa0719c6_6551710e","updated":"2016-03-23 01:46:42.000000000","message":"Done","commit_id":"d80f5e66e4c8fd1713a4c874303a4297bd59e96e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7b7096bdb8f10fb2e4fd39755eb6826a531130ba","unresolved":false,"context_lines":[{"line_number":158,"context_line":"IRONIC_AUTH_STRATEGY\u003d${IRONIC_AUTH_STRATEGY:-keystone}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"# By default, terminal SSL certificate is disabled."},{"line_number":161,"context_line":"IRONIC_TERMINAL_SSL\u003d${IRONIC_TERMINAL_SSL:-False}"},{"line_number":162,"context_line":"IRONIC_TERMINAL_CERT_DIR\u003d${IRONIC_TERMINAL_CERT_DIR:-$IRONIC_DATA_DIR/terminal_cert/}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa0719c6_31df463b","line":161,"range":{"start_line":161,"start_character":43,"end_line":161,"end_character":49},"updated":"2016-03-24 14:44:37.000000000","message":"I think we should use trueorfalce function here. Please have look at the example https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L151","commit_id":"843ce0a16160f2e2710ef0901028453cd9a0357c"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"530992ef9eaf3ebdb50cda0db8772dad95950188","unresolved":false,"context_lines":[{"line_number":158,"context_line":"IRONIC_AUTH_STRATEGY\u003d${IRONIC_AUTH_STRATEGY:-keystone}"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"# By default, terminal SSL certificate is disabled."},{"line_number":161,"context_line":"IRONIC_TERMINAL_SSL\u003d${IRONIC_TERMINAL_SSL:-False}"},{"line_number":162,"context_line":"IRONIC_TERMINAL_CERT_DIR\u003d${IRONIC_TERMINAL_CERT_DIR:-$IRONIC_DATA_DIR/terminal_cert/}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa0719c6_e3921cf5","line":161,"range":{"start_line":161,"start_character":43,"end_line":161,"end_character":49},"in_reply_to":"fa0719c6_31df463b","updated":"2016-03-24 16:39:06.000000000","message":"+1","commit_id":"843ce0a16160f2e2710ef0901028453cd9a0357c"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"530992ef9eaf3ebdb50cda0db8772dad95950188","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        # Generate the SSL certificate"},{"line_number":397,"context_line":"        openssl req \\"},{"line_number":398,"context_line":"            -x509 \\"},{"line_number":399,"context_line":"            -days 3650 \\"},{"line_number":400,"context_line":"            -newkey rsa:1024 \\"},{"line_number":401,"context_line":"            -nodes \\"},{"line_number":402,"context_line":"            -keyout $IRONIC_TERMINAL_CERT_DIR/certificate.pem.key \\"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa0719c6_b84852cd","line":399,"range":{"start_line":399,"start_character":18,"end_line":399,"end_character":22},"updated":"2016-03-24 16:39:06.000000000","message":"nit: seems a bit long for a test environment.","commit_id":"843ce0a16160f2e2710ef0901028453cd9a0357c"}]}