)]}'
{"ironic/drivers/modules/iscsi_deploy.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8d8b2287a96bb6905b83cae98e765ce3304c0026","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        result \u003d agent_client.start_iscsi_target(node, iqn)"},{"line_number":443,"context_line":"    except IronicException as e:"},{"line_number":444,"context_line":"        msg \u003d (_(\"Failed to parse JSON response\"))"},{"line_number":445,"context_line":"        raise exception.InstanceDeployFailure(reason\u003dmsg)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":448,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_d0f75257","line":445,"updated":"2016-03-09 09:48:12.000000000","message":"Why are you assuming that the only ironic exception we will ever raise in start_iscsi_target is failure to parse reasponse?","commit_id":"1bff3f20d0b7970a5622e12c37104bcba53a35ba"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"1dc83d92e4aa9bacff193dc6b9c99e23c36af765","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        result \u003d agent_client.start_iscsi_target(node, iqn)"},{"line_number":443,"context_line":"    except IronicException as e:"},{"line_number":444,"context_line":"        msg \u003d (_(\"Failed to parse JSON response\"))"},{"line_number":445,"context_line":"        raise exception.InstanceDeployFailure(reason\u003dmsg)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":448,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_f8121a56","line":445,"in_reply_to":"5aef4532_6af0f567","updated":"2016-03-09 15:50:42.000000000","message":"Thanks Lucas","commit_id":"1bff3f20d0b7970a5622e12c37104bcba53a35ba"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"1dc83d92e4aa9bacff193dc6b9c99e23c36af765","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        result \u003d agent_client.start_iscsi_target(node, iqn)"},{"line_number":443,"context_line":"    except IronicException as e:"},{"line_number":444,"context_line":"        msg \u003d (_(\"Failed to parse JSON response\"))"},{"line_number":445,"context_line":"        raise exception.InstanceDeployFailure(reason\u003dmsg)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":448,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_fdafac27","line":445,"in_reply_to":"5aef4532_d0f75257","updated":"2016-03-09 15:50:42.000000000","message":"Hi Dmitry, first off sorry for the generic message. This was just a quick try at what I thought would be a possible solution.\n\nThe assumption came from when AgentClient._command is throwing the IronicException (https://github.com/openstack/ironic/blob/0812dcaba04baa59e65d6d95b992cc265e8992d3/ironic/drivers/modules/agent_client.py#L86) which is when a ValueError is caught when retrieving the json response.\n\nThat being said, saying that it\u0027s a parsing failure is wrong.\n\nBased on your comment in the bug, should I abandon this patch?","commit_id":"1bff3f20d0b7970a5622e12c37104bcba53a35ba"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"75bc7a3155b5b42edd4f368cb0f5438c3f53d000","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        result \u003d agent_client.start_iscsi_target(node, iqn)"},{"line_number":443,"context_line":"    except IronicException as e:"},{"line_number":444,"context_line":"        msg \u003d (_(\"Failed to parse JSON response\"))"},{"line_number":445,"context_line":"        raise exception.InstanceDeployFailure(reason\u003dmsg)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:"},{"line_number":448,"context_line":"        msg \u003d (_(\"Failed to start the iSCSI target to deploy the \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_6af0f567","line":445,"in_reply_to":"5aef4532_d0f75257","updated":"2016-03-09 14:34:49.000000000","message":"This also should call set_failed_state().\n\nI think we should reuse the logic from L448, perhaps a small refactor would do it.\n\n def _raise_start_iscsi_target_failure(self, node, error):\n     msg \u003d (_(\"Failed to start the iSCSI target to deploy the \"\n               \"node %(node)s. Error: %(error)s\") %\n             {\u0027node\u0027: node.uuid, \u0027error\u0027: error]})\n     deploy_utils.set_failed_state(task, msg)\n     raise exception.InstanceDeployFailure(reason\u003dmsg)\n\nAnd then we call on both places:\n\n try:\n     result \u003d ...\n except IronicException as e:\n     self._raise_start_iscsi_target_failure(node, e)\n\n if result[\u0027command_status\u0027] \u003d\u003d \u0027FAILED\u0027:\n     self._raise_start_iscsi_target_failure(node, result[\u0027command_error\u0027])","commit_id":"1bff3f20d0b7970a5622e12c37104bcba53a35ba"}]}
