)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3b02d89b77515f6a4eab07055ba6c4847c4e6c11","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After Ironic is moved to devstack plugin the tempest is always"},{"line_number":10,"context_line":"executed before ironic devstack plugin. Unfortunatly there is no quick"},{"line_number":11,"context_line":"way to change order."},{"line_number":12,"context_line":"This change introduce new function ironic_configure_tempest that is"},{"line_number":13,"context_line":"called from Ironic\u0027s devstack plugin. It updated flavor_ref and"},{"line_number":14,"context_line":"flavor_ref_alt compute tempest options."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ba0121b8_dd77bbd2","line":11,"updated":"2016-03-29 09:02:13.000000000","message":"It would be good to have a bug ticket for such problem","commit_id":"ba15202d99b2c26ba3eaf319f1e3d20edb697483"}],"devstack/lib/ironic":[{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"71e2800533906b0b80315e4a662ed90d7baafb32","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"function ironic_configure_tempest {"},{"line_number":1001,"context_line":"    if [[ -n \"$DEFAULT_INSTANCE_TYPE\"  ]]; then"},{"line_number":1002,"context_line":"        local bm_flavor_id"},{"line_number":1003,"context_line":"        bm_flavor_id\u003d$(nova flavor-list | grep \" $DEFAULT_INSTANCE_TYPE \" | get_field 2)"},{"line_number":1004,"context_line":"        die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $DEFAULT_INSTANCE_TYPE flavor\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref $bm_flavor_id"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1af94dfe_36bc176c","line":1003,"updated":"2016-03-15 17:22:26.000000000","message":"Tried this out and the flavor_ref needs to be the id, this returns the name, which tempest doesn\u0027t like.","commit_id":"20116c2049acccc5ede5bbcf4ec2e60c6dce0af0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"794baf8649c9dbd24a9a82a078be4b3f2230bbf5","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"function ironic_configure_tempest {"},{"line_number":1001,"context_line":"    if [[ -n \"$DEFAULT_INSTANCE_TYPE\"  ]]; then"},{"line_number":1002,"context_line":"        local bm_flavor_id"},{"line_number":1003,"context_line":"        bm_flavor_id\u003d$(nova flavor-list | grep \" $DEFAULT_INSTANCE_TYPE \" | get_field 2)"},{"line_number":1004,"context_line":"        die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $DEFAULT_INSTANCE_TYPE flavor\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref $bm_flavor_id"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1af94dfe_68607336","line":1003,"in_reply_to":"1af94dfe_36bc176c","updated":"2016-03-15 20:47:09.000000000","message":"Done","commit_id":"20116c2049acccc5ede5bbcf4ec2e60c6dce0af0"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"b35d9910698102f7d55e6f1b42daf69f2adc092a","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"function ironic_configure_tempest {"},{"line_number":1001,"context_line":"    if [[ -n \"$DEFAULT_INSTANCE_TYPE\"  ]]; then"},{"line_number":1002,"context_line":"        local bm_flavor_id"},{"line_number":1003,"context_line":"        bm_flavor_id\u003d$(nova flavor-list | grep \" $DEFAULT_INSTANCE_TYPE \" | get_field 1)"},{"line_number":1004,"context_line":"        die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $DEFAULT_INSTANCE_TYPE flavor\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref $bm_flavor_id"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1af94dfe_ee18d886","line":1003,"updated":"2016-03-16 17:11:31.000000000","message":"Is DEFAULT_INSTANCE_TYPE the only configuration variable we care about here? Is it possible to do this more generically? On the other hand, would it be a good idea to do this more generically, or would it just make debugging more confusing?","commit_id":"1f824de5bfbf6040572c99ccadaae2d053dd8c12"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d13a153b23f13fd8c2ed6723d861839969972c38","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"function ironic_configure_tempest {"},{"line_number":1001,"context_line":"    if [[ -n \"$DEFAULT_INSTANCE_TYPE\"  ]]; then"},{"line_number":1002,"context_line":"        local bm_flavor_id"},{"line_number":1003,"context_line":"        bm_flavor_id\u003d$(nova flavor-list | grep \" $DEFAULT_INSTANCE_TYPE \" | get_field 1)"},{"line_number":1004,"context_line":"        die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $DEFAULT_INSTANCE_TYPE flavor\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref $bm_flavor_id"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1af94dfe_c3c63367","line":1003,"in_reply_to":"1af94dfe_54318904","updated":"2016-03-18 10:37:10.000000000","message":"Right,\n\nWould be easier to have another env variable (e.g IRONIC_TEMPEST_FLAVOR_ID) which can be set to configure tempest with another flavor and if unset, we then fallback to the DEFAULT_INSTANCE_TYPE one?","commit_id":"1f824de5bfbf6040572c99ccadaae2d053dd8c12"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"26797f61a8234b0f5c80b4816ca8754d540989c7","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"function ironic_configure_tempest {"},{"line_number":1001,"context_line":"    if [[ -n \"$DEFAULT_INSTANCE_TYPE\"  ]]; then"},{"line_number":1002,"context_line":"        local bm_flavor_id"},{"line_number":1003,"context_line":"        bm_flavor_id\u003d$(nova flavor-list | grep \" $DEFAULT_INSTANCE_TYPE \" | get_field 1)"},{"line_number":1004,"context_line":"        die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $DEFAULT_INSTANCE_TYPE flavor\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref $bm_flavor_id"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa0719c6_e7cfe853","line":1003,"in_reply_to":"1af94dfe_c3c63367","updated":"2016-03-24 07:10:28.000000000","message":"flavor id is automatically generated UUID, I propose to replace it with IRONIC_FLAVOR_NAME and use baremetal.flavor_id tempest config option .","commit_id":"1f824de5bfbf6040572c99ccadaae2d053dd8c12"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"705a16cb8d00b65fe6347bd208abf534adddaeaf","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"function ironic_configure_tempest {"},{"line_number":1001,"context_line":"    if [[ -n \"$DEFAULT_INSTANCE_TYPE\"  ]]; then"},{"line_number":1002,"context_line":"        local bm_flavor_id"},{"line_number":1003,"context_line":"        bm_flavor_id\u003d$(nova flavor-list | grep \" $DEFAULT_INSTANCE_TYPE \" | get_field 1)"},{"line_number":1004,"context_line":"        die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $DEFAULT_INSTANCE_TYPE flavor\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref $bm_flavor_id"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1af94dfe_54318904","line":1003,"in_reply_to":"1af94dfe_ee18d886","updated":"2016-03-17 01:01:35.000000000","message":"I agree with Miles here. This makes things potentially hard to debug. And overwrite any tempest setting beyond tempest\u0027s baremetal section doesn\u0027t sound like the correct approach imho.\nOf course I\u0027m biased here, but I\u0027ve proposed https://review.openstack.org/#/q/status:open+branch:master+topic:bug/1546706 which fix this very same situation split in 3 patches across devstack, tempest and ironic.","commit_id":"1f824de5bfbf6040572c99ccadaae2d053dd8c12"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"38fcf6c3ebcc0ac5f8e9f0592fa0bdc2e7460e2e","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"        bm_flavor_id\u003d$(nova flavor-list | grep \" $DEFAULT_INSTANCE_TYPE \" | get_field 1)"},{"line_number":1004,"context_line":"        die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $DEFAULT_INSTANCE_TYPE flavor\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref $bm_flavor_id"},{"line_number":1007,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref_alt $bm_flavor_id"},{"line_number":1008,"context_line":"    fi"},{"line_number":1009,"context_line":"}"},{"line_number":1010,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1af94dfe_4324e35e","line":1007,"range":{"start_line":1006,"start_character":10,"end_line":1007,"end_character":67},"updated":"2016-03-18 10:34:26.000000000","message":"what you do here is essentially\n\n iniset $TEMPEST_CONFIG compute flavor_ref $DEFAULT_INSTANCE_TYPE\n\nthe \u0027flavor-list\u0027 command seems redundant","commit_id":"1f824de5bfbf6040572c99ccadaae2d053dd8c12"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"26797f61a8234b0f5c80b4816ca8754d540989c7","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"        bm_flavor_id\u003d$(nova flavor-list | grep \" $DEFAULT_INSTANCE_TYPE \" | get_field 1)"},{"line_number":1004,"context_line":"        die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $DEFAULT_INSTANCE_TYPE flavor\""},{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref $bm_flavor_id"},{"line_number":1007,"context_line":"        iniset $TEMPEST_CONFIG compute flavor_ref_alt $bm_flavor_id"},{"line_number":1008,"context_line":"    fi"},{"line_number":1009,"context_line":"}"},{"line_number":1010,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"fa0719c6_3354b11f","line":1007,"range":{"start_line":1006,"start_character":10,"end_line":1007,"end_character":67},"in_reply_to":"1af94dfe_4324e35e","updated":"2016-03-24 07:10:28.000000000","message":"Dmitry, not really. compute flavor_ref_alt is ID of the flavor it can\u0027t be flavor name.","commit_id":"1f824de5bfbf6040572c99ccadaae2d053dd8c12"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"be286e97c1445c9a93f7f957cfc4b3f149d84e6d","unresolved":false,"context_lines":[{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"function ironic_configure_tempest {"},{"line_number":1012,"context_line":"    local bm_flavor_id"},{"line_number":1013,"context_line":"    bm_flavor_id\u003d$(nova flavor-list | grep \" $IRONIC_FLAVOR_NAME \" | get_field 1)"},{"line_number":1014,"context_line":"    die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $IRONIC_FLAVOR_NAME flavor\""},{"line_number":1015,"context_line":"    iniset $TEMPEST_CONFIG baremetal flavor_id $bm_flavor_id"},{"line_number":1016,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"fa0719c6_5470f6a3","line":1013,"range":{"start_line":1013,"start_character":19,"end_line":1013,"end_character":80},"updated":"2016-03-24 11:36:02.000000000","message":"openstack flavor show $IRONIC_FLAVOR_NAME -f value -c id","commit_id":"5e432f0773666a4d929629be75f46e3db347d1c5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7dbf712752b7ac55077cb316d9289fc003593fbf","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"    bm_flavor_id\u003d$(openstack flavor show $IRONIC_FLAVOR_NAME -f value -c id)"},{"line_number":1053,"context_line":"    die_if_not_set $LINENO bm_flavor_id \"Failed to get id of $IRONIC_FLAVOR_NAME flavor\""},{"line_number":1054,"context_line":"    iniset $TEMPEST_CONFIG baremetal flavor_id $bm_flavor_id"},{"line_number":1055,"context_line":"}"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"# Restore xtrace + pipefail"},{"line_number":1058,"context_line":"$_XTRACE_IRONIC"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"da0c15f0_6b613b39","line":1055,"updated":"2016-03-28 14:41:18.000000000","message":"Now that I think about this more, I think this block is the only change we really need here, we don\u0027t need to introduce IRONIC_FLAVOR_NAME to fix this bug.","commit_id":"c4569c1557a56712f59adbb56827617ab6998b2a"}],"devstack/plugin.sh":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d80ba0672854efe77d02990110b0758ee599531f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":27,"context_line":"        start_ironic"},{"line_number":28,"context_line":"        prepare_baremetal_basic_ops"},{"line_number":29,"context_line":"        if is_service_enabled tempest ir-api; then"},{"line_number":30,"context_line":"            ironic_configure_tempest"},{"line_number":31,"context_line":"        fi"},{"line_number":32,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa0719c6_2ccd6b85","line":29,"updated":"2016-03-23 15:43:48.000000000","message":"ir-api is unnecessary, it\u0027s checked on L7","commit_id":"ec3cebcf787e95501130f8832e50f6e347aea79d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b99cd24fe783a3a9cb233823fc55fd9f385137cc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":27,"context_line":"        start_ironic"},{"line_number":28,"context_line":"        prepare_baremetal_basic_ops"},{"line_number":29,"context_line":"        if is_service_enabled tempest ir-api; then"},{"line_number":30,"context_line":"            ironic_configure_tempest"},{"line_number":31,"context_line":"        fi"},{"line_number":32,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa0719c6_ef84050c","line":29,"in_reply_to":"fa0719c6_2ccd6b85","updated":"2016-03-23 15:46:09.000000000","message":"Oh, this is or, nevermind :)","commit_id":"ec3cebcf787e95501130f8832e50f6e347aea79d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5caefc2c439a4359636c5d74ad5bec7aeb73bd57","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":27,"context_line":"        start_ironic"},{"line_number":28,"context_line":"        prepare_baremetal_basic_ops"},{"line_number":29,"context_line":"        if is_service_enabled tempest ir-api; then"},{"line_number":30,"context_line":"            ironic_configure_tempest"},{"line_number":31,"context_line":"        fi"},{"line_number":32,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa0719c6_60748267","line":29,"in_reply_to":"fa0719c6_ef84050c","updated":"2016-03-23 16:17:39.000000000","message":"So, as long as this is OR, it means that ironic_configure_tempest is going to be called if either tempest or ir-api are enabled. Should it be just tempest here?","commit_id":"ec3cebcf787e95501130f8832e50f6e347aea79d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cd7eea7ee2327892d9862952a149c58a2fde0975","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":27,"context_line":"        start_ironic"},{"line_number":28,"context_line":"        prepare_baremetal_basic_ops"},{"line_number":29,"context_line":"        if is_service_enabled tempest \u0026\u0026 is_ironic_enabled; then"},{"line_number":30,"context_line":"            ironic_configure_tempest"},{"line_number":31,"context_line":"        fi"},{"line_number":32,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"fa0719c6_c60f3c35","line":29,"updated":"2016-03-24 11:15:45.000000000","message":"I\u0027m still not sure that we need to check if ironic is enabled here. If it is disabled, we will fail earlier in prepare_baremetal_basic_ops - https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L673 , also this function just sets config file value, so ironic is not needed for it to properly work, only nova is needed.","commit_id":"cfa4410792daec12c30e61106841e902b4380e6a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"713d4627235173fdcc1893e951ada7867f7b4d51","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":27,"context_line":"        start_ironic"},{"line_number":28,"context_line":"        prepare_baremetal_basic_ops"},{"line_number":29,"context_line":"        if is_service_enabled tempest \u0026\u0026 is_ironic_enabled; then"},{"line_number":30,"context_line":"            ironic_configure_tempest"},{"line_number":31,"context_line":"        fi"},{"line_number":32,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"fa0719c6_e999737a","line":29,"in_reply_to":"fa0719c6_c60f3c35","updated":"2016-03-24 11:23:32.000000000","message":"If we enable ironic plugin for example, but do not enable ironic service itself. In this case ironic_configure_tempest will be called and devstack installation will fail, please have look at lib/ironic L1014","commit_id":"cfa4410792daec12c30e61106841e902b4380e6a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"505877e9a73c9036586b98a61d05e124be3a257f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        echo_summary \"Starting Ironic\""},{"line_number":27,"context_line":"        start_ironic"},{"line_number":28,"context_line":"        prepare_baremetal_basic_ops"},{"line_number":29,"context_line":"        if is_service_enabled tempest \u0026\u0026 is_ironic_enabled; then"},{"line_number":30,"context_line":"            ironic_configure_tempest"},{"line_number":31,"context_line":"        fi"},{"line_number":32,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"fa0719c6_e9a4d34b","line":29,"in_reply_to":"fa0719c6_e999737a","updated":"2016-03-24 11:31:42.000000000","message":"This check is performed at L7.","commit_id":"cfa4410792daec12c30e61106841e902b4380e6a"}],"ironic_tempest_plugin/config.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"be286e97c1445c9a93f7f957cfc4b3f149d84e6d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d15,"},{"line_number":52,"context_line":"               help\u003d\"Timeout for Ironic node to reach the \""},{"line_number":53,"context_line":"                    \"wait-callback state after powering on.\"),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027flavor_id\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Baremetal flavor ID\"),"},{"line_number":56,"context_line":"    # cfg.IntOpt(\u0027active_timeout\u0027,"},{"line_number":57,"context_line":"    #            default\u003d300,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_14883e70","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"updated":"2016-03-24 11:36:02.000000000","message":"would be nice to set default explicitly","commit_id":"5e432f0773666a4d929629be75f46e3db347d1c5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"cc3a03f785ac1d0746457b4878e7bc6413ef87f7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d15,"},{"line_number":52,"context_line":"               help\u003d\"Timeout for Ironic node to reach the \""},{"line_number":53,"context_line":"                    \"wait-callback state after powering on.\"),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027flavor_id\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Baremetal flavor ID\"),"},{"line_number":56,"context_line":"    # cfg.IntOpt(\u0027active_timeout\u0027,"},{"line_number":57,"context_line":"    #            default\u003d300,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_70992d1f","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"in_reply_to":"da0c15f0_c9a09d93","updated":"2016-03-28 14:12:58.000000000","message":"Done","commit_id":"5e432f0773666a4d929629be75f46e3db347d1c5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f4444f2bc1b507e68af8ee6ecf0fde045e8661da","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d15,"},{"line_number":52,"context_line":"               help\u003d\"Timeout for Ironic node to reach the \""},{"line_number":53,"context_line":"                    \"wait-callback state after powering on.\"),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027flavor_id\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Baremetal flavor ID\"),"},{"line_number":56,"context_line":"    # cfg.IntOpt(\u0027active_timeout\u0027,"},{"line_number":57,"context_line":"    #            default\u003d300,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_f4f02acb","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"in_reply_to":"fa0719c6_14883e70","updated":"2016-03-24 11:37:58.000000000","message":"I think it\u0027s better as is, if this is not set, CONF.compute.flavor_ref is used, which kind of preserves current behaviour.","commit_id":"5e432f0773666a4d929629be75f46e3db347d1c5"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"edc800bfc94faba97a021fa35b3d209b13f30120","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d15,"},{"line_number":52,"context_line":"               help\u003d\"Timeout for Ironic node to reach the \""},{"line_number":53,"context_line":"                    \"wait-callback state after powering on.\"),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027flavor_id\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Baremetal flavor ID\"),"},{"line_number":56,"context_line":"    # cfg.IntOpt(\u0027active_timeout\u0027,"},{"line_number":57,"context_line":"    #            default\u003d300,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_c9a09d93","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"in_reply_to":"fa0719c6_8f94378b","updated":"2016-03-25 11:55:57.000000000","message":"sure, but I guess Vladyslav says that compute flavor_ref will be used if this options will be None(by default), maybe we should mentioning this in help, wdyt?","commit_id":"5e432f0773666a4d929629be75f46e3db347d1c5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5c8f1eef7e06cdd1df7880dc9af7497c6bbd96bc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d15,"},{"line_number":52,"context_line":"               help\u003d\"Timeout for Ironic node to reach the \""},{"line_number":53,"context_line":"                    \"wait-callback state after powering on.\"),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027flavor_id\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Baremetal flavor ID\"),"},{"line_number":56,"context_line":"    # cfg.IntOpt(\u0027active_timeout\u0027,"},{"line_number":57,"context_line":"    #            default\u003d300,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_8f94378b","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"in_reply_to":"fa0719c6_b42992e8","updated":"2016-03-24 11:51:54.000000000","message":"baremetal flavor is always created when ironic is enabled. Why we should fall-back to compute.flavor_ref? BaremetalBasicOps should always use baremetal flavor.","commit_id":"5e432f0773666a4d929629be75f46e3db347d1c5"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"eabba95bab8d1b454c585dc94e9234114331363c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               default\u003d15,"},{"line_number":52,"context_line":"               help\u003d\"Timeout for Ironic node to reach the \""},{"line_number":53,"context_line":"                    \"wait-callback state after powering on.\"),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027flavor_id\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Baremetal flavor ID\"),"},{"line_number":56,"context_line":"    # cfg.IntOpt(\u0027active_timeout\u0027,"},{"line_number":57,"context_line":"    #            default\u003d300,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_b42992e8","line":54,"range":{"start_line":54,"start_character":16,"end_line":54,"end_character":25},"in_reply_to":"fa0719c6_f4f02acb","updated":"2016-03-24 11:42:34.000000000","message":"It\u0027s not a problem:\n\ncfg.StrOpt(\u0027flavor_id\u0027,\n           default\u003dNone,\n           help\u003d\u0027compute.flavor_ref opt is used by default...\u0027","commit_id":"5e432f0773666a4d929629be75f46e3db347d1c5"}]}