)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"ded29bff8f3fee5549a61664a693f22b6705ebd7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow to use NETWORK_DRIVERS in devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to set enabled_network_drivers configuration option"},{"line_number":10,"context_line":"via IRONIC_ENABLED_NETWORK_DRIVERS and registed ironic node with"},{"line_number":11,"context_line":"IRONIC_NETWORK_DRIVER."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie01ca4be3a085bc283879b5528c5c174a35a843b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"dab17558_01576426","line":10,"updated":"2016-05-17 11:31:13.000000000","message":"s/registed/registered","commit_id":"024d9cf92efca119dd9e7ceeaa6857bbc8615128"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6d7bba2bca58a3e072fcf76d36de817b41acc739","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow to use NETWORK_DRIVERS in devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to set enabled_network_drivers configuration option"},{"line_number":10,"context_line":"via IRONIC_ENABLED_NETWORK_DRIVERS and registed ironic node with"},{"line_number":11,"context_line":"IRONIC_NETWORK_DRIVER."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie01ca4be3a085bc283879b5528c5c174a35a843b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"bab6814e_cc4540b4","line":10,"in_reply_to":"dab17558_01576426","updated":"2016-05-24 16:16:23.000000000","message":"Done","commit_id":"024d9cf92efca119dd9e7ceeaa6857bbc8615128"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ca74b7866bb2649feb0191b675f279910da37605","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-14 20:13:31 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to use NETWORK_DRIVERS in devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to set enabled_network_drivers configuration option"},{"line_number":10,"context_line":"via IRONIC_ENABLED_NETWORK_INTERFACES and registered ironic node with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"3aaa91ec_beeae5d5","line":7,"updated":"2016-07-01 01:12:16.000000000","message":"maybe s/NETWORK_DRIVERS/network interfaces/\n\n(There isn\u0027t any \u0027NETWORK_DRIVER\u0027 is there?)","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5c7ee2332ad190b74e9d0d1ff5fb0de19bab566d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-14 20:13:31 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to use NETWORK_DRIVERS in devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to set enabled_network_drivers configuration option"},{"line_number":10,"context_line":"via IRONIC_ENABLED_NETWORK_INTERFACES and registered ironic node with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"1aa78d24_8f8339cc","line":7,"in_reply_to":"3aaa91ec_beeae5d5","updated":"2016-07-04 07:33:05.000000000","message":"Done","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ca74b7866bb2649feb0191b675f279910da37605","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to use NETWORK_DRIVERS in devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to set enabled_network_drivers configuration option"},{"line_number":10,"context_line":"via IRONIC_ENABLED_NETWORK_INTERFACES and registered ironic node with"},{"line_number":11,"context_line":"IRONIC_NETWORK_INTERFACE."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"3aaa91ec_fed74d20","line":9,"updated":"2016-07-01 01:12:16.000000000","message":"s/enabled_network_drivers/enabled_network_interfaces/","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5c7ee2332ad190b74e9d0d1ff5fb0de19bab566d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to use NETWORK_DRIVERS in devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allow to set enabled_network_drivers configuration option"},{"line_number":10,"context_line":"via IRONIC_ENABLED_NETWORK_INTERFACES and registered ironic node with"},{"line_number":11,"context_line":"IRONIC_NETWORK_INTERFACE."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"1aa78d24_6f888de8","line":9,"in_reply_to":"3aaa91ec_fed74d20","updated":"2016-07-04 07:33:05.000000000","message":"Done","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"}],"devstack/lib/ironic":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f8c003d4d4e837f86d9047303a03f8a244853656","unresolved":false,"context_lines":[{"line_number":857,"context_line":"            | grep -w \"uuid\" | get_field 2)"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        # In case we using portgroups, we should API version that support them."},{"line_number":860,"context_line":"        # Othervise API will return 406 ERROR"},{"line_number":861,"context_line":"        ironic $ironic_api_version port-create --address $mac_address --node $node_id $llc_opts"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"        # NOTE(vsaienko) use node-update instead of specifing network_interface"},{"line_number":864,"context_line":"        # during node creation. If node is added with latest version of API it"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1af94dfe_7539dad6","line":861,"range":{"start_line":860,"start_character":8,"end_line":861,"end_character":95},"updated":"2016-03-18 07:53:23.000000000","message":"I know here is existing code, but I think it is better for devstack user to make stack.sh exit with line number as I commented in L.867 when 406 ERROR is returned.\nWhat do you think?","commit_id":"3fe287f8288dfb3fb3f43189e5a75b63d06df29a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"160512a343e4b76adedafbee40111ef92737c03e","unresolved":false,"context_lines":[{"line_number":857,"context_line":"            | grep -w \"uuid\" | get_field 2)"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"        # In case we using portgroups, we should API version that support them."},{"line_number":860,"context_line":"        # Othervise API will return 406 ERROR"},{"line_number":861,"context_line":"        ironic $ironic_api_version port-create --address $mac_address --node $node_id $llc_opts"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"        # NOTE(vsaienko) use node-update instead of specifing network_interface"},{"line_number":864,"context_line":"        # during node creation. If node is added with latest version of API it"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_c512d956","line":861,"range":{"start_line":860,"start_character":8,"end_line":861,"end_character":95},"in_reply_to":"1af94dfe_7539dad6","updated":"2016-03-23 10:02:06.000000000","message":"Will do it in new patchset.","commit_id":"3fe287f8288dfb3fb3f43189e5a75b63d06df29a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f8c003d4d4e837f86d9047303a03f8a244853656","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        # during node creation. If node is added with latest version of API it"},{"line_number":865,"context_line":"        # will NOT go to available state automatically."},{"line_number":866,"context_line":"        if [[ -n \"${IRONIC_NETWORK_DRIVER}\" ]]; then"},{"line_number":867,"context_line":"            ironic $ironic_api_version node-update $node_id add network_interface\u003d$IRONIC_NETWORK_DRIVER"},{"line_number":868,"context_line":"        fi"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        # Find minimum flavor"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1af94dfe_0a6af5ed","line":867,"range":{"start_line":867,"start_character":12,"end_line":867,"end_character":104},"updated":"2016-03-18 07:53:23.000000000","message":"Should we check return code like this?\n\nhttps://review.openstack.org/#/c/293781/1/devstack/lib/ironic","commit_id":"3fe287f8288dfb3fb3f43189e5a75b63d06df29a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"160512a343e4b76adedafbee40111ef92737c03e","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        # during node creation. If node is added with latest version of API it"},{"line_number":865,"context_line":"        # will NOT go to available state automatically."},{"line_number":866,"context_line":"        if [[ -n \"${IRONIC_NETWORK_DRIVER}\" ]]; then"},{"line_number":867,"context_line":"            ironic $ironic_api_version node-update $node_id add network_interface\u003d$IRONIC_NETWORK_DRIVER"},{"line_number":868,"context_line":"        fi"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        # Find minimum flavor"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa0719c6_4506c91d","line":867,"range":{"start_line":867,"start_character":12,"end_line":867,"end_character":104},"in_reply_to":"1af94dfe_0a6af5ed","updated":"2016-03-23 10:02:06.000000000","message":"Done","commit_id":"3fe287f8288dfb3fb3f43189e5a75b63d06df29a"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"ded29bff8f3fee5549a61664a693f22b6705ebd7","unresolved":false,"context_lines":[{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"        # NOTE(vsaienko) use node-update instead of specifing network_interface"},{"line_number":1038,"context_line":"        # during node creation. If node is added with latest version of API it"},{"line_number":1039,"context_line":"        # will NOT go to available state automatically."},{"line_number":1040,"context_line":"        if [[ -n \"${IRONIC_NETWORK_DRIVER}\" ]]; then"},{"line_number":1041,"context_line":"            local n_id"},{"line_number":1042,"context_line":"            ironic node-set-maintenance $node_id true"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"dab17558_bc3cbfc8","line":1039,"updated":"2016-05-17 11:31:13.000000000","message":"Please explain why you need an update vs passing it on the create. Why does it matter create vs update? Is it that this attribute cannot be changed when node is in available state?","commit_id":"024d9cf92efca119dd9e7ceeaa6857bbc8615128"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6d7bba2bca58a3e072fcf76d36de817b41acc739","unresolved":false,"context_lines":[{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"        # NOTE(vsaienko) use node-update instead of specifing network_interface"},{"line_number":1038,"context_line":"        # during node creation. If node is added with latest version of API it"},{"line_number":1039,"context_line":"        # will NOT go to available state automatically."},{"line_number":1040,"context_line":"        if [[ -n \"${IRONIC_NETWORK_DRIVER}\" ]]; then"},{"line_number":1041,"context_line":"            local n_id"},{"line_number":1042,"context_line":"            ironic node-set-maintenance $node_id true"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"bab6814e_ece484ad","line":1039,"in_reply_to":"dab17558_bc3cbfc8","updated":"2016-05-24 16:16:23.000000000","message":"Please have look at L1037","commit_id":"024d9cf92efca119dd9e7ceeaa6857bbc8615128"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"ded29bff8f3fee5549a61664a693f22b6705ebd7","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"        # will NOT go to available state automatically."},{"line_number":1040,"context_line":"        if [[ -n \"${IRONIC_NETWORK_DRIVER}\" ]]; then"},{"line_number":1041,"context_line":"            local n_id"},{"line_number":1042,"context_line":"            ironic node-set-maintenance $node_id true"},{"line_number":1043,"context_line":"            n_id\u003d$(ironic $ironic_api_version node-update $node_id add network_interface\u003d$IRONIC_NETWORK_DRIVER)"},{"line_number":1044,"context_line":"            die_if_not_set $LINENO n_id \"Failed to update network provider for node\""},{"line_number":1045,"context_line":"            ironic node-set-maintenance $node_id false"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"dab17558_dc442348","line":1042,"updated":"2016-05-17 11:31:13.000000000","message":"Could you explain why you wrap the update with maintenance mode?","commit_id":"024d9cf92efca119dd9e7ceeaa6857bbc8615128"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ca74b7866bb2649feb0191b675f279910da37605","unresolved":false,"context_lines":[{"line_number":215,"context_line":"# This flag is used to specify enabled network drivers"},{"line_number":216,"context_line":"IRONIC_ENABLED_NETWORK_INTERFACES\u003d${IRONIC_ENABLED_NETWORK_INTERFACES:-}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# This flag specify network driver"},{"line_number":219,"context_line":"IRONIC_NETWORK_INTERFACE\u003d${IRONIC_NETWORK_INTERFACE:-}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"3aaa91ec_7ef6bdd7","line":218,"updated":"2016-07-01 01:12:16.000000000","message":"how about \u0027This is the network interface to use for a node\u0027","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5c7ee2332ad190b74e9d0d1ff5fb0de19bab566d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"# This flag is used to specify enabled network drivers"},{"line_number":216,"context_line":"IRONIC_ENABLED_NETWORK_INTERFACES\u003d${IRONIC_ENABLED_NETWORK_INTERFACES:-}"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# This flag specify network driver"},{"line_number":219,"context_line":"IRONIC_NETWORK_INTERFACE\u003d${IRONIC_NETWORK_INTERFACE:-}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# get_pxe_boot_file() - Get the PXE/iPXE boot file path"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1aa78d24_0f4f49be","line":218,"in_reply_to":"3aaa91ec_7ef6bdd7","updated":"2016-07-04 07:33:05.000000000","message":"Done","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ca74b7866bb2649feb0191b675f279910da37605","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        # Othervise API will return 406 ERROR"},{"line_number":922,"context_line":"        ironic $ironic_api_version port-create --address $mac_address --node $node_id $llc_opts"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"        # NOTE(vsaienko) use node-update instead of specifing network_interface"},{"line_number":925,"context_line":"        # during node creation. If node is added with latest version of API it"},{"line_number":926,"context_line":"        # will NOT go to available state automatically."},{"line_number":927,"context_line":"        if [[ -n \"${IRONIC_NETWORK_INTERFACE}\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"3aaa91ec_3e42750f","line":924,"updated":"2016-07-01 01:12:16.000000000","message":"nit, s/specifing/specifying/","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5c7ee2332ad190b74e9d0d1ff5fb0de19bab566d","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        # Othervise API will return 406 ERROR"},{"line_number":922,"context_line":"        ironic $ironic_api_version port-create --address $mac_address --node $node_id $llc_opts"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"        # NOTE(vsaienko) use node-update instead of specifing network_interface"},{"line_number":925,"context_line":"        # during node creation. If node is added with latest version of API it"},{"line_number":926,"context_line":"        # will NOT go to available state automatically."},{"line_number":927,"context_line":"        if [[ -n \"${IRONIC_NETWORK_INTERFACE}\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1aa78d24_cf02613e","line":924,"in_reply_to":"3aaa91ec_3e42750f","updated":"2016-07-04 07:33:05.000000000","message":"Done","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"ca74b7866bb2649feb0191b675f279910da37605","unresolved":false,"context_lines":[{"line_number":928,"context_line":"            local n_id"},{"line_number":929,"context_line":"            ironic node-set-maintenance $node_id true"},{"line_number":930,"context_line":"            n_id\u003d$(ironic $ironic_api_version node-update $node_id add network_interface\u003d$IRONIC_NETWORK_INTERFACE)"},{"line_number":931,"context_line":"            die_if_not_set $LINENO n_id \"Failed to update network provider for node\""},{"line_number":932,"context_line":"            ironic node-set-maintenance $node_id false"},{"line_number":933,"context_line":"        fi"},{"line_number":934,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"3aaa91ec_1e6059a4","line":931,"updated":"2016-07-01 01:12:16.000000000","message":"s/provider/interface/","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5c7ee2332ad190b74e9d0d1ff5fb0de19bab566d","unresolved":false,"context_lines":[{"line_number":928,"context_line":"            local n_id"},{"line_number":929,"context_line":"            ironic node-set-maintenance $node_id true"},{"line_number":930,"context_line":"            n_id\u003d$(ironic $ironic_api_version node-update $node_id add network_interface\u003d$IRONIC_NETWORK_INTERFACE)"},{"line_number":931,"context_line":"            die_if_not_set $LINENO n_id \"Failed to update network provider for node\""},{"line_number":932,"context_line":"            ironic node-set-maintenance $node_id false"},{"line_number":933,"context_line":"        fi"},{"line_number":934,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1aa78d24_cf89c1cc","line":931,"in_reply_to":"3aaa91ec_1e6059a4","updated":"2016-07-04 07:33:05.000000000","message":"Done","commit_id":"8206d9fa376f4cfe32586a8c5b1717fde1dc5552"}]}