)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"da593d9f387b508ce022d61e6f79bf6e3b5bbd3f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IPMISocatConsole is a new console driver class using ipmitool and"},{"line_number":10,"context_line":"socat. It has the same APIs of IPMIShellinaboxConsole class and"},{"line_number":11,"context_line":"provides TCP4/TCP6/SSL connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"And get_console_driver() selects one of IPMIShellinaboxConsole() and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3aaa91ec_4c117453","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":41},"updated":"2016-07-01 16:27:25.000000000","message":"According to the spec and code, SSL is not part of this work","commit_id":"bd826a5bb57c7b315e59dc66bde5585874f6b4ae"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"0bbc9ce24cad461510c3529ff8c6cce7ff3ef118","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IPMISocatConsole is a new console driver class using ipmitool and"},{"line_number":10,"context_line":"socat. It has the same APIs of IPMIShellinaboxConsole class and"},{"line_number":11,"context_line":"provides TCP4/TCP6/SSL connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"And get_console_driver() selects one of IPMIShellinaboxConsole() and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1aa78d24_5a575202","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":41},"in_reply_to":"3aaa91ec_4c117453","updated":"2016-07-04 04:16:24.000000000","message":"Done","commit_id":"bd826a5bb57c7b315e59dc66bde5585874f6b4ae"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"da593d9f387b508ce022d61e6f79bf6e3b5bbd3f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"provides TCP4/TCP6/SSL connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"And get_console_driver() selects one of IPMIShellinaboxConsole() and"},{"line_number":15,"context_line":"IPMISocatConsole(), depends on CONF.console.terminal."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- CONF.console.terminal contains \"shellinaboxd\":"},{"line_number":18,"context_line":"   get_console_driver() returns IPMIShellinaboxConsole()"},{"line_number":19,"context_line":"- CONF.console.terminal contains \"socat\":"},{"line_number":20,"context_line":"   get_console_driver() returns IPMISocatConsole()"},{"line_number":21,"context_line":"- Other cases (default):"},{"line_number":22,"context_line":"   get_console_driver() returns IPMIShellinaboxConsole()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Spec: https://review.openstack.org/#/c/319505/"},{"line_number":25,"context_line":"Partial-Bug: #1553083"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3aaa91ec_e9d3f2d3","line":22,"range":{"start_line":14,"start_character":0,"end_line":22,"end_character":56},"updated":"2016-07-01 16:27:25.000000000","message":"I don\u0027t think they patch is doing this","commit_id":"bd826a5bb57c7b315e59dc66bde5585874f6b4ae"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"0bbc9ce24cad461510c3529ff8c6cce7ff3ef118","unresolved":false,"context_lines":[{"line_number":11,"context_line":"provides TCP4/TCP6/SSL connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"And get_console_driver() selects one of IPMIShellinaboxConsole() and"},{"line_number":15,"context_line":"IPMISocatConsole(), depends on CONF.console.terminal."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- CONF.console.terminal contains \"shellinaboxd\":"},{"line_number":18,"context_line":"   get_console_driver() returns IPMIShellinaboxConsole()"},{"line_number":19,"context_line":"- CONF.console.terminal contains \"socat\":"},{"line_number":20,"context_line":"   get_console_driver() returns IPMISocatConsole()"},{"line_number":21,"context_line":"- Other cases (default):"},{"line_number":22,"context_line":"   get_console_driver() returns IPMIShellinaboxConsole()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Spec: https://review.openstack.org/#/c/319505/"},{"line_number":25,"context_line":"Partial-Bug: #1553083"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1aa78d24_9a41ba3c","line":22,"range":{"start_line":14,"start_character":0,"end_line":22,"end_character":56},"in_reply_to":"3aaa91ec_e9d3f2d3","updated":"2016-07-04 04:16:24.000000000","message":"Done","commit_id":"bd826a5bb57c7b315e59dc66bde5585874f6b4ae"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"da593d9f387b508ce022d61e6f79bf6e3b5bbd3f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Spec: https://review.openstack.org/#/c/319505/"},{"line_number":25,"context_line":"Partial-Bug: #1553083"},{"line_number":26,"context_line":"Depends-on: I79ddd83d12cc8111e05b5107359d6db8a8881d61"},{"line_number":27,"context_line":"Change-Id: I35a7dcb7e89baf16d096501fd44dbc12adc8c61e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3aaa91ec_e914924e","line":26,"updated":"2016-07-01 16:27:25.000000000","message":"Depends-on is only used for cross-project dependencies. Since both patches are in Ironic you should use commit dependency.","commit_id":"bd826a5bb57c7b315e59dc66bde5585874f6b4ae"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"0bbc9ce24cad461510c3529ff8c6cce7ff3ef118","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Spec: https://review.openstack.org/#/c/319505/"},{"line_number":25,"context_line":"Partial-Bug: #1553083"},{"line_number":26,"context_line":"Depends-on: I79ddd83d12cc8111e05b5107359d6db8a8881d61"},{"line_number":27,"context_line":"Change-Id: I35a7dcb7e89baf16d096501fd44dbc12adc8c61e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"1aa78d24_7a6fae92","line":26,"in_reply_to":"3aaa91ec_e914924e","updated":"2016-07-04 04:16:24.000000000","message":"Done","commit_id":"bd826a5bb57c7b315e59dc66bde5585874f6b4ae"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IPMITool: add IPMISocatConsole and IPMIConsole class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IPMISocatConsole is a new console driver class using ipmitool and"},{"line_number":10,"context_line":"socat. It has the same APIs of IPMIShellinaboxConsole class and"},{"line_number":11,"context_line":"provides TCP4/TCP6 connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"dada55a8_3def2c1f","line":9,"updated":"2016-07-21 16:35:39.000000000","message":"nit s/driver/interface/","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IPMITool: add IPMISocatConsole and IPMIConsole class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"IPMISocatConsole is a new console driver class using ipmitool and"},{"line_number":10,"context_line":"socat. It has the same APIs of IPMIShellinaboxConsole class and"},{"line_number":11,"context_line":"provides TCP4/TCP6 connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"dada55a8_aaa614be","line":9,"in_reply_to":"dada55a8_3def2c1f","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"socat. It has the same APIs of IPMIShellinaboxConsole class and"},{"line_number":11,"context_line":"provides TCP4/TCP6 connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."},{"line_number":13,"context_line":"IPMIConsole is a new console driver class using ipmitool and used"},{"line_number":14,"context_line":"as common class from IPMIShellinaboxConsole and IPMISocatConsol"},{"line_number":15,"context_line":"class."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"dada55a8_dde0902b","line":13,"updated":"2016-07-21 16:35:39.000000000","message":"nit s/driver/interface/","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":10,"context_line":"socat. It has the same APIs of IPMIShellinaboxConsole class and"},{"line_number":11,"context_line":"provides TCP4/TCP6 connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."},{"line_number":13,"context_line":"IPMIConsole is a new console driver class using ipmitool and used"},{"line_number":14,"context_line":"as common class from IPMIShellinaboxConsole and IPMISocatConsol"},{"line_number":15,"context_line":"class."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"dada55a8_0aaac084","line":13,"in_reply_to":"dada55a8_dde0902b","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"provides TCP4/TCP6 connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."},{"line_number":13,"context_line":"IPMIConsole is a new console driver class using ipmitool and used"},{"line_number":14,"context_line":"as common class from IPMIShellinaboxConsole and IPMISocatConsol"},{"line_number":15,"context_line":"class."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch set implements new console driver interfaces"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"dada55a8_bdc2fc82","line":14,"updated":"2016-07-21 16:35:39.000000000","message":"s/common class from/parent class of/","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":11,"context_line":"provides TCP4/TCP6 connection service to connect serial-on-LAN of"},{"line_number":12,"context_line":"nodes."},{"line_number":13,"context_line":"IPMIConsole is a new console driver class using ipmitool and used"},{"line_number":14,"context_line":"as common class from IPMIShellinaboxConsole and IPMISocatConsol"},{"line_number":15,"context_line":"class."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch set implements new console driver interfaces"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"dada55a8_eaac8ca0","line":14,"in_reply_to":"dada55a8_bdc2fc82","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"}],"ironic/drivers/agent.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027AgentAndIPMIToolDriver\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class AgentAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":70,"context_line":"    \"\"\"Agent + IPMITool + socat driver."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_cb971aea","line":69,"updated":"2016-07-07 19:32:24.000000000","message":"I know that this approach is common, but why not use AgentAndIPMIToolDriver as base class here, and redefine onlu self.console. Since it is only one changed option.\n?","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"36076694a707dbdf71a2b04622451beb11cf0a4a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027AgentAndIPMIToolDriver\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class AgentAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":70,"context_line":"    \"\"\"Agent + IPMITool + socat driver."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_6621e6b4","line":69,"in_reply_to":"1aa78d24_2359958f","updated":"2016-07-08 08:24:01.000000000","message":"I mean that we can inherit AgentAndIPMIToolAndSocatDriver directly from AgentAndIPMIToolDriver and redefine self.console \u003d . \nWe don\u0027t using this for other drivers, not sure why. So I\u0027m interested in community opinion.","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"3ce2a82c2a0c8d83adfabf9fec2c7bc0ef79ecb2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027AgentAndIPMIToolDriver\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class AgentAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":70,"context_line":"    \"\"\"Agent + IPMITool + socat driver."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_904e486d","line":69,"in_reply_to":"1aa78d24_6621e6b4","updated":"2016-07-12 05:15:23.000000000","message":"OK, I understand what you say. I\u0027m not sure, but now driver composition work is going, so it\u0027d be better to do something after that.","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c686b120493250fe889c4553f03c79c05e713b1b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027AgentAndIPMIToolDriver\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class AgentAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":70,"context_line":"    \"\"\"Agent + IPMITool + socat driver."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_2359958f","line":69,"in_reply_to":"1aa78d24_cb971aea","updated":"2016-07-08 05:09:42.000000000","message":"You mean it should be SocatDriver? but interface name is agent_ipmitool_socat. IMO, it should be consistent, WDYT?","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"82d8f18fb35ccb88acd42d7f7e0fa41fc8bc52c0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027AgentAndIPMIToolDriver\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class AgentAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":70,"context_line":"    \"\"\"Agent + IPMITool + socat driver."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_80495a35","line":69,"updated":"2016-07-13 23:20:51.000000000","message":"I now see Vasyl\u0027s previous comment - I agree, you could subclass AgentAndIPMIToolDriver, and set self.console differently.","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f01e6d73702d3e773bde925ae462e520329d6758","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027AgentAndIPMIToolDriver\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class AgentAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":70,"context_line":"    \"\"\"Agent + IPMITool + socat driver."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_b7c2d632","line":69,"in_reply_to":"1aa78d24_80495a35","updated":"2016-07-14 02:58:11.000000000","message":"Done.\nVasyl, thank you for your suggestion.","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9b60c314a399ffcaa2760078a5ba11fd86ead4dc","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    This driver implements the `core` functionality, combining"},{"line_number":73,"context_line":"    :class:`ironic.drivers.modules.ipmitool.IPMIPower` (for power on/off and"},{"line_number":74,"context_line":"    reboot) with :class:`ironic.drivers.modules.agent.AgentDeploy` (for"},{"line_number":75,"context_line":"    image deployment)."},{"line_number":76,"context_line":"    Implementations are in those respective classes; this class is merely the"},{"line_number":77,"context_line":"    glue between them."},{"line_number":78,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_238fa7cd","line":75,"updated":"2016-07-14 17:59:58.000000000","message":"If you do another revision, I think it is worth mentioning that this uses the socat console interface instead of the shellinabox one.\n\nOtherwise, this description is exactly the same as the inherited AgentAndIPMIToolDriver.","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1e4e9274e59c4fe0966f6001477831fb5f51f409","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    This driver implements the `core` functionality, combining"},{"line_number":73,"context_line":"    :class:`ironic.drivers.modules.ipmitool.IPMIPower` (for power on/off and"},{"line_number":74,"context_line":"    reboot) with :class:`ironic.drivers.modules.agent.AgentDeploy` (for"},{"line_number":75,"context_line":"    image deployment)."},{"line_number":76,"context_line":"    Implementations are in those respective classes; this class is merely the"},{"line_number":77,"context_line":"    glue between them."},{"line_number":78,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_16a0d5a4","line":75,"in_reply_to":"1aa78d24_238fa7cd","updated":"2016-07-15 07:56:13.000000000","message":"Done","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"}],"ironic/drivers/fake.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"class FakeIPMIToolSocatDriver(base.BaseDriver):"},{"line_number":94,"context_line":"    \"\"\"Example implementation of a Driver.\"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self):"},{"line_number":97,"context_line":"        self.power \u003d ipmitool.IPMIPower()"},{"line_number":98,"context_line":"        self.console \u003d ipmitool.IPMISocatConsole()"},{"line_number":99,"context_line":"        self.deploy \u003d fake.FakeDeploy()"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_abc1eee5","line":96,"updated":"2016-07-07 19:32:24.000000000","message":"Ditto about inheritance","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"96b146639589df527024791b567f6d54998b2bca","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"def get_console_driver():"},{"line_number":1296,"context_line":"    \"\"\"Return an object of console driver."},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"    :return: IPMIShellinaboxConsole or IPMIShellinaboxConsole"},{"line_number":1299,"context_line":"    \"\"\""},{"line_number":1300,"context_line":"    if \"shellinaboxd\" in CONF.console.terminal:"},{"line_number":1301,"context_line":"        return IPMIShellinaboxConsole()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_4a71c3a7","line":1298,"range":{"start_line":1298,"start_character":39,"end_line":1298,"end_character":61},"updated":"2016-03-23 06:44:20.000000000","message":"not IPMIShellinaboxConsole, but IPMISocatConsole, right?","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3c1f425b0494bf00ab3a6238501929e81cf97e39","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"def get_console_driver():"},{"line_number":1296,"context_line":"    \"\"\"Return an object of console driver."},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"    :return: IPMIShellinaboxConsole or IPMIShellinaboxConsole"},{"line_number":1299,"context_line":"    \"\"\""},{"line_number":1300,"context_line":"    if \"shellinaboxd\" in CONF.console.terminal:"},{"line_number":1301,"context_line":"        return IPMIShellinaboxConsole()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_1bc138e5","line":1298,"range":{"start_line":1298,"start_character":39,"end_line":1298,"end_character":61},"in_reply_to":"da0c15f0_3dc03c7c","updated":"2016-03-29 11:25:58.000000000","message":"Done","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"2813b0f4ffb48fd5d55fdc582970d4e2a976ab94","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"def get_console_driver():"},{"line_number":1296,"context_line":"    \"\"\"Return an object of console driver."},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"    :return: IPMIShellinaboxConsole or IPMIShellinaboxConsole"},{"line_number":1299,"context_line":"    \"\"\""},{"line_number":1300,"context_line":"    if \"shellinaboxd\" in CONF.console.terminal:"},{"line_number":1301,"context_line":"        return IPMIShellinaboxConsole()"}],"source_content_type":"text/x-python","patch_set":8,"id":"da0c15f0_3dc03c7c","line":1298,"range":{"start_line":1298,"start_character":39,"end_line":1298,"end_character":61},"in_reply_to":"fa0719c6_4a71c3a7","updated":"2016-03-28 07:43:24.000000000","message":"Yes! I\u0027ll fix it.","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"96b146639589df527024791b567f6d54998b2bca","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"    \"\"\""},{"line_number":1300,"context_line":"    if \"shellinaboxd\" in CONF.console.terminal:"},{"line_number":1301,"context_line":"        return IPMIShellinaboxConsole()"},{"line_number":1302,"context_line":"    elif \"socat\" in CONF.console.terminal:"},{"line_number":1303,"context_line":"        return IPMISocatConsole()"},{"line_number":1304,"context_line":"    else:"},{"line_number":1305,"context_line":"        return IPMIShellinaboxConsole()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_ea6097d1","line":1303,"range":{"start_line":1302,"start_character":4,"end_line":1303,"end_character":33},"updated":"2016-03-23 06:44:20.000000000","message":"How about like below?\n\n if \"socat\" in CONF.console.terminal:\n     return IPMISocatConsole()\n else:\n     return IPMIShellinaboxConsole()","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3c1f425b0494bf00ab3a6238501929e81cf97e39","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"    \"\"\""},{"line_number":1300,"context_line":"    if \"shellinaboxd\" in CONF.console.terminal:"},{"line_number":1301,"context_line":"        return IPMIShellinaboxConsole()"},{"line_number":1302,"context_line":"    elif \"socat\" in CONF.console.terminal:"},{"line_number":1303,"context_line":"        return IPMISocatConsole()"},{"line_number":1304,"context_line":"    else:"},{"line_number":1305,"context_line":"        return IPMIShellinaboxConsole()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_bbb00c8d","line":1303,"range":{"start_line":1302,"start_character":4,"end_line":1303,"end_character":33},"in_reply_to":"da0c15f0_bd61ecaa","updated":"2016-03-29 11:25:58.000000000","message":"Done","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"2813b0f4ffb48fd5d55fdc582970d4e2a976ab94","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"    \"\"\""},{"line_number":1300,"context_line":"    if \"shellinaboxd\" in CONF.console.terminal:"},{"line_number":1301,"context_line":"        return IPMIShellinaboxConsole()"},{"line_number":1302,"context_line":"    elif \"socat\" in CONF.console.terminal:"},{"line_number":1303,"context_line":"        return IPMISocatConsole()"},{"line_number":1304,"context_line":"    else:"},{"line_number":1305,"context_line":"        return IPMIShellinaboxConsole()"}],"source_content_type":"text/x-python","patch_set":8,"id":"da0c15f0_bd61ecaa","line":1303,"range":{"start_line":1302,"start_character":4,"end_line":1303,"end_character":33},"in_reply_to":"fa0719c6_ea6097d1","updated":"2016-03-28 07:43:24.000000000","message":"Of course, it works. I made it to be clear what is the key to dispatch.","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":7900,"name":"Tomasz Paszkowski","email":"ss7pro@gmail.com","username":"tpaszkowski"},"change_message_id":"6aba3ff33de21c957dcd8fcb9fff434b67c5a9ac","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"        if CONF.debug:"},{"line_number":1261,"context_line":"            ipmi_cmd +\u003d \" -v\""},{"line_number":1262,"context_line":"        ipmi_cmd +\u003d \" sol activate\""},{"line_number":1263,"context_line":"        try:"},{"line_number":1264,"context_line":"            console_utils.start_socat_console(driver_info[\u0027uuid\u0027],"},{"line_number":1265,"context_line":"                                              driver_info[\u0027port\u0027],"},{"line_number":1266,"context_line":"                                              ipmi_cmd)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_3b2c95ab","line":1263,"updated":"2016-06-17 15:43:24.000000000","message":"We should ensure few things here:\n\n1) First we need to drop any existing sol sessions with: sol deactivate.\n2) start console should be started from some kind of supervisor (systemd || supervisord) which will ensure that socat process will keep running even when user will exit ipmitool on his own (~. command) or ipmitool command will crash.","commit_id":"f0586b579d394844469a64c9d911b5904c57084a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7345145cebd915aeaab78c4e34433cd5f439ae35","unresolved":false,"context_lines":[{"line_number":355,"context_line":"    }"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def _exec_ipmitool(driver_info, command, **kwargs):"},{"line_number":359,"context_line":"    \"\"\"Execute the ipmitool command."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    :param driver_info: the ipmitool parameters for accessing a node."}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_cab5efee","line":358,"updated":"2016-07-05 12:50:35.000000000","message":"PLease add to the docstring why do we need it.","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"e25df7b9901bd31351ecd659b39adca911983fcc","unresolved":false,"context_lines":[{"line_number":355,"context_line":"    }"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def _exec_ipmitool(driver_info, command, **kwargs):"},{"line_number":359,"context_line":"    \"\"\"Execute the ipmitool command."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    :param driver_info: the ipmitool parameters for accessing a node."}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_16dd5ee0","line":358,"in_reply_to":"1aa78d24_cab5efee","updated":"2016-07-06 04:44:35.000000000","message":"Done","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7345145cebd915aeaab78c4e34433cd5f439ae35","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"        pw_file \u003d console_utils.make_persistent_password_file("},{"line_number":1146,"context_line":"            path, driver_info[\u0027password\u0027] or \u0027\\0\u0027)"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"        ipmi_cmd \u003d (\"/:%(uid)s:%(gid)s:HOME:ipmitool -H %(address)s\""},{"line_number":1149,"context_line":"                    \" -I lanplus -U %(user)s -f %(pwfile)s\""},{"line_number":1150,"context_line":"                    % {\u0027uid\u0027: os.getuid(),"},{"line_number":1151,"context_line":"                       \u0027gid\u0027: os.getgid(),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_8a05a77b","line":1148,"range":{"start_line":1148,"start_character":21,"end_line":1148,"end_character":44},"updated":"2016-07-05 12:50:35.000000000","message":"Do we need this part too?","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"e25df7b9901bd31351ecd659b39adca911983fcc","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"        pw_file \u003d console_utils.make_persistent_password_file("},{"line_number":1146,"context_line":"            path, driver_info[\u0027password\u0027] or \u0027\\0\u0027)"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"        ipmi_cmd \u003d (\"/:%(uid)s:%(gid)s:HOME:ipmitool -H %(address)s\""},{"line_number":1149,"context_line":"                    \" -I lanplus -U %(user)s -f %(pwfile)s\""},{"line_number":1150,"context_line":"                    % {\u0027uid\u0027: os.getuid(),"},{"line_number":1151,"context_line":"                       \u0027gid\u0027: os.getgid(),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_8acf4328","line":1148,"range":{"start_line":1148,"start_character":21,"end_line":1148,"end_character":44},"in_reply_to":"1aa78d24_8a05a77b","updated":"2016-07-06 04:44:35.000000000","message":"It\u0027s shellinabox option. In case of shellinabox, complete command is like:\n\n shellinaboxd -t -p 1 --background\u003d/tmp/e6285f6a-c17c-42b5-b70f-9ce1fcdd6cf9.pid -s /:1000:1000:HOME:ipmitool -H 192.168.100.6 -I lanplus -U Administrator -f /tmp/e6285f6a-c17c-42b5-b70f-9ce1fcdd6cf9.pw -v sol activate\n\nPlease see: http://linux.die.net/man/1/shellinaboxd\nIn case of socat, the options specifying uid, gid are CWsetuid \n and CWsetgid(Please see: http://linux.die.net/man/1/socat), but I\u0027m not sure whether we need them or not because unless executing socat with root, socat and ipmitool process have same uid, gid with ironic-conductor, so it seems not cause problem. WDYT?","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7345145cebd915aeaab78c4e34433cd5f439ae35","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"            ipmi_cmd +\u003d \" -v\""},{"line_number":1259,"context_line":"        ipmi_cmd +\u003d \" sol activate\""},{"line_number":1260,"context_line":"        try:"},{"line_number":1261,"context_line":"            console_utils.start_socat_console(driver_info[\u0027uuid\u0027],"},{"line_number":1262,"context_line":"                                              driver_info[\u0027port\u0027],"},{"line_number":1263,"context_line":"                                              ipmi_cmd)"},{"line_number":1264,"context_line":"        except (exception.ConsoleError, exception.ConsoleSubprocessFailed):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_8ade470f","line":1261,"updated":"2016-07-05 12:50:35.000000000","message":"This function duplicates most of the things from the shellinabox start_console, could you please create a helper method and move things there?","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"e25df7b9901bd31351ecd659b39adca911983fcc","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"            ipmi_cmd +\u003d \" -v\""},{"line_number":1259,"context_line":"        ipmi_cmd +\u003d \" sol activate\""},{"line_number":1260,"context_line":"        try:"},{"line_number":1261,"context_line":"            console_utils.start_socat_console(driver_info[\u0027uuid\u0027],"},{"line_number":1262,"context_line":"                                              driver_info[\u0027port\u0027],"},{"line_number":1263,"context_line":"                                              ipmi_cmd)"},{"line_number":1264,"context_line":"        except (exception.ConsoleError, exception.ConsoleSubprocessFailed):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_614dfe6b","line":1261,"in_reply_to":"1aa78d24_8ade470f","updated":"2016-07-06 04:44:35.000000000","message":"I can do it, but it seems enough to do after driver composition work separately. can I?","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7345145cebd915aeaab78c4e34433cd5f439ae35","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1282,"context_line":"        try:"},{"line_number":1283,"context_line":"            out, err \u003d _exec_ipmitool(driver_info, cmd, check_exit_code\u003d[0, 1])"},{"line_number":1284,"context_line":"        finally:"},{"line_number":1285,"context_line":"            pass"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"    def get_console(self, task):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_ea3b8b36","line":1284,"updated":"2016-07-05 12:50:35.000000000","message":"Why is this needed? Please remove.","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"e25df7b9901bd31351ecd659b39adca911983fcc","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1282,"context_line":"        try:"},{"line_number":1283,"context_line":"            out, err \u003d _exec_ipmitool(driver_info, cmd, check_exit_code\u003d[0, 1])"},{"line_number":1284,"context_line":"        finally:"},{"line_number":1285,"context_line":"            pass"},{"line_number":1286,"context_line":""},{"line_number":1287,"context_line":"    def get_console(self, task):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_1ce9fde6","line":1284,"in_reply_to":"1aa78d24_ea3b8b36","updated":"2016-07-06 04:44:35.000000000","message":"Done","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0138ed68d7925e08cf64d9d68e21cfe999f9fe2b","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    :param driver_info: the ipmitool parameters for accessing a node."},{"line_number":362,"context_line":"    :param command: the ipmitool command to be executed."},{"line_number":363,"context_line":"    :param kwargs: info for action."},{"line_number":364,"context_line":"    :returns: (stdout, stderr) from executing the command."},{"line_number":365,"context_line":"    :raises: PasswordFileFailedToCreate from creating or writing to the"},{"line_number":366,"context_line":"             temporary file."}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_ab31405c","line":363,"updated":"2016-07-06 15:07:52.000000000","message":"Mostly a nit (because it\u0027s an internal function): I would prefer if we add the \"check_exit_code\" parameter here instead of a kwargs. The reason is because someone reading this docstring won\u0027t know what is supported and what is not by this parameter [0], the kwargs and it\u0027s description is just too vague.\n\n[0] https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/processutils.py#L181","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3edafbb920173ee230392b20532835cbf5bda79c","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    :param driver_info: the ipmitool parameters for accessing a node."},{"line_number":362,"context_line":"    :param command: the ipmitool command to be executed."},{"line_number":363,"context_line":"    :param kwargs: info for action."},{"line_number":364,"context_line":"    :returns: (stdout, stderr) from executing the command."},{"line_number":365,"context_line":"    :raises: PasswordFileFailedToCreate from creating or writing to the"},{"line_number":366,"context_line":"             temporary file."}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_fe6ae4eb","line":363,"in_reply_to":"1aa78d24_ab31405c","updated":"2016-07-06 15:26:56.000000000","message":"+1","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f02371c65251b69deba4360dc1c57cd2f56f390e","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    :param driver_info: the ipmitool parameters for accessing a node."},{"line_number":362,"context_line":"    :param command: the ipmitool command to be executed."},{"line_number":363,"context_line":"    :param kwargs: info for action."},{"line_number":364,"context_line":"    :returns: (stdout, stderr) from executing the command."},{"line_number":365,"context_line":"    :raises: PasswordFileFailedToCreate from creating or writing to the"},{"line_number":366,"context_line":"             temporary file."}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_ff3802d5","line":363,"in_reply_to":"1aa78d24_ab31405c","updated":"2016-07-07 02:59:42.000000000","message":"Done separately in https://review.openstack.org/338658","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def __init__(self):"},{"line_number":1196,"context_line":"        try:"},{"line_number":1197,"context_line":"            _check_option_support([\u0027timing\u0027, \u0027single_bridge\u0027, \u0027dual_bridge\u0027])"},{"line_number":1198,"context_line":"        except OSError:"},{"line_number":1199,"context_line":"            raise exception.DriverLoadError("},{"line_number":1200,"context_line":"                driver\u003dself.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_66661dbc","line":1197,"updated":"2016-07-07 19:32:24.000000000","message":"subprocess.check_call may raise CalledProcessErrorr\nOSError might occur when binary not found. Need to investigate more here.\nhttps://docs.python.org/2/library/subprocess.html","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c686b120493250fe889c4553f03c79c05e713b1b","unresolved":false,"context_lines":[{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def __init__(self):"},{"line_number":1196,"context_line":"        try:"},{"line_number":1197,"context_line":"            _check_option_support([\u0027timing\u0027, \u0027single_bridge\u0027, \u0027dual_bridge\u0027])"},{"line_number":1198,"context_line":"        except OSError:"},{"line_number":1199,"context_line":"            raise exception.DriverLoadError("},{"line_number":1200,"context_line":"                driver\u003dself.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_a380e58c","line":1197,"in_reply_to":"1aa78d24_66661dbc","updated":"2016-07-08 05:09:42.000000000","message":"Here is copied from shellinabox\u0027s one. should I fix it also?","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"36076694a707dbdf71a2b04622451beb11cf0a4a","unresolved":false,"context_lines":[{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def __init__(self):"},{"line_number":1196,"context_line":"        try:"},{"line_number":1197,"context_line":"            _check_option_support([\u0027timing\u0027, \u0027single_bridge\u0027, \u0027dual_bridge\u0027])"},{"line_number":1198,"context_line":"        except OSError:"},{"line_number":1199,"context_line":"            raise exception.DriverLoadError("},{"line_number":1200,"context_line":"                driver\u003dself.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_31f27607","line":1197,"in_reply_to":"1aa78d24_a380e58c","updated":"2016-07-08 08:24:01.000000000","message":"So after deeper investigation, the logic seems to be valid for me. But not sure that it is needed here, since it will be checked during IPMIPower initialization https://github.com/openstack/ironic/blob/03ab6011ee715096fffbbf5ffc8b9f293f1df5a8/ironic/drivers/modules/ipmitool.py#L739","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"            raise exception.DriverLoadError("},{"line_number":1200,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":1201,"context_line":"                reason\u003d_(\"Unable to locate usable ipmitool command in \""},{"line_number":1202,"context_line":"                         \"the system path when checking ipmitool version\"))"},{"line_number":1203,"context_line":"        _check_temp_dir()"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_060e39e4","line":1202,"updated":"2016-07-07 19:32:24.000000000","message":"period is missed at the end","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c686b120493250fe889c4553f03c79c05e713b1b","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"            raise exception.DriverLoadError("},{"line_number":1200,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":1201,"context_line":"                reason\u003d_(\"Unable to locate usable ipmitool command in \""},{"line_number":1202,"context_line":"                         \"the system path when checking ipmitool version\"))"},{"line_number":1203,"context_line":"        _check_temp_dir()"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_1edcac45","line":1202,"in_reply_to":"1aa78d24_060e39e4","updated":"2016-07-08 05:09:42.000000000","message":"Other messages also doesn\u0027t have period at the end.","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"    def validate(self, task):"},{"line_number":1211,"context_line":"        \"\"\"Validate the Node console info."},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        :param task: a task from TaskManager."},{"line_number":1214,"context_line":"        :raises: InvalidParameterValue"},{"line_number":1215,"context_line":"        :raises: MissingParameterValue when a required parameter is missing"},{"line_number":1216,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_860229b2","line":1213,"range":{"start_line":1213,"start_character":21,"end_line":1213,"end_character":22},"updated":"2016-07-07 19:32:24.000000000","message":"s/a/A we start param description with capital letter.","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c686b120493250fe889c4553f03c79c05e713b1b","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"    def validate(self, task):"},{"line_number":1211,"context_line":"        \"\"\"Validate the Node console info."},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        :param task: a task from TaskManager."},{"line_number":1214,"context_line":"        :raises: InvalidParameterValue"},{"line_number":1215,"context_line":"        :raises: MissingParameterValue when a required parameter is missing"},{"line_number":1216,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_deb864eb","line":1213,"range":{"start_line":1213,"start_character":21,"end_line":1213,"end_character":22},"in_reply_to":"1aa78d24_860229b2","updated":"2016-07-08 05:09:42.000000000","message":"Copied from above","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        :param task: a task from TaskManager."},{"line_number":1214,"context_line":"        :raises: InvalidParameterValue"},{"line_number":1215,"context_line":"        :raises: MissingParameterValue when a required parameter is missing"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        \"\"\""},{"line_number":1218,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_0625995a","line":1215,"updated":"2016-07-07 19:32:24.000000000","message":"missed period","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c686b120493250fe889c4553f03c79c05e713b1b","unresolved":false,"context_lines":[{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":"        :param task: a task from TaskManager."},{"line_number":1214,"context_line":"        :raises: InvalidParameterValue"},{"line_number":1215,"context_line":"        :raises: MissingParameterValue when a required parameter is missing"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"        \"\"\""},{"line_number":1218,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_feb720f3","line":1215,"in_reply_to":"1aa78d24_0625995a","updated":"2016-07-08 05:09:42.000000000","message":"Copied from above","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":1226,"context_line":"                \"Serial over lan only works with IPMI protocol version 2.0. \""},{"line_number":1227,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""},{"line_number":1228,"context_line":"                \"node\u0027s driver_info\"))"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"    def start_console(self, task):"},{"line_number":1231,"context_line":"        \"\"\"Start a remote console for the node."}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_a6bf65ce","line":1228,"updated":"2016-07-07 19:32:24.000000000","message":"ditto about period","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1230,"context_line":"    def start_console(self, task):"},{"line_number":1231,"context_line":"        \"\"\"Start a remote console for the node."},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":"        :param task: a task from TaskManager"},{"line_number":1234,"context_line":"        :raises: InvalidParameterValue if required ipmi parameters are missing"},{"line_number":1235,"context_line":"        :raises: PasswordFileFailedToCreate if unable to create a file"},{"line_number":1236,"context_line":"                 containing the password"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_46984178","line":1233,"range":{"start_line":1233,"start_character":21,"end_line":1233,"end_character":22},"updated":"2016-07-07 19:32:24.000000000","message":"ditto about capital letter","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"        \"\"\"Start a remote console for the node."},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":"        :param task: a task from TaskManager"},{"line_number":1234,"context_line":"        :raises: InvalidParameterValue if required ipmi parameters are missing"},{"line_number":1235,"context_line":"        :raises: PasswordFileFailedToCreate if unable to create a file"},{"line_number":1236,"context_line":"                 containing the password"},{"line_number":1237,"context_line":"        :raises: ConsoleError if the directory for the PID file cannot be"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_869ea960","line":1234,"updated":"2016-07-07 19:32:24.000000000","message":"ditto about period","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"        :param task: a task from TaskManager"},{"line_number":1234,"context_line":"        :raises: InvalidParameterValue if required ipmi parameters are missing"},{"line_number":1235,"context_line":"        :raises: PasswordFileFailedToCreate if unable to create a file"},{"line_number":1236,"context_line":"                 containing the password"},{"line_number":1237,"context_line":"        :raises: ConsoleError if the directory for the PID file cannot be"},{"line_number":1238,"context_line":"                 created"},{"line_number":1239,"context_line":"        :raises: ConsoleSubprocessFailed when invoking the subprocess failed"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_c68a711a","line":1236,"updated":"2016-07-07 19:32:24.000000000","message":"same","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"        :raises: PasswordFileFailedToCreate if unable to create a file"},{"line_number":1236,"context_line":"                 containing the password"},{"line_number":1237,"context_line":"        :raises: ConsoleError if the directory for the PID file cannot be"},{"line_number":1238,"context_line":"                 created"},{"line_number":1239,"context_line":"        :raises: ConsoleSubprocessFailed when invoking the subprocess failed"},{"line_number":1240,"context_line":"        \"\"\""},{"line_number":1241,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_068119fb","line":1238,"updated":"2016-07-07 19:32:24.000000000","message":"same","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"        pw_file \u003d console_utils.make_persistent_password_file("},{"line_number":1245,"context_line":"            path, driver_info[\u0027password\u0027] or \u0027\\0\u0027)"},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"        ipmi_cmd \u003d (\"ipmitool -H %(address)s\""},{"line_number":1248,"context_line":"                    \" -I lanplus -U %(user)s -f %(pwfile)s\""},{"line_number":1249,"context_line":"                    % {\u0027address\u0027: driver_info[\u0027address\u0027],"},{"line_number":1250,"context_line":"                       \u0027user\u0027: driver_info[\u0027username\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_c62d51ff","line":1247,"updated":"2016-07-07 19:32:24.000000000","message":"if operator change ipmi port it should be present in this command with -p key right?","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c686b120493250fe889c4553f03c79c05e713b1b","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"        pw_file \u003d console_utils.make_persistent_password_file("},{"line_number":1245,"context_line":"            path, driver_info[\u0027password\u0027] or \u0027\\0\u0027)"},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"        ipmi_cmd \u003d (\"ipmitool -H %(address)s\""},{"line_number":1248,"context_line":"                    \" -I lanplus -U %(user)s -f %(pwfile)s\""},{"line_number":1249,"context_line":"                    % {\u0027address\u0027: driver_info[\u0027address\u0027],"},{"line_number":1250,"context_line":"                       \u0027user\u0027: driver_info[\u0027username\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_de2984f4","line":1247,"in_reply_to":"1aa78d24_c62d51ff","updated":"2016-07-08 05:09:42.000000000","message":"According to _exec_ipmitool(), as you say, -p key seems necessary, but shellinabox also need it. I will fix it separately.","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"    def stop_console(self, task):"},{"line_number":1270,"context_line":"        \"\"\"Stop the remote console session for the node."},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"        :param task: a task from TaskManager"},{"line_number":1273,"context_line":"        :raises: ConsoleError if unable to stop the console"},{"line_number":1274,"context_line":"        \"\"\""},{"line_number":1275,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_661a9dc7","line":1272,"updated":"2016-07-07 19:32:24.000000000","message":"ditto capital letter and period","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"        \"\"\"Stop the remote console session for the node."},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"        :param task: a task from TaskManager"},{"line_number":1273,"context_line":"        :raises: ConsoleError if unable to stop the console"},{"line_number":1274,"context_line":"        \"\"\""},{"line_number":1275,"context_line":"        try:"},{"line_number":1276,"context_line":"            console_utils.stop_socat_console(task.node.uuid)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_c67b91f3","line":1273,"updated":"2016-07-07 19:32:24.000000000","message":"ditto about period","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0138ed68d7925e08cf64d9d68e21cfe999f9fe2b","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"        out, err \u003d _exec_ipmitool(driver_info, cmd, check_exit_code\u003d[0, 1])"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"    def get_console(self, task):"},{"line_number":1286,"context_line":"        \"\"\"Get the type and connection information about the console.\"\"\""},{"line_number":1287,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1288,"context_line":"        url \u003d console_utils.get_socat_console_url(driver_info[\u0027port\u0027])"},{"line_number":1289,"context_line":"        return {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_cb964cef","line":1286,"updated":"2016-07-06 15:07:52.000000000","message":"nit: \n\n:param task: ...","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f02371c65251b69deba4360dc1c57cd2f56f390e","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"        out, err \u003d _exec_ipmitool(driver_info, cmd, check_exit_code\u003d[0, 1])"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"    def get_console(self, task):"},{"line_number":1286,"context_line":"        \"\"\"Get the type and connection information about the console.\"\"\""},{"line_number":1287,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1288,"context_line":"        url \u003d console_utils.get_socat_console_url(driver_info[\u0027port\u0027])"},{"line_number":1289,"context_line":"        return {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_5f34b6dc","line":1286,"in_reply_to":"1aa78d24_cb964cef","updated":"2016-07-07 02:59:42.000000000","message":"Done separately in https://review.openstack.org/338658","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9684feb34f57a8ac9f1982c8d90287b17a033276","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":1201,"context_line":"                reason\u003d_(\"Unable to locate usable ipmitool command in \""},{"line_number":1202,"context_line":"                         \"the system path when checking ipmitool version\"))"},{"line_number":1203,"context_line":"        _check_temp_dir()"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"    def get_properties(self):"},{"line_number":1206,"context_line":"        d \u003d COMMON_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_401e5260","line":1203,"updated":"2016-07-13 23:17:54.000000000","message":"Could we create a common class that IPMISocatConsole and IPMIShellinaboxConsole use, that has common code like this, validate, and get_properties? Lots of duplication there.","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f01e6d73702d3e773bde925ae462e520329d6758","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"                driver\u003dself.__class__.__name__,"},{"line_number":1201,"context_line":"                reason\u003d_(\"Unable to locate usable ipmitool command in \""},{"line_number":1202,"context_line":"                         \"the system path when checking ipmitool version\"))"},{"line_number":1203,"context_line":"        _check_temp_dir()"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"    def get_properties(self):"},{"line_number":1206,"context_line":"        d \u003d COMMON_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_97bfdaa9","line":1203,"in_reply_to":"1aa78d24_401e5260","updated":"2016-07-14 02:58:11.000000000","message":"Done","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9684feb34f57a8ac9f1982c8d90287b17a033276","unresolved":false,"context_lines":[{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        if CONF.debug:"},{"line_number":1259,"context_line":"            ipmi_cmd +\u003d \" -v\""},{"line_number":1260,"context_line":"        ipmi_cmd +\u003d \" sol activate\""},{"line_number":1261,"context_line":"        try:"},{"line_number":1262,"context_line":"            console_utils.start_socat_console(driver_info[\u0027uuid\u0027],"},{"line_number":1263,"context_line":"                                              driver_info[\u0027port\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_60638ede","line":1260,"updated":"2016-07-13 23:17:54.000000000","message":"This method down to here could be factored out, too","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7341cb8bf832300a058dd85c3658270b7d818dfc","unresolved":false,"context_lines":[{"line_number":1226,"context_line":""},{"line_number":1227,"context_line":"        if CONF.debug:"},{"line_number":1228,"context_line":"            ipmi_cmd +\u003d \" -v\""},{"line_number":1229,"context_line":"        ipmi_cmd +\u003d \" sol activate\""},{"line_number":1230,"context_line":"        try:"},{"line_number":1231,"context_line":"            console_utils.start_socat_console(driver_info[\u0027uuid\u0027],"},{"line_number":1232,"context_line":"                                              driver_info[\u0027port\u0027],"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_1285b806","line":1229,"updated":"2016-07-14 03:11:08.000000000","message":"Can we also factor out everything in this method above this comment? It seems to be the same between the two drivers.","commit_id":"278c367d4ae2b4d5fdbf075019060f9bef3939c5"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"0df362e187bbe6a781c0d3c207962a209f102680","unresolved":false,"context_lines":[{"line_number":1226,"context_line":""},{"line_number":1227,"context_line":"        if CONF.debug:"},{"line_number":1228,"context_line":"            ipmi_cmd +\u003d \" -v\""},{"line_number":1229,"context_line":"        ipmi_cmd +\u003d \" sol activate\""},{"line_number":1230,"context_line":"        try:"},{"line_number":1231,"context_line":"            console_utils.start_socat_console(driver_info[\u0027uuid\u0027],"},{"line_number":1232,"context_line":"                                              driver_info[\u0027port\u0027],"}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_3ebfd161","line":1229,"in_reply_to":"1aa78d24_1285b806","updated":"2016-07-14 10:27:17.000000000","message":"Done. Sorry for not having notice your comment in previous patch set.","commit_id":"278c367d4ae2b4d5fdbf075019060f9bef3939c5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9b60c314a399ffcaa2760078a5ba11fd86ead4dc","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""},{"line_number":1130,"context_line":"                \"node\u0027s driver_info\"))"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def get_start_console_command(self, task):"},{"line_number":1133,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        path \u003d _console_pwfile_path(driver_info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_631b6f81","line":1132,"updated":"2016-07-14 17:59:58.000000000","message":"would be good to have a docstring that describes this. It returns something, right?\n\nI think some exceptions may get raised.","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1e4e9274e59c4fe0966f6001477831fb5f51f409","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                \"Check the \u0027ipmi_protocol_version\u0027 parameter in \""},{"line_number":1130,"context_line":"                \"node\u0027s driver_info\"))"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def get_start_console_command(self, task):"},{"line_number":1133,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        path \u003d _console_pwfile_path(driver_info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_115f3f76","line":1132,"in_reply_to":"1aa78d24_631b6f81","updated":"2016-07-15 07:56:13.000000000","message":"Done","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9b60c314a399ffcaa2760078a5ba11fd86ead4dc","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"                 created"},{"line_number":1170,"context_line":"        :raises: ConsoleSubprocessFailed when invoking the subprocess failed"},{"line_number":1171,"context_line":"        \"\"\""},{"line_number":1172,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"        ipmi_cmd \u003d self.get_start_console_command(task)"},{"line_number":1175,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_fedb727b","line":1172,"updated":"2016-07-14 17:59:58.000000000","message":"i don\u0027t like that this is being called here AND in self.get_start_console_command()","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1e4e9274e59c4fe0966f6001477831fb5f51f409","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"                 created"},{"line_number":1170,"context_line":"        :raises: ConsoleSubprocessFailed when invoking the subprocess failed"},{"line_number":1171,"context_line":"        \"\"\""},{"line_number":1172,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1173,"context_line":""},{"line_number":1174,"context_line":"        ipmi_cmd \u003d self.get_start_console_command(task)"},{"line_number":1175,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_75482ecd","line":1172,"in_reply_to":"1aa78d24_fedb727b","updated":"2016-07-15 07:56:13.000000000","message":"Done","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9b60c314a399ffcaa2760078a5ba11fd86ead4dc","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                 created"},{"line_number":1215,"context_line":"        :raises: ConsoleSubprocessFailed when invoking the subprocess failed"},{"line_number":1216,"context_line":"        \"\"\""},{"line_number":1217,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        ipmi_cmd \u003d self.get_start_console_command(task)"},{"line_number":1220,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_5e2f263e","line":1217,"updated":"2016-07-14 17:59:58.000000000","message":"ditto","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1e4e9274e59c4fe0966f6001477831fb5f51f409","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"                 created"},{"line_number":1215,"context_line":"        :raises: ConsoleSubprocessFailed when invoking the subprocess failed"},{"line_number":1216,"context_line":"        \"\"\""},{"line_number":1217,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        ipmi_cmd \u003d self.get_start_console_command(task)"},{"line_number":1220,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_554372af","line":1217,"in_reply_to":"1aa78d24_5e2f263e","updated":"2016-07-15 07:56:13.000000000","message":"Done","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9b60c314a399ffcaa2760078a5ba11fd86ead4dc","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"        try:"},{"line_number":1221,"context_line":"            console_utils.start_socat_console(driver_info[\u0027uuid\u0027],"},{"line_number":1222,"context_line":"                                              driver_info[\u0027port\u0027],"},{"line_number":1223,"context_line":"                                              ipmi_cmd)"},{"line_number":1224,"context_line":"        except (exception.ConsoleError, exception.ConsoleSubprocessFailed):"},{"line_number":1225,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1226,"context_line":"                path \u003d _console_pwfile_path(driver_info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_be6baaf0","line":1223,"updated":"2016-07-14 17:59:58.000000000","message":"I saw a comment from Tomasz in revision 13, but didn\u0027t see any reply, so I\u0027m going to copy that to here.\nWe should ensure few things here:\n1) First we need to drop any existing sol sessions with: sol deactivate.\n2) start console should be started from some kind of supervisor (systemd || supervisord) which will ensure that socat process will keep running even when user will exit ipmitool on his own (~. command) or ipmitool command will crash.","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1e4e9274e59c4fe0966f6001477831fb5f51f409","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"        try:"},{"line_number":1221,"context_line":"            console_utils.start_socat_console(driver_info[\u0027uuid\u0027],"},{"line_number":1222,"context_line":"                                              driver_info[\u0027port\u0027],"},{"line_number":1223,"context_line":"                                              ipmi_cmd)"},{"line_number":1224,"context_line":"        except (exception.ConsoleError, exception.ConsoleSubprocessFailed):"},{"line_number":1225,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1226,"context_line":"                path \u003d _console_pwfile_path(driver_info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_3ec4be3f","line":1223,"in_reply_to":"1aa78d24_be6baaf0","updated":"2016-07-15 07:56:13.000000000","message":"1)Done\n2)socat command is executed with \"fork\" option, so, socat will restart ipmi(sol session) in case of sol session dropped.\nAnd Tomasz, sorry for having not notice your comment.","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9b60c314a399ffcaa2760078a5ba11fd86ead4dc","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        except (exception.ConsoleError, exception.ConsoleSubprocessFailed):"},{"line_number":1225,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1226,"context_line":"                path \u003d _console_pwfile_path(driver_info[\u0027uuid\u0027])"},{"line_number":1227,"context_line":"                ironic_utils.unlink_without_raise(path)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    def stop_console(self, task):"},{"line_number":1230,"context_line":"        \"\"\"Stop the remote console session for the node."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_9e386e3f","line":1227,"updated":"2016-07-14 17:59:58.000000000","message":"I have two thoughts. From what I can tell, everything is the same with IPMIShellinaboxConsole.start_console, except for the actual call to start the console, console_utils.start_socat_console vs start_shellinabox_console. So you could add an IPMIConsole._start_console(task, start_method) and call that, passing either the .start_socat_console() or .start_shellinabox_console() method.\n\nOR\n\nchange self.get_start_console_command() to return a tuple: (driver_info, command) OR tuple (port, command) [You can get the node\u0027s uuid from task.node.uuid]","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1e4e9274e59c4fe0966f6001477831fb5f51f409","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        except (exception.ConsoleError, exception.ConsoleSubprocessFailed):"},{"line_number":1225,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1226,"context_line":"                path \u003d _console_pwfile_path(driver_info[\u0027uuid\u0027])"},{"line_number":1227,"context_line":"                ironic_utils.unlink_without_raise(path)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"    def stop_console(self, task):"},{"line_number":1230,"context_line":"        \"\"\"Stop the remote console session for the node."}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_c484d2d4","line":1227,"in_reply_to":"1aa78d24_9e386e3f","updated":"2016-07-15 07:56:13.000000000","message":"Done","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"8b9d635944c38ff6b23be5cea0aed5233e54a7e3","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"                \"node\u0027s driver_info\"))"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"    def _start_console(self, task, start_method):"},{"line_number":1136,"context_line":"        \"\"\"\"Start a remote console for the node."},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        :param task: a task from TaskManager"},{"line_number":1139,"context_line":"        :param start_method: console_utils method to start console"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_a5d687ee","line":1136,"updated":"2016-07-21 03:09:26.000000000","message":"nit: redundant \u0027\"\u0027.","commit_id":"af73f4ac364c9f3a0dd01c287a405bc7bb404949"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"8365aa0fdbae624e3af0f3fc79cba04fd81295cd","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"                \"node\u0027s driver_info\"))"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"    def _start_console(self, task, start_method):"},{"line_number":1136,"context_line":"        \"\"\"\"Start a remote console for the node."},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        :param task: a task from TaskManager"},{"line_number":1139,"context_line":"        :param start_method: console_utils method to start console"}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_5b94cc41","line":1136,"in_reply_to":"dada55a8_a5d687ee","updated":"2016-07-21 04:23:08.000000000","message":"Done","commit_id":"af73f4ac364c9f3a0dd01c287a405bc7bb404949"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"8b9d635944c38ff6b23be5cea0aed5233e54a7e3","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        \"\"\""},{"line_number":1225,"context_line":"        try:"},{"line_number":1226,"context_line":"            self._exec_stop_console(task)"},{"line_number":1227,"context_line":"        except OSError:"},{"line_number":1228,"context_line":"            pass"},{"line_number":1229,"context_line":"        self._start_console(task, console_utils.start_socat_console)"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_05f03366","line":1227,"updated":"2016-07-21 03:09:26.000000000","message":"You may put a comment here to explain why we ignore the failure.","commit_id":"af73f4ac364c9f3a0dd01c287a405bc7bb404949"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"8365aa0fdbae624e3af0f3fc79cba04fd81295cd","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        \"\"\""},{"line_number":1225,"context_line":"        try:"},{"line_number":1226,"context_line":"            self._exec_stop_console(task)"},{"line_number":1227,"context_line":"        except OSError:"},{"line_number":1228,"context_line":"            pass"},{"line_number":1229,"context_line":"        self._start_console(task, console_utils.start_socat_console)"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_bb74e835","line":1227,"in_reply_to":"dada55a8_05f03366","updated":"2016-07-21 04:23:08.000000000","message":"Done","commit_id":"af73f4ac364c9f3a0dd01c287a405bc7bb404949"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"8b9d635944c38ff6b23be5cea0aed5233e54a7e3","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"    def _exec_stop_console(self, task):"},{"line_number":1245,"context_line":"        cmd \u003d \"sol deactivate\""},{"line_number":1246,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1247,"context_line":"        out, err \u003d _exec_ipmitool(driver_info, cmd, check_exit_code\u003d[0, 1])"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def get_console(self, task):"},{"line_number":1250,"context_line":"        \"\"\"Get the type and connection information about the console."}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_051af37c","line":1247,"updated":"2016-07-21 03:09:26.000000000","message":"(out, err) are unused. Please either remove them or log the error.","commit_id":"af73f4ac364c9f3a0dd01c287a405bc7bb404949"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"8365aa0fdbae624e3af0f3fc79cba04fd81295cd","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"    def _exec_stop_console(self, task):"},{"line_number":1245,"context_line":"        cmd \u003d \"sol deactivate\""},{"line_number":1246,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1247,"context_line":"        out, err \u003d _exec_ipmitool(driver_info, cmd, check_exit_code\u003d[0, 1])"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def get_console(self, task):"},{"line_number":1250,"context_line":"        \"\"\"Get the type and connection information about the console."}],"source_content_type":"text/x-python","patch_set":26,"id":"dada55a8_bbd98824","line":1247,"in_reply_to":"dada55a8_051af37c","updated":"2016-07-21 04:23:08.000000000","message":"Done","commit_id":"af73f4ac364c9f3a0dd01c287a405bc7bb404949"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":1223,"context_line":"        :raises: ConsoleSubprocessFailed when invoking the subprocess failed"},{"line_number":1224,"context_line":"        \"\"\""},{"line_number":1225,"context_line":"        try:"},{"line_number":1226,"context_line":"            self._exec_stop_console(task)"},{"line_number":1227,"context_line":"        except OSError:"},{"line_number":1228,"context_line":"            # We need to drop any existing sol sessions with sol deactivate."},{"line_number":1229,"context_line":"            # OSError is raised when sol session is deactive, so we can"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_5de65fe8","line":1226,"updated":"2016-07-21 16:35:39.000000000","message":"I don\u0027t like that we are calling _parse_driver_info() twice; one here and once in self._start_console()\n\nWhat do you think about changing it so self._start_console() takes driver_info instead of task, eg: self._start_console(driver_info, ...)\n\nAnd all the methods that call self._start_console() can do driver_info\u003d_parse_driver_info() first.\n\nAnd then self._exec_stop_console(driver_info) instead of passing it the task.","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":1223,"context_line":"        :raises: ConsoleSubprocessFailed when invoking the subprocess failed"},{"line_number":1224,"context_line":"        \"\"\""},{"line_number":1225,"context_line":"        try:"},{"line_number":1226,"context_line":"            self._exec_stop_console(task)"},{"line_number":1227,"context_line":"        except OSError:"},{"line_number":1228,"context_line":"            # We need to drop any existing sol sessions with sol deactivate."},{"line_number":1229,"context_line":"            # OSError is raised when sol session is deactive, so we can"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_aa657445","line":1226,"in_reply_to":"dada55a8_5de65fe8","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"da366d580c3b8e9b423cf83008a10e30a49c3bfb","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"    def _start_console(self, driver_info, start_method):"},{"line_number":1136,"context_line":"        \"\"\"Start a remote console for the node."},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        :param task: a task from TaskManager"},{"line_number":1139,"context_line":"        :param start_method: console_utils method to start console"},{"line_number":1140,"context_line":"        :raises: InvalidParameterValue if required ipmi parameters are missing"},{"line_number":1141,"context_line":"        :raises: PasswordFileFailedToCreate if unable to create a file"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_fc9b5a64","line":1138,"updated":"2016-07-25 13:30:39.000000000","message":"this should be driver_info, not task.","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437770ed5174a8a3c4fcf551fd64d5d9c0cc8a48","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"    def _start_console(self, driver_info, start_method):"},{"line_number":1136,"context_line":"        \"\"\"Start a remote console for the node."},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        :param task: a task from TaskManager"},{"line_number":1139,"context_line":"        :param start_method: console_utils method to start console"},{"line_number":1140,"context_line":"        :raises: InvalidParameterValue if required ipmi parameters are missing"},{"line_number":1141,"context_line":"        :raises: PasswordFileFailedToCreate if unable to create a file"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_d35800fd","line":1138,"in_reply_to":"dada55a8_fc9b5a64","updated":"2016-07-25 14:52:48.000000000","message":"++","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"c22eb2a4db6c2ae8fc0320a6b8d3ceadb49962de","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"    def _start_console(self, driver_info, start_method):"},{"line_number":1136,"context_line":"        \"\"\"Start a remote console for the node."},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        :param task: a task from TaskManager"},{"line_number":1139,"context_line":"        :param start_method: console_utils method to start console"},{"line_number":1140,"context_line":"        :raises: InvalidParameterValue if required ipmi parameters are missing"},{"line_number":1141,"context_line":"        :raises: PasswordFileFailedToCreate if unable to create a file"}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_bb150de6","line":1138,"in_reply_to":"dada55a8_fc9b5a64","updated":"2016-08-01 08:31:43.000000000","message":"Done","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437770ed5174a8a3c4fcf551fd64d5d9c0cc8a48","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"        \"\"\""},{"line_number":1258,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"},{"line_number":1259,"context_line":"        url \u003d console_utils.get_socat_console_url(driver_info[\u0027port\u0027])"},{"line_number":1260,"context_line":"        return {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_13d29800","line":1260,"updated":"2016-07-25 14:52:48.000000000","message":"Just a note (nothing to do with this patch):\n\nThis file now have six classes in it, I think it\u0027s time to us to break the ipmitool driver in modules like we do for other drivers (e.g ipmitool/console.py and ipmitool/power.py)","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"}],"ironic/drivers/pxe.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92706728d13ad0796faef2da86c86a177af8eb0c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class PXEAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":89,"context_line":"    \"\"\"PXE + IPMITool + socat driver."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_8b1fd2b5","line":88,"updated":"2016-07-07 19:32:24.000000000","message":"This driver missed from setup.cfg","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"36076694a707dbdf71a2b04622451beb11cf0a4a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class PXEAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":89,"context_line":"    \"\"\"PXE + IPMITool + socat driver."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_6608c62e","line":88,"in_reply_to":"1aa78d24_1e594c8f","updated":"2016-07-08 08:24:01.000000000","message":"The commit message says that it was added here, so please update this commit. I don\u0027t like follow up patches, when the patch is not merged yet.","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"3ce2a82c2a0c8d83adfabf9fec2c7bc0ef79ecb2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class PXEAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":89,"context_line":"    \"\"\"PXE + IPMITool + socat driver."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_96691bfc","line":88,"in_reply_to":"1aa78d24_6608c62e","updated":"2016-07-12 05:15:23.000000000","message":"Done","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"c686b120493250fe889c4553f03c79c05e713b1b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class PXEAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":89,"context_line":"    \"\"\"PXE + IPMITool + socat driver."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_1e594c8f","line":88,"in_reply_to":"1aa78d24_8b1fd2b5","updated":"2016-07-08 05:09:42.000000000","message":"Done separately in https://review.openstack.org/#/c/338658/, thanks.","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"82d8f18fb35ccb88acd42d7f7e0fa41fc8bc52c0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class PXEAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":89,"context_line":"    \"\"\"PXE + IPMITool + socat driver."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_c05362e1","line":88,"updated":"2016-07-13 23:20:51.000000000","message":"Ditto","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f01e6d73702d3e773bde925ae462e520329d6758","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class PXEAndIPMIToolAndSocatDriver(base.BaseDriver):"},{"line_number":89,"context_line":"    \"\"\"PXE + IPMITool + socat driver."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    This driver implements the `core` functionality, combining"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aa78d24_573a9235","line":88,"in_reply_to":"1aa78d24_c05362e1","updated":"2016-07-14 02:58:11.000000000","message":"Done","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9b60c314a399ffcaa2760078a5ba11fd86ead4dc","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :class:`ironic.drivers.modules.iscsi_deploy.ISCSIDeploy` for"},{"line_number":95,"context_line":"    image deployment. Implementations are in those respective"},{"line_number":96,"context_line":"    classes; this class is merely the glue between them."},{"line_number":97,"context_line":"    \"\"\""},{"line_number":98,"context_line":"    def __init__(self):"},{"line_number":99,"context_line":"        PXEAndIPMIToolDriver.__init__(self)"},{"line_number":100,"context_line":"        self.console \u003d ipmitool.IPMISocatConsole()"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_e372bfe2","line":97,"updated":"2016-07-14 17:59:58.000000000","message":"ditto, should mention that it uses socat console interface instead of shellinabox one.","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"1e4e9274e59c4fe0966f6001477831fb5f51f409","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    :class:`ironic.drivers.modules.iscsi_deploy.ISCSIDeploy` for"},{"line_number":95,"context_line":"    image deployment. Implementations are in those respective"},{"line_number":96,"context_line":"    classes; this class is merely the glue between them."},{"line_number":97,"context_line":"    \"\"\""},{"line_number":98,"context_line":"    def __init__(self):"},{"line_number":99,"context_line":"        PXEAndIPMIToolDriver.__init__(self)"},{"line_number":100,"context_line":"        self.console \u003d ipmitool.IPMISocatConsole()"}],"source_content_type":"text/x-python","patch_set":22,"id":"1aa78d24_44df42d6","line":97,"in_reply_to":"1aa78d24_e372bfe2","updated":"2016-07-15 07:56:13.000000000","message":"Done","commit_id":"f5ecfb26c74a334ebe137774ba3c30e9b4343a04"}],"ironic/tests/unit/drivers/modules/test_ipmitool.py":[{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"96b146639589df527024791b567f6d54998b2bca","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"        self.assertEqual(states.ERROR, state)"},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"class IPMIToolDriverTestCase(db_base.DbTestCase):"},{"line_number":1314,"context_line":""},{"line_number":1315,"context_line":"    def setUp(self, terminal\u003dNone):"},{"line_number":1316,"context_line":"        super(IPMIToolDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_90678ce8","line":1313,"range":{"start_line":1313,"start_character":6,"end_line":1313,"end_character":28},"updated":"2016-03-23 06:44:20.000000000","message":"Could you please add test case of get_console_driver function in ipmitool.py into this class?","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3c1f425b0494bf00ab3a6238501929e81cf97e39","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"        self.assertEqual(states.ERROR, state)"},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"class IPMIToolDriverTestCase(db_base.DbTestCase):"},{"line_number":1314,"context_line":""},{"line_number":1315,"context_line":"    def setUp(self, terminal\u003dNone):"},{"line_number":1316,"context_line":"        super(IPMIToolDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_14d58542","line":1313,"range":{"start_line":1313,"start_character":6,"end_line":1313,"end_character":28},"in_reply_to":"fa0719c6_90678ce8","updated":"2016-03-29 11:25:58.000000000","message":"Done","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"2813b0f4ffb48fd5d55fdc582970d4e2a976ab94","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"        self.assertEqual(states.ERROR, state)"},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"class IPMIToolDriverTestCase(db_base.DbTestCase):"},{"line_number":1314,"context_line":""},{"line_number":1315,"context_line":"    def setUp(self, terminal\u003dNone):"},{"line_number":1316,"context_line":"        super(IPMIToolDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"da0c15f0_3de31c07","line":1313,"range":{"start_line":1313,"start_character":6,"end_line":1313,"end_character":28},"in_reply_to":"fa0719c6_90678ce8","updated":"2016-03-28 07:43:24.000000000","message":"It\u0027s easy to implement some tests, but IMO, additional test cases below cover the test for get_console_driver().","commit_id":"040df58ecdc6c5c8d6cbcdedd4c625aee54f4864"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7345145cebd915aeaab78c4e34433cd5f439ae35","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    @mock.patch.object(utils, \u0027check_dir\u0027, autospec\u003dTrue)"},{"line_number":178,"context_line":"    def test_console_init_calls_for_socat(self, mock_check_dir, mock_support):"},{"line_number":179,"context_line":"        mock_support.return_value \u003d True"},{"line_number":180,"context_line":"        ipmi.TMP_DIR_CHECKED \u003d None"},{"line_number":181,"context_line":"        ipmi.IPMISocatConsole()"},{"line_number":182,"context_line":"        mock_support.assert_called_with(mock.ANY)"},{"line_number":183,"context_line":"        mock_check_dir.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_ead70bbd","line":180,"updated":"2016-07-05 12:50:35.000000000","message":"I understand that this is how other tests are done, but could you please mock global variables instead of assigning values directly to them? It will help to avoid the races possible here.","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"e25df7b9901bd31351ecd659b39adca911983fcc","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    @mock.patch.object(utils, \u0027check_dir\u0027, autospec\u003dTrue)"},{"line_number":178,"context_line":"    def test_console_init_calls_for_socat(self, mock_check_dir, mock_support):"},{"line_number":179,"context_line":"        mock_support.return_value \u003d True"},{"line_number":180,"context_line":"        ipmi.TMP_DIR_CHECKED \u003d None"},{"line_number":181,"context_line":"        ipmi.IPMISocatConsole()"},{"line_number":182,"context_line":"        mock_support.assert_called_with(mock.ANY)"},{"line_number":183,"context_line":"        mock_check_dir.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_2792c5f6","line":180,"in_reply_to":"1aa78d24_ead70bbd","updated":"2016-07-06 04:44:35.000000000","message":"Done. For other test cases, it\u0027s out of scope in this patch set, so I will fix in separated patch.","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7345145cebd915aeaab78c4e34433cd5f439ae35","unresolved":false,"context_lines":[{"line_number":2103,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2104,"context_line":"                       autospec\u003dTrue)"},{"line_number":2105,"context_line":"    def test_start_console_fail(self, mock_exec):"},{"line_number":2106,"context_line":"        mock_exec.side_effect \u003d iter("},{"line_number":2107,"context_line":"            [exception.ConsoleSubprocessFailed(error\u003d\u0027error\u0027)])"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_2a90f3eb","line":2106,"updated":"2016-07-05 12:50:35.000000000","message":"no need for iter, in other places too.","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"e25df7b9901bd31351ecd659b39adca911983fcc","unresolved":false,"context_lines":[{"line_number":2103,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2104,"context_line":"                       autospec\u003dTrue)"},{"line_number":2105,"context_line":"    def test_start_console_fail(self, mock_exec):"},{"line_number":2106,"context_line":"        mock_exec.side_effect \u003d iter("},{"line_number":2107,"context_line":"            [exception.ConsoleSubprocessFailed(error\u003d\u0027error\u0027)])"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1aa78d24_5cf385d6","line":2106,"in_reply_to":"1aa78d24_2a90f3eb","updated":"2016-07-06 04:44:35.000000000","message":"Done","commit_id":"3916e2047da69ad19c18d16a85009ef809b40fa2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0138ed68d7925e08cf64d9d68e21cfe999f9fe2b","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    @mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"},{"line_number":177,"context_line":"    @mock.patch.object(utils, \u0027check_dir\u0027, autospec\u003dTrue)"},{"line_number":178,"context_line":"    def test_console_init_calls_for_socat(self, mock_check_dir, mock_support):"},{"line_number":179,"context_line":"        with mock.patch.object(ipmi, \u0027TMP_DIR_CHECKED\u0027):"},{"line_number":180,"context_line":"            mock_support.return_value \u003d True"},{"line_number":181,"context_line":"            ipmi.TMP_DIR_CHECKED \u003d None"},{"line_number":182,"context_line":"            ipmi.IPMISocatConsole()"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_4bc6dc9a","line":179,"updated":"2016-07-06 15:07:52.000000000","message":"nit (doesn\u0027t need to change as part of this patch): It would be good to have it mocked for all the other tests above, perhaps adding the decorator to the class.\n\nWe can do it in another patch.","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f02371c65251b69deba4360dc1c57cd2f56f390e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    @mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"},{"line_number":177,"context_line":"    @mock.patch.object(utils, \u0027check_dir\u0027, autospec\u003dTrue)"},{"line_number":178,"context_line":"    def test_console_init_calls_for_socat(self, mock_check_dir, mock_support):"},{"line_number":179,"context_line":"        with mock.patch.object(ipmi, \u0027TMP_DIR_CHECKED\u0027):"},{"line_number":180,"context_line":"            mock_support.return_value \u003d True"},{"line_number":181,"context_line":"            ipmi.TMP_DIR_CHECKED \u003d None"},{"line_number":182,"context_line":"            ipmi.IPMISocatConsole()"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aa78d24_7f2c1299","line":179,"in_reply_to":"1aa78d24_4bc6dc9a","updated":"2016-07-07 02:59:42.000000000","message":"Done separately in https://review.openstack.org/338665","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":193,"context_line":"            ipmi.IPMISocatConsole()"},{"line_number":194,"context_line":"            mock_support.assert_called_with(mock.ANY)"},{"line_number":195,"context_line":"            self.assertEqual(0, mock_check_dir.call_count)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"@mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_5d3adfe7","line":195,"updated":"2016-07-21 16:35:39.000000000","message":"or self.assertFalse(mock_check_dir.called)","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":193,"context_line":"            ipmi.IPMISocatConsole()"},{"line_number":194,"context_line":"            mock_support.assert_called_with(mock.ANY)"},{"line_number":195,"context_line":"            self.assertEqual(0, mock_check_dir.call_count)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"@mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_8d61aad5","line":195,"in_reply_to":"dada55a8_5d3adfe7","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        mock_support.assert_called_once_with(\u0027timing\u0027)"},{"line_number":1185,"context_line":"        mock_exec.assert_called_once_with(*args)"},{"line_number":1186,"context_line":"        self.assertFalse(mock_sleep.called)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)"},{"line_number":1189,"context_line":"    def test__power_status_on(self, mock_exec, mock_sleep):"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_fdc113e5","line":1186,"updated":"2016-07-21 16:35:39.000000000","message":"We should add a test for check_exit_code parameter to ipmi._exec_ipmitool()","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        mock_support.assert_called_once_with(\u0027timing\u0027)"},{"line_number":1185,"context_line":"        mock_exec.assert_called_once_with(*args)"},{"line_number":1186,"context_line":"        self.assertFalse(mock_sleep.called)"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)"},{"line_number":1189,"context_line":"    def test__power_status_on(self, mock_exec, mock_sleep):"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_c3eb7311","line":1186,"in_reply_to":"dada55a8_fdc113e5","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2086,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":2087,"context_line":""},{"line_number":2088,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":2089,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2090,"context_line":"            self.driver.console.start_console(task)"},{"line_number":2091,"context_line":""},{"line_number":2092,"context_line":"        mock_exec.assert_called_once_with(self.info[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_a0a650ab","line":2089,"updated":"2016-07-21 16:35:39.000000000","message":"please use self.node.uuid instead of self.node[\u0027uuid\u0027]","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2086,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":2087,"context_line":""},{"line_number":2088,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":2089,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2090,"context_line":"            self.driver.console.start_console(task)"},{"line_number":2091,"context_line":""},{"line_number":2092,"context_line":"        mock_exec.assert_called_once_with(self.info[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_a3d59f43","line":2089,"in_reply_to":"dada55a8_a0a650ab","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2092,"context_line":"        mock_exec.assert_called_once_with(self.info[\u0027uuid\u0027],"},{"line_number":2093,"context_line":"                                          self.info[\u0027port\u0027],"},{"line_number":2094,"context_line":"                                          mock.ANY)"},{"line_number":2095,"context_line":"        self.assertTrue(mock_exec.called)"},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2098,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_c0d544e5","line":2095,"updated":"2016-07-21 16:35:39.000000000","message":"you don\u0027t need this since the line above already confirmed that it was called.","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2092,"context_line":"        mock_exec.assert_called_once_with(self.info[\u0027uuid\u0027],"},{"line_number":2093,"context_line":"                                          self.info[\u0027port\u0027],"},{"line_number":2094,"context_line":"                                          mock.ANY)"},{"line_number":2095,"context_line":"        self.assertTrue(mock_exec.called)"},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2098,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_23c24f85","line":2095,"in_reply_to":"dada55a8_c0d544e5","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2101,"context_line":"            error\u003d\u0027error\u0027)"},{"line_number":2102,"context_line":""},{"line_number":2103,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":2104,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2105,"context_line":"            self.assertRaises(exception.ConsoleSubprocessFailed,"},{"line_number":2106,"context_line":"                              self.driver.console.start_console,"},{"line_number":2107,"context_line":"                              task)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_23070a83","line":2104,"updated":"2016-07-21 16:35:39.000000000","message":"ditto","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2101,"context_line":"            error\u003d\u0027error\u0027)"},{"line_number":2102,"context_line":""},{"line_number":2103,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":2104,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2105,"context_line":"            self.assertRaises(exception.ConsoleSubprocessFailed,"},{"line_number":2106,"context_line":"                              self.driver.console.start_console,"},{"line_number":2107,"context_line":"                              task)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_a33c7f93","line":2104,"in_reply_to":"dada55a8_23070a83","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2104,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2105,"context_line":"            self.assertRaises(exception.ConsoleSubprocessFailed,"},{"line_number":2106,"context_line":"                              self.driver.console.start_console,"},{"line_number":2107,"context_line":"                              task)"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2110,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_63fd826d","line":2107,"updated":"2016-07-21 16:35:39.000000000","message":"should check that mock_exec was called.","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2104,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2105,"context_line":"            self.assertRaises(exception.ConsoleSubprocessFailed,"},{"line_number":2106,"context_line":"                              self.driver.console.start_console,"},{"line_number":2107,"context_line":"                              task)"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2110,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_e35957fe","line":2107,"in_reply_to":"dada55a8_63fd826d","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2135,"context_line":"        mock_pass.assert_called_once_with(mock.ANY, \u0027\\0\u0027)"},{"line_number":2136,"context_line":"        mock_exec.assert_called_once_with(self.info[\u0027uuid\u0027],"},{"line_number":2137,"context_line":"                                          self.info[\u0027port\u0027],"},{"line_number":2138,"context_line":"                                          mock.ANY)"},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"    @mock.patch.object(console_utils, \u0027stop_socat_console\u0027,"},{"line_number":2141,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_c670bc42","line":2138,"updated":"2016-07-21 16:35:39.000000000","message":"This test doesn\u0027t make sense here; it should be part of IPMIConsole. I see that it is also tested for shellinabox.\n\nHmm. I think we should reorganize the tests, since there is a new IPMIConsole class. Wondering if we can do that in a separate patch though. I\u0027ll leave it for you to decide. (Or some other reviewer to comment on.)","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2135,"context_line":"        mock_pass.assert_called_once_with(mock.ANY, \u0027\\0\u0027)"},{"line_number":2136,"context_line":"        mock_exec.assert_called_once_with(self.info[\u0027uuid\u0027],"},{"line_number":2137,"context_line":"                                          self.info[\u0027port\u0027],"},{"line_number":2138,"context_line":"                                          mock.ANY)"},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"    @mock.patch.object(console_utils, \u0027stop_socat_console\u0027,"},{"line_number":2141,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_d23e9ad9","line":2138,"in_reply_to":"dada55a8_c670bc42","updated":"2016-07-23 14:16:23.000000000","message":"You\u0027re right. this test should check whether _start_console() is called correctly, and what is done in this test should be done in other test case. Done.","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2145,"context_line":"        mock_stop.return_value \u003d None"},{"line_number":2146,"context_line":""},{"line_number":2147,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":2148,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2149,"context_line":"            self.driver.console.stop_console(task)"},{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        mock_stop.assert_called_once_with(self.info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_06bc94b9","line":2148,"updated":"2016-07-21 16:35:39.000000000","message":"ditto","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2145,"context_line":"        mock_stop.return_value \u003d None"},{"line_number":2146,"context_line":""},{"line_number":2147,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":2148,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2149,"context_line":"            self.driver.console.stop_console(task)"},{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        mock_stop.assert_called_once_with(self.info[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_bdbad76f","line":2148,"in_reply_to":"dada55a8_06bc94b9","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2149,"context_line":"            self.driver.console.stop_console(task)"},{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        mock_stop.assert_called_once_with(self.info[\u0027uuid\u0027])"},{"line_number":2152,"context_line":"        self.assertTrue(mock_stop.called)"},{"line_number":2153,"context_line":"        self.assertTrue(mock_exec.called)"},{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"    @mock.patch.object(console_utils, \u0027stop_socat_console\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_86c88456","line":2152,"updated":"2016-07-21 16:35:39.000000000","message":"no need to call this","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2149,"context_line":"            self.driver.console.stop_console(task)"},{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        mock_stop.assert_called_once_with(self.info[\u0027uuid\u0027])"},{"line_number":2152,"context_line":"        self.assertTrue(mock_stop.called)"},{"line_number":2153,"context_line":"        self.assertTrue(mock_exec.called)"},{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"    @mock.patch.object(console_utils, \u0027stop_socat_console\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_1d5a0351","line":2152,"in_reply_to":"dada55a8_86c88456","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        mock_stop.assert_called_once_with(self.info[\u0027uuid\u0027])"},{"line_number":2152,"context_line":"        self.assertTrue(mock_stop.called)"},{"line_number":2153,"context_line":"        self.assertTrue(mock_exec.called)"},{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"    @mock.patch.object(console_utils, \u0027stop_socat_console\u0027,"},{"line_number":2156,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_86cfe454","line":2153,"updated":"2016-07-21 16:35:39.000000000","message":"is it worth checking mock_exec.called_once_with() to see what parameters were used?","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        mock_stop.assert_called_once_with(self.info[\u0027uuid\u0027])"},{"line_number":2152,"context_line":"        self.assertTrue(mock_stop.called)"},{"line_number":2153,"context_line":"        self.assertTrue(mock_exec.called)"},{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"    @mock.patch.object(console_utils, \u0027stop_socat_console\u0027,"},{"line_number":2156,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_78da2d19","line":2153,"in_reply_to":"dada55a8_86cfe454","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2163,"context_line":"                              self.driver.console.stop_console,"},{"line_number":2164,"context_line":"                              task)"},{"line_number":2165,"context_line":""},{"line_number":2166,"context_line":"        mock_stop.assert_called_once_with(self.node.uuid)"},{"line_number":2167,"context_line":""},{"line_number":2168,"context_line":"    @mock.patch.object(console_utils, \u0027get_socat_console_url\u0027,"},{"line_number":2169,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_e676a004","line":2166,"updated":"2016-07-21 16:35:39.000000000","message":"don\u0027t you want to check to see if IPMISocatConsole._exec_stop_console() was called or not called?\n\nAlso, what about checking (or mocking) ironic_utils.unlink_without_raise()?","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2163,"context_line":"                              self.driver.console.stop_console,"},{"line_number":2164,"context_line":"                              task)"},{"line_number":2165,"context_line":""},{"line_number":2166,"context_line":"        mock_stop.assert_called_once_with(self.node.uuid)"},{"line_number":2167,"context_line":""},{"line_number":2168,"context_line":"    @mock.patch.object(console_utils, \u0027get_socat_console_url\u0027,"},{"line_number":2169,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_3277ff03","line":2166,"in_reply_to":"dada55a8_e676a004","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2167,"context_line":""},{"line_number":2168,"context_line":"    @mock.patch.object(console_utils, \u0027get_socat_console_url\u0027,"},{"line_number":2169,"context_line":"                       autospec\u003dTrue)"},{"line_number":2170,"context_line":"    def test_get_console(self, mock_exec):"},{"line_number":2171,"context_line":"        url \u003d \u0027tcp://localhost:4201\u0027"},{"line_number":2172,"context_line":"        mock_exec.return_value \u003d url"},{"line_number":2173,"context_line":"        expected \u003d {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_66d0f0c9","line":2170,"updated":"2016-07-21 16:35:39.000000000","message":"I\u0027d prefer you call this something else, mock_exec doesn\u0027t really reflect the object it is mocking.","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2167,"context_line":""},{"line_number":2168,"context_line":"    @mock.patch.object(console_utils, \u0027get_socat_console_url\u0027,"},{"line_number":2169,"context_line":"                       autospec\u003dTrue)"},{"line_number":2170,"context_line":"    def test_get_console(self, mock_exec):"},{"line_number":2171,"context_line":"        url \u003d \u0027tcp://localhost:4201\u0027"},{"line_number":2172,"context_line":"        mock_exec.return_value \u003d url"},{"line_number":2173,"context_line":"        expected \u003d {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_b2af6f7c","line":2170,"in_reply_to":"dada55a8_66d0f0c9","updated":"2016-07-23 14:16:23.000000000","message":"Sorry, I can\u0027t understand what you say. I think this tests whether get_console works correctly, and I copied this from shellinabox\u0027s one.","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"        expected \u003d {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"},{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":2176,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2177,"context_line":"            console_info \u003d self.driver.console.get_console(task)"},{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"        self.assertEqual(expected, console_info)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_a6578856","line":2176,"updated":"2016-07-21 16:35:39.000000000","message":"ditto","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"        expected \u003d {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"},{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"        with task_manager.acquire(self.context,"},{"line_number":2176,"context_line":"                                  self.node[\u0027uuid\u0027]) as task:"},{"line_number":2177,"context_line":"            console_info \u003d self.driver.console.get_console(task)"},{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"        self.assertEqual(expected, console_info)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_92b86be7","line":2176,"in_reply_to":"dada55a8_a6578856","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2bef444f412ed389354512b093e93d0e3b922a1c","unresolved":false,"context_lines":[{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"        self.assertEqual(expected, console_info)"},{"line_number":2180,"context_line":"        mock_exec.assert_called_once_with(self.info[\u0027port\u0027])"},{"line_number":2181,"context_line":"        self.assertTrue(mock_exec.called)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_669e3008","line":2181,"updated":"2016-07-21 16:35:39.000000000","message":"this isn\u0027t needed.","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f881e6303ac254bc4d7a2aa70bebe38afacfac45","unresolved":false,"context_lines":[{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"        self.assertEqual(expected, console_info)"},{"line_number":2180,"context_line":"        mock_exec.assert_called_once_with(self.info[\u0027port\u0027])"},{"line_number":2181,"context_line":"        self.assertTrue(mock_exec.called)"}],"source_content_type":"text/x-python","patch_set":27,"id":"dada55a8_b2b3ef09","line":2181,"in_reply_to":"dada55a8_669e3008","updated":"2016-07-23 14:16:23.000000000","message":"Done","commit_id":"6423152ac7b8b6d60e81ab87afe4856aca8f699a"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":194,"context_line":"            ipmi.IPMISocatConsole()"},{"line_number":195,"context_line":"            mock_support.assert_called_with(mock.ANY)"},{"line_number":196,"context_line":"            self.assertFalse(mock_check_dir.call_count)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"@mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_90e7b511","line":196,"updated":"2016-07-25 04:08:15.000000000","message":"Should be self.assertFalse(mock_check_dir.called) or mock_check_dir.assert_not_called()","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":194,"context_line":"            ipmi.IPMISocatConsole()"},{"line_number":195,"context_line":"            mock_support.assert_called_with(mock.ANY)"},{"line_number":196,"context_line":"            self.assertFalse(mock_check_dir.call_count)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"@mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_0ebf2261","line":196,"in_reply_to":"dada55a8_90e7b511","updated":"2016-07-25 07:40:56.000000000","message":"I\u0027ve got a comment from Ruby and I\u0027m not sure which is better.\nhttps://review.openstack.org/#/c/293873/27/ironic/tests/unit/drivers/modules/test_ipmitool.py@195","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"    @mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"},{"line_number":1190,"context_line":"    @mock.patch.object(ipmi, \u0027_make_password_file\u0027, _make_password_file_stub)"},{"line_number":1191,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1192,"context_line":"    def test__exec_ipmitool_with_check_exit_code(self, mock_exec,"},{"line_number":1193,"context_line":"                                                 mock_support, mock_sleep):"},{"line_number":1194,"context_line":"        args \u003d ["},{"line_number":1195,"context_line":"            \u0027ipmitool\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_70c96179","line":1192,"updated":"2016-07-25 04:08:15.000000000","message":"I know you copied the code from another test function, but the names seem not reasonable. Maybe some functions above should be updated in another change set.\nmock_support -\u003e mock_make or mock_make_pwfile (maybe)\nmock_sleep -\u003e mock_supported","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":1189,"context_line":"    @mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"},{"line_number":1190,"context_line":"    @mock.patch.object(ipmi, \u0027_make_password_file\u0027, _make_password_file_stub)"},{"line_number":1191,"context_line":"    @mock.patch.object(utils, \u0027execute\u0027, autospec\u003dTrue)"},{"line_number":1192,"context_line":"    def test__exec_ipmitool_with_check_exit_code(self, mock_exec,"},{"line_number":1193,"context_line":"                                                 mock_support, mock_sleep):"},{"line_number":1194,"context_line":"        args \u003d ["},{"line_number":1195,"context_line":"            \u0027ipmitool\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_4e70fadc","line":1192,"in_reply_to":"dada55a8_70c96179","updated":"2016-07-25 07:40:56.000000000","message":"Nice catch, thanks. done.","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":1602,"context_line":"                              task.driver.console.validate, task)"},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    @mock.patch.object(ipmi.IPMIConsole, \u0027_start_console\u0027, autospec\u003dTrue)"},{"line_number":1605,"context_line":"    def test_start_console(self, mock_exec):"},{"line_number":1606,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_b06759b6","line":1605,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":1602,"context_line":"                              task.driver.console.validate, task)"},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    @mock.patch.object(ipmi.IPMIConsole, \u0027_start_console\u0027, autospec\u003dTrue)"},{"line_number":1605,"context_line":"    def test_start_console(self, mock_exec):"},{"line_number":1606,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_0e1ba281","line":1605,"in_reply_to":"dada55a8_b06759b6","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"    @mock.patch.object(console_utils, \u0027start_shellinabox_console\u0027,"},{"line_number":1617,"context_line":"                       autospec\u003dTrue)"},{"line_number":1618,"context_line":"    def test__start_console(self, mock_exec):"},{"line_number":1619,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":1620,"context_line":""},{"line_number":1621,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_500ffde0","line":1618,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start or mock_start_shbox (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":1615,"context_line":""},{"line_number":1616,"context_line":"    @mock.patch.object(console_utils, \u0027start_shellinabox_console\u0027,"},{"line_number":1617,"context_line":"                       autospec\u003dTrue)"},{"line_number":1618,"context_line":"    def test__start_console(self, mock_exec):"},{"line_number":1619,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":1620,"context_line":""},{"line_number":1621,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_4e159a47","line":1618,"in_reply_to":"dada55a8_500ffde0","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":1630,"context_line":""},{"line_number":1631,"context_line":"    @mock.patch.object(console_utils, \u0027start_shellinabox_console\u0027,"},{"line_number":1632,"context_line":"                       autospec\u003dTrue)"},{"line_number":1633,"context_line":"    def test__start_console_fail(self, mock_exec):"},{"line_number":1634,"context_line":"        mock_exec.side_effect \u003d exception.ConsoleSubprocessFailed("},{"line_number":1635,"context_line":"            error\u003d\u0027error\u0027)"},{"line_number":1636,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_50b09ddd","line":1633,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start or mock_start_shbox (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":1630,"context_line":""},{"line_number":1631,"context_line":"    @mock.patch.object(console_utils, \u0027start_shellinabox_console\u0027,"},{"line_number":1632,"context_line":"                       autospec\u003dTrue)"},{"line_number":1633,"context_line":"    def test__start_console_fail(self, mock_exec):"},{"line_number":1634,"context_line":"        mock_exec.side_effect \u003d exception.ConsoleSubprocessFailed("},{"line_number":1635,"context_line":"            error\u003d\u0027error\u0027)"},{"line_number":1636,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_29ff8002","line":1633,"in_reply_to":"dada55a8_50b09ddd","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":1644,"context_line":""},{"line_number":1645,"context_line":"    @mock.patch.object(console_utils, \u0027start_shellinabox_console\u0027,"},{"line_number":1646,"context_line":"                       autospec\u003dTrue)"},{"line_number":1647,"context_line":"    def test__start_console_fail_nodir(self, mock_exec):"},{"line_number":1648,"context_line":"        mock_exec.side_effect \u003d exception.ConsoleError()"},{"line_number":1649,"context_line":""},{"line_number":1650,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_70c5e13b","line":1647,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start or mock_start_shbox (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":1644,"context_line":""},{"line_number":1645,"context_line":"    @mock.patch.object(console_utils, \u0027start_shellinabox_console\u0027,"},{"line_number":1646,"context_line":"                       autospec\u003dTrue)"},{"line_number":1647,"context_line":"    def test__start_console_fail_nodir(self, mock_exec):"},{"line_number":1648,"context_line":"        mock_exec.side_effect \u003d exception.ConsoleError()"},{"line_number":1649,"context_line":""},{"line_number":1650,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_490c743b","line":1647,"in_reply_to":"dada55a8_70c5e13b","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":1660,"context_line":"                       autospec\u003dTrue)"},{"line_number":1661,"context_line":"    @mock.patch.object(console_utils, \u0027start_shellinabox_console\u0027,"},{"line_number":1662,"context_line":"                       autospec\u003dTrue)"},{"line_number":1663,"context_line":"    def test__start_console_empty_password(self, mock_exec, mock_pass):"},{"line_number":1664,"context_line":"        driver_info \u003d self.node.driver_info"},{"line_number":1665,"context_line":"        del driver_info[\u0027ipmi_password\u0027]"},{"line_number":1666,"context_line":"        self.node.driver_info \u003d driver_info"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_b0bf59a9","line":1663,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start or mock_start_shbox (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":1660,"context_line":"                       autospec\u003dTrue)"},{"line_number":1661,"context_line":"    @mock.patch.object(console_utils, \u0027start_shellinabox_console\u0027,"},{"line_number":1662,"context_line":"                       autospec\u003dTrue)"},{"line_number":1663,"context_line":"    def test__start_console_empty_password(self, mock_exec, mock_pass):"},{"line_number":1664,"context_line":"        driver_info \u003d self.node.driver_info"},{"line_number":1665,"context_line":"        del driver_info[\u0027ipmi_password\u0027]"},{"line_number":1666,"context_line":"        self.node.driver_info \u003d driver_info"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_a913705b","line":1663,"in_reply_to":"dada55a8_b0bf59a9","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":1679,"context_line":""},{"line_number":1680,"context_line":"    @mock.patch.object(console_utils, \u0027stop_shellinabox_console\u0027,"},{"line_number":1681,"context_line":"                       autospec\u003dTrue)"},{"line_number":1682,"context_line":"    def test_stop_console(self, mock_exec):"},{"line_number":1683,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_30ea49ad","line":1682,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_stop or mock_stop_shbox (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":1679,"context_line":""},{"line_number":1680,"context_line":"    @mock.patch.object(console_utils, \u0027stop_shellinabox_console\u0027,"},{"line_number":1681,"context_line":"                       autospec\u003dTrue)"},{"line_number":1682,"context_line":"    def test_stop_console(self, mock_exec):"},{"line_number":1683,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_292660ba","line":1682,"in_reply_to":"dada55a8_30ea49ad","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":1703,"context_line":""},{"line_number":1704,"context_line":"    @mock.patch.object(console_utils, \u0027get_shellinabox_console_url\u0027,"},{"line_number":1705,"context_line":"                       autospec\u003dTrue)"},{"line_number":1706,"context_line":"    def test_get_console(self, mock_exec):"},{"line_number":1707,"context_line":"        url \u003d \u0027http://localhost:4201\u0027"},{"line_number":1708,"context_line":"        mock_exec.return_value \u003d url"},{"line_number":1709,"context_line":"        expected \u003d {\u0027type\u0027: \u0027shellinabox\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_70ccc161","line":1706,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_get or mock_get_url (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":1703,"context_line":""},{"line_number":1704,"context_line":"    @mock.patch.object(console_utils, \u0027get_shellinabox_console_url\u0027,"},{"line_number":1705,"context_line":"                       autospec\u003dTrue)"},{"line_number":1706,"context_line":"    def test_get_console(self, mock_exec):"},{"line_number":1707,"context_line":"        url \u003d \u0027http://localhost:4201\u0027"},{"line_number":1708,"context_line":"        mock_exec.return_value \u003d url"},{"line_number":1709,"context_line":"        expected \u003d {\u0027type\u0027: \u0027shellinabox\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_8935ccdc","line":1706,"in_reply_to":"dada55a8_70ccc161","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":2133,"context_line":"        mock_start.assert_called_once_with("},{"line_number":2134,"context_line":"            self.driver.console, driver_info,"},{"line_number":2135,"context_line":"            console_utils.start_socat_console)"},{"line_number":2136,"context_line":"        self.assertTrue(mock_start.called)"},{"line_number":2137,"context_line":""},{"line_number":2138,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2139,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_1004657c","line":2136,"updated":"2016-07-25 04:08:15.000000000","message":"This is not needed","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":2133,"context_line":"        mock_start.assert_called_once_with("},{"line_number":2134,"context_line":"            self.driver.console, driver_info,"},{"line_number":2135,"context_line":"            console_utils.start_socat_console)"},{"line_number":2136,"context_line":"        self.assertTrue(mock_start.called)"},{"line_number":2137,"context_line":""},{"line_number":2138,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2139,"context_line":"                       autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_0950bc09","line":2136,"in_reply_to":"dada55a8_1004657c","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":2137,"context_line":""},{"line_number":2138,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2139,"context_line":"                       autospec\u003dTrue)"},{"line_number":2140,"context_line":"    def test__start_console(self, mock_exec):"},{"line_number":2141,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":2142,"context_line":""},{"line_number":2143,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_50fedd6b","line":2140,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":2137,"context_line":""},{"line_number":2138,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2139,"context_line":"                       autospec\u003dTrue)"},{"line_number":2140,"context_line":"    def test__start_console(self, mock_exec):"},{"line_number":2141,"context_line":"        mock_exec.return_value \u003d None"},{"line_number":2142,"context_line":""},{"line_number":2143,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_c946a44e","line":2140,"in_reply_to":"dada55a8_50fedd6b","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2154,"context_line":"                       autospec\u003dTrue)"},{"line_number":2155,"context_line":"    def test__start_console_fail(self, mock_exec):"},{"line_number":2156,"context_line":"        mock_exec.side_effect \u003d exception.ConsoleSubprocessFailed("},{"line_number":2157,"context_line":"            error\u003d\u0027error\u0027)"},{"line_number":2158,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_90f8557e","line":2155,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2154,"context_line":"                       autospec\u003dTrue)"},{"line_number":2155,"context_line":"    def test__start_console_fail(self, mock_exec):"},{"line_number":2156,"context_line":"        mock_exec.side_effect \u003d exception.ConsoleSubprocessFailed("},{"line_number":2157,"context_line":"            error\u003d\u0027error\u0027)"},{"line_number":2158,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_696e98ca","line":2155,"in_reply_to":"dada55a8_90f8557e","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":2170,"context_line":""},{"line_number":2171,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2172,"context_line":"                       autospec\u003dTrue)"},{"line_number":2173,"context_line":"    def test__start_console_fail_nodir(self, mock_exec):"},{"line_number":2174,"context_line":"        mock_exec.side_effect \u003d exception.ConsoleError()"},{"line_number":2175,"context_line":""},{"line_number":2176,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_70f321a0","line":2173,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":2170,"context_line":""},{"line_number":2171,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2172,"context_line":"                       autospec\u003dTrue)"},{"line_number":2173,"context_line":"    def test__start_console_fail_nodir(self, mock_exec):"},{"line_number":2174,"context_line":"        mock_exec.side_effect \u003d exception.ConsoleError()"},{"line_number":2175,"context_line":""},{"line_number":2176,"context_line":"        with task_manager.acquire(self.context,"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_c95d0417","line":2173,"in_reply_to":"dada55a8_70f321a0","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":2186,"context_line":"                       autospec\u003dTrue)"},{"line_number":2187,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2188,"context_line":"                       autospec\u003dTrue)"},{"line_number":2189,"context_line":"    def test__start_console_empty_password(self, mock_exec, mock_pass):"},{"line_number":2190,"context_line":"        driver_info \u003d self.node.driver_info"},{"line_number":2191,"context_line":"        del driver_info[\u0027ipmi_password\u0027]"},{"line_number":2192,"context_line":"        self.node.driver_info \u003d driver_info"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_102bc5ec","line":2189,"updated":"2016-07-25 04:08:15.000000000","message":"mock_exec -\u003e mock_start (maybe)","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":2186,"context_line":"                       autospec\u003dTrue)"},{"line_number":2187,"context_line":"    @mock.patch.object(console_utils, \u0027start_socat_console\u0027,"},{"line_number":2188,"context_line":"                       autospec\u003dTrue)"},{"line_number":2189,"context_line":"    def test__start_console_empty_password(self, mock_exec, mock_pass):"},{"line_number":2190,"context_line":"        driver_info \u003d self.node.driver_info"},{"line_number":2191,"context_line":"        del driver_info[\u0027ipmi_password\u0027]"},{"line_number":2192,"context_line":"        self.node.driver_info \u003d driver_info"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_099efcb7","line":2189,"in_reply_to":"dada55a8_102bc5ec","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":2237,"context_line":"        mock_stop.assert_called_once_with(self.node.uuid)"},{"line_number":2238,"context_line":"        mock_unlink.assert_called_once_with("},{"line_number":2239,"context_line":"            ipmi._console_pwfile_path(self.node.uuid))"},{"line_number":2240,"context_line":"        self.assertFalse(mock_exec_stop.call_count)"},{"line_number":2241,"context_line":""},{"line_number":2242,"context_line":"    @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)"},{"line_number":2243,"context_line":"    def test__exec_stop_console(self, mock_exec):"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_50dd3d41","line":2240,"updated":"2016-07-25 04:08:15.000000000","message":"Should be self.assertFalse(mock_exec_stop.called) or mock_exec_stop.assert_not_called()","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":2237,"context_line":"        mock_stop.assert_called_once_with(self.node.uuid)"},{"line_number":2238,"context_line":"        mock_unlink.assert_called_once_with("},{"line_number":2239,"context_line":"            ipmi._console_pwfile_path(self.node.uuid))"},{"line_number":2240,"context_line":"        self.assertFalse(mock_exec_stop.call_count)"},{"line_number":2241,"context_line":""},{"line_number":2242,"context_line":"    @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)"},{"line_number":2243,"context_line":"    def test__exec_stop_console(self, mock_exec):"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_69f3380b","line":2240,"in_reply_to":"dada55a8_50dd3d41","updated":"2016-07-25 07:40:56.000000000","message":"ditto","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"88d6230366db91775d76db2afd343691f8893b92","unresolved":false,"context_lines":[{"line_number":2252,"context_line":""},{"line_number":2253,"context_line":"    @mock.patch.object(console_utils, \u0027get_socat_console_url\u0027,"},{"line_number":2254,"context_line":"                       autospec\u003dTrue)"},{"line_number":2255,"context_line":"    def test_get_console(self, mock_exec):"},{"line_number":2256,"context_line":"        url \u003d \u0027tcp://localhost:4201\u0027"},{"line_number":2257,"context_line":"        mock_exec.return_value \u003d url"},{"line_number":2258,"context_line":"        expected \u003d {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_b01bd9c9","line":2255,"updated":"2016-07-25 04:08:15.000000000","message":"As Ruby suggested you change the name to a more meaningful one, I suggest you use mock_get_url.","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"87bd228a0bb80c55e3aeca90e3fa2625d0a42f92","unresolved":false,"context_lines":[{"line_number":2252,"context_line":""},{"line_number":2253,"context_line":"    @mock.patch.object(console_utils, \u0027get_socat_console_url\u0027,"},{"line_number":2254,"context_line":"                       autospec\u003dTrue)"},{"line_number":2255,"context_line":"    def test_get_console(self, mock_exec):"},{"line_number":2256,"context_line":"        url \u003d \u0027tcp://localhost:4201\u0027"},{"line_number":2257,"context_line":"        mock_exec.return_value \u003d url"},{"line_number":2258,"context_line":"        expected \u003d {\u0027type\u0027: \u0027socat\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":28,"id":"dada55a8_89d82c81","line":2255,"in_reply_to":"dada55a8_b01bd9c9","updated":"2016-07-25 07:40:56.000000000","message":"Done","commit_id":"08ce6363dde673d6d99daad534550a3b1ca7bd45"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437770ed5174a8a3c4fcf551fd64d5d9c0cc8a48","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":110,"context_line":"        ipmi.IPMIPower()"},{"line_number":111,"context_line":"        mock_support.assert_called_with(mock.ANY)"},{"line_number":112,"context_line":"        self.assertFalse(mock_check_dir.called)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"},{"line_number":115,"context_line":"    @mock.patch.object(utils, \u0027check_dir\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_1355784f","line":112,"updated":"2016-07-25 14:52:48.000000000","message":"This change looks unrelated, I think it\u0027s actually good to assert how many times something was called instead of only called.","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2eb13432e92ed8818671e9cb001dee7512ab6388","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":110,"context_line":"        ipmi.IPMIPower()"},{"line_number":111,"context_line":"        mock_support.assert_called_with(mock.ANY)"},{"line_number":112,"context_line":"        self.assertFalse(mock_check_dir.called)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"},{"line_number":115,"context_line":"    @mock.patch.object(utils, \u0027check_dir\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_679cd75d","line":112,"in_reply_to":"dada55a8_1355784f","updated":"2016-07-25 22:16:46.000000000","message":"I think this is because I commented on this in one of the tests that was added. Which had probably been copied from the existing tests.\n\nIf a method wasn\u0027t called, we seem to use the assertFalse(.called) pattern instead of seeing that assertEqual(0, .call_count)","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437770ed5174a8a3c4fcf551fd64d5d9c0cc8a48","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        ipmi.IPMIManagement()"},{"line_number":133,"context_line":"        mock_support.assert_called_with(mock.ANY)"},{"line_number":134,"context_line":"        self.assertFalse(mock_check_dir.called)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"},{"line_number":137,"context_line":"    @mock.patch.object(utils, \u0027check_dir\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_534ff0bc","line":134,"updated":"2016-07-25 14:52:48.000000000","message":"ditto","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437770ed5174a8a3c4fcf551fd64d5d9c0cc8a48","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":152,"context_line":"        ipmi.VendorPassthru()"},{"line_number":153,"context_line":"        mock_support.assert_called_with(mock.ANY)"},{"line_number":154,"context_line":"        self.assertFalse(mock_check_dir.called)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"},{"line_number":157,"context_line":"    @mock.patch.object(utils, \u0027check_dir\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_93c7a811","line":154,"updated":"2016-07-25 14:52:48.000000000","message":"ditto","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437770ed5174a8a3c4fcf551fd64d5d9c0cc8a48","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":194,"context_line":"            ipmi.IPMISocatConsole()"},{"line_number":195,"context_line":"            mock_support.assert_called_with(mock.ANY)"},{"line_number":196,"context_line":"            self.assertFalse(mock_check_dir.call_count)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"@mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_13273813","line":196,"updated":"2016-07-25 14:52:48.000000000","message":"nit: s/call_count/called\n\nOr as it was before:\n\nself.assertEqual(0, mock_check_dir.call_count)","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"c22eb2a4db6c2ae8fc0320a6b8d3ceadb49962de","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            ipmi.TMP_DIR_CHECKED \u003d True"},{"line_number":194,"context_line":"            ipmi.IPMISocatConsole()"},{"line_number":195,"context_line":"            mock_support.assert_called_with(mock.ANY)"},{"line_number":196,"context_line":"            self.assertFalse(mock_check_dir.call_count)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"@mock.patch.object(ipmi, \u0027_is_option_supported\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_db9d6167","line":196,"in_reply_to":"dada55a8_13273813","updated":"2016-08-01 08:31:43.000000000","message":"Done","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"da366d580c3b8e9b423cf83008a10e30a49c3bfb","unresolved":false,"context_lines":[{"line_number":2236,"context_line":"        mock_stop.assert_called_once_with(self.node.uuid)"},{"line_number":2237,"context_line":"        mock_unlink.assert_called_once_with("},{"line_number":2238,"context_line":"            ipmi._console_pwfile_path(self.node.uuid))"},{"line_number":2239,"context_line":"        self.assertFalse(mock_exec_stop.call_count)"},{"line_number":2240,"context_line":""},{"line_number":2241,"context_line":"    @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)"},{"line_number":2242,"context_line":"    def test__exec_stop_console(self, mock_exec):"}],"source_content_type":"text/x-python","patch_set":29,"id":"dada55a8_97be79fd","line":2239,"updated":"2016-07-25 13:30:39.000000000","message":"s/call_count/called/","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"c22eb2a4db6c2ae8fc0320a6b8d3ceadb49962de","unresolved":false,"context_lines":[{"line_number":2236,"context_line":"        mock_stop.assert_called_once_with(self.node.uuid)"},{"line_number":2237,"context_line":"        mock_unlink.assert_called_once_with("},{"line_number":2238,"context_line":"            ipmi._console_pwfile_path(self.node.uuid))"},{"line_number":2239,"context_line":"        self.assertFalse(mock_exec_stop.call_count)"},{"line_number":2240,"context_line":""},{"line_number":2241,"context_line":"    @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)"},{"line_number":2242,"context_line":"    def test__exec_stop_console(self, mock_exec):"}],"source_content_type":"text/x-python","patch_set":29,"id":"bacf61ea_db744137","line":2239,"in_reply_to":"dada55a8_97be79fd","updated":"2016-08-01 08:31:43.000000000","message":"Done","commit_id":"857372a2269cdd0f8a1ae5b9e9f6e0ee193f01be"}],"releasenotes/notes/add-socat-console-ipmitool-ab4402ec976c5c96.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0138ed68d7925e08cf64d9d68e21cfe999f9fe2b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds socat serial console support to IPMItool."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_4b6ffc2a","line":3,"updated":"2016-07-06 15:07:52.000000000","message":"perhaps citing that two new drivers were added?","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3edafbb920173ee230392b20532835cbf5bda79c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds socat serial console support to IPMItool."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_e159a936","line":3,"in_reply_to":"1aa78d24_4b6ffc2a","updated":"2016-07-06 15:26:56.000000000","message":"+1","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f02371c65251b69deba4360dc1c57cd2f56f390e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds socat serial console support to IPMItool."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1aa78d24_9f50de0c","line":3,"in_reply_to":"1aa78d24_4b6ffc2a","updated":"2016-07-07 02:59:42.000000000","message":"Done separately in https://review.openstack.org/338658","commit_id":"cbe51c6a10d1fa68c7082af67827d8c0d8967fe3"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9684feb34f57a8ac9f1982c8d90287b17a033276","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds socat serial console support to IPMItool."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1aa78d24_8094ba8c","line":3,"updated":"2016-07-13 23:17:54.000000000","message":"I feel like this could be improved - maybe \"Adds support for socat-based serial console to ipmitool-based drivers. These are available by using the agent_ipmitool_socat and pxe_ipmitool_socat drivers.\"","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"},{"author":{"_account_id":7882,"name":"Yuiko Takada Mori","email":"yuiko-mori@nec.com","username":"YuikoTakada"},"change_message_id":"f01e6d73702d3e773bde925ae462e520329d6758","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds socat serial console support to IPMItool."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1aa78d24_f2fc6c0e","line":3,"in_reply_to":"1aa78d24_8094ba8c","updated":"2016-07-14 02:58:11.000000000","message":"Done","commit_id":"d8d695e8614c8d93b17f8d567c26ff8a6483463e"}]}
