)]}'
{"ironic/drivers/modules/agent_client.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"992d4258811ffdb2c0989d8ccfbc0cc237d792a3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                     \u0027%(node)s. Error: %(error)s\u0027) %"},{"line_number":76,"context_line":"                   {\u0027method\u0027: method, \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":77,"context_line":"            LOG.error(msg)"},{"line_number":78,"context_line":"            raise exception.IronicException(msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # TODO(russellhaering): real error handling"},{"line_number":81,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_7ec99bab","line":78,"updated":"2016-03-18 16:59:30.000000000","message":"Do we want to make a specific exception for agent communication errors?","commit_id":"ea238dcffa2a415c2ac40ee0f42977b1bfc0b1a1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a8dcd223eb571148215bde641bb48f833c65e9ce","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                     \u0027%(node)s. Error: %(error)s\u0027) %"},{"line_number":76,"context_line":"                   {\u0027method\u0027: method, \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":77,"context_line":"            LOG.error(msg)"},{"line_number":78,"context_line":"            raise exception.IronicException(msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # TODO(russellhaering): real error handling"},{"line_number":81,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_e94a1754","line":78,"in_reply_to":"1af94dfe_7eafdb7c","updated":"2016-03-18 17:12:42.000000000","message":"Actually, since we don\u0027t handle _command() anywhere I believe we don\u0027t need an specific exception.\n\nLet\u0027s see what other reviewers think about it.","commit_id":"ea238dcffa2a415c2ac40ee0f42977b1bfc0b1a1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fe6bd1b5b0b33fb55763a147df1144182bd0cb0c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                     \u0027%(node)s. Error: %(error)s\u0027) %"},{"line_number":76,"context_line":"                   {\u0027method\u0027: method, \u0027node\u0027: node.uuid, \u0027error\u0027: e})"},{"line_number":77,"context_line":"            LOG.error(msg)"},{"line_number":78,"context_line":"            raise exception.IronicException(msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # TODO(russellhaering): real error handling"},{"line_number":81,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_7eafdb7c","line":78,"in_reply_to":"1af94dfe_7ec99bab","updated":"2016-03-18 17:09:37.000000000","message":"+1\n\nAgentCommandError perhaps ?","commit_id":"ea238dcffa2a415c2ac40ee0f42977b1bfc0b1a1"}],"ironic/tests/unit/drivers/modules/test_agent_client.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b22d54704508656b2a3d109c651de3aa80f13594","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.client._get_command_url(self.node)"},{"line_number":128,"context_line":"        self.client._get_command_body(method, params)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        e \u003d self.assertRaises(exception.IronicException,"},{"line_number":131,"context_line":"                              self.client._command,"},{"line_number":132,"context_line":"                              self.node, method, params)"},{"line_number":133,"context_line":"        self.assertEqual(\u0027Error invoking agent command %(method)s for node \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_2ad6ad27","line":130,"updated":"2016-03-18 18:21:24.000000000","message":"assertRaisesRegex?","commit_id":"ea238dcffa2a415c2ac40ee0f42977b1bfc0b1a1"}]}